text:
Implements the TRIM(X) function

Adds the TRIM(X) function to the functions available in sqlpp11.
Roland, please check :-)
Juan Dent

Hi Juan,
Thanks for the pull request!
As you see there seems to be a  conflict in the parameter list. Not sure what happened there, yet.
I suggest, that you do not mix the two things (trim and parameter list). It would be simpler to handle those two things in separate pull requests.
Regarding the trim function: I would omit the two parameter version completely for the time being.

I agree - forget the parameter_list, it was something I had done and it stayed uncommitted. Not sure how to remove it from the pull request?

You can do a git reset --soft to where you started with your commits, drop the parameter-list change, and create a new pull request.
Again, github has cool documentation and a bit of googling will help you find the best way to do it (I am rarely creating pull requests and therefore not the best direct source of knowledge for this).

Closing this as outdated due to #205

authors: juandent rbock


text:
Document nested fields usage

Hello,
I am trying to retrieve values from a table which contains values that refer to other tables (e.g. alm_hardware table has a company field which refers to the core_company table)
By naively using String() field, I get a sys_id value, which means I need to dump the corresponding table to get the corresponding value:
class Company(aiosnow.TableModel):
    sys_id = aiosnow.fields.String(is_primary=True)
    name = aiosnow.fields.String()

class Hardware(aiosnow.TableModel):
    sys_id = aiosnow.fields.String(is_primary=True)
    asset_tag = aiosnow.fields.String()
    company = aiosnow.fields.String()

My guess is that I should use nested fields, but I cannot figure out how to do this with aiosnow.
Also, we could use the displayvalue=True instead of the displayvalue=all in the query, but I didn't find any way to do this either.
Could you document/explain ?

I realize this isn't included in the recently reworked documentation, so thanks for reporting :)
Anyway..
If you're only interested in sys_id and name of core_company, simply use a fields.StringMap; it validates and maps those fields to key and value respectively. Example:
https://github.com/rbw/aiosnow/blob/99e057da9d6f2677a92805b41ac436d05355b9c8/examples/table/create.py#L15
If you want aiosnow to fully resolve the related core_company object, you'll need to use a nested schema, which will enable querying by fields of that schema and automatically fetch referenced objects on request, with cache support.
Here's an example of nested schema use:
https://github.com/rbw/aiosnow/blob/master/examples/table/read/nested.py

Also, we could use the displayvalue=True instead of the displayvalue=all in the query, but I didn't find any way to do this either.

aiosnow controls the displayvalue parameter depending on if mappings or nested schemas are used in the model declaration.

Thank you for your help! My goal by opening this issue was also to help future newcomers that may want to do the same results.
To summarised, this gives us 4 solutions:
# case 1: return the sys-id of the company
class Hardware(aiosnow.TableModel):
    sys_id = aiosnow.fields.String(is_primary=True)
    company = aiosnow.fields.String()

# case 2: return the display name
from aiosnow.models.common.schema.helpers import Pluck
class Hardware(aiosnow.TableModel):
    sys_id = aiosnow.fields.String(is_primary=True)
    company = aiosnow.fields.String(pluck=Pluck.DISPLAY_VALUE)

# case 3: return the sys_id, display_name as key, value
class Hardware(aiosnow.TableModel):
    sys_id = aiosnow.fields.String(is_primary=True)
    company = aiosnow.fields.StringMap()

# case 4: do a nested table => get any fields from the company table
from aiosnow.models.common.schema import ModelSchema
class Company(ModelSchema):
    name = aiosnow.fields.String()

class Hardware(aiosnow.TableModel):
    sys_id = aiosnow.fields.String(is_primary=True)
    company = Company

Now that I get how it works, I tried to do filtering on those fields, e.g:
async with Hardware(servicenow_client, table_name="alm_hardware") as hardware:
        hardware_items = await hardware.get(Hardware.company.in_list(['ACME UK', 'ACME US']))

However I couldn't get it to work using company names (using case 2). Does only  sys-id works for filtering in this case ?

Sorry for the late response.
Yep, you covered all possible solutions to this problem. I'll try to include this in some form in the docs, thanks.
It should be Hardware.company.name.in_list(['ACME UK', 'ACME US'])), note the missing name in your example.

Thank you for all the detailed answers.

source: gharchive/issue

authors: netixx rbw

repo: rbw/aiosnow

license: MIT

license_type: permissive

license_source: github-api


text:
Module not found: Can't resolve 'rt/styles/Base'

When trying to run the application I'm getting this error
I tried to set an module-resolver for the rt but still error
{
        test: /\.(js|jsx)$/,
        include: paths.appSrc,
        loader: require.resolve('babel-loader'),
        exclude: /node_modules/,
        query: {
          presets: ['@babel/preset-env', '@babel/preset-react'],
          plugins: [
            ['import', { libraryName: 'antd', style: true }],
            ['@babel/plugin-proposal-class-properties', { loose: true }],
            [
              'module-resolver',
              {
                rt: ['./src']
              }
            ]
          ],
          cacheDirectory: true
        }
      },

using import Board from 'react-trello/dist' should solve until they fix

This is a duplicate of #359

Closed in https://github.com/rcdexta/react-trello/releases/tag/v2.2.5

authors: jprosevear marciowelben rcdexta

repo: rcdexta/react-trello

license: mit

license_source: bigquery


text:
What about Deno.connectTls ?

Connect is great but what about connectTls? Can that work too?

It would work if you had a proxy server that supports TLS connections, but using connectTls would only encrypt data between the client and the proxy server. Between the proxy and the target server the data would be unencrypted. Not sure if there is a use case for this.
From what I can tell, if you want to encrypt data between the client and the target server that is done outside the SOCKS protocol. In the case of this library that would mean reimplementing the TLS protocol on top of Deno.connect which I think is a bad idea.
FYI my use case when writing this library was running some program (SSH, Wireguard, etc) locally that exposes a SOCKS interface. Since the SOCKs server is running locally it doesn't matter at all that TLS is not used.

I'm trying to connect to a kafka server, I'm trying to use a socks proxy to access it but no luck so far. I have this working for the database but for some reason can't get it to work for kafka.
The kafka client is using Deno.connectTls but simply setting HTTP_PROXY or HTTPS_PROXY seems to not be sufficient. So I tried this library to replace the socketFactory maybe I'll just try doing the non tls connection...

I have this working for the database but for some reason can't get it to work for kafka.

Ah, it seems like the database probably accepts plain TCP connections but Kafka expects TCP + TLS. Unfortunately this is the use case that would require either Deno adding support for TCP proxies (then this library is no longer needed), or reimplementing TLS in this library.

maybe I'll just try doing the non tls connection...

That should work with the current state of this library 🤞

The connection is established but it seems to just close instantly, I couldn't figure it out. Going to try a different approach. Thanks for the help.

authors: justinmchase rclarey


text:
Date input parsing

The date input needs to be able to take all the various forms of dates that can be produced.
Additionally we should have a fallback date picker on necessary platforms.
Related to:
#29
#26
#14

As of 88ea34c47e2824d7ca1d242a0441d9cdac32375d this is mostly resolved, and is much easier to extend. So I am going to close this issue.

repo: rcos/observatory-new


text:
Add Typescript definitions

This PR adds the Typescript definitions (that previously existed at @types/rdf-data-model) to this repo and allows developers to use this package inside Typescript projects.
The reason for moving these typings in this repo is because this npm package has now been moved to a scoped name (@rdfjs/data-model), which makes it incompatible with the DefinitelyTyped workflow for adding package typings externally.
Note that these typings extend from @types/rdf-js

Just published version 1.1.0, which includes your PR.

source: gharchive/pull-request

authors: bergos rubensworks

repo: rdfjs/data-model


text:
fix(Artwork): add imageLoadFailed signal

Description
Adds an imageLoadFailed signal to let parent element know that a texture did not load properly.
References
LUI-1404
Testing
N/A
Automation
N/A
Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

Test Execution Passed.

Test Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-v2.21.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: rdkcentral/Lightning-UI-Components


text:
Enhanced Error Code Flag Support

Adding Flags to disable/enable test with  enhanced error code in UT.

merged to develop

repo: rdkcentral/rdkv-halif-test-tvsettings


text:
Fixes for rialto-597 tests

Summary: Added documentation links for the component tests of immediate-output, getSupportedProperties and getStats. Added client component test for getSupportedProperties
Type: Fix
Test Plan: UT, CT
Jira: NO-JIRA

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/58129/

'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending.
Build Job/Num: build-rpi4-ipstb-oss/4200
Flash rdkv_rpi4_ipclient[FAILURE]
rdkv_rpi4_ipclient - Video Test skipped [FAILURE]
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-raspberrypi-rdkv-rpi4-flow/12184/

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/58130/

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/58131/

'['BCM 72126OTT Refboard VA']' Sanity test FAILURE, investigation pending.
Build Job/Num: build-brcm-refboard3/5477
Flash BCMREF [FAILURE]
BCMREF - Video Test skipped [FAILURE]
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-bcmref-va-126-flow/3873/

'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending.
Build Job/Num: build-rpi4-ipstb-oss/4200
Flash rdkv_rpi4_ipclient[FAILURE]
rdkv_rpi4_ipclient - Video Test skipped [FAILURE]
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-raspberrypi-rdkv-rpi4-flow/12186/

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/58140/

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/58141/

authors: rdkcmf-jenkins skyproudmanp

repo: rdkcentral/rialto


text:
xts yaml file creation and modifcation support

Goal: Upgrade the XTS core tool to support creation and modification of .xts yaml files
Currently, users have to create their .xts yaml files manually before xts can be used. This upgrade would add a CLI interface users could use to make changes to their yaml files and create new yaml files, with sections specified by the users. This interface would allow users to add new sections or new entries to existing sections, by asking them for the required information. This would allow for users to do the yaml creation/modification without needing to understand the .xts yaml file format.
Acceptance Criteria

The XTS CLI provides a straight-forward way to modify .xts yaml files
The XTS CLI provides a similarly straight-forward way to create new .xts files

Not clear if this would be required, everyone can actually read and edit xts files and they should know how todo it.


text:
stop caching ring-finding results

Currently the ring-finding code caches its results, which leads to delightful confusion like this:
In [5]: m = Chem.MolFromSmiles('C1C2CC1CCC2')

In [6]: m.GetRingInfo().NumRings()
Out[6]: 3

In [7]: Chem.GetSSSR(m)
Out[7]: <rdkit.rdBase._vectclass std::vector<int,class std::allocator<int> > at 0x20583b62fc0>

In [8]: m.GetRingInfo().NumRings()
Out[8]: 3

In [9]: m = Chem.MolFromSmiles('C1C2CC1CCC2',sanitize=False)

In [10]: m.UpdatePropertyCache()

In [11]: Chem.GetSSSR(m)
Out[11]: <rdkit.rdBase._vectclass std::vector<int,class std::allocator<int> > at 0x20583ca1840>

In [12]: m.GetRingInfo().NumRings()
Out[12]: 2

That mess is by design, but it seems like a bug.
This removes the caching so that things are a bit less surprising.
We could add something to be more specific about what we cache, but there's really no reason for people to be calling the ring finding code multiple times on the same molecule, so this seems like wasted effort to me.
Thanks to @fwaibl for pointing out the problem

We should probably search for findSSSR in the code (or fastFindRings) and move the isInitialized to the caller.
Example:  Wrap/MolOps.cpp line 309
VECT_INT_VECT getSSSR(ROMol &mol) {
  VECT_INT_VECT rings;
  MolOps::findSSSR(mol, rings);
  return rings;
}

will always call the ring finding code now regardless of whether it exists or not.

I think there are only a few of these.
Mol2FileParser
ReactionWriter
are two that I've found in a brief search.

ExtendedMurckoScaffold always calls fastFindRings as well.

As does regioIsomer

I think you have everything except the Wrapper, Mol2FileParser and ReactionWriter

We should probably search for findSSSR in the code (or fastFindRings) and move the isInitialized to the caller.
Example: Wrap/MolOps.cpp line 309
VECT_INT_VECT getSSSR(ROMol &mol) {
  VECT_INT_VECT rings;
  MolOps::findSSSR(mol, rings);
  return rings;
}

will always call the ring finding code now regardless of whether it exists or not.

Correct - that's exactly what this bug fix is doing: when the user/client calls the ring finding code, it will always be run

I think you have everything except the Wrapper, Mol2FileParser and ReactionWriter

The Wrapper doesn't need a change (see my earlier comment). In the Mol2FileParser the work is being done during molecule construction, so we know we don't need to do the test. I've updated the ReactionWriter

Yep, the Wrapper was a brain fart.

LGTM

Nice, I think this will help with a lot of confusion.

Now, if we delete a ring bond or atom, do we or should we invalidate the ring info?

Now, if we delete a ring bond or atom, do we or should we invalidate the ring info?

We do: https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/RWMol.cpp#L315

authors: bp-kelley greglandrum

repo: rdkit/rdkit


text:
Add support for proxies / lazy

Alternative implementation for #184.

Closing in favor of #185.

repo: rdlowrey/auryn


text:
stop using download manager

Download manager has a ton of issues.
I wish i had known you used it.
Because download manager failed to get the files, it's been hammering my system trying to download the last few days killing my battery at 1% every 10 minutes.
I finally figured out why...
Download manager is a nightmare that has no user interface and zero user interaction ability.

Download manager is supposed to show a notification while downloading and allow cancelling a download this way, which works fine for user interaction.
In addition, downloads can also be cancelled from the app itself.
The app is OpenSource, so if someone wishes to implement a different download solution that is simple and maintainable enough, they are welcome to do so.
From my side personally though, I am not even going to try to work around bugs in the OS, because the 1000s of developers at Google, Samsung etc can add them far faster than I have any chance to keep up without even trying to work on the app itself.
Thus as annoying as this might be to you personally: I can only suggest to ask the ones selling the phone to fix their software. So I have a chance to have some time left to fix mine.

"Supposed to" never happens if there is no confirmed internet network connection. So it just hammers the system with zero user interaction.
And 1000 issues from oems is why no one should use Google crap api shortcuts (like download manager) to just Downloading directly.
Just turn off all network connections, start a download via your app .  Then try to find any way or even evidence that the system plans to download or hammer the system via download manager for 6 hours...
I have i pixel 8 pro. And even with the most basic Android system there is zero interaction between user and download manager. .

authors: nutpantz rdoeffinger

repo: rdoeffinger/Dictionary


text:
How can we handle router Prompt before navigation to different path?

Something similar to this https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/Prompt.md.
The need for the user to confirm before going back the page or clicking a different route if they have unsaved changes.
Currently, this is not possible as it returns Error: Invariant failed: You should not use <Prompt> outside a <Router>

@ThaDeveloper
It looks as though Prompt or something similar isn't planned/intended to be added to reach-router.
https://reach.tech/router/credits

Trade-offs (mostly compared to React Router)

No history blocking. I found that the only use-case I had was preventing the user from navigating away from a half-filled out form. Not only is it pretty easy to just save the form state to session storage and bring it back when they return, but history blocking doesn’t happen when you navigate away from the app (say to another domain). This kept me from actually using history blocking and always opting to save the form state to session storage.

With what actions will be 'PUSH' and when it will be 'POP'. Or where can I read about how action works?

authors: EmmanuelMr18 ThaDeveloper alexdunne

repo: reach/router


text:
Add synk to CI

Snyk continuously monitors your application's dependencies and lets you quickly respond when new vulnerabilities are disclosed.
I would be nice to have this tool integrated in the CI since it is free for open source projects.
In the current master release it reports:

node-pre-gyp@0.6.37 ->  tough-cookie: Regular Expression Denial of Service (ReDoS)
node-pre-gyp@0.6.37 ->  debug: Regular Expression Denial of Service (ReDoS)

This issues are "low severity" in my opinion but an additional free security audit on all dependencies does not hurt and can help to find vulnerabilities when they are disclosed.
See snyk features.

this is a great idea... alternative is https://github.com/nodesecurity/nsp for reference

Closing due to inactivity. Feel free to open it up again with a discussion.

authors: gretzky justingreenberg mawi12345

repo: react-boilerplate/react-boilerplate


text:
feat(core): Upgrade to React16 - update dependences

Should update dependences first and then add errorboundary and log intercept as follow up PRs.

[x] Update the dependences to React16
[x] Fix test warning: React depends on requestAnimationFrame.
[x] All seems good in my local test.

Coverage remained the same at 100.0% when pulling 6cdf75e0b2913c714f4fccc933f8346419c22c94 on blling:react16 into 3d182559262370aeb4987f0c0e046dbbc289516c on react-boilerplate:dev.

cc @mxstbr @justingreenberg  @Dattaya @gretzky @gihrig

What about #1969?

@avdeev I think we should upgrade to react 16 first and new features will add in the follow PRs. Will close #1969 when all it`s determined features are done :)
BTW:
Is there core teamer could give some advise of new features ?

Coverage remained the same at 100.0% when pulling 5d00c432f68b4ba5bec070cfaaf08a742231fb4d on blling:react16 into 3d182559262370aeb4987f0c0e046dbbc289516c on react-boilerplate:dev.

Coverage remained the same at 100.0% when pulling fdea3dae79f806b26219cf57f9f7ad919ff02a2a on blling:react16 into 139b061d2794068277fb2d86e5d0bc498f64d02d on react-boilerplate:dev.

authors: avdeev blling coveralls


text:
set first:true when validating don't work as same as expected

I set the option first:true when I call the form.validateFields.

first: Boolean, Invoke callback when the first validation rule generates an error, no more validation rules are processed.
see https://github.com/yiminghe/async-validator#options

It works well at the first validation, I will get the first error. But after fix the first field error and validate again, It will not check the rules of other fields.And if i set the first field correctly at first validation, it will check the second field.
Now I set the force true, it can work well.Does this mean I have lost the validation cache？Is this a normal appearance？
My code is like this.
submit = () => {
  const { form } = this.props
  form.validateFields({ first: true }, (err, values) => {
    if (err) {
      console.log(err)
    }
  })
}

render(){
  return (
    ...
    <Input
      {...getFieldProps('username', {
        rules: [{ required: true, message: 'require username' }]
      })}
    >UserName</Input>
    <Input
      {...getFieldProps('password', {
        rules: [{ required: true, message: 'require password' }]
      })}
    >Password</Input>
    ...
  )
}

It is right to set force: true.

authors: benjycui hezhii

repo: react-component/form


text:
Added drop-detection to examples

There have been a few repeated requests for drop-detection so I extended the example page with two additional boxes that use a simple conditional css class trick- I apply the pointer-events: none style to the box that is being dragged. This enables the developer to catch the appropriate event target, both when entering the drop target and releasing the mouse button.
I haven't made any changes to the source code itself.

Super helpful, thanks!

Nice, thanks!

@programstinator Are you able to update the example github site? Currently it doesn't show it.

authors: STRML fcalizobrandcoders hugoburguete programstinator

repo: react-grid-layout/react-draggable


text:
fix(useEventListener): change the way listener added and removed

What is the current behavior, and the steps to reproduce the issue?
It is possible to break the code bypassing types
What is the expected behavior?
Hook should stay vaiable even in case of improper input
How does this PR fix the problem?
Change raw addEventListener/removeEventListener to internal on/off methods that has proper checks.
Checklist

[x] Have you read contribution guideline?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Is there an existing issue for this PR?

#978

[x] Have the files been linted and formatted?
[ ] Have the docs been updated to match the changes in the PR?
[ ] Have the tests been updated to match the changes in the PR?
[x] Have you run the tests locally to confirm they pass?

:tada: This PR is included in version 20.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: react-hookz/web


text:
getting started нэгтгэх

getting-started.txt энд байгаа орчуулсан текстийг getting-started.md нэгтгээд pull request үүсгэх хэрэгтэй байна

Оройн мэнд над руу assign хийнэ үү. Баярлалаа. @dulmandakh

authors: dulmandakh telmen

repo: react-mongolia/react-native


text:
Fix ios build error in past PR

There was an error in my last PR(#11).
I think you need to publish a new version.
Sorry for my mistake.

Oops, 😅

authors: ifsnow wjaykim

repo: react-native-admob/admob


text:
borderTopLeftRadius not supported in iOS

In iOS LinearGradient only support borderRadius, per corner is not supported.
Any plans to support this feature in iOS?
Thanks!!

i REALLY need this to for a project we're working on now. Any assistance would be great, or tips on forking and making the changes ourselves ?

You can add " .   overflow: 'hidden'    " to the style that works

Hey! I'm closing this since it looks like a solved issue.

authors: ATranDev ajonno imarem radex


text:
getCountry with a MIUI phone

Bug
On Xiaomi/MIUI phones, the region is not tied to the locale, but rather to a "region" setting. So when you call getCountry() with a Xiaomi phone, it returns the wrong region.
Environment info
React native info output:
System:
    OS: macOS 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    Memory: 303.39 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.17.0 - /usr/local/bin/yarn
    npm: 6.7.0 - ~/.config/yarn/global/node_modules/.bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 23, 25, 26, 27, 28
      Build Tools: 23.0.1, 23.0.3, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3, 29.0.0
      System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
  IDEs:
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.4 => 0.60.4

Library version: 1.1.4
Steps To Reproduce

Get a Xiaomi MIUI phone
Switch your language to French
Switch your Region to Belgium
Call getCountry()
It returns FR

Describe what you expected to happen:

It should return BE

Reproducible sample code
Any app that uses getCountry ;)
Potential fix
Call getSystemProperties("ro.miui.region") and returns it if not null

I tried to implement it in the latest version: https://github.com/react-native-community/react-native-localize/releases/tag/1.4.0. It should be OK, but I don't have any MIUI device to test it. Please report any issue about it.

authors: Minishlink zoontek


text:
Keep native pin when adding React element to markers

Is this a bug report?
No, more like a feature request.
Have you read the Installation Instructions?
Yes.
Environment
"react": "^16.3.0-alpha.1",
"react-native": "0.54.4",
"react-native-maps": "https://github.com/react-community/react-native-maps.git", (fetched yesterday).

Steps to Reproduce

Added marker.
Want custom marker which looks similar to a marker with the default Callout but "Always-On".
Callouts cannot be always on simultaneously.
If I add a React child to the marker, it stops rendering the native marker pin. I need the native marker pin.
I could add the native pin as a image which is afaik rendered with both image and React children. But I cannot find the native pins as images, if anyone know how to extract or find the pin. Let me know.

Expected Behavior
Markers (optionally) keep the native pin when adding React children to the marker!
Actual Behavior
React children added to the marker removes the native pin.
Reproducible Demo
None.

@alvelig I understand that when you add the image prop to the Marker, the marker will display both the image and the react children of Marker?
Is it possible to replace the image with the native pin marker somehow?

@hegelstad currently it's not possible :( You need to place a marker image.

Okay, thanks!

Is this possible to do now ?

I am pulling my hair out. When I use the marker as noted above, the Image is not centered in the correct location.
Here is my marker code.
                 <Marker
                        image={markerImage}
                        key={waypoint.stop_id}
                        coordinate={{
                            latitude:waypoint.stop_lat,
                            longitude:waypoint.stop_lon
                        }}
                        tracksViewChanges={true}
                        onPress={() => this.onOperatorStopPress(waypoint,operator)}
                        style={styles.markerStyle}
                        >
                                <Text style={[styles.stopsMarkerLabel]}>
                                    {waypoint.stop_name.substring(0, 22)}
                                </Text>
                    </Marker>

My custom label is in the correct location, the image passed as a prop is always positioned all the way to the left. I have tried EVERYTHING, I can't get the image to be in the correct place.
If I remove my label element, then the image is in the correct place, anyone should be able to reproduce this.
This image shows the Marker centered on the map, you can see the label is perfect, but the image is not:

I believe yo need to use the image inside the marker and not passed as prop.

I believe yo need to use the image inside the marker and not passed as a prop.

Thanks for the reply, I cant use the image inside the marker because there are significant performance issues. I have about 160 markers right now, I have tried with tracksViewChanges set dynamically based on whether the markers are loading but performance is really bad.


text:
Add extra details to Wifi and Cellular [android only]

Overview

Inspired by #37, I've added in the SSID, IP address and wifi signal strength to the details object of a Wifi connection. I've also added carrier to the cellular details object.
Note currently, I've only implemented these changes on the Android side (that's what I do day-to-day) and it will take me a bit longer to get the iOS side going. Any help is appreciated!
Test Plan

Thanks for the PR @gretzky. I am currently away from my laptop a bit, but I'll review this when I can 👍

Hey @gretzky. Apologies again for the delay in looking at this. I have taken a look and it looks to be a great start on supporting this!
I am happy to take a look at the iOS side of this, but it will likely be a few weeks before I can get to it. I'll leave this PR open and make the changes on your branch :+1:
If anyone else has any feedback, then feel free to post it here.

Sounds great @matt-oakes

@gretzky Thanks for the contribution! I finally got around to looking at this, rebasing it, and adding corresponding support for iOS.
This closes #37 and #52.
Thanks again 🎉

Fantastic you guys! Thanks! I'm shaping up a react-native-device-info v3 breaking change and maybe I can move some APIs now, since this has landed.

Nice! Thanks @matt-oakes!

authors: gretzky matt-oakes mikehardy


text:
installation error

i am a newbie in react-native, dont mind if i ask a basic question, but i wanted to know
what is the step by step procedure to run this app ,
Any help regarding this will be great.

@Kureev I have to implement side drawer navigation , need help..

Hi @pareekkhushboo77!
First of all, I'm sorry for the late response. I recommend you to read an installation guide first. Then, you can take a look on our Basic example code to get a good overview of "how it works".

Don't hesitate to ask more questions on StackOverflow, it's a way better place (than GH issues) to ask this kind of questions!


text:
Issue with RN 0.44.2

I'm unable to update react-native-svg to the latest react native 0.44.2. See the following error:
Unable to resolve module `AccessibilityInfo` from `PATH/node_modules/react-native/Libraries/react-native/react-native-implementation.js`: Module does not exist in the module map or in the directories:
PATH/node_modules/react-native/node_modules,
PATH/node_modules

No longer an issue with 0.44.3

0.45.1 fixes this as well. react-native-git-upgrade did the trick for me.

Apparently it's not fixed. I get this error everytime:
ld: library not found for -lRNSVG-tvOS
clang: error: linker command failed with exit code 1 (use -v to see invocation)
mateioprea$ react-native --version
react-native-cli: 2.0.1
react-native: 0.45.1
If I unlink the library everything seems fine.

authors: ShMcK mateioprea sdeleon28

repo: react-native-community/react-native-svg


text:
Path rendering inconsistency between react-native and web

I have a react-native-svg Svg defined here:
<Svg height="128" width="106">
	<Rect fill="none" height="128" width="106" />
	<Path d="m11.07 1.2e2 l0.84-9.29 c1.97-18.79 23.34-22.93 41.09-22.93 17.74 0 39.11 4.13 41.08 22.84l0.84 9.38h10.04l-0.93-10.34c-2.15-20.43-20.14-31.66-51.03-31.66s-48.89 11.22-51.05 31.73l-0.91 10.27h10.03m41.93-102.29c-9.72 0-18.24 8.69-18.24 18.59 0 13.67 7.84 23.98 18.24 23.98s18.24-10.31 18.24-23.98c0-9.9-8.52-18.59-18.24-18.59zm0 52.29c-15.96 0-28-14.48-28-33.67 0-15.36 12.82-28.33 28-28.33s28 12.97 28 28.33c0 19.19-12.04 33.67-28 33.67" />
</Svg>

This is a port of this original svg element:
<svg xmlns="http://www.w3.org/2000/svg" height="128" version="1.1" viewBox="0 0 106 128" width="106">
	<rect fill="none" height="128" width="106" />
	<path d="m11.07 1.2e2l0.84-9.29c1.97-18.79 23.34-22.93 41.09-22.93 17.74 0 39.11 4.13 41.08 22.84l0.84 9.38h10.04l-0.93-10.34c-2.15-20.43-20.14-31.66-51.03-31.66s-48.89 11.22-51.05 31.73l-0.91 10.27h10.03m41.93-102.29c-9.72 0-18.24 8.69-18.24 18.59 0 13.67 7.84 23.98 18.24 23.98s18.24-10.31 18.24-23.98c0-9.9-8.52-18.59-18.24-18.59zm0 52.29c-15.96 0-28-14.48-28-33.67 0-15.36 12.82-28.33 28-28.33s28 12.97 28 28.33c0 19.19-12.04 33.67-28 33.67" />
	</svg>

When I view this SVG on the web, I see this:

However, in react-native, it looks like this:

After experimenting with the path definition for a while, I discovered that I can fix the issue by modifying my Svg component to this:
<Svg height="128" width="106">
	<Rect fill="none" height="128" width="106" />
	<Path d="m11.07 1.2e2 l0.84-9.29 c1.97-18.79 23.34-22.93 41.09-22.93 17.74 0 39.11 4.13 41.08 22.84l0.84 9.38h10.04l-0.93-10.34c-2.15-20.43-20.14-31.66-51.03-31.66s-48.89 11.22-51.05 31.73l-0.91 10.27h10.03m41.93-102.29c-9.72 0-18.24 8.69-18.24 18.59 0 13.67 7.84 23.98 18.24 23.98s18.24-10.31 18.24-23.98c0-9.9-8.52-18.59-18.24-18.59m0 52.29c-15.96 0-28-14.48-28-33.67 0-15.36 12.82-28.33 28-28.33s28 12.97 28 28.33c0 19.19-12.04 33.67-28 33.67" />
</Svg>

Here, I removed the z ClosePath command before the final m command. This has the effect of repositioning the circle in the bottom left that is being cut off into its rightful position overtop of the center 'head' circle.
Note that making the change (removing the z) had no adverse effect when viewing the SVG on the web.
Is this inconsistency a result of a bug in the react-native path parser, or is the issue with the SVG being invalid itself (and perhaps the browser is being more forgiving)?

Published a fix for the spec conformance of the path parser: https://github.com/react-native-community/react-native-svg/commit/9affd59b008500e6704c20458186899fd4fc5b70
Available as v8.0.4
https://www.w3.org/TR/SVG/paths.html#PathDataMovetoCommands

The "moveto" commands (M or m) must establish a new initial point and a new current point.

@msand Upgrading to ^8.0.4 fixes the issue. Thank you for the very prompt turn-around!


text:
SWIFT_VERSION '5.0' is unsupported, supported versions are: 3.0, 4.0, 4.2. (in target 'InputMask')

My build keeps failing with this error:
SWIFT_VERSION '5.0' is unsupported, supported versions are: 3.0, 4.0, 4.2. (in target 'InputMask')

Xcode: 10.1
react-native: 0.59.8
react-native-text-input-mask:  ^1.0.1
Thank you

@hbaseline 	I'm not sure but this is probably related to your Xcode version:
https://swift.org/blog/swift-5-released/
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_2_release_notes/swift_5_release_notes_for_xcode_10_2?language=objc

Upgrading Xcode to 10.2.1 solved the issue. Thank you

I downgraded library to 0.9.0 to get it work on xcode 10.1

I downgraded library to 0.9.0 to get it work on xcode 10.1

I was really happy when I read this comment but it keeps giving the same error.

authors: Yigityakut dsznajder hbaseline zvs001


text:
KVO Crash Remove PlayerViewController Observers on vc dismiss

The KVO crash still happens under certain circumstances, for example when having a view that still displays the video component after finishing the video.
Currently the KVO of the PlayerViewController are only being removed on removeFromSuperview.
Which problematic because the _playerViewController instance is being set to nil in the  videoPlayerViewControllerDidDismiss
which deallocates the the instances because it is no longer retained, so if the removeFromSuperview method is not called directly after that, you will get the KVO crash on the two values "frame" and "readyForDisplay" because they are both registered on the _playerViewController and _playerViewController. contentOverlayView.
this happen in situations where you are displaying the video object after the video is finished as well, for example in a listView or an article, where the user will still be on the page and the Video element is still rendered.
Video is not being played, just displayed and the _playerViewController was deallocated, but removeFromSuperview was yet to be called, the view is still visible.
Longer story short, the _playerViewController KVO listeners must be removed before nullifying the  _playerViewController object
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

@jenshandersson Regarding the reproduction of the crash, I think it's a special situation where you still keep the Video Thumbnail displayed (in a list for example) After dismissing the video player The Idea is to allow the videoPlayerViewControllerDidDismiss to be called but still keep the view thumbnail view on screen, the crash doesn't happen instantly it takes about 1.5s sec to happen (I guess it depends on the device).
But this commit fixes it anyways so not sure the long explanation is necessary, although is probably helpful for future reference

@jenshandersson Sorry I totally missed that message, will do so shortly

@jefersondaniel (I'll fix the merge conflict as well) but under what version name should I add the changelog?


text:
Extracting ShoutCast Metadata tags missing and protocal

Hi,
Firstly, thank you for putting together a high quaity project for all of us.   I have two items under the Shoutcast metadata extraction issue.   I used the code snippet you gave to another user which I will incude here.  With that code snippet, I added a debug line "console.log(Objet.kets(e)) within you snippet as I was not able to obtain a tracklength/duration meta data at all.  That being said, we do have a radio player on our HTM website from the vendor that is getting the duration value  of the current track being played.  When I do the debug line, I see these keys on the object (e) as follows:
["genre", "album", "date", "artist", "source", "title", "url"]
Two things that are apprent,  namely the missing duration metadata key -- If we're not getting this in this array, then where is the other radio player getting this deata and how do I extract it for our app?
Second part of this same question,  ShoutCast brodcast the Artwork metadata about a minute after the track is played,  That being said, how do I setup a listener to capture it specifically?  Does this ShoutCast broad ast thee entire data, or does it 'bit-torrent' it for the entire minute and then we have this data?   Either way, is the react-native-track-player capable of capturing this and passing it for us to render.  How do I render this image correctly.
the code snppet I am referring to:
TrackPlayer.addEventListener('playback-metadata-received', async e => {
console.log( Object.keys(e));

const currentTrack = await TrackPlayer.getCurrentTrack();
TrackPlayer.updateMetadataForTrack(currentTrack, {
    title: e.title,
    artist: e.artist,
duration: e.length
});

});
I cannot tell what version I have of the react-native-track-player, however, I installd the package two weeks ago (arouund Aug 24, 2020) through npm install react-native-track-player command.

You can check the version of react-native-track-player by looking at package.json.
I'm not sure what your Shoutcast server looks like, but for me, I'm currently grabbing meta data by from the "streaminfo.get" file on the shoutcast server. The following fetches the song title and artist, which I then display in the app, and pass to TrackPlayer.. However, I need to refactor the react-native-track-player side of things, as the song title and artist dont update into the control center/lock screen. So, at most this could be a starting point for you.. I'm still looking around for a solid example of using react-native-track-player for shoutcast streams..

const [song, setSong] = useState('');
const [musician, setMusician] = useState('');

useEffect(() => {
      let repeat;
      async function fetchData() {
          try {
              const res = await fetch("*my shoutcast server*/streaminfo.get");
              const json = await res.json();
              setSong(json.data[0].track.title);
              setMusician(json.data[0].track.artist);
              repeat = setTimeout(fetchData, 26000);
          } catch (error) {
              console.error(error.message)
          }
      }
      fetchData();
      return () => {
          if (repeat) {
              clearTimeout(repeat);
          }
      }
}, []);

authors: BryonConley thecluff


text:
can't pinch to zoom when touching marker

When I want to zoom map and initial touches are on markers — it's not zooming

Same problem here.

You can try animate zoom this way:
this.refs.map._component.animateToRegion(animatedRegion, 600);

@alexHlebnikov I want to use pinch to zoom

Any help or update about this issue?

This is a serious problem with the basic usability of the component. I'm willing to take a stab at a fix, but need a bit of guidance. @naoufal @spikebrehm @gilbox care to chime in?

So after a bit of debugging, the problem lies here: https://github.com/airbnb/react-native-maps/blob/master/ios/AirMaps/AIRMap.m#L144
A crude change that fixes zoom when initial touch is over markers:
- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch {
    return YES;
}

Obviously letting the map swallow every gesture will remove the ability to interact with markers, so we have to dig in and detect zoom (and other intents) so that we know when to let the MKMapView handle it properly. Will keep working on it, but please feel free to add comments/opinions.

After more analysis, my post above is somewhat misleading. I think the problem is more related to the hitTest here: https://github.com/airbnb/react-native-maps/blob/master/ios/AirMaps/AIRMap.m#L153-L159.
When images are used in Markers and a gesture starts on top of one, [super hitTest:point withEvent:event] will return that Image as the hitTest view instead of the MKNewAnnotationContainerView that is capable of responding properly to the pinch or zoom.
My knowledge is limited for best practices in all the various gesture event handling combinations on iOS, but I think it's probably safe to detect the type of gesture and just short circuit the hitTest view to be MKNewAnnotationContainerView for these cases. But we'd also have to think about other gestures too. For instance, when you double tap on a marker in iOS Maps app, it will zoom in accordingly, whereas single tap will bring up the marker detail overlay.

#544

My ticket #544 was a duplicate of this.
I don't know how to solve this problem, but when testing I find that I can pinch zoom over simple annotations, and custom image annotations(either with nested Image/View or marker image prop) on the initial render, but if more markers are rendered on the screen the previously rendered markers can no longer be pinch-zoomed over.

I managed to get sjmuellers PR to work when using onSelect instead of onPress. Check out my comment on #623

Any update on this? Is there a way around this? Can we add a prop to the markers or something to allow the pinch and zoom?
The map should detect when two fingers are on the screen & disable clicks on the markers?

any update on this issue pls?

Run into this issue too. https://github.com/airbnb/react-native-maps/pull/623 helps but is a tradeoff. Was anyone able to fix this  completely?

I have the same issue with the marker. Does anyone have a solution?

The bug exists for a long time, so any official plan to fix the bug?

I'm guessing there is no official fix yet? Is there a work around for this? Has anyone used the workaround from: @grundmanise (as referenced above)

Same as @carleryd, I can confirm @sjmueller PR works moving callback from onPress to onSelect.
Thank you.

That happens...

I'm currently having this issue and #623 doesn't seem to work anymore. Is there a way to stop markers grabbing gestures?

authors: alexHlebnikov alvelig carleryd creeperyang dot3bumpmap jamesone leandroalonso lylynguyen pablito25sp sami-juvonen sjmueller stereodenis tirnovali

repo: react-native-maps/react-native-maps


text:
Could not determine the dependencies of task ':react-native-community_masked-view:generateDebugRFile'

Bug report

Summary

While using it with react-native application, the build fails for Android.
* What went wrong:
Could not determine the dependencies of task ':react-native-community_masked-view:generateDebugRFile'.
> Could not resolve all task dependencies for configuration ':react-native-community_masked-view:debugRuntimeClasspath'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :react-native-community_masked-view
      > Failed to list versions for com.facebook.react:react-native.
         > Unable to load Maven meta-data from https://jitpack.io/com/facebook/react/react-native/maven-metadata.xml.
            > Could not get resource 'https://jitpack.io/com/facebook/react/react-native/maven-metadata.xml'.
               > Could not GET 'https://jitpack.io/com/facebook/react/react-native/maven-metadata.xml'.
                  > Read timed out

Environment info

react-native info output:
System:
OS: Windows 10 10.0.17134
CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
Memory: 3.34 GB / 11.79 GB
Binaries:
Node: 12.18.3 - C:\node-v12.18.3\node.EXE
Yarn: 1.22.4 - C:\node-v12.18.3\yarn.CMD
npm: 6.14.6 - C:\node-v12.18.3\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 30.0.0
System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom_64, android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Version  4.0.0.0 AI-193.6911.18.40.6514223
Visual Studio: Not Found
Languages:
Java: Not Found
Python: Not Found
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.2 => 0.63.2
npmGlobalPackages:
react-native: Not Found
# paste it here

Library version: 0.1.10
Steps to reproduce

run react-native run-android

Describe what you expected to happen:

The application runs on the simulator/device

Reproducible sample code

Seems like it was a temporary outage issue of https://jitpack.io. Started working now as the https://jitpack.io is responding. Hence closing the issue. Thanks

facing same issue
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Could not resolve all artifacts for configuration ':react-native-community_masked-view:releaseRuntimeClasspath'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :react-native-community_masked-view
      > Failed to list versions for com.facebook.react:react-native.
         > Unable to load Maven meta-data from https://jcenter.bintray.com/com/facebook/react/react-native/maven-metadata.xml.
            > Could not HEAD 'https://jcenter.bintray.com/com/facebook/react/react-native/maven-metadata.xml'. Received status code 502 from server: Bad Gateway

Here is my environment details (react-native info):
System:
    OS: macOS High Sierra 10.13.6
    CPU: (4) x64 Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz
    Memory: 413.54 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.13.0 - /usr/local/bin/node
    Yarn: 1.7.0 - /usr/local/bin/yarn
    npm: 8.1.0 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
    Android SDK:
      API Levels: 26, 27, 28, 29, 30
      Build Tools: 26.0.1, 27.0.3, 28.0.3, 29.0.2, 30.0.2, 32.0.0
      System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom_64, android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.7042882
    Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_201 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.66.4 => 0.66.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

repo: react-native-masked-view/masked-view


text:
Modal gets stuck visible when rendered in Storybook on iOS

(works fine with default RN modal)
Environment
System:
    OS: macOS 11.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 25.61 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.0/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v14.16.0/bin/npm
    Watchman: 2021.06.07.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /Users/brian/.rbenv/shims/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
    Android SDK:
      API Levels: 23, 28, 29, 30
      Build Tools: 29.0.2, 30.0.3
      System Images: android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.2 AI-202.7660.26.42.7351085
    Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_292 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.64.2 => 0.64.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Platforms
iOS
Versions

iOS:  14.5
react-native-modal: 12.0.2
react-native: 0.65.2
react: 17.0.1

Description
This seems similar to an issue I've had with this library (and the RN Modal for years now) - It seems like it can often cause soft locks, especially when other native views are involved. BUT, I don't think that is the case here. I'm not totally sure what storybook does under the hood, but seems to break this and not the Modal component in react native
Reproducible Demo
I will see if I can get to this :-)

In my case, I found, that resolver of animation was not called - file modal.tsx, function open,  line 666 ( https://github.com/react-native-modal/react-native-modal/blob/master/src/modal.tsx#L666 )  :
               this.contentRef
                    .animate(this.animationIn, this.props.animationInTiming)
                    .then(() => { // this is not called !!!
                       this.isTransitioning = false;
                 ...

and because this.isTransitioning was set to true and never to false, modal can not be closed.
For some reason it is not working in storybook. In application it works well. Tested on android and ios emulator.
Versions

react-native: 0.64.2,
react: 17.0.2,
Storybook: 5.3.23

+1

After upgrading storybook ( to 6.0.1-alpha.7 ) it works well. It seems like older version of storybook has problem with Promise.

For anyone else who is still facing this problem
I was able to workaround this in stories using key prop with isVisible state
e.g. <Modal isVisible={modalShown} key={modalShown}>{content}</Modal>

For anyone else who is still facing this issue
I was able to workaround this in stories using key prop with isVisible state as value
<Modal isVisible={modalShown} key={modalShown}>{content}</Modal

For anyone else who is still facing this issue I was able to workaround this in stories using key prop with isVisible state as value <Modal isVisible={modalShown} key={modalShown}>{content}</Modal

This work for me.

For anyone else who is still facing this issue
I was able to workaround this in stories using key prop with isVisible state as value
<Modal isVisible={modalShown} key={modalShown}>{content}</Modal

Hey @Artem-Kalugin, this fixes the issue. But any idea why ?  🤔

For anyone else who is still facing this issue
I was able to workaround this in stories using key prop with isVisible state as value
<Modal isVisible={modalShown} key={modalShown}>{content}</Modal

Hey @Artem-Kalugin, this fixes the issue. But any idea why ? 🤔

Its just triggers additional rerender while changing visibility. Seems that this disables optimizations that lib uses under the hood. Also it’s disables animations too. So don’t use it directly inside your components,  use it in stories instead.

authors: Artem-Kalugin ArtemKaluginCeviant CatWithNineLives bcgilliom bharatgupta99 jakubmichalko rmaharba

repo: react-native-modal/react-native-modal


text:
Unable to resolve module './DRMType'

Bug
Unable to resolve module './DRMType'
Platform

Which player are you experiencing the problem on:

iOS
Android ExoPlayer
Android MediaPlayer

Environment info

React native info output:
 Binaries:
    Node: 14.3.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.8 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK: Not Found
  IDEs:
    Android Studio: 3.5 AI-191.8026.42.35.6010548
    Xcode: 11.6/11E708 - /usr/bin/xcodebuild
  Languages:
    Java: javac 12 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.9.0 => 16.9.0
    react-native: ^0.63.2 => 0.63.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 5.0.0
Steps To Reproduce

Step 1:
Installed the 5.0.0 with locked version in my package.json

package.json
"react-native-video": "^5.0.0",
Error:
Unable to resolve module './DRMType'

Step 2:
Then I tried installing with the following command without specifying any version:
npm install --save react-native-video
It got installed with "react-native-video": "^5.1.0-alpha8",
I can not even find this version in both the pages
Releases (https://github.com/react-native-video/react-native-video/releases)
Tags (https://github.com/react-native-video/react-native-video/tags)
We do not even know which version is officially released from documentation.
...
Expected behaviour

We should not get error Unable to resolve module './DRMType'
We do not even know which version is officially released from documentation.

Let me know, if you require more info to understand this issue which I might have missed to point out here.

same here, any update ?

Any update on this issue? @pvn, did you manage to resolve it?

Same issue here.

authors: VladLegkowski hugoh59 josepichu pvn

repo: react-native-video/react-native-video


text:
[Windows] Clicking Links Does Not Trigger onShouldStartLoadWithRequest

Bug description:
I have a react-native-windows project that contains a webview pointing to my website.
When the user clicks on links in the website I expect it to trigger onShouldStartLoadWithRequest and then I can decide if to navigate inside the webview or if I should open the link externally.
On react-native-windows onShouldStartLoadWithRequest is not fired and the link is opened in a separate window (separate window but still part of the app)
To Reproduce:
Run windows example with useWebview2 set to true and click on any link,
a new window will be opened and onShouldStartLoadWithRequest or onNavigationStateChange will not be fired
Environment:

OS: Windows 10 Enterprise
OS version: 19045.2364
react-native version: 0.71
react-native-webview version: 12.0.2
react-native-windows version: 0.71.5

Also experiencing this
"react-native": "0.71.8",
"react-native-webview": "12.0.2",
"react-native-windows": "0.71.15"

@frankcalise I think it's simply not implemented :/ So maybe not a bug but feature request


text:
Getting Minified React error #130 in build version of application-version-6.7.0

We are using react-tag-input in our application. We were getting  Minified React error #130 in build version of application. On analyzing, we identified that the issue is with latest version-6.7.0 of react-tag-input. Earlier version of 6.6.1 was not having this issue. In order fix the build issue,  we have locked the version of react-tag-input as 6.6.1 in package.json . Can you please check  the issue with latest version.

@vineethasimon what error are you getting? Looks like you have linked a wrong issue in the description.

@vineethasimon what error are you getting? Looks like you have linked a wrong issue in the description.

hi @ad1992 ,
PFB actual error message received:
react-dom.production.min.js:209 Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Ol (react-dom.production.min.js:275)
at react-dom.production.min.js:148
at Ba (react-dom.production.min.js:173)
at ms (react-dom.production.min.js:262)
at ul (react-dom.production.min.js:246)
at sl (react-dom.production.min.js:246)
at $s (react-dom.production.min.js:239)
at react-dom.production.min.js:123
at t.unstable_runWithPriority (scheduler.production.min.js:19)
at zi (react-dom.production.min.js:122)

I have the same issue, the full error message is on the screenshot

@vineethasimon @kilimovich-aleksandr can you share a CSB or stackblitz link for further debugging?
It's working fine in the demo though.

Yeah I also got this error on minified version 6.6.1 it looks like. Seems to only happen on minification. Spent several hours trying to recreate locally / in dev but it only happens on our staging environment due to the minified build.

Hmm ok so will have to check the prod build to investigate this

Hmm ok so will have to check the prod build to investigate this

@ad1992 I just did some more testing and found that forcing 6.6.1 solves the issue. I edited my above comment. However ^6.6.1 was causing issues so the latest version prod build is probably going to be where the issue is.

@mattpetters @vineethasimon I verified it with the prod build as well and it works fine. I think some issue related to peer dependency might be causing this error so please make sure you have installed all the peer dependencies including the dependencies of peer dependencies correctly as that's what has changed in the latest version.

closing this as this is not related to the library. feel free to reopen if you find the issue related to the library.

authors: ad1992 kilimovich-aleksandr mattpetters vineethasimon

repo: react-tags/react-tags


text:
Dead link in readme

Check it out here (https://www.jinno.io/app/6?source=react-tag-input)
in readme redirect to some ad.

Thanks for reporting! Should be fixed now.


text:
fix: Korean input trigger keydown event twice

[!NOTE]
The solution needs to be tested by a proper Korean language user. Being a non-Korean lang user, I can change the keyboard and type input and test, but I will not be able to say whether what I tested is proper according to the Korean language,

Issue
Korean and Japanese languages characters are formed using the compositions of keys.
From GPT:
Composition-based Input:
Korean, like many East Asian languages, often uses an Input Method Editor (IME) for text entry. This involves a composition process where multiple keystrokes may be required to form a single character.
Challenges:

The value of the input field may not be final until the composition is complete.
Key events may fire multiple times for a single Korean character.
The keyCode or which properties may not accurately represent the Korean character being input.

The issue we were facing is that the keys were still composing when we were handling onKeyDown  event. By the time the composition is done, it is used to trigger one more time enter and last character.
can read more here
Fix
Add a composing check-in on the KeyDown event to handle the next stages. Though Key events might fire multiple times, this makes sure, that until all composing is done enter is not triggered .
Why the handling is added in onKeyDown event not on onChange?

we are concentrating on enter key which is the terminating key. It's not considered as value in the input tag.

This fixes https://github.com/react-tags/react-tags/issues/988
SCREEN RECORDINGS
English lang
https://github.com/user-attachments/assets/fe4060cf-d51f-4fa5-9efd-7f99a20f575f
Korean lang
https://github.com/user-attachments/assets/80ba9760-6184-4faa-8a76-4189ebc8901b

Hey @ad1992 , here is the fix for https://github.com/react-tags/react-tags/issues/988. How to ask the bug reporter to try this out and check whether this works ?

@shrilakshmishastry looks like this has fuzzy PR changes as well, can you only push the changes related to the fix?

@shrilakshmishastry please leave a comment about why this PR is closed

The PR is closed as the branch is cut out from non master branch


text:
Ripple effect on raw RadioButton.js is not visible but remains in the DOM

We are using a raw/unthemed RadioButton and taps on it result in the following HTML added inside the div data-react-toolbox="radio":

No ripple effect is actually visible and this span doesn't ever go away from the DOM!
Our relevant CSS is pretty much like in the default theme:
.input {
  position: absolute;
  width: 0;
  height: 0;
  padding: 0;
  margin: 0;
  border: 0;
  opacity: 0;
  -webkit-appearance: none;
  -moz-appearance: none;
  appearance: none;
}
.ripple {
  background-color: #00adee;
  opacity: .3;
  transition-duration: 650ms;
}

Each radio label tag is about a 100px x 83px box.

The ripple assumes that you are setting a transition on the opacity, being this the last animated property. This way, a listener is set on transition ends to check when the animation finished. This allows to modify the transition duration via CSS without touching the Javascript. If you feel like this should be changed, please reopen!

I am afraid you lost me. :-(
I am using the same .riple CSS as the styled component as indicated above. What do I need to do when using the raw RadioButton to a) have a ripple effect similar to the styled one; b) not have the HTML for the ripple remain in the DOM when the ripple animation completes?
Thanks.

The most important part of the ripple styling is here. Those classnames control the ripple lifecycle and when the element gets created, an event listener is added listening for the transition finish events. As you see in that snippet when the ripple gets active it has a transition-property set to transform and an opacity different from 0. This means while kept like that the size change will be animated but keeping the opacity. When the ripple covers the whole surface the active is removed so now transition affects to both opacity and transform changing the opacity to 0. This makes the ripple disappear. Then, if you check here you will see that there is an event listener for when the opacity transition finishes. Your ripple is not getting removed because that never happen.
To obtain a similar ripple you can either import from ripple/index.js, like with the rest of components, of you can import the CSS module from the top and pass it down. Just like any other component. Or, of course, you can just copy the style and pass a css module built manually :)

Ok, so if I understand correctly, my problem is that when I do this:
import RadioButton from 'react-toolbox/lib/radio/RadioButton';
that RadioButton is in turn importing the raw Ripple.js instead of the themed Ripple. So, how can I change that?

Exactly. Importing components from their definition does not require the css for you. This is done to make optional configuring CSS modules because this way you can use a ThemeProvider to pass the theme modules.
You might want to import raw what you want to fully customize and with style what you don't. For example, if you want to fully customize a RadioButton so the ripple covers the whole thing you should inject a identity decorator to the Radio (because it expects it) and then decorate the RadioButton with a ripple. You can see here more or less how it works. It should be something like this (not sure if it works).
import { themr } from 'react-css-themr';
import { RADIO } from '../identifiers.js';
import themedRippleFactory from '../ripple';
import radioFactory from './Radio.js';
import { radioButtonFactory } from './RadioButton.js';
import { radioGroupFactory } from './RadioGroup.js';
import theme from './theme.scss';

const identity = Component => Component;
const Radio = radioFactory(identity);
const rippleDecorator = themedRippleFactory({ spread: 2.6 });
const RadioButton = rippleDecorator(radioButtonFactory(Radio));
const ThemedRadioButton = themr(RADIO, theme)(RadioButton);
const ThemedRadioGroup = themr(RADIO, theme)(radioGroupFactory(ThemedRadioButton));

export default ThemedRadioButton;
export { ThemedRadioButton as RadioButton };
export { ThemedRadioGroup as RadioGroup };

Didn't try it but more or less that's the idea. While we provide two ways of importing (with/without css) DI is crucial.

authors: alexhisen javivelasco

repo: react-toolbox/react-toolbox


text:
Update sbt-buildinfo to 0.10.0

Updates com.eed3si9n:sbt-buildinfo from 0.9.0 to 0.10.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.eed3si9n", artifactId = "sbt-buildinfo" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #40.

repo: reactific/sbt-reactific


text:
RC1 TCK: IdentityProcessorVerification expectations

Maybe this isn't the right place for this but currently I have code available for C# (RxJava 2 doesn't do IdentityProcessorVerification).
I've encountered problems with the IdentityProcessorVerification:
Required_spec104_mustCallOnErrorOnAllItsSubscribersIfItEncountersANonRecoverableError
Looking at the source code, this test expects that an Exception is delivered eagerly to an ISubscriber even if it hasn't requested. My fanout IPublisher implementation first delivers available items and then any error which I believe is also legal. Maybe the verification at L347 could first check if there was an error emitted and if not, request 1 from sub2 and then check for the value and the error.
Required_exerciseWhiteboxHappyPath
Looks like this test expects that when a single the ISubscriber cancels its ISubscription, the IProcessor cancels its ISubscription. The same fanout IPublisher won't cancel its ISubscription as ISubscribers are allowed to come and go at will. I think both behaviors are acceptable and maybe this check should be optionally disabled via a public virtual long SupportsUpstreamCancelOnSubscriberCancel { get; } parameter for example.

In addition, I have trouble with Required_mustRequestFromUpstreamForElementsThatHaveBeenRequestedLongAgo:
Reactive.Streams.TCK.IdentityProcessorVerification`1.TestSetup.ExpectNextElement(ManualSubscriber`1 subscriber, T expected)

timeout while awaiting 2 within 25 ms

Without line numbers, I speculate L552 fails due to the lockstep nature of my fanout IProcessor: if items are available but not all ISubscribers are ready to receive, nobody receives an item.

onComplete and onError should not require request to propagate downstreams.

@viktorklang If the upstream emission sequence was onNext, onError and the processor is not fail-fast, one needs a request(1) to get the onNext item immediately followed by onError.

@akarnokd If the error has been detected/encountered by the upstream it should be propagated to current subscribers.

In practice, many stream users want to process as many items as received and delay the error to the very end. This is why most operators that have an implicit or explicit async boundary have the option to have the onError cut ahead (fail-fast mode) or not (delay-error mode). Just because Akka-Stream wasn't designed in this mind it doesn't mean other Reactive-Streams implementation are forbidden to do so and also pass the TCK in delay-error mode.

§1.4: If a Publisher fails it MUST signal an onError.

Doesn't say or require an immediate notification.

@akarnokd Just to be clear, RS does not define the terms "fail-fast mode" nor "delay-error mode".
While 1.4 doesn't say "immediately", there is precedent for using eventually to describe actions which are lenient in terms of delivery. The reason for not having to do request(…) in order to get a completion signal is because TCP made that mistake—having to prod the connection to figure out if it is broken is the cause of many bugs. As for immediacy, I think it's fine to, if there's a downstream demand of X, and X…X-N items to send before propagating the onError signal. But not holding off until more demand is signalled.
Since there is no corresponding issue open against reactive-streams-jvm, I'm assuming that the above is not an issue there? If so, I'd like to understand why.

These are issues in reactive-streams-jvm as well but I discovered them only when I implemented Processors in C# to check the TCK (as stated at the very top of this issue).
Since RS is in-memory, it is possible data is buffered and is available when the final event, an onError gets posted. Implementations may chose to keep strong event ordering and thus deliver onNexts that are in the buffer before delivering the final onError. That requires downstream requests of course. Since this behavior may depend on the actual use case (sometimes its okay, sometimes the onError should cut ahead), the behavior is parametric. The problem is that the TCK always expects eager onError delivery and the same Processor implementation may pass in "fail-fast mode" and fail in "delay-error mode".
I think the best would be I post a PR to the JVM version that enables this behavior so actual Java code can be analyzed and discussed.

Posted a PR to enhance the JVM version:
https://github.com/reactive-streams/reactive-streams-jvm/pull/348

authors: akarnokd viktorklang


text:
UWP sextant navigation, sample, and sample core project

What kind of change does this PR introduce?

Moves ViewModel, Interactions, and SextantDefaultExceptionHandler to SextantSample.Core project
Adds native UWP functionality to Sextant along with a UWP sample project that mimics the Xamarin forms project
Updated a few NuGet packages to latest

What is the current behavior?
No native UWP support for Sextant.
What is the new behavior?
Adds native UWP support for Sextant
What might this PR break?
Probably nothing.  I didn't touch the core files.
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

You can read my comments... but because of UWP's navigation idiosyncrasies, I had to create mirrors for the PageStack and ModalStack on NavigationView.  I also had to capture the most recently popped ViewModel (and named it more appropriately).  I think it works pretty well now.

Yeah.  I am unfamiliar with UWP and it's concerns.  So I definitely understand that you would have to bend the code to make it work.

Resolves #45

authors: RLittlesII limefrogyank

repo: reactiveui/Sextant


text:
EBUSY: resource busy or locked

Thanks for filing a bug! To save time, if you're having trouble using the library, please check off the items you have tried. If you are just asking a question, skip right to the bottom.
Please verify these steps before filing an issue, and check them off as you go

[x] The relevant native JavascriptEngineSwitcher library packages are installed (such as JavaScriptEngineSwitcher.V8.Native.win-x64)
[x] The VC++ 2017 2019 runtime is installed
[x] The value of SetUseReact and SetUseBabel is correct in ReactConfig.cs or Startup.cs
[x] I've looked at the sample projects in this repo to verify that my app is configured correctly

I'm using these library versions:

ReactJS.NET: 5.2.4
JavaScriptEngineSwitcher: 3.3.1
react and react-dom: 16.12.0
webpack: 4.42.1
clean-webpack-plugin: 3.0.0
node: 12.16.1

Runtime environment:

OS: Windows 10 64bit
.NET Framework: 4.6.2

Steps to reproduce
See below.

Since upgrading to 5.2.4 from 4.1.1 I have been having random EBUSY: resource busy or locked error on bundle.server.js. I noticed that this is a pretty persistent problem when it happens, if it happens. The initial error has so far happened only while the webpack is in watch mode. Using LockHunter I can see that w3wp.exe is locking the js file. After releasing the lock manually and running the webpack again may or may not solve the problem; it often takes 2-3 retries (unlock file, run webpack) to make it dissappear (unless I delete the js file manually).
I noticed that similar problems have been reported before. I have yet to test the effects of the suggested solution; adding .SetReuseJavaScriptEngines(false) to configuration.
I noticed that the JavascriptEngineSwitcher.v8 has a newer package (3.5.1) but via the changelogs I couldn't see anything that is related to this issue. Do you think it would help with the problem?
My config can be seen below:
public class JsEngineSwitcherConfig
    {
        public static void Configure(IJsEngineSwitcher engineSwitcher)
        {
            engineSwitcher.EngineFactories.AddV8();
            engineSwitcher.DefaultEngineName = V8JsEngine.EngineName;
        }
    }

[assembly: WebActivatorEx.PreApplicationStartMethod(typeof(ReactConfig), "Configure")]

namespace Project
{
    public static class ReactConfig
    {
        public static void Configure()
        {
            ReactSiteConfiguration.Configuration
                .SetLoadBabel(false)
                .AddScriptWithoutTransform("~/Static/bundle.server.js");
        }
    }
}

And here is the output I am getting from webpack:
> webpack --env.dev --progress

webpack is watching the files…

Live Reload listening on port 35729

* Webpack █████████████████████████ emitting (95%)

i ｢atl｣: Using typescript@3.8.3 from typescript
i ｢atl｣: Using tsconfig.json from D:/[redacted]/tsconfig.json (in a forked process)
i ｢atl｣: Checking started in a separate process...
95% emitting clean-webpack-pluginError: EBUSY: resource busy or locked, unlink 'D:\[redacted]\[redacted]\Static\bundle.server.js'
    at Object.unlinkSync (fs.js:1052:3)
    at Function.rimrafSync [as sync] (D:\[redacted]\node_modules\del\node_modules\rimraf\rimraf.js:314:17)
    at D:\[redacted]\node_modules\del\index.js:65:11
    at Array.map (<anonymous>)
    at module.exports.sync (D:\[redacted]\node_modules\del\index.js:57:40)
    at CleanWebpackPlugin.removeFiles (D:\[redacted]\node_modules\clean-webpack-plugin\src\clean-webpack-plugin.ts:304:29)
    at CleanWebpackPlugin.handleInitial (D:\[redacted]\node_modules\clean-webpack-plugin\src\clean-webpack-plugin.ts:239:14)
    at D:\[redacted]\node_modules\clean-webpack-plugin\src\clean-webpack-plugin.ts:189:26
    at AsyncSeriesHook.eval [as callAsync] (eval at create (D:\[redacted]\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:14:1)
    at AsyncSeriesHook.lazyCompileHook (D:\[redacted]\node_modules\webpack\node_modules\tapable\lib\Hook.js:154:20)
    at Compiler.emitAssets (D:\[redacted]\node_modules\webpack\lib\Compiler.js:491:19)
    at onCompiled (D:\[redacted]\node_modules\webpack\lib\Watching.js:51:19)
    at D:\[redacted]\node_modules\webpack\lib\Compiler.js:681:15
    at eval (eval at create (D:\[redacted]\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:18:1)
    at D:\[redacted]\node_modules\awesome-typescript-loader\src\instance.ts:523:16
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
i ｢atl｣: Time: 6742ms

Hmm unsure why this library would be locking the file. You could try switching to another JS engine like Chakra or NodeJS to see if it still happens...

Can't reproduce this; if I run into it or there is a solid repro case we'll see what we can do to make the engine release the file handle after it's done reading.
JSPool has its own file watcher implementation: https://github.com/Daniel15/JSPool/blob/286fadae1afe189ee1f3b7b96cabb70d579efd89/src/JSPool/FileWatcher.cs

authors: dustinsoftware erdihu


text:
Your First Component

Page: https://id.react.dev/learn/your-first-component
Assignee: @Cikang44

Closed by @Cikang44 in #338


text:
Traduzindo o Roadmap

Descrição
Fixes #279
PR com o intuito de traduzir a postagem de roadmap

[x] tl;dr
[x] React 16.6 (shipped): The One with Suspense for Code Splitting
[x] React 16.x (~Q1 2019): The One with Hooks
[ ] React 16.x (~Q2 2019): The One with Concurrent Mode
[ ] React 16.x (~mid 2019): The One with Suspense for Data Fetching
[ ] Other Projects

@jlucfarias Você terminará esta tradução ou podemos liberar para outra pessoa a fazer?

@jlucfarias Você terminará esta tradução ou podemos liberar para outra pessoa a fazer?

Desculpa o atraso, vou terminar sim só estava com uns problemas pra gerenciar o meu tempo, mas agora vou voltar a traduzir

Resolvido os problemas de tradução apontados pelo @Luanf e voltei os códigos para não serem traduzidos
Hoje mesmo eu continuo a tradução

Resolvido os problemas de tradução apontados pelo @Luanf e voltei os códigos para não serem traduzidos
Hoje mesmo eu continuo a tradução

@jhonmike pode revisar ou pedir pra alguém revisar por favor?

Assim que possível farei a review!!

Alterações feitas

@jlucfarias não consegui ver se vc aceitou ou não minhas sugestões, quando vc da um force na branch fica difícil saber oq vc alterou, dessa forma vou ter que revisar tudo novamente, e isso é um pouco demorado, assim que possível farei isso!
e se a ideia era deixar o histórico de commits mais organizado, não precisa se preocupar a gente por padrão faz squash na hora do merge, então no final todo seu PR se torna apenas 1 commit na master ;)

Revisado, obrigado pela tradução @jlucfarias e parabéns!! 🤘

authors: jcserracampos jhonmike jlucfarias


text:
I am posting (Post Request) data from React App into an API and its giving me 419   (status unknown) ERROR

Here is my code:
fetch("http://23.22.113.142/api/login",{
method:"post",
headers:{
"Content-Type":"application/json"
},
body:JSON.stringify({
password:"nasar@gmail.com",
email: "password"
})
}).then(res=>res.json())
.then(data=>{
if(data.error){
console.log(data.error)
}
else{
console.log(data.message)
}
}).catch(err=>{
console.log("ERROR: "+ err)
})
Her is the ERROR it gives
Singin.js:31 POST http://23.22.113.142/api/login 419 (unknown status)
Singin.js:53 ERROR: SyntaxError: Unexpected token < in JSON at position 0
please replay me, I will be waiting

Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:
Coding Questions
If you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.
https://stackoverflow.com/questions/tagged/react
Talk to other React developers
There are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.
https://reactjs.org/community/support.html

I've also posted On stack overflow but didn't get any satisfactory Answer😪
On Fri, 9 Apr 2021, 1:50 pm Sebastian Silbermann, @.***>
wrote:

Support requests filed as GitHub issues often go unanswered. We want you
to find the answer you're looking for, so we suggest the following
alternatives:
Coding Questions
If you have a coding question related to React and React DOM, it might be
better suited for Stack Overflow. It's a great place to browse through
frequent questions about using React, as well as ask for help with specific
questions.
https://stackoverflow.com/questions/tagged/react
Talk to other React developers
There are many online forums which are a great place for discussion about
best practices and application architecture as well as the future of React.
https://reactjs.org/community/support.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/reactjs.org/issues/3621#issuecomment-816529284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQVX3LZYHDZ7GNCE2RXR5WLTH25UXANCNFSM42UG7ELQ
.


text:
capy

we face some problem to find links in laptop and those links are easly found in the mobile app version

we face some problem to find links in laptop and those links are easly found in the mobile app version


text:
An extra comma in the object containing one element

there is an extra comma in the object that is being passed to setState function

It's added by Prettier to reduce diffs when you add more lines, and is valid syntax

authors: alexkrolick mohasarc


text:
update @babel/plugin-syntax-dynamic-import link

Docs previously linked to https://classic.yarnpkg.com/en/package/babel-plugin-syntax-dynamic-import for Babel 6. Updated link to point to plugin compatible with Babel 7.

@stephaniecoates thanks!


text:
Upgrade to react@28a574ea8

Upgrade React dependencies to 0.0.0-experimental-0cc724c77-20211125

Perhaps when doing this upgrade, it should also move away from react-fetch, react-fs and react-pg in favour of use https://github.com/facebook/react/pull/25577

https://github.com/reactjs/server-components-demo/pull/62

authors: gaearon penx

repo: reactjs/server-components-demo


text:
🛑 Bellshade Website is down

In dc22e0b, Bellshade Website (https://bellshade.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bellshade Website is back up in bd14e6f after 6 minutes.


text:
Unable to validate "27C" as chunk length header

I don't know how to reproduce problem using only this library, but with WyriHaximus/react-guzzle-psr7 this code
<?php

require_once __DIR__ . '/vendor/autoload.php';

$loop = React\EventLoop\Factory::create();
$handler = new WyriHaximus\React\GuzzlePsr7\HttpClientAdapter($loop);
$client = new GuzzleHttp\Client([
    'handler' => GuzzleHttp\HandlerStack::create($handler),
]);

$request = new GuzzleHttp\Psr7\Request('GET', 'https://wizzair.com/');
$promise = $client->sendAsync($request)->then(function (Psr\Http\Message\ResponseInterface $response) {
    echo (string)$response->getBody();
});

$promise->wait();

produces
PHP Fatal error:  Uncaught Exception: Unable to validate "27C" as chunk length header in /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php:122
Stack trace:
#0 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php(70): React\HttpClient\ChunkedStreamDecoder->iterateBuffer()
#1 [internal function]: React\HttpClient\ChunkedStreamDecoder->handleData('="Original" src...', Object(React\Stream\Stream))
#2 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Array, Array)
#3 /home/mateusz/git/react-guzzle-test/vendor/react/stream/src/Stream.php(173): Evenement\EventEmitter->emit('data', Array)
#4 [internal function]: React\Stream\Stream->handleData(Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#5 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(232): call_user_func(Array, Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#6 /home/mat in /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/Request.php on line 150

Hey thank you for reporting your issue. By the looks of it you're calling $promise->wait(); which forces the promise to resolve and blocks the loop. Running the loop the normal way, $loop->run(); will ensure the loop isn't blocked. I've just tried your URL with this example and had no issues what so ever: https://github.com/WyriHaximus/react-guzzle-psr7/blob/master/examples/basic.php
This should resolve your issue, so I'll close this for now. If you feel this problem persists, please report back and we can reopen this 👍

With other url's my code is not blocking.
When I change my code to
<?php

require_once __DIR__ . '/vendor/autoload.php';

$loop = React\EventLoop\Factory::create();
$handler = new WyriHaximus\React\GuzzlePsr7\HttpClientAdapter($loop);
$client = new GuzzleHttp\Client([
    'handler' => GuzzleHttp\HandlerStack::create($handler),
]);

$request = new GuzzleHttp\Psr7\Request('GET', 'https://wizzair.com/');
$promise = $client->sendAsync($request)->then(function (Psr\Http\Message\ResponseInterface $response) {
    echo (string)$response->getBody();
}, function (Exception $e) {
    echo $e;
});

$loop->run();

I get
Exception: Unable to validate "27C" as chunk length header in /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php:122
Stack trace:
#0 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php(70): React\HttpClient\ChunkedStreamDecoder->iterateBuffer()
#1 [internal function]: React\HttpClient\ChunkedStreamDecoder->handleData('="Original" src...', Object(React\Stream\Stream))
#2 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Array, Array)
#3 /home/mateusz/git/react-guzzle-test/vendor/react/stream/src/Stream.php(173): Evenement\EventEmitter->emit('data', Array)
#4 [internal function]: React\Stream\Stream->handleData(Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#5 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(232): call_user_func(Array, Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#6 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(201): React\EventLoop\StreamSelectLoop->waitForStreamActivity(NULL)
#7 /home/mateusz/git/react-guzzle-test/test.php(18): React\EventLoop\StreamSelectLoop->run()
#8 {main}

Next RuntimeException: An error occurred in the underlying stream in /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/Response.php:90
Stack trace:
#0 [internal function]: React\HttpClient\Response->handleError(Object(Exception))
#1 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Array, Array)
#2 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php(122): React\HttpClient\ChunkedStreamDecoder->emit('error', Array)
#3 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php(70): React\HttpClient\ChunkedStreamDecoder->iterateBuffer()
#4 [internal function]: React\HttpClient\ChunkedStreamDecoder->handleData('="Original" src...', Object(React\Stream\Stream))
#5 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Array, Array)
#6 /home/mateusz/git/react-guzzle-test/vendor/react/stream/src/Stream.php(173): Evenement\EventEmitter->emit('data', Array)
#7 [internal function]: React\Stream\Stream->handleData(Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#8 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(232): call_user_func(Array, Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#9 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(201): React\EventLoop\StreamSelectLoop->waitForStreamActivity(NULL)
#10 /home/mateusz/git/react-guzzle-test/test.php(18): React\EventLoop\StreamSelectLoop->run()
#11 {main}

Next RuntimeException: An error occured in the response in /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/Request.php:150
Stack trace:
#0 [internal function]: React\HttpClient\Request->React\HttpClient\{closure}(Object(RuntimeException), Object(React\HttpClient\Response))
#1 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Object(Closure), Array)
#2 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/Response.php(94): React\HttpClient\Response->emit('error', Array)
#3 [internal function]: React\HttpClient\Response->handleError(Object(Exception))
#4 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Array, Array)
#5 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php(122): React\HttpClient\ChunkedStreamDecoder->emit('error', Array)
#6 /home/mateusz/git/react-guzzle-test/vendor/react/http-client/src/ChunkedStreamDecoder.php(70): React\HttpClient\ChunkedStreamDecoder->iterateBuffer()
#7 [internal function]: React\HttpClient\ChunkedStreamDecoder->handleData('="Original" src...', Object(React\Stream\Stream))
#8 /home/mateusz/git/react-guzzle-test/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(64): call_user_func_array(Array, Array)
#9 /home/mateusz/git/react-guzzle-test/vendor/react/stream/src/Stream.php(173): Evenement\EventEmitter->emit('data', Array)
#10 [internal function]: React\Stream\Stream->handleData(Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#11 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(232): call_user_func(Array, Resource id #96, Object(React\EventLoop\StreamSelectLoop))
#12 /home/mateusz/git/react-guzzle-test/vendor/react/event-loop/src/StreamSelectLoop.php(201): React\EventLoop\StreamSelectLoop->waitForStreamActivity(NULL)
#13 /home/mateusz/git/react-guzzle-test/test.php(18): React\EventLoop\StreamSelectLoop->run()

Other url's works, just wizzair is somehow special.

Your example works fine until I change url to https://wizzair.com/ . Then i get An error occured in the response.

I fix that https://github.com/reactphp/http-client/pull/77

authors: WyriHaximus mdrost

repo: reactphp/http-client


text:
Latest change to reactphp/stream broken header parser

Hi,
Please note, that RequestHeaderParser has maxSize around 4096. It does not work with latest react streams as there is a high chance the first buffer would be longer, than 4096 bytes

@nick4fake good catch, would you mind making a PR fixing that?

@WyriHaximus yes, doing that right now. :)

Awesome :+1:

Closed via #88

authors: WyriHaximus clue nick4fake

repo: reactphp/http


text:
Fixed become a prime sponsor button styling while hovering on it in max-width of 800px

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
This PR fixes the "Become a Prime sponsor" Button issue. The styling for the "Become a Prime Sponsor" button is not correct.
1 file changed, 3 insertions(+), 4 deletions(-)
Fixes #1268
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Tested the application after fixing the issue , everything is working fine.
Checklist:

I have performed a self-review of my own code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Screenshots or example output
vs-code-cahnges:-

Changed UI

Hi @letscodedanish! Thanks for your contribution! Is it mobile-friendly? Can you share a GIF/multiple photos to show how does this look on different screen sizes? Also make sure to update this branch with the main

Hi @letscodedanish! Thanks for your contribution! Is it mobile-friendly? Can you share a GIF/multiple photos to show how does this look on different screen sizes? Also make sure to update this branch with the main

@joshi-kaushal It's working fine with different screen sizes .
Screenshots:-

![Screenshot (487)](https://github.com/reactpl
https://github.com/reactplay/react-play/assets/112203113/7aca1229-b123-4b7a-9e9a-4f2b3495581a
video:-
https://github.com/reactplay/react-play/assets/112203113/5eb1d336-292f-435f-b0ea-7893acc31943

Please review it @joshi-kaushal .

@joshi-kaushal please request a review from someone.

@priyankarpal please have a look on it.

@letscodedanish please check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/

repo: reactplay/react-play


text:
reactstrap Modal vs. React error boundaries

react: 16.2.0, reacstrap: 5.0.0-beta
I'm trying to add a React 16 error boundary to my application and noticed that componentDidCatch() in the error boundary component is not triggered for errors caused by Modal components. I'm following the standard example code from here: https://reactjs.org/docs/error-boundaries.html
Basic structure to show the problem
<ErrorBoundary>
    <Container>
       ... some "normal" component here ... (A)
    </Container>
   <Modal
         isOpen={this.state.isOpen}>
     .... the children of the Modal....     (B)
   </Modal>
</ErrorBoundary>

If I go to some render() method inside A and add a throw new Error('test'); then ErrorBoundary::componentDidCatch() is called. That proves that ErrorBoundary is working as it should.
If I go to some render() method inside B and add a throw new Error('test'); then ErrorBoundary::componentDidCatch() is not called, i.e. the error is not handled just as if the error boundary wouldn't have been added. The React debug tools show the Modal and its children as children of ErrorBoundary so according to the documentation it should catch the error.
Has somebody an idea what is so special about Modal that makes error boundaries fail? Is it maybe because the actual DOM node for Modal is added parallel to the React DOM node under <body>? I.e. not being inside the React DOM tree would confuse React lookup code?
Any ideas?

It's most likely due to reactstrap using the old unstable_renderIntoSubtree which was replace in react 16 with render_portal.
#796 changed reactstrap's Modal to use react-portal which uses react v16 and its official API for creating portals; has a fallback for react v15.
The PR mentioned above has been merged but there has not been a release since. I need to cut a release, I am hoping this solves this issue.

Thanks for the update. I'll verify this once the release is available.
For now I have found an acceptable workaround by replacing every instance of Modal with ModalWithBoundary. The drop-in replacement wraps the children into an ErrorBoundary:
export default class ModalWithBoundary extends React.Component {
    render() {
        const { children, ...remainder } = this.props;
        return (
            <Modal {...remainder}>
                <ErrorBoundary children={children}/>
            </Modal>
        );
    }
}

reactstrap-5.0.0.beta.2 does fix the issue, but I can't upgrade due to PR #870.

Fixed by reactstrap 5.0.0-beta.3. Thanks.

repo: reactstrap/reactstrap


text:
fix(cocoapods): fix an issue with podspecs minimum deployment target

increase the minimum deployment target due to SwiftSoup increasing theirs to 11.0.

I suppose the other option here is to add a more restrictive version to SwiftSoup. Not sure which you would prefer.

Hi Jacob,
I bumped the minimum version to iOS 11 already in develop.
However I also fixed SwiftSoup to 2.5.3, because 2.6.0 requires Xcode 14 which is not yet available with the GitHub actions: https://github.com/readium/swift-toolkit/blob/563667848b42895acddb25c435b4e2570304cfea/Support/CocoaPods/ReadiumNavigator.podspec#L23

authors: jspizziri mickael-menu

repo: readium/swift-toolkit


text:
POC Recent searches

A potential idea to close #33
This obviously needs some polish when it comes to styling, and a few implementation details. But what do you think of the overall concept? I tried following the Algolia example when it comes to behaviour (storing only the searches that were actually clicked).

@humitos it is done, but just to make things easier for me (not having to worry about existing structure) when I implement the clear feature. I'm already 50% done, so it shouldn't be long.

How are you all testing this? I tried on https://readthedocs-client--244.org.readthedocs.build/en/244/ but I assume that shouldn't work at all

@agjohnson I've been testing locally. I'm not sure of other options, but I'm sure @humitos can help
@humitos ok I added the clear search functionality (it took me forever because svg in the button was capturing click events for some reason, so nothing worked and I was stuck for a while and had no idea what was going on 😆 ), so I think this can now be merged as the first iteration

@zanderle looks good to me 👍🏼

@agjohnson

How are you all testing this?

You can either:

Use npm run dev and go to http://localhost:8000/, which used hardcoded search results no matter what you type
Tell wrangler to use this version by editing https://github.com/readthedocs/common/blob/760ffb301809d614db6531ca93a08c4104f766b8/dockerfiles/force-readthedocs-addons.js#L17-L18 to use http://localhost:8000/readthedocs-addons.js and then use npm run dev  plus inv docker.up to hit any documentation you have built in your development instance with addons enabled.

I tried on readthedocs-client--244.org.readthedocs.build/en/244 but I assume that shouldn't work at all

This won't work because the js file is injected by Cloudflare --and it uses the production version-- not by this repository.

Thanks for the work and the review here. I updated this PR with the latest changes and I will merge it once checks pass 🚀

authors: agjohnson humitos zanderle

repo: readthedocs/addons