text:
[Bug] Streaming example not working (even locally)

Expected Behavior
Setting "PYTHON_ENABLE_INIT_INDEXING": "1" and "PYTHON_ISOLATE_WORKER_DEPENDENCIES": "1" as app settings, installing the latest azurefunctions-extensions-http-fastapi streaming library, and running func start should be successful.
And i would expect the package import statements to work. The from azurefunctions.extensions.http.fastapi import Request, StreamingResponse which is mentioned here is completely wrong. It should be from azure.functions.extension.fastapi import Request, StreamingResponse
Actual Behavior
When running locally, the app throws following exception
Exception: FunctionLoadError: cannot load the stream_count function: 'req' binding type "httpTrigger" and dataType "None" in function.json do not match the corresponding function parameter's Python type annotation "Request"
Steps to Reproduce

Follow the steps listed in Azure Functions Support for Http Streams in Python.
Run func start

Relevant code being tried
import azure.functions as func
from azure.functions.extension.fastapi import Request, StreamingResponse

app = func.FunctionApp(http_auth_level=func.AuthLevel.ANONYMOUS)

def generate_count():
    """Generate a stream of chronological numbers."""
    count = 0
    while True:
        yield f"counting, {count}\n\n"
        count += 1

@app.route(route="stream", methods=[func.HttpMethod.GET])
async def stream_count(req: Request) -> StreamingResponse:
    """Endpoint to stream of chronological numbers."""
    return StreamingResponse(generate_count(), media_type="text/event-stream")

Relevant log output
[2024-07-22T14:39:32.701Z] Worker failed to index functions
[2024-07-22T14:39:32.702Z] Result: Failure
[2024-07-22T14:39:32.702Z] Exception: FunctionLoadError: cannot load the stream_count function: 'req' binding type "httpTrigger" and dataType "None" in function.json do not match the corresponding function parameter's Python type annotation "Request"
[2024-07-22T14:39:32.702Z] Stack:   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.10/LINUX/X64/azure_functions_worker/dispatcher.py", line 342, in _handle__worker_init_request
[2024-07-22T14:39:32.702Z]     self.load_function_metadata(
[2024-07-22T14:39:32.702Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.10/LINUX/X64/azure_functions_worker/dispatcher.py", line 393, in load_function_metadata
[2024-07-22T14:39:32.702Z]     self.index_functions(function_path, function_app_directory)) \
[2024-07-22T14:39:32.702Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.10/LINUX/X64/azure_functions_worker/dispatcher.py", line 773, in index_functions
[2024-07-22T14:39:32.702Z]     loader.process_indexed_function(
[2024-07-22T14:39:32.702Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.10/LINUX/X64/azure_functions_worker/loader.py", line 139, in process_indexed_function
[2024-07-22T14:39:32.702Z]     function_info = functions_registry.add_indexed_function(
[2024-07-22T14:39:32.702Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.10/LINUX/X64/azure_functions_worker/functions.py", line 450, in add_indexed_function
[2024-07-22T14:39:32.702Z]     deferred_bindings_enabled) = self.validate_function_params(
[2024-07-22T14:39:32.702Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.10/LINUX/X64/azure_functions_worker/functions.py", line 243, in validate_function_params
[2024-07-22T14:39:32.702Z]     raise FunctionLoadError(
[2024-07-22T14:39:32.702Z] .

requirements.txt file
azure-functions
azure-functions-extension-fastapi==1.0.0a2

Where are you facing this problem?
Local - Core Tools
Function app name
No response
Additional Information
No response

Thank you @hallvictoria for your response and good catch!
It seems like there is a copycat which pretends to publish your package under a similiar name:
https://pypi.org/project/azure-functions-extension-fastapi/
This is also why my code did not work. Following your explanation it worked instantly.
We should probably report this!

Glad I could help!
Thanks for bringing awareness to the azure-functions-extension-fastapi package. We'll take a look into it to prevent any further issues or confusion.

Thank you @hallvictoria for your response and good catch!
It seems like there is a copycat which pretends to publish your package under a similiar name:
https://pypi.org/project/azure-functions-extension-fastapi/
This is also why my code did not work. Following your explanation it worked instantly. We should probably report this! Looks like a classic dependency confusion attack, the version in the fake package is slightly higher than the original one... Also google rates the fake one a lot better, making the original one impossible to find if not searching explicitly in the pypi search.

sorry for this experimental legacy package causing any confusion @fabge. the package is removed now.

source: gharchive/issue

authors: YunchuWang fabge hallvictoria

repo: Azure/azure-functions-python-worker

license: MIT

license_type: permissive

license_source: github-api


text:
ci: Auto pull request from release branch into main after release publish

Once a new release is published (from dev), this workflow will run to create a PR from that branch to main using the title and tag of the release.
This also updates our conventional PR title check to exclude PRs to the main branch
Example workflow:

Release created: https://github.com/c-ryan-k/azure-iot-ops-cli-extension/releases/tag/v1.2.3b45
Action Run: https://github.com/c-ryan-k/azure-iot-ops-cli-extension/actions/runs/8024344609
PR created: https://github.com/c-ryan-k/azure-iot-ops-cli-extension/pull/5

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production

[ ] It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

[ ] If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
[ ] In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
[ ] Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
[ ] Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
[ ] Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
[ ] Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).

Closing for now since github doesn't allow separate merge policies per-branch, will reassess.

source: gharchive/pull-request

repo: Azure/azure-iot-ops-cli-extension


text:
The id of customIpPrefix with customIpPrefix name in uppercase returned by 'Public IP Prefixes - Create Or Update' API

The id of customIpPrefix with customIpPrefix name in uppercase returned by 'Public IP Prefixes - Create Or Update' API :
Repro steps:
Create a publicIpPrefix resource (specify customIPPrefix property)
The id of "customIpPrefix" in the following request body:
   "customIPPrefix": {
        "id": /subscriptions/XXX/resourceGroups/test/providers/Microsoft.Network/customIpPrefixes/testpip01"
      }

The id of "customIPPrefix" returned in the following response body:
 "customIpPrefix": {
      "id": "/subscriptions/XXX/resourceGroups/test/providers/Microsoft.Network/customIPPrefixes/testpip01"
    }

Expected:
The id of customIpPrefix with custom Ip Prefix name should be customIpPrefixes.
Actual:
The id of customIpPrefix with custom Ip Prefix name is customIPPrefixes.

it's worth calling out that the JSON keys aren't the same here too?

it's worth calling out that the JSON keys aren't the same here too?

Yes, the JSON keys are not the same too. The customIPPrefix in request body but the customIpPrefix returned by the 'Public IP Prefixes - Create Or Update' API.

authors: sinbai tombuildsstuff

repo: Azure/azure-rest-api-specs


text:
Alert Rules - add alert details override changes and PUT example

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run

@dw511214992 Can we get this approved please?

@raosuhas thanks for the sign off. Can you please merge the PR as well?

authors: ShaniFelig ruowan


text:
Microsoft.Security new base api-version 2024-05-01-preview

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[x] Other, please clarify:

New baseline API version for RP

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

The first commit needs to be an exact copy of the previous api version. All new changes should only be added in the subsequent commits.
This is explained in detail here (If using Open API which is recommended)  https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) :  https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" label once you have fixed this issue.

@ms-henglu since I'm doing it manually I must have done something wrong here and it isn't considered an exact copy - could you please point it out to help me solve it quickly? please note that we do not have a baseline API yet that we can copy - this will be the first one

Hi @eliagrady , this PR adds a new api-version to include the swaggers in previous api-versions, right?
And there're no changes except the api-versions, correct?

Hi @eliagrady , this PR adds a new api-version to include the swaggers in previous api-versions, right?
And there're no changes except the api-versions, correct?

Right now there isn't any other change other than the merger of previous API versions

/azp run

@ms-henglu before we continue making changes (fixes, alignment in rebranding Azure Security Center to Microsoft Defender for Cloud etc.)- I'd rather to get preliminary feedback regarding this proposed change if you don't mind me asking

@eliagrady I can see you are introducing the new api version 2024-05-01-preview based of various different versions. Please go ahead to make changes and follow the PR review workflow diagram provided in the summary.

/azp run

/azp run

/azp run

I see this PR is in the review queue, but it looks like there are a number of linter/model/etc validations to be addressed, plus a confusing commit history, and so I think it might be better to prioritize reviewing other PRs, until I am more clear that this is ready to review + merge.

@TimLovellSmith this PR is currently in the state of NotReadyForARMReview because it has un-approved breaking changes, but it also ARMChangesRequested because I see you folks reviewed it in spite of un-approved breaking changes. If you have any concerns about this setup, let me know.

There are a bunch of breaking changes reported on this PR. Please get a breaking changes approval from Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

We've been over this @razvanbadea-msft , @mikekistler already marked it as benign as there are no breaking changes in this PR - this PR is intended to use the exact latest APIs and merging them under a single api-version - all other commits are intended to improve the quality of the checks pipelines by fixing small swagger authoring mistakes that were previously unhandled - and establishing a good baseline for Microsoft.Security RP to use.

/azp run

@razvanbadea-msft fixed

authors: TimLovellSmith eliagrady gary-x-li konrad-jamrozik ms-henglu razvanbadea-msft


text:
Examples Changes and move VMSS list operation inside fleets resource

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[x] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

ListVMSS api will be used with fleets resource and we don't want VMSS to be exposed as a new resource. Customers are using it the way it is being defined here and it is a bug fix in swagger modeling. Please help in approving the breaking change.


text:
[Compute] [SIG] [BugFix] Remove ID as required because update gallery image version is failing when ID is not present

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

reassign to @xccc-msft since he has the context of the change

@NullMDR Do you have any idea for CI failure? The swagger change is quite simple here.

authors: AutorestCI azuresdkci jerryc3 xccc-msft yungezz


text:
Add nvaSku property for NetworkVirtualAppliance

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[x] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@MyronFanQiu could you please merge?

authors: AutorestCI azuresdkci naveenchekuri number213


text:
Use retriable tasks

Tasks with intermittent failures can be retried if they are made idempotent on retry -- https://learn.microsoft.com/en-us/azure/devops/release-notes/2021/pipelines/sprint-195-update
Build might be more difficult to do than generate (because build requires generate).

Used once here: https://github.com/Azure/azure-sdk-for-cpp/pull/4635

repo: Azure/azure-sdk-for-cpp


text:
Compatibility improvement for striped blob

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

/azp run cpp - storage

/azp run cpp - storage


text:
[AutoPR timeseriesinsights/resource-manager] typo: timeseriesinsights/resource-manager/Microsoft.TimeSeriesInsights

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4810

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/3638

repo: Azure/azure-sdk-for-go


text:
[QUERY] Java Azure Async Client for ESB: Parallel vs Sequential read

Query/Question
I would like to get the messages from a single queue sequentially using the async client.
During debugging I can see that there are 8 threads listening one the queue. Also when I set a breakpoint on the message handler other messages are read meanwhile.
But I need a true sequential processing: Wait for a message, process it, release it from the queue, pickup the next message.
Can anybody spot my error in below code?
Why is this not a Bug or a feature Request?
I have read the documentation extensively, the docs, the Java samples and also Reactive programming but have not found any solution. Hence I assume the problem is on my side, you might actually consider adding documentation in that regards. Should be a typical question.
Setup (please complete the following information if applicable):

OS: Linux

IDE : Eclipse

azure-storage-file-datalake: v12.2.0

azure-messaging-servicebus: v7.0.0
 	receiver = new ServiceBusClientBuilder()
 		    .connectionString(servicebusconnectionstring)
 		    .receiver()
 		    .queueName(queuename)
 		    .buildAsyncClient();
 	subscription = receiver
 			.receiveMessages()
 			.map(message -> {
 			    byte[] payload = message.getBody().toBytes();
 			    return handleMessage(payload, message);
 			})
 			.subscribe(aVoid -> {
 				}, error -> {
 					sendError(error);
 				}, () -> {
 					logger.info("Azure queue reader is shut down");
 				});

There are few things to consider while designing your application.

If you are needing absolute guarantee in maintaining the order, consider session queue. Here is more detail about it https://docs.microsoft.com/en-us/azure/service-bus-messaging/message-sessions

Sample : https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusSessionProcessorSample.java
Our processor are using sync receiver in background.
When you have async receiver client, like in your code above, keep in mind that. Service does not stop from creating more clients from other applications or other part of your code. So multiple clients could be reading from same queue. Session queue is solution where you can ensure that only once client can read at one point in time.
Using Project Reactor  API and and async receiver client, you may consider using concatMap operator, which  sequentially and preserving order https://projectreactor.io/docs/core/release/api/reactor/core/publisher/Flux.html#concatMap-java.util.function.Function-   but this can not stop other clients from reading messages from the queue.
I do not see any issue in your code above, you are using map(). I did try with 100 messages in a queue with one async client client and I am receiving in order. Where do you see 8 thread listening ? Please provide more details.

There are few things to consider while designing your application.

If you are needing absolute guarantee in maintaining the order, consider session queue. Here is more detail about it https://docs.microsoft.com/en-us/azure/service-bus-messaging/message-sessions

Sample : https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/ServiceBusSessionProcessorSample.java
Our processor are using sync receiver in background.
When you have async receiver client, like in your code above, keep in mind that. Service does not stop from creating more clients from other applications or other part of your code. So multiple clients could be reading from same queue. Session queue is solution where you can ensure that only once client can read at one point in time.
Using Project Reactor  API and and async receiver client, you may consider using concatMap operator, which  sequentially and preserving order https://projectreactor.io/docs/core/release/api/reactor/core/publisher/Flux.html#concatMap-java.util.function.Function-   but this can not stop other clients from reading messages from the queue.
I do not see any issue in your code above, you are using map(). I did try with 100 messages in a queue with one async client client and I am receiving in order. Where do you see 8 thread listening ? Please provide more details.

Okay. Your post caused me trying to create the most simple test and in essence you are right, there is no parallel processing. I omitted the essential part: The handlemessage() method is using an async file reader to read the file.
So what happens is that a message is received, the handlemessage starts the file read and thus is finished right away, the next message is read. So when I set a breakpoint inside the async file reader, then multiple messages are processed.
I'll close this request and create a new one.
Thanks for your help, sorry for my mistake!

authors: hemanttanwar wernerdaehn

repo: Azure/azure-sdk-for-java


text:
Missing H1 for cosmos-spark_3-1_2-12-readme

The cosmos-spark_3-1_2-12-readme landing page article on https://github.com/Azure/azure-docs-sdk-java/blob/main/docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md has an H2 instead of an H1 for the title header.
The Readme at sdk/cosmos/azure-cosmos-spark_3-1_2-12/README.md is using the H2 instead of H1 for title header. Can the readme be updated and re-imported to Docs?

It is intentional because it is pulled-in (inlined) form the public documentation (which is in a separate repo) under an H1 header.

@FabianMeiswinkel This is part of a cleanup of warnings in Docs, and this document is throwing a Missing H1 in the error logs.

authors: FabianMeiswinkel v-alje


text:
[AutoPR datalake-analytics/data-plane] Add hierarchyQueueNode into JobInformation(Basic)

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3942

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/2401


text:
[EngSys-CredScan] Remove some supppression and run the pipeline

Remove unused suppressions in the CredScan file.

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1927708&view=results

/check-enforcer evaluate

@mssfang you'll need to /check-enforcer override. There are no pipelines defined for this code path, so evaluate won't detect anything.

/check-enforcer override

authors: benbp mssfang sima-zhu


text:
mgmt, update network to 2023-05-01

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


text:
fixShowTablesOrShowDatabasesOnlyReturnInCorrectResult

Fixed issues:

When there are multiple databases under the same account, SHOW DATABASES IN cosmosCatalog only return one database
When there are multiple containers under the same database, SHOW TABLES FROM cosmosCatalog.$databaseName only return one container

Notes: spark 3.1, 3.2 does not support SHOW DATABASES IN cosmosCatalog, so the tests to validate all databases can be returned is only added in spark 3.3, 3.4 and 3.5

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - spark

/check-enforcer override


text:
Dependency package @opentelemetry/instrumentation-mysql has a new version available

We have identified a dependency on version 0.34.5 of @opentelemetry/instrumentation-mysql. A new version (0.35.0) is available for upgrade.
Following are the steps to upgrade package dependency.

Understand the breaking changes between the version being used and the version you want to upgrade to.

Identify all packages that take a dependency on this package.

Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

Run rush update to ensure the new version is pulled in.

Make relevant changes to absorb the breaking changes.

Repeat steps 3 to 5 for each of the packages that have a dependency on this package.

upgraded

authors: azure-sdk jeremymeng

repo: Azure/azure-sdk-for-js


text:
vscode eslint extension doesn't run correctly when opened against the repository root

Open VSCode against the root of the repo
Open a TS file inside one of our packages
Look at the ESLint output channel (in the command palette)

[Info  - 11:52:23 AM]
Failed to load the ESLint library for the document c:\src\azure-sdk-for-js\package.json

To use ESLint please install eslint by running npm install eslint in the workspace folder azure-sdk-for-js
or globally using 'npm install -g eslint'. You need to reopen the workspace after installing eslint.

If you are using yarn or pnpm instead of npm set the setting `eslint.packageManager` to either `yarn` or `pnpm`
Alternatively you can disable ESLint for the workspace folder azure-sdk-for-js by executing the 'Disable ESLint' command.
[Info  - 11:52:23 AM] ESLint library loaded from: C:\src\azure-sdk-for-js\common\temp\node_modules\.registry.npmjs.org\eslint\6.6.0\node_modules\eslint\lib\api.js
[Error - 11:52:23 AM]
Failed to load plugin '@typescript-eslint' declared in 'sdk\.eslintrc.json': Cannot find module '@typescript-eslint/eslint-plugin'
Require stack:
- C:\src\azure-sdk-for-js\__placeholder__.js
Referenced from: C:\src\azure-sdk-for-js\sdk\.eslintrc.json
Happened while validating C:\src\azure-sdk-for-js\sdk\storage\storage-blob\src\log.ts
This can happen for a couple of reasons:
1. The plugin name is spelled incorrectly in an ESLint configuration file (e.g. .eslintrc).
2. If ESLint is installed globally, then make sure '@typescript-eslint/eslint-plugin' is installed globally as well.
3. If ESLint is installed locally, then '@typescript-eslint/eslint-plugin' isn't installed correctly.

I tried adding eslint and the plugins we use to the root package.json, but while that got rid of the above errors, it didn't actually supply lint corrections to any files. It did, however, occasionally supply a callstack where v8 ran out of memory.

The short answer is that if the current version of the azure sdk eslint plugin is published, we will be able to eliminate this problem by getting rid of sdk/.eslintrc.js, since the new version includes all the settings from sdk/.eslintrc.js as an extendable ruleset.
--
This is related to how eslint resolves various kinds of files/packages. If we weren't using Rush/PNPM, then the CLI would also fail to run -- not just from the monorepo root, but even from the package folder. If you look at the contents of node_modules/.bin/eslint in any of the packages that depend on it, you'll see that PNPM has actually overwritten the binary and replaced it with a shim script that sets up NODE_PATH to make it work.
See this: microsoft/rushstack#1432
This has the unfortunate side-effect of making sdk/.eslintrc.js work when it really shouldn't.  When vscode-eslint tries to run the linter, it doesn't have that NODE_PATH setting and it fails like it always should have.
The reason this happens is because of how ESLint resolves the locations of things. It looks for files (such as tsconfig.json) relative to CWD using normal path rules. It resolves plugins (such as @azure/eslint-plugin-azure-sdk relative to the eslintrc file for the project using node modules rules, so they must be dependencies of the project. It resolves extensions that are not builtins or provided by a plugin, however, relative to the file where they are referenced (if you import a plugin and then use its recommended config, then anything it extends has to be a dependency of the plugin, and second-level plugins that it uses have to be peer dependencies that become direct dependencies of the project using the plugin).
When our sdk/.eslintrc.js says extends: [ ... , "prettier" ] it's trying to use node resolution to find a package named eslint-config-prettier relative to the sdk/ folder, which it won't be able to resolve... except when PNPM has patched the NODE_PATH to hard include the shared node_modules folder in common/.
If you create a symbolic link sdk/node_modules to ../common/temp/node_modules, then the whole thing will suddenly start to work because it will then have a node_modules folder next to the eslintrc where it can resolve eslint-config-prettier. But creating this symlink breaks the dependency isolation of Rush.
Take a look at this issue I opened on vscode-eslint when I was debugging this for more context: microsoft/vscode-eslint#770

I believe this was resolved with the migration of eslint configs to the new plugin. If anyone finds this still affects a package, please open a new issue specific to that package. Closing.

authors: willmtemple xirzec


text:
lint: @azure/azure-sdk/ts-doc-internal doesn't work with exported function

Not sure why, but the below function trips @azure/azure-sdk/ts-doc-internal even though it is a valid exported function:
/**
 * Escapes an odata filter expression to avoid errors with quoting string literals.
 * Example usage:
 * ```ts
 * const baseRateMax = 200;
 * const ratingMin = 4;
 * const filter = odata`Rooms/any(room: room/BaseRate lt ${baseRateMax}) and Rating ge ${ratingMin}`;
 * ```
 * For more information on supported syntax see: https://docs.microsoft.com/en-us/azure/search/search-query-odata-filter
 * @param strings
 * @param values
 */
export function odata(strings: TemplateStringsArray, ...values: unknown[]): string {
  const results = [];
  for (let i = 0; i < strings.length; i++) {
    results.push(strings[i]);
    if (i < values.length) {
      results.push(escapeQuotesIfString(values[i], strings[i]));
    }
  }
  return results.join("");
}

Needs investigation. Marking up for grabs.


text:
[Identity] Creating a sample.env on the samples folder

Fixes #9691

@willmtemple I made this issue to track what you describe: https://github.com/Azure/azure-sdk-for-js/issues/10684 I'll have an update for that later this month.


text:
[AutoPR blueprint/resource-manager] Fix model type regression

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5535

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/2002


text:
[engsys] Upgrade @types/mime to ^3.0.1

Packages impacted by this PR

@azure/api-managemnet-custom-widgets-tools

Issues associated with this PR

Fixes #22843

Describe the problem that is addressed by this PR
Upgrades type definitions (@types/mime) to ^3.0.1 to match major version with the actual mime dependency.

API change check
API changes are not detected in this pull request.

authors: azure-sdk timovv


text:
Fix artifact location

Fix artifact copying introduced by https://github.com/Azure/azure-sdk-for-js/pull/31420

/azp run js - template


text:
Emphasize that a ServiceBusSender can be used to send to both session and non-session entities

In UX studies, when users were asked to send session messages, they would often be drawn to the CreateSessionProcessor method since this has Session in the name, and it isn't obvious what a Processor would do. We can alleviate this somewhat by making it clear in the ServiceBusSender docs that it can be used for session entities. We can also try to emphasize in the Processor docs that this is used for receiving messages, not sending messages, and mention that it uses ServiceBusReceivers or ServiceBusSessionReceivers (for ServiceBusSessionProcessor) under the hood.

Closed with https://github.com/Azure/azure-sdk-for-net/pull/11592

authors: JoshLove-msft ShivangiReja

repo: Azure/azure-sdk-for-net


text:
InnerErrors

Does the service return one or multiple inner errors?
As an example, in TA we only care about the depends inner error so we only expose that Inner Error

Asked service team

After following up with the service team, they only have one InnerError, so we implemented the same logic as TA


text:
[QUERY] How to return the task to the calling of RegisterMessageHandler on subscriptionClient

Query/Question
I am trying to receive the messages on a service bus topics using subscriptionClient by using RegisterMessageHandler option.
Library  used is  Microsoft.Azure.ServiceBus 5.1.2
I am passing a task as parameter as below
subscriptionClient.RegisterMessageHandler(ReceiveMessagesAsync, messageHandlerOptions);
On the ReceiveMessageAsync  Task i am able to receive all the messages on the topic but when all the messages are consumed on the topic and finally when we call  the CompleteAsync Task, the  thread is not completing , it is still continuing as a long running task and the control is lost.
Is there a way we can stop the thread and bring the control back to the calling function/task.
Environment:

Microsoft.Azure.ServiceBus 5.1.2
Azure Functions,Windows 10 .NET Framework 4.8
Visual Studio 16.7.2

Thank you for your feedback.  Tagging and routing to the team best able to assist.

@kannanunnikrishnan can you share a code repro?

closing due to inactivity. Please open a new issue with a repro.
Thanks

authors: axisc jsquire kannanunnikrishnan


text:
EventHubTrigger failed to Start

[EventHubTrigger failed to Start due to the following error message in the screenshot.
The 'PrintEventHubTrigger' function is in error: Microsoft.Azure.WebJobs.Host: Error indexing method 'PrintEventHubTrigger'. Microsoft.Azure.WebJobs.Host: Multiple properties named 'ContentType' found in type 'EventData'.
Microsoft.Azure.WebJobs.Extensions.EventHubs - 5.1.0]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c0920fd-950b-1473-c8de-10204dca2fbd
Version Independent ID: e66c4847-14aa-5f33-db91-92cb5b7895aa
Content: EventData.ContentType Property (Azure.Messaging.EventHubs) - Azure for .NET Developers
Content Source: xml/Azure.Messaging.EventHubs/EventData.xml
Service: azure
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Hi @Vivek-Negi-GL.   Thank you for reaching out and we regret that you're experiencing difficulties.    This is the result of a dependency in the Functions tooling which was updated in the Azure hosts but has not yet updated in the Functions Core Tools.   The error will occur when running with the function tools locally if your application directly references v5.7.0 of the Azure.Messaging.EventHubs package.  Remediation would be to move to v5.6.2 until the function tools package v4.1.3.17473 is released.
More information can be found in #2830 in the WebJobs repository.  I'm going to mark this as addressed, but please feel free to unresolve if you'd like to continue the discussion.

authors: Vivek-Negi-GL jsquire


text:
Integrate logging into the Event Processor Client and associated types

Summary
As a library, it is important for the Event Hubs client library to provide a means for developers using it to understand its activities and the sequence of operations that comprise them, in order to assist in development and debugging efforts.   The standard .NET event source is used for logging within the library, but has not yet been integrated with the EventProcessorClient.
Scope of Work

The EventProcessorClient conforms to the patterns elsewhere in the Event Hubs client library for logging the beginning and completion of key operations, as well as any errors that occurred during them.

Operation logging should extend to areas that are likely to be of interest to developers using and troubleshooting the of the processor client.

Event source data is exposed alongside the other client library types; the EventProcessorClient does not employ its own event source.

Success Criteria

The EventProcessorClient has integrated logging via the existing event source, capturing key operations and following the established patterns within the Event Hubs client library.

The existing test suite continues to produce deterministic results and pass reliably.

will this also include instrumentation for Application Insights? It seems to me the preview library is lacking that so far. Or did I miss something? thanks

will this also include instrumentation for Application Insights? It seems to me the preview library is lacking that so far. Or did I miss something? thanks

Hi Sebastian.  Thank you for your feedback.
I'm happy to say that the Event Hubs client is instrumented for tracing and supports both Application Insights and Open Telemetry.  Because of the compatibility with Open Telemetry, you may need to upgrade to the most recent Application Insights library, as there was a fairly recent contribution for an adapter to enable that support.

Hi Jesse,
I just double checked and I'm on the latest version of the SDKs. I have a producer (ASP.NET Core 3.1) that uses the EventHubProducerClient to send messages. This part seems to be instrumented, as it shows up just fine in my AppInsights application map - without me adding anything extra.
However, the consumer part is a .NET Core 3.1 BackgroundService that uses the Azure.Messaging.EventHubs.Processor to read the messages from the event hub. The message processing does not seem to be instrumented on that end, or at least it does not show up in the Application Map (as I would expect it would?!).

(The arrow between frontend and backend only shows up since I manually added the correlation ID to my messages and reading them on the backend side).

I can confirm that we're creating a diagnostic scope within the processor for two scenarios:

When a checkpoint is written
When an event is read during partition processing and dispatched to the event handler provided

Beyond that, unfortunately, I'll have plead ignorance as I'm not familiar with the specifics around how our diagnostic scope abstraction interacts with the larger telemetry ecosystem.   If you think there may be a problem, would you be so kind as to log an issue and tag me in a comment?   That will let me route it to some folks who would have a deeper knowledge and better be able to assist.

authors: jsquire sebader


text:
Setting AMQP session incoming window size to unlimited for receivers

This fixes #6450.
The default incoming window size on an AMQP session is 5000. That means a session would accept 5000 unsettled incoming transfers and no more, if those transfers are not settled. For most customers, incoming messages will be completed or abandoned and this was never an issue. And this change makes no difference to majority of customers.
This issue specifically addresses the issue faced by those customer who only receive and never complete or abandon messages. The new window size doesn't mean they can receive unlimited number of transfers though, as service has its own limits and will force detach a link with too many unsettled deliveries.

cc @jsquire, @JoshLove-msft

cc @jsquire, @JoshLove-msft

Looks like we should make this change in the new library as well.

Any Idea when this will be released, what version and any tentative dates?

authors: JoshLove-msft Sandeep321 ramya-rao-a yvgopal


text:
Introducing new Microsoft.Azure.Monitor.dll for the Monitor team (formerly Insights)

Description
Introducing a new folder in this repo: monitor, which contains the code generated from the new Swagger specs folders called monitor, arm-monitor (PR merged recently https://github.com/Azure/azure-rest-api-specs/pull/936).
With this we are effectively introducing a new SDK dll called Microsoft.Azure.Monitor.dll intended to replace Microsoft.Azure.Insights.dll.
The contents of the dlls are almost identical with these differences:

Monitor.dll does not contain the old Metrics API
Some minor improvements derived from the process of validation of the Swagger spec.
One change due to the resolution of an issue with the Python CLI generation.
The Events operations were renamed to ActivityLogs, but their calls remain unchanged.

This name change is intended to avoid confusions with AppInsights artifacts and to align with the new name of our team.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[x] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

The errors don't seem to be coming from our code, but from Data Lake's.

@azuresdkci test this please

@twitchax  Please let us know how to handle this - should this be a new package, or a new version of Insights?  It looks liek the namespaces in AzureRm have not changed.  Needf to reach out to the PMs on the team to decide.

Based on previous discussions with them, this should be a separate package, and the old package will no longer ship (it was in preview).

Synced with them, and this should be a new package.

@markcowl: discussed the deprecation of the "Insights" package and redirection to the "Monitor" package...got the go ahead.

authors: gucalder markcowl shahabhijeet twitchax


text:
[Media] Resolve self review comments

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Media


text:
Autorest Regen Preview to 3.0.0-alpha.20230611.1 by Chun Yu from refs/pull/3412/head

Triggered from https://github.com/Azure/autorest.csharp/pull/3412

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.AI.OpenAI


text:
Increment version for storagecache releases

Increment package version after release of Azure.ResourceManager.StorageCache

API change check
API changes are not detected in this pull request.


text:
Generating control plane sdks for playwrighttesting

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run prepare-pipelines

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.PlaywrightTesting

authors: ArthurMa1978 ShreyaAnand azure-sdk


text:
Remove media compositions SDK's

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Merged the PR on behalf of @iaulakh

authors: iaulakh mikehang-msft


text:
add version and readMe or typespecProject information in ci output

Contributing to the Azure SDK
Fix https://github.com/Azure/azure-sdk-tools/issues/9221

emit version and typespecProject/readmeMd of ask package in sdk automation output

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Thanks @chunyu3
The change looks good to me, and please ensure it is validated in Test env.


text:
Add capability to send multiple events in one Send() call.

Add the ability for send to take a list of messages, failing if they don't fit in a single batch to maintain idempotency.
Adds tests for multisend.
Puts details of multisend into the changelog.

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer evaluate

/check-enforcer reset

/check-enforcer evaluate

authors: KieranBrantnerMagee praveenkuttappan

repo: Azure/azure-sdk-for-python


text:
[AutoPR cognitiveservices/data-plane/CustomWebSearch] Py conf in its own file

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4439

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2597


text:
Add test-proxy tests to azure-template

After test-proxy spinup is made part of the standard build processes, we need to exercise that in the template project under sdk/template/azure-template.

This issue is supplanted by the introduction of live tests. This build exercises exactly

repo: Azure/azure-sdk-tools


text:
Migrate "OpenAPI Hub: Adding new resource type or APIs to an existing API version" to Eng Hub

https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/209/OpenAPI-Hub-Adding-new-resource-type-or-APIs-to-an-existing-API-version

After taking a look at this document, most of the content has already been covered in https://eng.ms/docs/products/azure-developer-experience/design/tutorial/api-tutorial-1-branch
I have decided to not migrate this doc and deprecate it. If people start asking about it, I will move it

authors: MrJustinB maririos


text:
Azure DevEx Architecture Board: Introduction of Azure App Configuration

New SDK Review meeting has been requested.
Service Name: Azure App Configuration
Review Created By: Matthew Metcalf
Review Date: 3/1/2023 2:05 PM PT
Hero Scenarios Link: here
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links:
Description: Reviewing spring-cloud-azure-appconfiguration-config, spring-cloud-azure-appconfiguration-config-web, spring-cloud-azure-feature-management, spring-cloud-azure-feature-management-web. This review is for the 4.0 version of the libraries.
Detailed meeting information and documents provided can be accessed here

Meeting updated by Matthew Metcalf
Service Name: Azure App Configuration
Review Created By: Matthew Metcalf
Review Date: 3/1/2023 2:05 PM PT
Hero Scenarios Link: here
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links:
Description: Reviewing spring-cloud-azure-appconfiguration-config, spring-cloud-azure-appconfiguration-config-web, spring-cloud-azure-feature-management, spring-cloud-azure-feature-management-web. This review is for the 4.0 version of the libraries.
Detailed meeting information and documents provided can be accessed here

Hi @mrm9084,
Do you think it'd be possible to combine this review session with the App Config Provider Review the day before?
Could both reviews be completed within the 2-hour time slot?

Possibly. This review is a follow up. The other review is new but for a library that has been around for years. But it has a minimum public API.

If this is the Java version of the provider lib, then the architects would probably prefer to review this and the python lib in the same meeting. Just to make sure there are no un-needed inconsistencies between the libs.

I am not sure what you mean by "un-needed inconsistencies". The libraries results are the same but are used rather differently. At least between the python and spring libraries not a single API is in both of them.

By "un-needed inconsistencies" I mean we understand that between the languages not everything can match up, but when experiences can be similar, we will try to make them similar. Keeping in mind that we will still make sure the new features are idiomatic per language.
Even if there are completely different APIs in the libraries, if they provide a similar feature/functionality for the languages, the architects would like to review them in the context of the other languages.

It's not letting me add all of the APIs, so here they are:
spring-cloud-azure-appconfiguraiton-config
https://apiview.dev/Assemblies/Review/e08ff83856174723935fbaee832c1354
spring-cloud-azure-appconfiguraiton-config-web
https://apiview.dev/Assemblies/Review/849f4a29ba57494fbc1ab0bc1074d22c
spring-cloud-azure-feature-management
https://apiview.dev/Assemblies/Review/2e96c699150c4e219b0bb7282e934e0a
spring-cloud-azure-feature-management-web
https://apiview.dev/Assemblies/Review/ce8125eee8c84fe39274ee9647b1de64
spring-cloud-azure-starter-appconfiguration-config
https://apiview.dev/Assemblies/Review/b7311f0936bf4a7aa4aabde3110637ca

Microsoft.Extensions.Configuration.AzureAppConfiguration
https://apiview.dev/Assemblies/Review/2e5729305d32415495901ca8880697fa#Microsoft.Extensions.Configuration.AzureAppConfigurationExtensions

azure-appconfiguration-provider (python)
https://github.com/Azure/azure-sdk/issues/5493

Hi @mrm9084,
I wanted to ask again if it's possible to merge this review with the one you have scheduled for 2/28?
If you think each of these reviews need the full 2 hours then we can keep it as is, but if you think each could be done in an hour then we should merge the two sessions.

I would like to try to do it in a single day. But I'm not convinced that it will be only 2 hours.

We should definitely review this immediately following the scheduled Python review, if time permits. However, I also think there needs to be consideration of the feedback given to the APIViews above, and if possible, an updated iteration published before arch board takes place.

@JonathanGiles, Matt doesn't believe we'd be able to do both reviews in just 2 hours. And the Python review is just a follow up from a previous review, so we're trying to complete that one offline.

@mrm9084 could you also please add samples in the "Usage Samples" tab of the API view for all champion scenarios - features, refresh, filtering etc?
The quick start sample linked above only shows how to get a single config value from App Config service.

If you look in the side bar there are section for Feature management. Refresh can be found under https://learn.microsoft.com/en-us/azure/azure-app-configuration/enable-dynamic-configuration-java-spring-app.  Feature Filters can be found https://learn.microsoft.com/en-us/azure/azure-app-configuration/use-feature-flags-spring-boot

I have tried adding multiple links in the UI but it didn't seem to work.

Full usage docs can be found here: https://microsoft.github.io/spring-cloud-azure/docs/azure-app-configuration, but they are for the 2.x version, while this is 4.0. But there should mostly just name changes that can be seen through the API review.

The usage is no different, besides the name changes. The big 4.0 changes are mainly the package rename, and the few classes that have been renamed. Also, geo-replication support, but that can't be seen through the api view as that is a Spring Property.

ok. We have a bunch of feedback in the APIViews - will you be able to consider it and make any revisions in time for the arch board?

I didn't see any this morning when I looked. I can take a look now. Is there a way to upload the APIs with JavaDocs as that would seem to answer quite a few questions.

@JonathanGiles, I understand. If the API View looks good enough, to where we don't need to hold the online review, let me know and I'll cancel the meeting.

@JonathanGiles @srnagar I have responses to most of the comments. Some of the ones I didn’t will require a larger conversation.

@ronniegeraghty let's cancel and do this offline to save the other architects some time in their schedules.

Going to cancel the meeting. this will cause this issue to be deleted so I'll spawn a teams chat to continue the conversation.

Cancelled by System Admin

authors: JonathanGiles azure-sdk mrm9084 ronniegeraghty srnagar

repo: Azure/azure-sdk


text:
Add REST API for closing all connections for user/hub/group

Add REST API for closing all currently open connections for user/hub/group
Azure SignalR service already provides REST API for closing one connection based on its ConnectionID. However this is not very convenient in some cases as it requires users to keep track of all connection IDs and users. This leads to extra complexities in customer application.
Proposed APIs
Similarly to existing REST API we should have the following:

[ ] DELETE /api/v1/hubs/{hub}/connections/{User}
[ ] DELETE /api/v1/hubs/{hub}/connections/{GroupName}
[ ] DELETE /api/v1/hubs/{hub}/allconnections

And the corresponding management SDK wrappers (including the call for closing a particular connectionId):

[ ] CloseConnection(string hub, string connectionId)
[ ] CloseConnections(string hub, string user)
[ ] CloseConnections(string hub, string groupName)
[ ] CloseAllConnections(string hub)

TBD:

fire & forget or wait for all current connections to close?
return the number of dropped connections?
include flag telling clients to not auto-reconnect?

A similar approach for webpubsub is here : https://github.com/Azure/azure-rest-api-specs/pull/15907/commits/40a3903f9529d1c852f2b92d03802f90fd5ae060

authors: KKhurin vicancy

repo: Azure/azure-signalr


text:
Moving AppVeyor tests command to a script

This is a quick tactical change to unblock @suwatch
Will create an issue to clean this up.

@fabiocav thanks!

authors: fabiocav suwatch

repo: Azure/azure-webjobs-sdk-script


text:
[AVM Module Issue]: Boot Diagnostics has wrong parameter value

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/compute/virtual-machine-scale-set
(Optional) Module Version
0.4.0
Description
Unable to enable Boot Diagnostics, because parameter is configured wrong. It needs boolen, but requesting a string. After looking into it more deeply, the Microsoft best practice is to not include a storage account, but that can be optional. The  learn docs state that all you need is the enabled true or false
bootDiagnostics: {
          enabled: !empty(bootDiagnosticStorageAccountName)
          storageUri: !empty(bootDiagnosticStorageAccountName)
            ? 'https://${bootDiagnosticStorageAccountName}${bootDiagnosticStorageAccountUri}'
            : null
}

Feedback:
After looking into this for VMs and VMSS, I noticed this has the same issue. bootDiagnosticEnabled  needs to be a param to allow the users to decide if they should use the Microsoft best practice managed storage or the optional secure standalone storage account.
Suggested fix:
@description('Optional. Enable boot diagnostics to use default managed or secure storage. Defaults to false.')
param bootDiagnosticEnabled bool = false

@description('Optional. The name of the boot diagnostic storage account. Provide this if you want to use your own storage account for security reasons instead of the recommended Microsoft Managed Storage Account.')
param bootDiagnosticStorageAccountName string?

@description('Optional. The URI of the boot diagnostic storage account.')
param bootDiagnosticStorageAccountUri string?

bootDiagnostics: {
  enabled: bootDiagnosticEnabled
  storageUri: !empty(bootDiagnosticStorageAccountName) ? 'https://${bootDiagnosticStorageAccountName}${bootDiagnosticStorageAccountUri}' : null
}

Happy to create a PR if needed.
(Optional) Correlation Id
No response

@FallenHoot , thank you. Please submit a PR!

authors: FallenHoot rahalan

repo: Azure/bicep-registry-modules


text:
feat: Updated ServiceBus Namespace CMK Implementation

Description

Updated ServiceBus Namespace CMK Implementation
Implemented AVM-Common-Types

Linked to

Update CMK implementations as per https://github.com/Azure/bicep-registry-modules/issues/2842#issuecomment-2423679879
Docs Update: https://github.com/Azure/Azure-Verified-Modules/pull/1683
UDT update: https://github.com/Azure/bicep-registry-modules/pull/3724

Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Hey @ChrisSidebotham, just a careful ping :)


text:
Secure Parameter Default linter rule doesn't work across modules

Bicep version
VS Code 0.4.1
Describe the bug
If a module declares a secret parameter, the linter rule will pick up if you try to assign a plain text value inside that module.  However if if you assign a plain text value to the param in another module, that is not reported as a violation.
To Reproduce
In the following example, I'd expect the highlighted line in parent.bicep to produce a linter warning, but it does not.
parent.bicep:
module child 'child.bicep' = {
  name: 'foo'
  params: {
    secret: 'NOT A SECRET'  // Expect this to be a warning
  }
}

child.bicep:
@secure()
param secret string

The secure-parameter-default rule is specific to setting the param declaration's default. Consuming a module and setting param values are not defaults.

authors: MarcusFelling afscrome

repo: Azure/bicep


text:
Negative array index expressions raise no errors

The compiler doesn't raise any issues if you use a negative integer index for an array access expression, though this will cause an error at deploy time:

Bicep should emit an error-level diagnostic if:

The IndexExpression of an array access is of type IntegerLiteralType, and
The value of the type literal is < 0

At a team meeting, we discussed an alternative solution to this issue: what if we updated the ARM engine to support negative array indices for getting items based on their position relative to the end of the array (like is done in PowerShell, Python, and Perl)? This would not be complicated to implement in the ARM runtime, in which a negative index currently raises an out-of-range error.
Current behavior:
[createArray(1, 2, 3)[-1]] => out of range error
Proposed behavior:
[createArray(1, 2, 3)[-1]] => 3
Concerns raised by the team:

A negative index may be the result of a bug. In that case, the current behavior is desirable.
C# chose to implement a separate ^ (index from end) operator; should we use a dedicated operator instead of negative indexes?

One good reason to avoid adding a defined behavior for a negative index is that -1 is used as a sentinel value for certain functions (like indexOf  and lastIndexOf).
It would be unexpected if instead of raising an error, the following just began assigning a value of 'foo' to the bar variable:
var myArray = ['foo']
var bar = myArray[indexOf('bar')]

The proposal for how to support indexing into arrays from the end has been moved to #10104; this issue is back to just concerning the lack of a compiler error when using a negative array index.

@jeskew I'd like to take this up.

@levimatheri Great! I believe the area that needs to be updated is https://github.com/Azure/bicep/blob/da4a21a22d7f8e94b112177879262370a477f8b5/src/Bicep.Core/TypeSystem/TypeAssignmentVisitor.cs#L1200-L1209 and

@levimatheri Great! I believe the area that needs to be updated is
https://github.com/Azure/bicep/blob/da4a21a22d7f8e94b112177879262370a477f8b5/src/Bicep.Core/TypeSystem/TypeAssignmentVisitor.cs#L1200-L1209
and

@jeskew So I was looking at that, and wondering how do I get the integer value? Looks like IntegerType doesn't have a Value property. Though looks like IntegerLiteralType does.

@levimatheri IntegerLiteralType is the type used when a value is known to be a specific integer, and IntegerType is used when the type system knows that the value will be an integer but does not know which one.
param intParam int
var intVar = 1

array[intParam] // <-- The index here is of IntegerType
array[intVar] // <-- The index here is of IntegerLiteralType (with a .Value of 1)
array[-1] // <-- Also of IntegerLiteralType (with a .Value of -1)

authors: jeskew levimatheri


text:
docs: Add doc for custom repos.

All the feedback should be addressed now.

Updated this with all the requested changes.

repo: Azure/dalec


text:
Fix for #58: Store RetryAfter for subsequent requests

I think @garimakhulbe was making this change as part of a larger PR, but I'm sending this so that I can vendor it now for the PR I'm preparing for Kubernetes. This change saves me upwards of a minute or two whenever provisioning external load balancers for Kubernetes Services. I've been running this code for a while as-is; works as intended.

(addresses #58)

LGTM

Thanks @colemickens

authors: ahmetalpbalkan colemickens garimakhulbe

repo: Azure/go-autorest

license_source: bigquery


text:
Support custom DNS IP --dns-service-ip

Version

Karpenter Version: v0.0.0

Kubernetes Version: v1.0.0
Expected Behavior
the pod on new karpenter node, /etc/resolv.conf is 10.0.0.10. not follow az cli create --dns-service-ip 10.97.96.10.
this issue will cause cannot use custom vnet-subnet-id, the pod on karpenter node can not get reponse from default dns nameserver 10.0.0.10.
Actual Behavior

default nodepool
Steps to Reproduce the Problem
each AKS NAP cluster or self-host can reproduce this.
Resource Specs and Logs
(base) ottodeng@Otto-MacBook-Pro-M2.local:/Users/ottodeng/aks/self-host $ kubectl get pod -o wide
NAME                               READY   STATUS    RESTARTS   AGE   IP             NODE                                NOMINATED NODE   READINESS GATES
nginx-deployment-5f7bbf8bb-bkw8z   1/1     Running   0          18m   10.244.4.169   aks-t4-spot-rjz89
nginx-deployment-5f7bbf8bb-hvkvn   1/1     Running   0          18m   10.244.3.132   aks-t4-spot-xg75d
nginx-nodepool-5c64bc7fd8-xl92s    1/1     Running   0          18m   10.244.1.82    aks-nodepool1-32105842-vmss000001
nginx-nodepool-5c64bc7fd8-xs2mr    1/1     Running   0          18m   10.244.2.65    aks-nodepool1-32105842-vmss000000
(base) ottodeng@Otto-MacBook-Pro-M2.local:/Users/ottodeng/aks/self-host $ kubectl exec -it nginx-nodepool-5c64bc7fd8-xl92s cat /etc/resolv.conf
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
search default.svc.cluster.local svc.cluster.local cluster.local kdgjdzanqb1uxn5hrh45i34rib.ix.internal.cloudapp.net
nameserver 10.97.96.10
options ndots:5
(base) ottodeng@Otto-MacBook-Pro-M2.local:/Users/ottodeng/aks/self-host $ kubectl exec -it nginx-deployment-5f7bbf8bb-bkw8z cat /etc/resolv.conf
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
search default.svc.cluster.local svc.cluster.local cluster.local kdgjdzanqb1uxn5hrh45i34rib.ix.internal.cloudapp.net
nameserver 10.0.0.10
options ndots:5
(base) ottodeng@Otto-MacBook-Pro-M2.local:/Users/ottodeng/aks/self-host $
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

im working on a fix for --dns-service-ip here https://github.com/Azure/karpenter-provider-azure/pull/329. For now you will only be able to use the default values for --dns-service-ip until that change gets in.

im working on a fix for --dns-service-ip here https://github.com/Azure/karpenter-provider-azure/pull/329. For now you will only be able to use the default values for --dns-service-ip until that change gets in.

Thanks Bryce, will it merge into main in these days?

Hi,
Any update on this or any workaround?
I am also trying to use Karpenter with a custom subnet and the pod DNS is broken.

Thanks @Bryce-Soghigian . Unfortunately, we have run into the same issue.
Does anyone have any workaround for it?
Thanks

Sorry, other work was prioritized for cluster autoscaler security and quality. Not sure the exact timeline but this is on the GA checklist.

Any update on this? This is blocking us from using Karpenter in AKS

Hi,
We are also having the same issue.
Any update on when this is likely to be fixed ?
Thanks

authors: Bryce-Soghigian NMFR bedij03 gorositopablo ottodeng ppodevlabs

repo: Azure/karpenter-provider-azure


text:
Load testing of endpoint in Azure ML and data sanity tests

I wanted to load test a deployed model endpoint and add it to an MLOps v2 framework, so that new deployed models can go through load testing. I tried Azure load testing resource for web app but I think it is just for static content. Also, I saw a python package - locust which seems promising. Is there any other approach?
Also, for data sanity and integration tests for deployed models - great_expectations is available package. Is there a Azure service or recommended package for the same?

We have planned for load testing of the APIs in the upcoming release. If there is an urgent need, reach out to me separately via LinkedIn and we can help you out.


text:
Failure to handle large datasets. Integer Overflow

Describe the bug
mmlspark is unable to handle datasets whose size exceeds IntMax on a single executor. When using datasets this large it causes a silent integer overflow which leads to memory corruption or a jvm crash.
To Reproduce
The easiest way to reproduce is to train a model on a single executor using one partition. This ensures all the data will be loaded into a single array.
The bug is this line when the result is larger than an int.
val data = lightgbmlib.new_doubleArray(numCols * numRows)
Just changing the type there is not enough however, as lightgbmlib.new_doubleArray takes an integer as its argument, not a Long
Expected behavior
To not crash
Info:
MMLSpark Version: 95b7ef006d5cdb77346beb826130dc31239fa1db
Spark Version 2.4.3
Spark Platform Databricks
5.5 ML Runtime
** Stacktrace**
If the overflow results in a negative number, it fails to allocate
terminate called after throwing an instance of 'std::bad_array_new_length'
  what():  std::bad_array_new_length

If the overflow results in a positive number it passes the initial allocation and crashes in lightgbmlib.doubleArray_setitem
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [lib_lightgbm_swig.so+0xa3d3]  Java_com_microsoft_ml_lightgbm_lightgbmlibJNI_doubleArray_1setitem+0x3
J 32655 C2 com.microsoft.ml.spark.lightgbm.LightGBMUtils$$anonfun$generateData$1.apply(Ljava/lang/Object;)Ljava/lang/Object; (12 bytes) @ 0x00007f6f63f96ba8 [0x00007f6f63f96900+0x2a8]
J 11102 C2 scala.collection.mutable.ArrayOps$ofRef.foreach(Lscala/Function1;)V (6 bytes) @ 0x00007f6f61eb2bc0 [0x00007f6f61eb2b20+0xa0]
j  com.microsoft.ml.spark.lightgbm.LightGBMUtils$.generateData(I[[D)Lscala/Tuple2;+76
j  com.microsoft.ml.spark.lightgbm.LightGBMUtils$.generateDenseDataset(I[[DLscala/Option;Lscala/Option;Lcom/microsoft/ml/spark/lightgbm/TrainParams;Lorg/slf4j/Logger;)Lcom/microsoft/ml/spark/lightgbm/LightGBMDataset;+251
j  com.microsoft.ml.spark.lightgbm.TrainUtils$.generateDataset([Lorg/apache/spark/sql/Row;Ljava/lang/String;Ljava/lang/String;Lscala/Option;Lscala/Option;Lscala/Option;Lscala/Option;Lorg/apache/spark/sql/types/StructType;Lorg/slf4j/Logger;Lcom/microsoft/ml/spark/lightgbm/TrainParams;)Lscala/Option;+269
j  com.microsoft.ml.spark.lightgbm.TrainUtils$.translate(Ljava/lang/String;Ljava/lang/String;Lscala/Option;Lscala/Option;Lscala/Option;Lscala/Option;Lorg/slf4j/Logger;Lcom/microsoft/ml/spark/lightgbm/TrainParams;Lorg/apache/spark/sql/types/StructType;Lscala/collection/Iterator;)Lscala/collection/Iterator;+49
j  com.microsoft.ml.spark.lightgbm.TrainUtils$.trainLightGBM(Lcom/microsoft/ml/spark/lightgbm/NetworkParams;Ljava/lang/String;Ljava/lang/String;Lscala/Option;Lscala/Option;Lscala/Option;Lscala/Option;Lorg/slf4j/Logger;Lcom/microsoft/ml/spark/lightgbm/TrainParams;ILorg/apache/spark/sql/types/StructType;Lscala/collection/Iterator;)Lscala/collection/Iterator;+239
j  com.microsoft.ml.spark.lightgbm.LightGBMBase$$anonfun$6.apply(Lscala/collection/Iterator;)Lscala/collection/Iterator;+99
j  com.microsoft.ml.spark.lightgbm.LightGBMBase$$anonfun$6.apply(Ljava/lang/Object;)Ljava/lang/Object;+5
j  org.apache.spark.rdd.RDDBarrier$$anonfun$mapPartitions$1$$anonfun$apply$1.apply(Lorg/apache/spark/TaskContext;ILscala/collection/Iterator;)Lscala/collection/Iterator;+5
j  org.apache.spark.rdd.RDDBarrier$$anonfun$mapPartitions$1$$anonfun$apply$1.apply(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;+13
j  org.apache.spark.rdd.MapPartitionsRDD.compute(Lorg/apache/spark/Partition;Lorg/apache/spark/TaskContext;)Lscala/collection/Iterator;+27
J 10071 C1 org.apache.spark.rdd.RDD.computeOrReadCheckpoint(Lorg/apache/spark/Partition;Lorg/apache/spark/TaskContext;)Lscala/collection/Iterator; (30 bytes) @ 0x00007f6f61d5c484 [0x00007f6f61d59d40+0x2744]
j  org.apache.spark.rdd.RDD.iterator(Lorg/apache/spark/Partition;Lorg/apache/spark/TaskContext;)Lscala/collection/Iterator;+33
J 29117 C2 org.apache.spark.scheduler.Task.doRunTask(JI)Ljava/lang/Object; (338 bytes) @ 0x00007f6f635185ac [0x00007f6f635169a0+0x1c0c]
J 12512 C1 org.apache.spark.scheduler.Task.run(JILorg/apache/spark/metrics/MetricsSystem;)Ljava/lang/Object; (151 bytes) @ 0x00007f6f623ce55c [0x00007f6f623cd280+0x12dc]
j  org.apache.spark.executor.Executor$TaskRunner$$anonfun$13.apply()Ljava/lang/Object;+37
J 28798 C2 org.apache.spark.executor.Executor$TaskRunner.run()V (2776 bytes) @ 0x00007f6f622e5a8c [0x00007f6f622e3420+0x266c]
J 27489 C2 java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V (225 bytes) @ 0x00007f6f61bcc408 [0x00007f6f61bcc160+0x2a8]
J 24208 C1 java.util.concurrent.ThreadPoolExecutor$Worker.run()V (9 bytes) @ 0x00007f6f6039df04 [0x00007f6f6039de00+0x104]
J 17404 C1 java.lang.Thread.run()V (17 bytes) @ 0x00007f6f62aaa8fc [0x00007f6f62aaa7c0+0x13c]
v  ~StubRoutines::call_stub
V  [libjvm.so+0x6685d0]
V  [libjvm.so+0x665ab4]
V  [libjvm.so+0x666097]
V  [libjvm.so+0x6aa4b4]
V  [libjvm.so+0xa1c777]
V  [libjvm.so+0xa1cb60]
V  [libjvm.so+0x8c3102]
C  [libpthread.so.0+0x76ba]  start_thread+0xca

If the bug pertains to a specific feature please tag the appropriate CODEOWNER for better visibility
@imatiach-msft

closing as this has been fixed in lightgbm and now, with lightgbm upgrade on latest master, it has been fixed in mmlspark as well

authors: chris-smith-zocdoc imatiach-msft

repo: Azure/mmlspark


text:
Enable all distros for integration tests

Only jammy was configured to be able to run integration tests, other distros need to be updated in the same way.

This is complete with #48

repo: Azure/moby-packaging


text:
Adding ability to filter lifecycle tests

This adds the ability to filter lifecycle tests using an environment
variable (TEST_MODULES). Via this variable, the developer can provide
a comma delimited list of module names and only the test cases matching
that module will be enabled. If the variable is empty, all tests will run.
If an invalid module name is provided, no tests will run.
Implements #157

Here are a couple of examples of using the environment variable to selectively run tests (some output omitted).
In this case, only run the aci and mssql tests:
$ TEST_MODULES=aci,mssql make test-service-lifecycles
== RUN   TestServices
2017/12/29 18:46:50 ----> creating resource group "test-4c7deba3-b111-412e-bffd-84d6429d7695"
2017/12/29 18:46:52 ----> created resource group "test-4c7deba3-b111-412e-bffd-84d6429d7695"
2017/12/29 18:46:52 ----> testing in resource group "test-4c7deba3-b111-412e-bffd-84d6429d7695"
2017/12/29 18:46:52 Running tests for modules: [aci mssql]
=== RUN   TestServices/lifecycle
=== RUN   TestServices/lifecycle/TestServices/lifecycle/aci
=== RUN   TestServices/lifecycle/TestServices/lifecycle/mssql/new_server_and_database
=== RUN   TestServices/lifecycle/TestServices/lifecycle/mssql/database_on_an_existing_server
2017/12/29 18:46:52 ----> TestServices/lifecycle/aci: starting
2017/12/29 18:46:52 ----> TestServices/lifecycle/mssql/database_on_an_existing_server: starting
2017/12/29 18:46:52 ----> TestServices/lifecycle/mssql/new_server_and_database: starting

Here is an example of running with a bad module name.
$ TEST_MODULES=nomodule make test-service-lifecycles
=== RUN   TestServices
2017/12/29 18:22:54 ----> creating resource group "test-54b07116-64a0-4efc-9f63-e159b1aa4150"
2017/12/29 18:22:56 ----> created resource group "test-54b07116-64a0-4efc-9f63-e159b1aa4150"
2017/12/29 18:22:56 ----> testing in resource group "test-54b07116-64a0-4efc-9f63-e159b1aa4150"
2017/12/29 18:22:56 Running tests for modules: [nomodule]
2017/12/29 18:22:56 No test cases selected. Please check TEST_MODULES variable.
=== RUN   TestServices/lifecycle
2017/12/29 18:22:56 ----> deleting resource group "test-54b07116-64a0-4efc-9f63-e159b1aa4150"
2017/12/29 18:23:43 ----> deleted resource group "test-54b07116-64a0-4efc-9f63-e159b1aa4150"
--- PASS: TestServices (49.36s)
    --- PASS: TestServices/lifecycle (0.00s)
PASS
ok  	github.com/Azure/open-service-broker-azure/tests/lifecycle	49.379s

repo: Azure/open-service-broker-azure


text:
Auto-Gen the User ID, and Don;t show to the user

For auth, is asking the user to enter a user ID confusing? This User id appears to be an Azure thing (a principal). I think we're asking for something locally that Azure generates for you when you do it in the portal. Will the customer know what that is?  Should they?
Could we generate a random value and not prompt the user? Also, Is there any reason to show this?

Great suggestion @johnpapa !
Here is what I suggest:

we generate a random ID (following the same Az pattern)
we keep that field visible but we disable it (like we do for the provider).

Wdyt?

I like that.
I admit, I was completely confused. I have been using values like Fred and Sally in it:)

authors: johnpapa manekinekko

repo: Azure/static-web-apps-cli


text:
404 error when using custom authentication.

I am using Azure B2C as a OpenID Connect provider, and have used the example auth configuration from https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-custom?tabs=aad. I have used the B2C setup with MSAL several times without issue, and testing the B2C user flow works without issue.
When I launch the static website i get a 404 error on the /.auth/login/myProvider page. Is there anything missing in the documentation, my configuration or a way to troubleshoot the issue? (No errors in the github deployment action)
I confimed the app/route works using the oob github identity provider.
My Config:
{
  "routes": [
    {
      "route": "/api/*",
      "allowedRoles": ["authenticated"]
    }
  ],
  "auth": {
    "identityProviders": {
      "openIdConnectProviders": {
        "azureb2c": {
          "registration": {
            "clientIdSettingName": "MY ID",
            "clientCredential": {
              "secretSettingName": "My Secret"
            },
            "openIdConnectConfiguration": {
              "wellKnownOpenIdConfiguration": "https://tenant.b2clogin.com/tenant.onmicrosoft.com/v2.0/.well-known/openid-configuration?p=B2C_1_authSignIn"
            }
          }
        }
      }
    }
  }
}

Error
GET https://<site>/.auth/login/azureb2c 404

Is the GitHub repo public that I could take a look at?

Sure, just made one.
https://github.com/TellonUK/azureswa
( I've setup a Azure SWA at https://polite-desert-0bd142f0f.azurestaticapps.net/ I just need to configure the env config for a demo b2c, will update here when that's done too )

In staticwebapp.config.json:
  "auth": {
    "identityProviders": {
      "openIdConnectProviders": {
        "azureb2c": {
          "registration": {
            "clientIdSettingName": "<SWACLIENTID>",
            "clientCredential": {
              "secretSettingName": "<SWASECRET>"
            },
            "openIdConnectConfiguration": {
              "wellKnownOpenIdConfiguration": "<SWAWELLKNOWN>"
            }
          }
        }
      }
    }
  }

The clientIdSettingName, secretSettingName, wellKnownOpenIdConfiguration properties are invalid.
Try removing the <> in the setting names:
          "registration": {
            "clientIdSettingName": "SWACLIENTID",
            "clientCredential": {
              "secretSettingName": "SWASECRET"
            },

And create 2 app settings: one named SWACLIENTID containing the client ID, and one named SWASECRET containing the secret.
And for wellKnownOpenIdConfiguration, change <SWAWELLKNOWN> in the config file to the actual value of the issuer url.
+ @mkarmark to take a look as well. There might be other issues here.
Regarding this:

Not seeing any documentation on how to save an environment variable in the JSON file so that its picked up by the value in the Application Settings. (process.env.xxx works for the API but cant use that in JSON).

@craigshoemaker I think the app settings page might need to be updated now that app settings are no longer just for API apps.

@anthonychu I wouldn't have thought that failing to get the values from config would result in a 404 on the auth provider, I'd have expected a 500

In my staticwebapp.config.json I updated it to the suggested format.
{
  "routes": [
    {
      "route": "/api/*",
      "allowedRoles": ["authenticated"]
    }
  ],
  "auth": {
    "identityProviders": {
      "openIdConnectProviders": {
        "azureb2c": {
          "registration": {
            "clientIdSettingName": "SWACLIENTID",
            "clientCredential": {
              "secretSettingName": "SWASECRET"
            },
            "openIdConnectConfiguration": {
              "wellKnownOpenIdConfiguration": "https://glmtesting.b2clogin.com/glmtesting.onmicrosoft.com/v2.0/.well-known/openid-configuration?p=B2C_1_authSignIn"
            }
          }
        }
      }
    }
  }
}

I also updated my SWA app settings to have keys SWACLIENTID and SWASECRET, using a @Microsoft.KeyVault value and then also the ClientID and Secret in plaintext. Neither resolved the issue.
The SWA  site still has a 404 when you go to /.auth/login/azureb2c
When I have the auth key in my staticwebapp.config.json the /.auth/login/github route also responds with a 404. Which I would expect, as per the documentation when you override a pre-configured provider by configuring an auth section the built in providers are disabled. This suggests the auth section of my staticwebapp.config.json is being picked up. I can also confirm, if I remove the auth section from my staticwebapp.config.json  then the /.auth/login/github route works again.
I have replicated the issue on two SWA's, in the East US 2 region using the above staticwebapp.config.json, both have the same 404 issue.

Hi @TellonUK, can you rename in the json "openIdConnectProviders" to "customOpenIdConnectProviders"? That should fix the issue. We realize the docs are leading people to incorrectly use "openIdConnectProviders" and are trying to get the fix out ASAP.

Thanks, That did the trick.

authors: TellonUK aaronpowell anthonychu mkarmark

repo: Azure/static-web-apps


text:
chore: repository governance

Repository governance update
This PR was automatically created by the AVM Team hive-mind using the grept governance tool.
We have detected that some files need updating to meet the AVM governance standards.
Please review and merge with alacrity.
Grept config source: git::https://github.com/Azure/Azure-Verified-Modules-Grept.git//terraform
Thanks! The AVM team :heart:

Supersceeded by #62


text:
chore: repository governance

Repository governance update
This PR was automatically created by the AVM Team hive-mind using the grept governance tool.
We have detected that some files need updating to meet the AVM governance standards.
Please review and merge with alacrity.
Grept config source: git::https://github.com/Azure/Azure-Verified-Modules-Grept.git//terraform
Thanks! The AVM team :heart:

Supersceeded by #14


text:
Add ASPNETCORE_ENVIRONMENT with the value of Development.

I don't seem to be able to submit a PR to the wiki. The PR would be to add the following to Step 7 of deploy page.
Also add ASPNETCORE_ENVIRONMENT with the value of "Development". Note that you will need to get a token using the /scim/token endpoint for testing as described on the testing page.

Updated the wiki.

repo: AzureAD/SCIMReferenceCode


text:
The DSigSerializer read methods are not consistent with those of WsFederationMetadataSerializer

Currently, the DSigSerializer read methods (ex. ReadIssuerSerial()) return void, but those of WsFederationMetadataSerializer all return the type that was read. The methods in DSigSerializer should be changed to behave in a similar way.

We should fix this for 5.2.0 release

authors: brentschmaltz mafurman


text:
OSGi dependencies for MSAL4J bundle

I'm trying to load com.microsoft.azure:msal4j:1.4.0 as OSGi bundle into Apache Karaf using its dependency tree:
com.microsoft.azure:msal4j:1.4.0
+--- com.nimbusds:oauth2-oidc-sdk:6.5
|    +--- com.sun.mail:javax.mail:1.6.1
|    |    \--- javax.activation:activation:1.1
|    +--- com.github.stephenc.jcip:jcip-annotations:1.0-1
|    +--- net.minidev:json-smart:[1.3.1,2.3] -> 2.3
|    |    \--- net.minidev:accessors-smart:1.2
|    |         \--- org.ow2.asm:asm:5.0.4
|    +--- com.nimbusds:lang-tag:[1.4.3,) -> 1.4.4
|    \--- com.nimbusds:nimbus-jose-jwt:[6.0.1,) -> 8.16
|         +--- com.github.stephenc.jcip:jcip-annotations:1.0-1
|         \--- net.minidev:json-smart:[1.3.1,2.3] -> 2.3 (*)
+--- org.slf4j:slf4j-api:1.7.28
\--- com.fasterxml.jackson.core:jackson-databind:2.10.1
     +--- com.fasterxml.jackson.core:jackson-annotations:2.10.1
     \--- com.fasterxml.jackson.core:jackson-core:2.10.1

It turns out, that one of the dependencies: com.github.stephenc.jcip:jcip-annotations:1.0-1 cannot be loaded into Karaf because it is not an OSGi bundle - so, activation of both oauth2-oidc-sdk and msal4j fails.
How can I use msal4j bundle satisfying all the dependencies? Could you list all bundle dependencies to include?

from MANIFEST.FM :
...
Import-Package: com.fasterxml.jackson.annotation;version="[2.10,3)",co
m.fasterxml.jackson.core;version="[2.10,3)",com.fasterxml.jackson.dat
abind;version="[2.10,3)",com.fasterxml.jackson.databind.node;version=
"[2.10,3)",com.nimbusds.jose;version="[8.14,9)",com.nimbusds.jose.cry
pto;version="[8.14,9)",com.nimbusds.jose.util;version="[8.14,9)",com.
nimbusds.jwt;version="[8.14,9)",com.nimbusds.oauth2.sdk;version="[7.4
,8)",com.nimbusds.oauth2.sdk.auth;version="[7.4,8)",com.nimbusds.oaut
h2.sdk.http;version="[7.4,8)",com.nimbusds.oauth2.sdk.id;version="[7.
4,8)",com.nimbusds.oauth2.sdk.pkce;version="[7.4,8)",com.nimbusds.oau
th2.sdk.token;version="[7.4,8)",com.nimbusds.oauth2.sdk.util;version=
"[7.4,8)",com.nimbusds.openid.connect.sdk;version="[7.4,8)",com.nimbu
sds.openid.connect.sdk.token;version="[7.4,8)",com.sun.net.httpserver
,javax.mail.internet;version="[1.6,2)",javax.net.ssl,javax.xml.namesp
ace,javax.xml.parsers,javax.xml.transform,javax.xml.transform.dom,jav
ax.xml.transform.stream,javax.xml.xpath,net.minidev.json;version="[2.
3,3)",org.slf4j;version="[1.7,2)",org.w3c.dom
...
Export-Package: com.microsoft.aad.msal4j;uses:="com.nimbusds.oauth2.sd
k.auth,javax.net.ssl";version="1.6.0"
Bundle-Name: msal4j
Bundle-Version: 1.6.0
...

You can use the Karaf bundle wrap command to add non-bundles; For example:
bundle:install wrap:mvn:com.github.stephenc.jcip/jcip-annotations/1.0-1

authors: SomkaPe maciejmalycha paul-mcculloch

license: mit


text:
java.lang.ClassNotFoundException: Didn't find class "com.sun.net.httpserver.HttpHandler" in Android

Hello!
I'm a bit unsure if this is the right place to open this issue, so please tell me if I'm barking up the wrong tree.
According to https://docs.microsoft.com/en-us/graph/sdks/choose-authentication-providers?tabs=Android, an InteractiveBrowserCredential should be used on Android to acquire a token for the Graph api.
Eventually that ends up in an instantiation of an AuthorizationResponseHandler from this library which results in a java.lang.ClassNotFoundException since AuthorizationResponseHandler implements and imports a bunch of classes from com.sun.net.httpserver.* and com.sun stuff isn't available in Android.
I couldn't find any references to Android in the readme of this project so perhaps it isn't intended for Android use, but at the same time the official Microsoft documentation for using Microsoft Graph SDK for Android leads me here.
So, i guess my issue is two-fold:

Should I even open this issue here, or should I open it with the Graph SDK people?
If the issue does belong here, how do I get around using com.sun packages?

Thanks!

Hello @erikhakansson : Just to be clear, you're trying to create an Android application that acquires tokens from the Graph API, right? If so, what you actually want is MSAL Android, that's our library for Android applications. This repository is for MSAL Java, our library for Java applications.

Thank you @Avery-Dunn. You're absolutely right that I'm using the wrong library. It works much better when using the Android one, and especially following the documentation in that repo.
In my defense though, the documentation on the link in my first post (which is linked from https://github.com/microsoftgraph/msgraph-sdk-java) suggests that the same code should be used for both regular Java and Android, i.e:
final InteractiveBrowserCredential interactiveBrowserCredential = new InteractiveBrowserCredentialBuilder()
                .clientId(clientId)
                .redirectUrl("http://localhost:8765")
                .build();
final TokenCredentialAuthProvider tokenCredentialAuthProvider = new TokenCredentialAuthProvider(scopes, interactiveBrowserCredential);

which is what threw me off initially.
That's an issue for the Graph SDK people, though, and not an issue with this library 😄

authors: Avery-Dunn erikhakansson


text:
UserNamePasswordParameters The request body must contain the following parameter

Hello, when i use UserNamePasswordParameters i get the next exception:
"com.microsoft.aad.msal4j.AuthenticationException: {"error_description":"AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'.\r\nTrace ID: 1c15bd7a-12b0-4fcc-8f7d-fc4f909b0d00\r\nCorrelation ID: d895e136-9711-4a00-88ff-5fd7da8eb634\r\nTimestamp: 2019-06-26 08:26:25Z","error":"invalid_client"}"
What I do wrong?

Fixed. The application was not public.