text:
Terminal is not responding over the command

Type: Bug
when i opened the terminal and typed any command is not responding over the cammand.not even an error im getting but it is not responding

VS Code version: Code 1.91.0 (ea1445cc7016315d0f5728f8e8b12a45dc0a7286, 2024-07-01T18:52:22.949Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i5-12450H (12 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.70GB (1.08GB free)

Process Argv
--crash-reporter-id ca601bc5-5d09-4062-9743-2e3da74a423d

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

prettier-vscode
esb
10.4.0

vscode-pull-request-github
Git
0.92.0

node-module-intellisense
lei
1.5.0

LiveServer
rit
5.7.9

theme-check-vscode
Sho
2.4.2

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaac:30438847
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
chatpanelt:31048053
dsvsc021:30996838
bdiig495:31013172
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
legacy_priority:31082724
pythonrstrctxtcf:31093870

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


text:
Aux window: open issue reporter on current screen

atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor.

in these two examples, i have one large curved secondary monitor where vs code is.
open an aux window, and it spawns it in my laptop's screen.
same thing if full screened on secondary monitor. different when full screen on main screen (see https://github.com/microsoft/vscode/issues/224136)

https://github.com/user-attachments/assets/44837bfe-703d-4883-b49e-cbb3a3cc66ad
https://github.com/user-attachments/assets/d3181ab7-b897-4f7f-99e6-9751630eede9
wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.

@justschen that should be possible if you provide the coordinates for where to open the window via IAuxiliaryWindowOpenOptions:
https://github.com/microsoft/vscode/blob/d12c0c7892a9ff59f62091eee061d471614dc206/src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts#L244
You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the nativeHostMainService.
Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.

source: gharchive/issue

authors: bpasero justschen

repo: microsoft/vscode

license: MIT

license_type: permissive

license_source: github-api


text:
Program Crashes when "File" menu is opened

Type: Performance Issue
If I try to open the file menu (eg top left, next to edit), the VSCode crashes. Happens whether or not I have anything open.
VS Code version: Code - Insiders 1.95.0-insider (8d8f0cd9d4b25e89621ce897e82f2111eca6a278, 2024-10-15T05:04:26.261Z)
OS version: Linux x64 6.8.0-40-generic snap
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 5800H with Radeon Graphics (16 x 4025)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: disabled_offwebnn: unavailable_software

Load (avg)
2, 1, 0

Memory (System)
62.21GB (58.52GB free)

Process Argv
--no-sandbox --force-user-env --crash-reporter-id a872703c-2358-40e7-87d2-6f3aa72b5533

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu-wayland

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu-wayland

XDG_SESSION_TYPE
wayland

Process Info
CPU %	Mem MB	   PID	Process
    0	   127	  8905	code-insiders main
    0	     0	  8907	   zygote
    0	     0	  8908	   zygote
    0	   255	  8974	window [1] (Welcome - Visual Studio Code - Insiders)
    0	    64	  8957	   utility-network-service
    0	    64	  9026	   gpu-process
    0	   127	  9062	shared-process
    0	     0	  9508	     /bin/sh -c /usr/bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	     0	  9509	       /usr/bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	    64	  9063	fileWatcher [1]
    0	   319	  9100	extensionHost [1]
    0	    64	  9174	     electron-nodejs (languageserver.js )
    0	    64	  9195	     /snap/code-insiders/1768/usr/share/code-insiders/code-insiders /snap/code-insiders/1768/usr/share/code-insiders/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=9100

Workspace Info
;

Extensions (26)

Extension
Author (truncated)
Version

root-file-viewer
alb
1.3.4

copilot
Git
1.241.1169

copilot-chat
Git
0.22.2024101801

latex-workshop
Jam
10.5.4

vscode-docker
ms-
1.29.3

debugpy
ms-
2024.13.2024101501

python
ms-
2024.17.2024102101

vscode-pylance
ms-
2024.10.1

jupyter
ms-
2024.10.2024101501

jupyter-hub
ms-
2024.5.1002432242

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.2024101602

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-powertoys
ms-
0.1.1

vscode-jupyter-slideshow
ms-
0.1.6

remote-containers
ms-
0.389.0

remote-ssh
ms-
0.113.1

remote-ssh-edit
ms-
0.87.0

cmake-tools
ms-
1.19.52

cpptools
ms-
1.22.9

cpptools-extension-pack
ms-
1.3.0

remote-explorer
ms-
0.4.3

sqltools
mtx
0.28.3

biblatex-snippets
nik
1.0.5

quarto
qua
1.116.0

cmake
twx
0.0.17

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
vsc_aa:30263845
vscod805:30301674
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:30980852
pythonait:30973460
9c06g630:31013171
dvdeprecation:31040973
dwnewjupytercf:31046870
newcmakeconfigv2:31071590
nb_pri_only:31057983
nativerepl1:31134653
refactort:31084545
pythonrstrctxt:31093868
wkspc-onlycs-t:31132770
nativeloc1:31118317
wkspc-ranged-t:31151552
cf971741:31144450
e80f6927:31120813
autoexpandse:31146404
12bdf347:31141542
iacca1:31150324
notype1:31143044
f8igb616:31140137
dwcopilot:31158714
g7688163:31155431

/duplicate of https://github.com/microsoft/vscode/issues/230604

authors: Mitchjkjkjk gjsjohnmurray


text:
Source Control Graph: Go to Current History Item action button is disabled immediately after History Item Reference Picker is used to change from Auto to specific  references

Type: Bug

Open a folder for which the History Item Reference Picker is currently set to Auto (the default).
Hover over it and note what it means (typically main, origin/main).
Note that the Go to Current History Item button is enabled.
Use the picker to change from Auto to an explicit selection of the 2 branches noted in step 2 above.
:bug: After OKing the picker the Go to Current History Item button is disabled until you run Developer: Reload Window.

VS Code version: Code - Insiders 1.96.0-insider (5d6531aabba3abfbc263c1e17e965db97df9210f, 2024-12-03T05:13:15.471Z)
OS version: Windows_NT x64 10.0.22631
Modes:

PR submitted.


text:
Default settings override per process

We have a system where multiple different docker images run VSCode instances with different software installed. Users always get the same persistent data directory and this also contains their VSCode user settings.
Some of the software is installed in different versions on the different docker images and some VSCode extensions need to have different settings to work correctly with these. The problem is that there's no way to predefine settings without writing them into the user or workspace settings which are both persisted across sessions. So it's easy to introduce conflicts this way when the settings of one docker image don't work with those of another.
What we'd need is something like a flag --settings that would take a json file, and those settings would sit between defaults and user settings in terms of precedence.

/duplicate
https://github.com/microsoft/vscode/issues/80972


text:
editor.insertSnippet() messes with indenting of the SnippetString

This is a very similar issue to #44200/#57093 but that fix appears to be only being applied to completions, but applying snippets causes the same issues.
Here's a repro:
vs.workspace.openTextDocument(vs.Uri.parse(`untitled:${os.tmpdir}/a.dart`)).then(async (document) => {

	const originalCode = `main() {
  // code indented with two spaces
}`;
	const editor = await vs.window.showTextDocument(document);
	await editor.edit((eb) => eb.insert(new vs.Position(0, 0), originalCode));

	const startOffset = originalCode.indexOf("// code indented with two spaces");
	const endOffset = originalCode.indexOf("\n}");
	const snippetString = new vs.SnippetString("// new code indented with two spaces\n  // newer code indented with two spaces");

	await editor.insertSnippet(snippetString, new vs.Range(document.positionAt(startOffset), document.positionAt(endOffset)));
});

This creates a doc and inserts into it the code:
main() {
  // code indented with two spaces
}

It then applies a snippet string that includes an additional line that is also indented by two spaces. However what you end up with is:
main() {
  // new code indented with two spaces
    // newer code indented with two spaces
}

The inserted line has been re-indented.
Whilst this behaviour may be useful if applying basic hard-coded strings, it's incorrect for language servers that are correctly calculating edits to leave the file indented/formatted correctly (I guess for the same reasons that left to #57093).

(@jrieken FYI - this seems similar to the completion issue you resolved)

@jrieken this is tagged as a feature, but I it's really a bug. Any language server calculating the correct edits exactly as required will end up with bad indenting. There's no way for an extension to really fix this without asking the language server to implement the edit incorrectly.
This was fixed for completions, just not for edits.

@jrieken is this something that could easily be contributed (with a similar fix to whatever was done in completions?). As mentioned above, this is really a bug not a feature - VS Code is assuming a language extension is generating incorrect indenting and doesn't work correctly if it generates the correct indenting.

Any updates on this? It's really annoying to constantly have to select and delete a huge chunk of indentation. This reason alone makes me almost want to switch to IntelliJ.

It's been marked as a feature (even though it seems to surely be a bug to assume language servers don't know how to indent), so I'm not sure it'll be fixed anytime soon.
Maybe it's worth trying to work around in the extension by reading the indent level from the current line and subtracting that much whitespace from each line? 🤔 It does mean if VS Code ever does fix it, we'll be wrong in the opposite direction until we remove the workaround though.
I might have a play around and see how well it works.

Programmers joke about transforming bugs into features but VS Code devs seem to have taken it literally.

@jrieken I planned to work around this by figuring out what indent VS Code would add and then subtracting it from the edit - however that's not possible, because many of the edits insert code that should be less-indented than where the current cursor is (for example, inserting a new function).
Do you know if any other workaround? It's driving users mad, and it doesn't make any sense to try and get the language server updated to provide the wrong edits to compensate for VS Code's magic.

planned to work around this

How about not working around this but on this?

How about not working around this but on this?

So far there's been no response on this issue so it's not clear whether this is working-as-intended or something you'd accept a fix for (nor how it should best be fixed for compatibility).

Well, the issue wouldn't be open otherwise. This is your code pointer from which you can drill into things: https://github.com/microsoft/vscode/blob/2d713ac3a5385224a40ec6911195b14ac5a26139/src/vs/workbench/api/common/extHostTextEditor.ts#L626

I have many open issues that sit around for a long time then get closed, so being open isn't a very good indicator. I tried to get a response many times before with no luck :(
Anyway - if I get chance (though I can't guarantee it), would it be reasonable for there to be another boolean in options named keepWhitespace (to match the CompletionItem equivalent) that skips the magic?

@jrieken do you have an opinion on this question from above?

would it be reasonable for there to be another boolean in options named keepWhitespace (to match the CompletionItem equivalent) that skips the magic?

Yeah, that does make sense

Any updates here? I need this


text:
i am not able to zoom out.

Issue Type: Bug
i tried to zoom in by the following steps in visual studio code version-1.33.1.0
1.go to preference
2. go to setting.
3. Then i made the zoom from -1 to 100%.
4. Now i am not able to zoom out.

Did you use % in the value, like "100%"?

yes

@AbhilashaBaghel can you try without using the % character, it should just be a literal number.

I am not able to open it now. not getting popover in zoom mode to open preference settings

@AbhilashaBaghel you should be able to open the settings file directly and make that change. It is located in C:\Users\<name>\AppData\Roaming\Code\User\settings.json

thanks bpasero now it is coming fine. I am able to zoom out.

authors: AbhilashaBaghel bpasero chrmarti


text:
Auto import is importing relative path

Repo

Open vs/workbench/electron-browser/main.ts file
Delete the import line import { ConfigurationCache } from 'vs/workbench/services/configuration/node/configurationCache';
Go to the error that complains about missing import
Type cmd+. to see available code actions

/cc @sandy081

This is cause by the split syntax/semantic server work I added recently. We end up configuring preferences for one server and then cancelling the configure request to the other server. However since one request was successful, we end up caching the result and don't repeat the configure request again
Fix is to make sure if a request goes against both servers and one succeeds, we never cancel the other one


text:
“Remove destructuring” changes the function signature.

VSCode Version: 1.36.0
OS Version: Windows 10 18362.175

Steps to Reproduce:

Write code like function f({x}, y) {}.
Select Remove destructuring from “Show fixes”.
it is refactored to f(y) {}, which might cause problems because the function signature is changed.

I guess that it might be better refactored to something like f(_, y) {}.

Does this issue occur when all extensions are disabled?: Yes

Thanks. Opened https://github.com/microsoft/TypeScript/issues/32297 to track upstream

authors: infinnie mjbvz


text:
Certificate verification error installing devcontainer

When I try to start a devcontainer I get this error:
Installing VS Code Server for commit 2213894ea0415ee8c85c5eea0d0ff81ecc191529
Run: docker exec 7602314dc8df0bdf6cd43091a3643b3c89f5ff63ec1a463be93b1ddd3c3c192c mkdir -p /root/.vscode-server/bin/2213894ea0415ee8c85c5eea0d0ff81ecc191529_1563954742342
Error: unable to verify the first certificate
        at TLSSocket.onConnectSecure (_tls_wrap.js:1049:34)
        at TLSSocket.emit (events.js:182:13)
        at TLSSocket._finishInit (_tls_wrap.js:631:8)

I have to use a proxy that is defined in vscode settings. I've deactivated the 'http strict ssl' setting. I've tried to redefine those settings in the devcontainer settings but the certificates keep being verified.

VSCode Version: 1.36.1
OS Version: W10

Do you have the required certificate installed in the OS? If you do, could you check if this is still a problem with the latest Insiders build of VS Code? (Download: https://code.visualstudio.com/insiders/) We just fixed a related issue on Windows (#79044).

Hi,
Yes, the certificate was installed on the OS.
On the latest insiders version the problem is fixed!
Thanks a lot!

authors: ArtyMaury chrmarti


text:
Search doesn't seem to work in template literals

When searching for a string that is in a template literal, VS Code Insider doesn't throw any matches:

If I open the file containing the template literal, it works:

VSCode Version: 1.37.0-insider
OS Version: Windows 10.0.18362

Steps to Reproduce:

Search for an expression that is in a template literal and not in an open file.
Search doesn't work.

Does this issue occur when all extensions are disabled?: Yes

After reviewing it with the normal VS Code and other editors, it seems that the problem is that the folder path gets too long.

I think it's really unlikely that this has anything to do with template literals, can you show that it finds other matches in this file but not that one?

it seems that the problem is that the folder path gets too long.

Can you explain some more?

Can you explain some more?

Yes, sorry! It was a project with stupidly long paths because it followed a nested-component folder structure. The file I opened in the second screenshot was actually in a path of 460 characters (!).
I first blamed the insider build (and created this issue a bit hastily, sorry), then I switched to the normal one and the behaviour was the same, so I checked with the "find in files" option of Notepad++ (which is always kind of the last-resort-solution).
When even Notepad++ couldn't find anything I started checking the length of the path of the file (I remembered some problems with NTFS and paths larger than 260 chars).
I copied the file to a folder closer to the source folder and searched again and sure enough everything worked just fine ...

Oh, got it. That's unfortunate. Thanks for following up. Chalking this one up to NTFS/windows

authors: LeoLozes roblourens


text:
Error when expanding/collapsing in the Problems view (icon changes, but contents to not collapse)

I can't repro this, but maybe from the description/error you can tell what it is. I had a filter of !_demo.dart in the problems view, which filters to just the demo.dart file that has errors:

However when I tried to collapse it, the icon changed but the child nodes did not disappear:

Even after I removed the filter, it remained in a broken state. There's an error in the console that may be relevant:
ERR ListError [MarkersPanel] Invalid start index: 40: Error: ListError [MarkersPanel] Invalid start index: 40
    at O.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:883:34)
    at O.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1019:1004)
    at t.IndexTreeModel._setListNodeCollapseState (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:125:920)
    at t.IndexTreeModel._setCollapseState (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:125:427)
    at eventBufferer.bufferEvents (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:125:303)
    at t.EventBufferer.bufferEvents (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:787)
    at t.IndexTreeModel.setCollapsed (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:125:281)
    at t.ObjectTreeModel.setCollapsed (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:133:672)
    at N.onPointer (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1019:668)
    at c.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:116:539)
    at e (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:112:65)
    at c.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:116:519)
    at HTMLDivElement.s (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:122:46)

@joaomoreno I know :( I tried, but wasn't able to reproduce it. I don't think I did anything more than was written above - I wondered if maybe it was a race condition, but I'm not familiar with how the tree works.
If I do see it again, is there anything I can do to extract info about the state of the tree that might help?

When trying to repro this I also notice this strange behavior with filtering the problems view

@eamodio Can you maybe get me some repro steps? I can't seem to get to that state.

Here are the steps:

Create a problem in 2 files.
Whichever file is first in the problem list filter it out using something like !**/fileA.ts
Then try to expand/collapse the remaining problem (which is now the first one)

@joaomoreno Just after I reproduced the issue with those steps above, I cleaned up the errors I made to those 2 files and then this happened:

  ERR TreeError [MarkersPanel] Tree element not found: {
	"resource": "/c:/Users/Eric/code/microsoft/vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts",
	"owner": "typescript",
	"code": "2304",
	"severity": 8,
	"message": "Cannot find name 'asfas'.",
	"source": "ts",
	"startLineNumber": 300,
	"startColumn": 1,
	"endLineNumber": 300,
	"endColumn": 6
}: Error: TreeError [MarkersPanel] Tree element not found: {
	"resource": "/c:/Users/Eric/code/microsoft/vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts",
	"owner": "typescript",
	"code": "2304",
	"severity": 8,
	"message": "Cannot find name 'asfas'.",
	"source": "ts",
	"startLineNumber": 300,
	"startColumn": 1,
	"endLineNumber": 300,
	"endColumn": 6
}
    at t.ObjectTreeModel.getParentNodeLocation (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:135:861)
    at Object.getSetSize (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1035:358)
    at C.updateItemInDOM (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:956)
    at C._splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:469:645)
    at C.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:596)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:712
    at Array.forEach (<anonymous>)
    at t.CombinedSpliceable.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:699)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:994
    at t.EventBufferer.bufferEvents (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:120:603)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:961)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1033:27)
    at t.IndexTreeModel.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:126:211)
    at t.ObjectTreeModel._setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:133:13)
    at t.ObjectTreeModel.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:908)
    at W.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1046:639)
    at z.refreshPanel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5895:448)
    at z.onDidChangeModel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5900:390)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5899:729
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at t.MarkersModel.setResourceMarkers (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2827:148)
    at p.onMarkerChanged (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:304)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:237
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:379
log.ts:196   ERR Cannot read property 'templateData' of null: TypeError: Cannot read property 'templateData' of null
    at C.removeItemFromDOM (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:475:381)
    at C._splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:861)
    at C.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:596)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:712
    at Array.forEach (<anonymous>)
    at t.CombinedSpliceable.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:699)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:994
    at t.EventBufferer.bufferEvents (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:120:603)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:961)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1033:27)
    at t.IndexTreeModel.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:126:211)
    at t.ObjectTreeModel._setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:133:13)
    at t.ObjectTreeModel.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:908)
    at W.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1046:639)
    at z.refreshPanel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5895:448)
    at z.onDidChangeModel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5900:390)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5899:729
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at t.MarkersModel.setResourceMarkers (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2827:148)
    at p.onMarkerChanged (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:304)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:237
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:379
log.ts:196   ERR TreeError [MarkersPanel] Tree element not found: {
	"resource": "/c:/Users/Eric/code/microsoft/vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts",
	"owner": "typescript",
	"code": "1",
	"severity": 4,
	"message": "Missing semicolon (semicolon)",
	"source": "tslint",
	"startLineNumber": 300,
	"startColumn": 6,
	"endLineNumber": 300,
	"endColumn": 6
}: Error: TreeError [MarkersPanel] Tree element not found: {
	"resource": "/c:/Users/Eric/code/microsoft/vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts",
	"owner": "typescript",
	"code": "1",
	"severity": 4,
	"message": "Missing semicolon (semicolon)",
	"source": "tslint",
	"startLineNumber": 300,
	"startColumn": 6,
	"endLineNumber": 300,
	"endColumn": 6
}
    at t.ObjectTreeModel.getParentNodeLocation (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:135:861)
    at Object.getSetSize (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1035:358)
    at C.updateItemInDOM (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:474:956)
    at C._splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:469:645)
    at C.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:596)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:712
    at Array.forEach (<anonymous>)
    at t.CombinedSpliceable.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:699)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:994
    at t.EventBufferer.bufferEvents (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:120:603)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:961)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1033:27)
    at t.IndexTreeModel.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:126:211)
    at t.ObjectTreeModel._setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:133:13)
    at t.ObjectTreeModel.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:908)
    at W.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1046:639)
    at z.refreshPanel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5895:551)
    at z.onDidChangeModel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5900:390)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5899:729
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at t.MarkersModel.setResourceMarkers (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2827:148)
    at p.onMarkerChanged (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:304)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:237
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:379
log.ts:196   ERR Cannot read property 'templateData' of null: TypeError: Cannot read property 'templateData' of null
    at C.removeItemFromDOM (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:475:381)
    at C._splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:861)
    at C.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:468:596)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:712
    at Array.forEach (<anonymous>)
    at t.CombinedSpliceable.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:37:699)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:994
    at t.EventBufferer.bufferEvents (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:120:603)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:894:961)
    at O.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1033:27)
    at t.IndexTreeModel.splice (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:126:211)
    at t.ObjectTreeModel._setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:133:13)
    at t.ObjectTreeModel.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:132:908)
    at W.setChildren (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1046:639)
    at z.refreshPanel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5895:551)
    at z.onDidChangeModel (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5900:390)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5899:729
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at t.MarkersModel.setResourceMarkers (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2827:148)
    at p.onMarkerChanged (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:304)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2945:237
    at c.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:379

@eamodio Perfect steps, thank you!

authors: DanTup eamodio joaomoreno


text:
Old Windows Terminal Problem(s)

Issue Type: Bug
I should start off with saying that these are old problems that I've had before with VS code and have come back to haunt me.

There is extra white space whenever I open a new terminal. The terminal is scrolled to the bottom such that I can't see anything. Oh ya, and the prompt disappears until I hit enter. This only appears to happen on the first terminal tab, when it pops it up for the first time (if I make another tab while it's already open, this doesn't happen).

Whenever the terminal can scroll and I minimize it, when it comes back up with the scroll bar at the top of the terminal. However, it does show the content at the bottom, where it should be. Any mouse wheel scrolling in this state pages the terminal up to where the scroll bar says in the terminal. Resizing the terminal right after it's come back up in the goofy state does reset the scroll bar to the correct place.

VS Code version: Code 1.40.0 (86405ea23e3937316009fc27c9361deee66ffbf5, 2019-11-06T17:02:13.381Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz (4 x 2400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.87GB (2.42GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

better-toml
bun
0.3.2

vscode-svgviewer
css
2.0.0

xml
Dot
2.5.0

matlab
Gim
1.4.0

gc-excelviewer
Gra
2.1.32

latex-workshop
Jam
8.3.1

svg
joc
1.0.5

python
ms-
2019.10.44104

cpptools
ms-
0.26.1

powershell
ms-
2019.11.0

vetur
oct
0.22.6

shader
sle
1.1.4

cmake
twx
0.0.17

vscode-todo-highlight
way
1.0.4

jinja
who
0.0.8

(1 theme extensions excluded)

The blank initial terminal is a bug in Windows and you need to upgrade to fix it: https://github.com/Microsoft/vscode/issues/57803
I'm not so sure about the second, could you put a gif together showing the problem with some more detailed steps?
/needsMoreInfo

Ok, the windows update worked to fix the first issue (I didn't realize that it didn't get auto-updated).
A gif for the second issue: https://imgur.com/a/Xk2FCZO
Let me know if you need anything else

I just opened this:
https://github.com/microsoft/vscode/issues/84379
It's the same problem here (#2 that is). Really... really annoying.

Restarting VSCode does not seem to solve the issue.

its safer to use github for images and gifs. also ,https://imgur.com loads really slow.

regards ratatoeey

Scroll issue is captured in https://github.com/microsoft/vscode/issues/84145

authors: Tyriar bencecile ratatoeey rianquinn


text:
Alignment issues with quick pick

I see the following problems:

"4 selected" is not vertically aligned and the "Turn on"
The the S in selected should probably be lower case?
The "Turn on" button is taller than the text input

I guess this is already fixed

authors: Tyriar devanshj


text:
Command like filesExplorer.openFilePreserveFocus but don't preserve focus

Thank you for building and maintaining VSCode! I love it and how configurable it is.
I'm currently building a set of shortcuts for myself that mimic NERDTree behavior for navigating the Explorer sidebar viewlet. In doing so I'm using filesExplorer.openFilePreserveFocus, but to more accurately emulate the NERDTree behavior it'd be great to have a command that opens a file and moves focus to it - basically filesExplorer.openFileDontPreserveFocus.

Thanks.
@sashaweiss as far as I remember filesExplorer.openFilePreserveFocus was introduced as an alternative to regular open. And you would like the opposite of filesExplorer.openFilePreserveFocus, thus you want the original command which is list.select. So please try to assign a custom keybinding for that and it should do the job.
If you want the keybinding to only work in the explorer you can use some fancy context key like filesExplorerFocus.
Let me know how it goes and id anything is missing.

Correct me if I'm wrong, but doesn't list.select trigger a rename of the file rather than open it? I could have sworn I tried that - and can try again when I get to my machine.
I wonder if that functionality changed at some point - I was scrolling through some old SO posts trying to find a workaround and folks proposed list.select, so maybe it used to open without preserving focus? Or maybe it opens the file on one platform but not on all? It'd be in-line with the Mac list paradigm for "select" to rename in a file list, as that's what Finder (and Xcode) will do as well - and it'd make sense for it to open a file on Windows.
I can follow up here with some experimentation when I get to my machine.

Nope, list.select does what you're describing. Not sure why I was running into issues with it previously - if I had to guess I tested it by using a shortcut that was being intercepted somewhere and was triggering rename, rather than actually triggering list.select.
Will close this issue and the PR - thanks for the attention!

Not sure what platform you are on. But for example Enter is list.select on Win / Linux and Rename on Mac.
Cmd + Down is list.select on mac. So we align with native finder.

Makes sense - I bet I saw "Enter" as the shortcut on Windows and then tried that on my Mac and got the rename behavior instead, without realizing that the shortcut would be different. (Which makes sense, but slipped my attention.)
Thanks for your help!

authors: isidorn sashaweiss


text:
Update problems (diagnostics) on file modification

Introduction
Problems view shows Diagnostic. Some of them generated on the fly, as the user types code - for example from C# extension, from tslint etc. Other are "static" - generated on some action, for example after running a build, the build output is parsed.
Current behaviour
For "static" Diagnostics, when user edits source file, the Diagnostics in Problems view are getting out of sync. They still point to the old location.
For example after running build I got following Problem about non existing name:

As you can see, the entry in the Problems view has the "9, 48" location, so it's line 9. In editor, the squiggly line also correctly underlines the "foo" name.
Below you can see what happens after I add a new line just above the Console.WriteLine (the build action is not run):

The "foo" name is now in line 10. The squiggly line was updated, it still correctly underlines the "foo" name. But in the Problems view, the Diagnostic entry still retains old locations, that is line 9. Clicking on it takes me to the old/wrong location.
Proposed improvement
Please add mechanism to easily update Diagnostics after used edits source file. I expect you already have it somehow handled, because the squiggly lines locations are updated. And you already have connection between squiggly line and the Diagnostic problem, so it should be possible to update Diagnostics locations too.

By static diagnostics you mean those created using tasks?

Yes, for example those created using tasks.
But it could/should also work for diagnostic created by extensions. For example we're creating an extension right now, which provides command to execute external tool which analyzes source files and produces xml. This xml is then parsed and converted to diagnostics. When user edits the source files, the diagnostic are not updated and point to incorrect location.

I would start with tasks first to check if they are creating diagnostics correctly.

I think that the diagnostic is created correctly. The task runs, creates markers, then exits. Once the task exists the markers are only changed once the task runs again. This is the expected behavior.
The behavior you want for tasks is already supported with background tasks and watching problem matchers. To have a task that creates markers that change, you'll have to convert your task into a background task and your problem matcher into a watching problem matcher. https://code.visualstudio.com/docs/editor/tasks#_background-watching-tasks

No, it does not cover my needs.
In my case the action of creating diagnostics is triggered manually by user. Also, it is not a task, but an extension that creates the diagnostics. Converting it into background task and using watching problem matcher is not possible.
I understand that it currently works as designed, which is why this issue is a feature request, not a bug report. My hope was that since vscode already knows how to update range (squiggly lines) when user edits source code, this could be exposed as an API that could be used either explicitly by extension (which would cover my needs), or implicitly to update diagnostics reported from tasks (which I don't need but seems reasonable).
Right now I have implemented onDidChangeTextDocument and I'm updating diagnostics myself. It works quite well, but it's not a straightforward code, and it's a work that need to be re-done by many extension authors which provide diagnostics which are not re-created on every source code change.

@sandy081 looks like the use-case isn't a task.

My hope was that since vscode already knows how to update range (squiggly lines) when user edits source code,

Not sure if this is true. We always update all diagnostic decorations (including squigglies) using diagnostics information. Otherwise it should be a bug from our side. Can you please provide a sample extension that I can reproduce this behaviour?

I was able to reproduce this using the official extension samples: https://github.com/microsoft/vscode-extension-samples/tree/master/diagnostic-related-information-sample

you have to comment out the onDidChangeActiveTextEditor subscription
the code did not compile on my machine, had to update dependencies
Pasting diff with those changes at the end for your convenience.

The sample extension shows a diagnostic on the sample-demo.rs file when you open it. You can edit the file, for example add a new line before the squiggly line, and the squiggle will be updated. But the diagnostic location will still point to the old location - problems view has old location and clicking on it will take you to the original location.
diff --git a/diagnostic-related-information-sample/package-lock.json b/diagnostic-related-information-sample/package-lock.json
index cb876b0..3d9b9de 100644
--- a/diagnostic-related-information-sample/package-lock.json
+++ b/diagnostic-related-information-sample/package-lock.json
@@ -308,9 +308,9 @@
 			}
 		},
 		"typescript": {
-			"version": "3.4.5",
-			"resolved": "https://registry.npmjs.org/typescript/-/typescript-3.4.5.tgz",
-			"integrity": "sha512-YycBxUb49UUhdNMU5aJ7z5Ej2XGmaIBL0x34vZ82fn3hGvD+bgrMrVDpatgz2f7YxUMJxMkbWxJZeAvDxVe7Vw==",
+			"version": "3.8.2",
+			"resolved": "https://registry.npmjs.org/typescript/-/typescript-3.8.2.tgz",
+			"integrity": "sha512-EgOVgL/4xfVrCMbhYKUQTdF37SQn4Iw73H5BgCrF1Abdun7Kwy/QZsE/ssAy0y4LxBbvua3PIbFsbRczWWnDdQ==",
 			"dev": true
 		},
 		"wrappy": {
diff --git a/diagnostic-related-information-sample/package.json b/diagnostic-related-information-sample/package.json
index 295ae73..2e3f5cd 100644
--- a/diagnostic-related-information-sample/package.json
+++ b/diagnostic-related-information-sample/package.json
@@ -21,9 +21,9 @@
 		"watch": "tsc -watch -p ./"
 	},
 	"devDependencies": {
-		"@types/node": "^7.0.43",
+		"@types/node": "^12.11.7",
 		"tslint": "^5.16.0",
-		"typescript": "^3.5.1",
+		"typescript": "^3.6.4",
 		"@types/vscode": "^1.32.0"
 	}
 }
diff --git a/diagnostic-related-information-sample/src/extension.ts b/diagnostic-related-information-sample/src/extension.ts
index 3764012..2d625d4 100644
--- a/diagnostic-related-information-sample/src/extension.ts
+++ b/diagnostic-related-information-sample/src/extension.ts
@@ -8,11 +8,11 @@ export function activate(context: vscode.ExtensionContext) {
 	if (vscode.window.activeTextEditor) {
 		updateDiagnostics(vscode.window.activeTextEditor.document, collection);
 	}
-	context.subscriptions.push(vscode.window.onDidChangeActiveTextEditor(editor => {
-		if (editor) {
-			updateDiagnostics(editor.document, collection);
-		}
-	}));
+	// context.subscriptions.push(vscode.window.onDidChangeActiveTextEditor(editor => {
+	// 	if (editor) {
+	// 		updateDiagnostics(editor.document, collection);
+	// 	}
+	// }));
 }

 function updateDiagnostics(document: vscode.TextDocument, collection: vscode.DiagnosticCollection): void {

To be precise, with the sample extension, you may need to have the sample-demo.rs file opened and active when the extension activates.

Do you still need more info?

Will try it out and let you know if needed.

This issue was incorrectly closed. All required info was provided.

This is a bug from our side that squiggles are not updated on content change. Fixed it.
To verify:

Use the sample - https://github.com/microsoft/vscode-extension-samples/tree/master/diagnostic-related-information-sample
Comment out the onDidChangeActiveTextEditor subscription at line 11
Run the extension and open sample-demo.rs file available in the same sample
add a new line before the squiggly line, and the squiggle should remain at the same location

This is a bug from our side that squiggles are not updated on content change
To verify:

Hmm I'm not sure about that.
The squiggles were updated. It's the diagnostics in the Problems view that were not updated.
So either a different issue was fixed than reported, or the verification step must be extended to check the the Problems view.

add a new line before the squiggly line, and the squiggle should remain at the same location

I hope "same location" means same code should be underlined, not the same line, column values (which would mean the new line...)

@pkruk2

The squiggles were updated. It's the diagnostics in the Problems view that were not updated.

It is not correct. Squiggle were out of sync with diagnostics. It is responsibility of the diagnostics owner to update the diagnostics on content change and update them.

@sandy081
In my case the squiggles were updated after content change. Yes, they became out of sync with diagnostics after that:

the squiggles pointed to new location after content change
the diagnostic pointed to old location after content change

Do I understand correctly, that you consider the update of the squiggle as the bug, and changed it to not be updated on content change?
That's the opposite of what I hoped ;)
Yes, now both squiggle and diagnostic point to the same location, but on the other hand that location is wrong... Is it possible to have a feature of updating both squiggle and diagnostic to point to the new location?

In short, VS Code shall not make any assumptions about the content edits and cause models to be out of sync. It is extension's responsibility to update the diagnostics and keep them in sync.

Is it possible to have a feature of updating both squiggle and diagnostic to point to the new location?

Yes, you can file that agains the corresponding extension.

Thanks.

Doesn't work for me or I misunderstand what the behavior should be. Here is what I see

and then after inserting a new line

which looks wired to me. I would have expected that x = 6; is still squiggled.

@dbaeumer Yes whatever you see is expected.

I would have expected that x = 6; is still squiggled

To have this, corresponding diagnostic has to be updated. All diagnostics related UI should be in sync with diagnostics.

Here are the steps to verify
To verify:

Use the sample - https://github.com/microsoft/vscode-extension-samples/tree/master/diagnostic-related-information-sample
Comment out the onDidChangeActiveTextEditor subscription at line 11
Run the extension and open sample-demo.rs file available in the same sample
squiggly is shown on line 4
add a new line before the squiggly line
Verify that squiggly should remain at same line 4


text:
Watch typescript files included in tsconfig.json / jsconfig.json

Hello,
I have a jsconfig.json file including some type definitions living outside of the VSCode workspace I am working in. Let's call one of those definitions foo.d.ts.
When the TS language service is booting for the first time, everything works fine. However if foo.d.ts is modified by a third party program (eg the user did not open this file in the workspace) then the type definition will not be updated in VSCode. As soon as I open foo.d.ts in the workspace the type definition updates.
One hack is to Restart the TS language service manually.
I tried to use the latest features of the insiders version, like Tsserver: Watch Options and Tsserver › Experimental: Enable Project Diagnostics without success.
I would like VSCode to watch files outside of my workspace (included in jsconfig.json) without having to open them explicitly.
My jsconfig.json:
{
 "compilerOptions": {
  "target": "es5",
  "lib": ["es2015"],
  "checkJs": true
 },
 "typeAcquisition": {
  "include": ["jasmine", "underscore"],
 },
 "include": ["src", "test", "/Users/willydouhard/types"]
}

I can't reproduce this in VS code 1.44 on MacOS.
Can you confirm that both files are part of your jsconfig project by opening them and running the TypeScript: Go to project configuration command. This should open up the jsconfig


text:
Candidate/142146

This PR fixes #142146

@raghavthind2005 please don't approve all our PRs, this causes notifications to go out

source: gharchive/pull-request

authors: Tyriar sbatten


text:
fix shell integration on linux

This PR fixes #150892

this doesn't fix it, so closing


text:
Fixes #162047

Fixes #162047

Compilation errors


text:
Add Settings editor smoke tests

Fixes #141054

@rzhao271 I want you to mentor me, please I need you. Can you?


text:
Update yml actions

GitHub started warning about these older actions being deprecated.

Dependabot can update github-actions too (docs).

Neat, let me try that.

Cool that works - thanks @Nerixyz! It's not smart enough to fix the Rust tool that generates yml, so I'll still just proceed with this PR but at least this should alert me of future updates.

authors: Nerixyz kennykerr

repo: microsoft/windows-rs