text:
Request textDocument/documentSymbol failed

Describe the bug
In the nightly-version this information pops up.

Here's the complete output:
[Info  - 9:53:21 PM] v-analyzer version: 0.0.2-beta.1, OS: linux x64
[Info  - 9:53:21 PM] v-analyzer executable path: /home/mrcl/.config/v-analyzer/bin/v-analyzer
[Info  - 9:53:21 PM] v-analyzer build with V 976c5fb
[Info  - 9:53:21 PM] v-analyzer build at 2023-12-08 21:53:21
[Info  - 9:53:21 PM] Client / Editor: Visual Studio Code - Insiders 1.85.0-insider (PID: 92966)
[Info  - 9:53:21 PM] Using local config: /home/mrcl/.config/v-analyzer/config.toml
[Info  - 9:53:21 PM] Find custom VROOT path in '.config/v-analyzer/config.toml' config
[Info  - 9:53:21 PM] Using "~/V/v" as toolchain
[Info  - 9:53:21 PM] Using "/home/mrcl/.cache/v-analyzer" as cache dir
[Info  - 9:53:21 PM] Using "/home/mrcl/.vmodules" as vmodules root
[Info  - 9:53:21 PM] Indexing /home/mrcl/.vmodules
[Info  - 9:53:21 PM] Indexing /home/mrcl/V/v/vlib
[Info  - 9:53:21 PM] Indexing /home/mrcl/.config/v-analyzer/metadata
[Info  - 9:53:21 PM] Indexing /home/mrcl
[Error - 9:54:23 PM] Request textDocument/documentSymbol failed.
TypeError: Cannot read properties of undefined (reading 'range')
	at Tn (/home/mrcl/.vscode-server-insiders/extensions/vosca.vscode-v-analyzer-0.0.2/out/extension.js:33:72702)
	at o (/home/mrcl/.vscode-server-insiders/extensions/vosca.vscode-v-analyzer-0.0.2/out/extension.js:33:48437)
	at Object.KD [as map] (/home/mrcl/.vscode-server-insiders/extensions/vosca.vscode-v-analyzer-0.0.2/out/extension.js:33:48523)
	at Object.di [as asSymbolInformations] (/home/mrcl/.vscode-server-insiders/extensions/vosca.vscode-v-analyzer-0.0.2/out/extension.js:33:72341)
	at c (/home/mrcl/.vscode-server-insiders/extensions/vosca.vscode-v-analyzer-0.0.2/out/extension.js:37:56146)
	at runNextTicks (node:internal/process/task_queues:60:5)
	at process.processImmediate (node:internal/timers:447:9)
	at async d.provideDocumentSymbols (/home/mrcl/.vscode-server-insiders/bin/182f5125f2f8a8469e9dac4ed4795b804671bf7d/out/vs/workbench/api/node/extensionHostProcess.js:145:39708)

And after that for example println will not be able to 'autocomplete'

Expected Behavior
Actually I don't know
Current Behavior

Reproduction Steps

Possible Solution
No response
Additional Information/Context
Running on WSL - Debian - Win11 Canary Build (26010)
Environment details (v doctor output)
V full version: V 0.4.3 976c5fb.2768de1
OS: linux, Linux version 5.15.133.1-microsoft-standard-WSL2 (root@1c602f52c2e4) (gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.37) #1 SMP Thu Oct 5 21:02:42 UTC 2023 (WSL 2)
Processor: 8 cpus, 64bit, little endian, AMD Ryzen 9 3950X 16-Core Processor

getwd: /home/mrcl/CODING/vlang/1
vexe: /home/mrcl/V/v/v
vexe mtime: 2023-12-08 20:21:35

vroot: OK, value: /home/mrcl/V/v
VMODULES: OK, value: /home/mrcl/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.39.2
Git vroot status: weekly.2023.45.1-230-g2768de1f
.git/config present: true

CC version: cc (Debian 12.2.0-14) 12.2.0
thirdparty/tcc status: thirdparty-linux-amd64 12f392c3

Editor name
VSCode - Insiders
v-analyzer Version
v-analyzer version 0.0.2-beta.1
VS Code Extension Version
v0.0.2

Got the same issue

Is it still happening with the latest release?

@ttytm yes an then it results in #91 :(

repo: v-analyzer/v-analyzer


text:
🛑 cryptraffic.de is down

In c5661cb, cryptraffic.de (https://cryptraffic.de/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: cryptraffic.de is back up in 6940d1a after 8 minutes.

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
Fatal error: require(): Failed opening required '/home/v2board-1.7.2/vendor/autoload.php' (include_path='.:/www/server/php/73/lib/php') in /home/v2board-1.7.2/artisan on line 18

Warning: require(/home/v2board-1.7.2/vendor/autoload.php): failed to open stream: No such file or directory in /home/v2board-1.7.2/artisan on line 18
PHP Fatal error:  require(): Failed opening required '/home/v2board-1.7.2/vendor/autoload.php' (include_path='.:/www/server/php/73/lib/php') in /home/v2board-1.7.2/artisan on line 18
Fatal error: require(): Failed opening required '/home/v2board-1.7.2/vendor/autoload.php' (include_path='.:/www/server/php/73/lib/php') in /home/v2board-1.7.2/artisan on line 18

how did you solve it?

how did you solve it?

Don't remember~

authors: jldhrj ohmyskyhigh


text:
使用Cloudflare CDN后, 完全无法连上

套上Cloudflare后, (ws+tls或是ws+tls+Nginx反向代理)
手机/Notebook可以走http(80 port)/https(443 Port)连得上VPS上的Nginx
手机/Notebook开启v2ray后,使用全局代理,哪都连不上….
请问该排查哪里呢?
PS.
Nginx听80,443 port / V2Ray听3128 port,Nginx/V2Ray在同一VPS(AWS EC2)…
Cloudflare连到Nginx看log似乎都是走IPv6..跟这有关吗?

***V2Ray Server config:(由https://github.com/sprov065/v2-ui生成)
{
"api": {
"services": [
"HandlerService",
"LoggerService",
"StatsService"
],
"tag": "api"
},
"inbounds": [
{
"listen": "127.0.0.1",
"port": 62789,
"protocol": "dokodemo-door",
"settings": {
"address": "127.0.0.1"
},
"tag": "api"
},
{
"listen": "0.0.0.0",
"port": 3128,
"protocol": "vmess",
"settings": {
"clients": [
{
"alterId": 0,
"id": "MY-UUIDID"
}
],
"disableInsecureEncryption": true
},
"sniffing": {
"destOverride": [
"http",
"tls"
],
"enabled": true
},
"streamSettings": {
"network": "ws",
"security": "tls",
"tlsSettings": {
"allowInsecure": false,
"certificates": [
{
"certificateFile": "/etc/nginx/ssl/cf_crt.pem",
"keyFile": "/etc/nginx/ssl/cf_pkey.pem"
}
],
"serverName": "blog.example.com"
},
"wsSettings": {
"headers": {},
"path": "/MyRayParadise"
}
},
"tag": "inbound-3128"
}
],
"log": {
"access": "/var/log/v2ray/access.log",
"error": "/var/log/v2ray/error.log",
"loglevel": "warning"
},
"outbounds": [
{
"protocol": "freedom",
"settings": {}
},
{
"protocol": "blackhole",
"settings": {},
"tag": "blocked"
}
],
"policy": {
"system": {
"statsInboundDownlink": true,
"statsInboundUplink": true
}
},
"routing": {
"rules": [
{
"inboundTag": [
"api"
],
"outboundTag": "api",
"type": "field"
},
{
"ip": [
"geoip:private"
],
"outboundTag": "blocked",
"type": "field"
},
{
"outboundTag": "blocked",
"protocol": [
"bittorrent"
],
"type": "field"
}
]
},
"stats": {}
}
***V2Ray-Client 设定((由https://github.com/sprov065/v2-ui生成))
{
"policy": {
"system": {
"statsInboundUplink": true,
"statsInboundDownlink": true
}
},
"log": {
"access": "Vaccess.log",
"error": "Verror.log",
"loglevel": "warning"
},
"inbounds": [
{
"tag": "proxy",
"port": 1080,
"listen": "127.0.0.1",
"protocol": "socks",
"sniffing": {
"enabled": true,
"destOverride": [
"http",
"tls"
]
},
"settings": {
"auth": "noauth",
"udp": true,
"ip": null,
"address": null,
"clients": null
},
"streamSettings": null
},
{
"tag": "api",
"port": 61476,
"listen": "127.0.0.1",
"protocol": "dokodemo-door",
"sniffing": null,
"settings": {
"auth": null,
"udp": false,
"ip": null,
"address": "127.0.0.1",
"clients": null
},
"streamSettings": null
}
],
"outbounds": [
{
"tag": "proxy",
"protocol": "vmess",
"settings": {
"vnext": [
{
"address": "blog.example.com",
"port": 443,
"users": [
{
"id": "my-uuid",
"alterId": 233,
"email": "t@t.tt",
"security": "auto"
}
]
}
],
"servers": null,
"response": null
},
"streamSettings": {
"network": "ws",
"security": "tls",
"tlsSettings": {
"allowInsecure": false,
"serverName": "blog.example.com"
},
"tcpSettings": null,
"kcpSettings": null,
"wsSettings": {
"connectionReuse": true,
"path": "/spikeneural",
"headers": {
"Host": "blog.example.com"
}
},
"httpSettings": null,
"quicSettings": null
},
"mux": {
"enabled": true,
"concurrency": 8
}
},
{
"tag": "direct",
"protocol": "freedom",
"settings": {
"vnext": null,
"servers": null,
"response": null
},
"streamSettings": null,
"mux": null
},
{
"tag": "block",
"protocol": "blackhole",
"settings": {
"vnext": null,
"servers": null,
"response": {
"type": "http"
}
},
"streamSettings": null,
"mux": null
}
],
"stats": {},
"api": {
"tag": "api",
"services": [
"StatsService"
]
},
"dns": {
"servers": [
"1.1.1.1",
"8.8.8.8",
"8.8.4.4",
"168.95.192.1"
]
},
"routing": {
"domainStrategy": "IPIfNonMatch",
"rules": [
{
"type": "field",
"port": null,
"inboundTag": [
"api"
],
"outboundTag": "api",
"ip": null,
"domain": null
},
{
"type": "field",
"port": null,
"inboundTag": null,
"outboundTag": "direct",
"ip": [
"geoip:private"
],
"domain": null
},
{
"type": "field",
"port": null,
"inboundTag": null,
"outboundTag": "direct",
"ip": [
"geoip:cn"
],
"domain": null
},
{
"type": "field",
"port": null,
"inboundTag": null,
"outboundTag": "direct",
"ip": null,
"domain": [
"geosite:cn"
]
}
]
}
}


text:
[FEATURE-316] Condition to check maximum shared memory size

Signed-off-by: rohangupta rohaninjmu@gmail.com

What do these changes do?
Added a condition to check the maximum shared memory size and raise a warning when it is less than the value of the size parameter.

Related issue number

Fixes

Such kind of check should be placed in vineyard server (the bulk store module), I believe.

source: gharchive/pull-request

authors: Rohan-cod sighingnow


text:
0165 - Compare Version Numbers

Description of the Problem
Given two version numbers, version1 and version2, compare them.
Version numbers consist of one or more revisions joined by a dot '.'. Each revision consists of digits and may contain leading zeros. Every revision contains at least one character. Revisions are 0-indexed from left to right, with the leftmost revision being revision 0, the next revision being revision 1, and so on. For example 2.5.33 and 0.1 are valid version numbers.
To compare version numbers, compare their revisions in left-to-right order. Revisions are compared using their integer value ignoring any leading zeros. This means that revisions 1 and 001 are considered equal. If a version number does not specify a revision at an index, then treat the revision as 0. For example, version 1.0 is less than version 1.1 because their revision 0s are the same, but their revision 1s are 0 and 1 respectively, and 0 < 1.
Return the following:
If version1 < version2, return -1.
If version1 > version2, return 1.
Otherwise, return 0.

Example 1:
Input: version1 = "1.01", version2 = "1.001"
Output: 0
Explanation: Ignoring leading zeroes, both "01" and "001" represent the same integer "1".

Example 2:
Input: version1 = "1.0", version2 = "1.0.0"
Output: 0
Explanation: version1 does not specify revision 2, which means it is treated as "0".

Example 3:
Input: version1 = "0.1", version2 = "1.1"
Output: -1
Explanation: version1's revision 0 is "0", while version2's revision 0 is "1". 0 < 1, so version1 < version2.

Example 4:
Input: version1 = "1.0.1", version2 = "1"
Output: 1

Example 5:
Input: version1 = "7.5.2.4", version2 = "7.5.3"
Output: -1

Constraints:
1 <= version1.length, version2.length <= 500
version1 and version2 only contain digits and '.'.
version1 and version2 are valid version numbers.
All the given revisions in version1 and version2 can be stored in a 32-bit integer.
Code
Code

Link To The LeetCode Problem
LeetCode

I would like to be assigned to this. Thanks

repo: vJechsmayr/PythonAlgorithms


text:
Use https for Maven repositories

Related to vaadin/platform#766

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant alvarezguille

repo: vaadin/context-menu

license_source: bigquery


text:
Projects using templates inside frontend/views do not start with Vaadin 24.4 alpha9

Describe the bug
Running the start.vaadin.com tests for a new project using Flow + LitTemplate fails the Vite build
[ERROR] Failed to execute goal com.vaadin:vaadin-maven-plugin:24.4.0.alpha9:build-frontend (default) on project pre-javahtml: Execution default of goal com.vaadin:vaadin-maven-plugin:24.4.0.alpha9:build-frontend failed: Vite process exited with non-zero exit code.
[ERROR] Stderr: 'The directory of route files: file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/
[ERROR] The directory of generated files: file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/generated/
[ERROR] The output directory: file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/target/classes/META-INF/VAADIN/webapp
[ERROR] vite v5.1.4 building for production...
[ERROR] The file "file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/helloworldjavahtml/hello-world-javahtml-view.ts" should contain a default export of a component
[ERROR] The file "file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailjavahtml/master-detail-javahtml-view.ts" should contain a default export of a component
[ERROR] The file "file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsampleaddressjavahtml/master-detail-sample-address-javahtml-view.ts" should contain a default export of a component
[ERROR] The file "file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsamplebookjavahtml/master-detail-sample-book-javahtml-view.ts" should contain a default export of a component
[ERROR] Collected file-based routes
[ERROR] Frontend route list is generated: file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/target/classes/META-INF/VAADIN/views.json
[ERROR] Views module is generated: file:///tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/generated/views.ts
[ERROR] transforming...
[ERROR] frontend/generated/views.ts(6,109): error TS2769: No overload matches this call.
[ERROR]   Overload 1 of 2, '(path: string, children?: readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }> | undefined; children?: readonly Readonly<...>[] | undefined; }>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/helloworldjavahtml/hello-world-javahtml-view")' is not assignable to parameter of type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...'.
[ERROR]       Type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/helloworldjavahtml/hello-world-javahtml-view")' is missing the following properties from type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...': length, concat, join, slice, and 20 more.
[ERROR]   Overload 2 of 2, '(path: string, module: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>, children?: readonly Readonly<...>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/helloworldjavahtml/hello-world-javahtml-view")' is not assignable to parameter of type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR]       Property 'default' is missing in type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/helloworldjavahtml/hello-world-javahtml-view")' but required in type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR] frontend/generated/views.ts(6,199): error TS2769: No overload matches this call.
[ERROR]   Overload 1 of 2, '(path: string, children?: readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }> | undefined; children?: readonly Readonly<...>[] | undefined; }>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailjavahtml/master-detail-javahtml-view")' is not assignable to parameter of type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...'.
[ERROR]       Type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailjavahtml/master-detail-javahtml-view")' is missing the following properties from type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...': length, concat, join, slice, and 20 more.
[ERROR]   Overload 2 of 2, '(path: string, module: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>, children?: readonly Readonly<...>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailjavahtml/master-detail-javahtml-view")' is not assignable to parameter of type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR]       Property 'default' is missing in type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailjavahtml/master-detail-javahtml-view")' but required in type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR] frontend/generated/views.ts(6,317): error TS2769: No overload matches this call.
[ERROR]   Overload 1 of 2, '(path: string, children?: readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }> | undefined; children?: readonly Readonly<...>[] | undefined; }>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsampleaddressjavahtml/master-detail-sample-address-javahtml-view")' is not assignable to parameter of type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...'.
[ERROR]       Type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsampleaddressjavahtml/master-detail-sample-address-javahtml-view")' is missing the following properties from type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...': length, concat, join, slice, and 20 more.
[ERROR]   Overload 2 of 2, '(path: string, module: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>, children?: readonly Readonly<...>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsampleaddressjavahtml/master-detail-sample-address-javahtml-view")' is not assignable to parameter of type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR]       Property 'default' is missing in type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsampleaddressjavahtml/master-detail-sample-address-javahtml-view")' but required in type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR] frontend/generated/views.ts(6,429): error TS2769: No overload matches this call.
[ERROR]   Overload 1 of 2, '(path: string, children?: readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }> | undefined; children?: readonly Readonly<...>[] | undefined; }>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsamplebookjavahtml/master-detail-sample-book-javahtml-view")' is not assignable to parameter of type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...'.
[ERROR]       Type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsamplebookjavahtml/master-detail-sample-book-javahtml-view")' is missing the following properties from type 'readonly Readonly<{ path: string; module?: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | un...': length, concat, join, slice, and 20 more.
[ERROR]   Overload 2 of 2, '(path: string, module: Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>, children?: readonly Readonly<...>[] | undefined): Readonly<...>', gave the following error.
[ERROR]     Argument of type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsamplebookjavahtml/master-detail-sample-book-javahtml-view")' is not assignable to parameter of type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.
[ERROR]       Property 'default' is missing in type 'typeof import("/tmp/unzipped-test-pre-javahtml1391237071470546413svc-project/pre-javahtml/frontend/views/masterdetailsamplebookjavahtml/master-detail-sample-book-javahtml-view")' but required in type 'Readonly<{ default: unknown; config?: Readonly<{ title?: string | undefined; rolesAllowed?: readonly string[] | undefined; route?: string | undefined; menu?: Readonly<{ title?: string | undefined; order?: number | undefined; exclude?: boolean | undefined; icon?: string | undefined; }> | undefined; }> | undefined; }>'.

Expected-behavior
It works
Reproduction
See start tests
System Info
Vaadin 24.4 alpha9

As a workaround, one could either disable the FS router Vite plugin or move Lit templates files outside the frontend/views directory.

authors: Artur- Legioth

repo: vaadin/hilla


text:
Binding byte[] fields generates an error

Description of the bug
When calling binder.read() on an object that is based on a Java class that has a byte[], the binding fails with the following error in the browser:
Uncaught (in promise) TypeError: array.keys is not a function or its return value is not iterable
    at ArrayModel.[Symbol.iterator] (Models.ts:201:27)
    at ArrayModel.next (<anonymous>)
    at BinderNode.getChildBinderNodes (BinderNode.ts:349:18)
    at getChildBinderNodes.next (<anonymous>)
    at BinderNode.get errors [as errors] (BinderNode.ts:206:40)
    at BinderNode.ts:207:67
    at Array.reduce (<anonymous>)
    at Binder.get errors [as errors] (BinderNode.ts:206:63)
    at Binder.get invalid [as invalid] (BinderNode.ts:224:17)
    at Binder.updateValidation (BinderNode.ts:303:35)

Minimal reproducible example

Generate a new Hilla project using npx @vaadin/cli init --hilla my-hilla-app
Replace the content of HelloWorldEndpoint.java to look like the following:

@Endpoint
@AnonymousAllowed
public class HelloWorldEndpoint {

    Foo foo = new Foo();

    public HelloWorldEndpoint() {
        byte[] arr = new byte[20];
        new Random().nextBytes(arr);
        foo.setByteArray(arr);
    }

    @Nonnull
    public Foo loadFoo() {
        return foo;
    }

    class Foo{

        byte[] byteArray;

        public byte[] getByteArray() {
            return byteArray;
        }

        public void setByteArray(byte[] byteArray) {
            this.byteArray = byteArray;
        }
    }
}

Replace the content hello-world-view.ts with:

@customElement('hello-world-view')
export class HelloWorldView extends View {
  private binder = new Binder(this, FooModel);

  connectedCallback() {
    super.connectedCallback();
  }

  render() {
    return html`
      <vaadin-button @click=${this.fetch}>Fetch from server and read binder</vaadin-button>
    `;
  }

  async fetch() {
    const fromBackend = await HelloWorldEndpoint.loadFoo();
    this.binder.read(fromBackend);
  }
}

Expected behavior
The binding works without an error
Actual behavior
binder.read() generates the noted error
Versions:
- Vaadin / Hilla version: 1.0.7
- Java version: 17
- OS version: Windows

When debugging Model.ts, it's obvious that the error is caused by the returned value of the model being a String (instead of an array).


text:
Print version of GIB

Small improvement. There is already a TODO in MavenLifecycleParticipant:
logger.info("gitflow-incremental-builder starting..."); //TODO Print version.

AFAICS, the DRY approach would be to just read MANIFEST.MF (that is generated anyway) via java.util.jar.Manifest.
The only small downside to this is that we can only test this via an integration test which can operate on the jar that is created after phase test.
There is an alternative to that, but it seems a bit "over the top" for such a small issue: https://stackoverflow.com/a/43129180

Maybe you could try Resource Filtering which happens I think earlier and project versions would be accessed via [project.version] or something like that
https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html

Yeah, sure - but that would require another custom file.

authors: famod vackosar

repo: vackosar/gitflow-incremental-builder


text:
Parse ObjectID

When I try to parse the ObjectID from MongoDB in a web client, I get the following error
Invalid argument(s): Expected hexadecimal string with length of 24, got ObjectId("55a90733833d91c457d78065")

My code is
import 'package:bson/bson.dart';

ObjectId _id;
factory Customer.fromJson(Map m){
  var c =  new Customer()
  ...
  ...
  c._id = ObjectId.parse(m["_id"]);
}

Apparently m["_id"] already has valid ObjectID. If m created by bson, that would be case.
So maybe you should change your code to:
...
c._id = m["_id"];

I forgot to show the class that calls on 'Customer.fromJson'
_http
      .get('http://localhost:8080/api/customers/get')
      .then((response) {
        var list = response.data.map((e) => new Customer.fromJson(e));
        completer.complete(list);
      });

I'm using Angulardart and Shelf.
I have attached an example of the request to the server.

and the code is
Future<Response> saveCustomers(Request request) {
  var maps, cus = [];
  return _auth.open().then((_) {
      return request.readAsString().then((v) {
        maps = JSON.decode(v);
        maps.forEach((m1) {
          print('saving: ${m1.toString()}');

          customerColl
            .findOne(where.id(m1['_id']))
            ...
            ...

In the image ObjectID is a string and I need to convert it to an ObjectID object, when I try to use 'where.id(m1['_id'])', it gives me an error.
type 'String' is not a subtype of type 'ObjectId' of 'value'.

Well, I think now I know what is going on. My first guess is plainly wrong - would you pass real ObjectId into ObjectId.parse method there would be all sorts of type errors.
I suppose on server side you do not do special toJson encoding of Customer.
Currently in that case ObjectId is saved in Json as result of toString method - therefore that ObjectId('123fa....') representation.
You could ensurre that ObjectId is saved simply as hexString while encoding MongoDb object to Json
For example:
    _toEncodable(obj) {
  if (obj is DateTime) {
    return obj.toString();
  }
  if (obj is ObjectId) {
    return obj.toHexString();
  }
  return obj.toJson();
}
String jsObj = JSON.encode(obj, toEncodable: _toEncodable);

(I've added DateTime encoding for good measure - date fields stored in MongoDb shout require something like it too)

But looking at your scenario (I suppose it is quite usual) - I see that current behaviour of ObjectId is not so smart. It has toXml() method defaulting to toString() - so encoding to JSon silently stores ObjectId in form not suitable for ObjectId.parse().
Maybe right thing would be to do same as DateTime. It do not have toJson() method so it force you to make encoding manually,
On the other hand it could make toJson return toHexString() so it silently by default store in json value convenient for decoding by ObjectId.parse
I'll probably switch to last option in next version of bson and mongo_dart.

I think the last option it best, since
Json.encode()

automatically calls toJson method on objects.
My workaround solution is currently calling this method on server and client side, when I need to create my object.
String objecid(String id) {
  return id.substring(10, 34);
}

Have any of your objects DateTime properties? I think toJson() without toEncodable parameter breaks on map with DateTime value

No they don't have any DataTime properties

When I query the database, the returned _id is a string
 return customers.find(where.exists('_id').sortBy('name')).forEach((Map c){
      cus.add(JSON.encode(c, toEncodable: _toEncodable));
    });

All the other value has been converted to their correct types.
Wouldn't it be better if _id was converted to a ObjectId by the mongodart driver?

I've updated mongo_dart package at the github with that behaviour. Have not published that version at pub yet. Can you check how it would work for you?

If it is the master branch, then I can only see that you have modified yaml and a test file.
I have work around the problem, by using these method
JSON.decode(v, reviver: _toDecodable)
JSON.encode(m, toEncodable: _toEncodable)

 dynamic _toDecodable(k, v) {

  if ('_id' == k)
    return ObjectId.parse(v);

  return v;
}

dynamic _toEncodable(obj) {

  if (obj is ObjectId) {
    return obj.toHexString();
  }

  return obj.toJson();
}

The ObjectId get converted to Hex string, when sending between server and client and vice versa.

If it is the master branch, then I can only see that you have modified yaml and a test file.

Yes, I've modified yaml file and now it use new version of bson package. In that version ObjectId.toJson implemented as toHexString instead of toString.
Your workaround should work with any version of mongo_dart though.

Bson code on GitHub still shows toJson  to use toString.
But the code from pub.dartlang.org use toHexString
It works fine now.

Good catch. I have published bson on put but not pushed it on github.
Thank you for pointing me at that

authors: vadimtsushko zijam

license: mit


text:
Feature/fbp 88 cascade location upd to boundaries

Fixes #88

Codecov Report

Merging #103 into master will decrease coverage by 0.32%.
The diff coverage is 18.18%.

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     54.50%   54.17%   -0.33%
- Complexity      574      576       +2
============================================
  Files            79       80       +1
  Lines          3077     3103      +26
  Branches        583      586       +3
============================================
+ Hits           1677     1681       +4
- Misses         1174     1196      +22
  Partials        226      226

Flag
Coverage Δ
Complexity Δ

#unittests
54.17% <18.18%> (-0.33%)
576.00 <4.00> (+2.00)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

...n/com/valb3r/bpmn/intellij/plugin/events/Events.kt
60.00% <0.00%> (ø)
0.00 <0.00> (ø)

...tellij/plugin/render/DefaultBpmnProcessRenderer.kt
51.29% <0.00%> (ø)
24.00 <0.00> (ø)

...ender/elements/shapes/AnyShapeNestableIconShape.kt
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...ntellij/plugin/render/elements/shapes/IconShape.kt
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../intellij/plugin/flowable/parser/FlowableParser.kt
64.87% <0.00%> (-0.42%)
50.00 <1.00> (ø)

...lugin/render/elements/shapes/ShapeRenderElement.kt
80.67% <47.61%> (+0.49%)
22.00 <3.00> (+1.00)

...ginjection/FlowableDelegateExpressionUiInjector.kt
58.82% <0.00%> (+5.88%)
7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818cb68...4b68863. Read the comment docs.


text:
Add Node.js Valkey Commands (wiki)

https://github.com/valkey-io/valkey-glide/wiki/NodeJS-wrapper
This PR is to replace existing NodeJS-wrapper's Valkey Command section.

Changes have updated to https://github.com/valkey-io/valkey-glide/wiki/NodeJS-wrapper#valkey-commands. Close this PR.

repo: valkey-io/valkey-glide


text:
Merchant Ore Bug

Describe the bug
The merchant sells copper and iron ore for 1 gold each.
To Reproduce
Steps to reproduce the behavior:

Go to the merchant.
Open his shop.
Cycle over to ores.'
Open up ores.
Both copper and iron ore cost 1 gold coin each.

Expected behavior
I expected a much cheaper price.

What kind of price were you hoping for?

That's very cheaty, don't think I'm going to do that.

I just want you to lower the price from one gold coin. :p

repo: valkyrienyanko/MerchantsPlus


text:
Keypair login for Snowflake connector

@noora wrote
Snowflake allows setting up keypair login instead of username/password. Some of our customers would like to have this possibility for the Snowflake connector.
It would be great to have a similar option as what we now have for Redshift/BigQuery and using IAM for authentication that for example with a boolean the user could choose to use either password or keypair login. For this there should be a new environment variable field SNOWSQL_PRIVATEKEY.
Snowflake docs for keypair authentication: https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-example#using-key-pair-authentication-key-pair-rotation

Short description for implementation in case someone else takes this:

[ ] Add dependency cryptography to requirements.txt
[ ] Load the SNOWSQL_PRIVATEKEY and SNOWSQL_PASSPHRASE environment variables in snowflake/query.py
[ ] Create snowflake/connect.py (look at bigquery/connect.py for inspiration)
[ ] If there is private key, load and transform the key and call snowflake.connector.connect()
[ ] If there is no private key, do what we currently do with login/password

The cryptography stuff isn't strictly necessary though, there's no additional protection if the private key and the passphrase are submitted in the same request :)

authors: JuhaKiili akx

repo: valohai/library-sandbox


text:
Dropdown not working on bootstrap 4 Alpha 6

Dropdown is not expanding using Bootstrap v4.0.0-alpha.6. According to https://github.com/twbs/bootstrap/issues/20939 on Alpha.6 the class .open was renamed to .show:
"Renamed some .active, all .in, and all .open classes for our JavaScript powered components for more consistent naming. For example, instead it's now .collapse.show instead of .collapse.in and .show > .dropdown-menu instead of .open > .dropdown-menu to better communicate the visibility of elements."
Currently ng2-bootstrap dropdown is still adding the .open class. If I change it manually to .show it is working, so it should be updated.
Thank you.

see #1458 and #1553

thanks, closing as this is duplicate

authors: fchiumeo lumineida


text:
Bump open-aea and open-autonomy frameworks

Proposed changes
Bumps open-aea and open-autonomy frameworks.
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[ ] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have locally run services that could be impacted and they do not present failures derived from my changes

Further comments
n/a

LGTM. Some linter failures.

Not related to this repo:
https://github.com/valory-xyz/contribution-service/actions/runs/5759356448/job/15613314482?pr=123#step:6:104

repo: valory-xyz/contribution-service


text:
Send tx unsafe

Proposed changes
Expose a method that sends a transaction and raises on error. We need this method in order to be able to handle it from the tx settlement skill and know why the transaction digest has not been returned and act properly.
Fixes
n/a
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[ ] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
n/a

Codecov Report

Merging #87 (6e8c9e6) into main (e6037df) will increase coverage by 0.09%.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   96.76%   96.86%   +0.09%
==========================================
  Files         317      307      -10
  Lines       24763    24270     -493
==========================================
- Hits        23962    23509     -453
+ Misses        801      761      -40

Flag
Coverage Δ

unittests
96.86% <73.52%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...es/fetchai/connections/ledger/ledger_dispatcher.py
94.31% <16.66%> (-5.69%)
:arrow_down:

aea/crypto/ledger_apis.py
96.22% <33.33%> (-3.78%)
:arrow_down:

aea/helpers/ipfs/base.py
88.53% <78.82%> (-11.47%)
:arrow_down:

aea/cli/run.py
88.13% <100.00%> (ø)

aea/configurations/base.py
100.00% <100.00%> (ø)

aea/crypto/base.py
96.82% <100.00%> (+0.05%)
:arrow_up:

aea/__init__.py
100.00% <0.00%> (ø)

packages/fetchai/protocols/gym/dialogues.py
100.00% <0.00%> (ø)

packages/fetchai/connections/gym/__init__.py
100.00% <0.00%> (ø)

...s/aea-ledger-fetchai/aea_ledger_fetchai/_cosmos.py

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306f500...6e8c9e6. Read the comment docs.

Closed in favor of #88 .

authors: Adamantios codecov-commenter

repo: valory-xyz/open-aea


text:
Open API

Is it possible to get an open use API for this? Without reverse engineering it of course, I'd like to be able to get these from a quick get request on the API.

There's really only one endpoint that matters and that's the /submit URL.
My poor website is apparently being hit too hard at the moment for me to test this, but here's an example using the Python requests module:
r = requests.get(baseurl, params={'text': 'Hi!\nThis is an API call!', 'moodImg': ['images/sprites/Papyrus/0.png']})

That request generates the following URL:
http://thehotvoice.mccowan.space/?text=Hi%21%0AThis+is+an+API+call%21&moodI
mg=images%2Fsprites%2FPapyrus%2F0.png

so if you're using something other than the Python requests module you just need to make a URL like that. You'll get back a b64-encoded PNG file.
It's not designed to be accessed like this so if you do it wrong the error message might not be very helpful. In particular, the text you pass in is split into groups of 3 lines, each of which groups goes into a dialog box. You need to pass one moodImg param for each box. And the moodImg arguments are just numbers (the path construction should be pretty obvious) so you need to figure out what number corresponds to which picture. (You can just look in here to find that out!)
That's about it. LMK if that's not enough to go on.

Awesome thanks!

Hmm you'll probably get the same result if you use your link, but using yours or other requests, it just directs me to the http://thehotvoice.mccowan.space/ page, and it seems trying anything on the /submit endpoint, it 404's

Alright, I got it working. The working example URL that worked for me:
'http://ianmccowan.nfshost.com/undertale/submit?text=Hi%21%0AThis+is+an+API+call%21&moodImg=%2Fundertale%2Fstatic%2Fimages%2Fsprites%2FPapyrus%2F0.png

For some reason it doesn't like you to do it with the thehotvoice URL; I guess the redirect I'm using with my domain doesn't play well with requests.

Oh, actually, this works too:
http://thehotvoice.mccowan.space/undertale/submit?text=Hi%21%0AThis+is+an+API+call%21&moodImg=%2Fundertale%2Fstatic%2Fimages%2Fsprites%2FPapyrus%2F0.png

Note that I had to add a couple extra path components to the sprite image as well.

Oh there we go awesome, thanks!

No problem. Closing this now.

Oh just to let you know, in testing, I found that http://ianmccowan.nfshost.com yielded the actual result http://thehotvoice.mccowan.space popped it in an <iframe>

What about http://thehotvoice.mccowan.space/undertale ?

On both I was using /undertale/submit

Did you say you were forewarning the domain instead of DNS?

Forewarding*

repo: valrus/undertale-dialog-generator


text:
Porting libtokencap to Darwin.

Reading only main addresses and read only's.

@devnexen : thanks!
@hexcoder- : how about porting this to OpenBSD at the same time?
(or even FreeBSD/NetBSD if one of you two is able to (system availabilty and time))

I can help of any BSD if necessary.

Great, thanks!
Yes, let us compare *BSDs APIs and integrate all of them (if possible).
I am able to run NetBSD, FreeBSD, OpenBSD in VirtualBox and Darwin on a Mac mini, but need to investigate the APIs before.

@hexcoder since you seem to like OpenBSD maybe you would like to have a take on ? Did the FreeBSD implementation maybe we can merge it it is ok or still work from this branch ?

It checked the Darwin part and it is ok. Thanks very much. I enabled the corresponding test in the script for make tests. FreeBSD has problems yet, since the test does not succeed.
It is ok to work here for me.

Test in subdirectory test with
cc -o test-compcov test-compcov.c
AFL_TOKEN_FILE=token.out LD_PRELOAD=../libtokencap.so ./test-compcov foobar
grep BUGMENOT token.out

Bingo!

ok, can investigate NetBSD and OpenBSD tomorrow.

good job guys!

@devnexen: Could you help out with NetBSD? It partly works, but seems to grab invalid addresses,  which later lead to seg faults :-(

Try to refactor for NetBSD case instead as :
for (I = 0; I<len; i++) { ... getting region as region[I].. }
or maybe mmap flags to be changed or making a simple malloc for NetBSD.
Hope it helps.

ok, I ask at the NetBSD mailing list then.

might help in case but I took little time to look at it and in fact the segfault occurs when dumping the tokens. When I redirect to say stderr, it does not segfault.

Thanks, that is interesting. So the iteration might be ok, then.

authors: devnexen hexcoder- vanhauser-thc

repo: vanhauser-thc/AFLplusplus


text:
babel-plugin failed to compile type Modifiers on Import Names.

Describe the bug
Babel-plugin breaks when reading a line with type modifiers on import Names ( import {type Sometype} from "..." ) which was introduced in typescript 4.5. The error says Syntax error: Unexpected token, expected ",". The app uses Nextjs, so I can't confirm about the others.
Link to reproduction:
https://github.com/harisraharjo/ve-babel-plugin-repro
System Info
"@vanilla-extract/babel-plugin": "^1.1.5",
"@vanilla-extract/css": "^1.6.8",
"@vanilla-extract/next-plugin": "^2.0.1",
"@vanilla-extract/sprinkles": "^1.4.0"

any solution？

@sillysillyc The reproduction is gone, but it's likely that they were locked to an older version of babel that didn't support TS 4.5 syntax. @vanilla-extract/babel-plugin is no longer required for integrations, so it can be removed. Please open a new issue if you've found a reproducible bug.

authors: askoufis harisraharjo sillysillyc

repo: vanilla-extract-css/vanilla-extract


text:
index.html is too large

As a result of #389, the index.html file is now 13MB+. Not only is this poor for performance, but it creates large hosting costs for me like #334 did. EDIT: AWS is offsetting hosting costs for this so the expense is no longer a concern.
A few quick ideas for solutions:

Serve different files for each region (/index.html, /us-west-1.html, ap-northeast-1.html, etc)
Begin loading pricing data on-demand as the region changes (would require new per-region JSON files with the pricing data)
Move hosting somewhere free like GitHub (the "solution" for #334). Doesn't help the performance issues though.

cc @blckct

Yeah, I'm on LTE at home and the page takes forever to load.

It seem gzip is not enabled, could you double check that cloudfront has automatic compression enabled? It's also possible to upload the files to S3 already gziped and set correct headers for them.
At my previous job we considered moving to digital ocean spaces as it seems much cheaper than cloudfront but I haven't tried it.
Probably an improvement would be not indexing data by string, looking at the file I see things like "yrTerm1Standard.noUpfront" repeated hundreds of times.

Gzip is being added via CloudFront now luckily. Are you not receiving a gzipped copy?
Looked at other CDN prices before and everything seemed quite similar, except for totally free options like github sites.
Shortening those keys would probably help a good bit, though not a full solution. Nice idea.

Well DO advertises "$0.01 per additional GB transferred (CDN included)" so it should be cheaper but like I say I haven't tried it.
As for gzip no I'm not getting a gziped version, you can try it yourself:

blckct@kofeina-pc:~$ curl -I 'https://ec2instances.info' -H 'accept-encoding: gzip, deflate, br'
HTTP/2 200
content-type: text/html
content-length: 13982535
date: Sun, 03 Feb 2019 20:15:40 GMT
last-modified: Sun, 03 Feb 2019 19:25:20 GMT
etag: "68dcd59c8571a65fc0298d82aefb08ac"
server: AmazonS3
age: 2054
x-cache: Hit from cloudfront
via: 1.1 87de52593927dfce090da0b24ddc3123.cloudfront.net (CloudFront)
x-amz-cf-id: 5XPKV0CSjGfGFsKHDmlbUxBWp3JltPmWLMeTDblImBIWVuVyXR9miw==

versus:

blckct@kofeina-pc:~$ curl -I 'https://github.com' -H 'accept-encoding: gzip, deflate, br'
HTTP/1.1 200 OK
Date: Sun, 03 Feb 2019 20:49:58 GMT
Content-Type: text/html; charset=utf-8
Server: GitHub.com
Status: 200 OK
Vary: X-PJAX
ETag: W/"4ed027506279f9bc29bfbcd905e01f32"
Cache-Control: max-age=0, private, must-revalidate
Set-Cookie: has_recent_activity=1; path=/; expires=Sun, 03 Feb 2019 21:49:57 -0000
Set-Cookie: _octo=GH1.1.1486520581.1549226997; domain=.github.com; path=/; expires=Wed, 03 Feb 2021 20:49:57 -0000
Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Thu, 03 Feb 2039 20:49:57 -0000; secure; HttpOnly
Set-Cookie: _gh_sess=Z2xJY0V0RFpkWVBINGFoMXVadFYrVjFlL2RlMEhTcGZ2WGsyY2VRWld5Y25MbERMcENBcUVKaWIyamxkbjNDMDBSMVE3M3RiZ2NDa3dPYlZuUmhrYVlPaUxNeVBqcXNRdjkzaTE4aExRR1JKbk9QallpTlNtMnRFOVVFaXdtbVZzTnM3aFZhOVFtKzB6VlFIN2dBTDExWHdtMU42M0dXN0cwSkpXTGtoaU44Nm1NZC81OCs1NUk4eEFlYXlwSVcrYW1rL1NBeTJiV2UrYkxMSzdIaDRCUT09LS16aVpTQ0xVT21TbFpCQXNuTFVzMnNnPT0%3D--2bc18d0492d27b4e2ef2f83f73e20f3cfffc3793; path=/; secure; HttpOnly
X-Request-Id: 7c2e8861-1a13-4c18-bc67-c8581c9e0aa1
Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
X-Frame-Options: deny
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Referrer-Policy: origin-when-cross-origin, strict-origin-when-cross-origin
Expect-CT: max-age=2592000, report-uri="https://api.github.com/_private/browser/errors"
Content-Security-Policy: default-src 'none'; base-uri 'self'; block-all-mixed-content; connect-src 'self' uploads.github.com www.githubstatus.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com wss://live.github.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com; frame-ancestors 'none'; frame-src render.githubusercontent.com; img-src 'self' data: github.githubassets.com assets-cdn.github.com identicons.github.com collector.githubapp.com github-cloud.s3.amazonaws.com *.githubusercontent.com; manifest-src 'self'; media-src 'none'; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com
Content-Encoding: gzip
Vary: Accept-Encoding
X-GitHub-Request-Id: C690:D8BF:6C2A77D:A4F9A01:5C5753F5

Aha - looks like CloudFront's automatic compression stops working at 10mb. Extra motivation to shrink the file size. :)

The file size must be between 1,000 and 10,000,000 bytes.

https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/ServingCompressedFiles.html

It is enabled:

Hey, I just realized the deploy script actually is part of this repository so I decided to spend a couple of minutes to make a proof of concept of gziping the files before upload (#414). I tested it with S3 website hosting and it seems to work but may require additional tests. Brings the index.html from 13MB to under 1MB.

@powdahound Hey, any update on this? Did the costs go back to normal?

@blckct Yeah it's at a reasonable level now after your gzip fix. :) Would still be nice to actually shrink it but not a pressing concern at the moment.

#438 might help a bit. It reduces index.html from 16mb to 5.7mb.

I might be willing to chip in a little bit to help out here. I know it's a tad different approach, but what if the rebuild were to build a JSON structure (or maybe two? one for EC2 and one for RDS?) and then the index.html simply pulls the version that's needed and then uses JS to render it. It wouldn't be too hard to pull off either. It would keep it a static site (keep costs down) and also provides the advantage of letting the data become consumable by API. Thoughts?

Not sure about RDS, but for EC2 we do have a JSON file which we use to render the HTML.
I agree that using it would be great, just that we don't have the bandwidth to do it so any contribution toward this would be very welcome.

@mikesir87 Thanks for the thoughts. A few things to note:

JSON files are already available at ec2instances.info/instances.json and ec2intstances.info/rds/instances.json. They're also huge, so loading them dynamically wouldn't offer any savings.
The HTML files for EC2/RDS are already split as well
AWS is chipping in $ to host this now so the financial component to this issue isn't a problem any more. 👍 I'll make a note of that in the top level post

@powdahound Thanks for the notes! And great to hear that you're getting some help to cover the costs! Woot!
With you pointing me to the JSON (I also finally ran it locally to take a look), it looks like most of what can easily be done has been done. Beyond what's here, it would take quite a bit more work to break things up smaller. But, here's kinda what I was thinking:

Have one set of JSON files to describe the machines themselves
Separate out the pricing into other files, probably by region (since the UI displays only by region). I think this is the biggest win because 9 out of 10 times, folks are looking at one or two regions. Why ship it all then unless they want it?
When the page starts, start with an empty shell, not rendered HTML. It could render a default region so something's there. Your call.
If starting empty or changing region, fetch the appropriate JSON file to display based on the current selection

As a quick test, removing the pricing from the EC2 instances.json drops the filesize 98.7% to 380K as formatted JSON, 284K minifed, and 16K gzipped. Each region file is about 1.7M formatted, 1.3MB minified, and 168K gzipped.
Anywho... I totally get that that would be quite a change and one that might not be worth doing. But, was kinda a fun experiment. If you decide you want to go that route though, let me know and I'll be happy to help out! There isn't too much custom JavaScript that would be needed to pull it off and just a few tweaks to the creation of the JSON files.

Great experiment - thanks! Totally agree that it's wasteful to load so much pricing data that often goes unseen.
I do like the idea of splitting up the JSON files, though I believe there are other projects out there crawling them and I wonder what data they're expecting. I suppose the primary instances.json files could be left unchanged, and new ones could be created for this dynamic loading setup.
The library used for the table hasn't handled dynamic data changing well in the past (related: #274), but I'm not sure if that's because it's being used poorly or just isn't designed for it. The frontend of this site is quite dated...

Good point on the existing instances.json. Makes total sense to make new ones to not break existing services.
I'll take a look at the frontend and see what exact libraries are being used there. I'll admit I had completely missed the CSV download, so thanks for linking to the related issue. I'll loop back around soon! 👍

Shoutout to @powdahound this did end up being the idea we went with:

Begin loading pricing data on-demand as the region changes (would require new per-region JSON files with the pricing data)

authors: EverettBerry blckct cristim kichik mikesir87 powdahound


text:
Updating the version shield to show Swift 4

The alt text has already been updated, but not the URL.

thanks :)

repo: vapor/fluent-provider


text:
tls socket improvements

Addresses #16
TLS.Socket now has an internal TCPInternetSocket. This will make it harder to mess up the correct ordering of connect() or accept().
Config was changed to take a Context. This ensures tls_init is called before any other tls_* method can be called (as required by the libressl docs). It also gives the Config object access to the context for error messages in case loading the certs fails.
Most controversially (possibly) I removed the tls_config_insecure_noverifycert in the case of Certificates.none being passed. My thinking here is that one should have to explicitly pass verifyCertificates: false in the Config to disable this functionality (safety by default). I added a warning for this case.
@czechboy0 and @LoganWright please check this out.

Current coverage is 65.98% (diff: 66.25%)

Merging #18 into master will increase coverage by 15.19%

@@             master        #18   diff @@
==========================================
  Files             5          5
  Lines           126        147    +21
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             64         97    +33
+ Misses           62         50    -12
  Partials          0          0

Powered by Codecov. Last update 0e6f51c...51e7a40

@tannernelson Awesome work! I agree with all the refactoring, we might just provide the mozilla certificates to the library as well when creating a basic client (I think we should provide an out-of-the-box working client, which already uses the mozilla certs to connect to servers - but that can wait for the next PR).
Regarding the default of Certificates.none - I absolutely think this is the right way, that we fail if no certs are provided. If users want to provide no certs, they should also explicitly say to not verify certs, otherwise that would be a very easy way to invisibly end up with an insecure connection.

authors: codecov-io czechboy0 tannernelson

repo: vapor/tls


text:
update Flux.jl for GLPK v0.14.2

I updated Flux.jl to get it run with GLPK v0.14.2.
# ----------------------------------------------------------------------------------- #
# Copyright (c) 2020 Varnerlab
# Robert Frederick School of Chemical and Biomolecular Engineering
# Cornell University, Ithaca NY 14850

# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
# ----------------------------------------------------------------------------------- #

"""
    calculate_optimal_flux_distribution(S,[Lv,Uv],[Lx,Ux],c; min_flag=true)

    Computes the optimal metabolic flux distribution given the constraints.

    Inputs:
    `S` - stoichiometric_matrix (M x R)
    `[Lv,Uv]` - (R x 2) array of the flux lower (L) and upper (U) bounds
    `[Lx,Ux]` - (M x 2) array of species lower (L) and upper (U) bounds (if at steady-state, L = U = 0)
    `c` - R x 1 vector holding indexes for objective vector

    Outputs:
    `objective_value` - value of the objective function at the optimum
    `calculated_flux_array` - R x 1 flux array at the optimum
    `dual_value_array` - R x 1 dual values
    `uptake_array` - M x 1 array of S*v
    `exit_flag` = 0 if optimal
    `status_flag` = 5 if optimal
"""
function calculate_optimal_flux_distribution(stoichiometric_matrix::Array{Float64,2}, default_bounds_array::Array{Float64,2}, species_bounds_array::Array{Float64,2}, objective_coefficient_array::Array{Float64,1}; min_flag::Bool = true)

    # set some constants -
    TIME_RESTART_LIM = 60

    # Get the stoichiometric_matrix from data_dictionary -
    (number_of_species,number_of_fluxes) = size(stoichiometric_matrix);

    # # Setup the GLPK problem -
    lp_problem = GLPK.glp_create_prob();
    GLPK.glp_set_prob_name(lp_problem, "sample");
    GLPK.glp_set_obj_name(lp_problem, "objective")

    # Set solver parameters
    solver_parameters = GLPK.glp_smcp();
    GLPK.glp_init_smcp(solver_parameters);
    solver_parameters.msg_lev = GLPK.GLP_MSG_OFF;

    # Are we doing min -or- max?
    if min_flag == true
    	GLPK.glp_set_obj_dir(lp_problem, GLPK.GLP_MIN);
    else
    	GLPK.glp_set_obj_dir(lp_problem, GLPK.GLP_MAX);
    end

    # Set the number of constraints and fluxes -
    GLPK.glp_add_rows(lp_problem, number_of_species);
    GLPK.glp_add_cols(lp_problem, number_of_fluxes);

    # Setup flux bounds, and objective function -
    (number_of_fluxes,number_of_bounds) = size(default_bounds_array)
    for flux_index = 1:number_of_fluxes

    	flux_lower_bound = default_bounds_array[flux_index,1]
    	flux_upper_bound = default_bounds_array[flux_index,2]

    	# Check bounds type ... default is DB -
    	if (flux_upper_bound == flux_lower_bound)
    		flux_constraint_type = GLPK.GLP_FX
    	else
    		flux_constraint_type = GLPK.GLP_DB
    	end

    	# flux symbol? (later use name - for now, fake it)
    	flux_symbol = "R_"*string(flux_index)

    	# Set the bounds in GLPK -
    	GLPK.glp_set_col_name(lp_problem, flux_index, flux_symbol);
    	GLPK.glp_set_col_bnds(lp_problem, flux_index, flux_constraint_type, flux_lower_bound, flux_upper_bound);
    end

    # Setup objective function -
    for (flux_index,obj_coeff) in enumerate(objective_coefficient_array)

    	# Set the objective function value in GLPK -
    	GLPK.glp_set_obj_coef(lp_problem, flux_index, obj_coeff);
    end

    # Setup problem constraints for the metabolites -
    for species_index = 1:number_of_species

    	species_lower_bound = species_bounds_array[species_index,1]
    	species_upper_bound = species_bounds_array[species_index,2]

    	# defualt
    	species_constraint_type = GLPK.GLP_FX
    	if (species_lower_bound != species_upper_bound)
    		species_constraint_type = GLPK.GLP_DB
    	end

    	# set the symbol -
    	species_symbol = "x_"*string(species_index)

    	# Set the species bounds in GLPK -
    	GLPK.glp_set_row_name(lp_problem, species_index, species_symbol);
    	GLPK.glp_set_row_bnds(lp_problem, species_index, species_constraint_type, species_lower_bound, species_upper_bound);

    end

    # Setup the stoichiometric array -
    counter = 1;
    row_index_array = zeros(Cint,number_of_species*number_of_fluxes);
    col_index_array = zeros(Cint,number_of_species*number_of_fluxes);
    species_index_vector = collect(1:number_of_species);
    flux_index_vector = collect(1:number_of_fluxes);
    flat_stoichiometric_array = zeros(Float64,number_of_species*number_of_fluxes);
    for species_index in species_index_vector
    	for flux_index in flux_index_vector
    		row_index_array[counter] = species_index;
    		col_index_array[counter] = flux_index;
    		flat_stoichiometric_array[counter] = stoichiometric_matrix[species_index,flux_index];
    		counter+=1;
    	end
    end
    GLPK.glp_load_matrix(lp_problem, number_of_species*number_of_fluxes, GLPK.offset(row_index_array), GLPK.offset(col_index_array), GLPK.offset(flat_stoichiometric_array));

    # Call the solver -
    exit_flag = GLPK.glp_simplex(lp_problem, solver_parameters);

    # Get the objective function value -
    objective_value = GLPK.glp_get_obj_val(lp_problem);

    # Get the calculated flux values from GLPK -
    calculated_flux_array = zeros(Float64,number_of_fluxes);
    for flux_index in flux_index_vector
    	calculated_flux_array[flux_index] = GLPK.glp_get_col_prim(lp_problem, flux_index);
    end

    # Get the dual values -
    dual_value_array = zeros(Float64,number_of_fluxes);
    for flux_index in flux_index_vector
    	dual_value_array[flux_index] = GLPK.glp_get_col_dual(lp_problem, flux_index);
    end

    # is this solution optimal?
    status_flag = GLPK.glp_get_status(lp_problem)

    # Calculate the uptake array -
    uptake_array = stoichiometric_matrix*calculated_flux_array;

    # Formulate the return tuple -
    return (objective_value, calculated_flux_array, dual_value_array, uptake_array, exit_flag, status_flag);
end

Peter updated Flux.jl in  repo - AA tried new version. g2g

repo: varnerlab/CFMG


text:
How to add custom/self host TURN server?

How to add custom/self host TURN server?
on index.html
I tried to put own Turn Server in following format, but this is not working
var ICE_SERVERS = [
	{ 'urls': 'stun:stun.l.google.com:19302' },
	{ 'urls': 'stun:stun.stunprotocol.org:3478' },
	{ 'urls': 'stun:stun.sipnet.net:3478' },
	{ 'urls': 'stun:stun.ideasip.com:3478' },
	{ 'urls': 'stun:stun.iptel.org:3478' },
	{ 'urls': ['turn:myturn.com:3478'],'username':'123','credential':'123'}
];

@hassaan-dev Please check this https://stackoverflow.com/questions/26342589/how-does-webrtc-decide-which-turn-servers-to-use

@vasanthv I have tested TURN server via https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/
I just need to know, is my above format is OK or NOT
2nd thing, When I open https://itshello.co/ this redirect to random URL like https://itshello.co/2k1bmi
How can I redirect in the same way?

@hassaan-dev

The format seems ok to me as per MDN https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer/urls

It is not an actual redirection, but just the URL change. You can do it the same way as it is done in this line
https://github.com/vasanthv/hello/blob/master/index.html#L59

Thank you @vasanthv for quick response
I am currently deploying this on this URL https://hello.saedhamdan.com:3000/
Redirection is not working, can you please have a look?
2nd Turn Server is also in same error. Video is not working if network is not same.
If I post logs from about:webrtc that will helpful for you to debug the issue?

I see the pushState error. You are trying to push https://hello.saedhamdan.com/blah from  https://hello.saedhamdan.com:3000/. It will get rejected as the Origin is different. If the Room ID is not present it can mess many things. So can you fix that first.

@vasanthv I resolve the pushState error
This was cause of port at end of URL. I think this is enhancement in code to make it work with PORT is URL.
anyways please try this link now, https://hello.saedhamdan.com/s0pggj

@hassaan-dev Yes. Now PushState is fixed and the video is working fine for me.
I guess you haven't enabled autoplay of the video in Chrome. It wont play the video immediately, you need to enable autoplay for it to work.

Do you see me in video? the other person's video does not work if he/she is using other network.
This is working fine when both persons are using same network

@hassaan-dev It seems to work fine for me.
I tried one in a Wifi & another in my mobile (4G network). https://www.dropbox.com/s/dwz40nfcvkf9jaa/Screenshot 2019-03-07 14.26.10.png?dl=0
May be your ISP is messing up or something.

Thanks @vasanthv once again
Okay, I will check this and update the solution or actual problem here to help other people if some someone face the same issue

authors: hassaan-dev vasanthv

repo: vasanthv/hello


text:
#2417 Explore reimplementing HashMap as CHAMP (Compressed Hash-Array Mapped Prefix-tree)

This is a draft intended for discussion.
This merge requests explores how a migration of the HAMT trie to a CHAMP trie could look like:

HashSet, HashMap: Replaces the internal HAMT data structure by a CHAMP data structure.
LinkedHashSet, LinkedHashMap: Replaces the internal HAMT+Seq data strucures by CHAMP+Vector data structures.
The changes are intended to affect the performance of vavr, but are not supposed to change any API.

The changes are somewhat sub-optimal and somewhat over-complicated, because I strived to not break any of the unit tests. (I believe that I should change a number of unit tests, because some rely on the iteration sequence of the HAMT implementation. However, the vavr API specifies that the iteration sequence is unspecified.)
The code is a port from the JHotDraw 8 collections module. https://github.com/wrandelshofer/jhotdraw8/tree/main/org.jhotdraw8.collection
The JHotDraw 8 collections are in turn a port of the 'capsule' collection library https://github.com/usethesource/capsule, and of vavr.
I do not expect that this draft can be merged in the current form. In JHotDraw 8 we have a mutable 'partner' collection for every immutable collection. This allows to test all immutable collections with the 'guava-testlib' library. Which provides very through tests. I did not want to change the API of vavr - so I have downgraded the mutable collections to transient collections. But I have not written new tests yet. So code coverage by unit tests is currently lower than I want it to be.

I made now a release that is binary compatible with vavr 0.10.5.
You can get it here: https://github.com/wrandelshofer/vavr/releases/tag/v0.10.5

repo: vavr-io/vavr


text:
chore(deps): Update dependencies

Updated everything except JUnit.
If this pull request is accepted, a separate one will be submitted for JUnit 5 with lots of small code changes.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.78%. Comparing base (e43e44b) to head (683ee89).
Report is 45 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2748      +/-   ##
============================================
+ Coverage     92.74%   92.78%   +0.03%
- Complexity     5247     5262      +15
============================================
  Files            89       89
  Lines         12538    12535       -3
  Branches       1604     1595       -9
============================================
+ Hits          11628    11630       +2
+ Misses          721      718       -3
+ Partials        189      187       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks good to me, thanks :)

You're welcome, thanks for merging :)
Didn't know there was a new maintainer, cool! Do you want to upgrade to JUnit Jupiter? JUnit 4 is 3 years old and EOL...

If you feel like it, then go and do it :) stretch goal: update https://github.com/vavr-io/vavr/tree/version/0.10.5 as well

stretch goal: update https://github.com/vavr-io/vavr/tree/version/0.10.5 as well

I don't understand, 0.10.5 and 0.11.0 are extremely different from master, for example Maven instead of Gradle, let alone licenses, copyrights, docs, imports, code and tests.
What kind of branches are they? What is there to update?
Every release should be tagged from the default branch (master), or a child branch which just adds commits to the same base.


text:
defaultValue类型为number时, 点击编辑 setFieldsValue的值会被覆盖掉

⚠ 重要 ⚠ 在进一步操作之前，请检查下列选项。如果您忽视此模板或者没有提供关键信息，您的 Issue 将直接被关闭

[ ] 已阅读 文档.
[ ] 确保您的代码已是最新或者所报告的 Bug 在最新版本中可以重现. (部分 Bug 可能已经在最近的代码中修复)
[ ] 已在 Issues 中搜索了相关的关键词
[ ] 不是 ant design vue 组件库的 Bug

描述 Bug
请清晰地描述此 Bug 的具体表现。
复现 Bug
请描述在演示页面中复现 Bug 的详细步骤，以确保我们可以理解并定位问题。部分 Bug 如果未在 Demo 中涉及，请务必提供关键代码
系统信息

操作系统:
Node 版本:
包管理器 (npm/yarn/pnpm) 及其版本:

{
field: 'orderNo',
label: '排序',
component: 'InputNumber',
defaultValue: 100,// 这里是数字
required: true,
}
src\components\Form\src\hooks\useFormEvents.ts
315行 isEmpty(currentFieldsValue[item.field])) 这里好像不对,大佬们看看什么问题

setFiledValue 本来就会将值修改了呀。你可以再描述的清楚一点

setFiledValue 本来就会将值修改了呀。你可以再描述的清楚一点

不好意思哈,这是复现条件：

formSchema 中 component: 'InputNumber'或'RadioButtonGroup',并设置了 defaultValue:123(number 类型)

这两个组件,只要 defaultValue 是 number 类型就会有问题
// menu.data.ts
{
  field: 'orderNo',
  label: '排序',
  component: 'InputNumber',
  defaultValue: 123,
}

// MenuDrawer.vue
const [registerDrawer, { setDrawerProps, closeDrawer }] = useDrawerInner(async (data) => {
  resetFields();
  setDrawerProps({ confirmLoading: false });
  isUpdate.value = !!data?.isUpdate;
  if (unref(isUpdate)) {
    // setFieldsValue({
    //   ...data.record,
    // }); // 点击编辑,这里数据设置不上

    setFieldsValue({
      orderNo: 1,
    }); // 失败 orderNo=1 => orderNo=123;先是设置1成功,然后又覆盖成了默认值123

    // setFieldsValue({
    //   orderNo: '2',
    // }); // 成功 orderNo='2'
  }
  const treeData = await getMenuList();
  updateSchema({
    field: 'parentMenu',
    componentProps: { treeData },
  });
});

版本是最新的,昨晚上克隆的

版本是最新的,昨晚上克隆的

是有这个问题，我遇到在弹框中，Select的defaultValue如果是number 类型 用setFieldsValue也设置不上值

authors: mxchhz qwecxzpoi zwtvip

repo: vbenjs/vue-vben-admin


text:
使用全屏功能时出现警告和报错，功能无法使用

⚠ 重要 ⚠ 在进一步操作之前，请检查下列选项。如果您忽视此模板或者没有提供关键信息，您的 Issue 将直接被关闭

[x] 已阅读 文档.
[x] 确保您的代码已是最新或者所报告的 Bug 在最新版本中可以重现. (部分 Bug 可能已经在最近的代码中修复)
[x] 已在 Issues 中搜索了相关的关键词
[ ] 不是 ant design vue 组件库的 Bug

描述 Bug
点击项目header头部处的[全屏]功能 和 路由[/feat/full-screen]全屏示例组件中的全屏功能时，没有反应，并出现警告和报错
请清晰地描述此 Bug 的具体表现。
复现 Bug
就在刚刚，拉取GitHub最新代码不做任何修改 ，仅执行 pnpm install 和 pnpm run dev 命令,打开本地地址后确认代码有bug

请描述在演示页面中复现 Bug 的详细步骤，以确保我们可以理解并定位问题。部分 Bug 如果未在 Demo 中涉及，请务必提供关键代码
系统信息

操作系统: macbook pro (13-inch, M1, 2020)
Node 版本: v16.20.2
包管理器 (npm/yarn/pnpm) 及其版本: pnpm/8.3.1

报错写着未授权

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

authors: anncwb bingoboya luocong2016


text:
What happend to the REPOSITORY?

pinging admin

@wangjue666
@jinmao88
@likui628

Hello, why can someone merge a pull request without your approvals? Pls fix the settings of merging the pull request

vben 5.0.0 马上发布了，目前仓库的管理有点乱，后面会好的。

https://doc.vben.pro/
https://www.vben.pro/


text:
update README for logging information

Adds some details about using ScopedValues with logging.

Hah, somehow I thought I hadn't made the PR #15 because it was merged when I went to look! Here I've added some info on logging, which clarifies something I hadn't understood at first (only within dynamic scope does one need to take special care w the logger).

Thanks!

authors: ericphanson vchuravy


text:
🛑 Criptodolar & Covid API is down

In a04810a, Criptodolar & Covid API (https://exchange.vcoud.com/) was down:

HTTP code: 502
Response time: 552 ms

Resolved: Criptodolar & Covid API is back up in dc677ed after 11 minutes.

repo: vcoud/upptime


text:
Handle npm errors.

Had a syntax error in a package.json. Took a few tries to realize I had the error with packages not downloading.  Would be nice if Gifi printed out that error when it happens instead of just exiting with no message.

Good suggestion, would you be interested in sending a pull request?

I'll leave this for someone else. Do you mind labeling as help wanted? :)

Sure, no worries ;)

authors: josephfusco vdemedes

repo: vdemedes/gifi


text:
OnTick

Hi, Vyacheslav!
Sorry for my dummy question,
but is there are available proxy for OnTick(Tick) function for MT4?
In the source I've found the updateQuote method, but I'm not sure is it the same.

Hi!
Yes, QuoteUpdate and QuoteUpdated events are the same as OnTick in MQL.

This is a perfect FAQ question. Did you consider creating one?

Yes, I think this is very good idea to create FAQ for the project. I will do it when I will have more free time.

authors: alexssource sn50 vdemydiuk

repo: vdemydiuk/mtapi


text:
Please disable push notifications while the desktop or web client is in active use.

To reproduce the issue:

Open the Windows client.
Install the Android client.  Leave notifications enabled.
Use the Windows client to chat.  The android app will continue to push notifications through every time a friend sends a message.

It should already work i.e the notifications should not be triggered if the room is opened in the web client and the user is moving his/her mouse.
If the room is not opened on the webclient, the android client will trigger notifications because no read receipt will ne sent.
Could you tell us if the notified room is opened on the webclient ?

No, it is not opened in the web client.  It is opened in the Windows desktop client.
Sorry, I thought that was clear by my description of step 1 ("Open the Windows client.").  I will edit the subject title now, to make it more specific.

i 'm afraid we have no way to detect if another client is opening a dedicated room.
You would have the same behaviour on any client (mobiles or not).
ie the notifications will be triggered  and dismissed asap the dedicated read receipts are received.

i've tested the behaviour with 3 other clients (android, IOS and a webclient)

This has nothing to do with dedicated rooms.
We are talking about a situation when the desktop client is opened in a room. We expect that in this case the Android/iOS clients would not be emitting notifications for every new message. Unfortunately, this is what happens. It's very annoying -- I've had several people consider disabling all Riot notifications on their phones, or even uninstall the app completely. Why chatting on your desktop, you really don't want your phone to keep buzzing.
The solution should not be about the desktop app sending read receipts before other apps -- I understand that's impossible. Instead, the desktop app should lock the room -- or possibly all rooms -- while it's being used.

I can confirm the behavior reported by @gibbousmoon100 on the desktop client running on macOS and the mobile client on iPhone.  I receive notifications on my phone regardless of whether the client is open on my desktop with a particular room active.
Moreover (and perhaps best reported elsewhere), I've turned notifications for "Messages in group chats" completely off in my settings and I receive a notification on my phone for every message posted in the room regardless of whether I'm mentioned.

This is mainly tracked at https://github.com/vector-im/riot-web/issues/469.  Agreed that it sucks, and we need to fix it.

Close in favor of vector-im/riot-web#469.

repo: vector-im/riot-android


text:
Display name empty after first login

To reproduce:

Login with riot
Open the lateral menu:

Display name is empty

Restart Riot

Display name is displayed

Not reproduced

authors: jeangb sabrinaj


text:
DT render not working properly

We have same render function in table with and without yadcf, but results are different.
yadcf somehow ignores render type === 'filter'
jsFiddle with yadcf : http://jsfiddle.net/5kfwysmL/1/
without : http://jsfiddle.net/90gc3o4a/

fixed by @misanek

authors: misanek vedmack

repo: vedmack/yadcf


text:
Date range filter values are not set when scroll X and Y are used

When using date_range filters, the value that set in the input is never found when scrollX and scrollY are involved. I say involved because regardless of boolean value assigned to the scroll setting, the date_range will break.
https://jsfiddle.net/sLz38694/2/
In the following fiddle, I have constructed an example that closely follows my scenario. As soon as any individual column search is filled in, the table will fire a call to the fake endpoint. Notice when you set a 'text' value, it is passed along the network, but as soon as a date_range is chosen by the user, it will not be send along.
If you remove the scrollX and scrollY part, you see the date values are being posted.

I took initiative to dive in the source code and I noticed that the input that is triggering the event, does not actually hold the value of the date picker. Instead there is one behind the table (which I assume is because of the scroll X and Y) and one in front.
See here
Input that is used to retrieve the value, but does not have it:

Input that actually holds the value:

I also noticed that in this issue you fixed something similar by introducing selectorePrefix. Could that be a solution for my above problem as well?

I failed to mention that when the table is serverSide = false, the search will work, but the table state and its localstorage will again have empty values for date columns.


text:
Something needs a fix

It would be awesome if you can fix that.

GitHub added new color variables. I fixed the ones that I could find in v1.2.1; let me know if you happen to find more unstyled/broken ones.

GitHub added new color variables. I fixed the ones that I could find in v1.2.1; let me know if you happen to find more unstyled/broken ones.

Working fine right now thanks vednoc, continue with the great work!

All perfect now. Thank you and keep going with your fine work ♥

authors: JotaPe MyCodeIsntWorking vednoc

repo: vednoc/dark-github


text:
Release v1.0

Added a link

not worked

done


text:
[QUESTION] - TITLE - FTPS - TLS session of data connection not resumed error while using FileZilla server

Is this bug solved by Suppaftp https://github.com/mattnenterprise/rust-ftp/issues/96 ? The library is not maintained so I thought to use Suppaftp
I wrote a simple program with suppaftp to connect to filezilla ftps server version 1.9.2 and list directory but I get below error
<Date/Time> Info [Type] Message
<02-11-2024 12:10:21> FTP Session 106 127.0.0.1 testuser [Error] TLS session of data connection not resumed error.

Following is the script I tried to run
use suppaftp::{NativeTlsFtpStream, NativeTlsConnector};
use suppaftp::native_tls::TlsConnector;

fn main() {
    // Connect to the FTP server in passive mode
    let ftp_stream = NativeTlsFtpStream::connect("127.0.0.1:21").unwrap();

    let tls_connector = TlsConnector::builder()
        .danger_accept_invalid_certs(true) // Only for testing; not recommended in production
        .build()
        .unwrap();

    // Convert the connector into the type expected by suppaftp
    let native_tls_connector = NativeTlsConnector::from(tls_connector);

    // Switch to secure mode using the connector with modified validation settings
    let mut ftp_stream = ftp_stream.into_secure(native_tls_connector, "127.0.0.1").unwrap();

    // Log in to the FTP server
    ftp_stream.login("testuser", "test$123456").unwrap();

    // List files in the current directory
    match ftp_stream.list(None) {
        Ok(files) => {
            for file in files {
                println!("{}", file);
            }
        }
        Err(e) => {
            eprintln!("Failed to list files: {}", e);
        }
    }

    // Quit the FTP session
    assert!(ftp_stream.quit().is_ok());
}

My cargo.toml looks like this
[package]
name = "ftp_client"
version = "0.1.0"
edition = "2021"

[dependencies]
suppaftp = { version = "^6", features = ["native-tls"] }
native-tls = "0.2.12"
openssl = { version = "0.10.68", features = ["vendored"] }

The login to the server happens fine. The error occurs when you call commands like to list directory or any other file actions.
Before raising a bug , I wanted ask a question, if this is solved or not yet.
Note: The server is working fine because the same when I tried with node js code am able to do the directory listing, so it looks like to me the library lacks support for this feature. Can you confirm or am I doing something wrong? Thanks

I'm not sure if this is related to fervand1's issue or not, but I am also having issues with FileZilla.
When retrieving files, sometimes errors such as: Invalid response: [226] 226 Operation successful and Connection error: No connection could be made because the target machine actively refused it. (os error 10061) are returned.
This seems to happen when FileZilla responds with 150 About to start data transfer.
I think suppaftp is supposed to chill out on this response.
However, immediately afterward suppaftp sends PASV which seemingly messes things up?
FileZilla complains about this and says A command is already being processed. Queuing the new one until the current one is finished.
And that's when the Connection error: No connection could be made error is returned

@leontoeides I spent few days on this trying to understand why it is happening. And seems like the issue is with session resumption support. Am not an expert on this topic but here is what I found and hopefully might help you as well
Suppaftp supports FTP via TLS through native-tls and rustls. After researching a bit I found out that the native-tls crate doesn't have support for session resumption and hence we are seeing the behaviour where upon successful login it disconnects when we try to list or do any other file/dir related actions.
Rustls on the other hand has the support for this function which filezilla server is applying by default refer https://docs.rs/rustls/latest/rustls/client/struct.ClientConfig.html#structfield.resumption . Following is the script that worked for me. FYI ignore the implementatation of bypass with NoVerifier (I had a self signed local cert generated via filezilla but for some reason it was complaining stating the certificate is invalid when I passed it to my config object, I will check on that later).
use std::sync::Arc;
use suppaftp::{RustlsFtpStream, RustlsConnector};
use suppaftp::rustls::{ClientConfig};
use rustls::client::danger::{HandshakeSignatureValid, ServerCertVerified, ServerCertVerifier};

#[derive(Debug)]
struct NoVerifier;

fn main(){
    let config = ClientConfig::builder()
        .dangerous()
        .with_custom_certificate_verifier(Arc::new(NoVerifier))
        .with_no_client_auth();

    // Create a connection to an FTP server and authenticate to it.
    let rc_config = Arc::new(config);

    let mut ftp_stream = RustlsFtpStream::connect("127.0.0.1:21")
        .unwrap()
        .into_secure(RustlsConnector::from(rc_config), "127.0.0.1")
        .unwrap();

    ftp_stream.login("testuser", "test$123456")
        .expect("Failed to log in to FTP server");

    println!("Successfully connected and logged in!");

    match ftp_stream.pwd() {
        Ok(current_dir) => println!("Current directory: {}", current_dir),
        Err(e) => eprintln!("Error retrieving current directory: {}", e),
    }

    match ftp_stream.list(Some("/")) {
        Ok(dir_list) => {
            println!("Directory listing:");
            for entry in dir_list {
                println!("{}", entry); // Print each entry
            }
        }
        Err(e) => eprintln!("Error listing directory: {}", e), // Handle any errors
    }

    // Terminate the connection to the server.
    let _ = ftp_stream.quit();
}

/// DANGER: This custom implementation of the SeverCertVerifier
/// is really dangerous and return success for all and everything.
impl ServerCertVerifier for NoVerifier {
    fn verify_server_cert(
        &self,
        _end_entity: &rustls::pki_types::CertificateDer<'_>,
        _intermediates: &[rustls::pki_types::CertificateDer<'_>],
        _server_name: &rustls::pki_types::ServerName<'_>,
        _ocsp_response: &[u8],
        _now: rustls::pki_types::UnixTime,
    ) -> Result<rustls::client::danger::ServerCertVerified, rustls::Error> {
        Ok(ServerCertVerified::assertion())
    }
    fn verify_tls12_signature(
        &self,
        _message: &[u8],
        _cert: &rustls::pki_types::CertificateDer<'_>,
        _dss: &rustls::DigitallySignedStruct,
    ) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error> {
        Ok(HandshakeSignatureValid::assertion())
    }

    fn verify_tls13_signature(
        &self,
        _message: &[u8],
        _cert: &rustls::pki_types::CertificateDer<'_>,
        _dss: &rustls::DigitallySignedStruct,
    ) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error> {
        Ok(HandshakeSignatureValid::assertion())
    }

    fn supported_verify_schemes(&self) -> Vec<rustls::SignatureScheme> {
        vec![
            rustls::SignatureScheme::RSA_PKCS1_SHA1,
            rustls::SignatureScheme::ECDSA_SHA1_Legacy,
            rustls::SignatureScheme::RSA_PKCS1_SHA256,
            rustls::SignatureScheme::ECDSA_NISTP256_SHA256,
            rustls::SignatureScheme::RSA_PKCS1_SHA384,
            rustls::SignatureScheme::ECDSA_NISTP384_SHA384,
            rustls::SignatureScheme::RSA_PKCS1_SHA512,
            rustls::SignatureScheme::ECDSA_NISTP521_SHA512,
            rustls::SignatureScheme::RSA_PSS_SHA256,
            rustls::SignatureScheme::RSA_PSS_SHA384,
            rustls::SignatureScheme::RSA_PSS_SHA512,
            rustls::SignatureScheme::ED25519,
            rustls::SignatureScheme::ED448,
        ]
    }
}

In cargo.toml, enable the rustls feature
suppaftp = { version = "^6", features = ["rustls"] }

See if this helps. Thanks

repo: veeso/suppaftp


text:
Setting 100% width on the Vega container by default?

Thanks for this great dash extension @binste ! It's saving me from so many iframe headaches =)
I wonder if it would make sense to set style={'width': '100%'} by default on the Vega component, so that there is only one step required to make the altair chart stretch the width of the container. Or is there any advantage of not having this by default?
One step further would be to provide a "dash-style" altair theme that sets width='container' for all charts when activated.

Thanks for the feedback @joelostblom !
Yeah I was just never sure how to do this properly so that users can still set it themselves and that it does not interfere with other style properties. I know found a way in #12. Just released it as version 0.10.0. Probably not the most elegant solution but I tested it in a few different cases and seems to work well. Let me know if you face any issues!

Thank you @binste !

authors: binste joelostblom

repo: vega/dash-vega-components


text:
Move addDecimal and other ts only helpers to thier own lib

Currently addDecimal is duplicated in the smart-contracts lib. This i because react-helpers exports JSX and we don't want a TS only lib being depenent on react. We should move out helpers that are to be used across libraries that are not ts dependent

Please can you check if this is already covered in your PR?

@gordsport It was covered off but a similar task is still required after token app migration. I've updated the ticket title and description appropriately

authors: dexturr gordsport mattrussell36

repo: vegaprotocol/frontend-monorepo


text:
fix(trading): show cap fee multiplier on recurring gov transfers and game cards

Related issues 🔗
Closes #6511
Description ℹ
Show cap fee multiplier on recurring gov transfers and game cards.
Technical 👨🔧
Update queries.

looks good

authors: MadalinaRaicu daro-maj


text:
chore: correct AC code number 0027-ASSP-020

@vega-paul
The AC code 0027-ASSP-020 is reference in ./system-tests/tests/assets/erc20_asset_test.py
However in this spec its marked as COSMICELEVATOR.

Should the reference in the test be removed to avoid possible false coverage once this AC is made current?
Should this AC be made current as it is indeed testable and has been covered?

cc @davidsiska-vega for info

This AC be made current as it is indeed testable and has been covered

Our system test for this AC is not covering the defined scenario. I can adjust easily to match and can do that now on a new PR.

Spec reflects new AC and existing AC covered so we are good.

authors: gordsport vega-paul

repo: vegaprotocol/specs


text:
Error while running %AddDeps to add vegas to apache toree scala kernel

I'm just starting with your project. I'm getting error while adding vegas as a dependency in apache-toree scala kernel.

Spark-version -- 2.2.0 (scala -version 2.11.8)
apache-toree -- 0.2.0-dev1
vegas-version -- 0.3.11

error message
 error: error while loading package, class file '/home/pauli/wspace/SoftLib/spark-2.2.0/jars/scala-library-2.11.8.jar(scala/reflect/package.class)' is broken
(class java.lang.RuntimeException/Scala class file does not contain Scala annotation)
error: error while loading package, class file '/home/pauli/wspace/SoftLib/spark-2.2.0/jars/scala-library-2.11.8.jar(scala/package.class)' is broken
(class java.lang.RuntimeException/Scala class file does not contain Scala annotation)
error: error while loading Serializable, class file '/home/pauli/wspace/SoftLib/spark-2.2.0/jars/scala-library-2.11.8.jar(scala/Serializable.class)' is broken
(class java.lang.RuntimeException/Scala class file does not contain Scala annotation)
res4: Either[org.apache.toree.magic.CellMagicOutput,org.apache.toree.magic.LineMagicOutput] = Right(())
error: error while loading Predef, class file '/home/pauli/wspace/SoftLib/spark-2.2.0/jars/scala-library-2.11.8.jar(scala/Predef.class)' is broken
(class java.lang.RuntimeException/Scala class file does not contain Scala annotation)

MeanWhile, nice project. I have been planning to shift to scala for spark, but was stuck with pyspark in absence of nice visualization library for scala.

Solved it. It was due to conflict between scala-reflect-2.11.6 and scala-reflect-2.11.8. I had to manually install vegas-viz and its dependencies to local maven repo. Then added vegas-viz as sparks.jars.pacakages in configuration file instead of loading it on the run.

repo: vegas-viz/Vegas


text:
Velocity on 5' scRNAseq

Has velocyto been texted on the 10X 5' scRNAseq?

I was able to get some 5' scRNAseq made with 10xgenomics and run the velocity on them.

Hi hawiiki, I tested velocyto on my 10x 5' data, but I got very few counts from the loom file comparing to the original 10x matrix.  (please see  issue#78).
May I know do you have the same problem?

authors: LikaiTan hawaiiki


text:
Vendr uSync Umbraco V10 support?

Tried to use it on V10 but it didn't work.
I'll try to spend some time to see what's wrong and where but thought it'd be good to keep it as an issue here too :)

Hi @busrasengul There is a new 3.0.0 RC on our unstable feed at https://nuget.outfield.digital/unstable/vendr/v3/index.json if you want to give this a try?

authors: busrasengul mattbrailsford

repo: vendrhub/vendr-usync


text:
AggregateUtil 新增更多的test

AggregateUtil 新增更多的test

com.feilong.core.util.AggregateUtil.sum(Collection, String)
也需要更多的测试

repo: venusdrogon/feilong-core


text:
Originals folders doesn't get created on upload

I noticed that the originals folder is not created at the time an image is uploaded, even though I have the Non-destructive setting enabled. I only see it being creating when bulk-resizing images... but that's of course too late since the original file is gone at that point.

From what I understand, it is caused by the $path variable in the resize function that matches the runtime temp folder when the image is uploaded, while it matches the assets source folder when the bulk-resizing task is running.

repo: verbb/image-resizer


text:
Add availableForSale to variant

Add to cart button should be disabled when there's no stock for each variant.
          <Button
            aria-label="Add to Cart"
            type="button"
            className={s.button}
            onClick={addToCart}
            loading={loading}
            disabled={variant?.availableForSale === false}
          >
            {variant?.availableForSale === false
              ? 'Not Available'
              : 'Add To Cart'}
          </Button>

We appreciate the time you took to make this PR. We have decided to take Next.js Commerce in a new direction, but I am happy to say that this feature will be present in the upcoming release. Please see this PR for more details: #966

authors: manovotny powerwlsl

repo: vercel/commerce