text:
How is it ensured that user doesn't manipulate user id?

I've hosted botchat.js in my website and i'm initializing bot with user id like shown below
`
var  user = { id: 'userid', name: 'name'};
BotChat.App({
   bot: bot,
   botConnection: botConnection,
   user: user
}, document.getElementById('BotChatElement'));
`
Since this happens on client browser, how is it ensured that user doesn't manipulate the script in browser console, or host this code in his own site, use token captured on this page and pass different user id?
Not sure if this is an issue, maybe I'm missing something.

I agree with the concern above and would like to know what everyone's opinion is on this. Is the intention of that user identity to be for use when making requests downstream (as a trusted user), or is this just something nice to the bot can display some information about the user early on?

In Web Chat user is indeed used just for visually attributing a message.
The Bot Framework uses user.id is used by is as a key for accessing user-specific data in a conversation. In other words, if you have users A, B, and C  in a single conversation with a pizzabot, and ask everyone to say what they want on their pizza, you can store each of their preferences separately.
Unlike full-fledged messaging systems, e.g. Skype or Facebook Messenger, Direct Line doesn't have an identity system. When you deploy Web Chat yourself (as opposed to using the Web Chat channel) you create and manage your own user identities. If you want a more secure notion of user identity, do something more secure like passing security tokens via the backchannel.

@kushalbhabra it is more like HTTP cookie. If the user have access to JS, they could modify the cookie.
I will do something like this (essentially, the same thing as you would handle user ID on a HTTP cookie):

Browser ask server to generate a new user ID
Server generate a new ID payload with SHA signature (to prevent modification)

On the server side, every time it read the user ID, it verify the SHA signature to make sure the user ID is not forged.

authors: billba compulim kushalbhabra ukphillips

repo: Microsoft/BotFramework-WebChat


text:
Update Microsft.Net.Compilers(Roslyn) to 3.0.0 to enable C#/CSharp 8 …

…features

Waiting for a new LKG to be published from PR #198

Trying to close and reopen to see if GitHub is smart enough it needs to merge with master and re-kick off all the builds.

source: gharchive/pull-request

repo: Microsoft/BuildXL

license: MIT

license_type: permissive

license_source: github-api


text:
PBREffect

With almost all engines supporting this, would be nice to have PBR effect support.

Pharr, Jakob, and Humphreys, ,Physically Based Rendering: From Theory to Implementation, Morgan Kaufmann, website code

source: gharchive/issue

authors: amerkoleci walbourn

repo: Microsoft/DirectXTK


text:
merge Microsoft/GalaxyExplorer/phone with timGerken/GalaxyExplorer/ph…

…one  (#5)

Added content : Galactic Center (#41)
Converting GalaxyExplorer from a D3D app to a XAML based app (#46)
Default to Landscape Orientation (#47)
Native BackButton Handling for Desktop and Mobile (#48)

wrong way.

repo: Microsoft/GalaxyExplorer


text:
How to Undo an effect?

How do I undo an applied effect? I could not find an example in the source code.

There is no concept of "undo", the rendering chain produces an output given an input and the effects in the rendering chain and their parameters. To get a different output simply change the rendering chain and then call RenderAsync() on your renderer again.

Thanks! Based on your suggestion, I just feed the original image source as IImageProvider and call RenderAsync() again. Something like
    public async Task RenderOriginal(IImageProvider sourceImage)
    {

        if (m_swapChainPanelRenderer == null)
        {
            m_swapChainPanelRenderer = new SwapChainPanelRenderer(sourceImage, SwapChainPanel);
        }
        m_swapChainPanelRenderer.RenderOptions = Lumia.Imaging.RenderOptions.Mixed;
        m_swapChainPanelRenderer.Source = sourceImage;

        await m_swapChainPanelRenderer.RenderAsync().AsTask().ConfigureAwait(false);
    }

Exactly.

authors: Monsok davidbozjak

repo: Microsoft/Lumia-imaging-sdk

license: mit

license_source: bigquery


text:
LyncConnector Export script bug

Hi, I found a script bug in Lync Connector Export script.
Error during export was:

It turns out there's an extra single quotation mark on line 465 in the export script that gives the error (highlighted):

Thanks Henrik. I've checked in the fixed script. I'll close this issue now.

authors: Identitry NileshGhodekar

repo: Microsoft/MIMPowerShellConnectors


text:
Automatically handle controller model pose synchronization on model assignment

Does this affect the legacy HoloToolkit (master) or the Mixed Reality Toolkit (mrtk_release)?
Mixed Reality Toolkit
Is your feature request related to a problem? Please describe.
When a user specifies a controller model, if they do not explicitly add a controller pose synchronizer, the controllers will not automatically sync to the controllers.
Describe the solution you'd like
We should check the prefab/GameObject we're adding to the controller model object field and make sure we have a controller pose synchronizer, and if not warn the user and add it if they accept.

Fixed by #https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2667

repo: Microsoft/MixedRealityToolkit-Unity


text:
Better handle time module

# https://docs.python.org/3/library/time.html#module-time
import time

time.gmtime
time.asctime().split
time.clock().is_integer

time.struct_time.tm_year
time.strptime("30 Nov 00", "%d %b %y").tm_year # Fails: doesn't infer `tm_year`.
time.gmtime().tm_year  # Fails: doesn't infer `tm_year`.

time.CLOCK_MONOTONIC  # Fails: doesn't infer `CLOCK_MONOTONIC`.

Need to recognize and return named tuple based on the return type in doc
"gmtime([seconds]) -> (tm_year, tm_mon, tm_mday, tm_hour, tm_min,\n                       tm_sec, tm_wday, tm_yday, tm_isdst)

Works with typeshed

repo: Microsoft/PTVS


text:
Rename folder/file failed (see #1575)

#1575  happens again in 15.7.3

@mseise123 I'm not sure how to reproduce this. Can you provide steps?

Exactly as in #1575 - just try to rename a (python) file or folder in the project explorer.  The file on the harddrive is correctly renamed, but (Probably) not in the pyproject file - the name in the explorer view is not renamed.
The error is (something like) "Member not found" HRESULT:0x80020003, DISP_EMEMBERNOTFOUND"
Adding the renamed file is only possible after reloading the project.

This is fixed in 15.7.4


text:
stan: Error in system(cmd, intern = !verbose) : 'C:/Program' not found

from user:
setwd("e:/hmad")

emad_dat <- list(mad = 50)

library(rstan)
fit <- stan(file = 'e:/hmad/EMAD1.stan', data = emad_dat,
            iter = 10000, chains = 4)

I get the error:

Error in system(cmd, intern = !verbose) : 'C:/Program' not found

We don't use system anywhere, so it looks like a Stan bug - probably due to installation path having spaces? I'd ask to see if this repros with Rgui.

he said it works in RS.

What's actually failing here is inline::cxxfunction. Easier repro:
fx <- cxxfunction(signature(x = "integer", y = "numeric"), 'return ScalarReal( INTEGER(x)[0] * REAL(y)[0] )')

The root cause is that this code assumes that R.home() never has spaces in it, and so doesn't quote it. It works in Rgui and RS, because they use short path. In Rgui/RS:
> R.home()
[1] "C:/PROGRA~1/R/R-32~1.3"

In RTVS:
> R.home()
[1] "C:/Program Files/R/R-3.2.3"

repo: Microsoft/RTVS


text:
[StyleCop] Make Build process fail on Stylecop issues

Disclaimer: this PR will fail until we fix all StyleCop's errors.

Changed ruleset to force an error instead of a warning.
Fixed ruleset reference in Definitions.csproj
Added rule CS8019 regarding unnecessary using directives.

@JuanAr I've just noticed that the build in AppVeyor is no longer keeping the complete build log. I've tried download the log from some of the latest builds and they are always truncated.
Not sure if this is actually recent or not, but last time I looked into this, the full log was there.
Did the build output become much longer than previously?

I've also noticed that the output of a build in Visual Studio seems out of order. At least in my local dev env it seems all projects are built first, them the resources are generated from the YAML files.

@tellarin I've checked a few latest builds and could download the logs. SA warnings increased the log length when we enabled Style and might have created a transient problem with logs. This should no longer be an issue since SA warnings decreased significantly.
In this specific PR, we are turning SA warnings into errors and since there are still some SA warnings, the build process will stop after building .NET. We might want to store the issues, continue building other languages, and finally fail with the stored issues info. This will be easier with PowerShell.
Regarding the order of YAML processing. I've just checked and it seems to be working as expected for the root's build.cmd (builds all platforms.) However, I wonder if this is specific of .NET which uses a Post-Build script on Microsoft.Recognizers.Definitions.Common.csproj. I'll take a look at that unless you experienced it in another platform.

@Aliandi, can you resolve this last conflict? I can merge after that.
Thanks!

@tellarin Conflicts solved!

authors: Aliandi JuanAr ceciliaavila tellarin

repo: Microsoft/Recognizers-Text


text:
Minor mods to create update

Minor formatting, edit around local source publishing, edit prerequisites to include other updates in addition to detectoids.

@davstewmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

authors: davstewmsft msftclas

repo: Microsoft/SCCMdocs


text:
JSDoc @arg and @argument tags not recognized as synonyms for @param

TypeScript Version:  2.3
Recognize @arg and @argument as synonyms for the @param tag.
I don't know if this was by design or not, but @returns is recognized as a synonym for @return so I expected synonyms to work.
Code
// @ts-check

/**
 * @arg {string} input
 * @returns {string}
 */
export function foo(input) {
    return input.toLowerCase();
}

Expected behavior:
input is of type "string".
Actual behavior:
input is of type "any".

For what it's worth, it looks like it is an easily correctable omission (including the code for the return/returns synonym for reference).
case "param":
    tag = parseParamTag(atToken, tagName);
    break;
case "return":
case "returns":
    tag = parseReturnTag(atToken, tagName);
    break;

https://github.com/Microsoft/TypeScript/blob/a1a2006074a01ca0b75b08294377cc52302e3e71/src/compiler/parser.ts#L6505-L6511

@joechung-msft a PR would be appreciated.

authors: joechung-msft mhegazy

repo: Microsoft/TypeScript


text:
Compiler API: How to get the "type" of an interface?

TypeScript Version:  2.3.2
Code
Given an interface like this:
/**
 * The props which can be passed to `<Foo/>`.
 */
export interface FooProps {
  /**
   * Use a date formatted as RFC 3339/ISO 8601 (e.g. `'2017-02-22T10:36:24Z'`).
   */
  date: string;
}

I'd like to get the documentation of the interface. Currently I do something like this:
const exports = checker.getExportsOfModule(checker.getSymbolAtLocation(sourceFile));
const docs: Array<DocumentedExport> = exports.map(exportedSymbol => {
    const symbol = getOriginalSymbol(exportedSymbol, checker);  // returns exportedSymbol or the aliased symbol if it is a re-export
    const documentation = displayPartsToString(symbol.getDocumentationComment());

    const declaration = symbol.declarations![0];
    const sourceFile = declaration.getSourceFile();
    const { fileName } = sourceFile;
    const { line, character } = sourceFile.getLineAndCharacterOfPosition(declaration.getStart());
    const type = checker.typeToString(checker.getTypeOfSymbolAtLocation(symbol, declaration));

    if (declaration.kind === SyntaxKind.InterfaceDeclaration) {
      console.log('Found FooProps!');
    }

    return {
      name: symbol.getName(),
      kind: declaration.kind,
      fileName,
      line,
      character,
      documentation,
      type  // this is `'any'`
    }
  });

My type is 'any'. Shouldn't it be something like { date: string; }? And how would I get the documentation for date (the Use a date formatted as...' line).`?
Thank you :)

Is this the correct way? :)
const exports = checker.getExportsOfModule(checker.getSymbolAtLocation(sourceFile));
const docs: Array<DocumentedExport> = exports.map(exportedSymbol => {
  const symbol = getOriginalSymbol(exportedSymbol, checker);  // returns exportedSymbol or the aliased symbol if it is a re-export
  const documentation = displayPartsToString(symbol.getDocumentationComment());

  const declaration = symbol.declarations![0];
  const sourceFile = declaration.getSourceFile();
  const { fileName } = sourceFile;
  const { line, character } = sourceFile.getLineAndCharacterOfPosition(declaration.getStart());
  let type = checker.typeToString(checker.getTypeOfSymbolAtLocation(symbol, declaration));

  if (declaration.kind === SyntaxKind.InterfaceDeclaration) {
    type = checker.typeToString(checker.getTypeAtLocation(declaration));
  }

  return {
    name: symbol.getName(),
    kind: declaration.kind,
    fileName,
    line,
    character,
    documentation,
    type  // this is `'FooProps'` now \o/
  }
});

Can someone explain me when getTypeOfSymbolAtLocation and when getTypeAtLocation should be closed?

There are two functions, getDeclaredTypeOfSymbol and getTypeOfSymbol. The former is for getting the types of types, the latter is for getting the types of values. So getTypeOfSymbol(/*the FooProps symbol*/) tries to get the type of the value identifier (variable) named FooProps. getDeclaredTypeOfSymbol will do the right thing here.
I cannot coherently explain the naming convention.

Cool, thank you again. ❤

There are two functions, getDeclaredTypeOfSymbol and getTypeOfSymbol.

There is a getTypeOfSymbol function in the checker.ts, but it is not public. Should it be public? Or is getTypeOfSymbolAtLocation (which is public) basically for similar use cases like getTypeOfSymbol?
(getDeclaredTypeOfSymbol is on the public interface TypeChecker.)

The former is for getting the types of types

Types of types are... interface and type? So basically TypeScript keywords/primitives which aren't included in your compiled JS code?

Not sure on the first question.
For the second, there are also classes and imports to consider. The identifier for a class resolves to both a value (which is the constructor function) and a type (the instance type); similarly an imported identifier may have both type and value meanings (or possibly neither, if it's a namespace).

authors: RyanCavanaugh donaldpipowitch


text:
Class.name of a derived class reported incorrectly in IE 11

I can't categorically say that this is specifically a typescript issue, but it is an issue involving typescript that is affecting me.
We are presently upgrading from Typescript 1.7.2 to 2.3. Our development environment is Microsoft Visual Studio 2015 (which probably has no relevance to this question).
Two simple classes:
class Foo {
   me: string;

   constructor() {
      this.me = "I am Foo";
   }
}

class Bar extends Foo {
   constructor() {
      super();
      this.me = "I am Bar";
   }
}

var fooName = Foo.name;
var barName = Bar.name;
console.log( "fooName is " + fooName + ", barName is " + barName );

In TS 1.7, on IE11:
fooName = Foo, barName = Bar
In TS 2.3 on IE11:
fooName = Foo, barName = Foo
The output from Chrome is correct.
Have been digging around. Have found out that IE does not support Function.name property and that it is shimmed. We use core-js. We were running 1.2.6 to produce the above output. Upgraded to 2.4.1 and it produced the same output. Using requires as our loader if it makes any difference.
So, my dilemma is that I am not really sure who is "responsible" for this problem -- it used to work fine in TS 1.7 and now it doesn't.

Looks related to the changes in class emit in TS 2.1.
Looks like core-js just puts the name pollyfill on the function prototype. with TS 2.1 the class now inherits from the base constructor, and not directly from the function object, so you get the base name and not the Function.prototype.name.
The change was made in accordance with the ES6 spec; so i would say this should a core-js issue.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


text:
Should prepended project references be recursive?

After restructuring the src folder for project references, we followed the simple rule that we wouldn't generated concatenated outputs for "non-terminal" (e.g. library only / non-entry-point) projects. Concatenation only occurs for "endpoint" projects - tsc, tsserver, etc; i.e. those that produce a runnable program where it would make no sense to tack on additional code after these critical top-level statements. This is good for build speed because changing a variable name in checker only requires rewriting of its own output file plus the output files of  the endpoint projects (tsc, tsserver, etc).
The downside is that the endpoint tsconfig files look really goofy because they have to explicitly list out all their dependencies. It's also a maintainability problem because the ordering of those dependencies matters and doesn't get enforced by any mechanism.
The proposal was that "prending should be recursive". This is intuitive. Let's consider some examples
Legend
⇗ ⇑ ⇖ prepending reference
↗ ↑ ↖  non-prepending reference

First up, a straightforward project:
C
↑
B
⇑
A

The current behavior is that A emits a file containing B A.
It seems like we want the file C B A! To get C B A, the A config file now instead has to explicitly list A as a dependency, and has to list it above B to guarantee that the program will work.
Dependencies imply thinking about a diamond graph, of course:
   D
 ↗  ↖
B    C
 ⇖ ⇗
  A

The desired output is D B C A and we can easily construct that ordering.
What about this case?
   D
 ⇗  ⇖
B    C
 ⇖ ⇗
  A

B produces D B and C produces D C, so there's no way for A to produce anything other than D B D C A, which is not likely to load correctly due to the duplication of D.
We generally believe this to be an error - the graph is "fixed" by making new targets B2 and C2:
     ⇗ D ⇖
   ⇗ ↗  ↖ ⇖
 ⇗  B    C  ⇖
B2⇗  ⇖ ⇗  ⇖C2
      A

What about this graph?
  Q
↗  ↖
X   Y
⇑   ⇑
B   C

According to the "prepend should be recursive" principle, the outputs of B and C are "supposed" to be Q X B and Q Y C...
but consider dependencies of B and C:
  Q
↗  ↖
X   Y
⇑   ⇑
B   C
⇖ ⇗
 A

Now A has no valid output... but B and C aren't taking prepending references on Q on purpose.
The "fixed" version of the graph leaves us back where we started, because the new project B2 would have to explictly list Q, X, and B as its prepended inputs.

@mhegazy @ahejlsberg I'm leaning toward keeping references the way they are. Given that both options lead to situations where you have to re-list dependencies, being able to look at a config file and know exactly what its output will be seems like a better option?

Your statement after the first example; "the A config file now instead has to explicitly list A as a dependency" meant to finish with list C as a dependency, right?
Also, I don't think the B2/C2 graph fixes that issue, as building A still doesn't include D. (A would probably want to reference B2/C. Or just leave B as a prepending reference).
In general though, I agree. The current solution, while not ideal, seems to have less foot-guns. Though of course having to repeat configuration is multiple places is a foot-gun of its own. In practice, would these diamond patterns likely occur? Or would they be rare enough we could live with the danger level, and most dependencies would be a straight-line superset (e.g. tsc contains most of the compiler source, then typescriptServices references tsc and a few additional files, then tsserver references typescriptServices and a few additional files, etc...)

authors: RyanCavanaugh billti


text:
41GB tsserver.log file filled with "Cannot read property 'close' of undefined"

I wanted to share with you something interesting that happened today. Whether this can really be considered a bug, I'll leave up to you, but here goes.
So I was wondering how my C drive suddenly got so full today out of nowhere, ran a scan and found this:

It starts with this:

Info 5602 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/isSymbol.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5603 [10:50:10.787] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/isSymbol.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5604 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISTYPE~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5605 [10:50:10.787] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISTYPE~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5606 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISUNDE~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5607 [10:50:10.787] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISUNDE~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5608 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISWEAK~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5609 [10:50:10.787] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISWEAK~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5610 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISWEAK~2.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5611 [10:50:10.787] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/ISWEAK~2.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5612 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/iteratee.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5613 [10:50:10.787] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/iteratee.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5614 [10:50:10.787] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/join.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5615 [10:50:10.788] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/join.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5616 [10:50:10.788] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/juxt.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5617 [10:50:10.788] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/juxt.js :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5618 [10:50:10.788] DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/KEBABC~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5619 [10:50:10.788] Elapsed:: 0ms DirectoryWatcher:: Triggered with d:/projects/cherow/bench/node_modules/lodash/fp/KEBABC~1.JS :: WatchInfo: d:/projects/cherow/bench/node_modules 1 Project:  WatchType: node_modules for closed script infos in them
Info 5620 [10:50:10.789] Starting updateGraphWorker: Project: d:/Projects/cherow/bench/tsconfig.json
Info 5621 [10:50:10.798] Finishing updateGraphWorker: Project: d:/Projects/cherow/bench/tsconfig.json Version: 122 structureChanged: false Elapsed: 9ms
Info 5622 [10:50:10.798] Structure before ensureProjectForOpenFiles:
Info 5623 [10:50:10.798] Project 'd:/Projects/cherow/bench/tsconfig.json' (Configured) 0
Info 5623 [10:50:10.798] 	Files (81)
Info 5623 [10:50:10.798] -----------------------------------------------
Info 5623 [10:50:10.798] Project '/dev/null/inferredProject1*' (Inferred) 1
Info 5623 [10:50:10.798] 	Files (278)
Info 5623 [10:50:10.798] -----------------------------------------------
Info 5623 [10:50:10.798] Open files:
Info 5623 [10:50:10.798] 	FileName: d:/Projects/cherow/bench/bench.ts ProjectRootPath: d:/Projects/cherow
Info 5623 [10:50:10.798] 	FileName: d:/Projects/cherow/bench/src/cherow/index.ts ProjectRootPath: d:/Projects/cherow
Info 5623 [10:50:10.798] 	FileName: d:/Projects/cherow/bench/src/cherow/latest.ts ProjectRootPath: d:/Projects/cherow
Info 5623 [10:50:10.798] 	FileName: d:/Projects/cherow/bench/src/cherow/local.ts ProjectRootPath: d:/Projects/cherow
Info 5623 [10:50:10.798] 	FileName: d:/Projects/cherow/bench/src/parse.ts ProjectRootPath: d:/Projects/cherow
Info 5623 [10:50:10.798] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 5624 [10:50:13.362] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 14 structureChanged: true Elapsed: 2564ms
Info 5625 [10:50:13.364] Structure after ensureProjectForOpenFiles:
Info 5626 [10:50:13.364] Project 'd:/Projects/cherow/bench/tsconfig.json' (Configured) 0
Info 5626 [10:50:13.365] 	Files (81)
Info 5626 [10:50:13.365] -----------------------------------------------
Info 5626 [10:50:13.365] Project '/dev/null/inferredProject1*' (Inferred) 1
Info 5626 [10:50:13.365] 	Files (248)
Info 5626 [10:50:13.365] -----------------------------------------------
Info 5626 [10:50:13.365] Open files:
Info 5626 [10:50:13.365] 	FileName: d:/Projects/cherow/bench/bench.ts ProjectRootPath: d:/Projects/cherow
Info 5626 [10:50:13.365] 	FileName: d:/Projects/cherow/bench/src/cherow/index.ts ProjectRootPath: d:/Projects/cherow
Info 5626 [10:50:13.365] 	FileName: d:/Projects/cherow/bench/src/cherow/latest.ts ProjectRootPath: d:/Projects/cherow
Info 5626 [10:50:13.365] 	FileName: d:/Projects/cherow/bench/src/cherow/local.ts ProjectRootPath: d:/Projects/cherow
Info 5626 [10:50:13.365] 	FileName: d:/Projects/cherow/bench/src/parse.ts ProjectRootPath: d:/Projects/cherow
Info 5626 [10:50:13.365] got projects updated in background, updating diagnostics for d:/Projects/cherow/bench/bench.ts,d:/Projects/cherow/bench/src/cherow/index.ts,d:/Projects/cherow/bench/src/cherow/latest.ts,d:/Projects/cherow/bench/src/cherow/local.ts,d:/Projects/cherow/bench/src/parse.ts
Err 5627  [10:50:13.367] Exception on executing command unknown:
Cannot read property 'close' of undefined

TypeError: Cannot read property 'close' of undefined
    at FSEvent.FSWatcher._handle.onchange (fs.js:1385:22)

And then proceeds to log this error another 180 million times in the 3 hours that follow:
Err 5628  [10:50:13.368] Exception on executing command unknown:

    Cannot read property 'close' of undefined

    TypeError: Cannot read property 'close' of undefined
        at FSEvent.FSWatcher._handle.onchange (fs.js:1385:22)

Indeed, that's 16.699 errors (100.196 lines of text ~4MB) logged per second, without interruption, for 3 hours straight until Windows warned me that my SSD drive started getting full.
The reason these numbers are so large, I soon realized, is most likely because I forgot to add node_modules under a new subfolder to .gitignore (and/or to some other ignore settings). I can't actually reproduce this now.
Now this is largely a problem between chair and keyboard, but shouldn't there be some kind of limit on how much log can be produced? I'm not entirely sure what one can be expected to expect in this situation. It's no big deal, but I just wanted to inform you guys that this sort of thing can apparently happen if node_modules somehow ends up getting analyzed by TypeScript 😆

This sounds similar to  as when trying out repro  for #29856 as mentioned in https://github.com/Microsoft/vscode/issues/68576#issuecomment-463865605, I was able to repro this issue.

Closing this as this is duplicate of #29407 which is result of gulp build deleting the folder we are watching and we not getting notified or node going in bad state.

@sheetalkamat Thanks for clarifying. That makes sense. I think in my case then it was because I used git clean -xfd to clean the working folder state. I do that quite often. I might have still had a mocha watch task running in some console with ts-node
Is there any way to limit the amount of log that can be produced though?

authors: fkleuver sheetalkamat


text:
Expose --init functionality in a tsserver command

We now have --init support to generating a default tsconfig.json file (see #4037). Editors would need to expose a functionality that uses this, possibly passing a set of additional defaults based on their scenario. we need to expose this as a Language Service API as well as a tsserver command. see @jrieken's comment in https://github.com/Microsoft/TypeScript/pull/4037#issuecomment-135056980

//CC: @tinganho


text:
Importing amd i18n plugin file

To Import the amd plugin i18n file,
1)I defined localization file in nls folder style for en-US (./app-resources/nls/resources)
define({     todo: {         todolist: 'Todo List',         todo: 'Task',         done: 'Done',         state: 'State'     } });
2) for TS resolution,defined module with extract path as following in a.ts
declare module "i18n!app-resources/nls/resources" {     let json: any;     export default json; }
3) Import the module like below in b.ts
import appresource from "i18n!app-resources/nls/resources";
i18n file succesfully loaded as dependency.problem is here when you use the appresource in b.ts,it appears as appresource.default  which is null because todo object is assigned to appresource obj itself.
What would be the way of doing this binding correctly ?
using vs 2015 ,ts ver 1.8

using 'require' fixed the case.
import appresource = require('i18n!app-resources/nls/resources');
Is there any solution for es6 way?

import appresource from "i18n!app-resources/nls/resources"; => import the default property of the module. if the module does not have one, you get undefined.
what you need is import * as appresource from "i18n!app-resources/nls/resources"; instead.

here is more documentation about modules: https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/Modules.md

Thanks :thumbsup:

authors: mhegazy sercangurbuz


text:
Allow to use a const in the initializer of a const enum

Was there any reason we didn't do this already? It doesn't seem to cause errors in the presence of circularity.

file1.ts
import { b } from './file2';

export const enum X {
  a = 1,
  c = b
}

file2
export const b = 10;

In your branch this compiles cleanly under --isolatedModules but file1.ts will generate different (and possibly non-working) code under transpileModule

From discussion with @RyanCavanaugh: It looks like --isolatedModules just ignores const anyway and produces accesses like X.c everywhere, so this won't affect that.
Ping @ahejlsberg to see if there are any other reasons we don't support this.

This only works for constants with literal types? Otherwise there's no way the value can be inlined.
There should probably be a test for non-literal types, e.g. : string or : 1 | 2

@ahejlsberg Good to go?

@ahejlsberg bump

@ahejlsberg

@ahejlsberg

authors: RyanCavanaugh ajafff andy-ms


text:
How to install WSL into other disk?

I don't want it be installed at %localappdata%\Packages.
In the past I could mount it to a VHD file, but now I can't.
So what should I do to manage it?

#449

@Ferouden you can easily do that with WslRegisterDistribution function. Make a executable with that and you can install it anywhere. The installed path is saved in registry  path HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Lxss\{GUID} and registry key is REG_SZ BasePath.

@therealkenc I have read that, and every method invovled in that issue I tried is no use.

@Biswa96 I found a Tool is written with method you explained. LxRunOffline.
And it works. THX.

Ya, I know Directory.Move() method does that. Also you may do that manually as I said.
I'm contributing to that repo. You may see wiki page of LxRunOffline to install many distros.
You may close this issue if your problem was solved.

authors: Biswa96 Ferouden therealkenc

repo: Microsoft/WSL


text:
Windows 7 install cordova-plugin-appcenter-analytics on a ionic 3 project

Failed to install 'cordova-plugin-appcenter-analytics': Error
at C:\Users\Administrator\AppData\Roaming\npm\node_modules\cordova\node_modu
les\cordova-lib\src\plugman\install.js:557:37
at _fulfilled (C:\Users\Administrator\AppData\Roaming\npm\node_modules\cordo
va\node_modules\cordova-lib\node_modules\q\q.js:787:54)
at self.promiseDispatch.done (C:\Users\Administrator\AppData\Roaming\npm\nod
e_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:816:30)
at Promise.promise.promiseDispatch (C:\Users\Administrator\AppData\Roaming\n
pm\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:749:13)
at C:\Users\Administrator\AppData\Roaming\npm\node_modules\cordova\node_modu
les\cordova-lib\node_modules\q\q.js:509:49
at flush (C:\Users\Administrator\AppData\Roaming\npm\node_modules\cordova\no
de_modules\cordova-lib\node_modules\q\q.js:108:17)
at _combinedTickCallback (internal/process/next_tick.js:73:7)
at process._tickCallback (internal/process/next_tick.js:104:9)
Failed to restore plugin "cordova-plugin-appcenter-analytics" from config.xml. Y
ou might need to try adding it again. Error: Version of installed plugin: "cordo
va-plugin-appcenter-shared@0.1.2" does not satisfy dependency plugin requirement
"cordova-plugin-appcenter-shared@^0.1.3". Try --force to use installed plugin a
s dependency.
I tried reinstall all plugins , still get this
I tried reinstall ionic@latest, still get this
I tried remove all node_modules , still get this.

Closing this for now, please feel free to reopen if you have any updates.

authors: brianwang sergey-akhalkov

repo: Microsoft/appcenter-sdk-cordova


text:
msbot connect abs should not enforce optional creation of endpoint

Tool
Name:  Msbot
Version: 4.0.7
OS: windows 10
Describe the bug
The help command of msbot connect bot states that endpoint is optional.
-e, --endpoint               (OPTIONAL) Registered endpoint url for the Azure Bot Service
-p, --appPassword         (OPTIONAL) Microsoft AppPassword for the Azure Bot Service
But the parameter is enforced AND and an endoint is created too.
To Reproduce
Steps to reproduce the behavior:
Check help for msbot connect abs. Then try to omit the enddpoint or the password. It will not accept the omission.
Expected behavior
msbot abs connect should not enforce endpoint creation. It should be optional as in the help.
[bug]

Thanks for reporting this. In this case, the right behavior is to make the endpoint mandatory which was the original intention. Updating the docs to reflect that.

repo: Microsoft/botbuilder-tools


text:
Tag 4.7.1-windowsservercore-ltsc2016 doesn't start with memory 4G

If I run a new container without any memory limitation it starts successfully.
docker run microsoft/dotnet-framework:4.7.1-windowsservercore-ltsc2016
Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.
C:\>
If I run a new container with --memory 4G it doesn't start and seems so be in an endless loop (I've stopped after waiting about an hour:
docker run --memory 4G  microsoft/dotnet-framework:4.7.1-windowsservercore-ltsc2016
So I try to start with --memory 3G and it starts as expected
docker run --memory 3G  microsoft/dotnet-framework:4.7.1-windowsservercore-ltsc2016
Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.
C:\>
I'm running the latest Docker Version under Win 10 1703 (Build 15063.1088)

@GerritSo - I'm not able to reproduce this.  Can you include the output from docker version and docker info?  Thanks

The one thing I noticed that with your configuration is that your Docker service is running with the Experimental features enabled.  You might want to disable this and retry.  You should also verify this issue is not specific to microsoft/dotnet-framework.  Can you try docker run --memory 4G microsoft/windowsservercore:ltsc2016?

I've also tried docker run --memory 4G microsoft/windowsservercore:ltsc2016 and also with --memory 3G and without --memory so I think this problem can be closed here and I'll open an issue for the windowsservercore

authors: GerritSo MichaelSimons

repo: Microsoft/dotnet-framework-docker


text:
Server can not append to header after HTTP headers have been sent

In general I do not change HTTP headers by custom code except in some binary download URLs. This happens on <httpRuntime targetFramework="4.5.2" /> using Microsoft.Owin after deployment to production server. Well I am not sure where. Stackstrace below does not offer more details. The Codebase was generated by Visual Studio using project/new/ASP.NET Web Application (.Net Framework)  It seems to me that this are a lot of redirects while automatic logon process. And I feel this could have something todo with HTTPS. Please let me know if I can post further informations.
2017-08-21 14:27:28,509 [63] FATAL root - System.Web.HttpException (0x80004005): Der Server kann den Header nicht anh▒ngen, nachdem HTTP-Header gesendet wurden.
   bei System.Web.HttpHeaderCollection.SetHeader(String name, String value, Boolean replace)
   bei Microsoft.Owin.Host.SystemWeb.CallHeaders.AspNetResponseHeaders.Set(String key, String[] values)
   bei Microsoft.Owin.Infrastructure.OwinHelpers.AppendHeaderUnmodified(IDictionary`2 headers, String key, String[] values)
   bei Microsoft.Owin.Infrastructure.ChunkingCookieManager.AppendResponseCookie(IOwinContext context, String key, String value, CookieOptions options)
   bei Microsoft.Owin.Security.Cookies.CookieAuthenticationHandler.<ApplyResponseGrantAsync>d__f.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.Owin.Security.Infrastructure.AuthenticationHandler.<ApplyResponseCoreAsync>d__b.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.Owin.Security.Infrastructure.AuthenticationHandler.<ApplyResponseAsync>d__8.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.Owin.Security.Infrastructure.AuthenticationHandler.<TeardownAsync>d__5.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.Owin.Security.Infrastructure.AuthenticationMiddleware`1.<Invoke>d__0.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.AspNet.Identity.Owin.IdentityFactoryMiddleware`2.<Invoke>d__0.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.AspNet.Identity.Owin.IdentityFactoryMiddleware`2.<Invoke>d__0.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.AspNet.Identity.Owin.IdentityFactoryMiddleware`2.<Invoke>d__0.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.IntegratedPipelineContextStage.<RunApp>d__5.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   bei Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.IntegratedPipelineContext.<DoFinalWork>d__2.MoveNext()
--- Ende der Stapel▒berwachung vom vorhergehenden Ort, an dem die Ausnahme ausgel▒st wurde ---
   bei System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   bei Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.IntegratedPipelineContext.EndFinalWork(IAsyncResult ar)
   bei System.Web.HttpApplication.AsyncEventExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
   bei System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)

using System;
using System.Security.Claims;
using System.Threading.Tasks;
using Microsoft.AspNet.Identity;
using Microsoft.AspNet.Identity.EntityFramework;
using Microsoft.AspNet.Identity.Owin;
using Microsoft.Owin;
using Microsoft.Owin.Security;
using konsole_vorwerk.Models;

namespace myapp
{
    public class EmailService : IIdentityMessageService
    {
        public Task SendAsync(IdentityMessage message)
        {
            var smtpSection = (System.Net.Configuration.SmtpSection)System.Configuration.ConfigurationManager.GetSection("system.net/mailSettings/smtp");
            System.Net.Mail.SmtpClient client = new System.Net.Mail.SmtpClient();
            client.UseDefaultCredentials = false;
            client.Port = smtpSection.Network.Port;
            client.Host = smtpSection.Network.Host;
            client.DeliveryMethod = System.Net.Mail.SmtpDeliveryMethod.Network;
            client.EnableSsl = smtpSection.Network.EnableSsl;
            client.Credentials = new System.Net.NetworkCredential(smtpSection.Network.UserName, smtpSection.Network.Password);

            return client.SendMailAsync(smtpSection.From, message.Destination, message.Subject, message.Body);
        }
    }

    public class SmsService : IIdentityMessageService
    {
        public Task SendAsync(IdentityMessage message)
        {
            // Plug in your SMS service here to send a text message.
            return Task.FromResult(0);
        }
    }

    // Configure the application user manager used in this application. UserManager is defined in ASP.NET Identity and is used by the application.
    public class ApplicationUserManager : UserManager<ApplicationUser>
    {
        public ApplicationUserManager(IUserStore<ApplicationUser> store)
            : base(store)
        {
        }

        public static ApplicationUserManager Create(IdentityFactoryOptions<ApplicationUserManager> options, IOwinContext context)
        {
            var manager = new ApplicationUserManager(new UserStore<ApplicationUser>(context.Get<ApplicationDbContext>()));
            // Configure validation logic for usernames
            manager.UserValidator = new UserValidator<ApplicationUser>(manager)
            {
                AllowOnlyAlphanumericUserNames = false,
                RequireUniqueEmail = true
            };

            // Configure validation logic for passwords
            manager.PasswordValidator = new PasswordValidator
            {
                RequiredLength = 3,
                RequireNonLetterOrDigit = false,
                RequireDigit = false,
                RequireLowercase = false,
                RequireUppercase = false,
            };

            // Register two factor authentication providers. This application uses Phone and Emails as a step of receiving a code for verifying the user
            // You can write your own provider and plug it in here.
            manager.RegisterTwoFactorProvider("Phone Code", new PhoneNumberTokenProvider<ApplicationUser>
            {
                MessageFormat = "Your security code is {0}"
            });
            manager.RegisterTwoFactorProvider("Email Code", new EmailTokenProvider<ApplicationUser>
            {
                Subject = "Security Code",
                BodyFormat = "Your security code is {0}"
            });

            // Configure user lockout defaults
            manager.UserLockoutEnabledByDefault = true;
            manager.DefaultAccountLockoutTimeSpan = TimeSpan.FromMinutes(5);
            manager.MaxFailedAccessAttemptsBeforeLockout = 5;

            manager.EmailService = new EmailService();
            manager.SmsService = new SmsService();
            var dataProtectionProvider = options.DataProtectionProvider;
            if (dataProtectionProvider != null)
            {
                manager.UserTokenProvider = new DataProtectorTokenProvider<ApplicationUser>(dataProtectionProvider.Create("ASP.NET Identity"));
            }
            return manager;
        }
    }

    public class ApplicationSignInManager : SignInManager<ApplicationUser, string>
    {
        public ApplicationSignInManager(ApplicationUserManager userManager, IAuthenticationManager authenticationManager) :
            base(userManager, authenticationManager) { }

        public override Task<ClaimsIdentity> CreateUserIdentityAsync(ApplicationUser user)
        {
            return user.GenerateUserIdentityAsync((ApplicationUserManager)UserManager);
        }

        public static ApplicationSignInManager Create(IdentityFactoryOptions<ApplicationSignInManager> options, IOwinContext context)
        {
            return new ApplicationSignInManager(context.GetUserManager<ApplicationUserManager>(), context.Authentication);
        }
    }
}

PTAL @csharpfritz

@s-a You've attached source code for the providers in your application, but what actions are you taking in the browser that present the stack trace you shared?

Can you provide more info @s-a ?

Sorry for the delay. I am 100% back to nodejs business so pretty far away from the situation. I simply loaded a routed web page in browser. I guess you tried to reproduce the error so if there is nobody else concerned about the situation we can close this issue.  Maybe i did something wrong.

Thanks for responding. I'll wait to see if anyone runs it this and we can then get source code to test.

authors: csharpfritz richlander s-a

repo: Microsoft/dotnet


text:
Update pom.xml

HI all I'm new here

ok

ok

ok

repo: Microsoft/elastic-db-tools-for-java


text:
Re-evaluate "cgo" dependency?

As of 23ad5a714ce953959ea79723df23a913ff886ddd, the go-winio package depends on cgo. Some projects, mine included, try to avoid cgo dependencies because of the can of worms it opens, including adding complexity to cross-compiling and, in my case, the addition of the gcc toolchain to builder systems.
If cgo is required, so be it, but I figured I'd at least raise the issue for discussion. Is there any way to achieve a similar end without it? Thanks!

Worked on the fix before noticing this issue. Looks removable.

The Azure/azure-container-networking repo has a dependency on go-winio through hcsshim. It looks like the cgo dependency broke the Windows cross-compilation on Linux build machines. +1 for @danjacques ' comment on build complexity.
@darrenstahlmsft I tried your fix and it solved my build problems. Thank you!

Awesome, thanks much for resolving this so quickly!

authors: danjacques darrenstahlmsft ofiliz

repo: Microsoft/go-winio


text:
Cannot start IIS

I have installed docker:
Client:
Version:           18.06.0-ce
API version:       1.38
Go version:        go1.10.3
Git commit:        0ffa825
Built:             Wed Jul 18 19:05:28 2018
OS/Arch:           windows/amd64
Experimental:      false
Server:
Engine:
Version:          18.06.0-ce
API version:      1.38 (minimum version 1.24)
Go version:       go1.10.3
Git commit:       0ffa825
Built:            Wed Jul 18 19:23:19 2018
OS/Arch:          windows/amd64
Experimental:     false
And I have this simple Dockerfile
FROM microsoft/iis
RUN powershell -NoProfile -Command Remove-Item -Recurse C:\inetpub\wwwroot*
WORKDIR /inetpub/wwwroot
COPY Web/ .
I build the container with
docker build -t cpp-site .
Then I run it with
docker run -d -p 8000:8000 --name cpp-site cpp-site
I get the address of the running container and then go to my browser (Chrome) and go to the address http://xx.xx.xx.xx:8000 and I just get a timeout error. I looked at the logs (docker logs xxxx returns no output). I tried to exec into the running container to see if I could see anything amiss. Nothing.  Any hints as to how I would find what is tripping up my container?
Thank you.
Kevin

Hi Kevin,
I also run into this issue, and have some findings to share,
1st of all, I think this doc has mistake at this command line
docker run -d -p 8000:8000 --name my-running-site iis-site,
because in the container, there is no opening port 8000 at all, the only open port in it, is 80
#in the container
PS C:\inetpub\wwwroot> netstat -ano | findstr "80"
TCP    0.0.0.0:80             0.0.0.0:0              LISTENING       4
TCP    [::]:80                [::]:0                 LISTENING       4
2nd. To access the container you can do it in two ways,
*) as you've followed the README, you can access by the IP and port 80, in Chrome, don't use 8000.
or
*) run the command like below, to expose 80 to an unused port on local PC,e.g. 8011,
docker run -d -p 8011:80 --name my-running-site6 iis-jw-site01
then access in Chrome,  127.0.0.1:8011
Hope this help you too.

@KevinBurton As pointed out by @wcs9108 you're mapping to the incorrect port in the container. Trying mapping to port 80 inside the container instead as that the port the default site binding in IIS is listening on.

Thank you. This moved me forward.  Now the Chrome request is giving me "Sorry, an error occurred while processing you request."

authors: KevinBurton shirhatti wsc9108

repo: Microsoft/iis-docker


text:
formatOnTyping do not work for my language server

I add the typing format trigger char to my server capabilities as bellow, but it dos not work, when i type ;, the server do not receive the request.
capabilities: {
            documentOnTypeFormattingProvider: {
                firstTriggerCharacter: ";"
            }
}

...

connection.onDocumentOnTypeFormatting(params => {
    coder.tracer.info('onDocumentOnTypeFormatting');
    return coder.formatOnTyping(params);
});

My env:
vscode-languageserver@3.4.3
vscode-languageclient@3.4.5
vscode-languageserver-protocol@^3.4.4
vscode: 1.17.2
Any help is apreciate.

You should probably open your bug in the against the Microsoft/vscode or Microsoft/vscode-languageserver-node repository.
@liwangqian Did you set "editor.formatOnType": true in your VS Code settings?

@rcjsuen Yes, "editor.formatOnType": true is in my settings, I will commit an issue to  Microsoft/vscode-languageserver-node repository, thinks you any way.

authors: liwangqian rcjsuen

repo: Microsoft/language-server-protocol


text:
Discrete action redesign

Suggestion:

Mod doesn't send data until command has been acted on and rendered
Vastly simplifies agent code

In addition to this, I'd like to argue for a design that enables us to work on a combination of grid world scenarios.

Action interface needs to be designed in such a way that the agent becomes able to spawn / summon / gain blocks, NPCs, and other entities. This would allow for the creation of 3D versions of popular scenarios such as taxiworld. Related: #289.
Relative views often complicated gridworld scenarios in such a way, so getting a representation of the world relative to a fixed point of the world would greatly simplify the construction of such scenarios. See #293.

These points somewhat apply to the continuous action interface as well, but they are way more useful for discrete states / actions / scenarios.

Just wondering, is this discrete (or absolute) action redesign still on the development roadmap somewhere?

authors: DaveyBiggers Phantomb edran

repo: Microsoft/malmo


text:
Fix tests that weren't working on Linux

Casing issue and a timing issue.
Closes #1297

I manually updated the CI build to run tests on linux just to test this PR
@dotnet-bot test Ubuntu14.04 Build for CoreCLR please
@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

Tests passed!
Ubuntu 14.04: https://ci.dot.net/job/Microsoft_msbuild/job/master/job/_Ubuntu14.04_CoreCLR_prtest/163/testReport/
Ubuntu 16.04: https://ci.dot.net/job/Microsoft_msbuild/job/master/job/_Ubuntu16.04_CoreCLR_prtest/165/testReport/

repo: Microsoft/msbuild


text:
Allow overriding the optprof source branch

When the source branch was hardcoded to $(Build.SourceBranchName),
there was no good way to tell the build "build this branch, but take the
latest OptProf information from branch X". That's an important scenario
when standing up a new branch (like a release branch), or trying to
insert updated bits from a feature branch.
This requires a change to the build definition, which is the only place
(currently) that knows what variables to offer at job-scheduling time.
See https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=2568755 for an example of the override working:
Acquiring optimization data
Downloading optimization data from service https://devdiv.artifacts.visualstudio.com, drop OptimizationData/Microsoft/msbuild/master/20190405.1/295317/1

@tmat, any concerns about adding this layer of indirection?

Looks good. BTW, you might want to consider using a similar branch configuration mechanism as Roslyn does:
We configure our branches in https://github.com/dotnet/roslyn/blob/master/eng/config/PublishData.json
The only relevant version of this file is the one in the master branch.
Then we have PS functions that read that file and figure out what the right deafult IBC data branch and VS installer branch are like so: https://github.com/dotnet/roslyn/blob/master/eng/build.ps1#L272-L328

The idea of an automated indirection makes a lot of sense for the future, but I think we can defer it until we feel the pain more acutely (fortunately, we tend to have fewer branches in flight than Roslyn).

authors: rainersigwald tmat


text:
gitignore update for intellij idea

Make the project more friendly for intellij idea users :)

This is great default behavior.

@gstojsic Thank you for your great idea.

authors: DwordPtr gstojsic v-xiangs

repo: Microsoft/mssql-jdbc


text:
Add failover support without db mirroring configured

I would like to use the JDBC failoverPartner in an application that uses Azure SQL Databases.
Our scenario is this:
Set up Database X with geo-replication on primary server A, secondary B.
In JDBC, set server=A,failoverPartner=B
If server A goes down, stop the geo-replication, and application will automatically connect to B.
Azure SQL Databases do not support database mirroring, and thus they don't send metadata at connection time about their partner. JDBC expects this metadata to be received and throws an exception if not.
I modified the code to just use the database mirror if no failoverPartner is provided by the server it connects to. This might not be right per Database Mirroring specifications, but I would like to propose it anyways to be useful in other setups than database mirroring. Maybe a flag could be introduced that will allow it, or we could go with this and issue a warning if the server does not provide a partner.

We have the same issue here, I wanted to do a similar patch ;)

You are correct, the failoverPartner is not supported in Azure SQL Database. To achieve this you will need transparent failover. This is not yet public but if you'd like immediate access to this functionality you can enroll into the private preview.
Pls email to sashan at microsoft.com if interested.

Closing this PR since failoverPartner is set to release for Azure SQL Database.

authors: ajlam anosov1960 kentmc pierresouchay


text:
add --no-check-certificate for wget

It may fails without --no-check-certificate.

Hi @c9n, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hi c9n, thanks for your commit.
but githubusercontent is always offer the certification. if it is unable to verify the chain, you should fix your client.

authors: c9n chivee msftclas

repo: Microsoft/multiverso


text:
Update Extension More Info Setting to point to Github

Updates both the more info and Getting Started links to point to our GitHub instead of to CodePlex

Let's create fwlinks for these instead so that we don't have to edit the code in the future.

Sounds like a good idea, I'll create two new fwd links: one for MoreInfo and one for GettingStarted.

authors: mjbvz mousetraps

repo: Microsoft/nodejstools


text:
Samples tests do not work for gcc/g++ builds

The samples tests are also not enabled for gcc/g++ CI builds.

Fixed by https://github.com/Microsoft/openenclave/pull/871

authors: johnkord soccerGB

repo: Microsoft/openenclave


text:
Incompatible packages dialog is unclear about repercussions

Its unclear from the incompatible packages dialog text that you'll lose any references to radio. I think it needs to be clear that if you are using any radio blocks / references you will lose those by removing 'Radio'.

Otherwise you can find yourself with empty blocks, not knowing why.

New experience:

Missing packages are no longer added automatically if they cause a conflict with existing packages

When adding a package, we detect any conflicts with existing packages, and warn before installing it

If no conflicts are detected, the new package is added as usual
If a conflict is detected, we try to detect if the conflicting packages are in use

If the conflicting packages are not used anywhere, then we warn the user that they will be removed (with the ability to cancel).

If the conflicting packages appear to be in use in the user's blocks, then we let them know that they need to remove all these blocks before they can add the new package

Changes are in and will be in the next beta release

authors: guillaumejenkins microsoftsam

repo: Microsoft/pxt


text:
Add Keyboard navigation of the CodeFlowLocations in the editor

New feature to assign keys to navigate the codeflowlocations in the editor. A couple of initial design questions to discuss:

Which keys will we assign to forward and backward navigation? Are there other actions we want?
How should we handle when there is more then one CodeFlow in the result? Couple options I can think of:

cycle within one codeflow until you switch to  the next(either a keyboard key or mouse selection)
on reaching the end of the current codeflow the next hotkey will take you to the beginning of the next codeflow. In this scenario will it be obvious that they entered a different codeflow or do we need a notification of some sort?

This seems important to tackle in the short-term

I'm changing these two keybindings from F9 and F10 to Ctrl+F9 and Ctrl+F10. With the previous key mapping it was interfering with VSCodes default F9 command which adds a breakpoint to the current line in the editor.

authors: michaelcfanning rscrivens

repo: Microsoft/sarif-vscode-extension


text:
Impossible to add a CMake only port

I would like to package a library that is composed only of CMake modules (Extra CMake Modules (ECM)), but there are no include files and vcpkg fails with:
The folder /include is empty. This indicates the library was not correctly installed.

It would be useful a way to skip this check.

I will add a policy to skip the /include folder check.

authors: alexkaratarakis drdanz

repo: Microsoft/vcpkg


text:
Web applications cannot be published to Azure from Publish Wizard

Recently I noticed that when we create a VS 2017 .NET Core Web application project for F#
publishing to azure won't work.
The reasons is publish adds the following to the project file  :
  <UserSecretsId>3b2b079e-6201-411f-aa7d-....</UserSecretsId>
Which in turn causes the compiler give :
Program.fs(23,9): error FS0433: A function labeled with the 'EntryPointAttribute' attribute must be the last declaration in the last file in the compilation sequence.
Repro steps

Create an Empty .NET Core Web project with F#
Right click to Project and Publish it to Azure

It will take long time. Cancel it and try to build the projects
This issue didn't exist in June (I always keep VS up to date). But now happens with 15.8.8.

Adding   <GenerateUserSecretsAttribute>false</GenerateUserSecretsAttribute> works around the issue.

Linking duplicate #5549
This will be fixed in ASP.NET 2.2: https://github.com/aspnet/Configuration/pull/872

authors: OnurGumus cartermp

repo: Microsoft/visualfsharp


text:
Fix 316 - null array-valued attribute causes the compiler internal error

Fix #316
We were missing the 0xFFFFFFFF case indicating a "null" value for arrays

:shipit:

authors: dsyme latkin


text:
It doesn't show conflict if creating resource group using an existing name

Repro Steps:

Click "Create Account" button.
Find an existing resource group.
Select the subscription where the existing resource group is.
Select "Create Resource Group".
Type the name of the existing resource group.

Expect:
It shows "Resource Group name XXX already exists."

Actual:
It doesn't show the conflict.

This was fixed in https://github.com/Microsoft/vscode-cosmosdb/pull/412

authors: EricJizbaMSFT v-etzha

repo: Microsoft/vscode-cosmosdb


text:
The close arrow on the inline comment thing should be an X

It's an X for the inline find-all-references widget, and the panel.

Fixed by https://github.com/Microsoft/vscode/commit/70df226af0a243181edc7c7682aa71a548767996

@roblourens I clicked on the X expecting it to delete the comment
The collapse icon makes more sense here
In case of peek widgets there is nothing to delete, so X would mean close not delete
@misolori

We use x in several places to close things, I don't think we use it to mean 'delete'. Right or wrong, I think the consistency is good.

We (@RMacfarlane, @misolori and I) just had a discussion about the same.
I had added a comment, wanted to delete it, and even before I formed a coherent thought in my mind, I ended up clicking the X expecting it to delete the comment.
Once we do support the edit and delete features, we can have the trash can icon for delete just like we do for terminals. Then it wouldnt be so confusing.

authors: RMacfarlane ramya-rao-a roblourens

repo: Microsoft/vscode-pull-request-github


text:
vscode-python repeatedly launching wmic

Environment data

VS Code version: 1.21.1 x64
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Win10
Python version (& distribution if applicable, e.g. Anaconda): 2.7.13
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): NA

Actual behavior
When open to a python file, code with the Python extension enabled is continually launching
wmic processes.  This in turn backs the wmiprvse.exe service up, to the point where very
quickly it's consuming 100% of the CPU (on one core).
Expected  behavior
VSCode shouldnt' cause my CPU to be fully loaded when nothing's actually happening
Steps to reproduce:
Install VSCode
Install the python extension
Open a python file.
Watch in taskmgr/process explorer as wmic processes are created repeatedly.
Disable python extension
Watch as no further wmic processes are created, and processor returns to idle.

It is checking Jedi process memory footprint. It can be turned off.

My suggestion is to take control of the use of wmic ourselves (not use the npm package for windows os). VS Code is also using wmic to monitor processes for debugging (in a polling manner).
I.e. if they can do it reliably, we too should be able to do this by taking control over things, rather than relying on this.
@brettcannon @MikhailArkhipov
I propose we get a revised solution in for the next version, else this CPU could potentially throw off new users from using VSC (or the extension).

Making that change did resolve (or suppress) the problem.  But I've found that hitting WMI frequently has the same adverse affect; if there's a way to do it outside of WMI it's probably a good thing.

@DonJayamanne - I wouldn't worry too much. I think we can change default memory control to off (or at least on Windows). In the new analysis engine we have internal control of the memory consumption so the setting won't be needed eventually.

I was experiencing this issue as well, but the workaround posted above worked for me.  I'm very interested to understand the root cause of this issue because it isn't the first time I've had these symptoms.
I'm not even a Python developer normally (I usually write TypeScript and C# code), but I had been given a Python script to decipher and I used VSCode mainly for the syntax highlighting and IntelliSense.  I did install the vscode-python extension and later I noticed my CPU was pegged at 100%.
Unfortunately, I did not suspect VSCode (or the Python extension) at first because I have previously had issues with high-CPU usage in WmiPrvSE.exe with extremely similar symptoms.  FYI, this is a corporate machine with a ton of monitoring software on it, so I have assumed that one of those monitoring or security processes is overusing the WMI functionality.  One of the symptoms was McAfee anti-virus repeatedly being required to scan tzres.dll and tzres.dll.mui, hundreds of times a second.  McAfee has posting about this issue below, but of course, they claim the root cause is always something other than their software (and the article below links to a Microsoft posting for troubleshooting WMI, which again says the root cause is not WMI but something using it).
High CPU usage by mcshield.exe, and wmiprvse.exe and mcshield.exe are repeatedly opening and closing tzres.dll and tzres.dll.mui
https://kc.mcafee.com/corporate/index?page=content&id=KB88026
The symptom above was definitely occurring in this case, and the workaround stopped it.  However, I have had the same symptom even when VSCode was not running and something else was causing it (perhaps regular Visual Studio Professional or Chrome or one of those dozens of corporate bloatware processes that are always running).
Thus, I would appreciate any insights into the root cause.  Thanks!

@YipYipX4 the problem is that we use a project called Jedi for our IntelliSense and some users have complained about massive memory usage. So we introduced a mechanism to monitor the memory and prevent it from getting too big. Unfortunately the mechanism has had some adverse effects as well, so we are trying to figure out how best to handle this.

WMI just doesn't perform well if you use it frequently (as in poll every 5 seconds).  You can get the same information from the performance counters library w/o incurring the wmi perf hit.

authors: DonJayamanne MikhailArkhipov YipYipX4 brettcannon derekwbrown

repo: Microsoft/vscode-python


text:
Question: Is it possible to "merge" completion provider results

Hey guys
I was wondering if the following scenario is possible:
When I register my custom CodeCompletionProvider (which now works like a charm, thanks to Johannes Rieken), the default provider from VSCode is kinda deactivated.
When I explicitly call the suggestions, it more or less works, but not on all scenarios.
I'd like to merge the results of my provider with the original providers of vscode. Or at least extend the base result with my results.
The problem is, if I overwrite the default provider and deliver non imported symbols to complete, stuff like [].some or other array functions are not completable anymore. My completionprovider does not index those functions, so there are not visible anymore.
It would be cool if both information would be there.
Cheers
Chris

The default is merging and it's actually hard to disable that. I'd interested in learning more about your provider and how it overrides?

Of course :-) I'd be happy to help.
Have a look at it here: https://github.com/buehler/typescript-hero/blob/feature/code-completion-provider/src/provider/ResolveCompletionItemProvider.ts
Registering it here: https://github.com/buehler/typescript-hero/blob/feature/code-completion-provider/src/extensions/ResolveExtension.ts#L97
And if I use this provider I don't see any other providers results in the suggestions window. I don't know the exact mechanics of vscode, but my assumption was, that the results are merged.
But you can try it for yourself, you'll only see the results of "my" provider when you are typing, but afterwards when you call the provider "by force" with the keybindings, the results are kind of merged.
Cheers

Yeah, that's because of the long list of auto trigger characters. When a auto trigger character is seen we only ask those providers - usually that is just a few special characters like .. If there a special reason you use the whole alphabet? As long as the quickSuggest setting is true (which is default) you will be asked anyways.

Alright. Yea there is a special reason: When I remove the trigger characters, my provider never gets called in the first place. Only if I use the keybinding of the suggestions. At least, all other stuff works again (like Array.some), but my suggestions are never shown.
My completion provider works as such that is only delivers a result when the user is typing the first word of a assignment or stuff. The usecase is to add the import to the document when it's not already imported.
So if you write "MyC" it should suggest "MyClass". But when I don't use the trigger characters, it looks like this:

Only when I call the suggestions with ctrl+space it looks like this:

When I used all the trigger characters, the suggestions would automatically pop up if you write anything.
Is this the wrong way to accomplish this goal?

Hey @jrieken
Do you still need more information? I'd be happy to provide you with any information that I can.
Cheers

Can you check for this setting "editor.quickSuggestions": true? By default we keep asking for completions while the user types (24x7 intellisense) - if that is turned off we still use trigger characters (unless turned off "editor.suggestOnTriggerCharacters": true|false)

Well I just checked, quickSuggestions is on (true) and suggestOnTriggerCharacters is true as well.
The behaviour is still the same. On normal typing, only the normal suggestions of vscode are visible. Only if I explicitly call the suggestions with the keycombo, my suggestions show up.

So, putting a breakpoint here and I see it being hit on type as well as on ctrl+space. Unsure what comes then but if the provider is being hit, its result (iff available) will be merged

Alright, let me check again if the line https://github.com/buehler/typescript-hero/blob/master/src/provider/ResolveCompletionItemProvider.ts#L38 is causing those troubles. Maybe because I drop out of completion if less than 2 characters are typed, this is deactivating my suggestions.
I'll come back to you with more info, thanks for the help!

Hooray!
Alright, my bad 😉
Since I deactivated the "minimum characters", it does work like a charm!
I really appreciate the help!
Cheers

authors: buehler jrieken

repo: Microsoft/vscode


text:
Start Integrated Terminal in the same location as the active file

VSCode Version: Code 1.5.2 (66f37fd2a99eb9d628dd374d81d78835b410c39b, 2016-09-12T13:30:03.456Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

Open a file
Open the Integrated Terminal (View > Integrated Terminal)

It should work similar to: right-click on file > Open with command prompt.

Here are a number of easy ways that would either open an integrated terminal in a user selected location or change the working directory of an existing integrated terminal:

via 2 right click menu entries in file editors:

new integrated terminal here
chdir integrated terminal here

same 2 menu entries in explorer right click menu

drag a directory from the explorer to a terminal to set its current directory

The context menu request is captured in #8132
As for dragging, I think I like iTerm's feature where it pastes the path of the file into the terminal. #11907
As for this actual feature request, you should be able to do this in an extension now through the recently introduced terminal API. In fact... I just did it! :wink: https://marketplace.visualstudio.com/items?itemName=Tyriar.vscode-terminal-here you will need VS Code 1.5+ to install the extension, if you have any improvements in mind file issues over at https://github.com/Tyriar/vscode-terminal-here

Works fine except with paths with embedded spaces.
I have quoted the pathname to care for that case.
Created a pull request.
Guido
On 16 September 2016 at 02:32, Daniel Imms notifications@github.com wrote:

Closed #12094 https://github.com/Microsoft/vscode/issues/12094.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/12094#event-791532492, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMnVtaBCEq4i4UW9brb3Am2UDw7qBC6ks5qqeODgaJpZM4J-J5H
.

Thanks for the rapid response guys. That was tremendously quick.

authors: Tyriar carlin-q-scott guivho


text:
Prompt user for opening all tabs for replace all

VSCode Version: 1.5.2
OS Version: OS X 10.11.6

Currently, if someone is doing a project-wise replace, VSCode opens all modified files after the change.
If 100 files are changed, VSCode opens 100 tabs. Should prompt user.

Prompting would be annoying for me. VSCode should just replace the text in all the files and don't bother to open any tabs at all IMHO.

@sandy081 fyi

Might make sense after a certain threshold is hit?

I feel the current behavior is fine.

authors: Tyriar bpasero jhasse octref


text:
Previous file functionality

Often while I'm using Code I want to go back to the previous file I was just at. Other IDEs have back and forward buttons. I'm not thinking we should have those buttons in code, but possibly a keyboard shortcut to go back to the previous file or maybe have something in the status bar.
I'll look into implementing it as an extension - but it could be a good idea for a feature.

Nevermind found it in Goto menu.


text:
Destructuring does not auto-format whitespace

VSCode Version: 1.7.1 02611b40b24c9df2726ad8b33f5ef5f67ac30b44 2016-11-03T13:44:00.572Z
OS Version: OSX 10.12.1 (16B2657)

Issue
The whitespace on the LHS of a destructuring assignment is not formatted.
Steps to Reproduce:

Add the following to a typescript file:

const {NoSpaces} = { NoSpaces: 1 }
const { WithSpaces } = { WithSpaces: 1 }
const {OneSpace } = { OneSpace: 1 };

Format the document.

Expected
I would expect the whitespace on the LHS of the assignment to be consistent. I would expect either:
const {NoSpaces} = { NoSpaces: 1 }
const {WithSpaces} = { WithSpaces: 1 }
const {OneSpace} = { OneSpace: 1 };

or
const { NoSpaces } = { NoSpaces: 1 }
const { WithSpaces } = { WithSpaces: 1 }
const { OneSpace } = { OneSpace: 1 };

Actual Output
Whitespace of the LHS is inconsistent:
const {NoSpaces} = { NoSpaces: 1 }
const { WithSpaces } = { WithSpaces: 1 }
const {OneSpace } = { OneSpace: 1 };

@marcomorain thank you for opening this issue and apologize for the delay. This issue has to deal with functionality provided by TS Server. Migrating to that repo.

This issue was moved to Microsoft/TypeScript#12239

authors: marcomorain waderyan


text:
[C/C++] syntax highlight after calling macro without semicolon

VSCode Version: 1.7.1
OS Version: Ubuntu 16.04

Steps to Reproduce:

Create a macro that doesn't / can't end with a semicolon
Next line after calling said macro won't be syntactically highlighted

Example:
#define BEGIN_NAMESPACE(name) namespace name {

BEGIN_NAMESPACE(test)
class Test {}; // won't be colored, regardless of whitespace (newlines) in between

duplicate of https://github.com/atom/language-c/issues/173


text:
Does Global Storage keep states when extension is updated / removed and intalled

I have stored user secret information in global state.
Will user be able to get the information when the extension is updated or removed and install after sometime?

Yes - the data is kept in a location which is derived from the extension id. So as long as the identifier (name & publisher) doesn't change data is kept stable

authors: jrieken shanalikhan


text:
after installing or upgrading extension(s) open explorer viewlet on restart

Most (all?) of the time when I restart VS Code after installing or updating an extension, I don't want the extension viewlet open on restart.
My mental model is that I've discovered and installed all of the extensions I'm interested in and upon restart I want to start using them. I want to start opening files (e.g. a Dockerfile after installing DockerSupport) and rarely do I want to search for new extensions or mange the existing ones.
I suggest that upon restart after installing/updating an extension that we go back to the Explorer view.

@chrisdias please see https://github.com/Microsoft/vscode/issues/8269

authors: bpasero chrisdias


text:
Settings search stopped working for me

VSCode Version: Code - Insiders 1.9.0-insider (2cdc2b3da8f0fd5322b48747241584cf9dd98f8f, 2017-01-13T07:03:18.620Z)
OS Version: Linux x64 4.8.0-32-generic
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.3.4

lorem-ipsum
Tyriar
1.0.0

theme-glacier
Tyriar
0.0.10

vscode-svgviewer
cssho
1.3.0

python
donjayamanne
0.5.5

gitlens
eamodio
1.4.1

tslint
eg2
0.8.1

git-project-manager
felipecaputo
1.0.1

Theme-Wombat
gerane
0.0.2

md-navigate
jrieken
0.0.1

Go
lukehoban
0.6.50

vscode-scss
mrmlnc
0.6.0

csharp
ms-vscode
1.6.2

seti-icons
qinjia
0.1.3

java
redhat
0.0.8

annotator
ryu1kn
0.10.1

In console:
shell.ts:432t.toLowerCase is not a function: TypeError: t.toLowerCase is not a function
    at Object.a [as matchesContiguousSubString] (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:30:9716)
    at f (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:90:3319)
    at t._findMatchesInSetting (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:90:3541)
    at t.doFilterSettings (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:90:2054)
    at t.filterSettings (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:90:8764)
    at t.filterPreferences (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:114:8733)
    at t.filterPreferences (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:114:1765)
    at file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:114:281
    at e.invoke (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:30:26461)
    at e.fire (file:////usr/share/code-insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:30:29773)

I was not expecting null values in default settings and there was a new setting introduced yesterday with null value. Fixed the search to be null value aware.


text:
Keep being asked to login to Github

VSCode Version: 1.11
OS Version: Windows 10

Steps to Reproduce:
Every time I open a new editor window I am asked to login on Github even when I did it before.

You likely need to configure git to cache your credentials. VS Code utilizes the underlying git installed on your device.

@mdmoura Check @wsmelton's suggestion.

authors: joaomoreno mdmoura wsmelton


text:
TSCheck: dot not needed on the end of quick fix action titles

Refs: #25322
There should not be a dot on the end of the titles of quick fix actions. Just compare it to all the other actions we have in the context menu. None of them have a dot at the end

Opened https://github.com/Microsoft/TypeScript/issues/15399 to track this upstream

authors: isidorn mjbvz


text:
Would love to be able to fast-project-switch

gitkraken has a neat dropdown in the top left of their interface.  Basically enumerates all known repositories.
Would be neat if code did something similar, except for projects.  That way I don't have to do the ctrl-shift-n keystroke and then drill over to whatever directory I need.

@bpasero - Not really the same as what I suggested.

@atrauzzi but it avoids having to to type Ctrl+Shift+N, no?

@bpasero  - That would be focusing exclusively on one aspect of my original ticket.  There's more to this than speed-triaging this against an existing feature.
The other issue is that "Open Recent" opens it in the current window.  So, even in your suggestion, it doesn't speak at all to what I'm trying to highlight here.

@atrauzzi not at all, there are instructions how to force open it in a new window:

@bpasero wow, didn't know about this. cool feature!

authors: atrauzzi bpasero kumarharsh


text:
onDidChangeWorkspaceRoots comes too early

onDidChangeWorkspaceRoots event comes too early. If i try to get the configuration of one of the roots I get undefined results.
I believe the onDidChangeWorkspaceRoots events should come only after I am able to read settings from all the roots

Right, roots changes are detected first and then configuration is computed and notified. Let me know how important is it for you to get this fixed?
I would like to move it to next milestone if not important.

Not that important, next milestone is fine

Thanks


text:
Launch config wraps args in quotes

VSCode Version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:12:42.401Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

vscode-docker
Pet
0.0.16

npm-intellisense
chr
1.3.0

vscode-eslint
dba
1.3.0

vscode-npm-script
eg2
0.2.1

sublime-babel-vscode
jos
0.2.8

cpptools
ms-
0.12.3

csharp
ms-
1.12.1

debugger-for-chrome
msj
3.2.1

vscode-icons
rob
7.12.0

Steps to Reproduce:

Launch with `		{
// Name of configuration; appears in the launch configuration drop down menu.
"name": "Run app-server tests",
// Type of configuration. Possible values: "node", "mono".
"type": "node",
"request": "launch",
 	// Workspace relative or absolute path to the program.
 	"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
 	// Automatically stop program after launch.
 	"stopOnEntry": false,
 	// Command line arguments passed to the program.
 	"args": ["$(find ./test -name '*.js')"],
 	// Workspace relative or absolute path to the working directory of the program being debugged. Default is the current workspace.
 	"cwd": "${workspaceRoot}",
 	// Workspace relative or absolute path to the runtime executable to be used. Default is the runtime executable on the PATH.
 	"runtimeExecutable": "${workspaceRoot}/node.sh",
 	// Environment variables passed to the program.
 	"env": { "NODE_ENV": "development"}
 }`

Command line call ends up single quoting the args which causes the command to fail. Here is the output node.sh --inspect=36920 --debug-brk node_modules/mocha/bin/_mocha '$(find ./test -name '*.js')'

Reproduces without extensions: Yes/No

I want to clarify (I have been working to get around the issue). The problem isn't that it is wrapping the args in quotes, it is that the args for me is actually a bash command to list all the files in a directory.  I need the command to execute and the results to written out as args.

Currently what you are trying to do is not supported.
You could try to use an argument that does not contain any spaces and will not be quoted by VS Code, e.g. a bash function.

We cannot support correct quoting for all possible combinations of shells and OSes.
I suggest to move the $(find ./test -name '*.js') into a shell script and refer to that from the launch configuration.

authors: guycnicholas weinand


text:
SCM: repository status could get some alignment

Testing: https://github.com/Microsoft/vscode/issues/35034
I think visually it would be nice if the repository status would be aligned at least on the left hand side. We always seem to have the branch icon followed by the branch name and I think the branch icon should always show aligned across all repositories:

Actually this is more complicated and needs more thinking:

It seems to me we have some structure per row:

the repository name
the repository provider name
the number of changes
the branch
dirty indicators (*, +)
the sync action
incoming / outgoing changes

Some way of aligning these would be nice, otherwise the view becomes very heavy.

This is also nothing we can really control, given that providers can contribute whatever they want. We might want to drop the status items though, and just allow to have inline, square, actions.

We might want to drop the status items though

What does that mean?

Those status items were never meant to be shown there, but in the status bar. I just repurpose them to that location. But maybe it's best if we call it a whole different location and have semantic actions in that location.

Don't get me wrong, I like all the info I am seeing there. But visually I wonder if we can align things better that belong together.

Closing this for now.

authors: bpasero joaomoreno


text:
Uncaught TypeError: Cannot read property '1' of null.

Hi there,
I have no clue what this is about, but it is crashing the app we are developing.  It would appear that something (an object I know not what) is null and blowing up the xterm console when I move my mouse in the Chrome browser.

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:23.027Z)
OS Version: Windows_NT x64 6.1.7601
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

vscode-angular2-files
ale
1.3.10

path-intellisense
chr
1.4.2

jshint
dba
0.10.15

bower
don
0.0.3

githistory
don
0.2.3

vscode-npm-script
eg2
0.2.1

Angular2
joh
2.7.0

csharp
ms-
1.12.1

PowerShell
ms-
1.4.3

debugger-for-chrome
msj
3.3.1

view-in-browser
qin
0.0.5

nativescript
Tel
0.7.2

html-snippets
wge
0.1.5

html-css-class-completion
Zig
1.10.0

Steps to Reproduce:

Debug the web app in VS Code.
Navigate to any view.
Move the mouse.

The whole app crumbles at: at NgIf.module.exports.NgIf._updateView...
I need to use *ngIf for obvious reasons, since this is an angular app.

Uncaught TypeError: Cannot read property '1' of null     at SelectionModel.areSelectionValuesReversed  (C:\Program Files\Microsoft VS Code\resources\app\node_modules\xterm\lib\SelectionModel.js:51)

fail: Microsoft.AspNetCore.NodeServices[0]
ERROR ReferenceError: document is not defined
at createDropCue (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\main-server.js:10885:24)
at GroupConnectionService.register (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\main-server.js:10915:24)
at new GroupPanelComponent (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\main-server.js:54294:14)
at createClass (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\vendor.js:21881:26)
at createDirectiveInstance (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\vendor.js:21699:37)
at createViewNodes (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\vendor.js:23127:49)
at Object.createEmbeddedView (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\vendor.js:23010:5)
at TemplateRef_.module.exports.TemplateRef_.createEmbeddedView (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\vendor.js:21214:38)
at ViewContainerRef_.module.exports.ViewContainerRef_.createEmbeddedView (C:\Users\dmorri3\Source\repos\revrec.Workbookmanager\rr.webapi\ClientApp\dist\vendor.js:2099
Honestly, I can't figure out if it is something I am doing wrong.  I have not seen this behavior before, and hope never to see it again.
Thanks for checking it out.
David

Reproduces without extensions: Not sure.  When I Control + f5 I get "Configured debug type 'coreclr' is not supported."

Adding verified by code review. End can not now be null

authors: dhmorrison isidorn


text:
[insiders] VS Code no longer finds GIT

Using the latest Insiders on Windows 10.
I have GIT installed at C:\Git.

Please configure it using the git.path setting, like the alert box suggests.

authors: AndyBay joaomoreno


text:
Unescaped markdown in "Failed to move to trash" message

VSCode Version: 1.18.1

Reproduces without extensions: Yes
Image example:

https://github.com/Microsoft/vscode/issues/34367

authors: bpasero cauebs


text:
Issue bot should assign type labels when issue was created with the issue reporter

Issues filed with the issue reporter contain information about the type of the issue. This information should be used to auto-type-label the issue.

One objection when the bot guessed and auto-assigned type-labels was that these are used as a way of confirming the issue and should always be set by the developer. That feedback might again come up in this case.

authors: chrmarti kieferrm


text:
syntax highlighting is wrong for SQL statement containing alias with []

Issue Type: Bug
for example:
SELECT [Student's Name] = StuName
FROM StudentTable
all the charaters after ' will highlighted as VARCHAR
VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

Memory (System)
7.89GB (1.61GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

mssql
ms-
1.3.0

team
ms-
1.122.0

iRule
yig
1.2.0

This issue was moved to Microsoft/vscode-mssql#1075

authors: aeschli chowkf


text:
[Accessibility]A11y_VSCode_GoToSymbolInFile_ScreenReader:NVDA reads @ twice which is in the placeholder

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
ScreenReader [NVDA2018.2],,MAS1.3.1
Repro Steps:
1)Launch VS Code.
2)Navigate   to Go(Alt+G) menu option and select "Go To Symbol in File" from   dropdown
3)Start NVDA.
Actual:
NVDA reads @ twice which is inappropriate
Expected:
NVDA should not read @ twice.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
Such an activity would create Confusion for the user.
MAS Reference:
https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Does this issue occur when all extensions are disabled?: Yes
Attachment for Reference:
[Accessibility]A11y_VSCode_GoToSymbolInWorkSpace_Keyboard.pptx

Can not repro this issue.
Video is unrelated to this issue, it is a duplicate of https://github.com/Microsoft/vscode/issues/51850

authors: AccessibilityTestingTeam-TCS isidorn


text:
Custom problem matcher not clearing problems correctly

Issue Type: Bug
I have the following problem matchers associated with an npm task which is a webpack watcher using ts-loader and tslint-loader. It seems to capture and populate the Problems view, but when errors are cleared it leaves behind problems in other (not opened) files. It seems like a clean run from the watch should clear all the problems.
/cc @dbaeumer
{
	"type": "npm",
	"script": "watch",
	"group": "build",
	"isBackground": true,
	"problemMatcher": [
		{
			"fileLocation": "absolute",
			"owner": "typescript",
			"pattern": [
				{
					"regexp": "\\[tsl\\] ERROR in (.*)?\\((\\d+),(\\d+)\\)",
					"file": 1,
					"line": 2,
					"column": 3
				},
				{
					"regexp": "\\s*TS\\d+:\\s*(.*)",
					"message": 1
				}
			],
			"severity": "error",
			"source": "ts",
			"background": {
				"activeOnStart": true,
				"beginsPattern": {
					"regexp": "webpack is watching the files..."
				},
				"endsPattern": {
					"regexp": "Built at\\:(.*)"
				}
			}
		},
		{
			"fileLocation": "relative",
			"owner": "typescript",
			"pattern": [
				{
					"regexp": "WARNING in (.*)",
					"file": 1
				},
				{
					"regexp": "Module Warning (.*)"
				},
				{
					"regexp": "\\[(\\d+), (\\d+)\\]: (.*)",
					"line": 1,
					"column": 2,
					"message": 3
				}
			],
			"severity": "warning",
			"source": "tslint",
			"background": {
				"activeOnStart": true,
				"beginsPattern": {
					"regexp": "webpack is watching the files..."
				},
				"endsPattern": {
					"regexp": "Built at\\:(.*)"
				}
			}
		}
	]
},

VS Code version: Code - Insiders 1.26.0-insider (aceb8771b1c0e116f684091986ad25769bdc0537, 2018-08-07T07:55:29.593Z)
OS version: Windows_NT x64 10.0.17730

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.93GB (15.71GB free)

Process Argv
C:\Users\Eric\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

@eamodio if I understand this correctly these problems aren't TypeScript problem. So they shouldn't use typescript as the owner.
Can you provide me with a GitHub repository I can clone that demos this?

@dbaeumer They are coming from the webpack ts-loader which would be the equivalent of typescript owner no?
If you try the develop branch of the GitLens repo it has it all setup with webpack and the problem matchers

I cloned the repository. Can you provide steps I have to do to see the problem?

OK. I was able to reproduce and the problem is that webpack is watching the files… is only issued once.
A background problem matcher for a watching task always needs a start / end expression to function correctly. When the start is detected the matcher scans the output and when the end is detected it stops scanning and clears all old problems. Since there is no new start it never clears.
Any objection to close ?

Damn, ok -- thank you for the help!

No problem.

authors: dbaeumer eamodio


text:
Cannot read property 'classList' of undefined

Issue Id: 4240de92-3050-fab8-2a53-bb2ea93294ffVersions - 1.26.0-  493869ee8e8a846b0855873886fc79d480d342de-  bda8a4de93278004d6d7c3628b92664f93f7e811-  207ace21dfec3dccab52f1296a3880ac7644c978-  c827480be25bd63065e7ee2e106c24a707c08004Stack TypeError: Cannot read property 'classList' of undefined/vs/base/browser/dom.ts#170:24 (removeClass)/vs/base/browser/ui/breadcrumbs/breadcrumbsWidget.ts#200:8 (_focus)/vs/base/browser/ui/breadcrumbs/breadcrumbsWidget.ts#258:7 (setItems)/vs/workbench/browser/parts/editor/breadcrumbsControl.ts#227:16 (call)/vs/base/common/event.ts#140:15 (fire)/vs/workbench/browser/parts/editor/breadcrumbsModel.ts#218:21 (_updateOutlineElements)/vs/workbench/browser/parts/editor/breadcrumbsModel.ts#181:12 (runner)/vs/base/common/async.ts#671:3

/duplicate of #56634

same root cause as #56634

authors: jrieken vscodeerrors


text:
acceptSuggestionOnCommitCharacter

VSCode Version: 1.27.0
OS Version: macOS

this, super, console isn't finished after pressing .

The issue was also with 1.26.1 version.

@mjbvz As I know you know how this setting works. I really like it and I'm trying to use it as much as possible instead of Tab or Enter cuz' it will reduce some typing, but it kinda annoying when it doesn't work in such cases...

Second part (from comment) is upstream issue https://github.com/Microsoft/TypeScript/issues/25691

You're my hero! 😄

authors: mjbvz svipben


text:
Extension Host process never exits when having endless loop in extension

(The UI side of things is tracked in #58612)

Create an extension with a while (true) or process.nextTick endless loop
Close VS Code completely
Observe, the extension host process lingers around

Here is an example extension:

package.json:

{
  "name": "bad",
  "publisher": "alex",
  "version": "0.0.0",
  "engines": { "vscode": "^1.22.0" },
  "activationEvents": [ "*" ],
  "main": "index.js"
}

index.js:

const vscode = require('vscode');
exports.activate = function() {
    console.log(`I am now entering while true loop`);
    while (true) {
        // do nothing, like a pro
    }
}

Observe that after exiting vs code the extension host process runs forever, until it must be manually killed.

The extension host process will now quit at most within 7 seconds of the parent process quitting.

@alexandrudima I love you. You just fixed half of my Windows installation issues.

authors: alexandrudima joaomoreno