text:
Probable bug in TopKAggregate

Describe the bug
@dispanser pointed out a probable bug in TopKAggregate:
https://github.com/apache/datafusion/blob/77f330c6a2b26f2d1d4d4bf11d456fad466316b4/datafusion/physical-optimizer/src/topk_aggregation.rs#L102

we should probably call it cardinality_reducing and allow anything that is !cardinality_reducing
FilterExec is cardinality reducing, and should not be whitelisted here
things like CoalescePartitionsExec should be white listed because they don't change cardinality
in theory, something like a left outer join can only increase cardinality, so should be allowed as well

I would suggest we add a cardinality_reducing() or not_cardinality_reducing() method to the ExecutionPlan trait, so we don't need to maintain this downcast list.
i.e.
                    GlobalLimitExec: skip=0, fetch=100, metrics=[]
                      SortExec: TopK(fetch=100), expr=[$d.max_ts@1 DESC NULLS LAST], preserve_partitioning=[false], metrics=[]
                        AggregateExec: mode=Final, gby=[$d.traceID@0 as $d.traceID], aggr=[$d.max_ts], lim=[100], metrics=[]
                          CoalescePartitionsExec, metrics=[]
                            AggregateExec: mode=Partial, gby=[$d.traceID@0 as $d.traceID], aggr=[$d.max_ts], lim=[100], metrics=[]

is fine because CoalescePartitionsExec means the 100 rows from AggregateExec will be passed all the way up to GlobalLimitExec.
However:
                    GlobalLimitExec: skip=0, fetch=100, metrics=[]
                      SortExec: TopK(fetch=100), expr=[$d.max_ts@1 DESC NULLS LAST], preserve_partitioning=[false], metrics=[]
                        AggregateExec: mode=Final, gby=[$d.traceID@0 as $d.traceID], aggr=[$d.max_ts], lim=[100], metrics=[]
                          FilterExec, expr=[id % 2 == 0]
                            AggregateExec: mode=Partial, gby=[$d.traceID@0 as $d.traceID], aggr=[$d.max_ts], lim=[100], metrics=[]

Is not because AggregateExec could return 100 rows, FilterExec could make that 50, then GlobalLimitExec doesn't get the 100 it was guaranteed in the original plan.
To Reproduce
We need a new test.
Expected behavior
Don't lose rows.
Additional context
No response

I agree this likely needs a test showing incorrect behavior to be actionable

I agree this likely needs a test showing incorrect behavior to be actionable

This query produces incorrect results, which demonstrates the bug.
Unfortunately I needed to add some code to even be able to reproduce it, conflating features and bugs in the PR.
[SQL] select * from (select trace_id, MAX(timestamp) max_ts from traces t group by trace_id) where max_ts != 3 order by max_ts desc limit 2;
[Diff] (-expected|+actual)
-   c 4
-   a 1
+   c 4

Explanation - the raw aggregate on the table looks like:
c 4
b 3
a 1
NULL 0

By filtering on where max_ts != 3 we eliminate the NULL, the b 3, and force the filter to live in between the aggregate and the sort/limit.
Unfortunately, at present, the limit 2 gets pushed past the filter and down into the aggregate, so it only produces 2 rows:
c 4
a 1

Then after the filter happens we're left with 1 row instead of the desired 2. This shows that Filter should not be in the cardinality_preserving white list.

authors: alamb avantgardnerio

repo: apache/datafusion


text:
Support setseed function

Is your feature request related to a problem or challenge?
support select setseed(xxx);
Here is defination in pg. https://www.postgresql.org/docs/current/functions-math.html
setseed ( double precision ) → void

Sets the seed for subsequent random() and random_normal() calls; argument must be between -1.0 and 1.0, inclusive

setseed(0.12345)

It will be helpful to create random but unchanging test data.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

Given DataFusion is multi-threaded and there isn't one global random number generator, and the plans may not run in deterministic order (due to thread scheduling, etc) it is not quite clear to me how we could support this

source: gharchive/issue

authors: alamb my-vegetable-has-exploded

license_type: permissive

license_source: github-api


text:
Regression in 43.0.0: coalesce no longer works between Utf8 and Utf8View columns

Describe the bug
coalesce() no longer considers Utf8 and Utf8View columns as the same type.
To Reproduce
use datafusion::common::arrow::array::{ArrayRef, StringArray, StringViewArray};
use datafusion::common::arrow::record_batch::RecordBatch;
use datafusion::prelude::*;
use std::sync::Arc;

#[tokio::main]
async fn main() {
    let ctx = SessionContext::new();
    let df = ctx
        .read_batch(
            RecordBatch::try_from_iter([
                (
                    "utf8",
                    Arc::new(StringArray::from(vec!["a", "b"])) as ArrayRef,
                ),
                (
                    "utf8view",
                    Arc::new(StringViewArray::from(vec!["a", "b"])) as ArrayRef,
                ),
            ])
            .unwrap(),
        )
        .unwrap();
    df.select(vec![coalesce(vec![col("utf8"), col("utf8view")])])
        .unwrap()
        .collect()
        .await
        .unwrap();
}

Result:
thread 'main' panicked at src/main.rs:25:10:
called `Result::unwrap()` on an `Err` value: Plan("Execution error: User-defined coercion failed with Execution(\"Fail to find the coerced type, errors: Some(Execution(\\\"Expect to get struct but got Utf8\\\"))\") No function matches the given name and argument types 'coalesce(Utf8, Utf8View)'. You might need to add explicit type casts.\n\tCandidate functions:\n\tcoalesce(UserDefined)")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
No error.
Additional context
It worked fine in version 42.2.0.

I vaguely remember that @jayzhan211  worked on coalesece recently, maybe that was releated

It seems the issue is fixed somewhere, I couldn't reproduce the error on the latest commit
Including your test and this
statement count 0
create table t(a varchar, b varchar) as values ('a', 'b'), ('c', 'd');

statement ok
create table t2 as
select
    a as c1,
    arrow_cast(b, 'Utf8View') as c2
from t;

query T
select coalesce(c2, c1) from t2;
----
b
d

I verified that the reproducer query now runs without error on main (will be release in DataFusion 44).
Thank you again for the report @ttencate

authors: alamb jayzhan211 ttencate


text:
Stop copying LogicalPlan and Exprs in SingleDistinctToGroupBy

Which issue does this PR close?

Closes #10295
Rationale for this change

Make the optimizer faster by not copying
What changes are included in this PR?

Use the OptimizerRule::rewrite API
Stop copying LogicalPlan and Exprs in SingleDistinctToGroupBy

Are these changes tested?

Existing CI
Are there any user-facing changes?

No (maybe minimal performance improvements)

Since what I was working on overlapped a bit with the code changes here, I made a PR on this branch to remove some additional clones,
@appletreeisyellow https://github.com/appletreeisyellow/arrow-datafusion/pull/8

There are still some clones but I think they are necessary here because we are building two aggregates from one

@alamb Thanks for the review! I have updated the code according to your feedback

I found whitespace blind diff easier to review: #10527 (files)

Indeed! It greatly reduced my mental matching effort 😄

source: gharchive/pull-request

authors: appletreeisyellow erratic-pattern


text:
Ehcache v3 update

This pull contains changing ehcache 2.10.4 to 3.6.1. ehcache v3 is very different architecturally from v2. Several configuration options were removed, and several more programmatic capabilities removed. v3 also uses generics to stronger type cache instances.
The first place to look to understand the changes made are in /directory-server/core-api/src/main/resources/directory-cacheservice.xml. There is no longer a "default" cache, so each cache used by ApacheDS is explicitly defined. The configuration properties that simply no longer map into the v3 config I left commented out.
There was a lot more work here than I thought. Someone needs to look at this and the changes I had to make to get everything to compile and unit test and vet them all.
It may simply be easier to implement JSR-107 entirely and make caching pluggable.

I fixed the NPE, in {{AbstractBtreePartition}}, {{fetch()}} method :
`
public Entry fetch( PartitionTxn partitionTxn, String id ) throws LdapException
{
try
{
rwLock.readLock().lock();
        if ( id == null )
        {
            id = "";
        }

        Dn dn = buildEntryDn( partitionTxn, id );

`
Now, there are some other issues, OSGi related.
On it.

Ok, after many {{pom.xml}} updates, I think I'm good to go with ehcache 3.6.1.
I'll run a last full build first, to be sure.

I was able to do a full build but some of the junit tests were throwing exceptions in the beforeclass methods, sorry I thought I’d fixed them all :-)
A few of the tests that were very specifically testing the cache configurations no longer work with the more limited runtime controls of ehcache3.
Sent from my iPhone

On Jan 3, 2019, at 10:16 AM, Emmanuel Lécharny notifications@github.com wrote:
I fixed the NPE, in {{AbstractBtreePartition}}, {{fetch()}} method :
`
public Entry fetch( PartitionTxn partitionTxn, String id ) throws LdapException
{
try
{
rwLock.readLock().lock();
    if ( id == null )
    {
        id = "";
    }

    Dn dn = buildEntryDn( partitionTxn, id );

`
Now, there are some other issues, OSGi related.
On it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Merged into trunk !
It was quite a fight... Fixing OSGi tests were just a nightmare, took me hours.

authors: elecharny rsandidfc

repo: apache/directory-server

license_source: bigquery


text:
[Bug] [dolphinscheduler-datasource-api]  There are two jmod issues in this module

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Running org.apache.dolphinscheduler.plugin.datasource.api.utils.CommonUtilsTest#testLoadKerberosConf method in jdk11 has some jmod issues.
PowerMockito.mockStatic(UserGroupInformation.class) method leads to the following bug
Bug Info:
java.lang.ExceptionInInitializerError
	at jdk.internal.reflect.GeneratedSerializationConstructorAccessor5.newInstance(Unknown Source)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:48)
	at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:73)
	at org.mockito.internal.creation.instance.ObjenesisInstantiator.newInstance(ObjenesisInstantiator.java:21)
	at org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:48)
	at org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:29)
	at org.powermock.api.mockito.mockmaker.PowerMockMaker.createMock(PowerMockMaker.java:41)
	at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:53)
	at org.mockito.internal.MockitoCore.mock(MockitoCore.java:62)
	at org.mockito.Mockito.mock(Mockito.java:1951)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.createMethodInvocationControl(DefaultMockCreator.java:108)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.doCreateMock(DefaultMockCreator.java:61)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.createMock(DefaultMockCreator.java:53)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.mock(DefaultMockCreator.java:40)
	at org.powermock.api.mockito.PowerMockito.mockStatic(PowerMockito.java:62)
	at org.apache.dolphinscheduler.plugin.datasource.api.utils.CommonUtilsTest.testLoadKerberosConf(CommonUtilsTest.java:67)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:326)
	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:89)
	at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:310)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:131)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.access$100(PowerMockJUnit47RunnerDelegateImpl.java:59)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner$TestExecutorStatement.evaluate(PowerMockJUnit47RunnerDelegateImpl.java:147)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.evaluateStatement(PowerMockJUnit47RunnerDelegateImpl.java:107)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:298)
	at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:87)
	at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:50)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:218)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:160)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:134)
	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:34)
	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:44)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:136)
	at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:117)
	at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:57)
	at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected java.lang.Class jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(java.lang.String,boolean) throws java.lang.ClassNotFoundException accessible: module java.base does not "opens jdk.internal.loader" to unnamed module @7d907bac
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:340)
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:280)
	at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:198)
	at java.base/java.lang.reflect.Method.setAccessible(Method.java:192)
	at org.powermock.reflect.internal.WhiteboxImpl.doGetAllMethods(WhiteboxImpl.java:1508)
	at org.powermock.reflect.internal.WhiteboxImpl.getAllMethods(WhiteboxImpl.java:1482)
	at org.powermock.reflect.internal.WhiteboxImpl.getMethods(WhiteboxImpl.java:1750)
	at org.powermock.reflect.internal.WhiteboxImpl.getMethods(WhiteboxImpl.java:1789)
	at org.powermock.reflect.internal.WhiteboxImpl.getBestMethodCandidate(WhiteboxImpl.java:1008)
	at org.powermock.core.MockInvocation.findMethodToInvoke(MockInvocation.java:58)
	at org.powermock.core.MockInvocation.init(MockInvocation.java:35)
	at org.powermock.core.MockInvocation.<init>(MockInvocation.java:22)
	at org.powermock.core.MockGateway.doMethodCall(MockGateway.java:155)
	at org.powermock.core.MockGateway.methodCall(MockGateway.java:138)
	at org.apache.hadoop.security.UserGroupInformation.getOsPrincipalClass(UserGroupInformation.java:404)
	at org.apache.hadoop.security.UserGroupInformation.<clinit>(UserGroupInformation.java:412)
	... 48 more

CommonUtils.loadKerberosConf(new Configuration()) method causes the following problem
java.lang.IllegalAccessError: class javax.xml.parsers.FactoryFinder (in unnamed module @0x7a45d714) cannot access class jdk.xml.internal.SecuritySupport (in module java.xml) because module java.xml does not export jdk.xml.internal to unnamed module @0x7a45d714

	at javax.xml.parsers.FactoryFinder.<clinit>(FactoryFinder.java:69)
	at javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java:140)
	at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2516)
	at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2492)
	at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2405)
	at org.apache.hadoop.conf.Configuration.set(Configuration.java:1143)
	at org.apache.hadoop.conf.Configuration.set(Configuration.java:1115)
	at org.apache.dolphinscheduler.plugin.datasource.api.utils.CommonUtils.loadKerberosConf(CommonUtils.java:92)
	at org.apache.dolphinscheduler.plugin.datasource.api.utils.CommonUtils.loadKerberosConf(CommonUtils.java:60)
	at org.apache.dolphinscheduler.plugin.datasource.api.utils.CommonUtilsTest.testLoadKerberosConf(CommonUtilsTest.java:68)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:326)
	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:89)
	at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:310)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:131)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.access$100(PowerMockJUnit47RunnerDelegateImpl.java:59)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner$TestExecutorStatement.evaluate(PowerMockJUnit47RunnerDelegateImpl.java:147)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.evaluateStatement(PowerMockJUnit47RunnerDelegateImpl.java:107)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:298)
	at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:87)
	at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:50)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:218)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:160)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:134)
	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:34)
	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:44)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:136)
	at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:117)
	at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:57)
	at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)

What you expected to happen
passed
How to reproduce
Run the mvn test -e
Anything else
JDK Version : JDK 9+
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!
Already mentioned pr #10239 , will add content in this pr

Related to an issue #10232

Currently only support jdk8 in dolphinscheduler. There are many places to adapt, not just unit test. I think we should open a discussion if you want to support another version of jdk.

I saw the official developer interface prompting support for jdk1.8+ when I raised the issue a few days ago, and then encountered some jmod problems in the process of using 11, and mentioned a pr by the way. This issue is also about jmod, so I want to relate it to the pr I mentioned before. Since the CI of that pr is a bit of a problem, I'd like to temporarily update the official documentation to guide developers on how to develop on the jdk9+ version.

You can submit a pr to change the incorrect description of jdk1.8+ to jdk1.8. But we did not support jdk9 right now.

You can submit a pr to change the incorrect description of jdk1.8+ to jdk1.8. But we did not support jdk9 right now.

I saw it last week and now it has been changed. But I pr have done a lot of work on jmod.

You can submit a pr to change the incorrect description of jdk1.8+ to jdk1.8. But we did not support jdk9 right now.

I saw it last week and now it has been changed. But I pr have done a lot of work on jmod.

You can continue your PR in #10239. There is no conflict between two of them.

repo: apache/dolphinscheduler


text:
I recommend supporting data support across workflows（跨工作流的血缘关系建议）

We have a total of 650 script sources and endpoints, namely, STG and app layer have the most scripts. The middle layer is ods, DWD, dwa and DWR. According to the hierarchical construction flow, we rely on nodes to determine whether to go down or not.If one of the STG tables at the source is broken, or there is a problem with one of the mid-level tables.The upstream and downstream data to be replenishment can not be realized by cross-workflow, this scheduling framework can only be executed in this workflow forward, backward, and only execute itself.Once you cross the workflow, nothing is impossible.
In theory, the parent-child dependencies in each workflow can be connected to form a total blood map.In this way, the subsequent complement, relatively convenient.

我们一共650个脚本 源头和终点 也就是stg、 app层脚本量最多， 中间层 ods、dwd、dwa、dwr啊， 按照分层建流， 依靠节点来当天成功失败来是否往下走。如果源头的一张stg表数据坏了， 或者中层某个表数据有问题。上下游要补数据 靠跨工作流能无法实现重跑， 这个调度框架 只能在本工作流里往前执行、往后执行、仅执行本身。你一旦跨工作流了 ，就无没法实现。
理论上是可以根据各自工作流里面的父子依赖串联起来，形成一个总的血缘图。这样后续要补数，就相对方便了。

good suggestion，already add to Requirement Card
if anybody who like this feature, please reply "+1" or anything you want to reply, like how  to do implement it and so on, please feel free

+1

+1

Great!+1

+1

+1

I am implementing.

+1

waiting!  +1

Is there any progress on this requirement?

+1

+1

+1

Select the current job and its upstream and downstream recursion , then Complement data

authors: JamesBonddu Level1Accelerator MyColorfulDays Rubik-W aikuyun atai-555 dailidong feiyalun jetaime-chen lgcareer swxchappy zhencang zixi0825


text:
Don't write taskPlugin to db in master/worker

Purpose of the pull request

Remove dao in worker
Remove write taskplugin in master/worker

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #10994 (9cf2208) into dev (4ff8eaa) will increase coverage by 0.04%.
The diff coverage is 35.48%.

@@             Coverage Diff              @@
##                dev   #10994      +/-   ##
============================================
+ Coverage     40.31%   40.35%   +0.04%
- Complexity     4858     4862       +4
============================================
  Files           943      943
  Lines         37015    37028      +13
  Branches       4061     4057       -4
============================================
+ Hits          14922    14944      +22
+ Misses        20593    20580      -13
- Partials       1500     1504       +4

Impacted Files
Coverage Δ

...e/dolphinscheduler/server/master/MasterServer.java
0.00% <0.00%> (ø)

...lphinscheduler/service/task/TaskPluginManager.java
0.00% <0.00%> (ø)

...e/dolphinscheduler/server/worker/WorkerServer.java
0.00% <0.00%> (ø)

...che/dolphinscheduler/api/ApiApplicationServer.java
76.47% <84.61%> (+16.47%)
:arrow_up:

...duler/plugin/task/zeppelin/ZeppelinParameters.java
81.25% <0.00%> (-3.37%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-2.78%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (-1.34%)
:arrow_down:

...inscheduler/plugin/task/zeppelin/ZeppelinTask.java
48.05% <0.00%> (-0.64%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.60% <0.00%> (-0.30%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff8eaa...9cf2208. Read the comment docs.

@ruanwenjun I change milestone from 3.0.0 to 3.1.0

@ruanwenjun I change milestone from 3.0.0 to 3.1.0

OK


text:
[Improvement-4375][api] cannot delete yarn queue

[Improvement-4375][api] cannot delete yarn queue
Improvements for unable to delete queues
have delete button to delete the queue
close #4375

good job, can you add Unit Test for this PR?

good job, can you add Unit Test for this PR?

OK, I'll try

good job, can you add Unit Test for this PR?

I added it as well, can you look at it

I need some review

@amaoisnb Hi, please check the failed CI.

@amaoisnb Hi, please check the failed CI.

OK， I'll try

Please check failed UT. @amaoisnb

Codecov Report

Merging #13046 (423b495) into dev (ca760aa) will increase coverage by 0.00%.
The diff coverage is 25.92%.

:exclamation: Current head 423b495 differs from pull request most recent head b7e026f. Consider uploading reports for the commit b7e026f to get more accurate results

@@            Coverage Diff            @@
##                dev   #13046   +/-   ##
=========================================
  Coverage     38.58%   38.58%
  Complexity     4575     4575
=========================================
  Files          1260     1260
  Lines         43748    43729   -19
  Branches       4826     4801   -25
=========================================
- Hits          16878    16871    -7
+ Misses        24998    24986   -12
  Partials       1872     1872

Impacted Files
Coverage Δ

...lphinscheduler/api/controller/QueueController.java
69.23% <0.00%> (-12.59%)
:arrow_down:

...inscheduler/api/service/impl/QueueServiceImpl.java
65.81% <18.18%> (-11.04%)
:arrow_down:

.../org/apache/dolphinscheduler/api/enums/Status.java
100.00% <100.00%> (ø)

... and 33 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @SbloodyS @amaoisnb , FYI, we plan to remove yarn queue management https://github.com/apache/dolphinscheduler/pull/14310#issuecomment-1624817040, do you have any different idea about it?

authors: Radeity SbloodyS amaoisnb codecov-commenter davidzollo


text:
[Fix-16904][Alert]Fix incorrect log description

Brief change log
Fix incorrect log description in org.apache.dolphinscheduler.alert.registry.AlertHeartbeatTask.

Please create an issue first. @justicerling

# @SbloodyS

@justicerling Next time, the title for this kind of PR which only fix the log can be [Chore], like [Chore] Fix incorrect log description in AlertHeartbeatTask, then you don't need to create a issue.

authors: justicerling ruanwenjun


text:
Fix alert plugin instance filter (#7172)

alert plugin could not filter by given
pattern, cause api server do not handle
parameter searchVal, This patch add parameter
searchVal for alert plugin.
fix: #7209

Codecov Report

Merging #7210 (af4b742) into dev (b3efcdf) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #7210      +/-   ##
============================================
- Coverage     40.44%   40.37%   -0.07%
- Complexity     3594     3676      +82
============================================
  Files           647      648       +1
  Lines         26316    27042     +726
  Branches       2926     3032     +106
============================================
+ Hits          10643    10919     +276
- Misses        14699    15086     +387
- Partials        974     1037      +63

Impacted Files
Coverage Δ

.../api/controller/AlertPluginInstanceController.java
7.69% <0.00%> (-0.31%)
:arrow_down:

...i/service/impl/AlertPluginInstanceServiceImpl.java
65.59% <0.00%> (-2.19%)
:arrow_down:

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...eduler/server/master/processor/CacheProcessor.java
17.17% <0.00%> (-71.72%)
:arrow_down:

...erver/master/runner/task/TaskProcessorFactory.java
0.00% <0.00%> (-54.55%)
:arrow_down:

...nscheduler/api/service/impl/LoggerServiceImpl.java
66.15% <0.00%> (-11.63%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
47.27% <0.00%> (-8.19%)
:arrow_down:

...phinscheduler/api/controller/LoggerController.java
7.69% <0.00%> (-6.60%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...r/server/master/runner/task/BaseTaskProcessor.java
0.00% <0.00%> (-4.97%)
:arrow_down:

... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3efcdf...af4b742. Read the comment docs.

e2e CI failed, rebase and force push to re-run it

Still failed e2e and it is odd that show noSuchEelmet in L162
https://github.com/apache/dolphinscheduler/blob/37ba1eb5adb962f6f13825ee0375e82b4823f254/dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowE2ETest.java#L159-L162

Thanks for merging.

authors: codecov-commenter zhongjiajie


text:
[Bug] When obtaining table information in information_schema, the length of the varchar field is -1

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0.0
What's Wrong?
When obtaining table information in information_schema, the length of the varchar field is -1,
However, according to the description of the data type chapter in the official website, the length of varchar is 1-65533
What You Expected?
expects correct datatype length
How to Reproduce?

create DataSource connection
exec show full columns from information_schema.tables``
view

Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Must be a number in   ()

authors: fuchanghai zhu-mingye

repo: apache/doris


text:
feature-wip reuse hdfsFS and decode values in batch without breaking up by null

Proposed changes
PR(https://github.com/apache/doris/pull/13404) introduced that ParquetReader will break up batch insertion when encountering null values, which leads to the bad performance compared to OrcReader. So this PR has pushed null map into decode function, reduce the time of virtual function call when encountering null values.
Further more, reuse hdfsFS among file readers to reduce the time of building connection to hdfs.
Performance Test
Using one thread to query data in table with 10 million rows, and the table is generated from a data generator tool with all types supported by hive, and all values are random, and has a 10% probability of being null.

Type/Time(s)
Before Opt.
After Opt.

tinyint
0.34
0.14

smallint
0.34
0.14

int
0.32
0.13

bigint
0.34
0.15

boolean
0.31
0.13

float
0.32
0.12

double
0.32
0.14

string
2.41
2.31

binary
0.86
0.63

timestamp
1.12
0.88

decimal
0.40
0.20

char
0.44
0.21

varchar
0.44
0.21

date
1.12
0.91

array
0.48
0.46

array
2.33
1.86

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.56 seconds
load time: 555 seconds
storage size: 17154644123 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027023643_clickbench_pr_34509.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.53 seconds
load time: 575 seconds
storage size: 17154644830 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028012100_clickbench_pr_34948.html

authors: AshinGau hello-stephen


text:
feature Statistics persistence

Proposed changes
Issue Number: #13628
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.21 seconds
load time: 614 seconds
storage size: 17182184957 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221103181931_clickbench_pr_39499.html

one suggestion: merge this pr after we recovery nereids regression cases in P0 and P1.
@Kikyou1997 @morrySnow

plz update commit msg to add:

a brief desc about statistics persistence in english
a todo list need to fix in another pr

done

authors: Kikyou1997 englefly hello-stephen


text:
fix fix leaks of connect context

Proposed changes
Problem summary
Remove ConnectContext which built for internal statistics  from threadlocal to avoid memory leaks
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.91 seconds
load time: 434 seconds
storage size: 17171944182 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221123143301_clickbench_pr_51681.html


text:
fix use Long instead of Date to persiste cooldowntime in storage policy

Proposed changes
Issue Number: close #xxx
Problem summary
Previously, we use "Date" type for cooldownTime in StoragePolicy.
But the serialization method of Date type in Gson is different in java8 and java11, which may cause inconsistent meta error.
This PR use Long to save cooldownTime.
And notice that in FE, the cooldownTime is saved in milliseconds, and in BE, it is saved in seconds.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.22 seconds
load time: 444 seconds
storage size: 17171947851 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221123153735_clickbench_pr_51707.html

authors: hello-stephen morningman


text:
fix fix loss of precision when cast to decimalv2 literal

Proposed changes
Issue Number: #14810 case1
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.35 seconds
load time: 646 seconds
storage size: 17123119103 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230104184650_clickbench_pr_73778.html

@Gabriel39 PTAL

authors: hello-stephen luozenglin morningman


text:
Improvement some refactor of process hash table probe impl

Proposed changes
some refactor of process hash table probe impl
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


text:
Docs Add more docs for partial update using native insert statement

Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


text:
feature support creating table columns with type decimal256

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run p0

run pipelinex_p0

run buildall

run buildall

run feut

run feut

maybe we can add using Int256 = wide::Int256?

maybe we can add using Int256 = wide::Int256?

We already had struct UInt256 in uint128.h, in wide_integer.h also had Int256 and UInt256 which are all in the wide namespace, using Int256 = wide::Int256 can be confusing, better to use wide::Int256 when doing calculations.

run buildall

run buildall

run buildall

run buildall

authors: BiteTheDDDDt jacktengg


text:
FixFix analyze sql including key word bug.

backport https://github.com/apache/doris/pull/27321

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buidall

run buildall


text:
enhancement Add support for limiting low priority compaction scheduling

Consider treating non-forced compaction tasks as low priority tasks and limit the concurrency of low priority tasks to reduce the utilization of hardware resources by compaction tasks.

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

authors: Xiaoccer dataroaring


text:
fixnullable info of agg node's intermediate and output slots should be same

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


text:
feat: extract agg in struct info node

Proposed changes
extract agg in struct info node

Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


text:
improvement Optimize the logic of slot mapping generate for performance

Proposed changes
Slot mapping is used for materialized view rewritting
given the relation mapping, the slot mapping is the same
Optimize the slot mapping genarate logic
Cache the slot mapping in materialization context  by realation mapping key
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


text:
[fix](inverted index)Support rename column with inverted index (#38079)

Proposed changes
backport #38079

run buildall

run feut

run p0

run feut

run feut

run p0

run p0


text:
bugfix(cooldown) cancel backup properly when be backup failed #38724

cherry pick from #38724

run buildall

run buildall


text:
fixfix max compute null parts table read (#40046)

bp #40046

run buildall


text:
enchementimport enable_text_validate_utf8 session var

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

run buildall

authors: hello-stephen hubgeter


text:
DRILL-4369: Exchange name and version infos during handshake

There's no name and version exchanged between client and server over the User RPC
channel.
On client side, having access to the server name and version is useful to expose it
to the user (through JDBC or ODBC api like DatabaseMetadata#getDatabaseProductVersion()),
or to implement fallback strategy when some recent API are not available (like
metadata API).
On the server side, having access to the client version might be useful for audit
purposes and eventually to implement fallback strategy if it doesn't require a RPC
version change.

@paul-rogers I missed your comments, but I don't mind doing a follow up. Let me know

Thanks for the responses! Sorry I posted my comments just after the commit. The issues are "nice-to-haves" for the original PR, do not justify another PR.

authors: laurentgo paul-rogers

repo: apache/drill


text:
longSum/Max aggregation in metricsSpec is ignored when setting inputSource type=druid

Tested in druid 0.20.0 with druid.generic.useDefaultValueForNull=false
I have exising druid datasource:

Then I tried to aggregate using ingestion spec
{     "type": "index_parallel",     "spec": {         "dataSchema": {             "dimensionsSpec": {                 "dimensions": [{                         "name": "MONITOR_ID",                         "type": "long"                     }]             },             "metricsSpec": [{                     "fieldName": "L3",                     "name": "L3",                     "type": "longSum"                 }, {                     "name": "CNT",                     "type": "count"                 }],             "granularitySpec": {                 "segmentGranularity": "day",                 "queryGranularity": "hour"             },             "timestampSpec": {                 "column": "POLL_TIME",                 "format": "millis"             },             "dataSource": "z_3600000_0"         },         "ioConfig": {             "appendToExisting": true,             "inputSource": {                 "interval": "2020-11-10T03:26:00.000Z/2020-11-10T03:31:00.000Z",                 "type": "druid",                 "dataSource": "z_60000_0"             },             "type": "index_parallel"         }     } }
The longSum result for L3 is null

Is this a bug or am I missing something?

It may be the same problem as https://github.com/apache/druid/issues/9914. There is a workaround mentioned in that ticket.

The workaround works fine.
Thanks!

repo: apache/druid


text:
Druid loading lookups failed to iterate over fetched data

Druid loading lookup failed to iterate over fetched data.
Affected Version
Starting from v28.0.0 to v30.0.1
Description
Steps to reproduce the issue:
1- Create a loading lookup that has a JDBC connection
2- Wait for a couple of minutes until the lookup is created and registered
3- Try to get the values of the lookup
4- You should see an error saying that it cannot iterate over fetched data

FYI @Akshat-Jain


text:
fix global filter input

Previously the filters would be applied as soon as they passed the try catch of the jsonInput component, not when the user hit apply. The user must now actually click apply for the filter to work. Additionally, I have changed it so now the jsonInput is a controlled component which will allow for the input to be reset upon clicking apply.

Perfect. Thank you for addressing the feedback! 👍

authors: mcbrewster vogievetsky


text:
dubbo-admin ui 登陆后出现strict-origin-when-cross-origin

dubbo-admin ui 登陆后出现strict-origin-when-cross-origin

你是用的什么浏览器？

谷歌浏览器

谷歌浏览器

版本是多少呢 ?

96.0.4664.110（正式版本）

authors: haoyann wolfewf

repo: apache/dubbo-admin


text:
Interface level registry metrics

What is the purpose of the change
Issue Number: https://github.com/apache/dubbo/issues/11707
Brief changelog
add level registry metrics

Codecov Report

Merging #11786 (d400eee) into 3.2 (d093579) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11786      +/-   ##
============================================
- Coverage     69.24%   68.91%   -0.33%
+ Complexity      339        2     -337
============================================
  Files          1744     1535     -209
  Lines         90348    63654   -26694
  Branches      16357     9305    -7052
============================================
- Hits          62564    43869   -18695
+ Misses        22640    15531    -7109
+ Partials       5144     4254     -890

see 3279 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

authors: codecov-commenter wxbty

repo: apache/dubbo


text:
allow user to pass AsyncMethodInfo at runtime.

What is the purpose of the change
allow AsyncMethodInfo on Invocation to override the configured AsyncMethodInfo, to give user a chance to change AsyncMethodInfo on the fly.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #5635 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #5635      +/-   ##
============================================
- Coverage     61.26%   61.18%   -0.08%
  Complexity      422      422
============================================
  Files           922      922
  Lines         37504    37501       -3
  Branches       5432     5432
============================================
- Hits          22975    22945      -30
- Misses        12049    12071      +22
- Partials       2480     2485       +5

Impacted Files
Coverage Δ
Complexity Δ

.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
17.7% <50%> (+0.5%)
0 <0> (ø)
:arrow_down:

.../remoting/transport/netty4/NettyServerHandler.java
56.81% <0%> (-11.37%)
0% <0%> (ø)

...va/org/apache/dubbo/remoting/TimeoutException.java
22.22% <0%> (-11.12%)
0% <0%> (ø)

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
79.16% <0%> (-8.34%)
0% <0%> (ø)

...dubbo/remoting/exchange/support/DefaultFuture.java
79.27% <0%> (-7.21%)
0% <0%> (ø)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

...e/dubbo/remoting/transport/netty/NettyChannel.java
52.27% <0%> (-3.41%)
19% <0%> (-1%)

...pache/dubbo/registry/support/AbstractRegistry.java
77.15% <0%> (-3%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyClientHandler.java
64.4% <0%> (-1.7%)
0% <0%> (ø)

...in/java/org/apache/dubbo/common/utils/IOUtils.java
87.8% <0%> (-1.09%)
0% <0%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aed3ae...b74507b. Read the comment docs.


text:
使用graph图时，两个节点之间的多条连线可以设置偏移量吗

Version
5.0.1
Reproduction link
https://echarts.apache.org/examples/zh/editor.html?c=graph-simple
Steps to reproduce
节点1和节点2之间有两条连线，但是现在这两条连线重叠在一起了
What is expected?
期望不用设置curveness也可以做到两条线互不干扰
What is actually happening?
两条连线重叠在一起了

You can set autoCurveness to be a number greater than 2. I think the document has some problem because the default value of this options seems to be 0.

You can set autoCurveness to be a number greater than 2. I think the document has some problem because the default value of this options seems to be 0.

You can try remove all the lineStyle.curveness in the options, and set autoCurveness to true.
The documentation is missing some configuration instructions and will be updated later.

You can try remove all the lineStyle.curveness in the options, and set autoCurveness to true.
The documentation is missing some configuration instructions and will be updated later.

Doc fixed in https://github.com/apache/echarts-doc/pull/159

can I make it straight? My requirement is I want to use straight lines instead of curveness lines, and I want straight lines that won't cover each other.

authors: Ovilia chj-damon wf123537200

repo: apache/echarts