text:
Add Plan block for the control plane VMs to the example Terraform configs for Azure

What this PR does / why we need it:
Problem Overview
If a VM is using an image that comes from the Azure Marketplace, the VM must have a Plan block defined and populated, otherwise, provisioning fails with the following error:
│ Error: Code="VMMarketplaceInvalidInput" Message="Creating a virtual machine from Marketplace image or a custom image sourced from a Marketplace image requires Plan information in the request. VM: '<redacted>'."

This wasn't a problem before because we only supported Ubuntu until #2266, and Ubuntu doesn't require Plan to be specified.
Problem Statement
Depending on where the image is coming from, the Plan block:

MUST NOT be preset if the image is a built-in Azure image (i.e. not coming from the marketplace)

You can't provide null or empty strings, the block must be omitted entirely
Ubuntu and CentOS are those images in our case

MUST be present if the image is coming from the marketplace

RHEL, Rocky Linux, and Flatcar are images coming from the marketplace

We need to make Terraform to omit the Plan block if OS is Ubuntu or CentOS, and populate the block if it's an image coming from the marketplace.
Solution
This is not easy out of the box with Terraform. I decided to utilize Dynamic Blocks since this seems to be the only way you can dynamically set or remove a block.
To make Dynamic Blocks work, the object must be iterable, i.e. you can't use a simple object, you have to use a list or a map.
The image_references variable has been changed:

Information about the image is moved to a new nested object (image)
A new nested object (plan) type of list is added with information about the Plan

If a Plan is not supposed to be used, the list is empty
If a Plan is supposed to be used, the list must contain ONLY ONE Plan to be used

We have no validation for this, but I don't think anyone should provide more than one Plan

This approach seems to integrate very well with the dynamic Plan block.
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
NONE

Documentation:
NONE

/test pull-kubeone-e2e-azure-default-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-centos-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rhel-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rockylinux-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-default-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-centos-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rhel-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rockylinux-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-centos-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3


text:
Update DigitalOcean CSI to v4.4.1

What this PR does / why we need it:
Update DigitalOcean CSI to v4.4.1.
Which issue(s) this PR fixes:
xref #2406
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change? Then add your Release Note here:
Update DigitalOcean CSI to v4.4.1

Documentation:
NONE

/retest

/test pull-kubeone-e2e-digitalocean-default-install-containerd-external-v1.23.14
/test pull-kubeone-e2e-digitalocean-default-install-containerd-external-v1.24.8
/test pull-kubeone-e2e-digitalocean-default-install-containerd-external-v1.25.4

/test pull-kubeone-e2e-digitalocean-default-install-containerd-external-v1.23.14

source: gharchive/pull-request

authors: ahmedwaleedmalik xmudrii

repo: kubermatic/kubeone

license_type: permissive

license_source: github-api


text:
Add additional safeguad/validation for the master taint

What this PR does / why we need it:
This is a follow up on #2688 to:

add safeguard that would fail kubeone apply if there's the master taint on nodes running 1.25+
add API validation that would forbid using the master taint on clusters running 1.25+

What type of PR is this?
/kind cleanup
Does this PR introduce a user-facing change? Then add your Release Note here:
NONE

Documentation:
NONE

/test pull-kubeone-e2e-aws-default-stable-upgrade-containerd-from-v1.24.10-to-v1.25.6
/test pull-kubeone-e2e-aws-default-stable-upgrade-containerd-from-v1.25.6-to-v1.26.1


text:
Fix azure refresh token apiserver id

Fixes #135
Currently, the refresh token logic is hardcoded to use the general Microsoft Graph application id as the apiserver.  This fails if there's a mismatch in the kubeconfig, specifically in the audience in the access token being refreshed.  Instead, the new code will dynamically load this from the local kubeconfig as with the other request values and use that to submit the refresh call.
Additionally, this sets the ADAL API version to 1.0 to keep the behavior consistent with the kubernetes go client azure authentication flow.  (Namely, the string spi: being included for the audience)
I also updated the tests to use the Microsoft Graph app id as that was the prior behavior the tests were relying on.

/assign @yliaog

Codecov Report

Merging #170 into master will decrease coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   93.44%   93.41%   -0.03%
==========================================
  Files          13       13
  Lines        1389     1398       +9
==========================================
+ Hits         1298     1306       +8
- Misses         91       92       +1

Impacted Files
Coverage Δ

config/kube_config.py
87.53% <0%> (-0.23%)
:arrow_down:

config/kube_config_test.py
95.28% <100%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd1301...0b20833. Read the comment docs.

/lgtm
/approve

authors: codecov-io fooka03 yliaog

repo: kubernetes-client/python-base


text:
Default all container storage to /var/lib/containers/storage

containers/storage is defaulting to /var/lib/containers/storage
for image and containers storage.  It is also defaulting to
/var/run/containers/storage for all runtime.  The defaults
for CRI-O should match so that lots of other tools that use
containers/storage can share the same storage.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com

git-validation is failing. The issue is being discussed. We can wait till tomorrow to see.

Needs rebase.

LGTM

LGTM

authors: mrunalp rhatdan runcom

repo: kubernetes-incubator/cri-o


text:
Continue switching from libkpod to libpod

Refactored rmi, images, diff, and history.
Made fixes to kpod images in the way it was handing the templates as well as printing the image names
Signed-off-by: umohnani8 umohnani@redhat.com

@rhatdan @mheon PTAL. Let me know if I am missing some things that need to be moved to libpod as well.

I'll do a more thorough review after lunch, but minus one big reservation this looks like a good step forward.

Is there stuff we should be deleting from libkpod that is no longer used?

@rhatdan We moved all the image code to libkpod/image, right? So I don't think we're removing anything from libkpod itself.

Ok, the faster get rid of libkpod the better.

@rhatdan @mheon should copy_data.go and copy_ref.go be under libpod/images or just under libpod?
Currently there are copies in both paths for some reason.

@umohnani8 Put it in libpod, and try to remove the versions in libpod/image. We want to remove libpod/image eventually.

Got rid of most of the stuff from libpod/images the only file left is image_data.go, which is needed by inspect and container_data while we wait to get the container commands shifted over.
I renamed image.go to runtime_img.go to follow the convention of runtime_ctr.go and runtime_pod.go.
@rhatdan @mheon PTAL

LGTM assuming happy tets.  Thanks for the touch ups!

/test all

There's a ton of code here, and I definitely think the interface isn't the best right now. But we can look into that in later refactoring, and this almost eliminates the libpod/image subpackage. LGTM, let's get this merged.

/test all

@rhatdan @mrunalp all tests pass

LGTM

authors: TomSweeneyRedHat mheon rhatdan umohnani8


text:
RBAC role

Can you provide the cluster role definition for this to work?

This is a duplicate of #233 (the issue also contains example RBAC).

source: gharchive/issue

authors: hjacobs jyoungs

repo: kubernetes-incubator/external-dns

license_source: bigquery


text:
Make DNSimple tolerant of unknown zones

Like other providers, the DNSimple provider should ignore any records
that belong to zones outside of its control.

@jbowes Thanks! 👍

authors: jbowes linki


text:
Default controller manager limits

Fixes: #1254

Codecov Report

Merging #1318 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1318   +/-   ##
=======================================
  Coverage   37.79%   37.79%
=======================================
  Files          67       67
  Lines        4231     4231
=======================================
  Hits         1599     1599
  Misses       2408     2408
  Partials      224      224

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c509be...f38910b. Read the comment docs.

@jorge07 Thanks for the PR!
Honestly I'm still unsure this is the safe defaults. Ideally there should be a heuristic to calculate necessary request/limit that is proportional to number of resources managed by k8s. But let's start by seeing how it works in practice.

I've this patch in production since 3 weeks. I'll report any issue related with this.

@jorge07 I greatly appreciate your support!

authors: codecov-io jorge07 mumoshu

repo: kubernetes-incubator/kube-aws


text:
Image update

This gets us back to a working state again with the User and image tag defaulting changes that happened upstream.
This also takes advantage of using the image annotation of its original name to behave more correctly when listing images.
cc @yifan-gu @squeed
Fixes #49

LGTM, except a small comment regarding validation (that perhaps we want to tackle later).

A few small questions, but they are mostly more general. Seems reasonable to me.

I fixed a few more issues with the code that I uncovered (specifically returning empty, nil for "image does not exist case and defaulting the originalname with a tag too).
I think this is good to go.

authors: euank lucab squeed

repo: kubernetes-incubator/rktlet


text:
Congito integration - Error with action type 'authenticate-cognito'

Enabling the cognito integration in an existing Ingress with ALM produces the following error:
E0213 12:55:36.186978       1 controller.go:217] kubebuilder/controller "msg"="Reconciler error" "error"="failed to reconcile listeners due to failed to reconcile listener due to ValidationError: Action type 'authenticate-cognito' must be one of 'redirect,fixed-response,forward,authenticate-oidc'\n\tstatus code: 400, request id: e3cc4d71-d848-454a-b59e-ab9054497ba5"  "controller"="alb-ingress-controller" "request"={"Namespace":"test","Name":"test"}

The part of manifest related to it is the following:
metadata:
  annotations:
    alb.ingress.kubernetes.io/auth-type: cognito
    alb.ingress.kubernetes.io/auth-scope: openid
    alb.ingress.kubernetes.io/auth-session-timeout: "3600"
    alb.ingress.kubernetes.io/auth-session-cookie: AWSELBAuthSessionCookie
    alb.ingress.kubernetes.io/auth-on-unauthenticated-request: authenticate
    alb.ingress.kubernetes.io/auth-idp-cognito: '{"UserPoolArn": "arn:aws:cognito-idp:eu-central-1:xxx:userpool/eu-central-xxx","UserPoolClientId":"xxx","UserPoolDomain":"xxxx"}'
    alb.ingress.kubernetes.io/certificate-arn: ' arn:aws:acm:eu-west-3:xxx:certificate/xxxx'

I've seen that the message Action type 'authenticate-cognito' must be one of could be from AWS. Is there missing any annotation?

@guillemtp
Hi, which controller version are you using? I cannot reproduce this with v1.1.5:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/auth-type: cognito
    alb.ingress.kubernetes.io/auth-scope: openid
    alb.ingress.kubernetes.io/auth-session-timeout: "3600"
    a: b
    alb.ingress.kubernetes.io/auth-session-cookie: AWSELBAuthSessionCookie
    alb.ingress.kubernetes.io/auth-on-unauthenticated-request: authenticate
    alb.ingress.kubernetes.io/auth-idp-cognito: '{"UserPoolArn": "arn:aws:cognito-idp:us-west-2:283511030707:userpool/us-west-2_OBdkeJ0Za","UserPoolClientId":"xxxx","UserPoolDomain":"m00nf1sh"}'
    alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:us-west-2:283511030707:certificate/f58895f2-e71c-4bd1-8f12-cad3efd7b51c

I used above setting, and it works fine 🤔

I confirm that I'm using the version v1.1.5.
I attach the whole ingress file, if some other parameter could have an impact.
 iVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type": "redirect", "RedirectConfig": { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301"}}'
    alb.ingress.kubernetes.io/auth-type: cognito
    alb.ingress.kubernetes.io/auth-scope: openid
    alb.ingress.kubernetes.io/auth-session-timeout: "3600"
    alb.ingress.kubernetes.io/auth-session-cookie: AWSELBAuthSessionCookie
    alb.ingress.kubernetes.io/auth-on-unauthenticated-request: authenticate
    alb.ingress.kubernetes.io/auth-idp-cognito: '{"UserPoolArn": "arn:aws:cognito-idp:eu-central-1:*****:userpool/****","UserPoolClientId":"****","UserPoolDomain":"******"}'
    alb.ingress.kubernetes.io/certificate-arn: ' arn:aws:acm:eu-west-3:*******:certificate/**********'
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80},{"HTTPS": 443}]'

  name: ingres-monitoring
  namespace: kube-monitoring
spec:
  rules:
  - host: alertmanager.example.com
    http:
      paths:
      - backend:
          serviceName: ssl-redirect
          servicePort: use-annotation
      - backend:
          serviceName: alertmanager-main
          servicePort: web
  - host: grafana.example.com
    http:
      paths:
      - backend:
          serviceName: ssl-redirect
          servicePort: use-annotation
      - backend:
          serviceName: grafana
          servicePort: http
  - host: prometheus.example.com
    http:
      paths:
      - backend:
          serviceName: ssl-redirect
          servicePort: use-annotation
      - backend:
          serviceName: prometheus-k8s
          servicePort: web

Analyzing the query traced in Cloud Trail and the options in AWS console, I deduce that is caused because Cognito User Pool is in a different region.

@guillemtp
Thanks, cognito cannot across region :D, but the error message given by cognito is somehow misleading..


text:
role board link

This link takes you off site. Is it possible to display an icon (e.g. https://icons8.com/icons/set/external-link) to denote that it's an external link?

/remove-lifecycle stale

repo: kubernetes-sigs/contributor-site


text:
Add new strategy ‘RemoveContainersNotReadyPods’

When the node network or  CRI is error ， the init container is always initialized  when deploy app .
It may be caused by image download failure or insufficient IP , in this case, pods and containers will always be in this state
But the pod is not in the failed state, if you try to reschedule to another node in this case, the image may be downloaded successfully and the IP may be sufficient，the container will be in a ready state or succeed.
I think it is necessary to add a non-ready  policy for containers, because in this case rescheduling may make the container run successfully
for example：
apiVersion: "descheduler/v1alpha1"
kind: "DeschedulerPolicy"
strategies:
  "RemoveContainersNotReadyPods":
     enabled: true
     params:
       containersNotReadyPods:
         reasons:
         - "ContainersNotReady"
         includingInitContainers: true
         minPodLifetimeSeconds: 600

Would this need to be an entirely new strategy? Or is it just a status phase we can parse and check in PodLifetime or RemoveFailedPods?

Would this need to be an entirely new strategy? Or is it just a status phase we can parse and check in PodLifetime or RemoveFailedPods?

RemoveFailedPods currently only support pods phase is failed ,if support other phase(Running and Pending) or PodLifetime support pods phase is failed and parameter support filter reasons .
In this case, there is no need to add new strategies to solve the above problems

/assign
I can create a PR once #834 is reviewed/approved/merged

I went ahead and included the change in #834 since it's stalling

On second though, PodLifeTime is likely not a good candidate for this given that it is included in conditions at some point in time.
For example, take the following example:
  conditions:
    - type: Initialized
      status: 'True'
      lastProbeTime: null
      lastTransitionTime: '2019-02-13T20:31:37Z'
    - type: Ready
      status: 'False'
      lastProbeTime: null
      lastTransitionTime: '2019-02-13T20:31:37Z'
      reason: ContainersNotReady
      message: 'containers with unready status: [...]'
    - type: ContainersReady
      status: 'False'
      lastProbeTime: null
      lastTransitionTime: '2019-02-13T20:31:37Z'
      reason: ContainersNotReady
      message: 'containers with unready status: [...]'
    - type: PodScheduled
      status: 'True'
      lastProbeTime: null
      lastTransitionTime: '2019-02-13T20:31:37Z'

The container was not ready at some point in time, but eventually, it was scheduled.

@a7i so this is only reported through the conditions? We could probably do some logic to check that it's the most recent condition. But I think that could be enough for a new strategy (RemovePodsWithConditions?)

/remove-lifecycle stale
/assign
@damemi this would be a good opportunity for me to create a new plugin and see how that goes.

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

authors: a7i damemi wxuedong

repo: kubernetes-sigs/descheduler


text:
Add a config option to control adopting pre-existing resources

Fixes: https://github.com/kubernetes-sigs/federation-v2/issues/805
Context: https://github.com/kubernetes-sigs/federation-v2/pull/715#discussion_r273306716
/cc @marun @irfanurrehman

@marun, Addressed your comment. PTAL.

Is it worth adding a test that validates this behavior? The existing test for adoption could likely be the basis for a non-adoption test, at least as far as setup goes.

I think adding an e2e test case needs lot of effort and involve following things:

Start the Federation Control plane (SUT) with SkipAdoptResource config set to true. (probably as a new step in CI).
Get the FederationConfig from SUT.
Create exactly the same resource in one of member cluster which you gonna propagate.
Check that, If SkipAdoptResource config is true, propogation should fail to that cluster.

So now, I am contemplating whether it would be good idea to just add Unit test for dispatcher. wdyt @marun ?

@shashidharatd I think it could be simpler if the test were implemented for CRDs and only run in cluster-scope.  Then the sync controller could be started with namespace-scope with adopt=false.  I'll let you address that in a subsequent PR.

/lgtm

@shashidharatd I think it could be simpler if the test were implemented for CRDs and only run in cluster-scope. Then the sync controller could be started with namespace-scope with adopt=false. I'll let you address that in a subsequent PR.

Thanks @marun for the merge. I will explore this and submit a pr ASAP. For what it's worth here is some proof of it working when tested manually with adopt=false.
  Normal   CreateInCluster        23s               federateddeployment-controller  Creating Deployment "default/fr1" in cluster "cluster1"
  Normal   CreateInCluster        2s (x4 over 23s)  federateddeployment-controller  Creating Deployment "default/fr1" in cluster "cluster2"
  Warning  CreateInClusterFailed  2s (x4 over 22s)  federateddeployment-controller  Failed to create Deployment "default/fr1" in cluster "cluster2": Resource pre-exist in cluster
  Normal   UpdateInCluster        2s (x3 over 22s)  federateddeployment-controller  Updating Deployment "default/fr1" in cluster "cluster1"

@shashidharatd I'm glad to see the event logging is proving useful :)
I don't think the test is absolutely required right now, I'm just generally mindful of our need to be more test-focused.

authors: marun shashidharatd


text:
Replace cert-manager with internal cert

We don't want a dependency on cert-manager and it also complicates the user experience by requiring they install it on their cluster beforehand. We should migrate to using internal certs.
See https://github.com/kubernetes-sigs/kueue/pull/265 for example

It would be best to prioritize this and have it as part of 0.1.0 release.

Hello, jobset community :)
Do you plan to provide the component config like kueue to enable configurable cert settings such as whether the users use internal cert or cert-manager and so on?
https://github.com/kubernetes-sigs/kueue/blob/9ca57c86cf06c11a94a2d5b7badf60233a51a2f2/config/components/manager/controller_manager_config.yaml

Hello, jobset community :)
Do you plan to provide the component config like kueue to enable configurable cert settings such as whether the users use internal cert or cert-manager and so on?
https://github.com/kubernetes-sigs/kueue/blob/9ca57c86cf06c11a94a2d5b7badf60233a51a2f2/config/components/manager/controller_manager_config.yaml

Hello and welcome :)
Yes, for sure, do you mind opening an issue to track it?

Hello, jobset community :)
Do you plan to provide the component config like kueue to enable configurable cert settings such as whether the users use internal cert or cert-manager and so on?
https://github.com/kubernetes-sigs/kueue/blob/9ca57c86cf06c11a94a2d5b7badf60233a51a2f2/config/components/manager/controller_manager_config.yaml

Hello and welcome :)
Yes, for sure, do you mind opening an issue to track it?

Oh, sounds great!
I will create an issue, and I will help with introducing the component config to the JobSet.

authors: ahg-g danielvegamyhre tenzen-y

repo: kubernetes-sigs/jobset


text:
allow retries for special users or all users on tests

Description
What problem are you trying to solve?
I tend to run into a fair bit of flake when running the tests. It would be nice to be able to retest so that when I ask for reviews the reviewers can just look and see that the checks are green and passing for everything. This way we waste less of everyones time :)
Its nice that anyone can run the tests on each commit, but if the tests fail I cannot retry the tests even if I know its failing due to flakey reasons. Sometimes I end up just repushing to run the tests and get them to pass before asking for review which seems like the wrong solution.
Either allowing everyone to retry, or having a role/scoped permissions to allow certain trusted members of the community to re-run tests would be great.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Yeah, this is the whole point of /retest. I'm wondering if there's a way to enable this with GHA. If not, we may have to fully shift to K8s-infra

authors: Bryce-Soghigian jonathan-innis

repo: kubernetes-sigs/karpenter


text:
[metrics] Register ClusterQueueByStatus metric.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Register ClusterQueueByStatus metric.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Register ClusterQueueByStatus metric.

/release-note-edit
Fix missing metric cluster_queue_status

/release-note-edit
Fix missing metric cluster_queue_status

authors: alculquicondor mbobrovskyi

repo: kubernetes-sigs/kueue


text:
Custom client has product name acting as a link that does nothing

Describe the bug
In our custom client we have assigned the product title which is displayed in the top tab stripe to the left of the "Tab 1".  The appearance of the text is fine, but if the user moves the mouse pointer over it, the cursor changes to the "finger" and it highlights like a link.  Examining the DOM shows that it is wrapped in an <a> tag, hence getting that behavior.
Steps to reproduce the behavior

Hover over product title in the top tab stripe.

Expected behavior
The text is just text, not a link.
System

Kui version: 10.3.z
Operating system: Red Hat ubi container at RHEL-8

This comes from the  instance. We are using the default logoComponent which is indeed a, but we also set no logoProps, which means that the anchor has no href. So, sane CSS rules would give no hover effect. And indeed this is the case for stock Kui. But perhaps other CSS rules may change this behavior?
We can change the logoComponent to span to help this out.

authors: mark-nc starpit

repo: kubernetes-sigs/kui


text:
Add Metrics for SELinux profiles

This PR adds metrics updates for the SELinux profile functionality (mentioned in https://github.com/kubernetes-sigs/security-profiles-operator/issues/276#issuecomment-839636908)
# HELP security_profiles_operator_selinux_profile_error_total Counter about selinux profile errors.
# TYPE security_profiles_operator_selinux_profile_error_total counter
security_profiles_operator_selinux_profile_error_total{reason="CannotUpdatePolicyStatus"} 1

# HELP security_profiles_operator_selinux_profile_total Counter about selinux profile operations.
# TYPE security_profiles_operator_selinux_profile_total counter
security_profiles_operator_selinux_profile_total{operation="delete"} 1
security_profiles_operator_selinux_profile_total{operation="update"} 6

Add Metrics for SELinux profiles

@saschagrunert @jhrozek @JAORMX

/ok-to-test

Cool stuff! Docs have to be updated and linters have to be fixed now, too. :)

Thanks, I'll fix em

Fixed the last linter failure

@saschagrunert any idea why the Github actions didn't run in this PR?

Codecov Report

Merging #470 (2148677) into master (12d2a6a) will increase coverage by 1.22%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   36.70%   37.92%   +1.22%
==========================================
  Files          23       23
  Lines        1087     1110      +23
==========================================
+ Hits          399      421      +22
- Misses        673      674       +1
  Partials       15       15

/kind feature

authors: JAORMX codecov-commenter mrogers950 saschagrunert


text:
bump chart versions to 0.2.2

^

/test pull-build-all-images-for-ppc64le

/lgtm

repo: kubernetes-sigs/service-catalog


text:
ParseGroupKind parses back to front

The method ParseGroupKind found here reads as if the string you pass in should be ordered as "Group.Kind" (and the argument name similarly implies this). However, the actual parsing of the string switches the order, instead returning a GroupKind struct with the first half of the string stored as the Kind and the second half stored as the Group.
This is to say, the string apps.Deployment will be parsed as GroupKind{group: Deployment, kind: apps} which is incorrect.
Here's an example using the Go playground: https://go.dev/play/p/G1L4qJwGzru

The input parameter is in the format of either Kind.group.com or Kind.version.group.com.
so ParseGroupKind() method logic is correct.
Ref:  https://github.com/kubernetes/apimachinery/blob/v0.27.2/pkg/runtime/schema/group_version.go#L43

Ah, I was thrown off by the name and didn't realise the convention was to have them in that order. Thanks for clarifying!

repo: kubernetes/apimachinery


text:
fix typo in owncloud/README.md

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/retest

repo: kubernetes/charts


text:
[incubator/kubernetes-vault] add RBAC support and enable more configuration

What this PR does / why we need it:

adds RBAC support,
split and move vault values into configMap directly mapping to kubernetes-vault ConfigMap for easier understanding and better customization,

@bbriggs

/assign @scottrigby

/assign

/lgtm

🎉

authors: bbriggs nazarewk unguiculus


text:
make batch member update configurable

What this PR does / why we need it:
make batch member update configurable
Octavia supports batch member updates, however some provider drivers for Octavia do not support batch update of pool members. In that case, the pool members are added/removed by occm.
batch-member-update can be set in cloud-config file.
Special notes for reviewers:
Batch member update is enabled by default for Octavia.

Release note:

NONE

/assign @lingxiankong
@lingxiankong  can you please review. Thanks

/retest

/ok-to-test

Hi @hamzazafar , I am not sure which driver you are using, but from Octavia official API document (https://docs.openstack.org/api-ref/load-balancer/v2/index.html?expanded=batch-update-members-detail#batch-update-members) I didn't see anything mentioned that different drivers may have different implementations.
As an official cloud provider that supports official openstack API, I don't think we should support any 'non-standard' openstack API. So, rather than adding an extra config option to OCCM, could you please provide more information about your driver and maybe talk to Octavia team about the API support?
/hold

authors: hamzazafar jichenjc lingxiankong

repo: kubernetes/cloud-provider-openstack


text:
Add a /metrics endpoint to submit-queue for external monitoring

/cc @eparis

Is this coming back?

Yes, I'm working on it.

recomputing cla status...

I'm going to close this until we figure out whether we're using Prometheus.

authors: eparis rmmh test-foxish

repo: kubernetes/contrib


text:
add myself to blunderbuss for pkg/client/leaderelection

I'd like to field these initially

LGTM

Won't take affect until we build & restart-- @eparis has been doing that, I think.

I can kick it once the PR goes in

That's fine, you should be able to 'make' from head, upload the image to gcr, and then do a rolling update to rc.yaml.

(rc.yaml in your local tree will be updated when you do the make)

authors: eparis lavalamp mikedanese


text:
Client: Lint command

The helm lint NAME command runs a series of checks on NAME, which may be either a packaged chart (foo-1.1.1.tgz) or a chart directory (/my/chart).
Potential linting operations:

Check Chart.yaml syntax and contents
Check that templates contains files in a known format
Check that there is a README file

Where do the tests run (client or server)?

authors: jackgr technosophos

repo: kubernetes/deployment-manager


text:
[Federation][kubefed][aws kops cluster] Cluster stays in unknown state & TLS handshake error

 Issue by csarora
Tuesday Feb 28, 2017 at 16:51 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/42263

Kubernetes version :
Client Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.2", GitCommit:"08e099554f3c31f6e6f07b448ab3ed78d0520507", GitTreeState:"clean", BuildDate:"2017-01-12T04:57:25Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.2", GitCommit:"08e099554f3c31f6e6f07b448ab3ed78d0520507", GitTreeState:"clean", BuildDate:"2017-01-12T04:52:34Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}
Environment:

Cloud provider or hardware configuration: AWS
OS (e.g. from /etc/os-release): Ubuntu

root@ip-172-31-26-62:/home/ubuntu# kops get clusters
NAME                    CLOUD   ZONES
k8east.spopt.co.uk      aws     us-east-1a
k8s.test                aws     eu-west-1a,eu-west-1b,eu-west-1c

root@ip-172-31-26-62:/home/ubuntu# kubectl get clusters
NAME      STATUS    AGE
k8s       Unknown   32m
k8stest   Unknown   1h

cat cluster.yaml >>
apiVersion: federation/v1beta1
kind: Cluster
metadata:
  name: k8stest
spec:
  serverAddressByClientCIDRs:
    - clientCIDR: "172.31.0.0/16"
      serverAddress: "https://api.k8s.test"
  secretRef:
    name: k8s

I created secret k8s using below command :
 kubectl config use-context k8s.test
 kubectl --context=k8s.test config view --flatten --minify > /root/.kube/k8s.test/kubeconfig
 kubectl --context="k8s.test"   --namespace=federation-system   create secret generic k8s   --from-file=/root/.kube/k8s.test/kubeconfig

Logs from apiserver : fedcluster-apiserver-3532249059-cmp48
2017-02-28T16:19:36.163944507Z I0228 16:19:36.163851       1 logs.go:41] http: TLS handshake error from 10.123.45.1:24237: EOF
2017-02-28T16:19:46.164331830Z I0228 16:19:46.164239       1 logs.go:41] http: TLS handshake error from 10.123.45.1:24241: EOF
2017-02-28T16:19:56.164934170Z I0228 16:19:56.164819       1 logs.go:41] http: TLS handshake error from 10.123.45.1:24253: EOF
2017-02-28T16:20:06.164256376Z I0228 16:20:06.164132       1 logs.go:41] http: TLS handshake error from 10.123.45.1:24265: EOF
2017-02-28T16:20:11.064377515Z I0228 16:20:11.064303       1 logs.go:41] http: TLS handshake error from 10.123.45.1:24269: remote error: tls: unknown certificate authority

Logs from control manager fedcluster-controller-manager-3452268026-ulyz6:
2017-02-28T16:19:44.897940307Z E0228 16:19:44.897889       1 reflector.go:199] k8s.io/kubernetes/federation/pkg/federation-controller/service/servicecontroller.go:266: Failed to list *v1.Service: Get https://fedcluster-apiserver/api/v1/services?resourceVersion=0: dial tcp 100.71.86.69:443: i/o timeout
2017-02-28T16:19:57.116456809Z E0228 16:19:57.116345       1 clustercontroller.go:117] Error monitoring cluster status: Get https://fedcluster-apiserver/apis/federation/v1beta1/clusters: dial tcp 100.71.86.69:443: i/o timeout
2017-02-28T16:20:15.521432571Z E0228 16:20:15.521335       1 reflector.go:199] k8s.io/kubernetes/federation/pkg/federation-controller/util/federated_informer.go:294: Failed to list *v1beta1.Cluster: Get https://fedcluster-apiserver/apis/federation/v1beta1/clusters?resourceVersion=0: dial tcp 100.71.86.69:443: i/o timeout
2017-02-28T16:20:15.524803604Z E0228 16:20:15.524762       1 reflector.go:199] k8s.io/kubernetes/federation/pkg/federation-controller/daemonset/daemonset_controller.go:260: Failed to list *v1beta1.DaemonSet: Get https://fedcluster-apiserver/apis/extensions/v1beta1/daemonsets?resourceVersion=0: dial tcp 100.71.86.69:443: i/o timeout

 Comment by csarora
Thursday Mar 09, 2017 at 16:18 GMT

Any updates what could be the issue?

 Comment by kargakis
Tuesday Jun 20, 2017 at 17:52 GMT

@kubernetes/sig-federation-misc @kubernetes/sig-aws-misc

 Comment by fejta-bot
Monday Jan 08, 2018 at 18:26 GMT

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

cc @csarora

repo: kubernetes/federation


text:
GPU metrics on kubernetes

The GPU task will be supported on kubernetes soon.
I wonder how to add GPU metrics on heapster, so the users can view the usage of GPU information via Grafana+InfluxDB.

I am curious about this, too. IMO, this is mainly related to cAdvisor or libcontainer. Heapster is just collecting time series data from cAdvisor. :)

It seems that @jianzhangbjz has already post an issue about this in cAdvisor#1436.

@andyxning thanks for the correction. I will follow the cAdvisor issue.

we can reopen once cAdvisor gets support

authors: DirectXMan12 andyxning pineking

repo: kubernetes/heapster


text:
Heapster Pod ExitCode:255 status with restart loop

I tried to run heapster using
https://github.com/kubernetes/heapster/blob/master/docs/influxdb.md
and changed Grafanaservice yaml to use NodePort rather than LoadBalancer. After executing kubectl command on the directory, I get following output for my pods:
NAME                    READY     STATUS         RESTARTS   AGE
heapster-zxvi0          0/1       ExitCode:255   14         22m
infludb-grafana-frz46   2/2       Running        0          22m
kube-dns-v8-nyura       4/4       Running        0          2d
kube-dns-v8-socln       4/4       Running        2          2d
kube-dns-v8-tx505       4/4       Running        0          59m
Needless to say i am unable to access web ui.
Here is my modified grafana-service.yaml
apiVersion: v1
kind: Service
metadata:
labels:
kubernetes.io/cluster-service: 'true'
kubernetes.io/name: monitoring-grafana
name: monitoring-grafana
namespace: kube-system
spec:
type: NodePort
ports:

port: 80
targetPort: 3000
selector:
name: influxGrafana

I suspect heapster is being killed by the kernel because of memory limits. Can you try removing the memory limits from heapster cofiguration file?

Hi, I don't have any memory limit set in my config file. Also, I tried running only heapster-rc alone and it is unable to start. docker ps -a shows no trace of heapster container whatsoever. My docker version in 1.7.1, build 2c2c52b-dirty. And the cluster is running on coreos.

What version are you running? Can you post heapster logs? Also post the
output of dmesg from your host.
On Tue, Oct 13, 2015 at 8:18 AM, prateekrastogi notifications@github.com
wrote:

Hi, I don't have any memory limit set in my config file. Also, I tried
running only heapster-rc alone and it is unable to start. docker ps -a
shows no trace of heapster container whatsoever. My docker version in
1.7.1, build 2c2c52b-dirty. And the cluster is running on coreos.
—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/heapster/issues/622#issuecomment-147747662
.

i was running 7.3.0 of coreos with k8 1.0.5. After your response I used dmesg and saw some error lines in it, so i tried upgrading the whole cluster first os and then k8, but it broke down whole setup. Then, i created a new setup with latest realeases and heapster working fine on it. Unfortunately, i was not able to log dmesg at that time, nor able to comprehend how mere upgrade broke down whole cluster setup. Thanks for your efforts anyway.

authors: prateekrastogi vishh


text:
add another three types of sink in overview.md

add another three types of sink in overview.md, includes:
kafka, hawkular , riemann

Can one of the admins verify this patch?

ok to test

LGTM

thanks, @piosz . Would you please help me to review another PR?https://github.com/kubernetes/heapster/pull/733   ^_^

@huangyuqi I assigned @mwielgus to it.

thanks so much, @piosz ^_^

authors: cadvisorJenkinsBot huangyuqi piosz


text:
PROPOSAL: Chart preview Mode

Hi,
I have been doing some modifications lately to example and custom charts and I have noticed that it does not seem to be a simple way to preview how the templates will look like after executing and interpolating the values.
The linter today does a full template rendering, taking your values from Values.yaml and Chart.yaml and letting you know if any of your functions returns nothing, but I think we should go an step further showing what the full output will look like.
I think that this is important because:

Template rendering has become an important part of the chart lifecycle, happening for every chart install.
We support piped sprig functions. It would be great to know not just that they do not crash but that they are doing what we expect them to do.
Namespaces (Global, Values., Charts., dependency charts) has added great features but also complexity in terms of overrides.
Partial templates are flexible but (in my opinion) prone to errors during conception.

I do not propose to add it as part of the linter command, it might make sense to have something like:
helm preview [chartName] which could:

Output to STDOUT the file name and its rendered output.
or, output into another directory. I think we should not do this because it can be confusing since helm classic used to work this way.

What's your workflow today to test that the modifications in your chart make sense?  (using dry-run? checking pod definitions via kubectl?)
Thoughts?
Regards,
Miguel

I believe the --dry-run and --debug flags on the install command do just that! @migmartri
helm [master]$ bin/helm install docs/examples/nginx/ --dry-run --debug
Created tunnel using local port: '58818'
Server: ":58818"
Chart path: /Users/michellenoorali/gocode/src/k8s.io/helm/docs/examples/nginx
NAME:   wise-lizzard
INFO:   Tue Jun 28 13:03:04 2016
CHART:  nginx 0.1.0
MANIFEST:
---
# Source: templates/deployment.yaml
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  # This uses a "fullname" template (see _helpers)
  # Basing names on .Release.Name means that the same chart can be installed
  # multiple times into the same namespace.
  name: wise-lizzard-nginx
  labels:
    # The "heritage" label is used to track which tool deployed a given chart.
    # It is useful for admins who want to see what releases a particular tool
    # is responsible for.
    heritage: "Tiller"
    # This makes it easy to search for all components of a release using kubectl.
    release: "wise-lizzard"
    # This makes it easy to audit chart usage.
    chart: "nginx-0.1.0"
spec:
  replicas: "1"
  template:
    metadata:
      labels:
        app: wise-lizzard-nginx
        release: "wise-lizzard"
    spec:
      containers:
      - name: wise-lizzard-nginx
        # Making image configurable is not necessary. Making imageTag configurable
        # is a nice option for the user. Especially in the strange cases like
        # nginx where the base distro is determined by the tag. Using :latest
        # is frowned upon, using :stable isn't that great either.
        image: "nginx:1.11.0"
        imagePullPolicy: IfNotPresent
        ports:
        - containerPort: 80
        # This (and the volumes section below) mount the config map as a volume.
        volumeMounts:
        - mountPath: /usr/share/nginx/html
          name: wwwdata-volume
      volumes:
        - name: wwwdata-volume
          configMap:
            name: wise-lizzard-nginx

---
# Source: templates/svc.yaml
# This is a service gateway to the replica set created by the deployment.
# Take a look at the deployment.yaml for general notes about this chart.
apiVersion: v1
kind: Service
metadata:
  name: wise-lizzard-nginx
  labels:
    heritage: "Tiller"
    release: "wise-lizzard"
    chart: "nginx-0.1.0"
spec:
  ports:
  - port: "8888"
    targetPort: 80
    protocol: TCP
    name: http
  selector:
    app: wise-lizzard-nginx

---
# Source: templates/configmap.yaml
# This is a simple example of using a config map to create a single page
# static site.
apiVersion: v1
kind: ConfigMap
metadata:
  name: wise-lizzard-nginx
  labels:
    release: "wise-lizzard"
    app: wise-lizzard-nginx
    heritage: "Tiller"
data:
  # When the config map is mounted as a volume, these will be created as
  # files.
  index.html: "
Hello

This is a test
"
  test.txt: test

helm [master]$

Awesome, that's exactly what I wanted!
I am wondering if we should either document it at a higher level (I have just found it in the Nginx example), encapsulate it into its own command or integrate it with the linter.

Sweet. Glad it helps!
On documenting at a higher level: were you thinking on the quickstart guide or maybe having a more advanced user scenario document? Those flags are very useful. How can we make them more apparent?
On encapsulating it into its own command: For this case, I think keeping the functionality on install as flags makes the most sense from a user perspective rather than having to learn/remember an additional command. What do you think? Do you think the flags are confusing or straightforward? Do you think
On integrating it with linter: could you expand a little more on that?
cc/ @technosophos

I think it might make more sense to be added to the charts document under the "using help to manage charts" section.
https://github.com/kubernetes/helm/blob/master/docs/charts.md#using-helm-to-manage-charts

One thing to note about --dry-run is that it still goes to the server for resolution.

In my opinion, and taking into account the early stage of the project, it would be enough to just add some visibility to this command/flags combo in the current documentation as suggested above in the comments.
Eventually, I'd prefer a separated command or sub-command so in that way it gets explicitly-documented. It will also avoid people to install a wip chart when what they wanted was to just debug it (if you miss the ---dry-run).

One thing to note about --dry-run is that it still goes to the server for resolution.

It is true that adds some latency, but from that perspective I think it is fine (for now). I am wondering if you have other concerns related to hitting the server, like system overload, bottleneck, etc.

Yeah, I can definitely see the value in a separate command or sub command and avoiding installing a wip chart is a really good point.

@technosophos @vaikas-google now that we have the helm inspect command, an option like --render/generate/full could render the chart client-side. What do you think?

Closing in favour of #978

authors: michelleN migmartri prydonius technosophos

repo: kubernetes/helm


text:
update docs to demonstrate best practices in regards to named templates

This PR modified named template documentation:

update helper examples to demonstrate namespace best practices

highlight that templates names are global at the top of the documentation

address #3487

Hi @mueedc
This is looking great! I notice that you have moved the helper naming explanation closer to the top (thanks). Can we simply and reword the second occurrence of that same text? Perhaps leading with something like "As noted above, template names are global... etc"

Oh yeah absolutely. Gotta be DRY with our code and docs


text:
Deleting new-machines.yaml.

There used to be a plan for this file, but it's obsolete now.

This change is

repo: kubernetes/kube-deploy


text:
kubectl logs command with label selector does not show all entries (results truncated)

What happened:
Executed command:
kubectl logs -n kube-system -l k8s-app=kube-dns
Only received a subset of the logs from the pods with the label.
Manually collecting the logs pod-by-pod shows many more results. It's as if using the label selector causes the results to be truncated.
Seems to only return 20 lines max.
What you expected to happen:
Expected to see all results for all log entries of all pods.
How to reproduce it (as minimally and precisely as possible):

Execute command: kubectl logs -n kube-system -l k8s-app=kube-dns
Compare with results of kubectl logs -n kube-system <dnsPodName>

Anything else we need to know?:
N/A
Environment:

Kubernetes client and server versions (use kubectl version):

kubectl version --short
Client Version: v1.18.2
Server Version: v1.17.7

Cloud provider or hardware configuration: Azure Kubernetes Service (AKS)
OS (e.g: cat /etc/os-release):

NAME="Ubuntu"
VERSION="20.04 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal

/assign

See help info in kubectl logs --help:
cmd.Flags().Int64Var(&o.Tail, "tail", o.Tail, "Lines of recent log file to display. Defaults to -1 with no selector, showing all log lines otherwise 10, if a selector is provided.")

Thank you @zhouya0 , makes sense - as expected this behaves properly for me with:
kubectl logs -n kube-system -l k8s-app=kube-dns --tail -1
Thanks for your help and the clarification!

repo: kubernetes/kubectl


text:
Issue with k8s.io/docs/concepts/cluster-administration/certificates/

This is a Bug Report

Problem:
Be sure the replace the values marked with angle brackets with real values you want to use
Proposed Solution:
Be sure to replace the values marked with angle brackets with real values you want to use
Page to Update:
https://kubernetes.io/...

Thanks for pointing out this mistake @kingmax-chan

So to fix this, change “Be sure the replace” to “Be sure to replace”.
/good-first-issue

authors: kingmax-chan sftim

repo: kubernetes/website


text:
kubernetes/website release 1.22 freeze

This issue freezes the k/website repo and should remain open till 1.22 is officially released!
The release is scheduled to happen tomorrow 4th of August and No PRs are allowed to merge until the release PR has successfully merged.
If there are any questions, please contact me or anyone from the docs release team
cc: @ashnehete @carlisia @chrisnegus @ritpanjw
/sig release

/triage accepted

freeze over!
/close


text:
Job completion-mode documentation has an unclarified note about a 'rare' condition

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/workloads/controllers/job/#completion-mode mentions

Note that, although rare, more than one Pod could be started for the same
index, but only one of them will count towards the completion count.

Can it be clarified why that note is needed? And if the pod is started, will it run to completion, or aborted before running or ... ?
Proposed Solution:
@alculquicondor  proposes via https://github.com/kubernetes/enhancements/issues/2214

We can clarify that it will be aborted.

Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/job

As for why the note was added...
Due to the async nature of kubernetes, it's possible that we don't observe the creation of Pods in a timely manner. We have some in-memory guards in place to prevent double creation. So it's very unlikely that you would observe such behavior and we simply don't make guarantees.
Not sure how to express all of the above in a user-friendly way :) I'll wait for suggestions from tech-writers.

/sig apps
/language en
Help wanted, but this isn't necessarily easy enough to merit /hel
/remove-kind bug
/triage accepted

Thanks for the report @heyleke

I know of one instance kubernetes/kubernetes#109429. I think it's about the garbage collection, but I don't have enough evidence.
/lifecycle frozen

It occurrence many times in my cluster.
https://github.com/kubernetes/kubernetes/issues/109429#issuecomment-1537780017

/assign

/unassign

authors: alculquicondor heyleke mrgiles sftim wu0407


text:
[ja] Translate reference/glossary/api-eviction.md into Japanese

This is a Feature Request
What would you like to be added
Translate content/en/docs/reference/glossary/api-eviction.md into Japanese.
Why is this needed
This page has not been translated.
Comments
/language ja
/assign

/triage accepted


text:
Broken link need to fix

This is a Bug Report
Problem:
visit this page pull-requests
when we click on this Kubernetes Enhancement Proposal process it returns 404 not found page,so this needs to be fix.
Proposed Solution:
correct link of md file require to provide.
Page to Update:
https://www.kubernetes.dev/docs/guide/pull-requests/
/language en
/assign

Hey @amolmote Can I work on this issue, If you are not already.


text:
[ja] The hyperlinks are not getting redirected to the Japanese version of Website

This is a Bug Report

Problem:
In the Japanese website, two hyperlinks ( --kubeconfig and cheat sheet ) on the Command line tool (kubectl) page are not getting redirected to the Japanese version of the respective pages.
Proposed Solution:
The Japanese version of these two pages is already available, so I will simply make these two hyperlinks redirect to the respective Japanese page.
Page to Update:
https://deploy-preview-39991--kubernetes-io-main-staging.netlify.app/ja/docs/reference/kubectl/

Comments
I want to work on this issue.
/assign

/language ja

Ok, thank you @NitishKumar06 I'll keep this in my mind from now on 😀.


text:
Chinese link in the English docs to "Overview of Cloud Native Security: Cloud provider security"

https://kubernetes.io/docs/concepts/security/overview/#cloud-provider-security

Huawei Cloud
https://www.huaweicloud.com/securecenter/overallsafety

Consider using the English-language version of the link for Huawei Cloud:
https://www.huaweicloud.com/intl/en-us/securecenter/overallsafety
The current link is Chinese.

Page related to issue: https://kubernetes.io/docs/concepts/security/overview/
/language en

/assign

/kind bug
/good-first-issue
/triage accepted

Anyone is welcome to work on this. @bogarams, it sounds like you plan to open a pull request?
(other contributors: it's polite to try to liaise with @bogarams ahead of starting work)

@sftim , yes i would like to work on this and going to open a pull request.

/assign

Hey Please assign this issue to me, I am a new contributor

Anyone is welcome to work on this.
(it's polite to try to liaise with contributors who've previously expressed an interest in working on this, and ideally to consider collaborating)

/assign

@deepak4566 ,  Kindly next time liaise with previous assigned user first before you assign youself and start work. This will show some courtesy.

authors: PRYNSH1224 bogarams deepak4566 dipesh-rawat nnlkcncff sftim


text:
improve layout of Kubernetes online documentation to make better use of the screen space

The whole Kubernetes documentation on https://kubernetes.io/docs/ and below wastes a lot of screen space with blank space not providing any information.

on the right hand side by some options that are barely needed. 8 lines of text, using up appr 40% of the browser window. And if I resize the browser window to increase the space available for the main documentation are (to get more "real text"), the right hand side area is increased as well!
there is a large gap between the main documentation area and its left and right edge
line spacing could be reduced as well, providing more text on the same screen space. Please use book-style line spacing for the online documentation.

/area web-development

it is build on Hugo Docsy themes. so it is difficult to change the entire layout now

/remove-lifecycle rotten


text:
Move Hardening guides out of concepts section

Regarding this comment https://github.com/kubernetes/website/pull/45080#discussion_r1751203955, we should consider moving security hardening guides out of concepts. It cannot be moved to references either. Should we move it to a new section?

/sig security

Out of all the sections we have, the concepts section feels like the least bad home.

it's explaining what you might need to consider to secure your cluster
it is not task documentation where following it unquestioningly produces a specific outcome
it is not really a tutorial or a setup guide
it is not reference documentation

@sftim what are your thoughts about moving them to docs/setup/best-practices https://kubernetes.io/docs/setup/best-practices/ ?

@sftim what are your thoughts about moving them to docs/setup/best-practices https://kubernetes.io/docs/setup/best-practices/ ?

We shouldn't move them to a section about good practice for large clusters. Even small clusters may need to have strong information security.

That section is not specific for large clusters 🤔 . For example since we already have Enforcing pod security standards, maybe the hardening guides could also be alongside this doc

Ah, I was wrong! Maybe that is OK then.

The content of the page fits into the best practices folder.
content/en/docs/setup/best-practices
For example, all sub-sections in the section "kube-scheduler configuration" describe some best practices while using those command line options.

authors: AnshumanTripathi network-charles sftim


text:
Graduate BlockVolume feature to beta

docs for feature https://github.com/kubernetes/features/issues/351

@wongma7 Now that this is in beta, does it need more documentation surrounding it?

@xiangpengzhao @zhangxiaoyu-zidif -- what's the status of this? These docs are overdue and we haven't heard any status updates on the associated feature issue.
I'm removing this from the milestone per this comment.
If you feel this is incorrect, please respond ASAP.
/milestone clear

@wongma7 please confirm @justaugustus concern :)

/open

/reopen

Hi @wongma7, can you please complete this PR and let us know when it's ready for review? The docs deadline is approaching fast so we want to start reviewing PRs ASAP.

oops i rebased on master instead of dev zzzz

/approve

/lgtm

authors: justaugustus tfogo wongma7 xiangpengzhao zparnold


text:
Update link of spec in network-policies

Old link points to https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#spec-and-status which will be removed after 2019-07-01 or the release of kubernetes 1.15, whichever comes first.
New link: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

CLA signed

sure
/lgtm

/approve

authors: danwinship kenveski tengqm


text:
Tasks/Configure DNS for a Cluster: add some descriptions about CoreDNS

Hi!
The document seems a little bit old.
Added some descriptions about CoreDNS.
Could you review it?
Thanks,

/lgtm
/approve


text:
Updating links and product name for JA language files for IBM Cloud

Updating links
Update deprecated product name Bluemix
Treating separately as follow up to #18083

@artberger ping

/lgtm

/approve

authors: artberger inductor oke-py


text:
Correct links 2016 10 00 helm charts making it simple to package and deploy apps on kubernetes

Correct links in 2016-10-00-Helm-Charts-Making-It-Simple-To-Package-And-Deploy-Apps-On-Kubernetes

/assign

This is just a link update PR so as a PR wrangler I can go ahead and approve this.
/lgtm
/approve


text:
Fix broken link to Xilinx FPGA device plugins

Fixes the broken Xilinx FPGA device plugins link on https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/
/sig docs
/language en
/language id
/language zh
/language ko

/lgtm
for EN, ZH changes

/lgtm
for the Korean content.

/approve

I can see that this PR is a trivial one. It fixes a broken link. That is great.
However, as you can see from the review history, a PR that spans more than one language is very difficult to review/approve. We have an explicit guideline on this.
Imagine how this proposal can be quickly processed if you had divided into several PRs per language?

@tengqm Thank you for pointing it out. That's absolutely right and I'd like to follow the guideline. Regarding this PR, it should be separated into multiple PRs (one per language) even though there are some comments already, correct?

@kiyoshim55 You can either solicit reviews from the ID localization team for this PR, or you can close it and reopen new ones. Completely up to you. Thanks for understanding.

Thank you @tengqm for your advice! I will close this PR and reopen new ones for each language in accordance with the guideline.

Please check out the followings:
[en] #21977
[id] #21978
[zh] #21979
[ko] #21980
Closing this PR.

authors: kiyoshim55 seokho-son tengqm


text:
Retitle “Kubernetes API Aggregation Layer” concept

The old title “Extending the Kubernetes API with the aggregation layer” sounds more like a task page than a concept, so I reworded.
/wg api-expression

Preview: https://deploy-preview-29229--kubernetes-io-main-staging.netlify.app/docs/concepts/extend-kubernetes/api-extension/apiserver-aggregation/

Changes look good.
https://deploy-preview-29229--kubernetes-io-main-staging.netlify.app/docs/concepts/extend-kubernetes/api-extension/
/lgtm

authors: jihoon-seo kbhawkey sftim


text:
[zh]fix broken link in Security For Windows Nodes

En PR: https://github.com/kubernetes/website/pull/34061
related issue: https://github.com/kubernetes/website/issues/34033

/lgtm
/approve

authors: howieyuen tengqm


text:
Correct description of Probe.initialDelaySeconds

initialDelaySeconds applies to all kinds of probes, but the descriptions
used so far mentioned either only "liveness" or only "liveness and
readiness", but never startup probes.

/hold
I'm afraid that https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/ is automatically generated. Please file an issue against Kubernetes instead to report that the API documentation is not correct.

Hey @geraldmayr,
I've found the (probably) source of this string for you:
https://github.com/kubernetes/kubernetes/blob/182e0989ecd3b4307e29815c8dd9527aea10f15e/staging/src/k8s.io/api/core/v1/types.go#L2190-L2196
Please open a PR in that repo, I'm closing this PR now.
/close

authors: Sea-n geraldmayr sftim


text:
[JA] Fix broken links for KubeletConfiguration struct

Hi!
For some configmap and secret documentation pages, links to the KubeletConfiguration struct are broken.
It's due to the usage of the docsbranch parameter which is evaluated to main. But the main branch doesn't exist in the kubernetes repo.
This PR replaces the parameter to an hardcoded value: master.
You can check that the link is currently broken here:
https://kubernetes.io/fr/docs/concepts/configuration/secret/#les-secrets-montés-sont-mis-à-jour-automatiquement (latest version)
https://v1-23.docs.kubernetes.io/fr/docs/concepts/configuration/secret/#les-secrets-montés-sont-mis-à-jour-automatiquement (v1.23 version)
This PR is a split of https://github.com/kubernetes/website/pull/34902

/lgtm
/assign @nasa9084


text:
statefulset: explicit apiVersion and kind for volumeClaimTemplates

The conversion introduced by https://github.com/kubernetes/kubernetes/pull/87706 caused ServerSide-apply to generate a diff when the applied volumeClaimTemplates item has no apiVersion  or kind .
This PR recommends setting apiVersion  and kind .
See https://github.com/argoproj/argo-cd/issues/11143.

...or is SSA doing something wrong? cc @apelisse to check?

@lavalamp You are right, and I don't see why SSA is going thru conversion (we are using apps/v1 StatefulSet).

Anyone having a idea how to fix diff in ServerSideApply with volumeClaimTemplates?
Ping @liggitt @wojtek-t 🙇

I mostly understand what's going on but a few details are still a little fuzzy. What are some minimal steps to reproduce so I can take a better look? Thanks.

It looks like the issue is coming from the way ArgoCD uses SSA (https://github.com/argoproj/argo-cd/issues/11143#issuecomment-1421323586). Closing PR.

authors: apelisse lavalamp sathieu


text:
document the PodAndContainerStatsFromCRI feature

Fixes: #33509

/sig node

@haircommander Can you review for correctness?

/lgtm
thanks @tzneal, @bobbypage PTAL

thank you for writing this up!
/lgtm

authors: bobbypage haircommander sftim tzneal


text:
Fix link to v1.10 docs

@jimangel Ah, nice catch :) I just noticed that this s/\//./ fixed that specific link, and figured I'd help out. Good to see it already taken care of!


text:
Putting all Installation Methods and links together in the README.

Describe your changes
In the main README file, the Installation has been provided as a sub-section under the TL;DR section. :point_down:

If we take a closer look at the README of the project, again under the Tutorials sub-section of the Options and examples section, the same content has been provided. :point_down:
Moreover, the links provided in the Installation section under the TL;DR do not forward to the correct places.

I have made a separate sub-section for installation under the TL;DR section, and kept all the methods to install under it.  Otherwise, it might have be confusing for new viewers viewing the project.
Screenshots

Issue ticket number and link
close #641
I think this PR can also close
#639
Checklist before requesting a review

[x] No code updation have been done.

Please open the PR against the dev branch (Unless the PR contains only documentation changes)
Opening the PR directly against master branch, since only documentation changes have been done.

Created a PR as I thought it cleans up the README :smile: :wave:

We prefer having the installation per environment right near the central copy-paste installation.

authors: dwertent noviicee

repo: kubescape/kubescape


text:
asdas

Overview

sad

/support

repo: kubescape/regolibrary


text:
Add PR template(s)

We need a PR template to guide folks for all they need to mention while making a PR.

Pls assign this to me

I think @abh139 you already had this covered in the issue #6 description.

No that is just for Issue template, for PR we need to create another issue for easy reviewing

@abh139 as soon as the PR for the issue template is merged please do a PR for PR template

@AvineshTripathi Sure

authors: AvineshTripathi SuperAayush abh139 anubha-v-ardhan

repo: kubesimplify/website

license: MIT


text:
Bug 2099608: Display Dynamic instead of DynamicB for dynamic disk size

📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2099608
Display 'Dynamic', not 'DynamicB' string in the VM Disks card or VM Disks tab - for the disk's Size info,
in cases when the disk size is provided dynamically.
🎥 Demo
Before:
'DynamicB' in the VM Overview Disks card, Size column:

'DynamicB' in the VM Disks tab:

After:

/lgtm

authors: hstastna yaacov

repo: kubevirt-ui/kubevirt-plugin


text:
WIP check master state

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

https://github.com/kubevirt/ipam-extensions/pull/56 this might fix it
so far so good, lets wait for it to finish

repo: kubevirt/ipam-extensions


text:
allow setting of libguestfs paths from env variables

What this PR does / why we need it:
allow setting of libguestfs paths from env variables
this will help to set different paths in ds
Release note:
NONE

/lgtm

/cherrypick release-v0.12

/retest

/retest

/retest

/retest

/retest

/retest

/lgtm

/retest

/cherrypick release-v0.9.0

repo: kubevirt/kubevirt-tekton-tasks


text:
fix virt-launcher panic after migration cancellation on crio

What this PR does / why we need it:
In some cases, destination virt-launcher panics after migration cancellation, on CRIO.
This PR handles the panic and let the virt-launcher exit cleanly.
Fixes #2243
NONE

@vladikr do you have a way to reproduce this? Does this have something to do with attempting to shutdown a VMI while migration is taking place?  I'm just curious if there's some issue with shtudown order of libvirt or something that's triggered this.

@vladikr do you have a way to reproduce this? Does this have something to do with attempting to shutdown a VMI while migration is taking place? I'm just curious if there's some issue with shtudown order of libvirt or something that's triggered this.

Yeah, I can reproduce it, but only on cri-o for some reason. I thought that maybe it takes longer for the watchdog ticker to exit. But I'm not sure yet.

/cherrypick release-0.13

authors: davidvossel rmohr vladikr

repo: kubevirt/kubevirt


text:
Add skip condition for CPUManager=false

Prior to this change, one CPUManager test assumed virt-handler would be
running on every node, including master nodes. In clusters where this
assumption is false, this test is invalid.
Release note:
NONE

/lgtm

authors: kbidarkar stu-gott


text:
janitorial: clean cluster-clean.sh

What this PR does / why we need it:
hack/cluster-clean.sh seems to have peculiar complexities which I'd like to understand and simplify
Special notes for your reviewer:
I have tested this with
make cluster-up
make cluster-sync
make functtest; ^C
make cluster-sync  # this first calls cluster-clean target

and it seemed to clean the cluster all right.
Release note:
NONE

No idea what is this failure on the sig-network lane. Let's see if rebase makes it go away.
 15:14:20: cp: cannot stat 'bazel-out/k8-fastbuild/bin/tools/perfscale-audit/perfscale-audit_/perfscale-audit': No such file or directory

@dhiller do you think this PR is helpful?

/retest

authors: dankenigsberg dhiller


text:
[flaky] Troubleshoot failing snapshot test case

What this PR does / why we need it:
Use Satisfy matcher to simplify the code and
improve the failure message. Additionally add correct offset.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm

/test pull-kubevirt-e2e-k8s-1.22-sig-storage
/test pull-kubevirt-e2e-k8s-1.23-sig-storage
/test pull-kubevirt-e2e-k8s-1.24-sig-storage
/test pull-kubevirt-e2e-k8s-1.24-sig-storage-dv-gc

Just re-runing storage tests, maybe I can catch the failure

/test pull-kubevirt-e2e-k8s-1.24-sig-network
/test pull-kubevirt-e2e-k8s-1.23-sig-compute

The flakiness was fixed by: https://github.com/kubevirt/kubevirt/pull/8539
Anyway this PR is still needed and provides a few useful additions (cleanup/reporting)

/approve

/retest

authors: ShellyKa13 brybacki mhenriks


text:
[release-0.58] tests, console: Prevent NewExpecter negative timeout scenario

What this PR does / why we need it:
This is a manual cherry-pick of #9497 and the proposed change in #9515.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

None

/uncc @rmohr @kbidarkar
/cc @ormergi @AlonaKaplan

/retest-required

/retest-required

/approve

/retest-required

authors: AlonaKaplan orelmisan


text:
Change naming convention for appliance

If this is considered a good direction, I will prepare a PR that adjusts the CI jobs accordingly.

@andreabolognani I'd be fine by changing the name, but... :) We need a way to deprecate and remove old appliances in the google store. I don't want that we run out-of-space because of the weekly CI job for the appliance. I don't recall how this work, but before merging this we need to clarify it.
I'm aware that I was relying on the same versioning and overwriting with new builds, and this needs to be changed!

@andreabolognani I'd be fine by changing the name, but... :) We need a way to deprecate and remove old appliances in the google store. I don't want that we run out-of-space because of the weekly CI job for the appliance. I don't recall how this work, but before merging this we need to clarify it. I'm aware that I was relying on the same versioning and overwriting with new builds, and this needs to be changed!

That's a good point. I guess we could perform this cleanup as part of the same weekly CI job, or another one with a similar schedule. Once we have the timestamp included in the filename, it should be easy to implement a cleanup policy like "only keep the five most recent builds".

We should have a similar mechanism for the rpms, and I'd like to rely on the same process. I asked @brianmcarey to help me finding how we handle the rpm repository.
We need to take into account that we also have old branches where we do backports. I don't think we can only keep the last five most recent builds. We would also need to periodically update the KubeVirt WORKSPACE and this isn't currently the case.

UPDATE: Additionally, we need to understand which versions of the appliance are used and which are not. Otherwise, if we remove them the build will fail when it tries to download the appliance.

I wonder if we could just clone kubevirt.git on the fly and the run something like
git log -p WORKSPACE | grep appliance- | grep ^+

to find out which versions have been used in KubeVirt and should thus not be removed. Not the fastest method, but should give accurate results without need for maintenance.

As already mentioned, we need to take into account also old branches. So, probably yes but with a list of branches where we actively develop and apply fixes.

We should have a similar mechanism for the rpms, and I'd like to rely on the same process. I asked @brianmcarey to help me finding how we handle the rpm repository.

I think the process is not the same, because the mirroring of RPMs happens as a consequence of the WORKSPACE being updated, so by definition all of those need to be kept around. For the appliance, we do weekly builds and not all of those are picked up by KubeVirt.

We need to take into account that we also have old branches where we do backports.

Aren't the backports just cherry-picks of commits from the main branch? So if an appliance was never used on main, it won't be used on any maintenance branch either.

I don't think we can only keep the last five most recent builds.

I was thinking of the last five builds among those that are not used in KubeVirt. If any of the builds was ever referenced by KubeVirt, then we'd need to keep it around.

We would also need to periodically update the KubeVirt WORKSPACE and this isn't currently the case.

I guess you could set up a way for PRs to automatically be opened against KubeVirt, but I was not thinking that far ahead O:-)
I just assumed that having KubeVirt pick up a new version of the appliance would be a manual affair, same as picking up updated RPMs currently is.

We should have a similar mechanism for the rpms, and I'd like to rely on the same process. I asked @brianmcarey to help me finding how we handle the rpm repository.

I think the process is not the same, because the mirroring of RPMs happens as a consequence of the WORKSPACE being updated, so by definition all of those need to be kept around. For the appliance, we do weekly builds and not all of those are picked up by KubeVirt.

You are right about the copy and update. But I don't know how they remove the old rpms once they aren't used anymore. I'd be interested to understand how they clean-up the old versions.

We need to take into account that we also have old branches where we do backports.

Aren't the backports just cherry-picks of commits from the main branch? So if an appliance was never used on main, it won't be used on any maintenance branch either.

Correct, we can remove appliances that were never picked. But we need to consider that different branches might have different appliance versions.

I don't think we can only keep the last five most recent builds.

I was thinking of the last five builds among those that are not used in KubeVirt. If any of the builds was ever referenced by KubeVirt, then we'd need to keep it around.

Ok, still not quite sure where to store/get this information

We would also need to periodically update the KubeVirt WORKSPACE and this isn't currently the case.

I guess you could set up a way for PRs to automatically be opened against KubeVirt, but I was not thinking that far ahead O:-)
I just assumed that having KubeVirt pick up a new version of the appliance would be a manual affair, same as picking up updated RPMs currently is.

Ok, yes and I'd like to keep it this way if possible :)

authors: alicefr andreabolognani

repo: kubevirt/libguestfs-appliance


text:
Alignment and Color change

BEFORE-

AFTER-

Pull Request Test Coverage Report for Build 1278

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.35%

Totals

Change from base Build 1507:
0.0%

Covered Lines:
3426

Relevant Lines:
3759

💛  - Coveralls

Pull Request Test Coverage Report for Build 1510

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.35%

Totals

Change from base Build 1507:
0.0%

Covered Lines:
3426

Relevant Lines:
3759

💛  - Coveralls

@rawagner Please review.

authors: AyushAmbastha coveralls

repo: kubevirt/web-ui-components


text:
Admission webhook for instance CRD

What would you like to be added:
This is designed in KEP-18
We want to ensure atomicity of plan executions so when one plan is running, nobody should update the instance and also trigger another plan. This is what admission webhook will help us with.

One functionality that is desired which this effort might be able to address is to add validation in state transitions, e.g. configuration updates or manual CRD mutation. A concrete use-case is preventing an operator instance from having its name changed, which would certainly cause issues at the base technology level, and possibly at the KUDO/k8s level as well.

also validate that the instance parameters are correct - that they contain all the parameters that did not contain defaults in OV

@mpereira unfortunately catching name changes is not really possible :( name change on a resource basically means that you're making a request on another resource, that you're creating so I am not sure how we can really prevent that :( same goes for namespace... there is no notion of moving resources between namespaces in k8s

@alenkacz I see. I guess that example was an extreme edge case that might not be too important assuming operator users aren't carelessly manually editing KUDO-created k8s objects.

authors: alenkacz mpereira

repo: kudobuilder/kudo


text:
Fix loop in check_serial_port when connected via usbip

When I tried running the integration over usbip, I encountered a problem in check_serial_port method. It looks like the reader thread is reading too fast and it reads the writer's  data before it gets flushed to the alarm control unit, so the unit never gets the data and never responds. As a quick fix, I added a sleep to the reader loop to slow down reading.
Actually is there a reason why the code is parallel? Can't the same thing be done in serial manner?

It looks it will probably not break anything so I'll merge it.

authors: PeterPalenik kukulich


text:
Other localization support (TH example)

We should support other localization languages like TH.

@suraneti Thanks for the PR https://github.com/kulapio/libra-wallet-poc/pull/43,
So the next language should be Chinese I think

Sir help me I am not english speking

repo: kulapio/libra-wallet-poc


text:
cart function issue

Dear @Malith3019
please sole the cart function  calculation issue also change the currency to LKR
thank you
@kulasekara02

@Malith3019
plz    do it asap

Done
please check and let me know
know


text:
Consider adding traffic cards to summary drawers

Description
TLDR; Add "traffic cards" to our summary drawers

From a UX perspective its sometimes harder to compare individual DPPs because for certain pieces of information we make you click backwards and forwards between the listing page and the detail page.
It would be much easier to compare data (i.e. does this DPP send or receive traffic) if we could show that data in the summary drawers, but we also have to be careful how we present data in a small space such as our summary drawers.
In regards to comparing amount of traffic between different DPPs of a Service, in some instances such as a Delegated Gateway we don't necessary need to be careful of space - we only need to show outbound traffic
In other instances (such as non-delegated gateways and sidecars) we now have more patterns to use within our GUI, in this case "sticky tabs within drawers" (sticky meaning a selected tab will remain selected between different instances of a drawer). We could use this pattern to add [Inbound] and [Outbound] sticky tabs to the drawers meaning as a user I could then easily click around on several DPPs in a list and immediately see the traffic without losing my place or getting confused as to where I am (see related https://github.com/kumahq/kuma-gui/issues/2770)

triage: what about the cost of making these calls more often?
could we require a click but not change pages?

authors: johncowen michaelbeaumont

repo: kumahq/kuma-gui


text:
[New game]: Menja Block breaker

🎮 Game Request
Game logic and basic description
it is block breaker game in which you have to bnreak blocks by swapping
Point down the features
Game points

3d game
good animation
html,css,js will be used
great UI

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Yashgabani845 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

repo: kunjgit/GameZone


text:
[Question]: Can I Add FAQ'S in GameZone using  bootstrap?

Describe your question or ask for support.❓
Description
I have created an issue in the "Question or support request" because I am not sure whether we can add other features to the website GameZone,if we can I would Like to create FAQ section using Bootstrap below are few questions examples:

What is GameZone?
Is GameZone really free to play?
Can I submit my own game to GameZone?
Are there any multiplayer games available on GameZone?

@kunjgit,If you would like FAQs in GameZone  assign me this issue under GSSoC'23.
Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Dimple-Choudhary !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey! @kunjgit
I want to discuss the questions and answers to be added in FAQ , below are 5 questions and they answers if you would Like to  add more or change  any of them Let me Know :)
1) What is GameZone?
=>🕹 GameZone is an open-source website that offers a collection of free-to-play games. 🌐🎮
It serves as a platform where game enthusiasts and developers can come together to contribute, collaborate, and share their games with the community. 👥🚀
2)  Is GameZone really free to play?
=> Yes! GameZone is completely free to play. 🆓🎮
          All the games available on the website can be accessed and enjoyed without any cost.
3) How can I contribute to GameZone?
=> Build and contribute games on GitHub.
          PRs welcome! Star the repo, join Discord for collaboration.
          Let's create together! 🎮💗🚀
4)     Can I submit my own game to GameZone?
=>  Yes, you can submit your own games to GameZone! It's an open-source project on GitHub. 🎮🎁
5)Can I play games on GameZone on my mobile device?
=>    Yes, you can play games on GameZone on your mobile device. 📱🎮

Also, I am not sure about 5 answer

Hey @Dimple-Choudhary ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

authors: Dimple-Choudhary kunjgit


text:
Painting Game Added

PR Description 📜
#1042

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Kalivarapubindusree ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

For this game their is no Images for this game please at once @kunjgit

Hello @Kalivarapubindusree, You will have to add one image in the assets/images directory which will be used as the thumbnail for your game on out GameZone website.

Hello @Kalivarapubindusree, You will have to add one image in the assets/images directory which will be used as the thumbnail for your game on out GameZone website.

Also, the image that you have added in PR, if you will add the same image, then also it would work.

Do I need to Do separate a another PR for only for the image r else I need to Do it along with the code files? @daccdacc

Hello @Kalivarapubindusree, just commit the image in the respective directory on your branch and you are done!🚀
No need of new PR!

Hello @Kalivarapubindusree, Make sure all the modified files are within a single PR only.
Also add only 1 picture in assets/images directory for painting game.
Alternate Option : Close all the open PRs, create a new fresh PR having your game, entry in main README.md file and single picture in assets/images directory.

authors: Kalivarapubindusree daccdacc kunjgit


text:
Testing

PR Description 📜
I have built the Racing Game made using JavaScript. In this a user can play game using 6 keys of the keyboard. User has to just start the game and play according to the situation and see if he/she can finish the race before time or not!
Fixes #991

Mark the task you have completed ✅

[✅] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[✅] I have performed a self-review of my own code or work.
[✅] I have commented my code, particularly in hard-to-understand areas.
[✅] My changes generates no new warnings.
[✅] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[✅] I have added screenshot for website preview in assets/images
[✅] I have added entries for my game in main README.md
[✅] I have added README.md in my folder
[✅] I have added working video of the game in README.md (optional)
[✅] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Parul1606 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

we already have this game on GameZone 👀 !!

Thank you  @Parul1606 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


text:
Added Star Trek Trivia Game

PR Description 📜
A fun trivia game centered around the famous Star Trek franchise, which would include the following:
Multiple Difficulty Levels: Different difficulty levels to cater to various levels of Star Trek knowledge.
Variety of Questions: A diverse range of questions covering different aspects of Star Trek, such as characters, aliens, technology, quotes, and memorable moments. This ensures that the quiz appeals to a wide audience and offers a mix of challenging and easier questions.
Time Constraints: A 10 second time limit to answer each question, increasing the pressure and making the game more exciting.
Winning Criteria = 100 points
Fixes #2413

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @tayyab-ilyas ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

hey @gurjeetsinghvirdee ! can you check this out? also please don't forget to assign the Gssoc'23 label. Thanks!

Can you re-add the screenshot in assets/images it's not working correctly

Can you check now? working for me..

Thank you  @tayyab-ilyas , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

hey @gurjeetsinghvirdee on the issue this was given the level 3 label

hey @gurjeetsinghvirdee on the issue this was given the level 3 label

That was automated by github action not given by any  human & labels should be given on the quality of PR

hey @gurjeetsinghvirdee on the issue this was given the level 3 label

That was automated by github action not given by any human & labels should be given on the quality of PR

cool.

authors: gurjeetsinghvirdee kunjgit tayyab-ilyas


text:
[New game]: Color swap

PR Description 📜
Added a new game color swap
"Color Swap" is a simple yet addictive browser-based game developed using HTML, CSS, and JavaScript. The game revolves around the player controlling a character or object that must pass through obstacles matching its color. The color of the character changes randomly, requiring quick reflexes and strategic thinking.
Simple Controls:
The player controls the character using the arrow keys or touch gestures on mobile devices.
The character moves left, right, up, or down to navigate through a series of color-coded obstacles.
Color Matching:
The character changes color periodically or when passing through special zones.
Players must guide the character through obstacles that match its current color to score points.
Increasing Difficulty:
As the game progresses, the speed and frequency of color changes increase.
More complex patterns and additional obstacles are introduced to challenge the player.
Fixes #4656

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @aditya-bhaumik ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43 please review my pull request

@ishita-43 please review my pull request and add the gssoc labels

Thank you  @aditya-bhaumik , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

authors: aditya-bhaumik kunjgit


text:
Add an option to add a single word to the table or an entire sentence

For now you can add to the table only one single word. This may be bad if you want to add modal verbs for example. Need to add something like a tick that you can click and after clicking it will allow you to add something longer than just a single word.

I changed the system of adding new words to the table so now if you want to add more than one word you need to use "," instead of space.

repo: kuronekozero/AnkiVocabHelper


text:
Discrepencies in BQ tutorial and UI

Reservations is under Capacity Management
Assignments is in the ... menu for the model
Stop before the section "Use the predicted recommendations in production"

Easy enough to figure out.

Use US not us-east1


text:
increase size of allowed request body from 100kb to 500kb

Was trying to use this package to generate a larger PDF (about 20 styled pages, ~200kb) and failed on request for content being too large. Increased the size to cover larger requests.

@rassie @marcelgross90 Any change you can get this in and up on dockerhub?

Hey folks, I merged your PR thanks for contributing.

authors: alechirsch marcelgross90 matt-fastpay

repo: kurzdigital/html-to-pdf

license: Unlicense