text:
Add support for PVC in Prometheus

We saw the issue in our prometheus installation that without the pvc our prometheus used a lot of disc creating a lot of pod evictions in our system.
The PVC is based on the official prometheus chart and how the pvc is setup there.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: peter-c-larsson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: morvencao
If they are not already assigned, you can assign the PR to them by writing /assign @morvencao in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @peter-c-larsson. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I signed it!

/ok-to-test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: peter-c-larsson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@peter-c-larsson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests-cni.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-simpleTests-cni

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test istio-integ-k8s-tests

prow/release-test.sh
5f15114fbd42f26bb79cc658bb63a0781fabc399
link
/test release-test

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-simpleTests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-simpleTests-cni

prow/e2e_pilotv2_auth_sds.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio_auth_sds_e2e

prow/e2e-mixer-no_auth.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
4191a332ebd5872cdddf3ba08133180061bf54ad
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@peter-c-larsson: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@douglas-reid I know a little bit about operators and the changes needs to be done here: https://github.com/istio/installer/tree/master/istio-telemetry/prometheus-operator
Currently we have disabled Prometheus in our installation so not that urgent so if anyone else is up for making the PR in the installer project I would be happy.

Going to close this to clean up old PRs since we won't merge this in here. As Doug mentioned, this should be done in https://github.com/istio/installer/tree/master/istio-telemetry/prometheus-operator. This looks really useful though so we should make sure we get a chance to port it over eventually - thanks for the PR

authors: gyliu513 howardjohn istio-testing peter-c-larsson


text:
Cherry-pick https://github.com/istio/istio/pull/20813#

Manually cherry-pick https://github.com/istio/istio/pull/20813#

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.5
bf91fd88e0051ccb7e0b2732563cde482cd71d8b
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

source: gharchive/pull-request

authors: JimmyCYJ istio-testing

repo: istio/istio

license_type: permissive

license_source: github-api


text:
Integration test for Prometheus certificate provisioning

Please provide a description for what this PR is for: Integration test for Prometheus certificate provisioning.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ X] Policies and Telemetry
[ X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ca049968d2406e4defba9adc56e50eaac5a14411
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c007144caa67a343401e2574a0418c7bd2ae8fa2
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c007144caa67a343401e2574a0418c7bd2ae8fa2
link
/test integ-telemetry-k8s-tests_istio

lint_istio
5f9b0b2abc4901e295e3faa3ea18075fa2906737
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
5f9b0b2abc4901e295e3faa3ea18075fa2906737
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5f9b0b2abc4901e295e3faa3ea18075fa2906737
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
5f9b0b2abc4901e295e3faa3ea18075fa2906737
link
/test integ-telemetry-k8s-tests_istio

lint_istio
c3c27dfa8fff03e04d91fe00b232f195cc5578f8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
5f9b0b2abc4901e295e3faa3ea18075fa2906737
link
/test integ-telemetry-k8s-tests_istio

lint_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
5f9b0b2abc4901e295e3faa3ea18075fa2906737
link
/test integ-telemetry-k8s-tests_istio

lint_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test lint_istio

gencheck_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test lint_istio

gencheck_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test integ-telemetry-k8s-tests_istio

lint_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
65473b039226144503ed4f763655985a2d9e298b
link
/test integ-telemetry-k8s-tests_istio

lint_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test lint_istio

gencheck_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test lint_istio

gencheck_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test integ-telemetry-k8s-tests_istio

lint_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
885048e470a4b663140485cc98ae55643ebf9407
link
/test integ-telemetry-k8s-tests_istio

lint_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test lint_istio

gencheck_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test lint_istio

gencheck_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test lint_istio

gencheck_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test lint_istio

gencheck_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
42a0e1841ebc3e7652939eb8c24684a29f2dcfdb
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
44edf985cefb396e9769ec363621f000e3a14f72
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
44edf985cefb396e9769ec363621f000e3a14f72
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
44edf985cefb396e9769ec363621f000e3a14f72
link
/test integ-telemetry-k8s-tests_istio

lint_istio
0edd7c5e56a740c30b632fdeb8bf625320748102
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
44edf985cefb396e9769ec363621f000e3a14f72
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
0c89728f409dac314bfb108effb6db3148e4b559
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@mandarjog @kyessenov Can you review the PR?

@lei-tang: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio/wg-policies-and-telemetry-maintainers Can you review the PR?

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a290b7089281cd61dfd4d146d47c34d4739c4b3c
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Does this test needs to be under telemetry folder? It does not actually verify any telemetry feature. security folder seems to be a better place for it.
I think the desired test to add under telemetry is to verify that prometheus could scrape app metrics when SDS is turned on.

/test integ-security-k8s-tests_istio

The reasons to organize this test under telemetry are:

This test is to verify the certificate provisioning for Prometheus, which is a telemetry component.
This test runs as a subtest within the telemetry test suite, instead of duplicating the telemetry suite under the security folder and running this test in a new telemetry deployment.

The test does not verify anything related to prometheus or telemetry. It verifies the sidecar inside prometheus pod is generating cert. e2e test is feature oriented and the feature to verify here is about certificate provision.
This test does not need any telemetry set up. The only option needed is cfg.Values["prometheus.enabled"] = "true"

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a290b7089281cd61dfd4d146d47c34d4739c4b3c
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The certificate provisioning feature tested here is specific to Prometheus and no other component uses the same feature. The certificate provisioning feature for Prometheus is related to the functioning of Prometheus and should be integration tested as part of the Prometheus integration test.
Running this test under security using a new test suite instead of a subtest under telemetry also prolongs the total test running time.

Meanwhile, this test does need telemetry setup, e.g.,
cfg.Values["telemetry.enabled"] = "true"
cfg.Values["telemetry.v1.enabled"] = "false"
cfg.Values["telemetry.v2.enabled"] = "true"
cfg.Values["prometheus.enabled"] = "true"

Why does it need telemetry options? It just need prometheus to be enabled... (cfg.Values["prometheus.enabled"] = "true")

cfg.Values["prometheus.enabled"] = "true" is a telemetry option, no?

I think the proper test we should add is to verify prometheus could scrape app metrics when mtls is turned on, which should cover what being tested here. wdyt? Feel free to open an issue and assign it to me.

An integrationt test that verifies Prometheus can scrape app metrics when mTLS is turned on will be useful and can be added in a separate PR. The integration test in this PR tests the foundation of the Prometheus mTLS since the Prometheus certificate provisioning is the foundation of Prometheus mTLS. So both integration tests are useful and they are different, e.g., when Prometheus mTLS fails, the Prometheus certificate provisioning may work correctly.

@istio/wg-policies-and-telemetry-maintainers Can you review the PR?

hmm I don't understand why they are different. Scraping with mTLS essentially covers certificate provisioning, and this is the actual feature we are shipping.

mTLS and certificate provisioning are different, e.g., certificate provisioning may succeed while mTLS may fail. mTLS is mutual TLS and certificate provisioning is to generate a certificate.

Isn't this certificate used to scrape application metrics from a port with mTLS enabled? Otherwise what is the usage of this cert?

Yes, the certificate provisioned is used by mTLS. But it does not mean certificate provisioning and mTLS are the same.

Ok then if prometheus could scrape metrics from a mTLS secured port, does it mean certificate is provisioned successfully in prometheus? Doesn't that cover what you are testing here? Isn't user visible behavior (metrics show in prometheus) what we really want to verify in e2e test, not detailed set up (prometheus has certs)?
Also the mechanism for prometheus scraping mTLS port is changing, I don't think the behavior you tested here is going to exist for long term. I don't think it should be in telemetry test suite.

Based on the review comments, the test is moved to the security folder.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a290b7089281cd61dfd4d146d47c34d4739c4b3c
link
/test integ-security-k8s-tests_istio

lint_istio
a8fdf715208b4e3c6d37e6d164e7cafae5674812
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a290b7089281cd61dfd4d146d47c34d4739c4b3c
link
/test integ-security-k8s-tests_istio

unit-tests_istio
f866408cbb6b78b9dbc7dacc4580eb8a0c689da6
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f866408cbb6b78b9dbc7dacc4580eb8a0c689da6
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

In response to a cherrypick label: #22036 failed to apply on top of branch "release-1.5":
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	tests/integration/telemetry/stats/prometheus/tcp/stats_tcp_filter_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/telemetry/stats/prometheus/tcp/stats_tcp_filter_test.go
CONFLICT (content): Merge conflict in tests/integration/telemetry/stats/prometheus/tcp/stats_tcp_filter_test.go
Patch failed at 0001 Integration test for Prometheus certificate provisioning

Strongly agree with @bianpengyuan comments, we should be testing mtls scraping works not looking for the cert

authors: bianpengyuan howardjohn istio-testing lei-tang


text:
[release-1.7] Grant read permission to component in the same group

This is an automated cherry-pick of #26438

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.7
497917b671c0367a95a73539ce26d6d3912b2f4a
link
/test unit-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.7


text:
'istioctl proxy-status': keep going even if a DiscoveryPod fails proxyGet()

Resolves https://github.com/istio/istio/issues/26300

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
713d2d0104d77412a8c9cdcd8347b784d87d9ebd
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
713d2d0104d77412a8c9cdcd8347b784d87d9ebd
link
/test release-notes_istio

lint_istio
713d2d0104d77412a8c9cdcd8347b784d87d9ebd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
0f9355b07a935c0e1e5005fd0c9359a62b9b90c0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
0f9355b07a935c0e1e5005fd0c9359a62b9b90c0
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
0f9355b07a935c0e1e5005fd0c9359a62b9b90c0
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: esnible istio-testing


text:
[Test Framework] Cleanup logic for cluster types

Please provide a description for what this PR is for.
Fix #28934
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@daixiang0: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
02191f413723ecb4980ab80fe0b4d537d18d2c6e
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


text:
[release-1.9] Fix probe header

This is an automated cherry-pick of #31981

@googlebot I consent.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

unit-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test unit-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/close

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

unit-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test unit-tests_istio_release-1.9

integ-security-k8s-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-k8s-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

unit-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test unit-tests_istio_release-1.9

integ-security-k8s-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-k8s-tests_istio_release-1.9

integ-security-multicluster-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-multicluster-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test unit-tests_istio_release-1.9

integ-security-k8s-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-k8s-tests_istio_release-1.9

integ-security-multicluster-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-multicluster-tests_istio_release-1.9

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-k8s-tests_istio_release-1.9

integ-security-multicluster-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-multicluster-tests_istio_release-1.9

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

unit-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test unit-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test lint_istio_release-1.9

unit-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test unit-tests_istio_release-1.9

integ-security-multicluster-tests_istio_release-1.9
cd7fcbc2c197b6463ccf48fc8ee1458e5f5316c3
link
/test integ-security-multicluster-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: istio-testing wzshiming