text:
Bedrock Testing V2: Triggered Integration Tests through PR modified file white-listing

Closes #334
Using white-listing script for selection and triggering appropriate Integration Tests based on PR modified files and respective file path in repo.

cluster/azure | cluster/common |test/ |tools/ |pipelines --> Trigger All Tests
cluster/environments/azure-common-infra --> Trigger Common_KeyVault & MultiCluster Test
cluster/environments/azure-simple --> Trigger Azure_Simple Test
cluster/environments/azure-multiple-clusters --> Trigger Multicluster_Test
cluster/environments/azure-single-keyvault --> Trigger Common_Keyvault Test

Planning on merging this, We will have another PR that will not be merged validating the triggers

Demonstration of Triggers

cluster/azure | cluster/common |test/ |tools/ |pipelines --> Trigger All Tests
cluster/environments/azure-common-infra -->Trigger KeyVault & MC -Validated in Build 6021 ✔
cluster/environments/azure-simple --> Trigger Azure_Simple Test - Validated in Build 6017 ✔
cluster/environments/azure-multiple-clusters --> Trigger MC_Test -  Validated in Build 6019 ✔
cluster/environments/azure-single-keyvault --> Trigger Keyvault Test-  Validated in Build 6020 ✔

repo: microsoft/bedrock


text:
Expressions should include flatten function

There is currently no way in the expression language to flatten arrays into primitive values.  Union can do this for a static number of expressions, but can't do it across a computed sets of arrays.  What is needed is to be able to do flatten([[1, 2, 3], [4, [5], 6]]) -> [1, 2, 3, 4, 5, 6].
[enhancement]

fixed by #3470

source: gharchive/issue

repo: microsoft/botbuilder-dotnet

license: MIT

license_type: permissive

license_source: github-api


text:
Do nothing when the activity is null

Fixes #5257

@Danieladu, this was reviewed by the SDK team. There are some questions. Why the response would be empty? Can this be fixed by adding constraints to the schema?

@Danieladu, this was reviewed by the SDK team. There are some questions. Why the response would be empty? Can this be fixed by adding constraints to the schema?

The response is evaluated at runtime. The schema could only check the dialog file staticly.

source: gharchive/pull-request

authors: Danieladu mrivera-ms


text:
Do we need FunctionContext like DecoratorContext?

When a projection calls a function, it passes a bare Program as the first arg automatically. Will we eventually need more info for the same reasons we added DecoratorContext? Or could this be a single Context type?

I would like to see these be the same, personally.

Yeah could probably be the exact same type

Maybe we should rename the current type ASAP then to avoid delaying a (TS source) break too long.

Yeah probably be good but we could also have that later and have a smooth transition if there is a reason to wait
/**
 *  @deprecated use FunctionContext
 */
type DecoratorContext = FunctionContext;

Is there aany design to discuss here, or can we just go to implementation, with the alias for DecoratorContext?

I think the only design to discuss is the name of the unified type. I think maybe CallContext is better than FunctionContext but I don't have a strong opinion.

authors: bterlson markcowl nguerrera timotheeguerin

repo: microsoft/cadl


text:
CI Pipeline Implementation

All Submissions:

[YES] Have you followed the guidelines in our Contributing document?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[N/A] I have updated the documentation accordingly.
[NO] I have added tests to cover my changes.
[N/A] All new and existing tests passed.
[YES] My code follows the code style of this project.
[NA] I ran lint checks locally prior to submission.
[YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?

This change implements the build pipeline described in issue number: https://github.com/microsoft/cobalt/issues/203
This change adds a build pipeline that can be leveraged by clients of Cobalt.
More specifically, this change adds the following features as called out
in the design for https://github.com/microsoft/cobalt/issues/178.
The features implemented are as follows:

Check out test harness from cobalt repo
Log into ACR hosting test container image via service principal
Build test harness
Log out of ACR hosting test container
Execute template unit and integration tests
Publish scripts from cicd and build folders as build artifacts

The implementation relies on the following variables defined as pipeline
variables. Note, no keyvault variables are needed.

Variable Name
Description

AD_SP_SUBSCRIPTION_ID
Subscription ID used to execute terraform commands

AD_SP_TENANT_ID
Tenant ID used to execute terraform commands

AGENT_POOL
Pool in which to run build pipeline

ASE_NAME
Name of static ASE used for testing

ASE_RESOURCE_GROUP
Name of static RG used for testing

ASE_VNET_NAME
Name of static VNET used for testing

BASE_IMAGE_ACR_HOST
Host of ACR hosting test harness base

BASE_IMAGE_ACR_SERVICE_CONNECTION_NAME
Service connection name to authenticate to BASE_IMAGE_ACR_HOST

PIPELINE_SERVICE_CONNECTION
Name of service connection for pipeline

REMOTE_STATE_ACCOUNT
Remote state storage account name

REMOTE_STATE_CONTAINER
Remote state storage container

Closed - will be in another PR

repo: microsoft/cobalt


text:
package detector warning

I got two question about warning note while running component detection leveraging msft-sbom-tool.

Does component detection tool support C/C++ based project?

We noticed component detection isn't capturing any packages and throws the below mentioned warning. Does C/C++ projected supported? if not, will this been enabled in the future?
##[warning]There were no packages detected during the generation workflow.

We noticed few of the component has been skipped. For example tensorflow and keras. Is this expected behavior or something need to be change on python requirement.txt.

]Candidate version ("protobuf 5.26.0 - pip") for "protobuf" already exists in map and the version is NOT valid.
##[warning]Specifiers: "!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.20.3" for package "tensorflow-cpu-aws" caused this.
##[warning]Candidate version ("tensorboard 2.15.2 - pip") for "tensorboard" already exists in map and the version is NOT valid.
##[warning]Specifiers: "<2.17,>=2.16" for package "tensorflow" caused this.
##[warning]Version Resolution for "tensorboard" failed, assuming last valid version is used.
##[warning]Candidate version ("keras 2.15.0 - pip") for "keras" already exists in map and the version is NOT valid.
##[warning]Specifiers: ">=3.0.0" for package "tensorflow" caused this.
##[warning]Components skipped for "Pip" detector:
##[warning]- "abi-pytestfixture-integration"
##[warning]- "abi-core"
##[warning]- "abi-package"
##[warning]- "abi-vault"
##[warning]- "numpy=1.26.4"

And I specify PIP_EXTRA_INDEX_URL as an internal link in system environment as well as in requirement.txt, but all the package is still not found in component detection. Do you know who can we resolve this warning message?
##[warning]Received NotFound "Not Found" from https://pypi.org/pypi/abi-core/json
##[warning]Root dependency "abi-core" not found on pypi. Skipping package.
##[warning]Received NotFound "Not Found" from https://pypi.org/pypi/abi-package/json
##[warning]Root dependency "abi-package" not found on pypi. Skipping package.
##[warning]Received NotFound "Not Found" from https://pypi.org/pypi/abi-vault/json
##[warning]Root dependency "abi-vault" not found on pypi. Skipping package.
Thank you.

Our support of C++ projects comes via the VCPKG detector. How are you registering the dependencies for your project?
For the second question about Python feed configuration, we have an open issue #415 for allowing internal feed configuration in the Pip detectors but we haven't had a chance to prioritize this recently. If you are interested in making the contribution I would be happy to help out how I can.

authors: cobya zongtaol

repo: microsoft/component-detection


text:
[DataGrid] Row Additional Content

Ability to add additional content to DataGrid row, with check if add.
Original PR #2389

something is missing?

Are there any problems applying this change?

Hi Daniele, still not have time to take a proper look at this and won't be able for the coming weeks because of vacation period. There is no rush to get this in as it will require at least a minor release (i.e. 4.X)

you're right, this change gives me the ability to create components outside of this library.

Closing this as there has been no activity for a while.

authors: franklupo vnbaaij

repo: microsoft/fluentui-blazor


text:
Automatically create partition for NVMe disks and use it for images, I/O, and executor Docker volume

Problem:
Azure L-series VMs have NVMe drives with no mountpoint.  TES tasks should use these by default if they exist.
Solution:
The runner should check if NVMe disks exist, and if so, create a single mountpoint (use RAID0 if more than one disk) in the TES runner.  Use it for Docker image storage, input/output storage, and the main volume for the TES executor.  Consider reformatting every time on task start, so that the previous run is securely deleted (rm only removes file references) if more than one task runs on the same machine.  Here is an example of a Standard_L16S_v3 on startup:

Possibly related to work previously targeting microsoft/CromwellOnAzure#317


text:
Merge like media queries in extracted CSS

With the webpack extraction plugin, we can end up with many similar CSS media queries immediately after each other. These should be collapsed to save some bytes from the output CSS file.
Example
Currently generated CSS
@media screen and (min-width: 700px) {
  .f15y6sl0 {
    margin-bottom: auto;
  }
}
@media screen and (min-width: 700px) {
  .f1mmeaxr {
    margin-left: auto;
  }
  .f13yy761 {
    margin-right: auto;
  }
}
@media screen and (min-width: 700px) {
  .fo29on3 {
    width: 369px;
  }
}
@media screen and (prefers-reduced-motion: reduce) {
  .folzdkc > svg > circle.fui-Spinner__Tail {
    -webkit-animation-duration: 0.01ms;
    animation-duration: 0.01ms;
  }
}
@media screen and (prefers-reduced-motion: reduce) {
  .fhlfkde > svg > circle.fui-Spinner__Tail {
    -webkit-animation-iteration-count: 1;
    animation-iteration-count: 1;
  }
}

Collapsed media queries
@media screen and (min-width: 700px) {
  .f15y6sl0 {
    margin-bottom: auto;
  }
  .f1mmeaxr {
    margin-left: auto;
  }
  .f13yy761 {
    margin-right: auto;
  }
  .fo29on3 {
    width: 369px;
  }
}
@media screen and (prefers-reduced-motion: reduce) {
  .folzdkc > svg > circle.fui-Spinner__Tail {
    -webkit-animation-duration: 0.01ms;
    animation-duration: 0.01ms;
  }
  .fhlfkde > svg > circle.fui-Spinner__Tail {
    -webkit-animation-iteration-count: 1;
    animation-iteration-count: 1;
  }
}

Minification of CSS is not the goal of CSS extraction.
There are existing tools that do that, for example CssMinimizerWebpackPlugin that uses css-nano. You can check playground there, it does exactly what you mentioned 😉

authors: NotWoods layershifter

repo: microsoft/griffel


text:
make code nicer

functions version updated

@daemel  @corygstevenson @c-w could you take a look

@corygstevenson could you take a look?

Code has to be manually merged at this time given multiple file changes.

7m after request

authors: SychevIgor daemel

repo: microsoft/health-architectures


text:
Checks numeric QR digit count (code + test)

Checks numeric QR digit count (code + test). Fixes #52.

It might also be good to specifically error out on invalid pairs (i.e., anything outside of the 65 characters allowed by our encoding).

(Also -- or alternatively -- just a helpful error message if JWS header decoding fails, nudging folks to review their numeric encoding.)

authors: christianpaquin jmandel

repo: microsoft/health-cards-validation-SDK


text:
add api key authentication provider for Ruby

details in #1902

Can u assign this issue

authors: LucianeFernandesRoque baywet

repo: microsoft/kiota


text:
Missing most licenses/dependencies starting in webpack 5.55.0

I updated to a recent version of webpack (5.68.0), and some time later noticed the license file generated with this plugin was missing almost all dependencies.  It only showed dependencies for a few webpack related plugins, like css-loader.  It was missing all other dependencies, like react.  I kept downgrading webpack and found that this started happening in webpack 5.55.0.  5.54.0 and before work as expected.
Looking briefly at code of the plugin, it looks like compilation.fileDependencies, used in licenseUtils.js doesn't have the missing dependencies when it's accessed (for example, react is not in the list).

same issue, have you solved this?


text:
Fix event persistence error handling

This commit fixes a bug in the error handling logic while attempting to flush event info objects. Currently, if an error occurs, the exception is caught and logged. It is not thrown. As a result the processing continues and the desired events log will not be produced.
The fix throws a custom error corresponding to Events and lets the caller decide if the processing should continue. As of now the error should result in termination of the workload or fail unit tests.
Fixes #48

Could we test it with the PR where tests passed and was not supposed to?

Exactly my intent. I have blocked the PR in which this was detected first. Once we merge this, validation of that PR should fail. Thanks

repo: microsoft/lst-bench


text:
TwoPaneView should not be included in tab navigation

Describe the bug
The TwoPaneView control is currently added automatically to tab-navigation although it shouldn't be for many reasons:

No user interaction possible
Its behavior should be similar to all other layout controls (Grid, StackPanel, RelativePanel)

Steps to reproduce the bug

Create a new app
Add a TwoPaneView control
Add a Button
Press many times tab
--> The focus will switch between the button and the TwoPaneView control

Expected behavior

The focus should stay on the Button

Version Info
NuGet package version:
2.3.200213001

Windows 10 version
Saw the problem?

Insider Build (xxxxx)
Yes

November 2019 Update (18363)
Yes

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

10X
Yes

Additional context
I would like to fix it.

@rudyhuyn Thanks for filing. @teaP Is there any reason why we might want TwoPaneView to be a tab stop ?

@rudyhuyn Rudy Huyn FTE Thanks for filing. @teaP Tammy Paine FTE Is there any reason why we might want TwoPaneView to be a tab stop ? If there is none, @rudyhuyn Rudy Huyn FTE go ahead with the fix - Thanks!

No, it definitely shouldn't be!

Rudy is fast.

authors: ranjeshj rudyhuyn shaheedmalik teaP

repo: microsoft/microsoft-ui-xaml


text:
BodyLarge TextBlock style is missing

Describe the bug
As described in the documentation type ramp, the body strong style is missing from WinUI 3
Steps to reproduce the bug
Try to add a style for textblock
Expected behavior
No response
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
October 2020 Update (19042)
Additional context
No response

@codendone FYI

authors: StephenLPeters harvinders


text:
the language:javascript doesn't work , treat as typescript code

and it cause when i use require syntax ，the intellisense doesn't work. And the import syntax works.

const monacoInstance = monaco.editor.create(
      this.$refs["editor"] as HTMLElement,
      {
        value: this.$props.value,
        language: "javascript",
        fontSize: 14,
        wordBasedSuggestions: true
      }
    );

    // monacoInstance.addCommand(
    //   monaco.KeyMod.Alt | monaco.KeyCode.US_SLASH,
    //   () => {
    //     monacoInstance.trigger("", "editor.action.triggerSuggest", "");
    //   },
    //   "editorTextFocus && !editorHasSelection && " +
    //     "!editorHasMultipleSelections && !editorTabMovesFocus && " +
    //     "!hasQuickSuggest"
    // );

    monaco.languages.typescript.javascriptDefaults.setCompilerOptions({
      allowNonTsExtensions: true,
      // noLib: true,
      target: monaco.languages.typescript.ScriptTarget.ES5,
      moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
      module: monaco.languages.typescript.ModuleKind.CommonJS,
      lib: ["es5", "es6"]
      // typeRoots: ["node_modules"]
    });

    monaco.languages.typescript.javascriptDefaults.addExtraLib(
      require("!raw-loader!./types/lib.es5.d.ts").default,
      "lib.es5.d.ts"
    );
    monaco.languages.typescript.javascriptDefaults.addExtraLib(
      require("!raw-loader!./types/lib.es6.d.ts").default,
      "lib.es6.d.ts"
    );

    [
      "buffer",
      "child_process",
      "cluster",
      "console",
      "constants",
      "crypto",
      "dgram",
      "dns",
      "domain",
      "events",
      "fs",
      "globals",
      "http",
      "http2",
      "https",
      "index",
      "inspector",
      "module",
      "net",
      "os",
      "path",
      "perf_hooks",
      "process",
      "punycode",
      "querystring",
      "readline",
      "repl",
      "stream",
      "string_decoder",
      "timers",
      "tls",
      "trace_events",
      "tty",
      "url",
      "util",
      "v8",
      "vm",
      "worker_threads",
      "zlib",
      "ts3.2/globals",
      "ts3.2/index",
      "ts3.2/util"
    ].forEach(function(fileName) {
      monaco.languages.typescript.javascriptDefaults.addExtraLib(
        require("!raw-loader!./types/node_modules/@types/node/" +
          fileName +
          ".d.ts").default,
        "node_modules/@types/node/" + fileName + ".d.ts"
      );
    });

    monaco.languages.typescript.javascriptDefaults.addExtraLib(
      require("!raw-loader!./types/serverless" + ".d.ts").default,
      "serverless.d.ts"
    );

when i make this lines as comments, it's OK.
// monaco.languages.typescript.javascriptDefaults.setCompilerOptions({
    //   allowNonTsExtensions: true,
    //   // noLib: true,
    //   target: monaco.languages.typescript.ScriptTarget.ES5,
    //   moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
    //   module: monaco.languages.typescript.ModuleKind.CommonJS,
    //   lib: ["es5", "es6"]
    //   // typeRoots: ["node_modules"]
    // });

repo: microsoft/monaco-editor


text:
Revert "Revert "Support host objects in 64-bit MSBuild (#5177)" (#5206)"

This reverts commit 28ce126ed4f2220d87317b7f95d03d116c72bb4b.
The original commit failed RPS twice, so it was reverted. It then passed RPS twice, so this reverts its revert.

Is there a link to the build where RPS passed you can paste here? (for the sake of leaving a clean trail)

https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/237504

authors: BenVillalobos Forgind

repo: microsoft/msbuild


text:
shuffle should be set to True in train_loader of SinglePathTrainer

Brief description of your proposal if any:
in nni/nni/retiarii/oneshot/pytorch/random.py
Line 144:
self.train_loader = torch.utils.data.DataLoader(self.dataset_train,
batch_size=batch_size,
num_workers=workers)

->
self.train_loader = torch.utils.data.DataLoader(self.dataset_train,
batch_size=batch_size,
num_workers=workers,
shuffle=True)

Excellent. Please open a pull request for this.

authors: dutxubo matluster

repo: microsoft/nni


text:
Candidate Issues for stabilization sprint

We plan to have a minor sprint for stabilization, the purpose of the sprint is to work on tech debt, bugs, CICD, etc. No new features are expected. By introducing this minor sprint, we give everyone a pause for the next big release, enjoy the minor sprint =)!
https://github.com/microsoft/nni/labels/v2.9.1
Release manager: @Louis-J
Release start date: TBD
Feature freeze date (at most 30 days): 10.14
Code freeze date: 10.17
First test package (1 week since feature freeze): 10.18
Release date (3 weeks since feature freeze): TBD 11.14
Training Service

[x] p0 - Does not support non-English path ~12/10 #5164  @Lijiaoa , bugbash: complete
[ ] p2 - #5064

HPO

[x] p0 - WebSocket connection may broken during long run ~12/10 #5166  @Lijiaoa , bugbash: complete
[x] p1 - Make anneal optional  ~13/10 #5165 @Bonytu , bugbash: complete
[ ] p0 - lag after long run
[ ] p2 - Assessor.trial_end() is not invoked if no metrics sent
[ ] p2 - Make REST timeout configurable

NAS

[x] p0 - Dedup for evolution search #5092 @ultmaster reviewing @liuzhe-lz , bugbash: complete
[x] p0 - #5117 #5135 @ultmaster reviewing @J-shang , bugbash: complete
[x] p0 - [nas] fix issue introduced by the trial recovery feature #5109 ~30/9 @QuanluZhang  reviewing @ultmaster, bugbash: complete
[x] #5119 @ultmaster  ~10/10 reviewing @QuanluZhang , bugbash: complete

Model Compression

[x] p1 - verify issue #3514, fix if there are any problems @J-shang @Louis-J , bugbash: complete

ModelSpeedup

[x] p0 - speedup rand_like_with_shape is easy to overflow when dtype=torch.int8. @J-shang  ~30/9 waiting for #5138 pr: #5140 Pruning detectron2's Faster R-CNN #4875 #5136 @J-shang ~28/9 pr: #5140 reviewing @QuanluZhang , bugbash: complete
[ ] p2 - Autoinfer can not deal with some op, sparsity cannot propagate through these ops, like torch.nn.functional.interpolate @J-shang move to 3.0
[x] p0 - torch._C.parse_schema in pytorch < 1.9.0 do not produce enough information. Writing a schema parser needed #5131  @Louis-J  ~25/9 reviewing @J-shang , bugbash: complete
[x] p0 - a bug in speedup propagate: executing random_init the view tensors causes error. #5018 @Louis-J  reviewing
https://pytorch.org/docs/stable/tensor_view.html#tensor-views @J-shang , bugbash: complete
[ ] p1 - a bug in speedup replace_module: #4991. @Louis-J ~10/10
[ ] p2 - refactor the inference process in speedup: in 'speedup support list/dict inputspeedup doesn't support list/dict input', #5107, solving #4998 #5097 #5130 @Louis-J
[ ] p2 - ~~speedup doesn't support registered buffer. @Louis-J
[ ] p2 - speedup get correct masks in cpu but wrong masks in gpu. #4945 @Louis-J

WebUI

[x] p0 - HPO experiment hyper-parameters page error. · Issue #5127 ~28/9 reviewing @liuzhe-lz , bugbash: complete
[x] p0 - #3549 ~30/9 @Louis-J , bugbash: complete

NAS

#5119
#5117
#5092

p1 - a bug in speedup replace_module: https://github.com/microsoft/nni/issues/4991. @Louis-J ~10/10
any progress in this？


text:
[Bug]: Microsoft.Playwright.CLI installs incorrect version of Chromium

Playwright version
1.13.0 (CLI 1.0.2)
Operating system
Windows
What browsers are you seeing the problem on?
Chromium
Other information
dotnet --version: 6.0.100-preview.6.21355.2
What happened? / Describe the bug
playwright install installs Chromium 888113, but _playwright.Chromium.LaunchAsync() requires  Chromium 901522
Code snippet to reproduce your bug
dotnet tool install --global Microsoft.Playwright.CLI
playwright install

in C# unit test:
_playwright = await Playwright.CreateAsync().ConfigureAwait(false);

  Browser = await _playwright.Chromium.LaunchAsync(new BrowserTypeLaunchOptions
  { Timeout = 5000, Headless = _headless })

Relevant log output
playwright install
Playwright build of chromium v888113 downloaded to C:\Users\romfi\AppData\Local\ms-playwright\chromium-888113
Playwright build of firefox v1271 downloaded to C:\Users\romfi\AppData\Local\ms-playwright\firefox-1271
Playwright build of webkit v1492 downloaded to C:\Users\romfi\AppData\Local\ms-playwright\webkit-1492
Playwright build of ffmpeg v1005 downloaded to C:\Users\romfi\AppData\Local\ms-playwright\ffmpeg-1005

from unit tests:
Microsoft.Playwright.PlaywrightException
Executable doesn't exist at C:\Users\romfi\AppData\Local\ms-playwright\chromium-901522\chrome-win\chrome.exe
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers:              ║
║                                                                         ║
║     npx playwright install                                              ║
║                                                                         ║
║ <3 Playwright Team                                                      ║
╚═════════════════════════════════════════════════════════════════════════╝

This sounds like it's picking up the "wrong" library version. A couple quick questions, to help me diagnose:

Are you running the command from the project location?
Do you also have the node/npm version installed?
Can you try running dotnet .\bin\Debug\net5.0\Microsoft.Playwright.dll -- install? Does that install the correct version?

Are you running the command from the project location?

No, I was runnig from solution folder, when I run it from project folder it downloaded correct version - chromium-901522

Do you also have the node/npm version installed?

yes, 16.5.0

Can you try running dotnet .\bin\Debug\net5.0\Microsoft.Playwright.dll -- install? Does that install the correct version?

dotnet ./bin/Debug/net6.0/Microsoft.Playwright.dll
dotnet : Cannot use file stream for [C:\Users\romfi\source\repos\HtmlRaportGenerator\HtmlRaportGenerator.Tests\bin\Debug\net6.0\Microsoft.Playwright.deps.json]: No such file or directory
At line:1 char:1
+ dotnet ./bin/Debug/net6.0/Microsoft.Playwright.dll
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Cannot use file...le or directory:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

A fatal error was encountered. The library 'hostpolicy.dll' required to execute the application was not found in 'C:\Users\romfi\source\repos\HtmlRaportGenerator\HtmlRaportGenerator.Tests\bin\Debug\net6.0\'.
Failed to run as a self-contained app.
  - The application was run as a self-contained app because 'C:\Users\romfi\source\repos\HtmlRaportGenerator\HtmlRaportGenerator.Tests\bin\Debug\net6.0\Microsoft.Playwright.runtimeconfig.json' was not found.
  - If this should be a framework-dependent app, add the 'C:\Users\romfi\source\repos\HtmlRaportGenerator\HtmlRaportGenerator.Tests\bin\Debug\net6.0\Microsoft.Playwright.runtimeconfig.json' file and specify th
e appropriate framework.

So playwright install on Windows must be run from project folder, but on linux it can also be run form solution? I have a github runner that installs playwright and it works ok

What I think is happening is, playwright install is picking up an older version of the DLL somewhere in your solution folder structure. Have you had a previous version of the NuGet installed there, by any chance? Is there a reference by another project to an older version?
That will also explain why it's working (as expected) on CI - there's likely no older versions there.

In my sln structure there are just 2 projects, blazor wasm app and playwright test app, the older version was installed in the test app previously, but the new (1.13.0) was installed before running playwright install

When you updated the reference, did you clean/rebuilt the project before doing install?

I thought so, but mb I forgot. Now I manually deleted bin and obj folders, uninstalled CLI tool and removed ms-playwright folder, rebuilt and reinstalled CLI and playwright install installs correct version 901522. Thanks for Your help, I'm closing this issue.

authors: avodovnik romfir

repo: microsoft/playwright-dotnet


text:
[Question] Can't run in Docker container

what's problem? Thanks

By using offical base image,I solve it. Thanks! @yury-s

repo: microsoft/playwright-java


text:
Visual testing

Could you add support for visual testing?
see on this solutions

https://codecept.io/visual/#using-resemble-helper
https://theheadless.dev/posts/basics-taking-screenshots/#use-in-visual-regression-testing

Thanks @JosefJezek! We have added support for visual comparisons. I'll reframe this to track adding that to our docs.

authors: JosefJezek arjunattam

repo: microsoft/playwright-test


text:
AttributeError with NlpEngine

Describe the bug
When running certain strings through the new TransformersNlpEngine I am getting errors. It doesn't happen on every string.
To Reproduce
Steps to reproduce the behavior:

See provided colab : https://colab.research.google.com/drive/1H_kKeHlfvZUSaPN0HNRn1_ymZk_TH4Cp#scrollTo=J63RtBZFaiLv

Expected behavior
I would expect it not to error
Additional context
i hacked this line with the following : https://github.com/microsoft/presidio/blob/37f74e8e880cb1bdf3f5224a05eaa9b63df02d31/presidio-analyzer/presidio_analyzer/nlp_engine/transformers_nlp_engine.py#L59
            if span is not None:
                span._.confidence_score = d["score"]
                ents.append(span)

and it silences the issue, but I don't understand why. help is appreciated.

Good catch. From spaCy's docs, char_span Returns None if the character indices don’t map to a valid span using the default alignment mode strict. We'll look into this. Perhaps changing the alignment_mode is the preferred solution.

thanks for the response @omri374 . I tried expand and contract in alignment_mode and am seeing exceptions thrown in both cases. I do feel expand is the way to go, but might need some tweaking. I can try to do some more digging  later this week.

Fixed in #941

Note that there still could be issues with the alignment, and #941 is not a perfect solution. If you have issues with this, we would recommend to use the TransformersRecognizer instead of the TransformersNlpEngine

repo: microsoft/presidio


text:
Add parameter names as labels to Function call block

Feature request submitted by an educator.
When introducing students to Functions, it would be helpful to include the parameter name as a label on the Call function block to help their understanding.

And then having something like this:

Yes it would be nice

@Jaqster It would be nice if default values could also be specified for these parameters, just like in TypeScript.

repo: microsoft/pxt


text:
don't try and find old copy of same project on load

fix https://github.com/microsoft/pxt-microbit/issues/2605; this was changed before in https://github.com/microsoft/pxt/pull/5535 but that basically got reverted in the ~160 commit github integration pr.
The behavior of loading the old project feels very confusing to me -- if I saw that it loaded the project, I'd probably think that meant the project was getting updated on the server as well / be very confused when i send the share link and my friend tells me there's a bug in it that isn't there when I load it.
Also dropped the return of the promise / 'async' suffix because it was just being called with an immediate .done()

made it async to match with importGithubProject; can make it return the header but it feels a bit weird having that be inconsistent with the function it's always called with (importGithubProject) / returning something and always just .doneing it.

let's go back to the non-async version without returning then.

Needs to be integrated in microbit branch

authors: jwunderl pelikhan


text:
Updated branding on header for documentation pages

yeah i was debating this, i thought it was a little weird to have the "MakeCode" text take you to the specific editor, but i'm willing to be convinced otherwise!! i think some of the docs (eg courses, etc) have links in the markdown itself but i definitely agree it's good to have something in the header


text:
Invariants page blank

https://microsoft.github.io/pybryt/html/annotations/invariants.html
Assuming "TODO", but it is blank :-)

Yeah, thanks for reminding me. This is an active TODO -- I'll add a note on the page while that's the case.

authors: chrispyles tonybaloney

repo: microsoft/pybryt


text:
Allow string references to be passed to ref argument in xl method

Passing a string of a spreadsheet range address to the xl method causes "NameError: name 'xl' is not defined"
It would be useful to be able to pass Names, connection names, range addresses etc as strings to the xl method.

I'm afraid this is rather fundamental as the Excel engine can automatically update row and column numbers when you insert or delete rows/columns.
On the other hand, $B$3 should never be a problem. Let's hope this will be adopted in the next release.

In the same vein, adding a tab index optional kwarg would be very helpful:

Is this fundamentally even possible? My question (and I think this question as well) is: is it possible to write to the xl() in a cell other than the one the python script is in?
It's easy to read from xl() :
a = xl("A1")
But is it possible to write:
a = 1
xl("B2") == a

Is this fundamentally even possible? My question (and I think this question as well) is: is it possible to write to the xl() in a cell other than the one the python script is in? It's easy to read from xl() : a = xl("A1") But is it possible to write: a = 1 xl("B2") == a

xl is a method that converts an Excel range, name or Power Query connection to some Python object. By default this is a DataFrame for Excel arrays of more than one cell, and a scalar for single-cell arrays, but it can be changed. I made a video about how to do that.
xl("B2") doesn't represent a cell. Rather, it applies the conversion to whatever data are in B2.
What I'm suggesting with this request is a Python in Excel analog to the INDIRECT function.

@ncalm
What I'm suggesting with this request is a Python in Excel analog to the INDIRECT function.
That is indeed what we need!

authors: Bobby-Miller WillemWannenburg ncalm salabim

repo: microsoft/python-in-excel


text:
Implement VS Code Formatter

This PR implements the skeleton for the VS Code formatter.  We have 2 basic rules for now:

Strip away any whitespace to the left of namespace. For example,
   namespace Microsoft.Quantum {} -> namespace Microsoft.Quantum {}.
Format operation definitions. For example:
operation   Foo(q:Qubit, n   :Int)   :  Bool -> operation Foo (q : Qubit, n : Int) : Bool

cc: @amrondonp, @swosti99

Apologies for the delay on the review; I thought I had hit submit but had it sitting open in a browser instead. Great work so far!

Looks like there was a failure in the testing of the VSCode extension. Is it possible something in these changes is showing up as a unit test when it shouldn't?
https://dev.azure.com/ms-quantum-public/Microsoft Quantum (public)/_build/results?buildId=12399&view=logs&j=aa540828-7369-5cca-9a86-6547727f16ff&t=5c10f11e-357e-5f9b-e70d-e2e6470f089e&l=1055

Actually, looks like quite a few commits were added between my original review and now. I'm going to take a look back through the files again. Thanks for adding testing!

authors: swernli theRoughCode

repo: microsoft/qsharp-compiler


text:
Change to allow a qubit to be released if it is measured

This PR is for a change I made to allow a qubit to be released if it has been measured and no operation has been made on it after the measurement. This involved adding an isMeasured field to Qubit, and setting its values appropriately. I also added 2 unit tests to confirm the desired behavior.

Releasing a Qubit measured in a different base, the qubit is still in super-position on the Z bases but it doesn't throw:     using (q = Qubit()) {
         H(q);
         let _ = Measure([PauliX], [q]);
     }

Quick comment, but this should be entirely OK, as the qubit is still in a deterministically known state at the point that it is released, such that appropriate instructions can be automatically added to reset it to the |0⟩ state.

For a bit of extra context, Aniket already found that the simulator handles release of qubits properly. See this code from the simulator.hpp elsewhere the repo:
    bool release(unsigned q)
    {
      recursive_lock_type l(mutex());
      bool allok = isclassical(q);
      if (allok)
      allok = (psi.getvalue(q)==false);
      else
      M(q);
      psi.release(q);
      return allok;
    }

When the qubit is released, the simulator will check if it's in a classical value (defined as |0> or |1> in the Z-basis), and if not, it performs a measure. That measure has code to explicitly collapses the state. Then it returns the boolean indicating whether the qubit was originally in a classical state and whether that classical state was |0>, then the higher level code in QubitManager would throw. So the simulator doesn't actually care and will handle the qubit no matter what state it is in, it's just a matter of what the QubitManager will allow, hence the fix that Aniket is building.

@swernli, yes, the simulator works correctly, and there is an option to disable this behavior (is just on by default).
The reason is on is because this is a common cause for invalid algorithms. You could question if there is a real value on doing this, since at the end users just get around this by calling Reset; I believe not having to call Reset but still throwing un-measured Qubits makes it more robust and makes the code cleaner.

The reason is on is because this is a common cause for invalid algorithms.

Agreed, but there's also value in that avoid reset by coherently unpreparing qubits is a common and useful optimization. For example, the target qubit in Deutsch–Jozsa is deterministically in |−⟩ after the query, such that an H and X operation call are sufficient to return the target qubit to |0⟩ for reuse, avoiding a potentially expensive measurement. Similarly, the same phase kickback trick is often used to perform common reflections, such that the state of a scratch qubit used in reflections can be efficiently unprepared without measurement or resetting.

Agreed on all points. I was just clarifying the simulator behavior because of some phrasing; as we are discussing this issue, we keep talking about what is "ok" or what "works" but any and all of these approaches can work, it's about what patterns we want to allow and encourage. So the question we should be asking ourselves is: what do we want the simulator to teach people about how to manage their qubits? What usage patterns do we want the simulator to reject so that it forces developers to adjust their programs?
The question of whether or not to clear the IsMeasured property when a qubit is used as a control is a very interesting one to me. Is using something as a control a "usage" in the sense that it invalidates the collapsing that occurred during the previous measure? Is that something that can vary between different kinds of qubits or hardware implementations? It's easy to ignore control qubits in the code, so either way can be quickly implemented. But I honestly don't know which way is correct given our goals of using this exception as instructive for algorithm correctness.

The question of whether or not to clear the IsMeasured property when a qubit is used as a control is a very interesting one to me. Is using something as a control a "usage" in the sense that it invalidates the collapsing that occurred during the previous measure? Is that something that can vary between different kinds of qubits or hardware implementations? It's easy to ignore control qubits in the code, so either way can be quickly implemented. But I honestly don't know which way is correct given our goals of using this exception as instructive for algorithm correctness.

Suppose after a measurement, the qubit left is left deterministically in the |+⟩ state, and then used as a control for a CNOT operation CNOT(left, right), where the initial state of right : Qubit is |0⟩. Immediately following that, the joint state of [left, right] is (|00⟩ + |11⟩) / √2.
Even worse, if you instead do a CNOT(left, right) with right starting in |−⟩, then the final state of the register is |−−⟩ not |+−⟩.
Put differently, the word "control" in the context of a controlled quantum operation is at most a mnemonic. A two-qubit operation can in general change the joint state of both qubits, even if one is only a "control." You can even reverse which qubit is a control and which is a target using H operations:
within {
    H(left); H(right);
} apply {
    CNOT(right, left);
}

// is equivalent to
CNOT(left, right);

From that perspective, I would strongly argue that IsMeasured has to be cleared when a qubit is used as a control in a quantum operation.

That's an excellent explanation, thanks @cgranade !

That's an excellent explanation, thanks @cgranade !

Thanks, happy to help!

I have to say, this is an exciting change from the libraries perspective! We've gotten feedback about the variety of different ways that measurement is used in the libraries, and in particular, that it's not clear when a reset is needed and not without looking at detailed API docs. This change would allow us to adopt the convention that measurements other than MReset* do not reset ever.

After looking at this thread, I am attempting to summarize the required changes:

The behavior for control qubits can stay as is, and thus the isMeasured should stay as false for the controls after a multi qubit operation
As far as properly releasing goes, the C++ side of the code handles it correctly
The only changes in behavior that would be required is around the DumpManager behavior which calls CheckQubit, but should be allowed to be Release if it has been previously Measured
@anpaz-msft @swernli @cgranade

That summary looks good to me (plus the renaming feedback which you already mentioned you'd be addressing).

After looking at this thread, I am attempting to summarize the required changes:

The behavior for control qubits can stay as is, and thus the isMeasured should stay as false for the controls after a multi qubit operation

That's correct; control qubits aren't special, such that the postcondition represented by isMeasured can be violated by passing qubits as controls. In particular, if I understand correctly, isMeasured represents the postcondition that the qubit is: (0) not entangled with any other qubits, and is (1) in a deterministically known state, such that it can be coherently returned to the |0⟩ state (that is, without further measurement).

@anpaz-msft Could you please take another look whether the changes you requested have been addressed?

authors: AniketDalvi anpaz-msft bettinaheim cgranade swernli

repo: microsoft/qsharp-runtime


text:
RFC add metadata_columns to RAIInsights

Description
This PR includes changes to

add a metadata_columns argument on RAIInsights (including input validation)
passes only features (excluding metadata_columns using drop) to predict and predict_proba methods
adjust managers:

causal needs no change since it doesn't use the model
error analysis needs to be aware of metadata_columns to use them for the error analysis calculations, but at the same time avoid passing metadata_columns to the model
explanations and counterfactuals just need to ignore metadata_columns so we don't pass them to that manager

Note that this is a DRAFT PR so I have deliberately not included the following yet since I want to work through potential comments:

tests
notebook adjustments and additions

Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] raiwidgets
[x] responsibleai
[x] erroranalysis
[ ] rai_core_flask

Tests

[ ] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #1207 (954dcd5) into main (4cd2487) will increase coverage by 15.80%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1207       +/-   ##
===========================================
+ Coverage   59.77%   75.58%   +15.80%
===========================================
  Files          90       10       -80
  Lines        4296      258     -4038
===========================================
- Hits         2568      195     -2373
+ Misses       1728       63     -1665

Flag
Coverage Δ

unittests
75.58% <ø> (+15.80%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...is/erroranalysis/_internal/surrogate_error_tree.py

...ranalysis/erroranalysis/analyzer/error_analyzer.py

responsibleai/responsibleai/_interfaces.py

...onsibleai/responsibleai/managers/causal_manager.py

...i/responsibleai/managers/counterfactual_manager.py

...i/responsibleai/managers/error_analysis_manager.py

...ibleai/responsibleai/managers/explainer_manager.py

...sibleai/responsibleai/rai_insights/rai_insights.py

...ponsibleai/responsibleai/_tools/shared/versions.py

erroranalysis/erroranalysis/_internal/utils.py

... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd2487...954dcd5. Read the comment docs.

@romanlutz not sure why these suddenly got included but we shouldn't be adding any datasets to git/source:

datasets make git slow, especially cloning, and git doesn't render/work with them well

I'm closing this as we've decided to move in a somewhat different direction led by @gaugup. The RFC has therefore served its purpose well 🙂

repo: microsoft/responsible-ai-toolbox


text:
ActivityTimeout for gRPC keep alive pings

What is the reason to ignore HTTP/2 protocol pings for reset ActivityTimeout?
In my case proxing gRPC stream with Keep Alive Pings not working as expected.

HTTP/2 and TCP pings are not propagated to user code, therefore ActivityTimeout does not know about them.
You set the ActivityTimeout to higher value, or you can try to enforce more gRPC traffic (e.g. gRPC pings if there is such a thing).

Thanks for reply!

authors: karelz oakio

repo: microsoft/reverse-proxy


text:
start.cmd should use unicorn to start app

The script needs to be updated to run the Quart app:
    echo.
    echo Starting backend
    echo.
    cd ..
    start http://127.0.0.1:8000
    call uvicorn app:app
    if "%errorlevel%" neq "0" (
        echo Failed to start backend
        exit /B %errorlevel%
    )

Fixed in #576

authors: MSimonart sarah-widder

repo: microsoft/sample-app-aoai-chatGPT


text:
Fix typo in Getting-Started-Notebook.ipynb

Motivation and Context

Description
authenication -> authentication
Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[ ] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

You need to enable actions on your fork in order for PRs to be accepted. Please re-open the PR when you have done so.

authors: eltociear lemillermicrosoft

repo: microsoft/semantic-kernel


text:
Semantic-Link-Labs library | schema enabled Lakehouse | Unsupported operation for schema enabled Lakehouse

Using Semantic-Link-Labs library in dataset migration with Microsoft Fabric schema enabled Lakehouse we get the message Unsupported operation for schema enabled Lakehouse.
I would like to if will be supported and if yes when

See #173 for the answer

authors: m-kovalsky somarine

repo: microsoft/semantic-link-labs


text:
[Question] - How to indentify the cause of high CPU usage within a Service Fabric application

Since a few months we see a steady increase in average CPU usage within our Service Fabric cluster.
It started from the 24th of April with a average CPU usage of 29% until the 11th of Juli with a average CPU usage of 80%.
After loggin in to one of the nodes within the cluster, we saw that one of the three Service Fabric applications was consuming alot CPU ranging from 40-90%.

The 11th of Juli we deleted the Service Fabric Application and redeployed it which decreased the average CPU usage to 16%.
But after that the CPU started slowly rising again, at this moment the average CPU usage is 20%.
I tried to investigate this with the Visual Studio diagnostic tools, but the tools are not supported for Service Fabric applications it seems.
My question is what are the options/possibillities to investigate this, to find out where the CPU increase is comming from.
Service Fabric Runtime Version:
10.1.2175.9590
Environment:

Azure
OS: Windows Server 2022 Datacenter
Version Latest

SF services are console apps. In VS cpu diagnostics tool, you simply connect to the service process. So, on your dev machine, launch your SF application from VS, then connect to the target service process and start the analysis session.

authors: GitTorre brewstertimothybrewster

repo: microsoft/service-fabric


text:
Upgrade to C# 10 language

Leverage:

Single-line namespace statements
Global using statements

The project is already .NET 6 and C# 10

authors: SvenAelterman softcraftsman

repo: microsoft/storage-as-a-service


text:
[Bug]:

Language
Javascript/Typescript, Python
Version
latest
Description
We're looking at the scenario where we can integrate Third party Idp in Microsoft teams message extension with SSO.
We got started with sample repo placed over here :
1.https://github.com/microsoft/teams-ai/tree/main/js/samples/05.authentication/e.teamsSSO-messageExtension
2. About 3rd party integration implementation : https://learn.microsoft.com/en-us/microsoftteams/platform/messaging-extensions/how-to/add-authentication
3. auth-start code we modified for 3rd party sign-in

4. here we're trying to create user signed-in session

The ultimate goal we're to do here have M365 copilot work for plugin and get items based on context.
example for assume gmail.com based on logged user it should be able to get mails.
Reproduction Steps
1. we revised the auth-start html pages to redirect it to third party and SSO was successful
2. We got the code back in end-auth.html
3. We're not able to create SSO session though we've successful sign-in done.

Many examples we've got all talk about Entra but no less examples of third party IDP integration part.

### Tasks

Can you elaborate more on how you're not able to create the SSO session? From the end users perspective (as well as the bot perspective) what happens once you get the code back in end-auth.html.

I'm looking for any elegant code where can save the code we receive at end-auth.html in turnState so the login link doesn't comes-up when user tries to do some search query.

Hey @ShujaathKhan ,
you can refer to my repository for third-party SSO.  - https://github.com/kjboogie/M365-Copilot-Plugin-Message-extension-SSO-Third-party-authentication
you cannot use ApplicationBuilder() to initiate the authentication for third party. This is only valid with Microsoft's internal sso auth, also you need to initiate authentication from the server side, specifically from  -
handleTeamsMessagingExtensionQuery( context: TurnContext,query: MessagingExtensionQuery ), so that when your client closes after token generation, via auth-end.html, we are sending back the token and it should be accessible inside this function by context.activity.value.state.
When your handleTeamsMessagingExtensionQuery() initiates something that goes outside the team's client, the team's client waits and captures in the same function inside -> 'context'.
In auth-end.html - microsoftTeams.authentication.notifySuccess(hashParams['code']); , this sends a response back to the teams client. We capture this code and generate tokens that are later set in the 'memory storage' of botbuilder .
From searchApps.ts -
we will send ComposeExtension of type 'auth' to the front end to initiate signing.
Create a function and call it from handleTeamsMessagingExtensionQuery(). You can call like - return this.staticHtmlPage();

From auth.html/auth-start.html -
We will call out the third-party auth URL with a redirect URL to auth-end.html

From auth-end.html -
we will send the generated code back to our team client i.e.handleTeamsMessagingExtensionQuery() . You can access the code by - context.activity.value.state

I am saving the token in UserStateand saving the UserState to MemoryStorage. Both of these are part of "botbuilder".
I am already initializing these in index.ts and passing them to searchapps while initializing them from index.ts.
Hope this solution will fix your problem.

Hi @ShujaathKhan can you share if this fixes your problem?

I'm closing this issue for now. @ShujaathKhan please re-open if your problem still persists.

authors: ShujaathKhan kjboogie singhk97

repo: microsoft/teams-ai


text:
Could the repo have a CODE_OWNERS.TXT?

Could the repo have a CODE_OWNERS.TXT as the CoreClr has?  This might be helpful.   I'm not 100% sold on people looking at this, but it is one way for people to know who they should ask.
Originally posted by @dlong11 in https://github.com/microsoft/terminal/issues/890#issuecomment-498915936

In theory, I like this, but I think of the four whole people who are on the console team, they all collectively own everything. I dunno.

I thought that might be the answer. 😄  Like I said I am not sure how effective this is.  Maybe when we have a public channel of communication this won't be needed.

Surely a *.md file, rather than *.txt.
But why not include this info in the README.md file, the list of code owners, and what their role is.  So contributors have an idea who to aim comments to.

We discussed this in triage today - since we triage all new issues once a week, we can usually put the right person on an issue in a pretty reasonable timeframe. Especially considering there's only 4 of us, we're never more than one hop away from the right person to answer a question.

authors: DHowett-MSFT dlong11 mdtauk zadjii-msft

repo: microsoft/terminal


text:
Rethink settings grouping

Referencing #754 and #1448, I think it's best to abandon separation between global/profile settings. Instead each setting could go to anywhere, but with profile settings overwriting global ones. There still will need to be global-only settings like showTabsInTitlebar or defaultProfile, but others could be made available as per-profile (e.g. keybindings or initialCols).
Additionally, I suggest a 'property groups' - groups of settings that you can '#include' in profiles (like include: ["guid1", "guid2"]). E.g. you may want to have consistent settings between wsl distros and anothers between cmd/ps profiles. (I can easily imagine profiles that differ only in command line, starting path or something like this, but have other settings, mostly, shared.)
Issues:

How should default settings look (what goes where?)
Design of settings GUI that support this might be hard

This'll probably be helped out a lot by #754 -- i'd like to hold off on further settings discussions until that one lands. We'd be happy to hear your settings feedback in 754 or on the spec review #1258.

authors: DHowett-MSFT mcpiroman


text:
Bug Report - Can't type pipe "|" and quick edit mode doesn't work

Environment

Microsoft Windows [Version 10.0.18362.175]
terminal version 0.2.1715.0

Steps to reproduce
I have a Canadian Multilingual keyboard ant to do a pipe symbol I have to use the right alt and the key before the 1 on a us layout I don't kown which one it is but on my keyboard is a slash (/).
Expected behavior
Able to write a "|" without pasting it and able to copy thing in the terminal window.
Actual behavior
The other bug I found is that I can't copy paste something. Normally, with quick edit enable you do select the text + "enter" or right click on the window title copy. The paste works.

Using AltGr for symbols is a dupe to #521.
Your copy/paste issues could be one of a multitude of things assigned to @carlos-zamora.
Please file one issue per bug that you find.
Please search for existing issues for your concerns before filing new ones.
Otherwise, thanks for your feedback. I'm closing this issue as it's duplicate data.

authors: TheMMcOfficial miniksa


text:
Title bar is sized incorrectly when switching monitor with different scaling

Environment
Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.6.2951.0

Monitor 1: 3840x2160 (225%)
Monitor 2 (new default): 2560x1440 (125%)

Steps to reproduce

Open Terminal and maximize its window
Attach a new default monitor to the device with a different scaling percentage from the previous one (the window is moved to the new monitor retaining its maximized state)
💥

It's easier to notice this if the new default monitor is placed on the left of the previous one.
Expected behavior
The title bar is sized correctly.

Actual behavior
The title bar is wider than the actual window by 9px.
Resizing the window fixes the width.
This is a little annoying because the 9px grey area goes on to the next monitor and it does nothing when you click on it.

I believe this is a /dupe of #2268

authors: DHowett-MSFT abarani


text:
Add X11 forwarding

Description of the new feature/enhancement:
I would like to be able to run the ssh -X (-Y)  command on a terminal and use the functionality available in PuTTY -> X11 Forwarding.
I got installed XLaunch and when I connect using PUTTY ssh, I can run GUI applications on remote linux server.
I was thinking if that can be done by windows terminal, without necessary to use PuTTY  or even XLaunch ?
Thanx !

If you can run ssh -X outside of Terminal you can certainly run it inside terminal. This sounds like a request for the Win32-OpenSSH team.

Hi there!
While it's technically possible to use X11 forwarding with Windows Terminal I have one case where it doesn't work.
When I open a WSL terminal and manually run ssh -X myhost I get a connection and can also open X11 programs. But when I use a custom profile with Command line "wsl.exe ssh -X user@myhost" I get a connection, too, but I cannot open X11 programs. Instead I get the usual error message:
xterm: Xt error: Can't open display:
xterm: DISPLAY is not set
So obviously there's a difference wrt. X11 forwarding between the "regular" WSL terminal (wsl.exe -d Ubuntu) and my custom profile. Is this a configuration error on my side, or is this a bug in Windows Terminal?
btw, I'm using the latest Preview version 1.10

It's likely that running wsl ssh skips parts of your profile initialization, or does not propagate the DISPLAY environment variable.

(This is by design)

Any idea how to do this differently, where to look for further information or whom to ask? Searching for wsl ssh x-forwarding didn't help much :-(

Hi @DHowett,
this issue is closed and my question is only partly related to the original question, so I wanted to post it somewhere else - but I don't have a clue where would be the best place to do so. Can you give me a hint? Is the behavior I reported "caused" by Windows Terminal, wsl or OpenSSH? And what is the correct reporting channel for the respective component?
Thanks in advance,
Torsten

@TomaszGrzmilas I also ran into this issue. Like the other said, it should not be Windows Terminal's issue. But I understand why you post here, since using PuTTY with Port Forwarding enabled simply works while Windows Terminal does not. I think PuTTY does many things under the hood in fact. To use other terminals than PuTTY, you can follow the note I wrote below.
Settings for SSH Clients Used On X11 Server (Workstation)
Option 1: Use PuTTY with Port Forwarding enabled
Option 2: Use ANY terminal with following steps

export DISPLAY environment variable in X11 Client's (remote) shell runcom file: *rc
# in ~/.bashrc or ~/.zshrc ...
export DISPLAY=<x11_server_name_or_ip>:<display_num>.<win_num>
# e.g.
export DISPLAY=myhome.com:0.0
# or just
export DISPLAY=myhome.com:0

allow ports 6000-6063 in Firewall setting
ref: https://forums.anandtech.com/threads/what-port-does-x11-traffic-use.618859/

Start X11 Server with access control disabled, e.g., start VcXsrv with option: Disable Access Control (Don't forget this. Otherwise, it will show authentification error.)

All three steps need to be done, otherwise, it won't work.
FYI

export DISPLAY environment variable in X11 Client's (remote) shell runcom file: *rc# in ~/.bashrc or ~/.zshrc ...
export DISPLAY=<x11_server_name_or_ip>:<display_num>.<win_num>
# e.g.
export DISPLAY=myhome.com:0.0
# or just
export DISPLAY=myhome.com:0

How do I find my x11 server name and display num?

export DISPLAY=localhost:11.0 in .zshrc.
start xming
done

update:
X11 forwarding  success only if I keep mobaxterm ssh to the same remote machine with the same  localhost:11.0   (Using mobaxterm, DISPLAY will be set by mobaxterm, not forced to localhost:11.0 by zshrc
my zshrc

Same code as above, but with my notes:

.zshlogin:
(excuted after .zshrc)

update: X11 forwarding success only if I keep mobaxterm ssh-ing to the same remote machine with the same localhost:11.0 (Using mobaxterm, DISPLAY will be set by mobaxterm, not forced to localhost:11.0 by zsh' s config ) This implies that it is the X-server integrated in mobaxterm, instead of Xming, that makes x11 forward success in the situation of my reply above. but I want to uninstall mobaxterm!
How to make Xming/VcXxvr works for windows terminal ?
my zshrc
Same code as above, but with my notes:
.zshlogin: (excuted after .zshrc)

Allowed by firewall

Exactly the same problem with you

authors: DHowett DHowett-MSFT TomaszGrzmilas Zhaoyilunnn ciaochiaociao hensz sisrfeng zxleong


text:
[SUI] Polish Launch Parameters setting controls

Summary of the Pull Request
Performs some cleanup in the Settings UI for the Launch Parameters settings:

Updates all NumberBox controls in the Settings UI to have a Compact SpinButtonPlacementMode instead of an inline one. This alleviates the XAML bug where the spin button would appear over the number box's input value.
Fixes an issue where a long X/Y value would resize the settings controls weirdly. This was fixed by introducing a Grid inside the main grid and applying a width to the number boxes.
Rename "Use system default" checkbox to be more clear. Propagate the new localized string into expander preview.

Closes #14558

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

Ask and you shall receive:

Tested with resizing the window too. Nothing gets cropped.

"let system position window, centered" is a funny juxtaposition. In that specific case, it means "Let system select which monitor" (but we should phrase it better...)

@msftbot merge this in 10 minutes

authors: DHowett carlos-zamora zadjii-msft


text:
Add getDefinitionAndBoundSpan

Hi, I'm writing a plugin that implements Go to Definition to a file within a template literal that needs getDefinitionAndBoundSpan .

Thanks! Will publish new version shortly

authors: mjbvz yesmeck


text:
install correct node version

Fixes https://github.com/microsoft/typespec/issues/3149

No changes needing a change description found.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3345/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3345/

authors: azure-sdk m-nash

repo: microsoft/typespec


text:
sdl2[core]:x64-linux build failure

Host Environment

OS: Linux (WSL) Ubuntu [2.0.04.1 LTS] (seems to install and work just fine on Windows and OS X)
Compiler: N/A (doesn't get that far)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install sdl2
Failure logs
Computing installation plan...
The following packages will be built and installed:
    sdl2[core]:x64-linux
Detecting compiler hash for triplet x64-linux...
Starting package 1/1: sdl2:x64-linux
Building package sdl2[core]:x64-linux...
Could not locate cached archive: /home/brian/.cache/vcpkg/archives/5f/5fc3a434f92da0414edb660695528208c02bc507.zip
-- Using cached /home/brian/vcpkg/downloads/SDL2-2.0.12.tar.gz
-- Cleaning sources at /home/brian/vcpkg/buildtrees/sdl2/src/SDL2-2-ac07e8117e.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/brian/vcpkg/downloads/SDL2-2.0.12.tar.gz
-- Applying patch export-symbols-only-in-shared-build.patch
-- Applying patch enable-winrt-cmake.patch
-- Applying patch disable-hidapi-for-uwp.patch
-- Applying patch fix-space-in-path.patch
-- Applying patch disable-wcslcpy-and-wcslcat-for-windows.patch
-- Applying patch fix-EventToken-header-reference.patch
-- Applying patch 0006-sdl2-Enable-creation-of-pkg-cfg-file-on-windows.patch
-- Using source at /home/brian/vcpkg/buildtrees/sdl2/src/SDL2-2-ac07e8117e.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Fixing pkgconfig file: /home/brian/vcpkg/packages/sdl2_x64-linux/lib/pkgconfig/sdl2.pc
-- CHECK_LIB_glib-2.0_RELEASE:CHECK_LIB_glib-2.0_RELEASE-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:232 (message):
  Library "glib-2.0" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:298 (vcpkg_fixup_pkgconfig_check_files)
  ports/sdl2/portfile.cmake:97 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Error: Building package sdl2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: sdl2:x64-linux
  Vcpkg version: 2020.06.15-unknownhash

Additional context
This started happening after updating vcpkg from git.  If I manually install "glib" via vcpkg, I then get an error on not finding ibus-1.0.  This isn't available in vcpkg.  I have installed via apt-get, but the error persists.

Hi @BrianPeek
Thanks for posting this issue.
I try to reproduce this on my local with WSL Ubuntu 18.04 and I can build successfully.
vruil@ruiltest01:~/vcpkg$ ./vcpkg install sdl2
Your feedback is important to improve Vcpkg! Please take 3 minutes to complete our survey by running: vcpkg contact --survey
Computing installation plan...
The following packages will be built and installed:
    sdl2[core]:x64-linux
Detecting compiler hash for triplet x64-linux...
Starting package 1/1: sdl2:x64-linux
Building package sdl2[core]:x64-linux...
Could not locate cached archive: /home/vruil/.cache/vcpkg/archives/35/356fd5b229f62e68a182a0aefbbe1a6562133566.zip
-- Using cached /home/vruil/vcpkg/downloads/SDL2-2.0.12.tar.gz
-- Cleaning sources at /home/vruil/vcpkg/buildtrees/sdl2/src/SDL2-2-ac07e8117e.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/vruil/vcpkg/downloads/SDL2-2.0.12.tar.gz
-- Applying patch export-symbols-only-in-shared-build.patch
-- Applying patch enable-winrt-cmake.patch
-- Applying patch disable-hidapi-for-uwp.patch
-- Applying patch fix-space-in-path.patch
-- Applying patch disable-wcslcpy-and-wcslcat-for-windows.patch
-- Applying patch fix-EventToken-header-reference.patch
-- Applying patch 0006-sdl2-Enable-creation-of-pkg-cfg-file-on-windows.patch
-- Using source at /home/vruil/vcpkg/buildtrees/sdl2/src/SDL2-2-ac07e8117e.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Fixing pkgconfig file: /home/vruil/vcpkg/packages/sdl2_x64-linux/lib/pkgconfig/sdl2.pc
-- Fixing pkgconfig file: /home/vruil/vcpkg/packages/sdl2_x64-linux/debug/lib/pkgconfig/sdl2.pc
-- Performing post-build validation
-- Performing post-build validation done
sh: 1: zip: not found
Failed to store binary cache /home/vruil/.cache/vcpkg/archives/35/356fd5b229f62e68a182a0aefbbe1a6562133566.zip: No such file or directory
Building package sdl2[core]:x64-linux... done
Installing package sdl2[core]:x64-linux...
Installing package sdl2[core]:x64-linux... done
Elapsed time for package sdl2:x64-linux: 4.87 min

Total elapsed time: 4.988 min

The package sdl2:x64-linux provides CMake targets:

    find_package(SDL2 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE SDL2::SDL2main SDL2::SDL2-static)

I also checked sdl2.pc, there is no glib in this file. So I don't know why this posts glib-2.0 not found.

I just blew away my vcpkg directory and re-cloned from github, bootstrapped, and tried again fresh.  Still getting the same error.  :(  That said, my sdl2.pc file is showing glib (and ibus, my 2nd error):
sdl pkg-config source file
prefix=${pcfiledir}/../..
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
Name: sdl2
Description: Simple DirectMedia Layer is a cross-platform multimedia library designed to provide low level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL, and 2D video framebuffer.
Version: 2.0.12
Requires:
Conflicts:
Libs: -L${libdir} -Wl,-rpath,${libdir} -Wl,--enable-new-dtags -pthread -lSDL2
Libs.private: -lglib-2.0 -lgobject-2.0 -lgio-2.0 -libus-1.0 -ldbus-1 -l/usr/lib/x86_64-linux-gnu/libsndio.so -ldl -lm  -Wl,--no-undefined -pthread -lSDL2
Cflags: -I${includedir}/SDL2  -D_REENTRANT

Upon further research, it appears the recent addition of this to the sdl2\portfile.cmake file has broken this for me:
set(DYLIB_COMPATIBILITY_VERSION_REGEX "set\\(DYLIB_COMPATIBILITY_VERSION (.+)\\)")
set(DYLIB_CURRENT_VERSION_REGEX "set\\(DYLIB_CURRENT_VERSION (.+)\\)")
file(STRINGS "${SOURCE_PATH}/CMakeLists.txt" DYLIB_COMPATIBILITY_VERSION REGEX ${DYLIB_COMPATIBILITY_VERSION_REGEX})
file(STRINGS "${SOURCE_PATH}/CMakeLists.txt" DYLIB_CURRENT_VERSION REGEX ${DYLIB_CURRENT_VERSION_REGEX})
string(REGEX REPLACE ${DYLIB_COMPATIBILITY_VERSION_REGEX} "\\1" DYLIB_COMPATIBILITY_VERSION "${DYLIB_COMPATIBILITY_VERSION}")
string(REGEX REPLACE ${DYLIB_CURRENT_VERSION_REGEX} "\\1" DYLIB_CURRENT_VERSION "${DYLIB_CURRENT_VERSION}")

vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/sdl2.pc" "-lSDL2" "-lSDL2d")

vcpkg_fixup_pkgconfig(IGNORE_FLAGS "-Wl,-rpath,${CURRENT_PACKAGES_DIR}/lib/pkgconfig/../../lib" "-Wl,-rpath,${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/../../lib" "-Wl,--enable-new-dtags" "-Wl,--no-undefined" "-Wl,-undefined,error" "-Wl,-compatibility_version,${DYLIB_COMPATIBILITY_VERSION}" "-Wl,-current_version,${DYLIB_CURRENT_VERSION}" "-Wl,-weak_framework,Metal" "-Wl,-weak_framework,QuartzCore")

Commenting out this addition allows sdl2 to build/install correctly.  @Sibras, it appears you made this update, any idea why this might break for me?
Thanks for any insight!

SDLs cmake script is automatically detecting additional non vcpkg libraries that you have optionally installed in your wsl instance and is linking against them. Based on your pkgconfig file these appear to be 'dbus ibus libsndio'. Since these libs are not installed by default others are not able to reproduce it and vcpkg_fixup_pkgconfig has not been made aware of them.
Looking at the cmake script for sdl it doesnt appear there is an option to disable the automatic detection and inclusion of dbus/ibus. Short term just uninstalling these will stop sdl from detecting them. Otherwise they will need to be added to the known system lib list in scripts/cmake/vcpkg_common_definitions.cmake.
The sndio issue should be fixable though (although I havnt tested it) by updating the sdl portfile to
vcpkg_configure_cmake(
    SOURCE_PATH ${SOURCE_PATH}
    PREFER_NINJA
    OPTIONS ${FEATURE_OPTIONS}
        -DSDL_STATIC=${SDL_STATIC}
        -DSDL_SHARED=${SDL_SHARED}
        -DFORCE_STATIC_VCRT=${FORCE_STATIC_VCRT}
        -DLIBC=ON
        -DSNDIO_SHARED=ON
)

Try those and see of they work

Got it.  Uninstalling libs for dbus, ibus, and libsndio fixed everything.  That said, I'm not entirely sure how they got there.  I truly appreciate the help and explanation of the issue, I learned something new.
Thank you!

authors: BrianPeek NancyLi1013 Sibras

repo: microsoft/vcpkg


text:
[libarchive] update to 3.5.0

Library name: libarchive
New version number: 3.5.0
https://github.com/libarchive/libarchive/releases/tag/v3.5.0

3.5.1 is now available: https://github.com/libarchive/libarchive/releases/tag/3.5.1

authors: Thieum mirostauder


text:
ffmpeg[all] need fix

ffmpeg[all] for any arm plantform not need amd-amf
amd-amf only used by amd plantform, and amd not have arm device

@WangHHY19931001 Do you mean that only ffmpeg[amd-amf] only supports amd? Or does it mean that this port amd-amf supports amd?

just arm not need it