text:
[Bug Report] Cant set height of textarea

Element UI version
2.2.0
OS/Browsers version
win10  chrome63
Vue version
2.5.13
Reproduction Link
https://jsfiddle.net/mmx38qxw/272/
Steps to reproduce
1、textarea 外包裹 一个 div,
2、div 设置一个高度
3、textarea 设置高度 100%
What is Expected?
textarea 高度达到 100%
What is actually happening?
然并卵

https://jsfiddle.net/leopoldthecuber/mmx38qxw/273/

@Leopoldthecoder 除了这个，有没有更优雅的方案？

authors: Leopoldthecoder zjxpcyc


text:
Add SeqDropout

I change the Dropout implentation of Torch/nn, get a dropout module that could be used for SeqLSTM, SeqGRU and SeqBRNN. the whole sequence will share the same mask which is diferrent from nn.Dropout.

I am not good at both coding and english, I appreciate any kinds of your help.

👍 I think this module does not need to be restricted to SeqLSTM, SeqGRU etc. Also it would be helpful if this module could support :remember('both').
For anyone interested why you want to do this, read: https://arxiv.org/pdf/1603.05118v2.pdf

@JoostvDoorn Thank you for your support. This module was considered to used before SeqRNN implementation, and I'm not clear how to implement remember in this module, I just used it like that:
nn.Sequential():add(nn.SeqDropout()):add(nn.SeqGRU(128,128))
In my understanding, remember was a method of AbstractSequencer and maybe there should be some changes in SeqLSTM, SeqGRU etc, but sorry for I do not know how to make it work, the codes were to hard for me.

That's okay, someone else (or me) should be able to implement remember for this fairly easily. Regarding it being only for SeqGRU etc., you can use it like this nn.Sequential():add(nn.SeqDropout(0.2)):add(nn.Sequencer(nn.GRU(128,128))). So we do not need to restrict this in the documentation.

@JoostvDoorn Thank you for your help, I do not have enough experience in this area, your advise is very helpful for me.

source: gharchive/pull-request

authors: JoostvDoorn anoidgit

repo: Element-Research/rnn

license_type: permissive

license_source: bigquery


text:
Jets for issuance entropy and asset IDs.

Only the code in C needs to be reviewed.

The sha256_midstate type is simply a 256-bit buffer.  Other stuff is in the sha256_context type.

repo: ElementsProject/simplicity

license: MIT

license_source: github-api


text:
Separate functions for downloading pre-processed and datasets and downloading & processing

I think it would be a good idea, where possible, to have separate functions in the pile for downloading a pre-processed version of the dataset from a hosted version (i.e a single wget) and running the entire replication step.
The Stackexchange dataset, for example, requires a large amount of storage for processing, and is pretty slow. It's good that people are able to recreate the pipeline if possible (and the stackexchange data on archive.org is being updated fairly regularly, so will grow over time), but in general, it would be better to host the data somewhere.
There are also some functions that only provide download, and no replication steps. I think these two things should be separated where possible.
So, we should first provide a hosted dataset, then fall back to full downloading and pre-processing, if, say, we can no longer host.

I think that providing the replication code and a way to directly download the processed data sets separately is a great idea. I would go as far as to say that it's necessary for usability.

source: gharchive/issue

authors: StellaAthena sdtblck

repo: EleutherAI/The-Pile


text:
adding boilerplate coverity scan to submit to public analysis

Generic boilerplate coverity scan workflow:
Downloads coverity build tool
Builds from project code
Uploads a build to scan queue

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant jaimemcc-intel

repo: EleutherAI/gpt-neox


text:
Task.construct_requests cannot be a generator (i.e., must return requests, not yield them)

The documentation on task creation suggests that Task.construct_requests does not have to return a list, but can be a generator. Is that intended?
It seems that implementations of construct_requests mostly return tuples. Grepping for yield in lm_eval/tasks/ does not show any cases of construct_requests implemented as a generator.
When I yield values from my implementation of construct_requests, I get an error:
Traceback (most recent call last):
  File "/home/tanner/git/club/build/git/lm-evaluation-harness/main.py", line 116, in <module>
    main()
  File "/home/tanner/git/club/build/git/lm-evaluation-harness/main.py", line 83, in main
    results = evaluator.simple_evaluate(
  File "/home/tanner/git/club/build/git/lm-evaluation-harness/lm_eval/utils.py", line 264, in _wrapper
    return fn(*args, **kwargs)
  File "/home/tanner/git/club/build/git/lm-evaluation-harness/lm_eval/evaluator.py", line 92, in simple_evaluate
    results = evaluate(
  File "/home/tanner/git/club/build/git/lm-evaluation-harness/lm_eval/utils.py", line 264, in _wrapper
    return fn(*args, **kwargs)
  File "/home/tanner/git/club/build/git/lm-evaluation-harness/lm_eval/evaluator.py", line 253, in evaluate
    requests[req.request_type].append(req)
AttributeError: 'generator' object has no attribute 'request_type'

This leads me to believe that implementing construct_requests as a generator is not really supported. Is that correct?

Thanks for raising this! This does seem to be correct, so I've updated the documentation to reflect this.
If the task you are implementing would require using a generator, then happy to discuss why this might be to better understand the use case, and to add this as a feature!

It wasn't a requirement. Based on the docs, I implemented the function as a generator, and so I was confused when it didn't work. With the docs updated, I think it's fine to just call this done. I don't have a feature request or anything. Thanks!

authors: haileyschoelkopf tanner-sorensen

repo: EleutherAI/lm-evaluation-harness


text:
Update NoticIA prompt

The prompt in the NoticIA task is not correct. I have updated it to be the same as in the paper (https://arxiv.org/pdf/2404.07611) and the official GitHub repo (https://github.com/ikergarcia1996/NoticIA/blob/main/prompts.py)
I am the author of the original commit that implemented NotiIA, the prompt implemented in the repo corresponds to an older version of prompt that had a few mistakes. We updated it in the final version of the paper and github repo.

Thanks, appreciate the PR!


text:
Interaction error

Hi, how can i fix that?

@T0miiis Are you sure that your handler is supporting the way the command being executed?
Additionally, "The reply to this interaction has not been sent or deferred." comes when you try to edit a response of Interaction, without actually making the response.

Fixed thru Discord Server Support


text:
Скласти таймлайн

Скласти список всіх (важливих) життєвих подій, визначних дат, досягнень, періодів, що дали приємний і неприємний досвід, тощо. В цьому конкретному випадку довгих списків не буває, натомість бувають погано згорнуті, тому пакуємо сюди все підряд, а про "лишні" події можна буде промовчати пізніше. Список повинен бути систематизованим і посортованим в такий спосіб, щоб читач швидко зрозумів "паттерн" і міг легко орієнтуватись в просторі і часі цього резюме.

Coment

EXPERIENCE
2018 Amongst many fighters of the past was featured in the movie "Ready Player One". Ryu ready always!
2017
United with unknown until then to me Power Rangers to defea resurrected M.Bison.Damn good fighters they are, even not knowing karate ways!
2016
In "Street Fighter V" once and for all erased M.Bison from earth and tamed my inner Evil Ryu. Also spent some time on a side-project, mini-series "Street Fighter: Resurrection".
2014
Filmed in a martial arts tutorial "Street Fighter: Assassin's Fist", revealing to audience forgotten art of Ansatsuken.
2012 The gods of intenet concluded me in the animated movie "Wreck-It Ralph", but rewarded me with a good drink for it!
2008
My evil alter ego sneaked out of control and became a boss in "Street Fighter IV".
2006
Borrowed my famous ripped gi to Soki in "Onimusha: Dawn of Dreams", gods informed me he needed that for the battle.
1998
Defeated M. Bison in "Street Fighter Alpha 2", bastard wanted to use my heroic body for his evil intentions, but retreated with shame. Also this year I encountered Marvel universe in "Marvel vs. Capcom: Clash of Super Heroes" fighter,loyal to my employer, Capcom, of course.
1997
Reunited with Ken, my friend and opponent in "Street Fighter III". Men's friendship works mysteriously. Also helped with Arika project "Street Fighter EX"
1996
Took care of villainous Akuma in "Street Fighter Alpha 2". As a freelance on "Super Puzzle Fighter II Turbo" tried myself in a new genre, puzzle games. Let the wrath of seven heavens come upon these malicious enigmas, never again!
1995
Kept fighting in "Street Fighter Alpha: Warriors' Dreams".
1994 Screened in a movie "Street Fighter", so that the batllesof past would not be forgotten by millenial generation.
1991
Was promoted to "Street Fighter II". Didn't stay there for long, celebrations and office dwelling is not for me!
1987
Started working for Capcom project "Street Fighter". My partner was Ken Masters, the boss'name was Sagat.
PUBLICATIONS
2011 The true and humble story of me under pseudonim Tyler Wilde in an article "The evolution of Ken and Ryu"
2003-2018 For 15 years I have published comic books with Udon Entertainment depicting my adventures, bitter lessons and great victories.


text:
Great scaler!  However, there is a significant shift towards magenta with each loop.

Are you also seeing this, as I have many examples of this occurring on 1.5 DDIM?

I'll have to dig into the issue.  If it's a problem with the sampler we can test with other samplers.  Also, this looper is something you can do manually.  I'll take some time this weekend and see if I can figure out if it's sampler based.

I tested this weekend and I do not see a significant shift towards magenta each loop, but that likely has more to do with model used and sampler than the looper code specifically.  The Loopback Scaler just takes a source image and increases the size by an amount divided by the target size and the number of loops.  Once an image is generated using img2img, the resulting image is then set as the source for the next loop.  So, the Loopback Scaler script doesn't do anything to the image, it just uses the A1111 framework to continually generate images and feed them back in for another loop.
If this is something you are still struggling with, please let me know what models you are using and share some examples.

authors: Elldreth sedetweiler


text:
Fixed meta table method(s) for PDO

Recent PDO code can't determine the _list_tables method for SQLite. Also current field_data method, returning meta field information in PDO spec, instead in CI spec as describe on Documentation

I think the PDO driver is getting a little messy with all these driver-specific workarounds. Should we sub-class the pdo driver into subdrivers instead?

@timw4mail yes, a pdodriver folder within the pdo, contain all subclass needed will be more nice than the recent code. If it get more bloated than this, and soon we have appropriate unit testing to test against all db package (as a whole), we could start re-writing DB package stuff.
But for now, i am still happy with the recent code.

repo: EllisLab/CodeIgniter


text:
[Help] Using Icons

Hi, I am unsure of how to customise the icons. Do i need to code it or something?
Thanks in advance!

Hi! You have to input the name of the icon you want to use. You can find a list of the icons and their names on the Lucide website, which is linked in the screenshot you showed. Good luck!

authors: Ellpeck mentosweet

repo: Ellpeck/ObsidianCustomFrames


text:
Require local size x dimension and remove gl_

Implements #486

Removes the gl_ prefix from the compute shader attribute.
Shortens the thread dimension declaration to threads(x, y, z).
Requires the x dimension to be specified.
Trailing ones may be elided for the y or z dimensions.

// old syntax: #[spirv(gl_compute(local_size_x = 128, local_size_y = 32, local_size_z = 64))]
#[spirv(compute(threads(128, 32, 64)))]

// equivalent to: #[spirv(compute(threads(32, 1, 1)))]
#[spirv(compute(threads(32)))]

// equivalent to: #[spirv(compute(threads(64, 32, 1)))]
#[spirv(compute(threads(64, 32)))]

@XAMPPRocky Done 🙂

repo: EmbarkStudios/rust-gpu


text:
Compile PhotoshopAPI with address sanitizers and wall

In order to get the PhotoshopAPI closer to being production ready we should always compile it with /Wall and /fsanitize=address (This is the only sanitizer currently supported out of the box with MSVC). Especially since our test cases cant and wont ever be able to cover all possible issues

Partial implementation by implementing sanitizers and Clang as an additional test suite, increasing warning levels is still TBD

Some considerations for MSVC warnings would be these:
/W4 /w44062 /w44165 /w34365 /we4464 /w45263
where
4062 is for a switch misses some enum members.
4165 is for HRESULT being used as a bool (almost always a mistake)
4365 is for signed/unsigned mismatch in integer conversion
4464 is for #include containing .. in the path (this should never happen)
5264 is for using std:move when returning a temporary.

repo: EmilDohne/PhotoshopAPI


text:
feature(dashboard): withdrawal deregistration warning dialog revamp

Description / Change(s) / Related issue(s)
It was necessary to change a default style of the Modal component in order to implement the new style of the withdrawal warning
Ticket
YOMO-1532

[!NOTE]
Please create the ticket if missing it.

In Android, space in the bottom is too much. And there's no horizontal padding

@jorbuedo thanks for the check 👍🏻
yes, that's the second dialog. I missed that one

changed to draft to implement the missing dialog

authors: banklesss jorbuedo

repo: Emurgo/yoroi


text:
Enhance brokered address space's address controller (agent) to populate address plan status

Type of change

Enhancement / new feature

Description
Enhance brokered address space's address controller (agent) to populate address plan status.
This change supports the max address size / message TTL work.
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=isolated

@enmasse-ci run tests profile=isolated

@lulf PR rebased.  I also reverted an unintentional delete agent/lib/broker_address_settings.js

@enmasse-ci run tests  testcase=PlansTestStandard,PlansTestBrokered

:heavy_exclamation_mark: Build Failed :heavy_exclamation_mark:

@enmasse-ci run tests testcase=PlansTestStandard,PlansTestBrokered

@enmasse-ci run tests profile=isolated

Test Result (2 failures / -4)
io.enmasse.systemtest.isolated.catalog.ServiceCatalogWebTest.testConsoleErrorOnDeleteAddressSpace
io.enmasse.systemtest.isolated.monitoring.MonitoringTest.testAddressQueries

authors: enmasse-ci k-wall

repo: EnMasseProject/enmasse


text:
changing regex to match everything after the ':'

Say for example nsswitch.conf has:
automount:  foo
sudoers:  bar

The current resource will create new lines lines for automount and sudoers which causes issues due to duplication. e.g:
automount:  foo
sudoers:  bar

automount:  files sss
sudoers:  files sss

This change enables the resource to actually update the values by matching everything after the : following the key names. So puppet will write it properly with only:
automount:  files sss
sudoers:  files sss

We are releasing this fix as a part of https://github.com/EncoreTechnologies/puppet-ipa/pull/14

repo: EncoreTechnologies/puppet-ipa


text:
🛑 OculusDB is down

In 8d6dd00, OculusDB (https://oculusdb.rui2015.me/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: OculusDB is back up in e5ce43b.

repo: EnderdracheLP/Beat-Saber-Uptime


text:
Set an object's default version to 1 when it is created,…

…rather than when it is stored, to allow undef versions (which can then be stored as NULLs in the database).

Coverage increased (+0.02%) to 81.852% when pulling 56f2d59f813ad791444dae160b3ff1dd5b239749 on james-monkeyshines:master into 985f2e3665ea4ffa98e6e70bfb272d31ec6a6065 on Ensembl:master.

that looks fine to me, thanks for the change

repo: Ensembl/ensembl


text:
extract dashboard listing into separate file

a lot of additional data necessary

done


text:
🛑 DataHorizon is down

In 023c6cb, DataHorizon (https://data.horizonfx.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: DataHorizon is back up in 179664e after 4 minutes.

repo: EnvyxLinzie/times-hzfx


text:
Dark themed notepad

https://discord.com/channels/81902207070380032/1118878035672846477

LGTM

LGTM

i do not speak Nerd

repo: Epix-Incorporated/Adonis


text:
Standard incorrect for test 7.12 in 6.7.12.2.b

Whereas the implant was an unexpected a two for one.  There is a question as to what should be the standard for 7.12.  One clear strategy is don’t implant a two for one.  The first detected DTC is what should (most likely) appear, and was provided.  It was flagged a a failure.
Start Test 7.12 - DM25: Expanded freeze frame
13:56:41.9442 Destination Specific DM25 Request to Engine #1 (0)
13:56:41.9467 18EA00F9 [3] B7 FD 00 (TX)
13:56:41.9537 18E8FF00 [8] 01 FF FF FF F9 B7 FD 00
Acknowledgment from Engine #1 (0): Response: NACK, Group Function: 255, Address Acknowledged: 249, PGN Requested: 64951
13:56:41.9552 Destination Specific DM25 Request to Engine #2 (1)
13:56:41.9577 18EA01F9 [3] B7 FD 00 (TX)
13:56:41.9657 18FDB701 [8] 00 00 00 00 00 FF FF FF
DM25 from Engine #2 (1):
Freeze Frames: [
No Freeze Frames
]
13:56:41.9672 Destination Specific DM25 Request to Exhaust Emission Controller (61)
13:56:41.9707 18EA3DF9 [3] B7 FD 00 (TX)
13:56:42.3807 18FDB73D [131] 82 A9 F0 F0 01 CC 03 00 00 00 00 00 FE 00 00 00 63 31 C6 6C 50 01 F1 00 50 25 CC 29 00 00 00 16 00 00 7D 7D 80 51 80 25 00 32 A0 42 B6 B7 E0 E1 D5 F0 04 00 00 00 64 00 64 00 64 00 64 00 64 00 64 00 64 8A 29 C2 00 00 98 26 31 70 94 3B 37 32 E8 28 D2 2F 00 00 00 00 01 05 31 01 00 00 00 00 00 00 01 0E 1B 03 00 0C 60 28 00 00 37 32 D2 2F 19 03 00 00 00 00 00 00 2F 02 AB 1F 04 FF FF 00 00 FF 03
DM25 from Exhaust Emission Controller (61):
Freeze Frames: [
Freeze Frame: {
DTC 520361:16 - Manufacturer Assignable SPN, Data Valid But Above Normal Operating Range - Moderately Severe Level - 1 times
SPN Data: CC 03 00 00 00 00 00 FE 00 00 00 63 31 C6 6C 50 01 F1 00 50 25 CC 29 00 00 00 16 00 00 7D 7D 80 51 80 25 00 32 A0 42 B6 B7 E0 E1 D5 F0 04 00 00 00 64 00 64 00 64 00 64 00 64 00 64 00 64 8A 29 C2 00 00 98 26 31 70 94 3B 37 32 E8 28 D2 2F 00 00 00 00 01 05 31 01 00 00 00 00 00 00 01 0E 1B 03 00 0C 60 28 00 00 37 32 D2 2F 19 03 00 00 00 00 00 00 2F 02 AB 1F 04 FF FF 00 00 FF 03
}
]
FAIL: 6.7.12.2.b - Exhaust Emission Controller (61) did not reported DTC in Freeze Frame data which included the DTC provided by DM23 earlier in this part
End Test 7.12 - DM25: Expanded freeze frame
6.7.12.2 Fail Criteria
a. Fail if no ECU reports Freeze Frame data.
b. Fail if DTC in reported Freeze Frame data does not include the DTC provided by DM23 earlier in this part.
c. Fail if NACK not received from OBD ECUs that did not provide DM25 message.
Failure criteria did not anticipate the two for one response and qualify which DTC in DM23 to check.
The one one the left cannot be guaranteed... as push can add the new DTC to the front of the list and not the end of the list.
b. Fail if DTC in reported Freeze Frame data does not include the first DTC detected in part 3.
may seem to be indicated.  But since the 2nd DTC may have priority over the the 1st.  The better answer is:
b. Fail if DTC in reported Freeze Frame data is not also displayed in DM23 response provided earlier in this part.
13:56:35.6357 Destination Specific DM23 Request to Exhaust Emission Controller (61)
13:56:35.6377 18EA3DF9 [3] B5 FD 00 (TX)
13:56:35.6822 18FDB53D [10] 03 FF A9 F0 F0 01 A9 F0 E2 01
DM23 from Exhaust Emission Controller (61): MIL: off, RSL: off, AWL: off, PL: not supported
DTC 520361:16 - Manufacturer Assignable SPN, Data Valid But Above Normal Operating Range - Moderately Severe Level - 1 times
DTC 520361:2 - Manufacturer Assignable SPN, Data Erratic, Intermittent Or Incorrect - 1 times
WARN: 6.7.2.3.c - OBD ECU Exhaust Emission Controller (61) reported > 1 previously active DTCs
End Test 7.2 - DM23: Emission related previously active DTCs
Start Test 3.2 - DM6: Emission related pending DTCs
Attempt 1
13:39:13.1252 Global DM6 Request
13:39:13.1282 18EAFFF9 [3] CF FE 00 (TX)
13:39:13.1412 18FECF3D [8] 03 FF A9 F0 F0 01 FF FF
DM6 from Exhaust Emission Controller (61): MIL: off, RSL: off, AWL: off, PL: not supported
DTC 520361:16 - Manufacturer Assignable SPN, Data Valid But Above Normal Operating Range - Moderately Severe Level - 1 times
13:39:13.1427 18FECF01 [8] 03 FF 00 00 00 00 FF FF
DM6 from Engine #2 (1): MIL: off, RSL: off, AWL: off, PL: not supported, No DTCs
13:39:13.7597 Destination Specific DM6 Request to Engine #1 (0)
13:39:13.7627 18EA00F9 [3] CF FE 00 (TX)
13:39:13.7722 18E8FF00 [8] 01 FF FF FF F9 CF FE 00
Acknowledgment from Engine #1 (0): Response: NACK, Group Function: 255, Address Acknowledged: 249, PGN Requested: 65231
13:39:13.7732 Destination Specific DM6 Request to Engine #2 (1)
13:39:13.7767 18EA01F9 [3] CF FE 00 (TX)
13:39:13.7817 18FECF01 [8] 03 FF 00 00 00 00 FF FF
DM6 from Engine #2 (1): MIL: off, RSL: off, AWL: off, PL: not supported, No DTCs
13:39:13.7832 Destination Specific DM6 Request to Exhaust Emission Controller (61)
13:39:13.7857 18EA3DF9 [3] CF FE 00 (TX)
13:39:13.8202 18FECF3D [10] 03 FF A9 F0 F0 01 A9 F0 E2 01
DM6 from Exhaust Emission Controller (61): MIL: off, RSL: off, AWL: off, PL: not supported
DTC 520361:16 - Manufacturer Assignable SPN, Data Valid But Above Normal Operating Range - Moderately Severe Level - 1 times
DTC 520361:2 - Manufacturer Assignable SPN, Data Erratic, Intermittent Or Incorrect - 1 times
FAIL: 6.3.2.5.a - Difference compared to data received during global request from Exhaust Emission Controller (61)
End Test 3.2 - DM6: Emission related pending DTCs

The better answer is:
b. Fail if DTC in reported Freeze Frame data is not also displayed in DM23 response provided earlier in this part.
to replace b. In
6.7.12.2 Fail Criteria
a. Fail if no ECU reports Freeze Frame data.
b. Fail if DTC in reported Freeze Frame data does not include the DTC provided by DM23 earlier in this part.
c. Fail if NACK not received from OBD ECUs that did not provide DM25 message.

Change not in proffer


text:
Wholesome interactions

This bot is unable to give head pats to others or myself through a command. I would like this to be fixed immediately.
Your b0ss,
b0b

Fixed in the next release.

repo: Erdragh/AstralBot


text:
Raw code bug in inverse_kinematics_np Function.

In common/skeleton.py  row 58：
'''Get Forward Direction'''
l_hip, r_hip, sdr_r, sdr_l = face_joint_idx
As you said: face_joint_idx should follow the order of right hip, left hip, right shoulder, left shoulder.This mistake may affect the real value of across and subsequent processing.

Hi, thanks for pointing out this. It seems a bug exactly. However since many experiments have been done on this version, I could not update this anymore. I will highlight this issue to note others.


text:
RLA --out parameter behaviour with -f

RLA version #
2.0.0.0
Describe the bug
Note: As ever, an excellent tool and very grateful for all your efforts in creating and maintaining them!
RLA: when targeting a particular hive file with the -f parameter, the --out recreates the full directory path (not required in my use case).
Command line:
C:\DFIR\Tools\net6\rla.exe -f "E:\Testing\Hostname\Collection\Windows\System32\config\SAM" --out "E:\Testing\Hostname\Collection\Windows\System32\config\Clean"
I've read the other issue entries and saw your comments in issue #55 about preserving the source path, in case you were processing multiple NTUSER.dat files (as an example), and I concur with this logic for the -d switch. But, I think for the -f switch where you are specifying a particular file it doesn't work as well?
In my use case I am processing individual hives before running other tools on them seperately, so it is counter-productive for it to reproduce the full source path, for example the cleaned hive file gets output to the following directory:
E:\Testing\Hostname\Collection\Windows\System32\config\Clean\E\Testing\Hostname\Collection\Windows\System32\config
Note: If you can specify the paths using relative paths it seems to work (i.e. doesn't create the original source path), but I can't relative paths in my use case and have to use the full paths to each file / directory. e.g. I have my tools on C:\ and my artifacts on E:.
To Reproduce

Copy a sample registry file to a directory
Run C:\DFIR\Tools\net6\rla.exe -f "E:\Testing\Hostname\Collection\Windows\System32\config\SAM" --out "E:\Testing\Hostname\Collection\Windows\System32\config\Clean"
Go to: E:\Testing\Hostname\Collection\Windows\System32\config\Clean
Find the preserved source path directory structure and follow it down to the clean file: E:\Testing\Hostname\Collection\Windows\System32\config\Clean\E\Testing\Hostname\Collection\Windows\System32\config

Expected behavior
When using the -f switch I would expect the clean file to be output to the path specified without retaining the source path. Or have another switch that enables / disables the preservation of the original source path?
Screenshots

I tried adding the tools directory to the PATH as suggested, but got similar results, in that, running it with the full paths specified resulted in the source path being included, and when using the relative path, the source path was not included.
I could certainly look at using this as a workaround to get the script working, but I do like your idea about adding a --nop switch as well!

I fully appreciate this is not urgent, but just inquiring how its going?

I'll try to get to it this week

this should be working.
--nop will end up like in test
without it test2

does this work? if so i can get a build to you

That looks perfect, yes I would be happy to test it as and when you have a version built.

ok check for updates or redownload. we can reopen if theres issues

Legend, thanks, I’ll test it tomorrow.

authors: Bloggzy EricZimmerman

repo: EricZimmerman/RECmd

license: mit


text:
function not working

The filter function ( types, weaknesses, ...) is not working sir.

Sorry for the delay in responding.
I did not find a performative way to implement these filters using the PokéAPI, it does not provide these types of filters, I would need to obtain the entire list of pokemons to carry out the filters, mainly for weaknesses. And as it is a project just for study purposes, I just coded the interface of these filters.
Thanks for the contact!


text:
Support ICE trickle

Send ICE candidates as they become available rather than only when generating the answer.

@Rugvip could you have a look at this one?

Fixed in https://github.com/EricssonResearch/openwebrtc-ios-sdk/pull/45.

ref: https://github.com/EricssonResearch/openwebrtc-ios-sdk/issues/67

authors: stefanalund xelven

repo: EricssonResearch/openwebrtc-ios-sdk


text:
Fix initialScore and finalScore (#37)

The cutDistanceScore was not included in the initialScore and finalScore.

Fix initialScore and finalScore calculation (fixes #37)
Expose cutDistanceScore
Included cutDistanceScore in protocol.md

This is a mergeback from the upstream repo.

repo: ErisApps/beatsaber-http-status


text:
My Own datasets

Hi, @ErlerPhilipp !
I want to deal a scene data using make_dataset.py. After set enforce_solid=False, I still can't find any file in 02_meshes_cleaned. I get "ValueError: Dataset is empty! datasets/lounge/05_query_pts". So I would like to ask if it's possible to deal with that data.
lounge.zip

Hi @qiao1025566574
The main problem is that your mesh is not closed. P2S is not really working with open meshes since the SDF basically enforces a solid object and the model will try to close it, which usually fails due to the heuristic (the grid is only evaluated near the point cloud). Sometimes, the model tries to consider the walls, floor and ceiling as double-sided but it's unreliable. I'm working on this issue and a follow-up paper should solve it.
If you want it only for evaluation, you should set the 'only_for_evaluation' setting in the settings.ini to 1. This disables a few checks and skips some processing steps. The reason why you don't get an output is probably the num_max_faces parameter. The reason for this parameter is that the SDF calculation of trimesh has an extremely high memory consumption, which scales with the number of vertices/faces in the mesh.
If you want it for training, honestly, you should try another method. In short, I recommend using another method for indoor reconstruction. "Convolutional occupancy networks" by Peng et al. seems good but I haven't tried it yet. If you really want P2S for this, you need to close the mesh manually and move the camera for the point cloud sampling into the room.
Does this answer you question?

Thanks for your detailed explanation! That is exactly the answer I want. I'm looking forward to your new study.


text:
Added EnemySpawnSystem. Added level mesh.

Enemy will spawn outside players view.
Added a new level mesh.

Potresti usare UnityEngine.Bounds, contiene anche il metodo Contains che ti dice se una posizione è all'interno della box

c'è anche Camera.CalculateFrustumCorners che potrebbe evitarti di fare calche calcolo

Purtroppo UnityEngine.Bounds funziona solo con aree non ruotate mentre Camera.CalculateFrustum funziona solo per le camere e le camere per i players oltre il mio non vengono instanziate. I calcoli in realtà sono pochi e veloci non c'è da preoccuparsi.

authors: MatteoNasci aannun

repo: ErrorNullReference/INVASION


text:
Modify pane symbol preview doesn't refresh once you save edits

I'm using Pro 1.2 and the 2525c_b2 version of the add-in.
To reproduce:

Select a feature in the modify pane:

edit the symbol in the Symbol pane and save your edits:

go back to the modify pane and see that the symbol preview still shows the symbol you selected pre-editing:

This is confusing, but not a showstopper bug by any means.

Addressed in #156, by:

Flashing/reselecting feature on "Save Edits"
This selects/flashes the feature and returns you to the modify pane

Which seems like a nice workflow/feedback on save

Verified using original steps.

tested on 1526 .... this works the way that @csmoore says it does, i am not seeing the behavior that @Dbarnes1 originally logged the issue about, and i agree with @csmoore that it's just a nice touch that you go back to the modify pane. closing

authors: ACueva Dbarnes1 csmoore dfoll

repo: Esri/military-symbol-editor-addin-wpf


text:
Visibility and Range

From @joebayles on September 28, 2015 18:16
https://nsec.esri.com/arcgis/home/item.html?id=b686d980cd5b497a95f95d8571c0826f

[x] No Summary
[x] Description needs to be complete
[x] No Access and Use Constraints
[x] No Credits
[x] Delete Protection Disabled

Copied from original issue: ArcGIS/mil-intel-desktop-solutions-templates#128

Done.

authors: joebayles nfeuerstein

repo: Esri/ops-server-config


text:
Add an icon to indicate the location when using search for creating features

Describe requirements
Currently, it only zooms and centers into the searched location when searched during the create reports functionality and doesn't indicate where to add the feature. Let's implement the behavior we have reporter 3.x that adds an icon in that location for point features

Alternatives
No response
Other Relevant Info
No response
Impact
No response

@skrishn
This functionality is in place. However, this will work only for point features, could you please check and let us know if you see any issues

I'm not able to reproduce it anymore. So, I'm closing it.

authors: skrishn sumitzarkar

repo: Esri/solutions-components


text:
No clear way to send eth to payable contract functions

The client's transfer function doesn't accept a data arg, and the contract's transact function doesn't accept a value arg.

@Flagship8787
Thanks for the issue. Please migrate as we will maintain the eth.rb library here. ;)


text:
Activity subtypes

Is there a way you could add a dialogue or similar option to the activity form that would allow a player to select a subtype of a downtime activity? For example, in XGtE you can pursue low-class, middle-class, or upper-class carousing. They are similar, but have different complications. A way to set up a general activity and then modify pieces of it depending on player selection would be awesome. Right now I am creating multiples of the same activity from scratch with different DCs - such as the Crime activity - and it is a bit of a pain to set up.

I will look into it but It should work with using groups as well. In this case you can have carousing groups show this:
Group: First Roll
Roll 1 - DC low-class
Roll 1 - DC middle-class
Roll 1 - DC upper-class
Group: Second Roll
Roll 2 - DC low-class
Roll 2 - DC middle-class
Roll 2 - DC upper-class
With that set up you can still do everything in one activity, you'll just have to select the appropriate choices when the dialog pops up.

That almost gets there, but it doesn’t solve the problem of having different complications tables for each class. Any ideas on that front?

repo: Ethck/Ethck-s-Downtime-Tracking


text:
Support for older versions of Delphi?

Any plan?
Thanks.

No, because the SVG library used is based on GDI+ available only from DXE4+

authors: carloBarazzetta edwinyzh

repo: EtheaDev/SVGIconImageList


text:
Slow open on Windows and a decent PC

I really love Terminus.
However, is too much slow on my machine (which is a i9-9900k nearly at 5Ghz, quite a "decent" PC).
I already have:

[x] Disabled the acrylic background
[x] Disabled the restore of previous sessions

Any suggestion to improve the loading time?

How long does it take? You could record a performance trace for a fresh load: https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/reference

Start Terminus
Open Devtools from Settings
Click "reload & record" on the Performance tab:

Save the trace: https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/reference#save

It took 2912 ms using the performance monitor, doing a full reload when Terminus was already openend.
When it's closed, it's even worst (i.e. launching it from "Open Terminus here".

Can you upload the trace?

Profile-20200420T110914.zip

I'm also facing the same issue on Terminus version 1.0.111
Here are my traces:
Trace 1.zip - took 5.4 seconds
Trace 2.zip - took 2.3 seconds
I ran the traces a few times and the average was 2.3 seconds. Not sure why that first one took that long but I guess you'll be able to tell. Also as @gremo said, it can take much longer to start for the first time. One time it took 15 seconds (manually timed) 😱
I would normally set the Shell profile to "WSL / Ubuntu" but for the trace I set it to "Default (PowerShell Core). Pretty much all other settings are default. No additional plugins or weird configurations. I also already have:

[x] Disabled the acrylic background
[x] Disabled the restore of previous sessions

No other apps were open and I checked that there were no running processes slowing down the system. I think my PC is more than capable.
Specs:
CPU - AMD Ryzen 7 3800X @ 3.9GHz
RAM - 32GB DDR4 @ 3600MHz
Storage - 1TB Samsung NVMe M.2 SSD (for OS and everything else. Only 97GB used so far.)
OS - Windows 10 Home, Version 1909, OS build 18363.815 (Installed only 2 weeks ago so hasn't built up "clutter" that could be slowing it down)

Here is my trace, took 6533 ms on MacBook Air 2017, running Mac OS Catalina
Profile-20200513T125134.json.zip

same here.. i really love this ssh client but it takes up to 12 seconds to start here...
and thats a bit too much..

authors: Eugeny Ireristible gremo manohar-voggu olsonnn

repo: Eugeny/terminus


text:
Create 0000-01-02-EvaOng.m

Add EvaOng's file

can't find merge the pull request button... where is it?
On Sun, 27 Jun 2021 at 09:33, github-learning-lab[bot] <
@.***> wrote:

@.**[bot] approved this pull request.
Step 8: Merge your pull request
Nicely done @EvaOng https://github.com/EvaOng! ✨
You successfully created a pull request, and it has passed all of the
tests. You can now merge your pull request.
⌨ Activity: Merge the pull request

Click Merge pull request
2.
Click Confirm merge
3.
Once your branch has been merged, you don't need it anymore. Click Delete
branch.

I'll respond when this pull request is merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EvaOng/github-slideshow/pull/3#pullrequestreview-693369930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUTSJ3ULNIQZUE7XWJFOZFTTUZ5XJANCNFSM47JCIBPA
.

repo: EvaOng/github-slideshow


text:
Shut downs when hitting Enter on the arrow for more options

Hey,
I just installed this theme, and as the title says, I'm unable to see the "more options" menu when moving to the arrow and hitting Enter. Is there any log I can look up so we can figure this out?
Great theme, thanks!

The down arrow isn't for more options unfortunately. It literally does mean shutdown.
I don't think there's a way in rEFInd to create a sub menu.

Oh... What about the options like "boot to Lenovo Repair tool, boot to memcheck", etc.? I have a row of about seven icons below my main OSes.
I like that they're hidden, but is there any way to access them?

For me I don't use those features, so in this theme I've hidden them.
There was some small discussion about adding icons for things like that over in #15 but I haven't gotten around to finding something exactly to my liking.
You would have to petition Roderick to have a feature added to rEFInd that allows the extra options to be hidden away.

authors: EvanPurkhiser tinchou

repo: EvanPurkhiser/rEFInd-minimal


text:
Method Invocation Method: Addtext

Getting this error when I run the script..any ideas?
Exception calling "AddText" with "6" argument(s): "Method not found: 'Void SixLabors.Fonts.TextOptions.set_Origin(System.Numerics.Vector2)'."
At C:\Program Files\WindowsPowerShell\Modules\PowerBGInfo\0.0.3\PowerBGInfo.psm1:717 char:13

        $Image.AddText($PositionX + $HighestWidth + $SpaceBetween ...

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : MissingMethodException

Did the modules load correctly? both PowerBGInfo or/and ImagePlayground?

I actually ended up using ISE instead of Visual Studio Code and it started working. Now just trying to figure out how to add MAC address, IP address and other items I like to use with BGINFO. Thanks!

It's a problem with the VSCode PowerShell extension conflicting with some DLL in ImagePlayground; I still need to figure out which one and try to be able to fix it. Or use PS 7 to edit, and PS 5.1 to run it.
As for your stuff, take a look at PSSharedGoods and Get-COmputer* commands. It simplify things a lot.

repo: EvotecIT/PowerBGInfo


text:
Chat sometimes is empty

This happens when the webview2 does't load for some reason.

One cause of this is if the user is using Windows 10 which doesn't have WebView2 installed by default.
In that case users must download the Evergreen Bootstrapper: https://developer.microsoft.com/en-us/microsoft-edge/webview2#download

I'm unable to reproduce this on a fresh windows 10 2004, it looks like Visual Studio already installed webview2

Huh, I wonder if it's a combination of an old VS and windows 10? Or maybe this is just not the root cause.

There seems to be no way to install an older version of Visual Studio so I couldn't test it, on another though, would the extension even load if it couldn't satisfy its dependencies?

Re-opening this. Will wait to see if #16 fixed this fully

authors: fortenforge thedemons

repo: Exafunction/CodeiumVisualStudio


text:
Add my first file

I have created a new branch, created a file, and made a commit!

created a new branch, created a file, and made a commit


text:
"Ghost" bans

Describe the bug
Sometimes it shows users are banned on the panel but they are actually not banned, it is grabbing a ban from someone else and putting it on their panel profile. They are able to connect to servers properly, it just confuses the staff members involved. We have dubbed them "Ghost" bans for now, bans that don't actually exist.
To Reproduce
It is unknown how this is reproduced. I first encountered this issue around 7-9 months ago where we would see new "Ghost bans" every other week. This stopped at around June and they've recently made a return with us finding new examples of said "bans" every other day.
Expected behaviour
Go onto a profile of a person who is clearly not banned, and it shows they are not banned, instead of a ban being pulled out of the database and being displayed.
Screenshots
https://cdn.discordapp.com/attachments/686057091475046451/810956089654247464/I_never_did_this.jpg
Example of a staff member that is displayed as banned but can connect properly.
For clarification, the one's I have seen are definitely from banning on the panel. A quick search in the logs shows no results https://prnt.sc/zn0nye.

I know that this ban was issued by Nuzi but not for this player - this player is not banned.

I'm not banned but on the panel it shows I am

This is most likely the result of the players sharing either of the following attributes:

steam
rockstar license
discord tag
Xbox live tag
IP address

There could however be a bug as well.

Definitely a bug, Ains says he does not share any of those attributes with anyone. I myself have been shown as "banned" like this too and I know for a fact I don't. Ex-staff members back in the day said if we was to unban these "ghost banned" accounts, i.e. ainsley (again, you know they are "ghost banned" because they can connect to the server without problems) then the original perpetrator will also be unbanned.
This makes be think that it is showing someone else's ban for sure, and unbanning the "ghost banned" account removes the same ban on the original account as well.
This would not be the case if a user was to share any of the above with someone else, they would get an identical but different id ban placed on their account to differentiate the two, i.e. if one was unbanned the other would not be. This has been tested in the field too, both accounts (if they were shared) would have to be unbanned for them to be able to play as they'd just be automatically banned again like you said for sharing said attributes.

Alright. If you unban the "ghost", the original perpetrator would be unbanned as well. What if you again banned either the "ghost" or perpetrator, would both persons be shown as banned again? Or would it work as intended?

I am almost certain that these 'ghost bans' come from IPs. For some reason, the FiveM/FXServer seems to often 'leak' IP addresses to players that they don't belong to, causing it to be logged to their account. Since that discovery, all OP-FW server bans (local & global), have stopped using IPs to track them entirely. Prior to that, these 'ghost bans' would often prevent players from joining the server, prompting them someone else's ban.

I live in a different country than most of our players from my subdivision. So my ip matching with anyone is pretty rare my profile yesterday I didnt have any ghost ban and I have a ban reflecting of someone I banned from the web panel a few mins back.
steam , rockstar or discord was never shared with anyone

It's not on your side @GuArDiAn-ops - something to do with the database. I've seen the problem InZidiuZ stated before whilst working on emulators and websites. Forced us to stop using ipbans as a lot of users would be involved. I know it's not common practice to log ip addresses, but when we did it was clear to see that they were the same for a lot of people.
Hopefully this can be fixed soon by looking into it more carefully, perhaps people are getting the proxy ip address linked to them instead of their actual ip address? @InZidiuZ (Not sure if there is a proxy in use, but that is almost always the case)

authors: ExpDev07 GuArDiAn-ops InZidiuZ ainstaylor mxttx


text:
[$1000] Not showing complete description text in Priority mode section

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open Settings -> Preferences -> Language.
Change language to Spanish.
After change language go to Modo prioridad.
Check Most recent section description is truncate.

Expected Result:
Complete text should be display as it is informative text and it can be display in multiple lines.
Actual Result:
Description is only bound to one line and showing ... at last instead of complete text in multiple line.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.68-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @jatinsonijs
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675923872069609
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01be9e8228361178fe
Upwork Job ID: 1625511246226124800
Last Price Increase: 2023-02-14

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Was able to repro this, I agree the informative text should show!

Job added to Upwork: https://www.upwork.com/jobs/~01be9e8228361178fe

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Great catch! Agree this is an error, that text component should probably wrap lines when text is longer than the width instead of truncating them

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to @Luke9389 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The priority mode description is truncated instead of going to the next line.
What is the root cause of that problem?
The priority mode use OptionsList which will render OptionRow for each item. OptionRow description text uses numberOfLines 1.
What changes do you think we should make in order to solve the problem?

We can add a new props (alternateTextNumberOfLines) with default value of 1 to the OptionRow and also to the OptionsList. We can apply the props to the whole item of the list, or to each item.
So, PriorityModePage will pass the number of lines to the OptionsList and it will pass further to the OptionRow.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
OptionRow priority mode text gets truncated
What is the root cause of that problem?
We are providing the numberOfLines 1 for the Text and that is causing the issue
What changes do you think we should make in order to solve the problem?
We can remove the static numberOfLines from the alternateText and remove the height & lineHeight styles here which won't be required.
https://github.com/Expensify/App/blob/1a5249dafc707fde309a62684c84f72cc93dd871/src/styles/styles.js#L1235-L1238
Also need to update the height to minHeight for the OptionRow so height gets updated when the content is more.
https://github.com/Expensify/App/blob/1a5249dafc707fde309a62684c84f72cc93dd871/src/styles/styles.js#L1248

Proposal
Please re-state the problem that we are trying to solve in this issue.
The priority mode description is truncated instead of going to the next line.
What is the root cause of that problem?
There is styles.optionAlternateText which is set height and lineHeight and number of line set 1
What changes do you think we should make in order to solve the problem?
We have to override this height and line height style  based on new props for multiple line condition as its common component and used on other pages also.
What alternative solutions did you explore? (Optional)
None

Proposal
Please re-state the problem that we are trying to solve in this issue.
The priority mode description is cut in one line instead showing in multiple lines
What is the root cause of that problem?
Priority Mode page uses OptionRow and there are 2 root causes here:

single line prop set in alternative text (main root cause)
https://github.com/Expensify/App/blob/1a5249dafc707fde309a62684c84f72cc93dd871/src/components/OptionRow.js#L241
height set in alternative text. I'd say this is also root cause because view is cut by fixed height
https://github.com/Expensify/App/blob/1a5249dafc707fde309a62684c84f72cc93dd871/src/styles/styles.js#L1235-L1238

What changes do you think we should make in order to solve the problem?

introduce new prop called isAlternativeTextMultiline

If this prop value is set to true, remove numberOfLines={1} stated in root cause and also set height to null or undefined in alternativeTextStyle conditionally.

This still doesn't fix the issue completely. When more than 3 lines of alternative text, OptionRow is cut. That's because container height is also set as fixed here:
https://github.com/Expensify/App/blob/1a5249dafc707fde309a62684c84f72cc93dd871/src/styles/styles.js#L1248
So the solution is to remove height conditionally here:
https://github.com/Expensify/App/blob/1a5249dafc707fde309a62684c84f72cc93dd871/src/components/OptionRow.js#L124-L130

I am suggesting this last change because OptionRow is low level component and should handle all various edge cases.

(Optional) We can also apply this change to title (DisplayNames)

Thanks for your proposal @Pujan92.
We cannot completely get rid of numberOfLines, height and lineHeight as it will be required in some other use cases of OptionRow.

Thans for the proposal @PankajAS.
Looks like you are a new contributor and you are working in your first PR. And as per our contributing guidelines you cannot work on more than one job until your first job gets done.

New contributors are limited to working on one job at a time, however experienced contributors may work on numerous jobs simultaneously.

Thanks for your proposal @bernhardoj.
Your updated proposal looks fine. I will suggest using permalink to make your root cause analysis and solution more clear.
We must make sure to test all components which are using OptionRow in PR. Also, please be aware that height of the components like SearchPage Options (where numberOfLines will be 1) should not change. So, please make sure to test height of option rows in all the platforms(web, Desktop, native and mWeb).

🎀👀🎀 C+ reviewed
cc: @iwiznia

Thanks for your proposal @Milos213.
Your proposal is similar to the previous proposals. You can find other open jobs here.

@sobitneupane Thanks for the feedback.
I will make sure all component that uses OptionRow does not change visually.

Thans for the proposal @PankajAS.
Looks like you are a new contributor and you are working in your first PR. And as per our contributing guidelines you cannot work on more than one job until your first job gets done.

New contributors are limited to working on one job at a time, however experienced contributors may work on numerous jobs simultaneously.

Hi @sobitneupane , My first PR is almost done and functionality is approved and after few minor changes it will mark as done today.

I think this was mis-tagged, awaiting @Luke9389's CME approval of the selected proposal:   https://github.com/Expensify/App/issues/15002#issuecomment-1431136859
In the meantime, hired @sobitneupane in Upwork as C+

We cannot completely get rid of numberOfLines, height and lineHeight as it will be required in some other use cases of OptionRow.

@sobitneupane, which other cases would be broken by this change?
I looked around for some and couldn't find any.

One such case is Search Page. Alternate Text in search page will have multiple lines if we remove numberOfLines prop.

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reapplying the label to get another CM as I am going OOO -- thanks @strepanier03!

Thanks @stephanieelliott I'll handle from here and follow along.

@strepanier03, @sobitneupane, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Waiting for your response on https://github.com/Expensify/App/issues/15002#issuecomment-1431136859 @Luke9389

@Luke9389

Have you tested that? I guess I'm thinking, why would we ever want to truncate text by forcing it to be on one line?

Yes. I tested it.

I believe it's a design decision. Each row with different number of rows of alternate message doesn't look pretty.

📣 @sobitneupane! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: sobit.neupane.111@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01074747269d215545

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Ah, yeah @sobitneupane that's correct. Ok lets go with this proposal then (the one you selected).
@bernhardoj please feel free to create your PR.
Thanks @sobitneupane!

📣 @bernhardoj You have been assigned to this job by @strepanier03!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

PR is ready for review.

@strepanier03, @sobitneupane, @Luke9389, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.77-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15400

If no regressions arise, payment will be issued on 2023-03-09. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@sobitneupane / @Luke9389] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@sobitneupane / @Luke9389] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@sobitneupane / @Luke9389] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@bernhardoj] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Regression Test Step

Open Settings > Preferences > Language
Change the language to Spanish
Go back and open Priority Mode (Modo prioridad)
Select Most recent (Más recientes)
Verify the list item description is not truncated

Do we 👍 or 👎 ?

Will work on reg test next step today.

@bernhardoj - I invited you to the job in UpWork.
@jatinsonijs - Upwork is giving me an error during job creation for the bug report job. I'll try again tomorrow and share a link as soon as it's ready.

@jatinsonijs - I have hired you for the job in Upwork, it won't let me pay the contract until you accept though. I'll check here again later today to see if I can pay out.
@bernhardoj - I've rehired you as well and will take a look for the option to pay later today.
@sobitneupane - Could you please finish the three checkbox times in this list and I'll check it off for you?
Thank you!

I've raised a discussion for the C+ and Contributor payment due to this post in Slack. I'll update here tomorrow once I get some more BugZero voices weighing in.
I'll check for accepted offers tomorrow and pay what I can if the discussion is resolved.

Upwork job price has been updated to $1000

After internal discussion, it was pointed out that the job price was increased to $2000 incorrectly as a proposal had been accepted by the C+ prior to the increase happening.
I have lowered the price in the title and will adjust accordingly when paying as well.

@strepanier03 hi, I see the contract is end but I still get paid 2k. Should I refund the whole 2k or just 500?

Oh darn, sorry about that @bernhardoj, I guess the job price didn't get updated properly and I was in a rush today and missed it.
If you can refund the $500 that would be fantastic. If you  need me to request that on my end please just let me know and I'll take care of it.

Thank you for catching it 🙌

@strepanier03 I never done it before, but there is an option to refund it. I have refund $500, can you confirm that you get the refund?

I can confirm it came through just fine, thank you again for being honest and raising this oversight on my part.
@sobitneupane - Once we have the bug zero checklist done I can finish paying you out for this job.

Bumped in Slack here.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The PR that introduced the bug has been identified. Link to the PR:

It was present from the very beginning and was designed to truncate overflow.

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR because it was designed to truncate overflow.

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

^

Woohoo, thank you. Handling payment now and will close after.

All good. Thank you everyone for your hard work and continued efforts.

repo: Expensify/App


text:
Composer displays briefly when opening a deleted workspace

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Delete workspace
Open any room or workspace chat of the deleted workspace

Expected Result:
Composer should not display when opening deleted
Actual Result:
Composer briefly displays when opening deleted workspace
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.88-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/227269432-3e23d950-468b-416e-96b5-6e4a8c4f904c.mp4
https://user-images.githubusercontent.com/43996225/227269467-150c4950-dcc4-49eb-8655-edffd1207598.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679581038766069
View all open jobs on GitHub

Hmm, I cannot repro on v88-1 (Pixel 3a) or the desktop app.

Also asked Kadie to double check/verify and she cannot repro either:
https://user-images.githubusercontent.com/30815269/227373813-222e35a2-7b3a-4cd5-a93f-a17b299c26c6.mp4
Could this be an internet connection thing? The behaviour doesn't seem consistent at all - you can see the chat switcher in @ayazhussain79 only some of the time.

@jliexpensify I can still produce it try to reproduce it on the app. composer open for a while while opening delete workspace

Can you run a speedtest and share a screenshot here? Since Kadie and I both don't see this issue, we're theorising it could be the internate connection?

I've tried with the iPhone mobile app, couldn't reproduce there either:
https://user-images.githubusercontent.com/59587260/227376009-dbd6547e-a934-4ab4-ade1-e067573c9307.MP4
Here are my internet speed test results for reference:

@jliexpensify @kadiealexander  So it is due to internet speed, there should be something that composer should not show at low internet speed.

@kavimuru can also reproduce it

@ayazhussain79 - so, just to confirm for my understanding:

You believe this specific issue is caused by a slow internet speed?
You think the actual issue is that the composer behaviour should be consistent (i.e. it shouldn't surface) whatever the internet speed?

@jliexpensify i can't confirm its a internet speed issue, it shouldn't surface on deleted workspaces, whether its internet issue or not

@ayazhussain79 we are not sure either, we are asking for more information to narrow down what the cause of the issue is (because neither @jliexpensify or myself is experiencing it).
Is your Expensify account set up as a high-traffic account?

@kadiealexander no ma'am

I'm on v1.2.89-0 now (Pixel 3a and Chrome) and I can't repro this

@kavimuru and @ayazhussain79 - given that Kadie and I can't repro this across every platform on v89, I'm going to close this. Please re-open if you can come up with very clear reproduction steps and we'll test again.

if you login and opened deleted workspace composer displayed but not 2nd time if you opened same deleted workspaces (in video)
https://user-images.githubusercontent.com/56740856/227811585-949589e7-b1ba-451b-9964-9e15ca9f88fe.mp4

Thanks for the updated video. Are you actually able to type anything into the compose box while it shows briefly? If not I don't think this is a bug, it's our regular loading screen.

I spent about 10 mins on various archived rooms trying to reproduce: I'd say that this occurs incredibly infrequently, and the only pattern/repro steps I have are:

Create new workspace and delete it
Click on archived #admins rooms to surface composer briefly

OR

Close Expensify Chat
Re-open Expensify chat and find any archived #admins room to surface composer briefly

Basically, the behaviour I'm seeing is that the composer will very briefly be generated with the "first" deletion of the workspace, or if Expensify Chat is re-opened.

I agree with Kadie - it isn't an actual bug, as you can only see a quick glimpse and you can't actually compose a message.

authors: ayazhussain79 jliexpensify kadiealexander kavimuru


text:
[$1000] LHN logic for threads is wrong (inconsistent with other chats)

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any chat room (non-DM)
Thread a message in that chat

Expected Result:
The thread appears in the LHN with a preview of the message threaded, followed by the most recent message in the thread.
Actual Result:
The thread appears in the LHN with a preview of the message threaded, followed by the workspace name and room name
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.17.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684503061244619
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01422c3862e47a029f
Upwork Job ID: 1661857447696506880
Last Price Increase: 2023-06-01

Started looking into this. Right now we are showing the same thing for the header and the lhn which is not intended. This can be external.

cc @aimane-chnaif ^

Looks like it was wanted here https://github.com/Expensify/App/issues/18755 , but I don't have access to the word so I don't know why. Here is the PR: https://github.com/Expensify/App/pull/18522

@aimane-chnaif @stitesExpensify what is the next step here? What do you think of @hoangzinh proposal?

This is what the doc says:
LHN:

Header:

I asked confirmation here - https://github.com/Expensify/App/pull/18522/files#r1212295913 to avoid any regression.

So reading that thread, it looks like the expected result here is correct.

Makes sense to me

@hoangzinh @aimane-chnaif I've sent you both an offer in Upworks. You're both eligible for the 50% speed bonus.
@aimane-chnaif can you get started on the checklist?

Everyone is hired in Upworks. We just need to complete the checklist and pay everyone out after the regression period.

The payments have been sent via Upworks. @aimane-chnaif can you please complete the checklist?

Regression test has been created https://github.com/Expensify/Expensify/issues/295396

authors: ShogunFire kavimuru stitesExpensify tjferriss


text:
[HOLD for payment 2023-06-30] [$1000] Workspace - Error message when trying to access workspace created with different default contact method.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/20406
Action Performed:

Login to NewDot under phone account
Add email as secondary login
Create a workspace
Change default contact from phone to email
Try to access settings of workspace from step 3

Expected Result:
User can open WS
Actual Result:
Error message when trying to access workspace created with different default contact method.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.27-6
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/52206f5c-02d8-4c89-8b67-82aeec75fffe
https://github.com/Expensify/App/assets/93399543/a3238e50-7b0b-4ab5-a641-72bbdbbda530
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686598989456939
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0143af88a3b986771d
Upwork Job ID: 1670867972193251328
Last Price Increase: 2023-06-19

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Asking QA if this is indeeed not repro in production as I faced the same issue right now but also in prod

Issue is not reproductible in production
https://github.com/Expensify/App/assets/93399543/8ea377b6-dee1-4a7e-872d-cc6a01a243ff

@kbecciv just to be clear, if you sign out / in are you able to access the workspace?
I'm just guessing if you change the default contact method and THEN try to access the workspace you may not be able to, but if you log out / in you may be able to.
I'm going to try all your original steps in production to see if i get the error

Ya here's what I see on production, which leads me to believe this isn't a deploy blocker:
https://github.com/Expensify/App/assets/3885503/214a20c4-f3b2-499c-99b1-d481be93e5b5

@mountiny Yes, it is reproducible on production too. I reported this issue when it was on staging here.
https://github.com/Expensify/App/assets/57330233/974fb240-5cb5-416c-a854-d12e1068c59d

Getting a BugZero member here since we can go through the normal process with this one

Proposal
Please re-state the problem that we are trying to solve in this issue.
An error message is displayed when trying to access a workspace created with a different default contact method.
What is the root cause of that problem?
The app checks the accessibility of the workspace with Policy.isPolicyOwner.
https://github.com/Expensify/App/blob/599f05a801829c4cf9a57bd307acd125195d9437/src/pages/workspace/WorkspaceInitialPage.js#L176-L180
But after changing the default contact, the workspace policy owner is the previous contact and the session email is the current contact, so the check fails and an error is displayed.
What changes do you think we should make in order to solve the problem?
We should change the Policy.isPolicyOwner function to check the user's other contact.
The loginList Onyx data contains all the user's contacts, so we can check whether the policy owner is in the login list or not.
Add the following code to Policy.js.
let loginList;
Onyx.connect({
 key: ONYXKEYS.LOGIN_ LIST,
 callback: (val) = > (loginList = val),
});

And modify the isPolicyOwner function as follows.
function isPolicyOwner(policy) {
 return _.keys(loginList).includes(policy.owner);
}

What alternative solutions did you explore? (Optional)
None.

Seems like a valid bug to me. I will go with External but correct me if you think otherwise Alex :D

:ribbon: :eyes: :ribbon: C+ reviewed
LGTM

@michaelhaxhiu FYI it looks like @dhanashree-sawant actually reported this first in https://github.com/Expensify/App/issues/21142

@StevenKKC can you please apply to the job? https://www.upwork.com/jobs/~0143af88a3b986771d

@michaelhaxhiu I have applied to the job. Thanks.

Bump @michaelhaxhiu :D

Kindly bump @michaelhaxhiu

Damn. Sorry all. This slipped away from me as a loose end and I should've caught it sooner.
Payouts:

[ ] $250 External issue reporter @dhanashree-sawant
[ ] $1500 Contributor+ that helped on the issue and/or PR

@StevenKKC can you let me know when you accept the offer?

@michaelhaxhiu Accepted an offer. Thanks.

authors: Beamanator Natnael-Guchima OSBotify StevenKKC kbecciv michaelhaxhiu mountiny narefyev91 puneetlath


text:
[$1000] Money request - Second money request while offline is missed  if the other User pay the first one

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Login as User A and User B in front of you at the same time.
As User A requests Money from User B ( make sure it works by avoiding the bugs around the IOU feature Now )
As User A go offline ( go to settings > preferences > turn on the offline mode ) - don't go offline as User B.
As User A Send another Money request.
As User B, Pay the first money request elsewhere.
Back to User A and Go online again.
Notice the Money request message for both users.

Expected Result:
The Second Money Request ( while offline ) should still appear for User A in the money request message, and displayed as unpaid

The second Money request ( while offline ) should be sent to User B, with a button to pay it elsewhere.

Actual Result:
The Second Money request ( while offline ) is missed for both users.

Second request desapair for  User A ( sender ), and just the first request is displayed as paid
Second Money request is not sent for User B.

Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.57-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/d0bc740c-f092-4d5e-aaeb-50816a0a009d
https://github.com/Expensify/App/assets/115492554/b1ef6ca2-8f17-4468-906c-4a6b3f843c50
Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692401728126839
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018064a0ff10eb2db7
Upwork Job ID: 1697306425103572992
Last Price Increase: 2023-09-22

This might require some major rework as I see, when an app goes online here, fresh details are being fetched from the server I guess.
An easy approach would be to store offline transactions or any message locally and then recreate them or add them to the stack when the device comes online. Then we will also have to work out messages and other things that are done offline.
OR we can put a barrier and say to the user that they cannot request without network access.

@maddylewis what do you think about combining these two? they seem related and likely have the same root issue: https://github.com/Expensify/App/issues/25925

@maddylewis when you're back LMK !

@zanyrenney - yes, i think what you're suggesting here makes sense! https://github.com/Expensify/App/issues/26099#issuecomment-1702797089

Awesome, yep let's close out the newer one (i.e. your one) also that's the fairest given the change in prices happened. If you can just add the additional workflow to my issue then close this one out and I'll handle! thanks @maddylewis

great! combined with this one - https://github.com/Expensify/App/issues/25925
closing!

Hi @maddylewis sorry but we've uncovered these have different root causes (https://github.com/Expensify/App/issues/25925#issuecomment-1724705349) so will need to be tackled sepaartely, reopening for you to handle.

Rushat is working on a project with a deadline atm, so re-added the external label to add a new C+.

updated price

Issue not reproducible during KI retests. (First week)

I still can reproduce this on latest main
Screencast from 28-09-23 07:24:04.webm

will confirm if this is still reproducible

@0xmiroslav - are you still able to repro this on your end?

@0xmiroslav - lmk what you found out!

still waiting for proposals

based on the lack of progress/age of this issue, im going to close this out for now.

authors: AJV009 Ahmed-Abdella izarutskaya maddylewis mvtglobally zanyrenney


text:
[$500] Split Bill - Green dot is missing for Admin when create Split Bill from group chat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Preconditions:
User A and User B should not have existing conversation
Steps:

User B creates Group chat
User B Send a Split Bill in the group

Expected Result:
Green dot should be displayed in the 1:1 conversation in LHN
Actual Result:
Green dot is missing for Admin when create Split Bill from group chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/115492554/280b8ea9-1656-4aaa-ad44-92c7c9d0ff65

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0133bb0b95d40a556a
Upwork Job ID: 1724822672378744832
Last Price Increase: 2023-11-15

This doesn't look like a bug.
The green dot is displayed only if the report requires an action from the user. If the Admin requests a split bill, the other users owe money to the Admin, but the Admin doesn't owe the money. So the green dot should be displayed for the other users, but not for the Admin.

Closing this one out.

authors: izarutskaya lschurr paultsimura


text:
Hmm its not there error message after uploading an expense receipt in workspace

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704329850344679
Action Performed:

Create an expense by scanning a receipt in workspace

Expected Result:
Receipt scanned and expense report created and to be able to click into the preview and see the recipe to image
Actual Result:
Unexpected error message. When I click on the preview I receive a message that I don’t have access to the chat.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Commented on the slack thread but going to close this one out because I'm not sure where to look here. I checked the logs and I just can't see it even hitting our server. (The two expenses for around that date and time are for Safeway and Expedia)

authors: m-natarajan sophiepintoraetz


text:
IOU - App resumes in IOU flow when killing app in confirmation page and relaunching app

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v.1.4-36.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch New Expensify app.
Tap FAB > Request money.
Enter amount > Next.
Select a participant.
Proceed to confirmation page.
Kill the app.
Relaunch the app.

Expected Result:
The home page will open.
Actual Result:
App resumes in IOU confirmation page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/1113d32e-c03e-4a90-b516-d93448450b14
View all open jobs on GitHub

We think that this bug might be related to #vip-split-p2p-chat-groups
CC @gabrielessner

Interesting @kbecciv is the user able to normally continue in the flow after this?
Its a side effect of us saving the last visited route so this is kinda expected and I am not sure if we want to change the behaviour now

Asking in Slack about the expected outcome https://expensify.slack.com/archives/C036QM0SLJK/p1707134955066079

This is expected outcome for now, lets see if this will cause any issues as we use it

The design change related to this issue will be made. The design change work is done in this issue.

authors: hayata-suenaga kbecciv mountiny


text:
[$500] LHN shows own name for every chat until refreshed

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719938146036489
Action Performed:

Go to staging.new.expensify.com
Observe LHN

Expected Result:
LHN displayed as per priority mode
Actual Result:
LHN shows own name for every chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f46c6cbf8b49f1e7
Upwork Job ID: 1810465718859818201
Last Price Increase: 2024-07-09

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Might be a dupe of

https://github.com/Expensify/App/issues/44756

I haven't had a chance to look at this, will come back to it on Monday

@dukenv0307 can you try to reproduce, possibly by quitting/reopening NewDot or restarting your computer? Also, do you think this can be external? I'm hoping so.  It's happened to a few folks so I would love to expedite a fix, or get a RCA for the bug

@dukenv0307 can you try again? On Desktop/mac?  Asking cuz I updated the app earlier today and it didn't happen. I think signed out/in and it didn't happen.  Just now I quit then reopened the app and it did happen.

@dukenv0307 have you had any luck reproducing this one?

Is there a newdot-quality thread for this? We should be using the bug reporter to get more information

https://stackoverflowteams.com/c/expensify/questions/19512

Please remember to use newdot-quality to get the data required to troubleshoot hard to reproduce issues.
This issue needs someone to gather the Onyx state for these broken reports and trace in the serverside DB how the onyx state got malformed - which part of the code caused this.

Ok, I think that the easiest way to dig into this issue would be with a live debugging session, where someone that can actively reproduce the issue dumps some information such as their Onyx state and we track down the root cause that way.

Some data from a potentially related issue

@mallenexpensify I'm not really sure what I'm looking at in this screenshot ... I see what appears to be a LHN with a number of chats having your name and profile picture, but then in the right edge I see a column of other people's avatars, and I'm not sure what that is

The piece of code that generates names for the LHN is here, and it's different for group chats vs DMs or other reports.

For all other reports, it comes from here. I'm not sure exactly why group chat names are computed separately.

I'm not really sure what I'm looking at in https://github.com/Expensify/App/issues/44783#issuecomment-2215628166

LHN shows my name and avatar when it should so the other person I'm chatting with.
The most reliable way to reproduce might be to hard refresh the app or close/reopen desktop.
If you want do a live debug, ping me on NewDot, I'm around til, at least, 6 tonight, on all day tomorrow too.

What is this priority mode that you want to get displayed instead?

@wasxxm , it's either be most recent or focus, depending on what the user has selected.

debugged this with @mallenexpensify last week, and as @puneetlath mentioned in slack, it's caused because the report.participants field of many reports gets clobbered to only include the current user. Most likely, this would be caused by an Onyx update using Onyx.set rather than Onyx.merge, and would be a back-end issue.
So the next step is to look at PRs deployed right around the time when this was merged and look at all Onyx.set calls under a microscope. Going to start with the Auth repo

There's no guarantee, but the best place to start looking imo is https://github.com/Expensify/Auth/compare/f065f6f7e0...c2f1e5112c

Removed External

Issue not reproducible during KI retests. (First week)

Sorry I haven't tracked this one down yet. Is this still happening to people?

Good question, I don't think so?  Checking in the thread of the report in #expensify-open-source

Is anyone still experiencing this? If so, can you comment on the issue plz.  [$500] LHN shows own name for every chat until refreshed

I don't think anyone is so I'm closing.  Comment/reopen if it's still occuring.

We had someone report it on Friday: https://expensify.slack.com/archives/C049HHMV9SM/p1721367249755689
Though I haven't heard about it since then.

Think that's different Puneet, commented on the thread and also the related issue (left closed since J Li's report was over a week old and Android version might be quite outdated)

LHN shows "hidden" avatar and name but preview message show the name of the user

authors: MelvinBot VictoriaExpensify m-natarajan mallenexpensify muttmuure mvtglobally puneetlath roryabraham wasxxm


text:
Web - Attachment - Video "more options" tooltip starts with a lowercase letter

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Navigate to https://staging.new.expensify.com/
Log in with any account
Navigate to any 1:1 DM that has a video attachment
Start the video
Click on the "Fullscreen" button
Hover over the "..." button

Expected Result:
It should be "More options".
Actual Result:
Video "more options" tooltip starts with a lowercase letter.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e52e8735-f813-4975-a54b-e3039db17114

View all open jobs on GitHub

Hmm, I think this must be device specific. It's fine for me. Even if this was an issue though, I don't think it's really worth doing anything. This has no user impact.

Closing for now.

authors: IuliiaHerets joekaufmanexpensify


text:
Feature switch is enabled and cannot be disabled before the workspace is upgraded to Control

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.70-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal TEeam
Action Performed:

Go to staging.new.expensify.com
Create a Collect workspace.
Go to Workspace settings > More features.
Enable a Control plan feature (eg, Company cards).
Do not upgrade and dismiss the upgrade prompt.

Expected Result:
When toggling on a Control plan feature on a Collect workspace, the switch should remain disabled until the workspace is upgraded to Control plan (production behavior).
Actual Result:
When toggling on a Control plan feature on a Collect workspace, the switch is enabled even before workspace is upgraded to Control plan. When dismissing the upgrade prompt, the feature switch is still enabled. The toggle cannot be switched off too.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/06405738-8573-4a9f-be66-699f2b472f8a

View all open jobs on GitHub

Production
https://github.com/user-attachments/assets/158d36c9-1908-4bf1-91ce-246b1ff8a28f


text:
Bill-  Selected category for an expense in a bill is not displayed in bill intake account

Expected Result:
The user should be able to open the pending invoice to pay with the correct expense information: Merchant, Amount, Category.
Actual Result:
The invoice's expense appears as "uncaterogized".
Actions Performed:

Go to Reports and create an Invoice
Add an expense to the invoice with a Category
Send the invoice to the email address applause.expensifail.com@expensify.cash
Open the expense in the bill submitted in bill intake account

Workaround:
Unknown
Notes/Photos/Videos:

Tester login credentials - Email/Phone: applausetester@applause.expensifail.com
Tester login credentials - Password: 1password

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Its olddot issue.

authors: MelvinBot kavimuru