text:
New gulp tasks for minified dist

Sorry, didn't get it. Why is this task, if such min files are already in dist/ folder?

dist/ folder weights 1.5Mb, with my gulp tasks it weights just 388Kb

But you can just remove unnecessary files, also this folders structure update can break many existing projects with update, people will have to change paths. So i can't accept it at the moment

Closing as outdated and incompatible with current version of Swiper


text:
Add browser example in README

Done

source: gharchive/issue

repo: noveens/js-owncloud-client

license: mit

license_type: permissive

license_source: bigquery


text:
[T5A1][T14-B1] Advay Pal

@advaypal
Some comments added. Please ack & close the PR after reading comments.

source: gharchive/pull-request

authors: advaypal okkhoy

license: MIT

license_source: github-api


text:
[W5.11][W15-A3]Gilbert Emerson

20032bf commit adapted from #261.


text:
Added Title and Meta Tags

Fixes #6

repo: o-d-i-n/HelloWorld


text:
Use firebase test lab to improve stability

No plans to merge until we get Okta Firebase Test Lab credentials. Once those are in, we can restart the builds and merge.

repo: okta/okta-idx-android


text:
Fix warnings for Swift 3.0

👍

authors: jordanekay onevcat

repo: onevcat/Kingfisher


text:
Delete untracked resources of manifest work

/assign @deads2k

/assign @pmorie

/assign @qiujian16

solid idea, but I think needs some updates.
/approve
/assign @qiujian16
@qiujian16 owns lgtm

/lgtm

repo: open-cluster-management/work


text:
Added another example, being a AlkEthOH-based one

@cbayly13 notes that the code change oechem.OEWriteConstMolecule(ofs, mol) is particular important and we should be sure that we use OEWriteConstMolecule everywhere. Otherwise, if the write is not the last operation, multiple writes of the same molecule could result in modifications to the molecules.
I will need to check everything in openmoltools to ensure that we do this.

@jchodera - you can now review this.

Looks good to me. Merge when ready!

authors: cbayly13 davidlmobley jchodera

repo: open-forcefield-group/smarty


text:
Add explanatory supplement, improve wording in coordinate reference

No objections, merging now.

authors: MaxNoe lmohrmann


text:
Remove duplicate code in adaptive param noise.

@pzhokhov a small bug mentioned last time

repo: openai/baselines


text:
1 more test to make sure we temp to 0 when LOW

heh, -0 ftw.  :-)

authors: jasoncalabrese scottleibrand


text:
check voters and sponsors (on votes/events) once they are linked

@paultag: Check for what? Once they're linked what're the key things left to do?

AFK conversation led to the decision to close, since we don't know what this ticket means :)

authors: jamesturk mileswwatkins

repo: opencivicdata/imago


text:
strings

cc @hangy

repo: openfoodfacts/openfoodfacts-androidapp


text:
web service / minimal UI for osm

@michelleN can you provide more details?

I think we can close this out. We ended up building out a debug endpoint that conveyed most of the info we needed.

authors: SanyaKochhar michelleN

repo: openservicemesh/osm


text:
Add ability to stop sync to target clusters

/ok-to-test

Comments addressed, PTAL

/test e2e

/lgtm

repo: openshift/hive


text:
Added sramakr to default_data.json

Thank you for contributing to openstack/stackalytics!
openstack/stackalytics uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
https://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
https://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.

authors: openstack-gerrit sramakr

repo: openstack/stackalytics


text:
#trivial add friendly completion message.

LGTM!
No errors, no warnings. :shipit:

  Generated by :no_entry_sign: Danger

authors: lachlanh sous-machine-account

repo: opentable/sous


text:
SW-245. add coap module to system path.

Out of date PR. the issue is solved at https://openwsn.atlassian.net/browse/COAP-33.

repo: openwsn-berkeley/openwsn-sw


text:
create spec files for recipe and cookbook generators

Thanks for the contribution and the good ideas! Though you were in first, closing because this overlaps functionality added in #266.

authors: brandocorp charlesjohnson

repo: opscode/chef-dk


text:
Locking in versions of angular app

/azp

/azp run

repo: osisoft/OSI-Samples


text:
[WIP] Result documentation

related to issue #50

repo: ouspg/libfuzzerfication


text:
Implement import time typing for XLS

Punting this for now.

repo: pandaproject/panda


text:
Tests for #126124

Merged. Will do a commit to check for message with a shorter regex, to make it less flaky, as per IRC conversation.

authors: LemonBoy zoffixznet


text:
Add helper function that product dictionary

LGTM

authors: okuta unnonouno

repo: pfnet/chainer


text:
Fixes typo in readme.md

:smile_cat: Thanks!

No problem, keep up the good work!

authors: DZittersteyn pgilad

repo: pgilad/leasot


text:
Support GHC-8.6.1

It's always a pleasant surprise not having any breaking changes due to a new major version of Cabal. :)

@RyanGlScott cabal-doctest's Setup.hs is in Cabal's test-suite, so we don't break it for no good reason.

@RyanGlScott I made a revision, and also made haskell-ci to not add head.hackage (and --allow-newer) for GHC-8.6.1

authors: RyanGlScott phadej

repo: phadej/cabal-doctest


text:
Production checklist

@DiegoTaka , coloquei as figuras e a tabela no final do manuscript.tex, mas as figuras ficam com a numeração C-1, C-2, etc. Tenta resolver isso colocando as figuras antes dos apêndices. Acho que vai resolver.

Assi que resolver, pode dar o merge

Resolveu colocando as figuras antes dos apêndices.

authors: DiegoTaka birocoles


text:
Add Bean Validation support to Piranha Server

Piranha Server, just like Piranha Micro, should use the WebApplicationExtension support to deliver support for additional libraries / dependencies. So we won't be adding any dependencies directly to Piranha Server. In the end the default extension for Piranha Server will be very similar to what Tomcat/Jetty deliver. At the moment if you want to enable a different extension you need to include a META-INF/services/cloud.piranha.webapp.api.WebApplicationExtension file that has a single line for the extension you want to enable in your WAR

@arjantijms would love to find out how well Piranha Micro is working for you.

Can I go ahead and close this one?

authors: Thihup manorrock

repo: piranhacloud/piranha


text:
Does not compile with Swift 4.2

added a PR to fix.

authors: sofierPoS tgotzsche

repo: pjocprac/PTPopupWebView


text:
life 吐槽页超出文字隐藏，如何展示？modal还是新页面？

应该采用随机彩色布局

repo: pkwenda/new-bee


text:
keepalive: fix max retries

fix timeout/2

repo: plgd-dev/go-coap


text:
Farsi implementation

 You should sign our Contributor License Agreement in order to get your pull request merged.

Thank you for your interest in contributing to Numsense. Before I proceed with a review, could you please update the fork so that all merge conflicts are resolved?
Once you've done that, please add a note here to that effect. The reason is that GitHub doesn't send out notifications when pull request forks are updated. Adding a note here ensures that I get a notification, and that means that I'll discover the update sooner.

Fixed the conflicts.
Thanks beforehand.

Thank you for your interest in contributing to Numsense! This pull request certainly looks promising :+1:
I only have a few small questions (apart from the inline comment I've already added):

Is there a specific reason you didn't add properties to the NumeralProperties module (NumeralProperties.fs)? For Danish and English, this is how all negative numbers are verified, but Farsi negative numbers may be dealt with using logic different from that, so there may be a good reason for that; I only ask out of ignorance. Likewise, the other property of both English and Danish is that numbers can round-trip, but again, Farsi numerals may be structured in such a way that this is logically impossible...
Did you forget to add FarsiNumeralConverter to NumeralConverterProperties, or is there a specific reason you left that out?

The latest commit should have addressed all the issues mentioned above. Please let me know if there's anything else.

It's looking good now :+1: It also builds and runs all tests without warnings on my machine, so from a technical perspective I think we're good to go.
As I don't read Farsi, I'd like someone who does to review that part of it, if at all possible. I don't expect any errors, but it's always good with a second pair of eyes :smile:

I solicited a review on Twitter: https://twitter.com/ploeh/status/685066949114609664
Please retweet and spread the word :smile:

I suppose no complaints means that there are no errors found so far :smile:
The only problem now is that the PR no longer can be automatically merged. If you can update the PR by addressing the conflicts, I'll subsequently pull it.

Just merged the branch with master. Please pull.

Thank you for your contribution! It's now live as Numsense 0.6.0.

authors: CLAassistant HEskandari ploeh

repo: ploeh/Numsense


text:
some random stuff

You picked the wrong repo fool


text:
adds actions for building geni-lib contexts

Hello @ivotron! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file .ci/one-baremetal-node.py:

Line 11:80: E501 line too long (91 > 79 characters)

In the file exec/util.py:

Line 29:16: E211 whitespace before '('
Line 30:3: E111 indentation is not a multiple of four
Line 32:3: E111 indentation is not a multiple of four
Line 34:1: E302 expected 2 blank lines, found 1
Line 34:20: E211 whitespace before '('
Line 35:3: E111 indentation is not a multiple of four
Line 38:3: E111 indentation is not a multiple of four
Line 39:3: E111 indentation is not a multiple of four
Line 40:3: E111 indentation is not a multiple of four
Line 42:7: E111 indentation is not a multiple of four
Line 44:3: E111 indentation is not a multiple of four
Line 47:19: E211 whitespace before '('
Line 48:3: E111 indentation is not a multiple of four
Line 49:3: E111 indentation is not a multiple of four
Line 51:3: E111 indentation is not a multiple of four
Line 52:3: E111 indentation is not a multiple of four
Line 54:7: E111 indentation is not a multiple of four
Line 54:80: E501 line too long (91 > 79 characters)
Line 55:3: E111 indentation is not a multiple of four
Line 57:7: E111 indentation is not a multiple of four
Line 57:80: E501 line too long (101 > 79 characters)
Line 58:3: E111 indentation is not a multiple of four
Line 61:19: E211 whitespace before '('
Line 61:28: E251 unexpected spaces around keyword / parameter equals
Line 61:30: E251 unexpected spaces around keyword / parameter equals
Line 61:39: E251 unexpected spaces around keyword / parameter equals
Line 61:41: E251 unexpected spaces around keyword / parameter equals
Line 61:53: E251 unexpected spaces around keyword / parameter equals
Line 61:55: E251 unexpected spaces around keyword / parameter equals
Line 61:70: E251 unexpected spaces around keyword / parameter equals
Line 61:72: E251 unexpected spaces around keyword / parameter equals
Line 62:3: E111 indentation is not a multiple of four
Line 70:3: E111 indentation is not a multiple of four
Line 73:3: E111 indentation is not a multiple of four
Line 74:3: E111 indentation is not a multiple of four
Line 81:21: E211 whitespace before '('
Line 82:3: E111 indentation is not a multiple of four
Line 83:80: E501 line too long (91 > 79 characters)
Line 84:80: E501 line too long (83 > 79 characters)
Line 91:3: E111 indentation is not a multiple of four
Line 93:3: E111 indentation is not a multiple of four
Line 97:1: E302 expected 2 blank lines, found 1
Line 97:17: E211 whitespace before '('
Line 98:3: E111 indentation is not a multiple of four
Line 106:3: E111 indentation is not a multiple of four
Line 107:3: E111 indentation is not a multiple of four
Line 110:3: E111 indentation is not a multiple of four
Line 111:3: E111 indentation is not a multiple of four
Line 113:7: E111 indentation is not a multiple of four
Line 114:7: E111 indentation is not a multiple of four
Line 116:3: E111 indentation is not a multiple of four
Line 119:3: E111 indentation is not a multiple of four
Line 120:3: E111 indentation is not a multiple of four
Line 121:10: E231 missing whitespace after ','
Line 121:14: E231 missing whitespace after ','
Line 124:7: E111 indentation is not a multiple of four
Line 125:7: E111 indentation is not a multiple of four
Line 126:7: E111 indentation is not a multiple of four
Line 127:7: E111 indentation is not a multiple of four
Line 129:3: E111 indentation is not a multiple of four
Line 132:26: E211 whitespace before '('
Line 133:3: E111 indentation is not a multiple of four
Line 136:3: E111 indentation is not a multiple of four
Line 139:1: E302 expected 2 blank lines, found 1
Line 139:22: E211 whitespace before '('
Line 140:3: E111 indentation is not a multiple of four
Line 153:3: E111 indentation is not a multiple of four
Line 153:3: E303 too many blank lines (2)
Line 154:3: E111 indentation is not a multiple of four
Line 158:3: E111 indentation is not a multiple of four
Line 161:3: E111 indentation is not a multiple of four
Line 162:3: E111 indentation is not a multiple of four
Line 163:10: E231 missing whitespace after ','
Line 166:3: E111 indentation is not a multiple of four
Line 170:3: E111 indentation is not a multiple of four
Line 170:80: E501 line too long (108 > 79 characters)
Line 171:3: E111 indentation is not a multiple of four
Line 173:3: E111 indentation is not a multiple of four
Line 176:1: E302 expected 2 blank lines, found 1
Line 176:31: E251 unexpected spaces around keyword / parameter equals
Line 176:33: E251 unexpected spaces around keyword / parameter equals
Line 177:3: E111 indentation is not a multiple of four
Line 177:80: E501 line too long (125 > 79 characters)
Line 179:3: E114 indentation is not a multiple of four (comment)
Line 181:3: E111 indentation is not a multiple of four
Line 184:3: E111 indentation is not a multiple of four
Line 185:3: E111 indentation is not a multiple of four
Line 185:24: E261 at least two spaces before inline comment
Line 187:3: E111 indentation is not a multiple of four
Line 189:3: E111 indentation is not a multiple of four
Line 191:7: E111 indentation is not a multiple of four
Line 194:7: E111 indentation is not a multiple of four
Line 196:7: E111 indentation is not a multiple of four
Line 198:3: E111 indentation is not a multiple of four
Line 200:7: E111 indentation is not a multiple of four
Line 201:7: E111 indentation is not a multiple of four
Line 207:7: E111 indentation is not a multiple of four
Line 211:3: E111 indentation is not a multiple of four
Line 213:3: E111 indentation is not a multiple of four
Line 216:13: E211 whitespace before '('
Line 217:3: E111 indentation is not a multiple of four
Line 217:80: E501 line too long (113 > 79 characters)
Line 218:3: E114 indentation is not a multiple of four (comment)
Line 220:3: E111 indentation is not a multiple of four
Line 221:3: E111 indentation is not a multiple of four
Line 223:3: E111 indentation is not a multiple of four
Line 224:3: E111 indentation is not a multiple of four
Line 224:24: E261 at least two spaces before inline comment
Line 226:3: E111 indentation is not a multiple of four
Line 228:3: E111 indentation is not a multiple of four
Line 230:7: E111 indentation is not a multiple of four
Line 231:7: E111 indentation is not a multiple of four
Line 234:11: E111 indentation is not a multiple of four
Line 236:7: E111 indentation is not a multiple of four
Line 241:11: E111 indentation is not a multiple of four
Line 242:11: E111 indentation is not a multiple of four
Line 244:80: E501 line too long (85 > 79 characters)
Line 247:11: E111 indentation is not a multiple of four
Line 250:11: E111 indentation is not a multiple of four
Line 253:5: E303 too many blank lines (2)
Line 254:7: E111 indentation is not a multiple of four
Line 257:7: E111 indentation is not a multiple of four
Line 260:7: E111 indentation is not a multiple of four
Line 261:7: E111 indentation is not a multiple of four
Line 262:7: E111 indentation is not a multiple of four
Line 263:7: E111 indentation is not a multiple of four
Line 265:11: E111 indentation is not a multiple of four
Line 266:7: E111 indentation is not a multiple of four
Line 268:7: E114 indentation is not a multiple of four (comment)
Line 268:80: E501 line too long (95 > 79 characters)
Line 269:7: E111 indentation is not a multiple of four
Line 271:11: E111 indentation is not a multiple of four
Line 273:11: E111 indentation is not a multiple of four
Line 273:80: E501 line too long (85 > 79 characters)
Line 275:11: E111 indentation is not a multiple of four
Line 277:11: E111 indentation is not a multiple of four
Line 278:11: E111 indentation is not a multiple of four
Line 279:21: E261 at least two spaces before inline comment
Line 280:11: E114 indentation is not a multiple of four (comment)
Line 281:11: E111 indentation is not a multiple of four
Line 281:80: E501 line too long (87 > 79 characters)
Line 284:11: E114 indentation is not a multiple of four (comment)
Line 285:11: E111 indentation is not a multiple of four
Line 286:11: E111 indentation is not a multiple of four
Line 288:15: E111 indentation is not a multiple of four
Line 289:15: E111 indentation is not a multiple of four
Line 289:80: E501 line too long (89 > 79 characters)
Line 290:80: E501 line too long (80 > 79 characters)
Line 291:15: E111 indentation is not a multiple of four
Line 293:11: E114 indentation is not a multiple of four (comment)
Line 294:11: E111 indentation is not a multiple of four
Line 294:80: E501 line too long (87 > 79 characters)
Line 297:11: E111 indentation is not a multiple of four
Line 298:11: E111 indentation is not a multiple of four
Line 301:11: E111 indentation is not a multiple of four
Line 303:11: E111 indentation is not a multiple of four
Line 303:19: E261 at least two spaces before inline comment
Line 303:20: E262 inline comment should start with '# '
Line 306:3: E111 indentation is not a multiple of four
Line 306:3: E303 too many blank lines (2)
Line 308:3: E111 indentation is not a multiple of four
Line 312:3: E111 indentation is not a multiple of four
Line 312:14: E211 whitespace before '('
Line 312:27: E261 at least two spaces before inline comment
Line 314:7: E111 indentation is not a multiple of four
Line 316:7: E111 indentation is not a multiple of four
Line 320:19: E211 whitespace before '('
Line 320:25: E251 unexpected spaces around keyword / parameter equals
Line 320:27: E251 unexpected spaces around keyword / parameter equals
Line 321:3: E111 indentation is not a multiple of four
Line 322:3: E111 indentation is not a multiple of four
Line 324:3: E111 indentation is not a multiple of four
Line 327:3: E111 indentation is not a multiple of four
Line 328:3: E111 indentation is not a multiple of four
Line 331:7: E111 indentation is not a multiple of four
Line 332:7: E111 indentation is not a multiple of four
Line 333:7: E111 indentation is not a multiple of four
Line 335:3: E111 indentation is not a multiple of four
Line 338:3: E111 indentation is not a multiple of four
Line 340:1: E302 expected 2 blank lines, found 1
Line 340:21: E211 whitespace before '('
Line 341:3: E111 indentation is not a multiple of four
Line 343:3: E111 indentation is not a multiple of four
Line 344:3: E111 indentation is not a multiple of four
Line 344:8: E231 missing whitespace after ','
Line 346:7: E111 indentation is not a multiple of four
Line 347:3: E111 indentation is not a multiple of four
Line 349:1: E302 expected 2 blank lines, found 1
Line 349:19: E211 whitespace before '('
Line 349:32: E251 unexpected spaces around keyword / parameter equals
Line 349:34: E251 unexpected spaces around keyword / parameter equals
Line 350:3: E111 indentation is not a multiple of four
Line 352:3: E111 indentation is not a multiple of four
Line 355:3: E111 indentation is not a multiple of four
Line 355:17: E203 whitespace before ':'
Line 356:3: E111 indentation is not a multiple of four
Line 361:16: E211 whitespace before '('
Line 361:22: E251 unexpected spaces around keyword / parameter equals
Line 361:24: E251 unexpected spaces around keyword / parameter equals
Line 361:45: E251 unexpected spaces around keyword / parameter equals
Line 361:47: E251 unexpected spaces around keyword / parameter equals
Line 362:3: E111 indentation is not a multiple of four
Line 363:3: E111 indentation is not a multiple of four
Line 364:3: E111 indentation is not a multiple of four
Line 365:3: E111 indentation is not a multiple of four
Line 367:3: E111 indentation is not a multiple of four
Line 369:3: E111 indentation is not a multiple of four
Line 372:3: E111 indentation is not a multiple of four
Line 374:3: E111 indentation is not a multiple of four
Line 376:3: E111 indentation is not a multiple of four
Line 380:3: E111 indentation is not a multiple of four
Line 384:7: E111 indentation is not a multiple of four
Line 386:7: E111 indentation is not a multiple of four
Line 388:7: E111 indentation is not a multiple of four
Line 401:3: E111 indentation is not a multiple of four
Line 408:7: E111 indentation is not a multiple of four
Line 410:7: E111 indentation is not a multiple of four
Line 417:7: E111 indentation is not a multiple of four
Line 418:7: E111 indentation is not a multiple of four
Line 419:7: E111 indentation is not a multiple of four
Line 420:7: E111 indentation is not a multiple of four
Line 421:7: E111 indentation is not a multiple of four
Line 423:7: E111 indentation is not a multiple of four
Line 425:3: E111 indentation is not a multiple of four
Line 426:3: E111 indentation is not a multiple of four
Line 427:3: E111 indentation is not a multiple of four
Line 427:80: E501 line too long (95 > 79 characters)
Line 428:3: E111 indentation is not a multiple of four
Line 429:80: E501 line too long (85 > 79 characters)
Line 430:3: E111 indentation is not a multiple of four
Line 433:19: E211 whitespace before '('
Line 434:3: E111 indentation is not a multiple of four
Line 436:3: E111 indentation is not a multiple of four
Line 437:3: E111 indentation is not a multiple of four
Line 441:3: E111 indentation is not a multiple of four
Line 441:14: E211 whitespace before '('
Line 442:80: E501 line too long (102 > 79 characters)
Line 446:3: E111 indentation is not a multiple of four
Line 446:15: E211 whitespace before '('
Line 450:3: E111 indentation is not a multiple of four
Line 450:14: E211 whitespace before '('
Line 453:1: E302 expected 2 blank lines, found 1
Line 453:21: E211 whitespace before '('
Line 454:3: E111 indentation is not a multiple of four
Line 454:80: E501 line too long (96 > 79 characters)
Line 455:3: E111 indentation is not a multiple of four
Line 457:7: E111 indentation is not a multiple of four
Line 459:1: E305 expected 2 blank lines after class or function definition, found 1
Line 461:1: E302 expected 2 blank lines, found 1
Line 461:27: E211 whitespace before '('
Line 461:53: E251 unexpected spaces around keyword / parameter equals
Line 461:55: E251 unexpected spaces around keyword / parameter equals
Line 461:76: E251 unexpected spaces around keyword / parameter equals
Line 461:78: E251 unexpected spaces around keyword / parameter equals
Line 461:80: E501 line too long (84 > 79 characters)
Line 462:3: E111 indentation is not a multiple of four
Line 464:3: E111 indentation is not a multiple of four
Line 466:3: E114 indentation is not a multiple of four (comment)
Line 467:3: E111 indentation is not a multiple of four
Line 469:3: E111 indentation is not a multiple of four
Line 471:3: E111 indentation is not a multiple of four
Line 472:3: E111 indentation is not a multiple of four
Line 475:7: E111 indentation is not a multiple of four
Line 480:7: E111 indentation is not a multiple of four
Line 482:3: E114 indentation is not a multiple of four (comment)
Line 483:3: E111 indentation is not a multiple of four
Line 484:3: E111 indentation is not a multiple of four
Line 486:3: E111 indentation is not a multiple of four
Line 487:3: E111 indentation is not a multiple of four
Line 489:7: E111 indentation is not a multiple of four
Line 491:7: E111 indentation is not a multiple of four
Line 493:3: E111 indentation is not a multiple of four
Line 495:3: E114 indentation is not a multiple of four (comment)
Line 496:3: E111 indentation is not a multiple of four
Line 498:3: E111 indentation is not a multiple of four
Line 501:3: E114 indentation is not a multiple of four (comment)
Line 501:80: E501 line too long (101 > 79 characters)
Line 502:3: E114 indentation is not a multiple of four (comment)
Line 503:3: E111 indentation is not a multiple of four
Line 504:3: E111 indentation is not a multiple of four
Line 508:7: E111 indentation is not a multiple of four
Line 509:7: E111 indentation is not a multiple of four
Line 510:80: E501 line too long (100 > 79 characters)
Line 511:80: E501 line too long (112 > 79 characters)
Line 512:11: E111 indentation is not a multiple of four
Line 515:7: E111 indentation is not a multiple of four
Line 516:7: E111 indentation is not a multiple of four
Line 518:11: E111 indentation is not a multiple of four
Line 521:80: E501 line too long (85 > 79 characters)
Line 523:7: E111 indentation is not a multiple of four
Line 524:7: E111 indentation is not a multiple of four
Line 524:80: E501 line too long (95 > 79 characters)
Line 524:88: E251 unexpected spaces around keyword / parameter equals
Line 524:90: E251 unexpected spaces around keyword / parameter equals
Line 525:7: E111 indentation is not a multiple of four
Line 526:3: E111 indentation is not a multiple of four
Line 529:7: E111 indentation is not a multiple of four
Line 531:3: E114 indentation is not a multiple of four (comment)
Line 532:3: E111 indentation is not a multiple of four
Line 534:3: E111 indentation is not a multiple of four
Line 536:3: E111 indentation is not a multiple of four
Line 540:7: E111 indentation is not a multiple of four
Line 542:3: E111 indentation is not a multiple of four
Line 543:3: E111 indentation is not a multiple of four
Line 544:3: E111 indentation is not a multiple of four
Line 545:3: E111 indentation is not a multiple of four
Line 546:3: E111 indentation is not a multiple of four
Line 547:3: E111 indentation is not a multiple of four
Line 548:3: E111 indentation is not a multiple of four
Line 549:3: E111 indentation is not a multiple of four
Line 550:3: E111 indentation is not a multiple of four
Line 553:18: E211 whitespace before '('
Line 553:80: E501 line too long (104 > 79 characters)
Line 554:3: E111 indentation is not a multiple of four
Line 556:3: E114 indentation is not a multiple of four (comment)
Line 557:3: E111 indentation is not a multiple of four
Line 559:3: E111 indentation is not a multiple of four
Line 560:3: E111 indentation is not a multiple of four
Line 562:3: E111 indentation is not a multiple of four
Line 565:3: E111 indentation is not a multiple of four
Line 568:3: E111 indentation is not a multiple of four
Line 571:3: E111 indentation is not a multiple of four
Line 572:3: E111 indentation is not a multiple of four
Line 573:3: E111 indentation is not a multiple of four
Line 574:3: E111 indentation is not a multiple of four
Line 575:3: E111 indentation is not a multiple of four
Line 576:3: E111 indentation is not a multiple of four
Line 577:3: E111 indentation is not a multiple of four
Line 578:3: E111 indentation is not a multiple of four
Line 579:3: E111 indentation is not a multiple of four

repo: popperized/geni


text:
improve migrateToNewRouter

Codecov Report

Merging #134 (199821d) into master (5f4b6f3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   66.56%   66.60%   +0.03%
==========================================
  Files          57       57
  Lines        3553     3557       +4
  Branches      531      531
==========================================
+ Hits         2365     2369       +4
  Misses       1188     1188

Impacted Files
Coverage Δ

...tracts/powerindex-router/PowerIndexBasicRouter.sol
95.12% <100.00%> (+0.12%)
:arrow_up:

...tracts/powerindex-router/PowerIndexNaiveRouter.sol
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4b6f3...199821d. Read the comment docs.

authors: codecov-commenter defi-dev

repo: powerpool-finance/powerindex


text:
issue #144 - spread remaining props on parent div

Rebased

Rebased.

@cklab can you rebase with latest master?

@ad1992 rebased

Rebased once more.

@cklab can you rebase with latest master and make the review fixes?

Apologies, I haven't used this library for almost a year now. I don't have the luxury to continually rebase and resolve conflicts for trivial reasons.


text:
Keep "operator": "==", optional

Fixed in 0.3.4

repo: prashanth-sams/client-api


text:
Widen 'useProvidedRefOrCreate' type to some near-equivalents

Closing, this has been handled now in the overlay branch.

repo: primer/components


text:
Aggregations (experimental)

Placeholder page merged in here with link to release notes: https://github.com/prisma/docs/pull/660

repo: prisma/docs


text:
Cli: compare response codes directly instead of catching exception

Addresses a comment from previous PR

repo: prodo-ai/plz


text:
Sentiment Analysis Dutch

sentiment analysis dutch

@danyitian thanks for your first contribution! Please add MLproject file to your pull request.

authors: danyitian slavakurilyak

repo: produvia/ai-platform


text:
Fix bugs in snapshot code

@robbrockbank this one is critical for v2.0

LGTM

authors: caseydavenport robbrockbank

repo: projectcalico/libcalico-go


text:
Cherry pick master fixes into 1.1.x-series

LGTM

authors: robbrockbank tmjd


text:
Fix #1926 sync triggers even no inputs

:shipit:

authors: shrimpy suwatch

repo: projectkudu/kudu


text:
Added illustration banner title to the README

👍

👍

authors: Haud MichaelCampbell paulmiard

repo: prolificinteractive/Yoshi


text:
Add good & bad examples of static method behavior.

If something needs to analyze the class itself, it operates on the wrong level.
If the use case needs a different behavior for bot users and regular users, it should not use if statements for this.
We should define the bot behavior class and the user behavior class and pass it to the use case.
These behavior classes would have the same interface, so there is no need to handle it with if statement.
We will instantiate the use case with two different classes in two different places.


text:
Add log level CLI option.

I was thinking to treat bikes/* as library code and to keep using debuglog() in there rather than couple it to the app's logger. The benefit being to be able to easily extract that stuff to a library/libraries if ever that made sense.
Looking at this again we do so little logging from the app I am wondering if we should ditch the log-level argument and go with something like your PR, but swap out debuglog() for the debug library which has millisecond timestamps and nicer formatting. An added benefit of that would be we could also see noble, bleno, serialport and other debug logs in context as they use that library too.
I'm also thinking we could shorten the debug scope names from "gymnasticon:" to "gn:" or similar.
What do you think?

That's a great idea!
And after troubleshooting the Keiser issues with the older firmware, I certainly agree with you that seeing milliseconds in the debug output is very helpful!
Also my initial fear of flooding the Raspberry SD card with too many log files is gone, after removing syslogd as part of #58.


text:
Get rid of bookmarks and saved searches

Are we generally against these features in blacklight?

In Pom, yes, but not Orangelight

authors: jpstroop tpendragon

repo: pulibrary/pomegranate


text:
schemas populateString bug - can't open "New Page" menu

was never a real bug.  but we added a more useful error message in 3a15b0da21fb069a9687605983f9afe667f16640

repo: punkave/apostrophe


text:
Allow setup to ask to not manage the service

Hi @bobtfish and thanks for the PR. Sorry for the long delay.
This looks potentially useful, although the parameter naming rings awkward with me.
How do you feel about exposing the values for ensure and enable as module parameters, so that the user can override them to be undef or whatever is appropriate?

closing for inactivity, failing tests, and awkward naming.

authors: bobtfish ffrank igalic

repo: puppet-community/puppet-mcollective


text:
0.1.0 prep

:+1:


text:
More instances for Product. Missing dependency.

Thanks! Is MonadPlus valid too?

Intuitively, yes, since everything just happens pointwise. I'll have a
closer look at it tomorrow.
On 28 Apr 2016 7:10 pm, "Phil Freeman" notifications@github.com wrote:

Thanks! Is MonadPlus valid too?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/purescript/purescript-functors/pull/3#issuecomment-215497711

If I haven't missed something, MonadPlus appears to be valid, too:
  (product a a' <|> product b b') >>= f
= product (a <|> b) (a' <|> b') >>= f
= product ((a <|> b) >>= (fstP <<< f)) ((a' <|> b') >>= (sndP <<< f))
= product ((a >>= (fstP <<< f)) <|> (b >>= (fstP <<< f))) ((a' >>= (sndP <<< f)) <|> (b' >>= (sndP <<< f)))
= product (a >>= (fstP <<< f)) (a' >>= (sndP <<< f)) <|> product (b >>= (fstP <<< f)) (b' >>= (sndP <<< f))
= (product a a' >>= f) <|> (product b b' >>= f)

(fstP is fst <<< runProduct and snd analogous)

👍 @garyb Can we include this when we bump to 1.0?

Sure thing. This repo becomes deprecated then in favour of purescript-functor-coproducts, I'll re-apply the changes there.

Ah, ok.

authors: garyb paf31 zrho

repo: purescript/purescript-functors


text:
Create loadview-testing

SPAM.

authors: jaymitripp philipa

repo: pushtechnology/java-load-testing-tool


text:
Array

02/17/2017

repo: qinyuanhang/leetCODE


text:
增加ss://，增加复制功能

Coverage increased (+0.02%) to 86.002% when pulling 91e37d634fcee451e1403ecf0a45c555af96cade on develop into fde59a9d7c0a1f837ab7ba3a65594ce228f07f3d on master.

authors: coveralls qious

repo: qious/ss-panel


text:
Add theme support

I have no idea why it's doing this, since I don't think you touched that file, but this branch also messed up the menu:

Sorry for not including that in my original report. I've confirmed this looks fine in master.

Not sure why you're seeing the greyed out menu. I may have to dig up my windows laptop this weekend to do some testing.

authors: NoahAndrews skullydazed


text:
Add documentation for gate_headers option in bastion

:+1:

Part of issue #42

authors: BenjamenMeyer TheSriram isaacm

repo: racker/eom


text:
Show I/O and Network stats on hosts & containers

This was added a while ago..

repo: rancher/rancher


text:
Move tests dir

LGTM

lgtm

authors: cjellick daxmc99 dramich


text:
Updated google analytics to something we are tracking instead of the default

cool give me the credentials for this sometime

authors: agundy seveibar


text:
[core] corrected the xutility inclusion.

https://jenkins.code.rdkcentral.com/job/github-triggered/251/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/255/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/273/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/298/ started

authors: anjalirajan rdkcmf-jenkins

repo: rdkcentral/Thunder


text:
v6.8.0 update

Thanks for the review @pmaier983

repo: react-hook-form/documentation


text:
NullPointer exception if no resize handler is set

Must be something messed up in the handler initalization code


text:
Tracing and Logging backports for v0.29.x

Closing out as we won't be needing to backport this to those versions.


text:
Sub development

This is a bad idea...


text:
fyx for https://github.com/reidpds/Storefront/issues/749

@reidransom once this is merged I can close https://github.com/reidpds/Storefront/issues/749

@theSage21 Please explain why this is necessary and what alternative avenues you considered.  PRs to this repo should only be for fixing bugs IMO.  Each change makes it more difficult to merge back with selectize proper.  The selectize APIs make it possible to make just about any customizations to the UI you should need.  If not, you should also be sure to consider the custom search dropdown code we are using in SF or select2 as well.

@reidransom this is a bug fix. I tried to alter SF code instead of this but could not attain necessary results with just that. Since the proposed fix was a one line change when we ignore the dist folder and the original issue documented the bug, I did not include a description in the PR.

In multi select fields, removed elements when added back are still having the "active" class on them leading to the behavior described in the issue.
Selectize JS had an issue reported with similar behavior a while back.

https://github.com/selectize/selectize.js/issues/1212
The proposed fix for that is present in our fork but the behavior perisists.

In our code, we add the 'x' part to enable removal of tags with a single click.

The 'x' button calls selectize to remove the corresponding tag.
The code in selectize is adding the 'active' class on click events which remains there the next time the same tag is added back to the filters.

Since there's no code in selectize that removes the active class when removing the element this PR adds that one line of change.
I also re-built the dist folder so that we can directly use this in storefront.


text:
"Relative links can break" warning should not happen for "mailto:email" href

Sorry for the delay, and thanks for the report! Will take a look at this soon.

authors: gre revivek

repo: revivek/oy


text:
Why payment channel and escrow only support XRP, what if it supports issued currency?

We want to escrow some issuing currency ,but found that escrow only support xrp. What if I change the code to support issuing currency?

We can’t stop you from changing the code to add such support, or from campaigning to get the amendment associated with your changes approved. If you want to submit a pull request, to include your changes in our release branch that would be cool and we would certainly review your code and consider it for inclusion.
But the change you are suggesting is quite extensive and is not as cut and dry. Please consider that unlike an XRP escrow, where the XRP itself is being held within the escrow object and there is no counterparty, an IOU escrow involves a counterparty and  represents an obligation of the that counterparty.
You will need to provide a mechanism that allows issuers to explicitly opt in to allowing their issuances to be escrowed and to decide how other, existing, features interact with IOU escrows.
Also challenging, such an object will need to thread against three accounts: the sender, the receiver and the issuer. No such support exists at this time, and adding it will likely require low-level changes.
This is certainly a challenging modification. Beyond the technical, I think that the semantics of an IOU escrow would be somewhat surprising to people, and that will be the bigger challenge.

As far as I understand Escrow, it is just a semi-automatic way to have funds sent somewhere after some timestamp has passed and/or to have a way to encode branching into a transaction ("If X gets revealed by Y then Z, otherwise Cancel"). I'm not sure why this would be unexpected functionality just because the currency that is transacted that way is not called XRP or because the base asset is held by a third party instead of nonexistent (XRP just stand for themselves).
There are some immediate concerns coming to my mind around freezing, (changing) issuer fees and QualityIn/QualityOut settings as well as a potential receiver not having enough "room" in a trust line for additional IOUs. I suspect IOU Escows actually might only be allowed to release into Checks instead of directly releasing funds into target accounts.
I don't see why issuers would have to opt in to have their issuances Escrowed, after all the same functionality could be provided invisible to XRPL off-chain too by handing limited control of an account to a smart contract. Unlike Freezing I would rather see IOU Escrow being implemented as "issuer opt-out" and "default on".
All in all I think IOU Escrow might be possible and I can see a lot of use cases for it actually, I wouldn't rank it as top priority on my wish list though - IOU PayChan for example would be ranked higher. This is of course just my opinion and it would be awesome to see a more concrete design for IOU Escrow. As Nik said though, it is definitely a challenge.

@MarkusTeufelberger, a couple of thoughts:

I don't see why issuers would have to opt in to have their issuances Escrowed

Issuers should be able to quickly sum up their total obligations; they do so by examining all the trustlines associated with their account.
Escrowed funds would not be kept in a trust line, but in the escrowed object itself, which means that, without the ability to opt-out, issuers would be, at a minimum, be forced to make changes to their accounting systems if this amendment were activated.
Interaction with existing IOU-specific features is also challenging, as we both pointed out.

Depending on the design, an Escrowed IOU could consist of both an Escrow object that contains the escrow related settings and a RippleState (towards the Escrow object) that contains the balance related stuff. That way iterating over RippleState objects would still give the correct, total outstanding balance - the downside is that it is now ~twice as expensive data wise than an XRP only escrow.

@nbougalis I have made a change in my code and it works fine except for that  total obligations is not easy to sum up.
I applied the change and just update on a chain without Escrow transaction before，there's no problem. I know that if I change on the public chain, it must be done with a new feature.
So,  do you have some suggestions for summing up total obligations ?  If I add every escrow to Issuer's dir, it seems not so elegant.

@MarkusTeufelberger thanks for your 'immediate concerns',  I will think more deeply about it.

If you can push your changes to a branch on GitHub and give me a link, I’d be happy to take a look at what you did.

@nbougalis I had tried to push my branch. But failed, seems I don't have the right ?
Git outputs:
$ git push --set-upstream origin feature/escrowForIOU
Enter passphrase for key '/c/Users/Jerry/.ssh/id_rsa':
ERROR: Permission to ripple/rippled.git denied to luleigreat.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists

@luleigreat On GitHub, the typical workflow is for you to create a fork (click the Fork button at the top right) and then push to your fork. You can use git remote add to add your fork as a remote.
You can then create a Pull Request (PR) at https://github.com/ripple/rippled/compare (click compare across forks).

Thanks very much @intelliot .
I have successfully made a pull request.

Thank you for opening PR #2672, @luleigreat! I'm going to close this issue and we can continue the discussion there.

authors: MarkusTeufelberger intelliot luleigreat nbougalis

repo: ripple/rippled

license: ISC


text:
added known failure decorator to schema_metadata_test

+1

authors: nutbunnies ptnapoleon

repo: riptano/cassandra-dtest


text:
Mix update & follow credo

Coverage increased (+0.1%) to 83.824% when pulling 668df1b449d8d414b1217dcab5427268b6effdfc on mix-update into a0ae3d4db5e7d27d86831a82c81618206df6ab0c on master.

authors: coveralls riseshia

repo: riseshia/gannbaruzoi


text:
[method]get a list of event listeners attached to the target node

and test

repo: riversun/event-listener-helper


text:
Add Macos X build support (thanks @samkrew)

Sorry for the question, but is @samkrew okay with you as the author of the patch?

ping @samkrew ?

timeout ?

authors: arska lategoodbye

repo: rscada/libmbus


text:
Fix incorrect client input when FPD site.domain is an ARRAY

Huge FPD revising is coming. Closing.

repo: rubicon-project/prebid-server-java


text:
Add RFC For Algebraic Effects

When you come to the Rust, you really feel safe because the compiler garante a lot of things to you, until you need a guarantee that rust do not provide. When this happen, the only thing you can do today are document saying "please do not use a function that have 'that effect' otherwise bad things will happen".  And this is totally okay, but is not what a Rust programmer expect, because he trust the compiler to avoid unexpected behaviors.

repo: rust-lang/rfcs


text:
Updating Dockerfile and adding config file example with instructions

Thanks @codemiller!

authors: codemiller ryanj


text:
Can it be used on Windows tensorflow?

@syan1992 I haven't tried it. But it should be possible. Please refer to https://github.com/sadeepj/crfasrnn_keras/issues/2 for more details.


text:
Sak 29914 Making calendar export period configurable by adding config params

No. I've deleted that line now

Corrected indendation and rebased

repo: sakaiproject/sakai


text:
SAK-30505 Moved event fire to connections logic

LGTM

authors: adrianfish ottenhoff


text:
implemented getEmail

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Gowtham Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@gowthamrodda - thanks for the contribution! I really appreciate it. Having a specific function for getting a record by email is probably too specific for the core api of SakuraApi. The build in get method would work fine for that purpose as it lets you provide any valid query.
See: https://github.com/sakuraapi/api/blob/develop/core/%40model/model.ts#L672
And example of how this could be used would be:
const someModel = SomeModel.get({filter:{email: 'someone@somewhere.com'}});

authors: CLAassistant etsuo gowthamrodda

repo: sakuraapi/api


text:
An ugly way to fix 48 bug and some test case

@sc0Vu Thanks

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     88.23%   88.23%
  Complexity      661      661
=========================================
  Files            47       47
  Lines          1454     1454
=========================================
  Hits           1283     1283
  Misses          171      171

Impacted Files
Coverage Δ
Complexity Δ

src/Utils.php
94.81% <100%> (ø)
86 <0> (ø)
:arrow_down:

src/Formatters/IntegerFormatter.php
100% <100%> (ø)
4 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00817ee...1760576. Read the comment docs.


text:
Fix #2639: Refuse to import modules without module support

Review by @sjrd

I manually checked that this triggers if a @JSImport is used.

Updated.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3520/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4637/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3529/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4646/
Test PASSed.

repo: scala-js/scala-js


text:
Adding Cite-seq-Count for CITE seq data

Although CITE seq data is a different assay type than mRNA, this method is not stricktly "integrating" multi assay data.
Should I add a new section for this?

repo: seandavi/awesome-single-cell


text:
Fix raml/api.raml syntax and structure

Coverage remained the same at 30.859% when pulling 1302eb7214e158acd16ae44dc0bba83a231e771a on fix-raml into 2870300edcd634cfe182fa0ed431f4d951c952ef on master.

authors: coveralls maretskiy

repo: seecloud/notify


text:
Consul integration

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/685/

lgtm

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/686/

authors: jenkins-sequenceiq keyki martonsereg

repo: sequenceiq/cloudbreak


text:
[TEST} Feature Requests

History Slider

repo: serge-rgb/libserg


text:
Fix error in homepage route

Thanks for sending this PR. Currently the master branch is a little behind of our develop branch and it is going to take a while for to do the merge. Thanks again.

authors: iambrosi ratasxy

repo: servergrove/ServerGroveLiveChat


text:
Generator should not add server side bundle compliation instructions into assets.rake when server side rendering is not specified in generator params

@szyablitsky @robwise This is basically correct that we might not have as server side bundle. But how would we know? Maybe we just change the generated rake task to check for the server webpack config file before trying to run it?

@szyablitsky does this issue break the build in production?

Yes, it break the build. I had to comment sh "cd client && npm run build:server" in assets.rake

Yeah in that case I'd consider this a bug and it needs to be fixed

@yorzi did any of your recent changes address this one?

@szyablitsky @yorzi I'm guessing this is still an issue. @rstudner want to take a crack at it? Any volunteers?

@justin808 recent changes didn't cover this one.

authors: justin808 robwise szyablitsky yorzi


text:
[fix] internal error downloading html on url resource

Coverage decreased (-0.05%) to 84.462% when pulling aac5f34a8a858dfd6558171526eb180cbfc2527d on sunny4381:fixes/opendata-html-download-on-url-resource into 1c17c6b27e9aa2dd7bfdf02fe8e5326e7cac96a9 on shirasagi:master.

Coverage decreased (-0.04%) to 84.396% when pulling 975b6f02c0eac7e2dfa1adc088927821bb6cb27c on sunny4381:fixes/opendata-html-download-on-url-resource into 49030dcf1781af034ae6a5cb98b104267ad1625c on shirasagi:master.

Coverage increased (+0.0005%) to 84.437% when pulling da1820995f50968706b4c67d891cf2480459eaf6 on sunny4381:fixes/opendata-html-download-on-url-resource into 49030dcf1781af034ae6a5cb98b104267ad1625c on shirasagi:master.

repo: shirasagi/shirasagi


text:
[Modify]search content

Coverage decreased (-0.05%) to 83.001% when pulling 4b3435f82ded8f2fcf7213ae5aa29d356b91a891 on ShinjiTanimoto:search into 5326e377d71db21ae7aa40684d94de379ad496fb on shirasagi:master.

競合が発生していたので手動で Rebase and merge を実行しました。
@a7025e55b
よって本プルリクは閉じます。

authors: ShinjiTanimoto coveralls sunny4381


text:
[modify] googlemaps : use idle event in resetting zoom level

Coverage decreased (-0.05%) to 79.512% when pulling d159b2f268a73808329a887448dece8e211d03a3 on itowtips:fix-googlemaps into 7f3c678d29cca3d6914fedfa47fe9f42ad6fc1c2 on shirasagi:master.

authors: coveralls itowtips


text:
Trips API change

We need to assign this.

repo: shivabitla/openhack-devops-team


text:
feature/autosave Add autosave to Project Layout Settings

fixed in commit 1f83197094299c799af89b9ffa8cca3915082a70


text:
config: tweak editorconfig to match NPMs indent style

Ping @jthomerson

repo: silvermine/standardization


text:
Update to base.

Apologies. Just me messing up when trying to update to the latest version.

repo: silvestreh/atom-material-ui


text:
added GEDCOM (genealogical data de-facto-standard)

Please read the instructions for creating a new list, contributing guidelines and the awesome manifest.
Mainly, it's missing contributing guidelines and add the entry to the end of the section.
The list could also use some tutorial, blog posts, etc, about the subject, not just converters and wrappers.

Closing for lack of reponse.

authors: sindresorhus todrobbins

repo: sindresorhus/awesome


text:
Uses spaces

Hello @moremay thanks for your contribution, however this function can easily be implemented outside of logrus and its resulting string given back at log function.
The API of logrus is already a bit bloated and we are reluctant to add new configuration option.

authors: dgsb moremay

repo: sirupsen/logrus


text:
[DOC] Typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!

authors: CLAassistant Rockfordal garyb

repo: slamdata/purescript-halogen


text:
Updates for purescript-aff-4.0.0

Thanks! Could you tweak the package.json to inclue -- before the psa arguments to pulp too? That'll fix the build error (unrelated to this change) that is occurring on Travis.

Done.

Thanks!

authors: coot garyb

repo: slamdata/purescript-routing


text:
Pneumonia Prediction

Hey @smaranjitghose I would like to work on this issue . Please provide some description..

Hey @smaranjitghose I would like to work on this issue. Please provide some description.

Have a look at this. We basically want to identify the presence of pneumonia using chest radiographs of patients

authors: kritikaparmar-programmer smaranjitghose


text:
Fix code formatting

This fixes the Travis build, but the appveyor build is still failing

repo: sncosmo/sncosmo


text:
Add pyenv role

LGTM!

authors: alexanderdean chuwy

repo: snowplow/ansible-playbooks


text:
Scala Common Enrich: add anonymization for IPv6 (fixes #4222)

Commits squashed.

Example in 3-enrich/config/enrichments/anon_ip.json updated

repo: snowplow/snowplow


text:
Cascade deletion to dependencies, including callbacks

Done with 40bce203b1f630bc391435ec5f5fc2d561ae22e2

repo: solderapp/solder-api


text:
Chat with me button on profile

Depends on https://github.com/solid/chat-pane/pull/45

To do: This requires the logged in user to grant the visited pod Write+Control access to their own pod. To resolve this, we should have a list of deployed chat apps that can receive a 'create' action, and see if the user has any of those as a trusted app. If they don't, the button can still offer to send the other user an invite, without creating the chat room (leaving that up to the other person)

repo: solid/solid-panes


text:
Fix license badge

Thanks you.

authors: marcelstoer sovaa

repo: sovaa/jperf


text:
Add health checks to TempJobs

:+1:

authors: davidxia rculbertson

repo: spotify/helios


text:
Change consul api call in ConsulServerList to get health info as well + new filter

this PR would benefit much from J8 lambdas, and HOFs like map for prop extractions.
The prev version had a bug: consul does not has a way to get info such as health check status by service instance id; but only by service name.
The higher level view, the aim is to have a selection of the "acceptable" service instances.
This means the non-critical status ones, perhaps further filtered (if we have an actual list after filtering).
Each service instance has 2categories of status: serf status and health check status.
The health checks is further divided into service and host (node) ones.
Each category (service, node) has multiple or no checks defined.
The node checks are indirectly obtainable from consul (there is api to get all checks running on node, and if we filter them by serviceId="", what remains, if any, are the node level checks, e.g. memory one).
My idea is to combine (aggregate) all health checks statuses by min.
From the instances, we select top instances by status.What do you think?

I think it's pretty complex.  I'd like the option to have just the service checks alone without the node checks.  Maybe it could be opt-in.

I will think tommorow of the options. Maybe the default filter will be a simpler class, and we will also offer a complex scenario such as this, which seems common sense when you think of all the cases and implications, and also offer that to be wired up if they want. I can make this complex class more configurable, create 1 or 2 more simple ones, and reuse code between them.

That would make me feel better about it.  Thanks for the continued work you are doing!

So the most simple solution is

Filtering only by service checks
All services must have checks defined

In that case, passing a query parameter named "passing" to the service/checks endpoint yields only service instances with all statuses green.
We can do this in either of 2 places:

In a filter - and fully replacing the instances list with a new one coming from a consul rpc
As a configurable behavior of ConsulServerList: meaning on a boolean, switching from getting catalog services to getting services' with checks all green (which is a different api call to consul)

Also, an ugly part is that Ecwid does not provide a parameter for this, so that would mean appending "?passing" to our serviceName parameter, and rely on the fact that ecwid appends the parameter text mode to the URL.

@spencergibb what do you think?
In fact, what we seem to need is pluggable instances list providers, not just filters.
Than we would have 3 such implementations:

the current one (extracted): gets all service instances from catalog.
the one for this PR: gets all service instances which have at least 1 associated health check, and which have all the associated checks green.
picks up the highest ranking instances (ranked by health level); where health is a min-aggregation of the checks for the service instance; so this returns the same as 2 if at least one is fully green, or returns the warn ones if no green found.

than this may be a filter:
4. picks up the highest ranking instances (ranked by node' health level); where node health is a min-aggregation of the checks for the node (those with serviceId="" on the /node/checks)

I think there is some confusion at to what parts of Ribbon do.  ServerList gets the list of servers.  IPing 'Interface that defines how we "ping" a server to check if its alive.' ServerListFilter 'allows for filtering the configured or dynamically obtained list of candidate servers with desirable characteristics.'  ServerList and ServerListFilter get called very often and I think it is the wrong place to put expensive API calls.  ServerListFilter could be suited for filtering by tags for example.  IPing is where to check the aliveness of a server.

Ok, I had a few clarifications with Consul Armon:

there is a consul api call to get all services with their checks, including service with no checks, and potentially filter them by all-green services;
that api also transparently adds the node' checks to the service checks

This means that for most scenarios, a single consul api call gets all the information needed on the client to determine the useful list.
As a consequence, we have 2 scenarios:

We want the green services. That means all services that do not have any checks below green. It will include services without a check. And will include the node checks for free, transparently.
We want the greens, but if no greens found, get the yellows. That means, give me the top service instances, but not critical ones.

For scenario 1, instead of the current strategy in ConsulServerList, we need to call another consul api, that will get the green services. A de-duplication on the client side may be necessary. That can be the default strategy.
For scenario 2, we need to call the same consul api as in scenario 1, but without the "?passing" query parameter. A heap based, or simpler client side checks aggregation + filtering strategy will be used.
As you can see, these are first-and-only consul calls. Using the filter mechanism for them is hacky. The filtering is still useful, for scenario 2, for various filtering strategies based on the statuses as already retrived from consul by ConsulServerList.
Of course, to allow this, ConsulServerList needs to contain a new field, statusList, or lowestStatusOptional = an aggregate by min of the statuses for the service/node.
How I would do it, is, driven by a configuration, have the ConsulServerList make the service-with-health call with "?passing" or not, and when not, cache the status results in the ConsulServer objects, as list or as a single status.

@spencergibb waiting for your feedback

lots to digest, I'm just getting back to work after a week+ off.

@nmarasoiu are you still interested in this?

I am not the original issue author but I am interested in this as it resolves my Issue reported https://github.com/spring-cloud/spring-cloud-consul/issues/116

Closing for lack of feedback by the author and I don't think this is the right approach.

authors: ibzx nmarasoiu spencergibb

repo: spring-cloud/spring-cloud-consul


text:
Fix wrong sample code

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7e05f99). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #974   +/-   ##
=========================================
  Coverage          ?   71.33%
  Complexity        ?      630
=========================================
  Files             ?      121
  Lines             ?     2805
  Branches          ?      294
=========================================
  Hits              ?     2001
  Misses            ?      626
  Partials          ?      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e05f99...d2972de. Read the comment docs.

You should fix this in Brave too, cause I've copied the docs ;)

Sent https://github.com/openzipkin/brave/pull/697

authors: codecov-io making marcingrzejszczak

repo: spring-cloud/spring-cloud-sleuth


text:
Add Jenkinsfile

The is some references to your repo: github.com/laurentgrangeau

I'm sorry, it was a mistake. I didn't want to create a PR here...

No problem Laurent

authors: arey laurentgrangeau


text:
Document how to explicitly set GraalVM version with Buildpacks

Currently generates a java.lang.RuntimeException: file name '/cnb/buildpacks/paketo-buildpacks_java-native-image/5.3.0/.git/logs/refs/heads/fix/remove-ca-certificates' is too long ( > 100 bytes) error as discussed with @dsyer and @scottfrederick, but will hopefully be fixed on Spring Boot side.


text:
Filtrar somente navios tipo tankers em navios em portos para acelerar a consulta.

Resolvido em 77b7366.


text:
codeship steps add name

名前つけられないのか・・

repo: srz-zumix/iutest


text:
Responsivenessv3

@SektorDV This PR is not based on master. Please solve the conflicts (ideally: squash-rebase to current master) on your side.

authors: SektorDV stared


text:
Adding 2019 publications till date

Adding publication and warmstart documentation.


text:
Compare ledger objects only on attributes shared by both

looks good

authors: MonsieurNicolas jonjove


text:
Showcase the use of ID Site via Stormpath Spring Security

any progress on this issue?

I would be interested in seeing this too.

This feature is already implemented in the id_site branch. It depends on the id_site branch of the Spring Security plugin. You will need to build and install the plugin first:mvn source:jar install -DskipITs=true
Neither branch has been reviewed so please do not consider them production ready in any way. I am just sharing cause you seem to be interested in taking a look at it.
Regards!

@jeffxor you seem to be using these branches already. Can you elaborate a little bit on your problem so I can help? Thanks

authors: jeffxor moravcik mrioan


text:
Configure plugins, backup and git sync

Backup is not necessary for now, as the whole website is in the github repo. As we move to production, we'll possibly have one repo for the backend and another one only for the contents using gitsync plugin.

TODO: look into plugin for disqus comment system.

I have installed the jscomments plugin and configured it with our disqus credentials. Now it's a matter of @fernandoted including it in the twig template when time comes.

We won't be using neither git sync nor a backup plugin. No use for that.

repo: subutai-io/readthedocs


text:
Update Contributors.md

The spacing is not right, the link wont show against your name


text:
added menu in home.html

The image is no longer visible, take a look into it.


text:
add Faiqa Shafqat to contributor list

Thank you
On Tue, Oct 23, 2018 at 5:34 PM Sudarshan Kamath notifications@github.com
wrote:

Merged #400 https://github.com/sudz123/Happy_Hacking/pull/400 into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sudz123/Happy_Hacking/pull/400#event-1920331848, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AjigVhEHc7775OiSb_Gnl5AIYzdzzrmHks5unwzTgaJpZM4X1bkO
.


text:
project8000欢迎你

总结一下，高级传销？

authors: Aaaaaaaty ApolloZhu

repo: sunqibuhuake/atom-miku


text:
Adds more tests

Current coverage is 58.41%

Merging #4 into master will increase coverage by +20.98% as of 88c0b00

@@            master      #4   diff @@
======================================
  Files            9      12     +3
  Stmts          179     214    +35
  Branches         0       0
  Methods
======================================
+ Hit             67     125    +58
  Partial          0       0
+ Missed         112      89    -23

Review entire Coverage Diff as of 88c0b00

Powered by Codecov. Updated on successful CI builds.

authors: codecov-io svenbacia

repo: svenbacia/iTunesSearchAPI


text:
Prepare for release

should we run this through the code-formatter?

authors: fehguy olensmar

repo: swagger-api/swagger-core


text:
全てのログ出力に時刻の情報を含める

ログ出力関数をまとめれば
https://github.com/syuilo/misskey/issues/1937 の実装も簡単そうですね

authors: AyaMorisawa syuilo

repo: syuilo/misskey


text:
Add Python 3.9 for CI builds

Travis builds were happy too - I'll merge.

repo: tableau/server-client-python


text:
Add taip protocol custom commands

Please fix the style issues. See Travis CI log.

Sorry, ignore my previous comment. The issue was not in your code.

I have looked through the code and I don't see any point of it. Custom command is already supported for all protocols. Why do you need to re-implement it for TAIP?

I have this problem when i try to send taip command
[image: Imágenes integradas 1]
2017-01-12 22:28 GMT-04:00 Anton Tananaev notifications@github.com:

I have looked through the code and I don't see any point of it. Custom
command is already supported for all protocols. Why do you need to
re-implement it for TAIP?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/pull/2790#issuecomment-272344745,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH_RdlvTYejhwjOEcV9dc-vlKJWYGl-4ks5rRuE7gaJpZM4LiCnE
.

--
Enrique A Villafañe
enrique@365monitoreo.com / +58 4123006796
365monitoreo.com
Av 23 de Enero cruce con Calle 1-A Barinas, Venezuela 5201
http://www.365monitoreo.com
[image: Twitter] http://www.twitter.com/villafanenrique [image: Instagram]
http://www.instagram.com/enriquevillafane [image: Skype] [image: Whatsapp]
This e-mail message may contain confidential or legally privileged
information and is intended only for the use of the intended recipient(s).
Any unauthorized disclosure, dissemination, distribution, copying or the
taking of any action in reliance on the information herein is prohibited.
E-mails are not secure and cannot be guaranteed to be error free as they
can be intercepted, amended, or contain viruses. Anyone who communicates
with us by e-mail is deemed to have accepted these risks. Company Name is
not responsible for errors or omissions in this message and denies any
responsibility for any damage arising from the use of e-mail. Any opinion
and other statement contained in this message and any attachment are solely
those of the author and do not necessarily represent those of the company.

You should reply through GitHub.

I have this problem when i try to send taip command

What are you trying to send?

Power OFF command
DYD,111111#
*Power ON *command
HFYD,111111#
2017-01-15 20:34 GMT+01:00 Anton Tananaev notifications@github.com:

What are you trying to send?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/pull/2790#issuecomment-272717848,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH_RdukmP-XAxG2-yu4VIzoZK63JJ3-oks5rSnSugaJpZM4LiCnE
.

--
Enrique A Villafañe
enrique@365monitoreo.com / +58 4123006796
365monitoreo.com
Av 23 de Enero cruce con Calle 1-A Barinas, Venezuela 5201
http://www.365monitoreo.com
[image: Twitter] http://www.twitter.com/villafanenrique [image: Instagram]
http://www.instagram.com/enriquevillafane [image: Skype] [image: Whatsapp]
This e-mail message may contain confidential or legally privileged
information and is intended only for the use of the intended recipient(s).
Any unauthorized disclosure, dissemination, distribution, copying or the
taking of any action in reliance on the information herein is prohibited.
E-mails are not secure and cannot be guaranteed to be error free as they
can be intercepted, amended, or contain viruses. Anyone who communicates
with us by e-mail is deemed to have accepted these risks. Company Name is
not responsible for errors or omissions in this message and denies any
responsibility for any damage arising from the use of e-mail. Any opinion
and other statement contained in this message and any attachment are solely
those of the author and do not necessarily represent those of the company.

I need to see HTTP request and corresponding fragment of the log file.

What protocol does your device use again? Can I see a screenshot of that as well?

I am closing this pull request because it's empty.

authors: tananaev vipien

repo: tananaev/traccar


text:
SSL Certificate for 52calls-52weeks.com

Registered api.52calls through Let's Encrypt so it can be used with API gateway
Registered www.52calls and the bare domain through Amazon Cert Service for use with CloudFront

authors: jontg sethvoltz


text:
Fix typo

I signed it!

repo: tensorflow/nmt


text:
Upstream changes for April 4th

@tensorflow-jenkins test this please.

authors: caisq vrv

repo: tensorflow/tensorflow


text:
Update word2vec_basic.py

@weidadeyaqhhya Could you please sign cla ? Thank you.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

We will not be encouraging one liner grammatical changes as this is expensive process, thank you for your interest.
CC @mihaimaruseac @chanshah

authors: gbaned weidadeyaqhhya


text:
Document framework

I couldn't find a good documentation generator, so I might just write the documentation by hand.

repo: tfukaza/harvest


text:
Kurzdokumentation von Bulut und Grimmeisen

Renamed bulut_grimmeisen.md to bulut-grimmeisen.md


text:
added exit message reminding to close haskelldo for windows users

Whoops, meant to pull this to my private fork 👅

repo: theam/haskell-do


text:
[Weapon] sometimes you pick the machine gun and an extra collider is generated (stays there)

may have the same root cause as #26
Thus maybe they can form a singular collider issue


text:
Correction of typo

Cheers 👍

authors: frankdejonge vitormattos

repo: thephpleague/flysystem-webdav


text:
Improve code example

He's on a roll.

authors: ADmad reinink

repo: thephpleague/glide


text:
fix coding style

👍

authors: appleboy thewhitetulip


text:
Don't have Foreman start Redis

Looks good.

@croaky, updated readme too.

It would be great to include an explanation in the commit message of what the issue with starting Redis via foreman was.

@frechg ran into an issue over the weekend, which I've also run into before, where starting Hound with Foreman fails because Redis server is already running.

authors: croaky gylaz salbertson

repo: thoughtbot/hound


text:
Fix group

test

repo: tibdex/auto-update


text:
Ros2 v0.8 scenario logger

[x]  Build passed
Package: scenario_logger
[x] Test  passed


text:
Not quite valid Update README.md

There were the following issues with your Pull Request

Commit: 430cde18661135c90ae1aff916aaff8b135d91ab
Commits must be in the following format: %{type} #(%{scope}): %{description}

Guidelines are available at https://github.com/tinova/one

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 430cde18661135c90ae1aff916aaff8b135d91ab
Commits must be in the following format: %{type} #(%{scope}): %{description}

Guidelines are available at https://github.com/tinova/one

This message was auto-generated by https://gitcop.com

authors: GitCop tinovaucm

repo: tinova/one


text:
Preserve quotes

Hello @jackton1! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file migration_fixer/utils.py:

Line 26:1: W293 blank line contains whitespace

repo: tj-django/django-migration-fixer


text:
Some documentation improvements

Had totally forgotten this PR.

repo: tomaka/winit


text:
Fix spec typos

@elasticLove1

repo: tonlabs/TON-SDK


text:
Added missing requirement of django-configurations

Current coverage is 96.13%

Merging #16 into develop will not affect coverage as of d7e3068

@@            develop     #16   diff @@
=======================================
  Files             9       9
  Stmts           233     233
  Branches         23      23
  Methods           0       0
=======================================
  Hit             224     224
  Partial           5       5
  Missed            4       4

Review entire Coverage Diff as of d7e3068

Uncovered Suggestions

+0.86% via form_data/forms.py#69...70
+0.86% via form_data/models.py#44...45
+0.86% via api/serializers.py#43...44

Powered by Codecov. Updated on successful CI builds.

authors: DebVortex codecov-io

repo: transcode-de/hopper


text:
Add optional instance serial console output archiving

Codecov Report

Merging #38 into master will decrease coverage by 8.29%.
The diff coverage is 5.19%.

@@            Coverage Diff            @@
##           master      #38     +/-   ##
=========================================
- Coverage    53.8%   45.51%   -8.3%
=========================================
  Files           6        6
  Lines         420      479     +59
=========================================
- Hits          226      218      -8
- Misses        171      237     +66
- Partials       23       24      +1

Impacted Files
Coverage Δ

gce.go
0% <0%> (ø)
:arrow_up:

instance_cleaner.go
58.06% <0%> (-20.85%)
:arrow_down:

cli.go
13.22% <17.39%> (+0.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30110e...627d5da. Read the comment docs.

authors: codecov-io meatballhat

repo: travis-ci/gcloud-cleanup


text:
Added an integration test for a search.

Codecov Report

Merging #2 into master will increase coverage by 6.78%.
The diff coverage is 85.18%.

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
+ Coverage     88.47%   95.26%   +6.78%
- Complexity      210      217       +7
============================================
  Files            23       23
  Lines           512      528      +16
============================================
+ Hits            453      503      +50
+ Misses           59       25      -34

Impacted Files
Coverage Δ
Complexity Δ

src/Facade/ElasticDsl.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/Dsl/AbstractDsl.php
92.3% <100%> (+2.3%)
16 <3> (+3)
:arrow_up:

src/Dsl/AbstractSearch.php
100% <100%> (+50%)
15 <5> (+2)
:arrow_up:

src/ElasticsearchDsl.php
100% <100%> (+40%)
8 <4> (+2)
:arrow_up:

src/Dsl/Search.php
42.85% <42.85%> (ø)
7 <0> (ø)
:arrow_down:

src/Model/SearchResult.php
83.33% <0%> (+83.33%)
10% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dceab78...e09f275. Read the comment docs.

authors: codecov-io triadev

repo: triadev/laravel-elasticsearch-dsl


text:
Update Create 04-custom-class.md

idk why theres 2

repo: tswow/tswow-wiki


text:
Fixes #4: constrain more package versions for HP 2013.2.0.0 tests

thanks again

authors: Mikolaj tuturto

repo: tuturto/space-privateers


text:
Improve logging for TMasterUtils.

👍

authors: kramasamy objmagic

repo: twitter/heron


text:
History list only shows 20 latest applications

Should be fixed with recent changes


text:
StickyExecution: remove the need to keep the entire history events all times

this is done as PR #277

repo: uber-go/cadence-client


text:
Non-blocking submit for Task Scheduler

Coverage decreased (-0.4%) to 67.239% when pulling b50a01c6b7d044532f560dcc9d902deba6bba40c on yycptt:non-blocking-submit into a20e0b412825dfdfe36af172e2238127fe32ff40 on uber:master.

authors: coveralls yycptt

repo: uber/cadence


text:
Handle opts.cwd correctly when using lintText

@jcorbin @Matt-Esch @malandrew @Raynos

@lucasmarshall please look at how feross/standard solves this issue (I believe they had this bug too and resolved it) and either cherry-pick that commit or manually apply those changes and submit as a new PR.
https://github.com/feross/standard/blob/master/index.js

@malandrew Looks like feross/standard doesn't have this particular issue fixed, actually. I just tested the latest from their master and it definitely doesn't work as expected.

Can you give me more details on the issue this is fixing and how to reproduce it?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant lucasmarshall malandrew

repo: uber/standard


text:
Remove metric log from query frontend

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1922/
Test PASSed.

@simon-mo , may I review this PR?

Yes please. You can merge it if it looks good to you.

@simon-mo , please merge this PR because I don't have the merge permission. To be honest, our team has already applied this. :)

authors: AmplabJenkins simon-mo withsmilo

repo: ucbrise/clipper


text:
Add License file

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   71.11%   71.11%
=======================================
  Files           5        5
  Lines          45       45
=======================================
  Hits           32       32
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2333f61...02be2ab. Read the comment docs.

authors: codecov-io ukor

repo: ukor/deeploy


text:
Release Irish coffee

Codecov Report

Merging #284 into master will decrease coverage by 0.47%.
The diff coverage is 84.82%.

@@            Coverage Diff            @@
##           master    #284      +/-   ##
=========================================
- Coverage   93.38%   92.9%   -0.48%
=========================================
  Files          58      60       +2
  Lines        2115    2212      +97
  Branches      194     199       +5
=========================================
+ Hits         1975    2055      +80
- Misses        118     133      +15
- Partials       22      24       +2

Impacted Files
Coverage Δ

datahub/company/urls.py
100% <ø> (ø)
:arrow_up:

datahub/core/exceptions.py
100% <100%> (ø)

datahub/investment/urls.py
100% <100%> (ø)
:arrow_up:

datahub/search/elasticsearch.py
98.3% <100%> (-0.14%)
:arrow_down:

datahub/investment/serializers.py
99.01% <100%> (+0.07%)
:arrow_up:

datahub/core/mixins.py
100% <100%> (ø)
:arrow_up:

datahub/core/utils.py
81.39% <60%> (-2.82%)
:arrow_down:

datahub/search/signals.py
84.61% <77.77%> (-15.39%)
:arrow_down:

datahub/documents/av_scan.py
83.05% <83.05%> (ø)

datahub/investment/views.py
93.42% <93.75%> (+0.08%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6484739...17c0601. Read the comment docs.

authors: codecov-io reupen

repo: uktrade/data-hub-leeloo


text:
Add configurable template for third party scripts

Coverage increased (+0.003%) to 93.272% when pulling 908d81e169671759db5191b122ad476d5aa3cf83 on add-sentry-template into e0b53886c0456b4a27b6094052d8d25ba36c4cef on master.

Coverage increased (+0.003%) to 93.272% when pulling 908d81e169671759db5191b122ad476d5aa3cf83 on add-sentry-template into e0b53886c0456b4a27b6094052d8d25ba36c4cef on master.

lgtm

authors: coveralls joshblum lydiagu

repo: unlimitedlabs/orchestra


text:
corrected frame id in the image and bounding box publisher

lgtm!

authors: nkhedekar tungdanganh


text:
Rename imports folder to modules

rename of imports folder to modules is done


text:
Make even better tools for analog groups

old issue

authors: mindymon neelamsaboo

repo: usdigitalresponse/neighbor-express


text:
Fixed regex transformation parsing.

LGTM

NOTM

authors: csdev stupschwartz vail130


text:
Create carosual

sdsd

repo: vasyabigi/angular-slick


text:
Add sse.cr

This stub-server.js couldn't be written in Crystal?

This is an impromptu solution...
I rewritten it.
https://github.com/y2k2mt/sse.cr/pull/5

repo: veelenga/awesome-crystal


text:
p1r4t3 fr33d0m modules

done?

repo: victorgama/Giskard


text:
Start trying to make netlify dev work WIP

@BrianMMcClain I've almost got this. There's a final redirect that doesn't seem to work. For some reason the path in auth-start.js is /.netlify/non-existent-path and I don't think it's supposed to be so it ends up with an infinite redirect loop. Maybe you can figure it out, I'll look more another time as well.

@BrianMMcClain I found this https://github.com/netlify/cli/blob/main/src/utils/proxy.js#L144
I think this is what's causing the problem. The nf_jwt cookie...

needs to be set without the domain parameter for localhost (easy fix similar to what I did with the other cookie)
needs to be set earlier I think. It's currently getting set in auth-callback instead of auth-start based on looking at this code. I think since token in the netlify cli code is not being set it never sets the URL. May have to adjust the flow a little bit for localhost...

Also a note, we should move this line https://github.com/vmware-tanzu/tanzu-dev-portal/blob/main/netlify/functions/auth-callback.js#L124 to a separate file ideally and read it in to a variable. This is pretty rough to maintain as is...

@bryanfriedman This sets the jwt token now, but still getting the redirect loop. Looking into if it needs to be set earlier like you mentioned

@BrianMMcClain Can you give this a really quick once over? I think it's good to merge. I tested in the deploy preview and workshops launch okay, nothing else should really be affected in prod, only locally, where it also seems to work. If it looks good, feel free to approve and merge.

authors: BrianMMcClain bryanfriedman

repo: vmware-tanzu/tanzu-dev-portal


text:
Fix save comment issue.

Coverage remained the same at 51.126% when pulling da85b8f3cb4023187c89065bb6d3722faaa6fa59 on wknet123:master-fix-save-comment into 454f0414311f6cd836a722e8b1b07d5ca31c27a7 on vmware:dev.

repo: vmware/harbor


text:
Merge Release 1.1.0 into master

Coverage decreased (-0.006%) to 55.309% when pulling 2b7d9fcb701271b3cb55e12a61e6b57ed0ca1fc9 on wknet123:release-1.1.0 into 13d9b05dcb837ff8db299637542ff7e6057882bf on vmware:master.


text:
Do not expose 5001 on registry container.

LGTM


text:
setParameter must be yaml for version >= 2.6

Is this still relevant? It at least needs a rebase.

Could you rebase this? there are conflicts with the current master branch which means we can't merge this.

The current data type doesn't allow an array so I'm going to close this. Please open a new PR if this is still relevant.

authors: ekohl icalvete

repo: voxpupuli/puppet-mongodb


text:
Changed handover metadata check for businessChat

Merged

authors: ReyAnthony vsct-jburet

repo: voyages-sncf-technologies/tock


text:
Fix for missing values in objects #161

I fixed this issue (using a different approach) in zod@2.0.0-beta.9 👍

authors: sylvanaar vriad

repo: vriad/zod


text:
refactor(VNode): refactor cloneVNode method

I believe this is written intentionally to remove the runtime overhead that ...obj introduces.

Yes, this is intentional.

https://jsperf.com/clone-vnode

repo: vuejs/vue-next


text:
Fixed misspelling of the track-by directive, and linked to the guide.

Thanks!


text:
Add example for Rstrip(s)

Fixed by commit 6019dc8b9fd82b1fbc2a520275e460dd8a36c65e

repo: wallclockbuilder/gstrings


text:
Add CHANGELOG to Helm chart

I am not sure if this made the release, nor if it should be mentioned, also this is for chat version 0.5.2
https://github.com/weaveworks/flux/pull/1543

@sfrique this will be added when we write up the release notes for 0.5.2.

I mentioned, because chart release and helm-op release are different things. So i wasn't sure how you guys would like to add this.

authors: hiddeco sfrique

repo: weaveworks/flux


text:
Housekeeping: merge release/1.12.x back into master

You will need to use your administrator rights to merge this PR.

It seems I have them ¯_(ツ)_/¯


text:
Add more info to the migration guide

This is good enough to me. We can accept more tweaks through separate PRs as people spot something. 👍

authors: bebraw sokra


text:
Link to paper source

Current coverage is 87.04%

Merging #7 into master will not affect coverage as of b50be20

@@            master      #7   diff @@
======================================
  Files           24      24
  Stmts          880     880
  Branches         0       0
  Methods          0       0
======================================
  Hit            766     766
  Partial          0       0
  Missed         114     114

Review entire Coverage Diff as of b50be20

Powered by Codecov. Updated on successful CI builds.

Thanks

authors: codecov-io jiahao weijianzhang


text:
Get child page hitting apiv3

すみません。
誤ってresolve conversation を押してしまいました。
swagger のタスクは別で存在します。(GW-3143)
ダミーデータはタスクとの整合性を合わせるために削除しました。GW-3316で解消します。

修正します。

REST URI について
duplicate を変更し、
subordinated-list に変更しました。

@yuki-takei
そもそも、エンドポイントの名前について非常に誤解していました。
絶対に / duplicate 縛りで作成しなければいけない。
と勘違いしていました。
なので今回のエンドポイントの名前は、REST api にしたがって
subordinated-list としています。
すると、今回のストーリーのスコープでは
そもそも　duplicate の apiv3 化が必要ではない？と感じてきています。
この辺りどうでしょうか？

if のところ修正しました。
エラーハンドリング対応しました。

repo: weseek/growi


text:
Sync'ed the Swarm version for Gradle artifacts

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

All other artifacts on this repo are using 2017.7.0-SNAPSHOT. This PR changes two instances where a different version was being used.

add to whitelist

authors: jpkrohling kenfinnigan wildfly-swarm-ci

repo: wildfly-swarm/wildfly-swarm-examples


text:
Probably should be trying to use HTTP/1.0 to avoid spotify potentially chunking the response

Fixed

repo: witnessmenow/spotify-api-arduino


text:
Refs/heads/wodexiaobeizi patch 1

Add wodexiaobeizi's file

Add wodexiaobeizi's file

repo: wodexiaobeizi/github-slideshow


text:
Implemented Debs features

@bhagyaj, It seems above PR contains Siddhi Debugger features as well. Can you please send this PR which contains only debs related changes..

Hi,
Sorry for the inconvenience. I removed debugger features.
On Thu, Aug 25, 2016 at 2:01 PM, Mohanadarshan Vivekanandalingam <
notifications@github.com> wrote:

@bhagyaj https://github.com/bhagyaj, It seems above PR contains Siddhi
Debugger features as well. Can you please send this PR which contains only
debs related changes..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wso2/siddhi/pull/185#issuecomment-242316185, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ0ZLmWgbEW6zbbC2cL4vtpyijBZO3GXks5qjVLkgaJpZM4JsM2_
.

--
Regards,
Rupasinghe M.A.B.J.
Software Engineer Intern
Wso2 Inc
Sri Lanka

authors: bhagyaj mohanvive


text:
Repurpose 00-documentation-examples as a tutorial learning for AskScript

Following our conversation today, we still want to have these files as a part of our test suite.

repo: xFAANG/askql


text:
updated some paths that are bricking the importer

https://github.com/xFFFFF/Gekko-BacktestTool/issues/45

repo: xFFFFF/Gekko-BacktestTool


text:
delete unused java code

fix #8

repo: xfyun/AthenaServing


text:
视频播放报错av_read_frame error: unknown

Native模式下华为，小米，vivo7.0系统以上视频播放一会就回报错


text:
Use (array) cast instead of !is_array check for both readability and performance

Hmm... HHVM failed. Any idea why?

If an object is converted to an array, the result is an array whose elements are the object's properties. The keys are the member variable names, with a few notable exceptions: integer properties are unaccessible; private variables have the class name prepended to the variable name; protected variables have a '*' prepended to the variable name. These prepended values have null bytes on either side. This can result in some unexpected behaviour:
https://github.com/yiisoft/yii2/blob/use_array_cast_instead_of_check/framework/helpers/BaseHtml.php#L1075

@Faryshta thanks :) I thought it failed on HHVM only but it doesn't seem to be the case. Will check it tomorrow.

Blindly casting to array is not a good idea in most cases.

I think we should not make any of these changes.

Some of this changes are cool, for example when you know that the element to be casted will be an string or an integer. The error here comes from casting objects to arrays.

:+1: to changes where it do not break anything

I'll re-check which cases could be applied and which could not.

authors: Faryshta cebe creocoder samdark


text:
Updated translation-status.md [skip ci]

The statuses are not quite right. We will update them when ready. Thanks.


text:
Docs/code highlighting and comments

@all-contributors please add @ivc369 for doc

repo: ykfe/egg-react-ssr


text:
Update doctrine notification handling

It seems that I have a problem with Travis, so I'll merge it anyway.

authors: mcrinquand yann-eugone

repo: yokai-php/messenger-bundle


text:
Support TypeScript worker files.

Tested and works.

I've merged another PR that adds this functionality. Pending release.

authors: joonhocho timneutkens

repo: zeit/next-plugins


text:
docs: better installation instructions.

Thanks for your contribution!
Could you follow the existing style of the README.md, and also include installation options for the browser? I'd be glad to merge it thten

authors: ahurtado-ias zenoamaro

repo: zenoamaro/react-quill


text:
ZEN-16125 - Send return values of OnMessage over the websocket

Retest this

PR has aged out. Closing.

authors: csmouse kindkid tgjonestx

repo: zenoss/zenoss-zapp


text:
Doc tar

Can we get a build where doc build fails and see how errors are being reported?

Can we get a build where doc build fails and see how errors are being reported?

will do.

authors: galak nashif

repo: zephyrproject-rtos/zephyr-testing


text:
More sql functions

Codecov Report

Merging #53 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines         1100      1163   +63
=========================================
+ Hits          1100      1163   +63

Impacted Files
Coverage Δ

src/zero_one/geni/core.clj
100.00% <ø> (ø)

src/zero_one/geni/sql.clj
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348da12...a7f06db. Read the comment docs.

authors: anthony-khong codecov-commenter

repo: zero-one-group/geni


text:
return a 404 for missing files

Nice! Thank you!

authors: andreimatei zorkian

repo: zorkian/distributor


text:
[refix 3954]

@zsyzsyhao @Alvin-Lau
补全case后，发现commit id: 230d43247ad871f05c98747f1db0ff97d1a2e08e 代码存在问题。SwitchL3NetworkCase fail :   Illegal base64 character 2c.
鉴于commit 仅影响ha1，避免修改代码后引入新的问题，故暂时搁置。

repo: zstackio/zstack


text:
fix i18n typo

thanks.