text:
use rfc7396 json merge patch in crdclient

Tested on my own GKE 1.17 cluster, fixes issue 1 described in #28799
The merge patch is more robust, it can be ambiguous whether an add or replace op (see rfc6902) is appropriate when we really want "create if not there, otherwise replace.
Not to be confused with strategic merge patch (k8s patch types)

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test gencheck_istio

lint_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test gencheck_istio

lint_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test lint_istio

unit-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test gencheck_istio

lint_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test lint_istio

unit-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test unit-tests_istio

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test gencheck_istio

lint_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test lint_istio

unit-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test unit-tests_istio

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test gencheck_istio

lint_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

unit-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

unit-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test unit-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

unit-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test unit-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

unit-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test unit-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

unit-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test unit-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

unit-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

unit-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

unit-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

unit-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test analyze-tests_istio

gencheck_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test gencheck_istio

lint_istio
13ca8b9368672ea795a2dca37c48439fb9c71169
link
/test lint_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

unit-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

release-test_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test release-test_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-ipv6-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

lint_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test lint_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test analyze-tests_istio

integ-security-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

gencheck_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test analyze-tests_istio

integ-security-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-security-k8s-tests_istio

lint_istio
3cabdff6581dca4b6d2127d1702ed11c5e500157
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
33a1decc3f72dcd64050bb1506f6def0e4d56021
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

integ-ipv6-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test analyze-tests_istio

integ-security-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-security-k8s-tests_istio

lint_istio
3cabdff6581dca4b6d2127d1702ed11c5e500157
link
/test lint_istio

gencheck_istio
3cabdff6581dca4b6d2127d1702ed11c5e500157
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test unit-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

integ-helm-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-helm-tests_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-security-k8s-tests_istio

lint_istio
3cabdff6581dca4b6d2127d1702ed11c5e500157
link
/test lint_istio

gencheck_istio
61bf32b1c24983906e9c02fed70b63ccd5086a2d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
569aa8db9aedecae199d89139ebc91462d4c292c
link
/test integ-pilot-k8s-tests_istio

release-test_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-security-k8s-tests_istio

gencheck_istio
ca3c395f55474142892abacf34b270771e99a6cf
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4ad252a87281f1e1cae3e3d051a9d12e3f5e7948
link
/test integ-security-k8s-tests_istio

gencheck_istio
ca3c395f55474142892abacf34b270771e99a6cf
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
ca3c395f55474142892abacf34b270771e99a6cf
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can we seek for another solution to the race https://github.com/istio/istio/issues/28799#issuecomment-741554087? Json merge patch is rarely used in k8s, generally more options mean more confusions.

Would strategic merge patch be better? This is a pretty simple use-case for setting annotations.

Strategic merge SGTM but does it work for CRDs?
On Thu, Dec 10, 2020 at 9:07 AM Steven Landow notifications@github.com
wrote:

Would strategic merge patch be better? This is a pretty simple use-case
for setting annotations.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/29534#issuecomment-742657693, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJ3V7PTSUD4XMM3HWLSUD53XANCNFSM4UUBS47Q
.

Right... https://github.com/kubernetes/kubernetes/issues/58414

JSONPatch and JSON merge patch should work today, I think?

Yes, they do. 👍

@hzxuzhonghu do you have specific concerns about the merge patch?
If the only concern is future devs using the wrong patch type, I could try to hide the option a bit more in the crdclient API or add comments to make it clear that regular JSONPatch is recommended if Patch ends up being used at all elsewhere.

Is #29564 an alternative? I will have a look

@stevenctl Suggest making use of retry mechanism to solve the conflict err.  This is a way k8s use commonly. BTW there are many kinds of failures other than conflict, backoff retry could solve all.

That PR solves other issues.. the use of Patch here is pretty intentional but I can try some load-testing using regular Updates and see how it goes

@stevenctl: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

authors: howardjohn hzxuzhonghu istio-testing stevenctl


text:
Add IST0139 analysis for install workflow

FilterRenderedComponentManifest method allows to filter particular k8s object from rendered istio component manifest
Signed-off-by: Akshit Grover akshit.grover2016@gmail.com
Fixes #33537
This is WIP PR, First part of getting the correct data to analyse using IST0139 ie. MutatingWebhookConfiguration is implemented.
The second part of analysing the same using webhook analyser is yet to be implemented.
[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ X ] User Experience
[ ] Developer Infrastructure
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @akshitgrover. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Can you take a look at the implementation of the method to get MutatingWebhookConfiguration?
I'll call the webhook analyser after FilterRenderedComponentManifest is called in the Reconcile method of HelmReconciler.

/cc @howardjohn

/assign @howardjohn

Sorry! I might have bombarded your inbox with emails, I was actually trying the commands by prow bot as suggested by the istio-testing bot as well. It didn't work so deleted those comments

@howardjohn
Apparently, Previous approach of getting the webhookconfig from the manifestMap was a redundant effort as the same thing was being done in the ApplyManifest method on per k8sObject basis. So, The cleaner way was to use the same thing instead of adding a new method for the same.
Now, The only thing left is to use the same for analysis, For which I have added the implementation and injected the same in the ApplyManifest method.
The only which is left is to skip this analysis if --skip-confirmation is set to true, Not sure if we need this. If yes, It'd be trickier to implement as the args are not propagated to the reconciler method.
PTAL at the implementation

The only which is left is to skip this analysis if --skip-confirmation is set to true, Not sure if we need this. If yes, It'd be trickier to implement as the args are not propagated to the reconciler method.

I think we still want to warn, possibly even failing unless --force is set?

The only which is left is to skip this analysis if --skip-confirmation is set to true, Not sure if we need this. If yes, It'd be trickier to implement as the args are not propagated to the reconciler method.

I think we still want to warn, possibly even failing unless --force is set?

Can you guide me a bit on this
I am not sure I understand the flow here completely

/ok-to-test

@akshitgrover: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test release-notes_istio

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Tests are failing because of https://github.com/istio/istio/pull/33644/files#diff-525ae81754807c29a4ae13370ad8e74c7948b57128c60967939feeeea4c8184fR581 statement
We'll have to filter and just the valid resources, Will raise a PR with the fix

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test gencheck_istio

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test lint_istio

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-pilot-multicluster-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
c22bb26c63c2375aceed781a8a476774d3eea58d
link
/test integ-security-k8s-tests_istio

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn
I'll raise a PR with the fix to pass test runs
What about the release-notes tests are there going to be any release notes for this if not can we add release-notes-none label so that particular test can pass?

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test release-notes_istio

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test gencheck_istio

lint_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test lint_istio

integ-ipv6-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-distroless-k8s-tests_istio

integ-cni-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
2b8266c95281822deaab15a4bd05290dab2c8417
link
/test integ-security-k8s-tests_istio

release-notes_istio
5a673b37e553775738b95ef1c06158085821a428
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akshitgrover: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-cni-k8s-tests_istio
8ac87f3cce5cb9e85ac57d4a3b22343e3e0a2ec0
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-cni-k8s-tests_istio

@shamsher31
I've added the release notes
Thank you

source: gharchive/pull-request

authors: akshitgrover howardjohn istio-testing

repo: istio/istio

license_type: permissive

license_source: github-api


text:
Fix split-horizon LB for MCS

Previous logic was broken for the case when only some clusters export service endpoints (via MCS ServiceExport). In this case, it's possible that we can accidentally hit unexported endpoints that share the same network as exported endpoints.
Refactoring the load balancing logic to prefer gateways with the same cluster as the endpoint. Going forward, we should recommend installing east-west gateway in all clusters to support the MCS use case.
Fixes #33526
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

/test benchmark_istio

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dbb531946ba1d9824cb7f24a7d63f687bf393b8f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I would like to review this closely but may not find time today, can you bug me if I don't get to it and am blocking?

@howardjohn @stevenctl I think I've addressed all of your comments. I ended up fishing the cluster/network through by passing the original IstioEndpoint to the endpoint builder. PTAL

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a7059fc7dd111c167cc48374e23bece7593de1f0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ecb93a8ea8c2ffe5ccf0a94f9b321ec4f88920c9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7406a4bb234ed3a77336fb306ee7e34c3734d309
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7406a4bb234ed3a77336fb306ee7e34c3734d309
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
7406a4bb234ed3a77336fb306ee7e34c3734d309
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test benchmark_istio

At a glance this looks good, but I am curious how kb/msg is going down so much. I haven't reviewed the latest changes, are we dropping some metadata?
name                                          old time/op        new time/op        delta
EndpointGeneration/1/100-8                          1.78ms ± 4%        1.45ms ± 2%  -18.52%  (p=0.008 n=5+5)
EndpointGeneration/10/10-8                          1.22ms ± 2%        1.01ms ± 1%  -17.24%  (p=0.008 n=5+5)
EndpointGeneration/100/10-8                         12.1ms ± 1%        10.1ms ± 1%  -16.22%  (p=0.008 n=5+5)
EndpointGeneration/1000/1-8                         12.5ms ± 2%        10.3ms ± 2%  -17.59%  (p=0.008 n=5+5)
name                                          old alloc/op       new alloc/op       delta
EndpointGeneration/1/100-8                           444kB ± 0%         374kB ± 0%  -15.87%  (p=0.008 n=5+5)
EndpointGeneration/10/10-8                           272kB ± 0%         245kB ± 0%   -9.94%  (p=0.008 n=5+5)
EndpointGeneration/100/10-8                         2.58MB ± 0%        2.33MB ± 0%   -9.47%  (p=0.016 n=4+5)
EndpointGeneration/1000/1-8                         2.57MB ± 0%        2.34MB ± 0%   -9.15%  (p=0.008 n=5+5)
name                                          old allocs/op      new allocs/op      delta
EndpointGeneration/1/100-8                           8.41k ± 0%         6.91k ± 0%  -17.84%  (p=0.008 n=5+5)
EndpointGeneration/10/10-8                           5.08k ± 0%         4.34k ± 0%  -14.59%  (p=0.008 n=5+5)
EndpointGeneration/100/10-8                          46.8k ± 0%         39.8k ± 0%  -15.07%  (p=0.016 n=4+5)
EndpointGeneration/1000/1-8                          46.3k ± 0%         39.3k ± 0%  -15.22%  (p=0.008 n=5+5)
name                                          old kb/msg         new kb/msg         delta
EndpointGeneration/1/100-8                            11.5 ± 0%           9.1 ± 0%  -20.89%  (p=0.008 n=5+5)
EndpointGeneration/10/10-8                            8.53 ± 0%          6.13 ± 0%  -28.14%  (p=0.008 n=5+5)
EndpointGeneration/100/10-8                           83.2 ± 0%          59.2 ± 0%  -28.84%  (p=0.008 n=5+5)
EndpointGeneration/1000/1-8                           83.6 ± 0%          59.6 ± 0%  -28.71%  (p=0.008 n=5+5)
name                                          old resources/msg  new resources/msg  delta
EndpointGeneration/1/100-8                             100 ± 0%           100 ± 0%     ~     (all equal)
EndpointGeneration/10/10-8                            10.0 ± 0%          10.0 ± 0%     ~     (all equal)
EndpointGeneration/100/10-8                           10.0 ± 0%          10.0 ± 0%     ~     (all equal)
EndpointGeneration/1000/1-8                           1.00 ± 0%          1.00 ± 0%     ~     (all equal)

Yeah that's right

authors: howardjohn istio-testing nmittler stevenctl


text:
Benchmark and optimize PushRequest

While this is a seemingly innocent code path, it shows up in pprof's a lot - like 5-10%+ of CPU and allocs.
name           old time/op    new time/op    delta
PushRequest-6    6.15ms ± 1%    5.42ms ± 8%  -11.87%  (p=0.002 n=6+6)

name           old alloc/op   new alloc/op   delta
PushRequest-6    4.24MB ± 0%    3.48MB ± 0%  -17.94%  (p=0.002 n=6+6)

name           old allocs/op  new allocs/op  delta
PushRequest-6     85.1k ± 0%     60.1k ± 0%  -29.39%  (p=0.000 n=5+6)

This will get faster with the fixes in https://github.com/census-instrumentation/opencensus-go/issues/1265 as well

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
193f32f274c9e24786c6534075f9f2dc06005430
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: howardjohn istio-testing


text:
Revert driver to old version

The current one does not work in GKE, I tried to fix but seems there are many incompatible issues. Revert it and work on a fix in the meantime.

@incfly , this will unblock you from the development work.

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de864958dbcb000761fe3d936f50f94f74c08b20
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de864958dbcb000761fe3d936f50f94f74c08b20
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
de864958dbcb000761fe3d936f50f94f74c08b20
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de864958dbcb000761fe3d936f50f94f74c08b20
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
de864958dbcb000761fe3d936f50f94f74c08b20
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
de864958dbcb000761fe3d936f50f94f74c08b20
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Saurabh, here are the ones I found:

the driver needs to be initialized with https://github.com/istio/istio/blob/master/security/cmd/flexvolume/driver/driver.go#L66

the mgmt.sock and workload.sock paths in the driver changed, but the node agent code does not

I tried to fix 2) but looks like /var/run path has some permission issues, this part I was not sure.

@wattli let me take a look at 1 and 2.

Thanks

authors: istio-testing saumoh wattli


text:
ServiceEntry deletion - trigger endpoint shard update when some endpoints are remaining

…ints are remaining
Please provide a description of this PR:

Hi @ivpr. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixes #43853

/ok-to-test

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
14033648f4e4809bc5428c6cc4cfbdce3c25cc42
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
74c4c159905a277535c8d5079f427cbcf501b3db
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8b6c539975fa3f0ac8bb79923b59bbb65a3b2e44
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu & @ramaraochavali I've added the test cases for this
The test case scenario was already present but we were not doing any assertions on edscache events. I've added the assertions for eds cache in all places and verified the tests to running
Below is the assertion failing without the code fix
https://github.com/istio/istio/pull/43852/files#diff-db93d0d3aef31b582e2969e9b40dcdce6b5f7d23172876ffec7f2c6285c81519R414
Please review

Can you fix lint?

@ivpr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8b6c539975fa3f0ac8bb79923b59bbb65a3b2e44
link
true
/test lint

gencheck_istio
8b6c539975fa3f0ac8bb79923b59bbb65a3b2e44
link
true
/test gencheck

release-notes_istio
a344358c64e78bfbf79ffd91a99916ec15733359
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6450ea871f1285e65cb3710508dfbf00486dd3f6
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali Fixed the lint errors. Had to amend and force push the commits to fix the author email for CLA. Please check

LGTM. Please add release notes also

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
e555a49540cd79b1c3fe23867743855ff76236fc
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc

authors: hzxuzhonghu istio-testing ivpr ramaraochavali