text:
Usage of Worker/Processor and protoc-bridge/protoc-jar in proto rules

Hi,
what is the reason/rationale for proto rules being implemented with Worker/Processor and protoc-bridge/protoc-jar
From my understanding current implementation has few "drawbacks"

@com_google_protobuf//:protoc is ignored. It's used by proto_library but scalapb_proto_library uses one of the https://github.com/os72/protoc-jar/tree/master/bin
a. it requires extra work/care to keep both protoc at same version
it requires extra hops to generate scala code
a. bazel invokes scala via Worker/Processor
b. protoc_bridge is invoked which
i. extracts own protoc to temp directory https://github.com/os72/protoc-jar/blob/master/src/main/java/com/github/os72/protocjar/Protoc.java#L197
ii. starts new protoc process https://github.com/os72/protoc-jar/blob/master/src/main/java/com/github/os72/protocjar/Protoc.java#L125
c. protoc calls scala plugin to generate code
to use custom plugin we had to copy Worker and Processor to supply it

As I know there is an aim to use persistent worker. But I guess because new process is spawned benefits of persistent worker cannot be used (my knowledge is limited on this topic).
I have a POC https://github.com/simuons/rules_scala/blob/scala-proto-gen/scala_proto/scala_proto.bzl#L595 which

uses @com_google_protobuf//:protoc from bazel (the same as proto_library uses)
calls protoc directly with supplied plugin and is based on descriptor sets to avoid --proto_path construction (mentioned here https://blog.bazel.build/2017/02/27/protocol-buffers.html # Descriptor Sets)
needs less code to supply own plugin https://github.com/simuons/rules_scala/blob/scala-proto-gen/src/scala/scripts/ScalaPBPlugin.scala to a rule https://github.com/simuons/rules_scala/blob/scala-proto-gen/test/proto/BUILD#L124

What do you think? If all I wrote makes any sense I'd like to proceed with that.

This all makes sense to me.
@azymnis contributed the original version and I think he just wanted to get unblocked. Ideally, I'd love to have only 1 version of the rules, and not break previous builds. So, if we could improve without breakage, that would be great, e.g. not breaking any of the current tests.
Also note the issue here if you are improving matters: #548 -- I think using aspects to transform the proto dependency graph into a scala_proto dependency graph would make things work more similar to the java proto rules.

One note: the persistent worker is still used for the scala/jvm code, and without that worker support you have to spin up a new JVM each time you build a target. This will likely be a considerable slowdown.
Have you benchmarked your version? I wonder if we can keep the worker support, but use the same protoc as bazel and sidestep keeping anything in sync.

@simuons there really wasn't a reason. I was just hacking things together till they worked. If your version works with the built in @com_google_protobuf//:protoc we should totally go with that instead.
@johnynek would the current set of tests passing be enough to make sure that we don't break existing users? We have moved away from protobuf in scala at KH so our code would not be a good candidate for beta testing. Maybe we can try looking for any existing users?

We can try a build at Stripe. We have mostly thrift, but moving towards scala.

@johnynek @azymnis thanks for your prompt responses.
I totally agree on having one set of rules. However I'm not sure how to handle https://github.com/bazelbuild/rules_scala/blob/master/scala_proto/scala_proto.bzl#L415 (as it is tightly coupled to scalapb). Anyway I'll try to converge both rules to single one.
I intentionally didn't mention aspects here. It's definitely in my plans but I see this change in this issue as a smaller increment towards end goal.
I'll dig more into workers and do some benchmarks.

I’ll just add that Simonas works at Wix and we’ll of course try it out on
our internal code base first
On Fri, 15 Feb 2019 at 9:45 Simonas Pinevičius notifications@github.com
wrote:

@johnynek https://github.com/johnynek @azymnis
https://github.com/azymnis thanks for your prompt responses.
I totally agree on having one set of rules. However I'm not sure how to
handle
https://github.com/bazelbuild/rules_scala/blob/master/scala_proto/scala_proto.bzl#L415
(as it is tightly coupled to scalapb). Anyway I'll try to converge both
rules to single one.
I intentionally didn't mention aspects here. It's definitely in my plans
but I see this change in this issue as a smaller increment towards end goal.
I'll dig more into workers and do some benchmarks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/issues/690#issuecomment-463940289,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF2Fy1swfyMk8fXte1DoZE_aeWhZHks5vNmWjgaJpZM4a59n4
.

BTW: you can look at the scrooge example:
https://github.com/bazelbuild/rules_scala/blob/18889f641ed62dd09aeb71d1505f3834ccc33be3/twitter_scrooge/twitter_scrooge.bzl#L340
for seeing one using aspects. We have been using that rule at Stripe pretty heavily. We have a tool that parses the thrift and generates fine grained BUILD files so you can depend on individual thrifts without any pain on the user.
We have a proto parser as well, I guess we could make a tool that generates build files for protos too.

@simuons I think you fixed this?

This issue is not relevant anymore.

authors: azymnis ianoc ittaiz johnynek simuons


text:
Fix debian requirement of --scan

changes the variable on line 280 to match the variable that is recursed through the directory (previously was stuck as /opt since that is what $scan was, $scandir is the variable it was expecting.
fixes #10

This change is

Thanks for catching this! It works on Arch as well.

source: gharchive/pull-request

authors: ObserverOfTime piks

license: MIT

license_type: permissive

license_source: github-api


text:
Feature Request: Style/ConfusingAndOr

While this works, it's not the easiest thing to understand:
def get_wheel_brand(car)
  # Assume car.wheels_ does a database lookup, and raises if it's not there.
  return car.wheels && car.wheels_.name || 'No wheels!'
end

In reality, this picks the first truthy thing.
It'd be cleaner to rewrite as something with brackets (or as an if statement)
def get_wheel_brand(car)
  (car.wheels && car.wheels_.name) || 'No wheels!'
end

Also equivalent:
def get_wheel_brand(car)
  if car.wheels
    name = car.wheels_.name
    return name if name
  end
  'No wheels!'
end

There's probably an analogue for a || b && c, but I haven't seen someone write that yet.

I like the idea of this. Even you've memorised Ruby's operator precedences, it reduces the cognitive load for reading it.
This secure coding guide from CERT makes a similar recommendation for C: https://www.securecoding.cert.org/confluence/display/c/EXP00-C.+Use+parentheses+for+precedence+of+operation

That page is a goldmine of weird bugs.

Treat relational and equality operators as if they were nonassociative

if a == b == c # Misleading; likely bug

https://www.securecoding.cert.org/confluence/display/c/EXP13-C.+Treat+relational+and+equality+operators+as+if+they+were+nonassociative

This issue is not really about "and" and "or". It's about expressions which require detailed knowledge of operator precedence to understand.
I once wrote some code for unparser which parenthesized expressions as necessary to make the meaning clear, given that the reader might only have a very basic knowledge of operator precedence. That same code could be used for this.

source: gharchive/issue

authors: alexdowad andyw8 shalecraig

repo: bbatsov/rubocop


text:
Fix false positive for Style/EmptyLineAfterGuardClause

This PR fixes a false positive for Style/EmptyLineAfterGuardClause when guard clause is before rescue or ensure.
Reproduction code
def foo
  begin
    return another_object if something_different?
  rescue SomeException
    bar
  end
end

and
def foo
  begin
    return another_object if something_different?
  ensure
    bar
  end
end

Expected behavior
No offenses.
Actual behavior and Steps to reproduce the problem
% rubocop /tmp/example.rb --only Style/EmptyLineAfterGuardClause
Inspecting 1 file
C

Offenses:

/tmp/example.rb:3:5: C: Style/EmptyLineAfterGuardClause: Add empty line after guard clause.
    return another_object if something_different?
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

RuboCop version
% rubocop -V
0.53.0 (using Parser 2.5.0.4, running on ruby 2.5.0 x86_64-darwin17)

This PR fixes the above false positive.
Also, the condition node.parent.single_line? seems to have no effect on behavior, so this PR removes it.
cc @unkmas

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

👍

authors: bbatsov koic


text:
Semi-automated title test

The first example of a "semi-automated test" which needs some user-supplied configuration before it can be executed.
I decided to express this configuration as a JavaScript function, to keep it as general as possible. This may be over-engineered. What do you think?
Can you think of examples where the text of the first <h1> tag is not included in the <title>?

I can't think of any things I worked on that did not use the  in the page title ... but that doesn't mean there isn't one out there. And having specifically the  be part of the page title is not the guideline. Having the tester provide an expected formula will help identify any pages that do not meet that expectation.
I wonder if the test should also verify that the formula contains something that is part of the page content. Or is that overkill?

authors: EmmaJP joshski


text:
library(tidyverse) : there is no package called ‘tidyverse’

Version info

bcbio version (bcbio_nextgen.py --version): 1.2.7
OS name and version (lsb_release -ds): Ubuntu 18.04.4 LTS

To Reproduce
Exact bcbio command you have used:
bcbio_nextgen.py ../config/K0008-K0011_RNA_updated.yaml -n 96

Your sample configuration file:
details:
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0006-BF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/S1N7CLEQE-23022021_S10_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/S1N7CLEQE-23022021_S10_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0006-BF1
    phenotype: tumor
    validate_batch: group0
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0011-BF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/S6TRHC9B1-23022021_S16_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/S6TRHC9B1-23022021_S16_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0011-BF1
    phenotype: tumor
    validate_batch: group4
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0011-AF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SK6762KAZ-23022021_S15_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SK6762KAZ-23022021_S15_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0011-AF1
    phenotype: tumor
    validate_batch: group4
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0009-AF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SM30WC7P9-23022021_S13_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SM30WC7P9-23022021_S13_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0009-AF1
    phenotype: tumor
    validate_batch: group2
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0008-AF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SM8EGVGWJ-23022021_S12_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SM8EGVGWJ-23022021_S12_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0008-AF1
    phenotype: tumor
    validate_batch: group1
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0006-AF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SQS2JA66K-23022021_S9_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SQS2JA66K-23022021_S9_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0006-AF1
    phenotype: tumor
    validate_batch: group0
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0008-AF1-LMDRNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SSRGQRVBA-23022021_S11_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SSRGQRVBA-23022021_S11_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0008-AF1-LMD
    phenotype: tumor
    validate_batch: group1
- algorithm:
    aligner: star
    fusion_caller:
    - pizzly
    - oncofuse
    - arriba
    hlacaller: optitype
    strandedness: firststrand
    variantcaller:
    - gatk-haplotype
  analysis: RNA-seq
  description: K0010-AF1-RNAseq
  files:
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SSRIVPS0A-23022021_S14_R1_001.fastq.gz
  - /apps2/data/K008-K0011_Target_Discovery/input/RNA/SSRIVPS0A-23022021_S14_R2_001.fastq.gz
  genome_build: hg38
  metadata:
    batch: K0010-AF1
    phenotype: tumor
    validate_batch: group3
fc_name: K0008-K0011_RNA
upload:
  dir: ../final

Observed behavior
Error message or bcbio output:
Traceback (most recent call last):
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 26, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 106, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command '/apps1/local/share/bcbio/anaconda/envs/r36/bin/Rscript --vanilla -e library(tidyverse);salmon_files = list.files("/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/salmon", pattern="quant.sf", recursive=TRUE, full.names=TRUE);tx2gene = readr::read_csv("/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/inputs/transcriptome/tx2gene.csv", col_names=c("transcript", "gene")); samples = basename(dirname(salmon_files));names(salmon_files) = samples;txi = tximport::tximport(salmon_files, type="salmon", tx2gene=tx2gene, countsFromAbundance="lengthScaledTPM", dropInfReps=TRUE);readr::write_csv(round(txi$counts) %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/bcbiotx/tmpyh6_tqvc/tximport-counts.csv");readr::write_csv(txi$abundance %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/bcbiotx/tmp9mjt2ip1/tximport-tpm.csv");
Error in library(tidyverse) : there is no package called ‘tidyverse’
Execution halted
' returned non-zero exit status 1.
Traceback (most recent call last):
  File "/apps1/local/bin/bcbio_nextgen.py", line 245, in <module>
    main(**kwargs)
  File "/apps1/local/bin/bcbio_nextgen.py", line 46, in main
    run_main(**kwargs)
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 50, in run_main
    fc_dir, run_info_yaml)
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 91, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 264, in rnaseqpipeline
    samples = rnaseq.combine_files(samples)
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/rnaseq.py", line 489, in combine_files
    tximport = load_tximport(data)
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/rnaseq.py", line 556, in load_tximport
    do.run([rcmd, "--vanilla", "-e", render_string], f"Loading tximport.")
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 26, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/apps1/local/share/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 106, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command '/apps1/local/share/bcbio/anaconda/envs/r36/bin/Rscript --vanilla -e library(tidyverse);salmon_files = list.files("/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/salmon", pattern="quant.sf", recursive=TRUE, full.names=TRUE);tx2gene = readr::read_csv("/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/inputs/transcriptome/tx2gene.csv", col_names=c("transcript", "gene")); samples = basename(dirname(salmon_files));names(salmon_files) = samples;txi = tximport::tximport(salmon_files, type="salmon", tx2gene=tx2gene, countsFromAbundance="lengthScaledTPM", dropInfReps=TRUE);readr::write_csv(round(txi$counts) %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/bcbiotx/tmpyh6_tqvc/tximport-counts.csv");readr::write_csv(txi$abundance %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/apps2/data/K008-K0011_Target_Discovery/K0008-K0011_RNA_updated/work/bcbiotx/tmp9mjt2ip1/tximport-tpm.csv");
Error in library(tidyverse) : there is no package called ‘tidyverse’
Execution halted
' returned non-zero exit status 1.

Expected behavior
A clear and concise description of what you expected to happen.
Log files
Please attach (10MB max): bcbio-nextgen.log, bcbio-nextgen-commands.log, and bcbio-nextgen-debug.log.
bcbio-nextgen.log
bcbio-nextgen-debug.log
bcbio-nextgen-commands.log
Additional context
Add any other context about the problem here.
bulkRNA-seq pipeline failed with error in 'library(tidyverse)'. I tried to install tidyverse with conda forge or install.packages("tidyverse"). It seemed to install tidyverse successfully (See below):
trying URL 'https://ftp.osuosl.org/pub/cran/src/contrib/tidyverse_1.3.0.tar.gz'
Content type 'application/x-gzip' length 712837 bytes (696 KB)
==================================================
downloaded 696 KB

* installing *source* package ‘tidyverse’ ...
** package ‘tidyverse’ successfully unpacked and MD5 sums checked
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
*** copying figures
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (tidyverse)

The downloaded source packages are in
        ‘/tmp/RtmpG0JxxC/downloaded_packages’
Updating HTML index of packages in '.Library'
Making 'packages.html' ... done

But, I can't load tidyverse package even after successful installation of tidyverse.
library(tidyverse)
Error: package or namespace load failed for ‘tidyverse’:
.onAttach failed in attachNamespace() for 'tidyverse', details:
call: clienv$num_colors[[std]]
error: subscript out of bounds

Could you tell me how to fix this issue? How can I install and load tidyverse? Thank you.

Thank you  Sergey @naumenko-sa
I re-installed bcbio (reuse genomes) and now it's working fine. Thank you for your help.

repo: bcbio/bcbio-nextgen


text:
query about starting the structural variation pipeline

Hi,
I am planning to use the germline structural variation pipeline from bcbio-nextgen for calling germline SVs. I was unable to follow the what was mentioned here and was unable to get a starting point -https://bcbio-nextgen.readthedocs.io/en/latest/contents/structural_variants.html
I have already aligned CRAM files and was wondering if I can be directed towards how can I start using the pipeline (like get yaml files and so on).
Regards,
Prasun

Hi @prasundutta87 !
Could you please outline what have you tried and what did not work for you?
Did you install bcbio first of all?
Did you run the structural variant calling example?
bcbio supports cram as input as well, even though there are some limitations:
https://github.com/bcbio/bcbio-nextgen/issues/3011
Sergey

Hi Sergey,
Thanks for your reply. I had actually installed bcbio in 2020, but I have recently started using it now starting with SV specific pipeline. I have tried working on the example dataset, however, it gets stuck in the CollectSequencingArtifactMetrics stage in which I get an error named "ERROR: Invalid argument '-REFERENCE_SEQUENCE'". How do I resolve this issue? This is the exact command which is being executed:
unset JAVA_HOME && export PATH=/gpfs/igmmfs01/eddie/aitman-lab/Prasun/bcbio_nextgen/bcbio_data/anaconda/bin:"$PATH" && picard -Xms750m -Xmx3500m -XX:+UseSerialGC CollectSequencingArtifactMetrics -REFERENCE_SEQUENCE /gpfs/igmmfs01/eddie/aitman-lab/Prasun/bcbio_nextgen/bcbio_data/genomes/Hsapiens/hg38/seq/hg38.fa -INPUT /gpfs/igmmfs01/eddie/aitman-lab/Prasun/NA12878-sv-eval/work/align/NA12878/NA12878-sort.bam -OUTPUT /gpfs/igmmfs01/eddie/aitman-lab/Prasun/NA12878-sv-eval/work/bcbiotx/tmpnvoleqan/NA12878/NA12878 --VALIDATION_STRINGENCY SILENT
The issues what I generally face with bcbio pipelines, is that, as the pipeline runs many internal scripts, without closely tracking the lines in the bcbio-nextgen-commands.log file, it become difficult to understand what all steps are exactly happenning. The yaml file gives an overall picture, but still many internal step descriptions are still missing. Is the command log file still the only way to understand what's actually happening under the hood?
I was also wondering if the bcbio piepline installs all the required tools automatically for a pipeline when the pipeline runs? For example, from the provenance folder in the work directory?
I have actually managed to convert my CRAMs to paired end fastq.gz and I can use them in the pipeline.
Regards,
Prasun

Just to add, I found out that CollectSequencingArtifactMetrics can be disabled in the yaml file, which I did, so I am no longer getting that error.


text:
Video player close button

A button to close the video player and stop the current stream.

Approach changed into #94.

repo: bccsa/video-webapp


text:
Contact CRHP for submission requirements

Available here: https://www.historicplaces.ca/media/5428/doc-standards-en.pdf

Met with Natalie-Anne, below are the nodes of the meeting:

CRHP never to be migrated to Arches, no API, CRHP is at end of life - a year or two out
Looking at model where CRHP pulls from provinces to provide CRHP view
Vocabularies - splitting designation information into separate model, pulling in ADT from Getty, adding architect as builder
Parks Canada has both Historic Places and Historic Persons registries
CRHP has full extract function in app - NA to see if this is sufficient for our reconcile
Source code not in public repo
CRHP currently only used to capture time of registration, their work is full lifecycle of registration, looking to expand
Targeting Azure cloud
Using Arches as-is, no extensions
Developing resource models
Waiting for Internationalization & Accessibility enhancements (England about a year in front of CDN gov't with legislation)

Action items

[ ] BF to follow up with requests below
[ ] NA to provide valid vocabularies - CSV or Excel
[ ] BF to provide script to upload vocabularies - wait to hear back from NA when it will be useful
[ ] NA - To set up CRHP for BF, provide links to app and "Full export" reports for reconcile

Marking complete. Added issue to follow up w/ NA

repo: bcgov/BCHeritage


text:
Method of Tracking Website Visits

Is there a way we can track public visits to the website quarterly? yearly? If not, can we create something to track that.

[ ] Track visits to public website

@emjohnst - Do you want this for internal use only (ie - no UI on the website)? If so, we should look at using the NRIDS OpenSearch for this, which wouldn't require any modifications to the app itself. If that is the case I have a contact in NRIDS that will help us set it up.

@bferguso - yes for internal use only to track our stats. That would be great!

Initial strategy will be to use the NRIDS OpenSearch functionality. We should be able to point it to the Apache logs to get the information necessary without modifying the app or writing any custom code.

authors: bferguso emjohnst


text:
SPIKE - Secret management in Helm Charts

Evaluate options for more efficient secret management in our Helm Charts (currently Traction and VC-AuthN).
Some of the options to evaluate are:

Hashicorp Vault (https://www.vaultproject.io). A provider for Helm is https://github.com/Just-Insane/helm-vault
Argo CD (https://argo-cd.readthedocs.io). A potential plugin is https://luafanti.medium.com/injecting-secrets-from-vault-into-helm-charts-with-argocd-43fc1df57e74
Using Github secrets

Things to consider when evaluating:

Effort to implement the solution and related changes (i.e.: need for private repos)
BC Gov needs vs. community needs: are we locking ourselves into a specific solution? If so, is it worth it, or are there other options?

Acceptance Criteria:
Document (as part of this issue, or HackMD) the pros/cons of the above options (and potentially others not listed) so that a recommendation on what the next steps should be can be made.

FYI @WadeBarnes @i5okie

Platform services host instances of Hashicorp Vault and Argo CD.  The plan so far is to at least use Hashicorp Vault to provide better secrets management and open the door to automated key/password rotation for our services.  This allows machine managed access to services.  For example if we use these features on a postgres database, a developer would have to be granted permissions to get a temporal password to access the system.  We also are looking into using 1Password Secrets Automation to integrate with Vault to provide better secrets management from a team perspective, allowing credentials to be updated in 1Password and automatically distributed to our various environments and platforms.

Assigned to @i5okie

Closing this as we're addressing in https://github.com/bcgov/DITP-DevOps/issues/158

authors: WadeBarnes esune hiteshgh

repo: bcgov/DITP-DevOps


text:
Content: Student: Start New Application: Apply for funding page Fixes

Story Description
As a Student, I will be selecting the program year for when my study dates start.
Acceptance Criteria

[ ]  1.	Update Financial Aid Application statement

Remove current text: “Apply to see if you are applicable for provincial or federal loans and grant. This is for students attending full-time or part-time post-secondary studies.”

Replace text with:  “Please select your program year.  This is for students attending full-time or part-time studies.”

[ ]  2.	Update text in “Select program year” dropdown list

Remove current text: “(2024-2025) – Study starting between August 01, 2024 and July 31, 2025”

Replace with text: “(2024-2025) – My first day of classes starts between August 01, 2024 and July 31, 2025”

Business Context:

URL to Apply for Funding Page: https://test-aest-sims.apps.silver.devops.gov.bc.ca/student/application-form/start

Business team source material for updates: https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBNXd4QkE9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--38b0ae2202a3e8b7e62770b598d7286770ff6556/Apply for funding.docx

authors: HRAGANBC astridSABC

repo: bcgov/SIMS


text:
Feature/ab#23923 ensure build no is visible

In uX1.0, the main body css used overflow hidden... probably because we did not want a scrollbar anywhere since the view components were themselves managing the scrolling.
With that the footer won't be seen at any cost since it is hidden by the overflow.
So currently keeping it to auto, footer is seen but this may have consequences.
Other option is to show build version in menu itself, let me know.

@ravirammysore - will take a look and follow up with Max around the placement of the build number

Sure.

authors: AndreGAot ravirammysore

repo: bcgov/Unity


text:
BC Lawyer Showcase Person Credential

Signed-off-by: Stephen Curran swcurran@gmail.com

Person credentials are easy -- I had an existing Excel file that was almost right. I have to stop now, but take a look and I can pump out the others tonight or in the morning.

repo: bcgov/aries-oca-bundles


text:
Improve the no internet/firewall banner

Background
As a person using the BC Wallet, I want to know if there's the internet is poor or non-existent so that I can properly troubleshoot the issue I'm experiencing.
As a developer of the BC Wallet app, I want to be able to filter out issues with the wallet that have anything to do with poor internet connection so that I can focus on actionable issues
UI Improvements
The banner that appears when no internet connection is detected or when a firewall is detected covers key UI elements in the header (ex. the back button). Some people have a hard time figuring out how to dismiss the banner.
It goes away on its own and sometimes comes back and when people have tried interacting with it, it has gotten stuck.
We also have reports of people seeing the notification and not understanding its purpose.
UX Improvements

Explore improving the messaging
expand the purpose of this banner to include reporting poor internet connection

Screenshots

Tried a few things. Updating the ledger nodes (genesis block) and manually confirming the results from some BC Wallet debugging. The wallet is getting a "timeout" on most of the ledger nodes. There are one or two that work and this is probably why the test works but its not overly reliable because if that one node can not or does not respond then the firewall message appears. In any case, we need to find a better way to check a node than opening a TCP conneciton to it on the client_ip and client_port.
 LOG  connected: 154.0.164.39 9702
 LOG  timeout: 54.207.36.81 9702
 LOG  timeout: 128.130.204.35 9722
 LOG  timeout: 35.167.133.255 9702
 LOG  timeout: 34.226.105.29 9701
 LOG  timeout: 34.224.255.108 9796
 LOG  timeout: 38.70.17.248 9702

Confirmed with nmap -Pn -sT --reason -p 9702 54.207.36.81
Scanning 54.207.36.81 on ports 9702
Command: nmap -Pn -sT --reason -p 9702 54.207.36.81
Starting Nmap 7.95 ( https://nmap.org ) at 2024-06-19 11:04 PDT
Nmap scan report for ec2-54-207-36-81.sa-east-1.compute.amazonaws.com (54.207.36.81)
Host is up, received user-set.

PORT     STATE    SERVICE REASON
9702/tcp filtered unknown no-response

we are removing the firewall checks altogether

Duplicate of #1907, closing

authors: bryce-mcmath cvarjao jleach knguyenBC

repo: bcgov/bc-wallet-mobile


text:
As a Project Coordinator, I want to submit a reason for change when submitting a project revision, so that the rationale behind the change is recorded

Description:
When a project revision is updating a project, the user should submit a mandatory "reason" for the changes. This textarea input will be located in the "Check Answers" page, and must have a value before allowing the submission of a project revision.
To keep the application behaviour consistent, the "reason" will be saved in the project_revision table as the user types, using a debounced mutation.
Acceptance Criteria:
Given I am a CIF user
When I am reviewing a revision
And I am on the "Check Answers" page of my revision
Then I have a place to enter a reason for the change.
Given I am a CIF user
When I am on the "Check Answers" page of a project revision
And I have not entered a reason for the changes
Then I can't submit the revision
Given I am a CIF user
When I am on the Check Answers page of my project revision
And I am typing the change reason
Then the my change reason is saved as I type
And I can see a saving indicator indicating whether my changes are being saved or not
Development Checklist:

[ ] add a change_reason type varchar(10000) to the project_revision table
[ ] a project_revision json schema with the form_change marked as required
[ ] a frontend rjsf component to display a form for that schema
[ ] a happo screenshot and an e2e test to submit a change with a reason
[ ] Meets the DOD

Hey team! Please add your planning poker estimate with ZenHub @BCerki @dleard @gurjmatharu @matthieu-foucault @mikevespi

@matthieu-foucault I just caught this, a project_revision json schema with the form_change marked as required it's change_reason that should be required right?

Yes. I'm not sure we need a full form and json schema here, given that we have only one field.

Since the commitProject in app/pages/cif/project-revision/[projectRevision]/index.tsx is already updating the project_revision I think a simple input in that page might suffice?
The other question I had was should we prevent changing status to committed without a change_reason in the backend too, or is preventing on the front end enough in this context?

I suppose a backend validation should happen too

Sounds good

Thank you @mikevespi ! I may have tested a early based on @matthieu-foucault 's comments at standup, but the functionality appears to be functioning as expected and meets the acceptance criteria. Do you know if there is a ticket to capture the ability to see a list of the reasons for changes?

@LindsayMacfarlane Not that I saw, but I think we need some way to look at individual revisions too (as opposed to just the latest) so I think the scope is a bit larger here.

authors: LindsayMacfarlane matthieu-foucault mikevespi pbastia

repo: bcgov/cas-cif


text:
Add vertical BC logo to assets

The Design System specifies that the header should use the vertical logo on smaller screens (https://developer.gov.bc.ca/Design-System/Header-Basic#mobile-design), but I didn't see that logo here. I have scraped this from the DevHub.

Hey Mark, thanks for the PR on this missing asset!
I think your new BC_Logo_Vertical.svg file is a duplicate of the ambiguously-named logo.svg in the same directory, but with the removal of the horizontal gold bar component at the bottom of the logo. You can see the gold bar missing with a diff:
$ diff logo.svg BC_Logo_Vertical.svg
29d28
<             <polygon id="Fill-11" fill="#F3B229" points="15 107 105 107 105 106 15 106"></polygon>

The Visual Identity Program publishes digital brand assets on their Download Marks page, but they don't actually include SVG files in their RGB collection.
The existing logo.svg has some color differences compared to the brand standard, and some cruft from the Sketch generation process. It's 37K, and since we're mostly concerned about the vertical logo in the case of mobile devices, we can probably do better.
I've exported a new candidate SVG file from the Visual Identity Program's BCID_V_rgb_rev.ai Illustrator file at 15K and thrown it up here: BCID_V_rgb_rev.svg
For export settings, I used the following in Illustrator:
Styling: Internal CSS
Font: SVG
Images: Preserve
Object IDs: Layer Names
[ ] Minify
[x] Responsive

Would that new SVG file meet your needs for #131 in digital.gov.bc.ca?

Oops, my mistake!! logo.svg was what I needed. Sorry about that, thanks for reviewing this anyway!

repo: bcgov/design-system


text:
Improvements to Comments

Describe the bug in current situation
The following were not explicit in the Acceptance Criteria of Comments, but are suggested for improvement

The bold formatting currently does not work when tested on a mac computer

Enable ability to type as soon as "reply" is clicked below a comment, instead of the current state of having to click twice (click on reply, then click in the text box)

Don't include "enter" (line breaks) as part of the character count

Refine UI with the following:

Move 'X' either inline with text editor or inside box
Remove blue from background
Make reply full width with outline - like design
Make Airplane icon inline with Character counter
Reduce height of reply window - can be 1/2 the height of the "+ Add New Comment" Window

An additional question - Do we want the ability to edit just one comment at a time? Currently you can select "edit" on an unlimited number of comments, and the previous comments you've selected to edit will remain open and editable @lmullane @arielleandrews @m-prodan

@JHarrietha-AOT or @lmullane can you please recheck bold text now?

All other improvements noted above have been retested and pass! Thanks @abin-aot !

repo: bcgov/foi-flow


text:
Add the /slug route for logged in users

Issue #: https://github.com/bcgov/met-public/issues/2293
Description of changes:

Add the slug routes in authenticated users

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #2294 (1ddf21e) into main (1620dba) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2294   +/-   ##
=======================================
  Coverage   68.58%   68.58%
=======================================
  Files         472      472
  Lines       15579    15557   -22
  Branches     1187     1187
=======================================
- Hits        10685    10670   -15
+ Misses       4688     4681    -7
  Partials      206      206

Flag
Coverage Δ

metweb
61.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

authors: codecov-commenter jadmsaadaot

repo: bcgov/met-public


text:
Convert application from Spring WebFlux to Spring MVC.

This converts the application from a Spring WebFlux application to a Spring MVC application.
The advantages to doing so are explained in Spring's documentation. For me, the most persuasive points are:

Imperative programming is the easiest way to write, understand, and debug code. You have maximum choice of libraries, since, historically, most are blocking.
If you have a large team, keep in mind the steep learning curve in the shift to non-blocking, functional, and declarative programming. A practical way to start without a full switch is to use the reactive WebClient.

One great thing about this is the code hardly changes. We change some dependencies, but the structure is the same. The RestControllers don't need to be modified at all.

Thanks for pointing that out Adam. That exception is irritating, and I did look into fixing it this morning, but no luck. Notably it's printed as a WARN message, so it is "handled", and the docs still generate. I'd like to find a fix one day, but in the meantime I suggest we live with it (or remove the docs entirely):
Start of the log:
2020-11-20 09:49:18.568  WARN 17472 --- [o-auto-1-exec-1] i.swagger.v3.core.jackson.ModelResolver  : jackson BeanDescription.findJsonValueAccessor not found, this could lead to inaccurate result, please update jackson to 2.9+
2020-11-20 09:49:18.576  WARN 17472 --- [o-auto-1-exec-1] o.s.core.SpringDocAnnotationsUtils       : Graceful exception occurred

java.lang.IllegalArgumentException: Strange Map type java.util.Map: cannot determine type parameters

As noted in the chat, the /docs exception should be resolved by upgrading Spring Boot to 2.4.0 as per https://github.com/spring-projects/spring-boot/issues/22865

authors: ahoplock sharpedavid

repo: bcgov/moh-keycloak-user-management


text:
Use " aws_api_gateway_stage" AWS Resource to Manage Stage than Using "stage_name argument" Argument.

Current API-Gateway "Stage" deployment isn't managed by Terraform, it is using "stage_name" from the "aws_api_gateway_deployment" resource.
Private Zenhub Image
The Terraform Registry has a warning using this "stage_name" and states that:
Private Zenhub Image
Currently it is working for using "stage_name" but not sure if previously this warning from Terraform was not noticed or being chosen to use for a purpose.

This issue was found during implementation of #725 for which I was trying to associate WAF ACL with API-Gateway "stage".
During the #725, I attempted to correct this but was facing some issue when "terraform apply" (not during plan).
Error: creating API Gateway Stage (v1): ConflictException: Stage already exists

The error isn't straightforward and not sure how it was caused after spent sometime looking for clue.
Most likely might be a "cycle" (dependencies cycle) problem.

repo: bcgov/nr-forests-access-management


text:
Compared to MobX

How does this project compare to MobX / MST and where does it differ?
https://github.com/mobxjs/mobx
https://github.com/mobxjs/mobx-state-tree

Hi @andraz! I haven't used MobX much, but from what I can tell:

Undux has a lot fewer concepts than MobX. Undux doesn't have Actions, Computed Values, or Observables (every field on a store is observable).
In MobX, Reaction are used for side effects like rendering and network requests. In Undux, Effects are used for things like network requests, but not rendering (rendering is done automatically). In Undux, Effects are full Rx observables, so you can do a lot more with them than you can in MobX.

At a high level, Undux is a lot simpler, and doesn't ship with advanced features like decorator support and derived values out of the box. That said, as I said I'm not a MobX user - maybe someone with more MobX experience can chime in too.

authors: andraz bcherny

repo: bcherny/undux


text:
Flashdata doesn't work with array

So if you do this:

$this->session->set_flahdata('alert', [
'state' => 'danger',
'message' => 'Error!',
]);

It persists in the session data. I think at this point you should just return an error state when passing an array as a value. I've already refactored my controller to use two flashdata keys: 'alert_state' and 'alert_message'.
So throwing an exception would be ideal. However it would be most beneficial to support my use case above because we typically want to have one field that will do things like render a bootstrap or growl alert and we want multiple values in one session var because you need extra data to output the correct UI state.
Also, I noticed you make alot of your own libs. It would be nice to see the email class code to be removed and allow for using things like swiftmailer instead. I t/hink you guys should considerring outsourcing code like that of the Laravel framework. $this->email could be an instance of swift.
Chris

Your title says something doesn't work, but the description says it works and then branches out to irrelevant stuff ...

You probably want to retrieve the flashdata like $this->session->flashdata('alert')['state'].
It does work, just not the way you think it works. The way you expect it to work doesn't really make sense either. You could have easily figured this out by debugging $this->session->flashdata('alert')...

@renolooijmans You can verify that your usage is working as expected? Because I was debugging dumping out the session in the session class. It persisted forever until I switched to the way I was using it as I mentioned above. It's not clear how it "should" work.
If I want to jam an array into flash data to use once, why does it keep persisting until I dump? That's where I made it to. I don/'t really mind.. it's a nice to have and furthermore I don't use CodeIgniter in any newer projects mainly because it does not have a dependency injection container.

You probably want to retrieve the flashdata like $this->session->flashdata('alert')['state'].
It does work, just not the way you think it works. The way you expect it to work doesn't really make sense either. You could have easily figured this out by debugging $this->session->flashdata('alert')...

Can u plz give me example if i have these data & want the getFlashdata hav an array?
#This is in controller:
session()->setFlashdata('err', [
	'first_na' => $this->request->getPost('first_na'),
	'last_na' => $this->request->getPost('last_na'),
	'username' => $this->request->getPost('username'),
	'level' => 5,
	'no_hp' => $this->request->getPost('no_hp'),
	'email' => $this->request->getPost('email'),
	'password' => $this->request->getPost('password'),
	'errors' => \Config\Services::validation()->getErrors()
]);

#This is in view:
??? How to do it, ikeep got : ErrorException (Array to string conversion)

authors: HenryKim2022 cigzigwon narfbg renolooijmans

repo: bcit-ci/CodeIgniter


text:
The problem of input class case sensitivity is solved in Unix systems…

…. - Form_validation, Cookie problems that occur in stacks like Lampp etc. installed in Unix systems.
Signed-off-by: Hasan Hüseyin CİHANGİR hhuseyincihangir@gmail.com

This has nothing to do with UNIX systems and certainly doesn't solve any problems related to the built-in Form Validation library or cookies.
The only potential problem this patch may solve is issues with custom class/library names written with non-Latin characters, and ... while someone may be able to present a potential case for that, it's a bad practice.

authors: hhuseyincihangir narfbg


text:
fix: Bug that can not split correctly when validation rule does not regex_match.

Based on documentation, it shown :
$this->validate([
    'avatar' => 'uploaded[avatar]|max_size[avatar,1024]'
]);

It will get the following error:
CodeIgniter\Validation\Exceptions\ValidationException: up is not a valid rule.

@see: #1201

I confirm that it fixes the issue 👍

I think that parsing will fail in the next example.
I do not consider it in this PR.
Should this be fixed with this PR?
Would you like to create a new issue?
$this->validate([
    'date' => 'regex_match[/^[0-9]{4}[\-\.\/][0-9]{2}[\-\.\/][0-9]{2}/]'
]);

I think this PR should only contains the fix #1201 for easier to review, should be another issue for that.

As for the regex match you're showing: isn't that covered by these tests?

It is not covered.
The code to extract the string of rules is as follows.
https://github.com/bcit-ci/CodeIgniter4/blob/develop/system/Validation/Validation.php#L718
This code will do the following:

We are defining the next character of [ as a delimiter.
Get the index of characters up to the first matching delimiter].
A character string from the beginning to the index is stored in the rules variable as a validation rule.

The point is,
When writing the following rules, this program works as follows.
`php $ this-> validate ([     'date' => 'required|regex_match[/^[0-9]{4}[\-\.\/][0-9]{2}[\-\.\/][0-9]{2}/]|max_length[10]' ]); `
Please pay attention to regex_match at this time.

We are defining the next character of [ as a delimiter. (/)
Get the index of characters up to the first matching /].
A character string from the beginning to the index is stored in the rules variable as a validation rule.

That is, the stored rules variable is regex_match[/^[0-9]{4}[\-\.\/].
This is not appropriate as a regular expression.
The expected rules variable is regex_match[/^[0-9]{4}[\-\.\/][0-9]{2}[\-\.\/][0-9]{2}/].
Sorry for writing such a long message.

Well, sure, but the tests I linked to have multiple brackets inside so I thought it would cover that situation. If it's failing, then by all means - we would love a PR to fix that :)
For your test, please take a look at how I did the latest test for that. Instead of using some other rule that might fail on its own, I've isolated the test to just the splitRules method by creating a method invoker for the protected function.

For your test, please take a look at how I did the latest test for that.

Looked. Thank you tell.

Well, sure, but the tests I linked to have multiple brackets inside so I thought it would cover that situation. If it's failing, then by all means - we would love a PR to fix that :)
Instead of using some other rule that might fail on its own, I've isolated the test to just the splitRules method by creating a method invoker for the protected function.

I think it's good.
Likewise, I limited the responsibility range to splitRule method and write the test with #1203.
I am happy if you review it.

authors: lonnieezell samsonasik ytetsuro

license: mit

license_source: bigquery


text:
Download website unreachable

Hello everyone, I was trying to download the dataset from the website (https://bdd-data.berkeley.edu/) but it says "403 Forbidden".
Could you fix it?
I actually just need the "Labels" dataset (https://doc.bdd100k.com/download.html#labels). Could someone mirror that? Thank you.

It is back online now. Thanks for reporting.

It is back online now. Thanks for reporting.

Hi, it is offline again. Could you please help to fix it?

It is back online now. Thanks for reporting.

Hi, the website is down again. Could you please fix it?

It is back online now. Thanks for reporting.

I hope the website will be fixed soon

It is back online now. Thanks for reporting.

The website is offline again. Could you please fix it?

authors: Mabel0403 OnceUponATimeMathley Varshini11024 fyu valeriocost xchani


text:
Tolerant: Completion: Magic

Better magic completion
%%r<un>
#%      java<script>

Before: some magics where with %% others with #%. Only one space was necessary for completion
Question: I had to repeat and (so magic-words.grep(*.starts-with($rest))) because if I affect it in the boolean context, its always false even : and (my word =  magic-words.grep(*.starts-with($rest)); True) or and (my @words = Array.new(magic-words.grep(*.starts-with($rest)))) {  makes the when fails do you have an idea why ?

Hmm -- not sure -- but I modified it slightly to just assign @words in an expression and it seems fine

authors: bduggan tinmarino


text:
no flasher in bone-eMMC-flasher-debian-10.12-console images

The flasher is enabled in uEnv.txt:
debian@beaglebone:~$ tail -3 /boot/uEnv.txt
##enable Generic eMMC Flasher:
cmdline=init=/opt/scripts/tools/eMMC/init-eMMC-flasher-v3.sh

but nothing happens.  Probably because the scripts are missing:
debian@beaglebone:~$ ls /opt/scripts
ls: cannot access 'opt/scripts': No such file or directory

I tried all of these console image snapshots:
bone-eMMC-flasher-debian-10.12-console-armhf-2022-06-02-1gb.img.xz
bone-eMMC-flasher-debian-10.12-console-armhf-2022-07-01-1gb.img.xz
bone-eMMC-flasher-debian-10.12-console-armhf-2022-08-01-1gb.img.xz
all the same, no flasher.
Can I just copy /opt/scripts from the IOT snapshot, or is other stuff also missing?
Thank you!
rix

Sorry, regenerating the console image...  I've been moving things to a non /opt/scripts/ method for flashing, looks like i didn't finish that in buster.
Should have something uploaded in a hour or two.
Regards,

@rickyketch please verfy with:
https://rcn-ee.net/rootfs/bb.org/testing/2022-08-04/buster-console-armhf/
and i'll update the forum post..
thank you!

I tested bone-eMMC-flasher-debian-10.12-console-armhf-2022-08-04-1gb.img.xz.
eMMC flashing worked as expected.
Thank you Robert!

authors: RobertCNelson rickyketch

repo: beagleboard/Latest-Images


text:
Site Title / Favicon POST btn mixup

Operation System:
Beaker version:

just a little something that had me going in circles. prolly a quick fix. cheers!

Thanks for the feedback. We'll look into how to make that more clear.

This has been reworked, let us know if you still find it confusing

authors: mediacobbler pfrazee taravancil

repo: beakerbrowser/beaker


text:
Error referencing local variable

An error occurs when referencing a local variable within a class.  The following code will throw a 'no such field' exception during the assignment to one.ref:
public class TestAccess {

   public TestAccess ref = null;

   public static void main(String[] args) {
      TestAccess one = new TestAccess();
      one.ref = one;
   }
}

I tried to track down where the problem was happening, and noticed an exception occuring in ClassGenerator.java at line 187, where tvd.evalType happens.  The error is ignored and the variable does not get defined.
                BSHTypedVariableDeclaration tvd = (BSHTypedVariableDeclaration) node;
                Modifiers modifiers = tvd.modifiers;
                BSHVariableDeclarator[] vardec = tvd.getDeclarators();
                for (BSHVariableDeclarator aVardec : vardec) {
                    String name = aVardec.name;
                    try {
                        Class<?> type = tvd.evalType(callstack, interpreter);
                        Variable var = new Variable(name, type, null/*value*/, modifiers);
                        vars.add(var);
                    } catch (UtilEvalError | EvalError e) {
                        // value error shouldn't happen
                    }
                }

TestAccess.java.txt

There still needs to be more work done separating properties from fields, yes.

This appears to be resolved:
bsh %
public class TestAccess {

   public TestAccess ref = null;

   public static void main(String[] args) {
      TestAccess one = new TestAccess();
      one.ref = one;
   }
}
--> $2 = class TestAccess :Class
bsh % TestAccess.main(new String[0])

--> void

Closed: Fixed

authors: nickl- opeongo

repo: beanshell/beanshell


text:
🛑 Translate is down

In 3c58fe3, Translate (https://translate.wpbeaverbuilder.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Translate is back up in 4780b57 after 1 hour, 55 minutes.

repo: beaverbuilder/uptimes


text:
[FEAT] RPC Multicall Abstraction

Migrate RPC libraries to use viem.

enables us to abstract away from multicall code and get even better optimizations than we were seeing before.
app-wide multicall batching, cross file requests can be multicalled, saving on rpc requests and costs
type inference for rpc calls (yey!!!)

more cool stuff!

Complete migration of all price and vault related code to the new libraries.
Bump node version requirement to 18 to take full advantage of viem's features!
The way to work moving forward will be to call fetchContract and do all related calls via that method. If we were to run into a call that doesn't allow calls from other contracts (tx.origin != tx.sender), fetchNoMulticallContract can be used instead [try to avoid at all costs]
To take full advantage of type inference, ABIs must be migrated to ts files such as it's been done with all price related ones. Please take this into consideration when adding new ABI files, I'll be migrating all existing ones as I cover other sections of the API in future PRs.
In order to fully maximize multicall optimizations there's one single requirement: Please make all needed RPC calls before awaiting. For example
    const price = await getLpPrice(pool);
    const balances = await getLpTokenBalances(pool); // This call can't be added to the multicall till price one has been answered

    const [price, results] = await Promise.all([getLpPrice(pool), getLpTokenBalances(pool)]);
    // here both promises are awaited after being called, so they can be batched together

src/api/stats/common/hop/getHopCommonApys.js:36:49
You must provide the json interface of the contract when instantiating a contract object.

surprisingly no big improvements for me, still takes quite some time and there are failed requests. some errors are very verbose, whole ABI is printed.
but overall its ok to merge and test in prod as long as there are no crashes. slightly unpleasant that api uses node v18 vs v16 in app, maybe can upgrade app as well.

Hey @roman-monk ! Thanks for taking a look at everything. I appreciate the feedback.
The PR exclusively focuses on migrating to this new capabilities but I didn't optimize multicall batching settings to an optimal value, the idea was to get everyone to start writing code with this new methods so I don't have to go around migrating even more than necessary.
As it stands right now, client settings are:
batchSize: 128, // bytes
wait: 1500 //ms

Locally, running with this params I get a full price update in ~25 seconds. However the default batchSize is 1024 bytes and when running it with that change a full update is finished in ~6.5 seconds.
It's a matter of fully optimizing the settings, I'd rather run through that process once the entire api is migrated so we can adjust for our entire volume of calls. However, 128 bytes was a value I was using for testing and I will bump it to the default 1024 since it appears our rpcs can handle that payload without issues.

@roman-monk since fetchAmmPrices and fetchDmmPrices need every inner request to be successful in order to find prices correctly, I add a promise retrying function that retries the call we provide N times with an exponentially increasing interval in between attempts.
Awesome feature coming from this is that promises being retried can get multicalled with others due to our global multicall aggregation.
I'm stil debating internally on whether we want every rpc call in the api to benefit from this feature or not, wdyt?
ps: I tried to cut back on error logs sizes a bit

fetchAmm was pretty stable i think, it wouldn't crash if some request failed (prices affected obv but no crash of the whole app), fetchDmm could crash completely. but no arguing, if there is a better way - cool, lets use it.

I'm stil debating internally on whether we want every rpc call in the api to benefit from this feature or not, wdyt?

retry looks obviously good, but isn't it already added on the transport level of viem?
its so much better if we dont need to wrap every request with this promise and it just retries under the hood.
btw im fully support to merge it early to avoid more and more conflicts, so proceed to merge if you like

My understanding was that the retry of requests was only on transport layer errors, so rpc errors themselves weren't being retried (only http errors), I'll check the implementation to clarify on this

authors: roman-monk seguido

repo: beefyfinance/beefy-api


text:
left menu should be scrollable for smaller screen factors.

On a 8 inch tablet, the last  menu items are not visible.
the scrolling on the main region works like a charm.
cheers

Temporary fix is that you select the 'scrolling' layout in Dashboard -> Theme.
I'm also not happy with how this works so I will have to dive into enhancing it. Issue is related to #40 .

As I was not completely happy with the AdminLTE theme that I implemented, I've implemented rdash-angular in a temporary branch.
This template has much less bloated than AdminLTE and it supports the resizing on smaller devices very well.
Please let me know what you think of it!

Of course @movibe @macbroadcast @bmcintyre @rhalff @rborn (and everybody else) are more then welcome to discuss this too! :)

I have a demo online on Heroku: http://loopback-rdash.herokuapp.com/

Very nice !
For those not knowing username password: admin@admin.com / admin.
The left menu scroll bar is doing the job.
Maybe the windows mobile alike tiles in the AdminLTE were a bit more sexy, but that's probably just a matter of taste.

It was much better.
I would like you to take a look also in a version with the Gulp instead of Grunt, where I added the Less version of the original theme Admin LTE and some improvements.

@paulvanbladel I agree that the tiles of AdminLTE looked better, i'll merge them along with some other stuff.

@movibe i've looked at your Gulp version, which does look very nice! I am thinking about moving to gulp instead of Grunt anyway.
The thing that I don't like about AdminLTE is that it is too bloated, there are simply too many options that won't be implemented in this base project. Next to that the interface is buggy (especially on small screens) and very picky about how it's implemented, I had to change the base AdminLTE to get it to work in this project.
What I like about RDash is that is is clean and simple, and provided as a bower module.
Could you tell what you like more about AdminLTE? If it is just the way it looks we could implement some sort of theming system where we mimic the looks of AdminLTE.

I'm glad you liked my version, just could not solve the dependency error and since you would like to ask you if you could help me solve?
As for AminLTE, imagine that you have used it to be free, but what I wanted to add was more the advantage of compiling Less version and give the freedom to easily change the theme to use in other projects without the need to have large changes in CSS, and added a task to Gulp, but if I like the layout of it, I confess that I find very simple and swollen like you said.
But as you are the leader of the project, you have the greatest word decision.
I confess that the version you did was much prettier and better for tablets, but it will run away from the base of AdminLTE and become a unique template, this is not bad, it may be the best way, but depends on its future plans for the project and I will collaborate as planned.
And forgive my English, I speak Brazilian Portuguese and use google translator rs

@movibe Your English is still better than my Portuguese :)
I guess I'll take this route for now and implement some of the other stuff that AdminLTE offers.
If you can than rebase the gulp version to the new layout I'll check and implement it too!

I definitely second the switch to rdash-angular, a much lighter framework to expand on!

Closing in favor of work on project based on Angular 2+ / TypeScript. Follow here https://github.com/beeman/loopback-angular-admin/issues/202

authors: beeman lennybr movibe paulvanbladel

repo: beeman/loopback-angular-admin


text:
Wave effect

After clicking on a button with a wave effect, the button remains with the changed color until you click outside the button.
The change returns the button to its original color after the wave and hover effects.
I changed the speed, because with the change in the application of the effect the response time changed and the value 2 was too fast

Nice add thanks

authors: bigbruno leonardorafael

repo: beercss/beercss


text:
关于h5支付必需字段scene_info

这边生成的是这样的

而官网给出的是这样
<scene_info>{"h5_info": {"type":"IOS","app_name": "王者荣耀","package_name": "com.tencent.tmgp.sgame"}}</scene_info>
请问有什么解决的好办法吗？
谢谢！

scene_info内点数据用json.stringify处理下试试

authors: Laumlin befinal

repo: befinal/node-tenpay


text:
the random 1k ShareGPT4V validation set

Thanks for the great work! Could you please share the random 1k ShareGPT4V validation set split?

I checked their code. The 1k validation set is the first 1k instances in share-captioner_coco_lcs_sam_1246k_1107.json

Thanks for your reply~

authors: Arsiuuu MajorDavidZhang

repo: beichenzbc/Long-CLIP


text:
[CRITICAL] Remove collaborators and participants details from /api/event/(id)

Right now is a critical bug, encrypted password is showing in response, and other sense data, even showing categories

Fixed

repo: belatrix/BackendAllStars


text:
/api/employee/search/{search_term}/

Follow /api/search?parameters endpoint documentation.

I'm going to start some research, my initial options are haystack or simple django filters, I will execute some tests and then start to commit some code.

After some research I decided to use Q() objects, haystack is probably when Tags are implemented in version 2.0.
Changes are in this commit

Updated documentation on wiki page:  https://github.com/belatrix/BackendAllStars/wiki#apiemployeesearchsearch_term


text:
Linearsearch

Deskripsi (Description)
menambahkan linear search
Checklist:
Umum:

[x] Saya menambah algoritma terbaru.
[ ] Saya memperbaiki algoritma yang sudah ada.
[ ] Saya memperbaiki dokumentasi.
[x] Saya menambah dokumentasi.

Contributor Requirements (Syarat Kontributor) dan Lain-Lain:

[x] Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
[x] Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
[x] Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment
Saya menggunakan (I'm using):

OS = Mac OS
Java = 18

Link Issues

Issues : #76

to the moon 🚀

repo: bellshade/Java


text:
Tokenizers Example doesn't run + from_pretrained from the tokenizers crate needs features=["http"]

Hey @benbrandt,
thanks for your effort with text-splitter! I found a small bug and added a PR to fix.
Describe the bug
Running the tokenizers example doesn't work. As I see it, there are two problems.

The tokenizers crate is not exposed, so it must be installed by the user directly to be used.
It must be installed with the "http" feature enabled to use from_pretrained().

To Reproduce
Install via
text-splitter = { version = "0.6.0", features = ["tokenizers"] }

Then run the example from the Readme
use text_splitter::TextSplitter;
// Can also use anything else that implements the ChunkSizer
// trait from the text_splitter crate.
use tokenizers::Tokenizer;

let tokenizer = Tokenizer::from_pretrained("bert-base-cased", None).unwrap();
let max_tokens = 1000;
let splitter = TextSplitter::new(tokenizer)
    // Optionally can also have the splitter trim whitespace for you
    .with_trim_chunks(true);

let chunks = splitter.chunks("your document text", max_tokens);

Expected behavior
Working example. I fixed by adding tokenizers as a direct dependency
tokenizers = { version = "0.15.1", features = ["http"] }

I created a PR with a fix here: https://github.com/benbrandt/text-splitter/pull/90

@SimonCW good point!
However, I wonder if this should be solved by better documentation on how to use this with other crates (which admittedly there isn't really any)
The reason the http feature isn't enabled is because it brings in a lot of extra dependencies that aren't necessary if you are loading tokenizers from files.
Since I am just implementing a trait for the tokenizer crate, I tried to be as minimal as their crate would let me (unfortunately I have to choose one of two regex features, which means I am kind of blocked from enabling wasm tokenizers usage... But I digress...) And let the user of the crate decide how they want to use the tokenizers crate themselves.
Since Rust requires you to either own the trait or the struct to impl Trait, I am doing the bridge between the two crates, but I don't actually want to own the tokenizers crate for the user.
Does that make sense? Regardless, I think I need clearer documentation. And the fix you specified is exactly as intended.

Makes 100% sense to me! I see two options:
1. Re-exposing tokenizers features
We could add a feature tokenizers-http which then uses tokenizers = {..., features = ["http"]} as dependency. In the README example we could "guard" the use of from_pretrained() with a #[cfg(features="tokenizers-http"], analogous to the tokenizers README (https://github.com/huggingface/tokenizers/blob/main/tokenizers/README.md#loading-a-pretrained-tokenizer-from-the-hub). However, where do we stop? Do we need to re-expose other features as well?
2. Adding example cargo.toml to README
We could require the user to specify tokenizers as a direct dependency like I did in my initial post. To document we could simply add an expandable code block with an exemplary cargo.toml. See, for example, serde: https://github.com/serde-rs/serde?tab=readme-ov-file#serde-in-action
Based on your goals, to keep dependencies slim, I think 2. would be preferable. Let me know what you think and I'll adapt the PR. However, also keep in mind that specifying tokenizers as a direct dependency compiles tokenizers twice. Once as transitive dependency, once as direct one. Thats at least how I interpret my cargo.lock file.

Hmm yes 2 would be preferred, and I don't see why this would mean compiling tokenizers twice, but this would not be the first time I am quite surprised by Cargo behavior.
But because at least in one other app I've seen, the tokenizers crate is not only used for splitting text, I would be very hesitant to take control of the dependency for the user, as I stated earlier. I don't want to be the one reexposing it if I can help it.
Would be curious to learn from your setup how this is getting compiled twice. When I've seen this in the past, you usually get a compile error because there are two versions of the tokenizers crate, and the trait is only implemented for one and not the other, so there can only be one. But like I said, I would not be surprised if you know something I don't here, so I am happy to learn!

I updated the README in a new PR and closed the old one.
Concerning double compilation: That was my mistake and I'm doing the learning (relatively new to Rust). I also had fastembed in my dependencies which relies on an older version of tokenizers. That's where the second tokenizers compilation came from.

Awesome thank you! And no worries at all, I have been using Rust for awhile, but still am surprised from time to time by cargo behavior, so I didn't want to assume 😆
I'll get your PR merged, and hopefully the crate is helpful to you! I would love to take a look at how you are using it if it is public.

Awesome, I could look into a small Github Action for running unit tests if that's something you'd want?  I'll probably need it for one of my projects anyway.
Off-topic:
@benbrandt, your crate was super helpful and a pleasure to use after the crazyness that is langchain 😵💫! Unfortunately, I don't really have a project to share. I'm just exploring the LLM-RAG space with Rust to gauge potential for local / self-hosted applications for some of our customers (working for a consultancy that's also partnering with aleph alpha btw 😉 ).

@SimonCW CI should already be setup, feel free to take a look: https://github.com/benbrandt/text-splitter/blob/main/.github/workflows/ci.yml#L25
And I'm glad to hear! I know it's not perfect, and I have several features I still want to build out, but I also agree about Langchain. One of my motivations for writing this in my spare time 😆

authors: SimonCW benbrandt

repo: benbrandt/text-splitter


text:
Unable to connect dashboard to the server

Describe the bug
Hi , i am not  able to connect my dashboard with the backend .
To Reproduce
Steps to reproduce the behaviour:

Go to bench-routes backend folder
type "wsl"
type "make run"

Expected behaviour
a  bacckend server should start
Screenshots

error logs :
compiling go-code and executing bench-routes
echo "using 9990 as default service listener port"
using 9990 as default service listener port
go run src/*.go 9990
level=info ts=2021-09-17T20:00:06.055Z caller=main.go:45 msg=configuration out="[{sample-google 5s https www.google.com /search get map[Content-Type:json] map[q:bench-routes] map[]}]"
level=info ts=2021-09-17T20:00:06.055Z caller=main.go:53 msg="launching machine routine"
level=info ts=2021-09-17T20:00:06.062Z caller=main.go:67 msg="launching monitor routine"
level=debug ts=2021-09-17T20:00:06.065Z caller=api.go:53 msg="Updated API domain map"
level=info ts=2021-09-17T20:00:06.065Z caller=main.go:117 msg="Listening at :9990"
level=error ts=2021-09-17T20:00:07.233Z caller=main.go:161 msg="running machine" error="running machine: job: sample-google: error running ping : socket: permission denied"
exit status 1

Thanks for opening this issue, will be looking into this, currently assigning myself

@ruddi10 What's your local config.yml on the backend?

The parameters being sent with the request are:
name=/search&start=2021-09-21T14:53:38.917Z&end=2021-09-21T15:53:38.918Z&step=15

@aquibbaig can you please have a look at the request get-domain-entities as that's the one responsible for getting the entities and there its showing network error in your case, also I can see the request has some error as its having red text.
As for my config.yml its same as the bench routes master branch one

hi is this issue resolved @aquibbaig @ruddi10

@satyaarthchhabra The issue on your end seems to be different, can you do a simple ping command on your terminal and display the results here? just do a ping www.google.com

@ruddi10 The issue is tracked in #507

hey i thought that wsl was not working great for me so i used the installation process via docker and while i run  this command docker build -t bench-routes .  an error  came here are its log
[+] Building 442.9s (16/18)
=> [internal] load build definition from Dockerfile                                                       0.2s
=> => transferring dockerfile: 658B                                                                       0.0s
=> [internal] load .dockerignore                                                                          0.1s
=> => transferring context: 272B                                                                          0.0s
=> [internal] load metadata for docker.io/library/centos:centos8                                          4.3s
=> [ 1/14] FROM docker.io/library/centos:centos8@sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbde  140.7s
=> => resolve docker.io/library/centos:centos8@sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbdee55b  0.1s
=> => sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbdee55bd6c473f432b177 762B / 762B                 0.0s
=> => sha256:a1801b843b1bfaf77c501e7a6d3f709401a1e0c83863037fa3aab063a7fdb9dc 529B / 529B                 0.0s
1.2s                                                                   .14kB             0.0s
=> [ 6/14] WORKDIR /src/github.com/bench-routes/bench-routes                            83.52MB         119.2s
0.1s                                                                                19.6s
=> [ 7/14] COPY . /src/github.com/bench-routes/bench-routes                                               1.3s
0.3s                                                                                1.1s
=> [ 8/14] RUN cd $GOPATH/src/github.com/bench-routes/bench-routes/src && go get -v ./..                 82.1s .                15.0s                                                                                187.2s
=> [ 9/14] RUN go build $GOPATH/src/github.com/bench-routes/bench-routes/src/main.go                      1.0s
2.0s                                                                                1.2s
=> [10/14] RUN mv main bench-routes                                                                       0.1s
0.7s                                                                                0.3s
=> [11/14] RUN npm install -g yarn                                                      .                15.0s
7.1s                                                                                2.0s
=> ERROR [12/14] RUN cd dashboard/v1.1/ && yarn install && yarn run build                                 0.7s
0.6s                                                                                7.1s
------                                                                                0.6s

[12/14] RUN cd dashboard/v1.1/ && yarn install && yarn run build:
#16 0.554 /bin/sh: line 0: cd: dashboard/v1.1/: No such file or directory

executor failed running [/bin/sh -c cd dashboard/v1.1/ && yarn install && yarn run build]: exit code: 1                                                                           : exit code: 1
hope you find it useful @aquibbaig

@ruddi10 The issue is tracked in #507

So there is some issue with the backend right ? As I think it was stopping suddenly

hey i thought that wsl was not working great for me so i used the installation process via docker and while i run this command docker build -t bench-routes . an error came here are its log
[+] Building 442.9s (16/18)
=> [internal] load build definition from Dockerfile 0.2s
=> => transferring dockerfile: 658B 0.0s
=> [internal] load .dockerignore 0.1s
=> => transferring context: 272B 0.0s
=> [internal] load metadata for docker.io/library/centos:centos8 4.3s
=> [ 1/14] FROM docker.io/library/centos:centos8@sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbde 140.7s
=> => resolve docker.io/library/centos:centos8@sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbdee55b 0.1s
=> => sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbdee55bd6c473f432b177 762B / 762B 0.0s
=> => sha256:a1801b843b1bfaf77c501e7a6d3f709401a1e0c83863037fa3aab063a7fdb9dc 529B / 529B 0.0s
1.2s .14kB 0.0s
=> [ 6/14] WORKDIR /src/github.com/bench-routes/bench-routes 83.52MB 119.2s
0.1s 19.6s
=> [ 7/14] COPY . /src/github.com/bench-routes/bench-routes 1.3s
0.3s 1.1s
=> [ 8/14] RUN cd $GOPATH/src/github.com/bench-routes/bench-routes/src && go get -v ./.. 82.1s . 15.0s 187.2s
=> [ 9/14] RUN go build $GOPATH/src/github.com/bench-routes/bench-routes/src/main.go 1.0s
2.0s 1.2s
=> [10/14] RUN mv main bench-routes 0.1s
0.7s 0.3s
=> [11/14] RUN npm install -g yarn . 15.0s
7.1s 2.0s
=> ERROR [12/14] RUN cd dashboard/v1.1/ && yarn install && yarn run build 0.7s
0.6s 7.1s
------ 0.6s

[12/14] RUN cd dashboard/v1.1/ && yarn install && yarn run build:
#16 0.554 /bin/sh: line 0: cd: dashboard/v1.1/: No such file or directory

executor failed running [/bin/sh -c cd dashboard/v1.1/ && yarn install && yarn run build]: exit code: 1 : exit code: 1
hope you find it useful @aquibbaig

@satyaarthchhabra I will recommend to use Linux system for bench-routes if it's possible

that was not a big thing @ruddi10  just you have to remove some lines from the docker file. will make a pull request soon .

that was not a big thing @ruddi10 just you have to remove some lines from the docker file. will make a pull request soon .

Kindly open an issue first and then make the corresponding PR fixing that

@satyaarthchhabra Yeah, since the dashboard doesn't ship with this repo, it invalidates the dockerfile. Updating that would be good help

@satyaarthchhabra btw, the error that you have mentioned in this issue tells me that for some reason ping command wasn't able to execute due to a permission error. Well, this can be due to the firewall blocking connections, or your connection itself might be the issue. Doing things "docker way" seems to be a good approach here

i got the same errors even with docker

that was not a big thing @ruddi10 just you have to remove some lines from the docker file. will make a pull request soon .

I'm facing the same issue. Could you please tell which lines have to be edited in the Dockerfile?

@aquibbaig this issue persists with both the docker and the bare metal installation.  Is there any workaround for this?

@aaaaayushh Are you on windows? If yes, can you do a regular ping google.com on your terminal and let me know what it says

No, I'm on linux. The issue was that I was restricted to make ping requests. Running
sudo sysctl -w net.ipv4.ping_group_range="0 2147483647" before running make run fixed the issue.
However, I'm still getting a network error on the application and would appreciate some help in fixing that

@aaaaayushh  can you please show the response of get domain entities endpoint as the component that is showing network error actually fetches the data from this endpoint

@aaaaayushh Awesome! I can see that a request to /query-entity returns a 404. May I know what's the error message?

@aquibbaig this is handled in the frontend

@ruddi10  this is the response of the first get domain entities

@aaaaayushh Are you on windows? If yes, can you do a regular ping google.com on your terminal and let me know what it says

No, I'm on linux. The issue was that I was restricted to make ping requests. Running sudo sysctl -w net.ipv4.ping_group_range="0 2147483647" before running make run fixed the issue. However, I'm still getting a network error on the application and would appreciate some help in fixing that

And here's the response for the second one

@ruddi10 this is the response of the first get domain entities

@aaaaayushh Are you on windows? If yes, can you do a regular ping google.com on your terminal and let me know what it says

No, I'm on linux. The issue was that I was restricted to make ping requests. Running sudo sysctl -w net.ipv4.ping_group_range="0 2147483647" before running make run fixed the issue. However, I'm still getting a network error on the application and would appreciate some help in fixing that

And here's the response for the second one

Please select the response tab instead of headers tab

@muskankhedia thanks a lot! everything is working now!

authors: aaaaayushh aquibbaig ruddi10 satyaarthchhabra

repo: bench-routes/bench-routes


text:
Error message documentation possibly out of date

I have been trying to use the built in error message functionality, but it seems to never display. I am returning null from a data source function and based on the source code I would expect that to trigger the message. However, the reducer action is called, but no message is displayed.
It would be great if there was more documentation on how to use the error message functionality so that people do not need to dig into source code to figure that part out. Or perhaps an actual demo that intentionally triggers the message, since most demos setup the error handler, but never actually utilize it.

Looks like there were a few issues with the ErrorHandler module. I've addressed those, as well as created an example for the demo site.

Demo: http://react-redux-grid.herokuapp.com/ErrorMessage
Code: https://github.com/bencripps/react-redux-grid-demo/blob/master/src/components/examples/ErrorMessage.js

repo: bencripps/react-redux-grid


text:
Support partitioned attribute to manage the phasing out of third-party cookies

Chrome plans to gradually phase out support for third-party cookies (3PC), starting January 4th, 2024. Initially, this will involve disabling third-party cookies for 1% of users to enable testing.
To address the deprecation of third-party cookies, one approach is using CHIPS (Cookies Having Independent Partitioned State)
CHIPS enhances user privacy and security with a novel approach. It introduces a Partitioned attribute for cookies, enabling developers to opt for partitioned storage. This creates separate cookie jars for each top-level site.

LGTM, thank you for your contribution!

Hi @eXon, thanks. I've signed my commit.

@pjchender Thank you for your contirbution! It's not released with v7.0.2

authors: eXon pjchender

repo: bendotcodes/cookies


text:
Option To Show Full URL

Hey @benjaminhirsch thanks for the cool field package, short and sweet and well done 👍
I couldn't seem figure out how to submit a feature request type Issue, so sorry in advance if this is in the wrong spot.
I think it would be really useful/cool to add a ->showPreviewUrl($prefix) option (or something similar) that would show a preview of the full URL, ex: https://www.yoursite.com/super-cool-slug/ underneath/to the side of the slug text box.
Anyone else find this useful?
Thanks again for the hard work on the package.

Hey @nickpoulos! Thank you for your words and the proposal, I like it and I think this could be a handy feature for a future version, yes.  😄

authors: benjaminhirsch nickpoulos

repo: benjaminhirsch/nova-slug-field


text:
Netwulf changes the current working directory

After running the visualize function, I found that os.getcwd() returned /home/<user>/.netwulf.
Is this to be expected?

good catch! I'll look into it soon

authors: benmaier telastrus

repo: benmaier/netwulf


text:
Support named TypeScript enums/interfaces/modules

Addresses issues raised in #726 regarding TypeScript-specific AST nodes

Coverage decreased (-0.04%) to 95.992% when pulling 3a7b41280f38585bf2c85bea2e0c8a9cde6995a5 on spencerhakim:ts-nodes into 98acd6afd04dcb6920b81330114e146dc8532ea4 on benmosher:master.

Coverage decreased (-0.04%) to 95.992% when pulling 65b1d50ad6c5f25e2ad5ffad2c5933691703b5a2 on spencerhakim:ts-nodes into 98acd6afd04dcb6920b81330114e146dc8532ea4 on benmosher:master.

@ljharb Since you're the most recent person to show activity on this repo, can you review/merge this?

@spencerhakim looks like we need some more tests first, so coverage doesn't go down.

@ljharb Look at my changes, I already added several tests to cover everything. I'm pretty sure it's just a false positive based on this line.

Which test covers a TSModuleDeclaration without a TSExportKeyword?

Right, didn't think that through. >_<

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f104604a7d637018819515d82892ac50fd on spencerhakim:ts-nodes into 9db95b350eec1034b2ef58a1b648265bf1fbcf92 on benmosher:master.

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f104604a7d637018819515d82892ac50fd on spencerhakim:ts-nodes into 9db95b350eec1034b2ef58a1b648265bf1fbcf92 on benmosher:master.

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f104604a7d637018819515d82892ac50fd on spencerhakim:ts-nodes into 9db95b350eec1034b2ef58a1b648265bf1fbcf92 on benmosher:master.

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f104604a7d637018819515d82892ac50fd on spencerhakim:ts-nodes into 9db95b350eec1034b2ef58a1b648265bf1fbcf92 on benmosher:master.

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f104604a7d637018819515d82892ac50fd on spencerhakim:ts-nodes into 9db95b350eec1034b2ef58a1b648265bf1fbcf92 on benmosher:master.

@spencerhakim the PR still needs reviews from other collabs

authors: coveralls ljharb spencerhakim

repo: benmosher/eslint-plugin-import


text:
Add WebSocket connected() function

This is a helper function for determining if the underlying WebSocket has not yet closed. Needing to know this was the main reason I requested #608 to make the socket public. If you think it'd be okay, we could probably revert that change with this. The issue is that some people may be relying on the socket being public now.
Also, I wasn't sure what your preference would be a connected() function or a getter property. I can change if you prefer that.

Codecov Report

Merging #656 (51ff268) into main (6c79874) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #656   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines          509       531   +22
  Branches        39        39
=========================================
+ Hits           509       531   +22

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/client/WebSocketClient.ts
100.00% <ø> (ø)

Hi @hjoelr, let's make it a getter function. The socket can stay public because otherwise we would break the API contract. :)

Thanks again @hjoelr. 🙏 All your changes are now live with v3.1.0 -> https://www.npmjs.com/package/coinbase-pro-node/v/3.1.0

@bennycode You're welcome. My next contribution will hopefully be based off the idea in #421.

authors: bennycode codecov-commenter hjoelr

repo: bennycode/coinbase-pro-node


text:
Kanboard is not fetched

Fetch kanboard from the official site in the Dockerfile.

Latest kanboard is fetched from the official website if needed.

repo: benoit-g/docker-kanboard


text:
Event Tracking Example?

Would love to see an event tracking example in the read me, is it possible with this package?

Hey, you can absolutely use the package for event tracking. If you're using the <BentoAnalytics /> (or legacy) component, you can use the Bento JS SDK via the window like:
window.bento.track("optin", {"organisation_name": "Team Rocket"});
window.bento.track("demo");
window.bento.track("download");

I'll update the readme and provided types!

Just curious should the event names have a dollar sign before them

I don't think it is required and is just a convention some teams use, but I'll cc @jessehanley to double check

Thank you! I just know all the examples use it so that's what I do

@connorlindsey is correcto. Some people like to leave them out in their events so they can tell the difference between Bento ones and theirs.

authors: connorlindsey jessehanley someguy9

repo: bentonow/bento-nextjs-sdk


text:
Using it with Chrome in iPad

You might not believe me, but it did work! Just great. But my happiness greatly diminished when I noticed that it was failing.

I wrote a document
I decided to store it my Google Drive
I was successful. The document is now in my Google Drive.

However, a few minutes later, I started another document. That's when things stopped working (I mean, only for the Google Drive part). I was never able to store the second document in my Google Drive.
What kept happening was that the program kept asking me to accept to proceed to pass on to the Google Authorization page. Which it did, but then NOTHING would happen. Nothing. It would stay there waiting for me to tap on the google account under whose drive I would be storing the document. But nothing else ever happened.
I did have my Gmail opened in one of the Chrome opened pages, I knew I was already logged into the Gmail/ Google Drive system.
Remember: I had already successfully stored 1 document (the first one). Hopefully you will be able to fix this. Good piece of work, StackEdit. Try to make it work properly under the Google Drive. It's pure HTML5 code. I know it can be done; I've advanced my application and so far it works just fine under all browsers and all environments.

Closing as too old.

authors: benweet frafor

repo: benweet/stackedit


text:
Improveme Map CSS

Are you guys managing https://www.healthmap.org/covid-19/ ? Sorry if not right place...
I guess it would be better to add some opacity in the pins. Something like
.pin-lg, .pin1 {
  opacity: 0.7;
}
.pin-md, .pin2 {
  opacity: 0.7;
}
.pin-sm, .pin3 {
  opacity: 0.7;
}
.pin-xs, .pin4 {
  opacity: 0.7;
}

We are not directly, but do talk with them regularly. Thanks for the feedback - I have passed this along to them. Hope you don't mind!


text:
Mismatch in prop names

This should be Database:
https://github.com/berenddeboer/cdk-rds-sql/blob/2ee7dd1e969bb7b0d7291faa0d6b66f49c34498b/src/role.custom-resource.ts#L58
As that is what the handler expects:
https://github.com/berenddeboer/cdk-rds-sql/blob/2ee7dd1e969bb7b0d7291faa0d6b66f49c34498b/src/handler.ts#L214
Otherwise, an error is thrown:
{
    "errorType": "error",
    "errorMessage": "database \"root\" does not exist",
    "code": "3D000",
    "length": 89,
    "name": "error",
    "severity": "FATAL",
    "file": "postinit.c",
    "line": "921",
    "routine": "InitPostgres",
    "stack": [
        "error: database \"root\" does not exist",
        "    at Parser.parseErrorMessage (/var/task/index.js:22772:98)",
        "    at Parser.handlePacket (/var/task/index.js:22613:25)",
        "    at Parser.parse (/var/task/index.js:22537:34)",
        "    at Socket.<anonymous> (/var/task/index.js:22813:44)",
        "    at Socket.emit (node:events:513:28)",
        "    at addChunk (node:internal/streams/readable:315:12)",
        "    at readableAddChunk (node:internal/streams/readable:289:9)",
        "    at Socket.Readable.push (node:internal/streams/readable:228:10)",
        "    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)"
    ]
}

I think this is fixed now.

authors: berenddeboer moltar

repo: berenddeboer/cdk-rds-sql


text:
🛑 PM is down

In 45b4929, PM (https://pacmart.shop) was down:

HTTP code: 503
Response time: 546 ms

Resolved: PM is back up in 5e9aeb1.

repo: berhei/monitor


text:
Update README to specify "bernard/bernard": "dev-master" in composer.json

When I follow the README and executecomposer require bernard/bernard the version of bernard installed is, bernard/bernard": "^0.13.0". I see Bernard\Router\ReceiverMapRouter exists in master, and the only way I am aware of getting the latest version is if I spell out in my composer file the following "bernard/bernard": "dev-master".

I guess it would even be better to tag a new release.
See #392
@sagikazarmark any update on making an updated release?

Please see https://github.com/bernardphp/bernard/discussions/413

What is happening with this

What is happening with this

https://github.com/bernardphp/bernard/discussions/417

authors: bumbummen99 phpbg pluc robskrob sagikazarmark

repo: bernardphp/bernard


text:
Issue with Odd-Order Highpass Filters

After introducing new tests, it was observed that highpass filters of odd order produce incorrect results. This issue has already been reported in the original library, as seen in this issue.
The proposed fix appears to be effective. Both tbrunsch and I have tested the fix, and it seems to work without introducing any other issues. Additionally, upon reviewing the code, we've verified that the changes exclusively affect the highpass filter and do so correctly.
We will be submitting a PR that includes both the unit tests and the fix for this problem.

thanks. Indeed. Pole and zero should end up in the same coefficient as the math is the same of both numerator and denominator.

authors: anleu berndporr

repo: berndporr/iirj


text:
1.18-3.0.48 issue

Just updated from 3.0.46 to 3.0.48 and now when I start the game, I'm greeted with the following screens:

Version: Forge
Game version: 1.18.2
Crash log: https://crashy.net/4ZpiJMn2468lk9c8NM5R
If I roll back, then the game is fine.

The mod Mowzie's Mobs causes this issue

repo: bernie-g/geckolib


text:
Generator creates duplicate items on first page

As I noted at the end of my report on issue 182, the generator is giving me duplicate items on the first generated page. While in my earlier report, this was annoying, in the last item I "generated", each page had a few dozen PDF annotations. After spending considerable time getting each annotation to link to the correct page, I was confused when the links all seemed to go to page 1 in the exported PDF.
I quickly figured out that it was the duplicate items problem. Although I was editing the top annotation, the export to PDF seemed to move it below the unedited one. And since they were in the same position, I had to select each one of the top ones (in the Scribus document) and move them aside before selecting the bottom ones to delete so that the PDF export would produce the desired results.
I don't recall either of my problem reports from the previous time I used generator (once a year). It is possible it's related to the move to Python 3.... Or it may just be the version of Scribus (1.5.6.1). Whatever the reason, it's giving me a lot of problems this year.

Hi Gary. Sorry to read about these difficulties.
Elements of multiple copies 'moving' to unexpected places when using the 'next record' feature is usually due to this elements being located at an unexpected place (sequence) in the source SLA document... define by the order in which the frames where created in the template document, and not by their graphical position if you later move them up or down.
It is usually possible to fix it by grouping the 'moving' frame with another frame that is duplicated at the right place (and then saving the SLA, of course)
I'd be happy to have a closer look at your template to try to find a better way to implement the multiple copies mechanism, that would not rely on the source code sequence... maybe at the cost of running a little bit slower.

The porting to Python3 introduced indeed some bugs in the items generation, sorry. These but should have been fixed in the January commits. Kindly update your script, test, and let me know if this is now resolved for you !

authors: berteh garydale

repo: berteh/ScribusGenerator