text:
fortune: Revert add an option to let user use offensive

This reverts commit https://github.com/NixOS/nixpkgs/commit/bf09f6c83afefd3c2dae00eeec0802644ceb7456.
There is no reason for nixpkgs to enable racism. If someone wants
this, overlays exist. No one is preventing anyone from using their
computer to do whatever they want, but maybe nixpkgs doesn't need a
flag that makes fortune print swastikas.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

There is no reason for nixpkgs to enable racism.

It's not enabled in Nixpkgs in any capacity, Nixpkgs is merely a package repository/implementation for a Linux distribution. The fact that a package has an optional flag which is not enabled by default that adds some funny (to some) quotes and messages is not "enabling racism".

maybe nixpkgs doesn't need a flag that makes fortune print swastikas

Please show an example of a fortune with swastikas in it. The upstream maintainer mentions in his GitHub bio that he's an Israeli software developer, so I highly doubt that he would be affiliated with swastikas, certainly not in a positive way.
/cc @wmertens @Vonfry (as participants of #172011)

There is no reason for nixpkgs to enable racism.

It's not enabled in Nixpkgs in any capacity, Nixpkgs is merely a package repository/implementation for a Linux distribution. The fact that a package has an optional flag which is not enabled by default that adds some funny (to some) quotes and messages is not "enabling racism".

I agree that it is an optional flag. I respectfully disagree in not enabling racism. Adding a clear path from not racism to racism is enabling it.

maybe nixpkgs doesn't need a flag that makes fortune print swastikas

Please show an example of a fortune with swastikas in it. The upstream maintainer mentions in his GitHub bio that he's an Israeli software developer, so I highly doubt that he would be affiliated with swastikas, certainly not in a positive way.
I am very, very saddened to hear that he is from Israel.

https://github.com/shlomif/fortune-mod/blob/da2fb5c184027d88401ea3f904314df83e5ea904/fortune-mod/datfiles/off/unrotated/atheism#L137
https://github.com/shlomif/fortune-mod/search?q=Adolf+Hitler

/cc @wmertens @Vonfry (as participants of #172011)

https://github.com/shlomif/fortune-mod/search?q=Adolf+Hitler

GitHub finds only a handful of occurrences for some reason. grep -rn "Adolf Hitler | wc -l in the repo returns 58.

🤯😱🤢 I had no idea. The swastika makes it actually illegal in Germany! You can't really claim that it's there for educational or artistic purposes (the only allowed exceptions)
This makes me very sad, I really enjoy the atheist jokes generally speaking.
Could we not patch out the offending fortunes?

The fortune manpage states:

Please, please, please request a potentially offensive fortune if and only if you believe,
deep in your heart, that you are willing to be offended. (And that you'll just quit using -o
rather than give us grief about it, okay?)

So the current behaviour is correct.

For what its worth, the ubuntu response on their side:
https://twitter.com/ubuntu/status/1592842830359461888

The swastika makes it actually illegal in Germany!

This got me thinking. Say I am a user of nixpkgs in Germany. I like fortune, and I install the default package. One day, there is a cache miss, or I want to update fortune so I run nix-build. In this case, the derivation in nixpkgs realizes the fortune source archive in my nix store, which completely unbeknownst to me includes nazi symbolism.
If my computer is searched for whatever reason by authorities, I am exposed to  risk. The risk is that I can end up in a legally involved situation.
Or more importantly, any NixOS server that has built and still builds the default fortune has fetched and holds an archive with nazi symbolism. Is that server in Germany, exposed to German laws? Is that server paid for by a company that doesn't want want to be exposed to such a situation? There is legal and publicity risk now.
Due to all this, I am changing my position. It is irrelevant whether withOffensive is there or not. The nixpkgs recipe must be changed immediately stop fetching from this upstream and fetch from an upstream that doesn't have these in the first place.
Imo nixpkgs unknowingly stepped into something bad with the source fetching. Let's undo that now, and only then start discussing how bad it actually was, if at all, and in what terms it can be re-introduced.

@JuJulius-Pepperwood
First of all, good find, I was not aware that the package contains a depiction of swastika. That is indeed peculiar.

I agree that it is an optional flag. I respectfully disagree in not enabling racism. Adding a clear path from not racism to racism is enabling it.

Well, I guess we just have a different perspectives on this matter. I am completely indifferent to these quotes and I don't take any offense in them personally, and even if I took offense, I'd consider it a private matter that I got offended by the text on the screen. I also don't think that the mere existence of racist quotes or words could enable racism. I also know for a fact that it's possible to steal something from someone, but that doesn't make me want to become a thief.
Hopefully this didn't come out as disrespectful, I'm not that well-versed in English.

I would like to see this filtering done upstream

In that case I believe it would be better to discuss this with upstream. Personally, I think that we should package software with the desire to replicate and follow upstream's intentions (or at least try doing it)... or don't package it at all.

This got me thinking. Say I am a user of nixpkgs in Germany. I like fortune, and I install the default package. One day, there is a cache miss, or I want to update fortune so I run nix-build. In this case, the derivation in nixpkgs realizes the fortune source archive in my nix store, which completely unbeknownst to me includes nazi symbolism.

If my computer is searched for whatever reason by authorities, I am exposed to risk. The risk is that I can end up in a legally involved situation.

Or more importantly, any NixOS server that has built and still builds the default fortune has fetched and holds an archive with nazi symbolism. Is that server in Germany, exposed to German laws? Is that server paid for by a company that doesn't want want to be exposed to such a situation? There is legal and publicity risk now.

Given this logic we should remove this package altogether because its tarball can be considered illegal.
Should we also remove other packages that could be considered illegal in other countries? For instance, in my country (Russia) it's illegal to negatively portray or discredit the Russian Armed Forces (RAF) and RAF's actions (especially regarding the ongoing conflict in Ukraine), you can also get into trouble by promoting or soliciting donations to Ukraine. Should we also remove a plethora of packages that include in them political statements that can somehow negatively portray RAF and/or solicit said donations? What if the word "Nixpkgs" gets banned tomorrow in your country? Should we rename the repository then?
My point is that these things depend entirely on the interpretation of the law. I am no expert in this and I assume you are not either (please correct me if I'm wrong). So let's not make any hasty decisions.

The nixpkgs recipe must be changed immediately stop fetching from this upstream and fetch from an upstream that doesn't have these in the first place.

We can remove this package from Nixpkgs, I have no objections against that, even though I don't agree with your reasoning. However, I don't think that removing the option will benefit us in this situation at all, and I also don't think that it would be the right thing to do (as explained above).

Imo nixpkgs unknowingly stepped into something bad with the source fetching. Let's undo that now, and only then start discussing how bad it actually was, if at all, and in what terms it can be re-introduced.

Let's first formalize this and ask the community. I'm willing to help and give my thoughts on this topic if you or someone else could draft an RFC.

the nastiness of what's in there voids the usual maintainer guarantee/responsibility/desire to make things configurable.

Which is why it's not enabled by default. If someone wants offensive jokes, it's entirely their decision - why assume that you know what the user wants more than they do? It's very condescending.

The swastika makes it actually illegal in Germany! You can't really claim that it's there for educational or artistic purposes (the only allowed exceptions).

Unless germany has a well defined meaning for "artistic purpose", it leaves a pretty broad door open for jokes/comedy, does it not?
Also as @azahi already pointed out once you start removing packages because it might be illegal in ${some_country} you'll step into a pretty bad rabbit hole. There are hundreds of countries out there - with plenty of questionable laws.

Hopefully this didn't come out as disrespectful, I'm not that well-versed in English.

No, not at all, I think we are having a great discussion here, respectful, factual and analytical. That is more than I expected, given the touchiness of the subject.

First of all, good find, I was not aware that the package contains a depiction of swastika. That is indeed peculiar.

I agree that it is an optional flag. I respectfully disagree in not enabling racism. Adding a clear path from not racism to racism is enabling it.

Well, I guess we just have a different perspectives on this matter. I am completely indifferent to these quotes and I don't take any offense in them personally, and even if I took offense, I'd consider it a private matter that I got offended by the text on the screen. I also don't think that the mere existence of racist quotes or words could enable racism. I also know for a fact that it's possible to steal something from someone, but that doesn't make me want to become a thief.

You are right, it is not enabling. I take that back. Still, I think having a flag that among other things enables all the things mentioned so far, is not good. I think we agree at this point that it's not enabling, it's definitely not condoning. It's a presence whose existence can be interpreted in different ways by different people. One of the interpretations is that it makes nixpkgs not-as-welcoming as it could be, and I want it removed so that this interpretation can be squashed. This is the reason ubuntu pulled their equivalent package when it was pointed out to them.

I would like to see this filtering done upstream

In that case I believe it would be better to discuss this with upstream. Personally, I think that we should package software with the desire to replicate and follow upstream's intentions (or at least try doing it)... or don't package it at all.

In principle, I agree on both points. In practice, I have read the blog of the upstream maintainer. He is very open about his views, goals, aspirations. I will not go into detail, here and now is not the place. Feel free to read the maintainer's blog and draw your own conclusions, I have drawn mine, they will not change and if we start discussing such things here we will lose track of what we want to do.
[sidenote: I have snipped a bunch of stuff here, I want to kind of nip the discussion wrt legality. I don't have a legal background, I'm just a programmer who likes nix. I'm not using my real account/name for protection, not subterfuge. I don't want actual nazis to escalate this thread into real life harassment. If you don't like the anonymity, let me know, and I can talk to one of the moderators and they can vouch that I am not doing sockpuppeting or pretending to be someone I am not or anything else.]

Should we also remove other packages that could be considered illegal in other countries?

This is a reasonable and expected question. My answer is that drawing equivalences and expanding the question to be generally about nixpkgs and legality kind of goes out of scope. I brought up the legality as an argument because of the intersection of laws and swastikas/hitler quotes. For the other cases, the moral/social/political context of what is banned is different, so I reject the notion of equivalence. It might also be worth pointing out that this is not just Germany, but tens of countries across the world that ban nazi symbols in public: https://en.wikipedia.org/wiki/Bans_on_Nazi_symbols.  nixpkgs is not violating any laws, i don't think, but in spirit a lot of countries agree and I am not aware of any that disagree, e.g. countries that make flying nazi flags mandatory.
The notion of precedent is important. We could stop here, merge the removal, with the record saying that this is not a general precedent. It would only be a precedent in the very narrow context of adding new flags or default source fetching of nazi symbols in the fortune package. This will not be a statement about other stuff.

My point is that these things depend entirely on the interpretation of the law. I am no expert in this and I assume you are not either (please correct me if I'm wrong). So let's not make any hasty decisions.

I am not bringing forth hasty suggestions, I hope. If I may use an analogy, I feel like we are on the first step on a bridge, and it made a weird sound. Let's take a small step back and discuss from the ground whether the bridge is safe to cross.
Removing the package as a whole is a huge step back, I am not proposing that.
From what I see here in this thread, the PR that added the flag was merged without full awareness of what the flag enabled. With the benefit of hindsight, it might never have been merged. Let's undo that and give us space and time to make the decision to add the flag with a more complete context. Which brings us to:

Let's first formalize this and ask the community. I'm willing to help and give my thoughts on this topic if you or someone else could draft an RFC.

I more than agree. This process will take time, so I very much see it as a prerequisite that we undo the flag addition now and remake the decision with a fuller context and an accepted RFC to guide us.
So with the RFC in mind, I say let's:

remove the flag, it's contentious and added without the full knowledge of the contents of fortune
Start the RFC process. Let us discuss what the scope of the RFC should be, legal, moral, very focused on nazi stuff? What do we want to solve?
Once we have the community consensus and framework, let's revisit this but from the side of merging it again, not removing it.

Are you ok with this?

Why assume that you know what the user wants more than they do? It's very condescending.
Please refrain from ascribing such intentions. I am trying not to be condescending, I am not telling the users what to do. I have multiple times mentioned that overlays exist to allow users to do what they want. I dislike your tone, please keep things civil and without attaching intents.

There is a dimension on what upstream means here, which I did not touch. The upstream nixpkgs uses is not the original source of fortune. The maintainer of it imported the original fortune program and the assets. It is closer to a fork, not the authoritative source of fortune. I believe there is some leeway in using a different upstream, which will have the same core fortune source code and non offensive jokes. It would not be a fork, but the exact same core, different assets, if this makes sense.

I have multiple times mentioned that overlays exist to allow users to do what they want.

It's unnecessary additional work.

I dislike your tone, please keep things civil and without attaching intents.

I had no intention to have a negative tone, but I see now that that's how it came off.
Similarly you may not had any intention to be condescending, but when a packager removes an upstream configuration due to personal/subjective reasons - that's precisely how it comes off. Hopefully that's clear now.

I don't have an opinion either way. I'm just commenting to let you know this PR should be squashed into a single commit.

With how trivial it is to override or pull in in non nixos/nixpkgs derivations now, I think it's really not too big a deal to remove this.

Thank you everyone for your time, for being so kind while being so kind while discussing such a touchy subject. Thanks for all the effort that went here, your suggestions, your kindness, taking the time to read my essays.
I am withdrawing this PR. In light of the above discussions, discoveries and a talk with one of the moderators on matrix, I wish to stop my involvement here. If anyone wishes to continue on the points made here, I have no reason or right to stop anything, I merely got a ball rolling. It seems likely I will find some time some other day to tackle this problem from the perspective of completely removing fortune.
To wit,
The upstream maintainer goes by Shlomi "Rindolf Hitlower" Fish: https://www.shlomifish.org/me/rindolf/#rindolf_aim_very_high_hitlower. The number packages with Hitler quotes and swastikas, whose maintainer goes by an A.H. pun nickname, that I find acceptable is exactly 0.

My best and gratitude to everyone here

authors: JuJulius-Pepperwood N-R-K azahi raphaelr reedrw witchof0x20 wmertens


text:
discord: 0.0.9 -> 0.0.10

Upgrade is now forced, so can't use 0.0.9

I see that the name of the branch is wrong, can fix that if it's wanted.

source: gharchive/pull-request

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
python310Packages.yamlloader: 1.1.0 -> 1.2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.yamlloader is: "A case-insensitive list for Python"
meta.homepage for python310Packages.yamlloader is: "https://github.com/Phynix/yamlloader"
meta.changelog for python310Packages.yamlloader is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.2.2 with grep in /nix/store/v3l8p3grlc5ip9388lsb8lsp4rxlfr3z-python3.10-yamlloader-1.2.2
found 1.2.2 in filename of file in /nix/store/v3l8p3grlc5ip9388lsb8lsp4rxlfr3z-python3.10-yamlloader-1.2.2

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
check-esxi-hardware
python310Packages.pywbem
python310Packages.yamlloader
python39Packages.pywbem
python39Packages.yamlloader

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v3l8p3grlc5ip9388lsb8lsp4rxlfr3z-python3.10-yamlloader-1.2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.yamlloader https://github.com/r-ryantm/nixpkgs/archive/788cdf4c905022a57b5c0e110f433ce11934c2d6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v3l8p3grlc5ip9388lsb8lsp4rxlfr3z-python3.10-yamlloader-1.2.2
ls -la /nix/store/v3l8p3grlc5ip9388lsb8lsp4rxlfr3z-python3.10-yamlloader-1.2.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

check-esxi-hardware
python310Packages.pywbem
python310Packages.yamlloader
python39Packages.pywbem
python39Packages.yamlloader

Maintainer pings
cc @freezeboy for testing.

Result of nixpkgs-review pr 204477 run on x86_64-linux 1

5 packages built:

check-esxi-hardware
python310Packages.pywbem
python310Packages.yamlloader
python39Packages.pywbem
python39Packages.yamlloader

Result of nixpkgs-review pr 204477 run on x86_64-linux 1

5 packages built:

check-esxi-hardware
python310Packages.pywbem
python310Packages.yamlloader
python39Packages.pywbem
python39Packages.yamlloader

authors: fabaff r-ryantm


text:
rstudioServerWrapper: inherit meta from rstudio

Description of changes
I was trying to do
lib.getExe pkgs.rstudioServerWrapper
but this would not get the correct binary because the wrapping erases
rstudio meta.mainProgram 's entry.
This change fixes that.
@cfhammill

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

seems like not ready yet
nix run .\#rstudioServerWrapper
error: unable to execute '/nix/store/ykzzr4a6gz711qwymqvl17szj1qc1hnz-RStudio-2022.07.1+554-wrapper/bin/rstudio-server': No such file or directory
nixpkgs on  nixos-unstable via 🐍 took 2m30s
✖1 ❯ ls /nix/store/ykzzr4a6gz711qwymqvl17szj1qc1hnz-RStudio-2022.07.1+554-wrapper/bin/rstudio
ls: cannot access '/nix/store/ykzzr4a6gz711qwymqvl17szj1qc1hnz-RStudio-2022.07.1+554-wrapper/bin/rstudio': No such file or directory

when building rstudio-server the binary is called rstudio-server :
lrwxrwxrwx 1 root root 33 1970-01-01  rstudio-server -> ../lib/rstudio/bin/rstudio-server
but building rstudioServerWrapper, we get:
rserver and rsession executables, which ones are correct

In the rocker image it's apparently rserver so we should probably  use that everywhere I will update the PR
docker exec -it rocker/rstudio sh

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/adding-rstudio-server-r/8644/8

Hi @teto, sorry this took me a while to get to. I went back through the notes on the original PR:
https://github.com/NixOS/nixpkgs/pull/95831#issuecomment-988500963
it looks like you're correct in determining that rserver is the correct program to run, if I remember correctly the rstudio-server program is just a shell script to communicate with rstudio-server running as a service. @bcdarwin do you remember if the nixos module uses rstudio-server?

yes https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/development/rstudio-server/default.nix

It looks here like it's using rserver too, not the rstudio-server script: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/development/rstudio-server/default.nix#L82

authors: bcdarwin cfhammill nixos-discourse teto


text:
scorecard: 4.8.0 -> 4.10.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ossf/scorecard/releases.
meta.description for scorecard is: "Security health metrics for Open Source"
meta.homepage for scorecard is: "https://github.com/ossf/scorecard"
meta.changelog for scorecard is: "https://github.com/ossf/scorecard/releases/tag/v4.10.2"
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10.2 with grep in /nix/store/rqlnxxp7djzfswqd545hx36ajs8p29x6-scorecard-4.10.2
found 4.10.2 in filename of file in /nix/store/rqlnxxp7djzfswqd545hx36ajs8p29x6-scorecard-4.10.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
scorecard

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rqlnxxp7djzfswqd545hx36ajs8p29x6-scorecard-4.10.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A scorecard https://github.com/r-ryantm/nixpkgs/archive/030b1aae17a7c520ae648fa9e8c3621889d04014.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rqlnxxp7djzfswqd545hx36ajs8p29x6-scorecard-4.10.2
ls -la /nix/store/rqlnxxp7djzfswqd545hx36ajs8p29x6-scorecard-4.10.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

scorecard

Maintainer pings
cc @06kellyjac for testing.

@ofborg build scorecard scorecard.passthru.tests

Result of nixpkgs-review pr 207582 run on x86_64-linux 1

1 package built:

scorecard

@ofborg build scorecard scorecard.passthru.tests

this doesn't do anything, right? I don't see any tests for this package.

authors: r-ryantm raboof wegank


text:
cni-plugins: 1.1.1 -> 1.2.0

Description of changes
Update CNI plugins to their latest release.
cc @NixOS/podman @cstrahan
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


text:
trufflehog: 0 -> 1

Automatic update generated by nixpkgs-update tools.
meta.description for trufflehog is: Find credentials all over the place
meta.homepage for trufflehog is: https://github.com/trufflesecurity/trufflehog
meta.changelog for trufflehog is: https://github.com/trufflesecurity/trufflehog/releases/tag/v3.26.1
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1 with grep in /nix/store/7ksmisz2mj4rjp0dav1f1hdag7i2bf4a-trufflehog-3.26.1
found 1 in filename of file in /nix/store/7ksmisz2mj4rjp0dav1f1hdag7i2bf4a-trufflehog-3.26.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
trufflehog

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7ksmisz2mj4rjp0dav1f1hdag7i2bf4a-trufflehog-3.26.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A trufflehog https://github.com/r-ryantm/nixpkgs/archive/3a1e4da396b4ef3f0a497d70eb6390e7ca1ff69e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7ksmisz2mj4rjp0dav1f1hdag7i2bf4a-trufflehog-3.26.1
ls -la /nix/store/7ksmisz2mj4rjp0dav1f1hdag7i2bf4a-trufflehog-3.26.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

trufflehog

Maintainer pings
cc @fabaff for testing.

What the heck is this??

What the heck is this??

I am redoing it rn.

authors: JulienMalka r-ryantm wegank


text:
puddletag: fix wrapping

Description of changes
Closes #212738

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I'm not familiar with qt stuff, so I'd appreciate a review from someone who actually knows best practices for that ecosystem.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1826

Hi! I was referring to the comment https://github.com/NixOS/nixpkgs/issues/212738#issuecomment-1410761903.
Do you also observe the crash when checking About? (I think this is unrelated to this PR, but should be fixed).

Yes:
Traceback (most recent call last):
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/mainwin/funcs.py", line 493, in show_about
    win = about.AboutPuddletag(parent)
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/about.py", line 97, in __init__
    ['%s: %s' % (lib, version) for (lib, version) in versions().items()]
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/about.py", line 67, in versions
    'Chromaprint': get_module_version('chromaprint'),
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/about.py", line 50, in get_module_version
    module = import_module(module_name)
  File "/nix/store/abax98471z8fshv4b9p46bkh3lxmpy0z-python3-3.10.9/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/nix/store/hn3l9hgbh202vs0h3mi993zv0k6l1bbh-python3.10-pyacoustid-1.2.2/lib/python3.10/site-packages/chromaprint.py", line 57, in <module>
    raise ImportError("couldn't find libchromaprint")
ImportError: couldn't find libchromaprint
zsh: IOT instruction (core dumped)  ./result/bin/puddletag

I'm not sure how to go about fixing it, though.

authors: dschrempf nixos-discourse tejing1


text:
haven-cli: 3.0.3 -> 3.0.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/haven-protocol-org/haven-main/releases.
meta.description for haven-cli is: Haven Protocol is the world's only network of private stable asset
meta.homepage for haven-cli is: https://havenprotocol.org/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.0.7 with grep in /nix/store/rdja5bbwk5c17ciw1a7p0h8mysm9vasq-haven-cli-3.0.7
found 3.0.7 in filename of file in /nix/store/rdja5bbwk5c17ciw1a7p0h8mysm9vasq-haven-cli-3.0.7

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
haven-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rdja5bbwk5c17ciw1a7p0h8mysm9vasq-haven-cli-3.0.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A haven-cli https://github.com/r-ryantm/nixpkgs/archive/bd8129db33fad5ea274002240e8ac29d82958df5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rdja5bbwk5c17ciw1a7p0h8mysm9vasq-haven-cli-3.0.7
ls -la /nix/store/rdja5bbwk5c17ciw1a7p0h8mysm9vasq-haven-cli-3.0.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

haven-cli

Maintainer pings
cc @kim0 for testing.

The x86_64-darwin failure isn't new, so merging.

authors: r-ryantm wegank


text:
Small fixups

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@AndersonTorres please don't just disregard the reviews

I didn't disregard them.

You only replied to the reviews and left no time to get a response from us.

This is not the first time you've done this, in https://github.com/NixOS/nixpkgs/pull/143042 you chose to ignore both @SuperSandro2000 and my reviews and merged the pull request without sufficient communication.

authors: AndersonTorres figsoda


text:
termusic: 0.7.8 -> 0.7.9

Description of changes
Supersedes #217429.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thank you!

authors: devhell wegank


text:
python310Packages.goodwe: 0.2.26 -> 0.2.27

Diff: https://github.com/marcelblijleven/goodwe/compare/refs/tags/v0.2.26...v0.2.27
Changelog: https://github.com/marcelblijleven/goodwe/releases/tag/v0.2.27
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 218256 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.goodwe
python310Packages.goodwe
python311Packages.goodwe


text:
python3Packages.curio: Fix Linux build

In one of our internal mass rebuilds at work we noticed this package fail on Linux and the two tests that failed were exactly the ones that had already been disabled on macOS, so this also disables them on Linux.
Things done

Built on platform(s)

[x] x86_64-linux

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Fits CONTRIBUTING.md.

Hydra is able to build it (https://hydra.nixos.org/eval/1791378?filter=curio&compare=1791358&full=). Works for me locally for Python 10 and Python 3.11 as well on x86-64.

Is there a downside to merging this?
My reasoning is that we can definitely reproduce the failure in our own Linux in our own environment for the exact same two tests which failed on Darwin.  This suggests that whatever issue affected Darwin can also strike on Linux even if it doesn't happen to strike on Hydra or your development environment specifically.
My guess is that those two tests are sensitive to some host environment impurity, so they should be disabled regardless.

Do you run by any chance kernel 6.0.X? If so you should up or downgrade immediately because the versions from 6.0.16 to 6.0.19 have broken error handling for the bind syscall.

The Linux kernel version on the machine in question is 5.10.88

Then I am out of ideas, but it should be okay to disable two tests here. I've pushed the commit onto python-updates.


text:
someblocks: init at 1.0.1

Description of changes
someblocks is a modular status bar for somebar, based on dwmblocks.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Closes #219537

Package builds successfully.
gabriel@pop-os:/tmp$ nix-build $NIXPKGS -A someblocks
/nix/store/gyjd7malmh6j34pn4iav3a74w4sqqdh3-someblocks-1.0.1
gabriel@pop-os:/tmp$ ls result
bin  share
gabriel@pop-os:/tmp$ tree result
result
├── bin
│   └── someblocks
└── share
    └── man
        └── man1
            └── someblocks.1.gz


text:
tcsh: 6.24.07 -> 6.24.10

Description of changes
https://github.com/tcsh-org/tcsh/compare/TCSH6_24_07...TCSH6_24_10

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2114

authors: foo-dogsquared nixos-discourse


text:
nodePackages: @shopify/cli init at 3.45.1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228894 run on x86_64-linux 1

60 packages built:

antennas
balanceofsatoshis
bat-extras.prettybat
bitwarden-cli
castnow
commitlint
concurrently
create-cycle-app
discourse
discourseAllPlugins
emacsPackages.lsp-bridge
emanote
emanote.data
epgstation
fast-cli
flexoptix-app
google-clasp
graphite-cli
joplin
lighthouse
lv_img_conv
morgen
openmoji-black
openmoji-color
pm2
postcss-cli
pulsar
pyright
python310Packages.nbdev
python310Packages.nbdev.dist
python311Packages.nbdev
python311Packages.nbdev.dist
quarto
redoc-cli
shepherd
slack
teams
theLoungePlugins.plugins.closepms
theLoungePlugins.themes.flat-blue
theLoungePlugins.themes.flat-dark
thelounge
triton
uppy-companion
vimPlugins.coc-prettier
vimPlugins.coc-pyright
vimPlugins.coc-stylelint
vimPlugins.coc-sumneko-lua
vimPlugins.coc-vetur
vimPlugins.markdown-preview-nvim
vscode
vscode-extensions.ms-python.vscode-pylance
vscode-extensions.rust-lang.rust-analyzer
vscode-fhs
vscode-with-extensions
vscodium
vscodium-fhs
wasm-text-gen
wrangler
yaml-language-server
zx


text:
linuxKernel.kernels: update

linux: 4.14.315 -> 4.14.316
linux: 4.19.283 -> 4.19.284
linux: 5.10.180 -> 5.10.181
linux: 5.15.113 -> 5.15.114
linux: 5.4.243 -> 5.4.244
linux: 6.1.30 -> 6.1.31
linux: 6.3.4 -> 6.3.5
linux-rt_5_15: 5.15.111-rt63 -> 5.15.113-rt64
linux_latest-libre: 19299 -> 19308
linux/hardened/patches/4.14: 4.14.314-hardened1 -> 4.14.315-hardened1
linux/hardened/patches/4.19: 4.19.282-hardened1 -> 4.19.283-hardened1
linux/hardened/patches/5.10: 5.10.179-hardened1 -> 5.10.180-hardened1
linux/hardened/patches/5.15: 5.15.111-hardened1 -> 5.15.112-hardened1
linux/hardened/patches/5.4: 5.4.242-hardened1 -> 5.4.243-hardened1
linux/hardened/patches/6.1: 6.1.28-hardened1 -> 6.1.29-hardened1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235010 run on x86_64-linux 1

6 packages marked as broken and skipped:

linuxKernel.kernels.linux_4_14_hardened
linuxKernel.kernels.linux_4_14_hardened.dev
linuxKernel.kernels.linux_4_19_hardened
linuxKernel.kernels.linux_4_19_hardened.dev
linuxKernel.kernels.linux_5_4_hardened
linuxKernel.kernels.linux_5_4_hardened.dev

22 packages built:

linuxKernel.kernels.linux_4_14
linuxKernel.kernels.linux_4_14.dev
linuxKernel.kernels.linux_4_19
linuxKernel.kernels.linux_4_19.dev
linuxKernel.kernels.linux_5_10
linuxKernel.kernels.linux_5_10.dev
linuxKernel.kernels.linux_5_10_hardened
linuxKernel.kernels.linux_5_10_hardened.dev
linuxKernel.kernels.linux_5_15
linuxKernel.kernels.linux_5_15.dev
linuxKernel.kernels.linux_5_15_hardened
linuxKernel.kernels.linux_5_15_hardened.dev
linuxKernel.kernels.linux_5_4
linuxKernel.kernels.linux_5_4.dev
linuxKernel.kernels.linux_hardened (linuxKernel.kernels.linux_6_1_hardened)
linuxKernel.kernels.linux_hardened.dev (linuxKernel.kernels.linux_6_1_hardened.dev)
linuxKernel.kernels.linux_6_3
linuxKernel.kernels.linux_6_3.dev
linuxKernel.kernels.linux_latest_libre
linuxKernel.kernels.linux_latest_libre.dev
linuxKernel.kernels.linux_rt_5_15
linuxKernel.kernels.linux_rt_5_15.dev

All kernels build, 6.1 and 6.3 boot, I think we can merge this.


text:
signalbackup-tools: 20230528-1 -> 20230531

Description of changes
Update to latest version. No changes that effect build (diff: https://github.com/bepaald/signalbackup-tools/compare/20230528-1...20230531).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235236 run on x86_64-darwin 1

1 package built:

signalbackup-tools

Result of nixpkgs-review pr 235236 run on aarch64-darwin 1

1 package built:

signalbackup-tools


text:
python311Packages.teslajsonpy: 3.8.1 -> 3.9.0

Diff: https://github.com/zabuldon/teslajsonpy/compare/refs/tags/v3.8.1...v3.9.0
Changelog: https://github.com/zabuldon/teslajsonpy/releases/tag/v3.9.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 237293 run on x86_64-linux 1

4 packages built:

python310Packages.teslajsonpy
python310Packages.teslajsonpy.dist
python311Packages.teslajsonpy
python311Packages.teslajsonpy.dist


text:
helm-ls: 0.0.3 -> 0.0.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mrjosh/helm-ls/releases.
meta.description for helm-ls is: Language server for Helm
meta.homepage for helm-ls is: https://github.com/mrjosh/helm-ls
meta.changelog for helm-ls is: https://github.com/mrjosh/helm-ls/releases/tag/v0.0.4
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.0.4 with grep in /nix/store/fdssbhyb1nn898khwg0vj0bgqb5f79qv-helm-ls-0.0.4
found 0.0.4 in filename of file in /nix/store/fdssbhyb1nn898khwg0vj0bgqb5f79qv-helm-ls-0.0.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
helm-ls

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fdssbhyb1nn898khwg0vj0bgqb5f79qv-helm-ls-0.0.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A helm-ls https://github.com/r-ryantm/nixpkgs/archive/32161d359e6d4346bb3d4c4f16ca66272bbe7fec.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fdssbhyb1nn898khwg0vj0bgqb5f79qv-helm-ls-0.0.4
ls -la /nix/store/fdssbhyb1nn898khwg0vj0bgqb5f79qv-helm-ls-0.0.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

helm-ls

Maintainer pings
cc @stehessel for testing.

Result of nixpkgs-review pr 238299 run on aarch64-darwin 1

1 package built:

helm-ls


text:
anytype: 0.31.0 -> 0.32.3

Description of changes
https://community.anytype.io/t/anytype-desktop-0-32-0-released/9468
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build anytype

@ofborg eval


text:
python310Packages.gprof2dot: 2021.02.21 -> 2022.07.29

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.gprof2dot is: Python script to convert the output from many profilers into a dot graph
meta.homepage for python310Packages.gprof2dot is: https://github.com/jrfonseca/gprof2dot
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2022.07.29 in filename of file in /nix/store/ylbbs2l9gjpldjc2njid8zivf5kh576p-python3.10-gprof2dot-2022.07.29

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
gprof2dot
python310Packages.django-silk
python310Packages.gprof2dot
python311Packages.django-silk
python311Packages.gprof2dot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ylbbs2l9gjpldjc2njid8zivf5kh576p-python3.10-gprof2dot-2022.07.29 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.gprof2dot https://github.com/r-ryantm/nixpkgs/archive/06f188a5fa33b705e21fee0cf4a3c3dec067c911.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/06f188a5fa33b705e21fee0cf4a3c3dec067c911#python310Packages.gprof2dot

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ylbbs2l9gjpldjc2njid8zivf5kh576p-python3.10-gprof2dot-2022.07.29
ls -la /nix/store/ylbbs2l9gjpldjc2njid8zivf5kh576p-python3.10-gprof2dot-2022.07.29/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

gprof2dot (python310Packages.gprof2dot)
python310Packages.django-silk
python311Packages.django-silk
python311Packages.gprof2dot

Maintainer pings
cc @pmiddend for testing.

Result of nixpkgs-review pr 255647 run on x86_64-linux 1

8 packages built:

gprof2dot (python310Packages.gprof2dot)
gprof2dot.dist (python310Packages.gprof2dot.dist)
python310Packages.django-silk
python310Packages.django-silk.dist
python311Packages.django-silk
python311Packages.django-silk.dist
python311Packages.gprof2dot
python311Packages.gprof2dot.dist


text:
indent: 2.2.12 -> 2.2.13, add patches for CVE-2023-40305

Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2023-40305
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Delayed because I don't think the fix is complete, am chasing upstream.

Turns out that other bug is pre-existing and a fix should be coming. In the meantime this fix won't make it worse and will fix the more serious OOB write.

Oops.  I forgot to retarget branch, and the UI here got confusing.  (also GitHub skipped the PR mention)
I had merged this PR to staging-next in aa240b058d39e4

Ah this is https://savannah.gnu.org/bugs/?64751 which I'm still pursuing. Should disable the related test till that's fixed.

authors: risicle vcunat


text:
caprine-bin: remove redundant mainProgram specification

Description of changes
The meta.mainProgam attributes is already specified per-system (per-binary-file to be precise).
This partially reverts commit d26b1b2d4a5c0845f3aee6af86123a2c280c473a.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Wouldn't it make more sense to keep this and remove the attr from the per-system

@Artturin Sounds great. Updated.

authors: Artturin ShamrockLee


text:
restish: 0.18.0 -> 0.19.0

Diff: https://github.com/danielgtaylor/restish/compare/refs/tags/v0.18.0...v0.19.0
Changelog: https://github.com/danielgtaylor/restish/releases/tag/v0.19.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 259021 run on x86_64-linux 1

1 package built:

restish


text:
vitess: 17.0.3 -> 18.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/vitess/versions.
meta.description for vitess is: A database clustering system for horizontal scaling of MySQL
meta.homepage for vitess is: https://vitess.io/
meta.changelog for vitess is: https://github.com/vitessio/vitess/releases/tag/v18.0.1
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 18.0.1 with grep in /nix/store/m0ab0npdksji648wa15gbhl5dblx53vi-vitess-18.0.1
found 18.0.1 in filename of file in /nix/store/m0ab0npdksji648wa15gbhl5dblx53vi-vitess-18.0.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vitess

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m0ab0npdksji648wa15gbhl5dblx53vi-vitess-18.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vitess https://github.com/r-ryantm/nixpkgs/archive/6e16e774e62fa658b915f7a7d927847b562c32fb.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6e16e774e62fa658b915f7a7d927847b562c32fb#vitess

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m0ab0npdksji648wa15gbhl5dblx53vi-vitess-18.0.1
ls -la /nix/store/m0ab0npdksji648wa15gbhl5dblx53vi-vitess-18.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vitess

Maintainer pings
cc @urandom2 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/vitess/versions.
meta.description for vitess is: A database clustering system for horizontal scaling of MySQL
meta.homepage for vitess is: https://vitess.io/
meta.changelog for vitess is: https://github.com/vitessio/vitess/releases/tag/v18.0.2
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 18.0.2 with grep in /nix/store/larx3jn0pgx9ja64dbaarqraxxcyya2v-vitess-18.0.2
found 18.0.2 in filename of file in /nix/store/larx3jn0pgx9ja64dbaarqraxxcyya2v-vitess-18.0.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vitess

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/larx3jn0pgx9ja64dbaarqraxxcyya2v-vitess-18.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vitess https://github.com/r-ryantm/nixpkgs/archive/0b1884bfbf21b35cda226fe6ecc00b0057a2abca.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0b1884bfbf21b35cda226fe6ecc00b0057a2abca#vitess

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/larx3jn0pgx9ja64dbaarqraxxcyya2v-vitess-18.0.2
ls -la /nix/store/larx3jn0pgx9ja64dbaarqraxxcyya2v-vitess-18.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vitess

Maintainer pings
cc @urandom2 for testing.


text:
bun: 1.0.17 -> 1.0.18

Description of changes
Wanted to test the new lifecycle stuff of Bun, so here the update for nixpkgs :)
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274722 run on x86_64-linux 1

1 package built:

bun

authors: bachp shyim


text:
polylux2pdfpc: init at 0.3.1

Description of changes

Small tool to convert metadata in PDF presentations made in typst with polylux to a format pdfpc can understand.
https://github.com/andreasKroepelin/polylux
Tool is located under the pdfpc-extrator directory.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Do you think you could make it work on aarch64-darwin as well ?

@drupol Hm... I'm not sure if I know how to do that. What do I need to add to the derivation?
And is it possible to test if it works from a linux machine?

I have the feeling that it's an unrelated issue. Going to merge it as it is.

Thanks for making the PR, it is now merged. I believe we won't have to use it much since there's a PR in Polylux to extract those data without using any external tool. See: https://github.com/andreasKroepelin/polylux/pull/123

authors: diogotcorreia drupol


text:
cudaPackages: __structuredAttrs works with autoPatchelf since #272752

Description of changes

#272752 introduced support for using __structuredAttrs with autoPatchelf to ignore dependencies.
This PR updates use-sites across cudaPackages to switch away from the env workaround.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

[!Note]
Template nixpkgs-review command:
PR=281376; \
SYSTEM="aarch64-linux"; \
CUDA_SUPPORT="true"; \
CUDA_CAPABILITIES='[ "7.5" ]'; \
nixpkgs-review pr "$PR" \
  --system "$SYSTEM" \
  --no-shell \
  --checkout commit \
  --allow aliases \
  --build-args "--max-jobs 1" \
  --skip-package-regex 'python3(\d){1,2}Packages\.(pytorch-pfn-extras|ffcv)' \
  --skip-package-regex 'python3(\d){1,2}Packages\.(shap|mlflow|optuna)' \
  --extra-nixpkgs-config "{
    allowUnfree = true;
    allowBroken = false;
    cudaSupport = ${CUDA_SUPPORT:-false};
    cudaCapabilities = ${CUDA_CAPABILITIES:-[]};
  }"

The packages python3Packages.{pytorch-pfn-extras,shap} are excluded because their checkPhase runs for multiple hours -- other excluded packages are dependent on these, and nixpkgs-review does not handle transitive dependencies, so we must find them ourselves.
Template log archival command:
PR=281376; \
RUN_NUMBER=13; \
SYSTEM="aarch64-linux"; \
CUDA_CAPABILITIES="7_5"; \
tar -cvf "$SYSTEM-cap-$CUDA_CAPABILITIES-pr-$PR-$RUN_NUMBER.tar.zst" \
  -I "zstd -T0 --ultra -22" \
  -C "$HOME/.cache/nixpkgs-review/pr-$PR-$RUN_NUMBER" \
  .

Logs are made available at https://drive.google.com/drive/folders/1GgABhwa2ooKeZXMqf5He6PcyClNrE6cQ?usp=share_link

:clock1: aarch64-darwin
In progress.
:clock1: x86_64-darwin
In progress.
:clock1: aarch64-linux
:clock1: CUDA (Jetson)
In progress.
:clock1: CUDA (Non-Jetson)
In progress.
:clock1: Non-CUDA
In progress.
:clock1: x86_64-linux
:clock1: CUDA (Non-Jetson)
In progress.
:clock1: Non-CUDA
In progress.

Reformatted with the latest nixfmt (https://github.com/piegamesde/nixfmt/commit/1eff7a84ac82fbebb5f586244f1c80e1fcc4f494).


text:
Nixpkgs config: NIXPKGS_CONFIG ->

Motivation for this change
Fixes https://github.com/NixOS/nixpkgs/issues/28085.

Expand documentation for nixpkgs config in a similar fashion to https://github.com/NixOS/nixpkgs/pull/28082
Throw an error if potential config files are not files as expected.
Change NIXPKGS_CONFIG to <nixpkgs-config> throughout.

I believe this is behaviour preserving except for:

Anyone who consumes NIXPKGS_CONFIG (not clear why you would do this)
Anyone who separately sets NIXPKGS_CONFIG.
Anyone who clears their NIX_PATH on a NixOS system rather than extending it. In particular, users of the nix.nixPath option.

Possibly we could make things easier for the second set of people by continuing to honour NIXPKGS_CONFIG for a while with a warning, but I'm not sure if it's worth it.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Note that contra my claim in https://github.com/NixOS/nixpkgs/issues/28085, adding this to nix.nixPath does put it in the environment for users too.

What does this do for users of nix.nixPath?

Setting nix.nixPath overwrites the default, so if you want any of the default bits you have to copy them over yourself. This adds to the default value, so anyone using it won't get that, where they probably would have got NIXPKGS_CONFIG.
I'm not sure there's much we can do about this, short of making nix.nixPath configurable as an attribute set which could then be merged with the default. However, I don't think it's a bit problem, since it seems like almost nobody uses NIXPGS_CONFIG, since it's undocumented.

That's what I thought, thank you for explaining.

I've also added a nixos release note, since this is technically a breaking change.

I like the change but I'm not sure if this should make 17.09. Has anybody tested this yet?

Yeah, I was somewhat putting this up for discussion - it only really makes things more consistent, rather than bringing any concrete improvement.
I think putting this in after the branch-off would make sense. I'll update it and test it a bit more when that happens.

Do we think this is still desirable? I think so, but I don't feel strongly about it

Pinging the status on this. Is this something we really want? We may be able to do this for 18.09

authors: fpletz matthewbauer michaelpj vyp


text:
python311Packages.crytic-compile: 0.3.5 -> 0.3.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.crytic-compile is: Abstraction layer for smart contract build systems
meta.homepage for python311Packages.crytic-compile is: https://github.com/crytic/crytic-compile
meta.changelog for python311Packages.crytic-compile is: https://github.com/crytic/crytic-compile/releases/tag/0.3.6
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.6 with grep in /nix/store/qw5iama8knj8vn1fzdg3qflkhjzmrzam-python3.11-crytic-compile-0.3.6
found 0.3.6 in filename of file in /nix/store/qw5iama8knj8vn1fzdg3qflkhjzmrzam-python3.11-crytic-compile-0.3.6

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
echidna
python311Packages.crytic-compile
python311Packages.slither-analyzer
python312Packages.crytic-compile
slither-analyzer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qw5iama8knj8vn1fzdg3qflkhjzmrzam-python3.11-crytic-compile-0.3.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.crytic-compile https://github.com/r-ryantm/nixpkgs/archive/dce88117e14afdb8462acbf83bd2d84cfbb1bcbc.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/dce88117e14afdb8462acbf83bd2d84cfbb1bcbc#python311Packages.crytic-compile

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qw5iama8knj8vn1fzdg3qflkhjzmrzam-python3.11-crytic-compile-0.3.6
ls -la /nix/store/qw5iama8knj8vn1fzdg3qflkhjzmrzam-python3.11-crytic-compile-0.3.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

echidna
python311Packages.crytic-compile
slither-analyzer (python311Packages.slither-analyzer)
python312Packages.crytic-compile

Maintainer pings
cc @arcz @hellwolf for testing.

@ofbory build crytic-compile

authors: hellwolf r-ryantm


text:
abuse: 0.8 -> 0.9.1

Description of changes
Fixes #287934-
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 288145 run on aarch64-linux 1

1 package built:

abuse

authors: iblech wegank


text:
coin3d: include fix for newer compilers

This manifests as a segfault in any applications that use the library.
Motivation for this change
Without this, FreeCAD just segfaults when started.  Thus, this is somehow also related to #28643, since FreeCAD builds, but does not run correctly without this.
Things done
Created a patch that fixes this issue.  See the comments in the commit for references.

Built FreeCAD without this patch and run -> segfault
Built FreeCAD and coin3d with this patch -> no segfault

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @viric

Thanks!


text:
staging-next 2024-03-01

Helpful links

workflow docs: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging
important jobs:
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
jobsets:
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
nix-review reports: https://malob.github.io/nix-review-tools-reports/
previous staging-next: https://github.com/NixOS/nixpkgs/pull/289734

Mass breakages

[x] libbacktrace is failing since xz: 5.4.6 -> 5.6.0; https://github.com/ianlancetaylor/libbacktrace/issues/118;

(will be edited based on progress)

There's an inconsequential pkgs/by-name check failure with this PR, here's a PR to fix it though: https://github.com/NixOS/nixpkgs/pull/292674

I suspect that would say to install everything into $dev, which wouldn't be what we want.

[ ] python3Packages.debugpy tests hang
https://hydra.nixos.org/build/252462132
Looks like a reproducible regression against nixpkgs master, for both linuxes and both pythons
maintainer: @kira-bruneau

A regularly complaint about debugpy tests: https://github.com/NixOS/nixpkgs/issues/262000

Oh OK, let me disable them for now: e0008b48c915

Overall I don't expect large improvements within days, so let's merge.

authors: infinisil mweinelt vcunat


text:
Add system_cmds apple project

Actually just build sysctl for now, as xcbuild segfaults.

Can you reference facebook/xcbuild#188 in the comment? There’s some investigation there on what’s going on there.

authors: matthewbauer shlevy


text:
rPackages.raer: fix deps

Description of changes
Added missing sysdeps
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.
raer? nem er ra

@ofborg build rPackages.raer

Builds and loads successfully on aarch64-linux

authors: Kupac b-rodrigues jbedo


text:
spacedrive: 0.2.4 -> 0.2.13

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for spacedrive is: An open source file manager, powered by a virtual distributed filesystem
meta.homepage for spacedrive is: https://www.spacedrive.com
meta.changelog for spacedrive is: https://github.com/spacedriveapp/spacedrive/releases/tag/0.2.13
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.2.13 with grep in /nix/store/pm7zn0iv4g25npsbs6z9j2fwapsw47wc-spacedrive-0.2.13
found 0.2.13 in filename of file in /nix/store/pm7zn0iv4g25npsbs6z9j2fwapsw47wc-spacedrive-0.2.13

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

spacedrive

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pm7zn0iv4g25npsbs6z9j2fwapsw47wc-spacedrive-0.2.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A spacedrive https://github.com/r-ryantm/nixpkgs/archive/8a74634fe7e088a6d123d0c4ffa86f85834416ec.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8a74634fe7e088a6d123d0c4ffa86f85834416ec#spacedrive

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pm7zn0iv4g25npsbs6z9j2fwapsw47wc-spacedrive-0.2.13
ls -la /nix/store/pm7zn0iv4g25npsbs6z9j2fwapsw47wc-spacedrive-0.2.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

spacedrive

Maintainer pings
cc @DataHearth @heisfer @MikaelFangel @stepbrobd for testing.

Result of nixpkgs-review pr 307301 run on x86_64-darwin 1

1 package built:

spacedrive

aarch64-darwin and x86_64-darwin was not updated
Superseded by #307630

authors: DataHearth r-ryantm stepbrobd


text:
nixos/jenkins: add tmpfile rule

Necessary for jenkins socket
https://www.github.com/jenkinsci/packaging/issues/455
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Although upstream also uses systemd-tmpfilse to manage the directory shouldn't RuntimeDirectory=jenkins in the service unit essentially do the same thing?  https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#RuntimeDirectory=

Although upstream also uses systemd-tmpfilse to manage the directory shouldn't RuntimeDirectory=jenkins in the service unit essentially do the same thing? freedesktop.org/software/systemd/man/latest/systemd.exec.html#RuntimeDirectory=

True, Changed and suggested it here https://www.github.com/jenkinsci/packaging/pull/442/files#r1649505949

Please reword commit message.

Changed the commit name via squash merge

authors: Aleksanaa Artturin fpletz


text:
gnome-podcasts: 0.6.1 -> 0.7.1

Description of changes
Changelog: https://gitlab.gnome.org/World/podcasts/-/blob/0.7.1/CHANGELOG.md
Diff: https://gitlab.gnome.org/World/podcasts/-/compare/0.6.1...0.7.1

Adding glib-networking fixes:
(gnome-podcasts:191149): Adwaita-CRITICAL **: 22:36:45.203: Page 'Command Control Power: Apple Tech Support & Business Talk' is not in the navigation stack

 ERROR podcasts_gtk::widgets::player    > gstreamer error: Error from element /GstPlayBin3:playbin3/GstURIDecodeBin3:uridecodebin3/GstURISourceBin:urisourc
ebin0/GstSoupHTTPSrc:souphttpsrc2: GStreamer encountered a general stream error.
Internal data stream error.
../libs/gst/base/gstbasesrc.c(3177): gst_base_src_loop (): /GstPlayBin3:playbin3/GstURIDecodeBin3:uridecodebin3/GstURISourceBin:urisourcebin0/GstSoupHTTPSr
c:souphttpsrc2:
streaming stopped, reason error (-5) Some(
    Structure(
        details {
            flow-return: (gint) -5,
        },
    ),
)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks.

authors: Aleksanaa jtojnar


text:
treewide: cargoSha256 -> cargoHash

limited to pkgs/applications to limit merge-conflicts, done with
rg 'cargoSha256 = "sha256-' pkgs/applications/ -l | grep \\\.nix$ | xargs grep buildRustPackage -l | xe sd 'cargoSha256 = "sha256-' 'cargoHash = "sha256-'

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/NixOS/nixpkgs/pull/329763#issuecomment-2249126607