text:
optimize rendering KeyboardShortcutsModal

Details
Move KeyboardShortcutsModal from BaseScreenWrapper to BaseSidebarScreen
Fixed Issues
$ https://github.com/Expensify/App/issues/12116
PROPOSAL: https://github.com/Expensify/App/issues/12116#issuecomment-1291548767
Tests

Login with any account on web/desktop
On any page, press CTRL + I (keyboard shortcut)
Verify that keyboard shortcut modal appears
Resize the window to a minimum
Verify that another keyboard shortcut modal doesn't appear

[x] Verify that no errors appear in the JS console

QA Steps

Login with any account on web/desktop
On any page, press CTRL + I (keyboard shortcut)
Verify that keyboard shortcut modal appears
Resize the window to a minimum
Verify that another keyboard shortcut modal doesn't appear

[ ] Verify that no errors appear in the JS console

PR Review Checklist
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots
Web
https://user-images.githubusercontent.com/97473779/199804607-65548175-11ec-402e-86d6-0a18cea39fb7.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/97473779/199813461-ae561cd8-87da-4553-9d79-cf70a0d870b5.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/97473779/199813406-e23f43de-9717-428f-9eb1-f81810d2cade.mp4
Desktop
https://user-images.githubusercontent.com/97473779/199804683-a8f29476-1f89-45a9-82c2-c63c9bdb267a.mov
iOS
https://user-images.githubusercontent.com/97473779/199813321-128edc88-d69f-4f1a-a7be-1197636b4127.mp4
Android
https://user-images.githubusercontent.com/97473779/199813247-d6998f6e-b89c-4ac3-a755-9951cf13e43e.mp4

You can just add videos of the working app for the platforms which don't support this modal.

Reviewing.

Tests passed. Removing Emergency label.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @luacmartins in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This PR ended up creating this bug https://github.com/Expensify/App/issues/13871, so I am moving the modal to ReportScreen which doesn't seem to have the same bug as the original bug linked here.

authors: 0xmiroslav OSBotify luacmartins parasharrajat pecanoro


text:
Fix padding above time stamp in report view

Details

Fixes the padding above the time stamp in the report view.
Fixed Issues

$ https://github.com/Expensify/App/issues/23187
TEST / QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Open chat with a timestamp, ensure that padding between a report action and the timestamp is correct.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Chrome emulator is broken, sorry

Mobile Web - Safari

Desktop

iOS

Android

@eVoloshchak this is a deploy blocker, could you please prioritize this review if possible? 🙏

I am available right now to review this

@situchan assigned, thank you!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@situchan committed your suggestion

@deetergp bump on this deploy blocker fix

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

source: gharchive/pull-request

authors: OSBotify grgia situchan

repo: Expensify/App

license: MIT

license_type: permissive

license_source: github-api


text:
Add top padding to the taxes and tags settings page description

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38547
PROPOSAL:
Tests

Check that the Categories, Tags, Distances, Taxes pages all have the same padding around the header text

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify getusha mountiny


text:
[CP Staging] Use default value for personalDetails in OptionListContextProvider

This PR is based on contributor @suneox 's https://github.com/Expensify/App/pull/41356, but they don't have signed commits enabled. I forked the branch and amended the commit so that it's signed.
Details
Use a default empty object for personal details in OptionListContextProvider, to prevent a crash after clearing cached data.
Fixed Issues
$ https://github.com/Expensify/App/issues/41275
PROPOSAL: https://github.com/Expensify/App/issues/41275#issuecomment-2084258468
Tests

Create a room
Invite a member to the room
Go to Account settings > Troubleshoot
Click Clear cache and restart
Click Reset and refresh
Verify that the app does not crash

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps

Create a room
Invite a member to the room
Go to Account settings > Troubleshoot
Click Clear cache and restart
Click Reset and refresh
Verify that the app does not crash

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/11959869/c77ac706-f678-4aa7-8249-3ece7146e671

Android: mWeb Chrome
https://github.com/Expensify/App/assets/11959869/ad73c292-5691-42de-ad4b-656e205a5185

MacOS: Safari
https://github.com/Expensify/App/assets/11959869/ae8c5b37-2f57-4ca2-83e5-7d7f6f181d8f

MacOS: Desktop
https://github.com/Expensify/App/assets/11959869/1c003d06-040a-4dec-9af1-b4c381d0f37b

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/11959869/442c63e2-4e51-4b2f-82e3-c23cc607c02b

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.68-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify francoisl luacmartins


text:
[WIP] Don't quote booleans in GITHUB_OUTPUT

Details

Fixed Issues

$
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

from local testing w/ act the quotes vs no quotes doesn't matter. These quotes aren't necessary, but they don't seem to be the root of a problem


text:
Remove "Let's get you set up 🔧 " line during onboarding

Please see this Slack thread for more details (and what I'm trying to do!):  https://expensify.slack.com/archives/C07HPDRELLD/p1731966744741239

Explanation of Change

Fixed Issues

$
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@marcaaron i probably messed some part of this up, but the linked Slack convo will show you exactly what we're trying to do, thank you!

Do the QA steps look OK, as well?

Looks like everything is passing here. Tested locally and looking good.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

authors: OSBotify jamesdeanexpensify marcaaron


text:
[No QA] Create OfflineUX.md file

Details

This is the OfflineUX.md file, which will describe our Offline UX patterns and provide useful examples and resources for those seeking to implement them.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/211555

IDK if people are interested, but GitHub has built-in support for creating diagrams in markdown via mermaid. Of course, it's a more limited than other diagramming tools, but may be good in cases where a diagram is used as part of "living documentation", because then we can adjust the diagram as needed with pull requests without needing access to the original diagram tool and/or file. Here's a demo of what it might look like for the Offline Patterns decision tree:
graph TD;
    Q1(1. Does the feature interact with the server?)
    Q2(2. What type of request is being made?)
    Q3(3. Is it OK for the user to see stale data?)
    Q4(4. Is the UI a form?)
    Q5(5. Can the server response be anticipated?)
    Q6(6. Is there validation done on the server?)
    Q7(7. Does the user need to know if the action was successful?)

    AN((NO OFFLINE UI PATTERNS NEEDED))
    class AN answer;
    style AN stroke:#0185ff;

    AA((Optimistic UI WITHOUT Feedback Pattern))
    class AA answer;
    style AA stroke:#03d47c;

    AB((Optimistic UI WITH Feedback Pattern))
    class AB answer;
    style AB stroke:#fed607;

    AC((Blocking Form UI Pattern))
    class AC answer;
    style AC stroke:#ff7101;

    AD((Full Page Blocking UI Pattern))
    class AD answer;
    style AD stroke:#fc3826;

    Q1-- Yes -->Q2
    Q1-- No -->AN

    Q2-- READ -->Q3
    Q2-- WRITE -->Q5

    Q3-- Yes ----> AN
    Q3-- No --> Q4

    Q4-- No --> AD
    Q4-- Yes --> AC

    Q5-- Yes --> Q6
    Q5-- No --> Q4

    Q6-- Yes --> Q4
    Q6-- No --> Q7

    Q7-- Yes --> AB
    Q7-- No --> AA

    classDef answer stroke-width:6px;

We could probably do more to customize the diagram as we see fit, but I figured this was a good place to stop to pitch the idea to see what people think. This particular diagram (hopefully) isn't likely to change any time soon, so it's not the end of the world if we prefer to just stick with the existing image. Still, it's a neat feature and I'm curious for people's thoughts!

Updated! That was a lot of suggestions! 😄

We could probably do more to customize the diagram as we see fit, but I figured this was a good place to stop to pitch the idea to see what people think.

@roryabraham interesting stuff, but don't think we should block on it and can always update it later if people prefer this

Thx Yuwen! Committed those

I'm gonna go ahead and self merge bc Marc, Yuwen, and Rory have all given overall 👍's or previously approved.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @yuwenmemon in version: 1.1.73-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: Luke9389 OSBotify marcaaron roryabraham


text:
Strange IE9 bug: Exception in callback of async function:TypeError: Object doesn't support property or method 'initAttrsAndRelations'

It works perfectly well in Chrome and Safari. But on IE9, it fails to retrieve data from mongodb and I got this error.
Exception in callback of async function:TypeError: Object doesn't support property or method 'initAttrsAndRelations'

Maybe it has to do with the way I do my class extends.. I did not use coffeescript.

source: gharchive/issue

repo: Exygy/minimongoid

license: mit

license_source: bigquery


text:
🛑 PR Medialogia is down

In 7033a62, PR Medialogia (https://pr.mlg.ru) was down:

HTTP code: 503
Response time: 867 ms

Resolved: PR Medialogia is back up in 6686fc2 after 14 minutes.


text:
"unable to validate certificate, invalid x509 file"

Environment

FAST RPM Version: 1.3.0
BIG-IP Version: 15.0.1.4

Summary
When you want to create an application and define a certificate + privateKey (PEM format) with FAST it doesn't work.
FAST give you a "declaration failed 01070712:3: unable to validate certificate, invalid x509 file" :
{
    "id": "68e01e2e-2e53-4670-b5bc-4d2f5605cb4d",
    "code": 200,
    "message": "no change\ndeclaration failed\n01070712:3: unable to validate certificate, invalid x509 file (/my_tenant/app_HTTPS_FRONT_HTTPS_BACK/app_HTTPS_FRONT_HTTPS_BACK_certificate.crt).",
    "name": "",
    "parameters": {},
    "tenant": "my_tenant",
    "application": "app_HTTPS_FRONT_HTTPS_BACK",
    "operation": "create"
}

Steps To Reproduce
Here is the template used :
definitions:
  tls_offload:
    type: boolean
  tls_front:
    type: boolean
  tls_back:
    type: boolean
  service_type_def :
    template: |
      {{#tls_offload}}
        "class": "Service_HTTPS",
      {{/tls_offload}}
      {{^tls_offload}}
        "class": "Service_HTTP",
      {{/tls_offload}}
  tls_def :
    template: |
      {{#tls_offload}}
        {{#tls_front}}
          "serverTLS": "{{application_name}}_tls_profile",
        {{/tls_front}}
        {{#tls_back}}
          "clientTLS": {
            "bigip": "/Common/serverssl"
          },
        {{/tls_back}}
      {{/tls_offload}}
  tls_server_def:
    template: |
      {{#tls_offload}}
        {{#tls_front}}
          "{{application_name}}_tls_profile": {
            "class": "TLS_Server",
            "certificates": [
              {
                "certificate": "{{application_name}}_certificate"
              }
            ]
          },
          "{{application_name}}_certificate": {
            "class": "Certificate",
            "certificate": "{{tls_server_certificate}}",
            "privateKey": "{{tls_server_private_key}}"
          },
        {{/tls_front}}
      {{/tls_offload}}
parameters:
  tls_offload: false
  tls_front: true
  tls_back: false
template: |
    {
      "class": "ADC",
      "schemaVersion": "3.19.0",
      "{{tenant_name}}": {
        "class": "Tenant",
        "{{application_name}}": {
          "class": "Application",
          "template": "generic",
          {{> tls_server_def}}
          "{{application_name}}_vs": {
            {{> service_type_def}}
            {{> tls_def}}
            "virtualPort": {{virtual_port::integer}},
            "virtualAddresses": [
              "{{virtual_address:f5:ipv4}}"
            ]
          }
        }
      }
    }

Here is the payload to create an application with a autogenerate cert :
{
    "name": "my_template/test_template_certificate",
    "parameters": {
        "tenant_name": "my_tenant",
        "application_name": "app_HTTPS_FRONT_HTTPS_BACK",
        "virtual_port": 443,
        "virtual_address": "20.1.1.50",
        "tls_offload": true,
        "tls_back": true,
        "tls_server_certificate": "-----BEGIN CERTIFICATE-----\n ... \n-----END CERTIFICATE-----",
        "tls_server_private_key": "-----BEGIN PRIVATE KEY-----\n ... \n-----END PRIVATE KEY-----"
        }
}

When I copy the rendered AS3 declaration with FAST and send it right to AS3, it works fine.

Escaped strings need special handling in FAST.
Try changing your cert and private key variables like so:
            "certificate": "{{tls_server_certificate::text}}",
            "privateKey": "{{tls_server_private_key::text}}"

This should work, awaiting resolution before closing.

Thanks for your feedbacks.
I've just tested with the type ::text and it doesn't work either.
Here is the message :
{
    "code": 400,
    "message": "failed to render template: Pole_Emploi/not_working_https_template\nmissed comma between flow collection entries at line 19, column 30:\n                \"certificate\": \"\"-----BEGIN CERTIFICATE-----\\nMII ... \n                                 ^"
}

Rendering doesn't seems to work (in API and GUI)

Apologies ben, my example was wrong, those lines should look like this:
            "certificate": {{tls_server_certificate::text}},
            "privateKey": {{tls_server_private_key::text}}

The text type runs a JSON stringify on the contents of the string, and puts quotes around it for you.

In addition to handling newlines, the text type automatically outputs quoted strings. In other words, the template text should instead be:
...
            "certificate": {{tls_server_certificate::text}},
            "privateKey": {{tls_server_private_key::text}}
...

Thanks ! I've removed the double quote and it worked like a charm :)


text:
[RFE] "chargebackTag" attribute for License class

Is your feature request related to a problem? Please describe.
The BIG-IQ API supports a "chargebackTag" field when requesting a new license.
We can't specify the field when configuring a BIG-IP via DO.
This request is similar to https://github.com/F5Networks/f5-declarative-onboarding/issues/72
In that case the request was to include the "Tenant" field.
Describe the solution you'd like
Update the License Class on the API to include "chargebackTag" field
Describe alternatives you've considered
None.
Additional context
Here is an example of the API on the BIG-IQ:
[root@bigiq-cm1:Active:Standalone] ~ # restcurl /cm/device/tasks/licensing/pool/member-management/example
[...]
      "address": "example string",
      "port": 2147483647,
      "user": "example string",
      "password": "example string",
      "macAddress": "example string",
      "hypervisor": "example string",
      "tenant": "example string",
      "assignmentType": "MANAGED",
      "skuKeyword1": "example string",
      "skuKeyword2": "example string",
      "unitOfMeasure": "example string",
      "chargebackTag": "example string",    <----- here
[...]

Thank you for your feedback. I have added this request to our internal product backlog as AUTOTOOL-2675.

This was resolved with the 1.24.0 release of Declarative Onboarding.


text:
Update .travis.yml

Fixes #1067
@jlongstaf
What issues does this address?
Fixes #1067
What's this change do?
Fixes the target location in clouddocs for the docs on the master branch. They need to go to /master, not /newton.
Where should the reviewer start?
Any background context?

Can one of the admins verify this patch?

authors: jputrino pjbreaux


text:
2.1.1 (Actividad) Revisión bibliográfica.

Indicadores

[x] Revisión bibliográfica de 10 artículos científicos para identificar características fisicoquímicas de aguas de ríos que puedan ser medidas a través de sensores.

Verificación

[x] Lista de características fisicoquímicas de aguas de ríos que puedan ser medidas a través de sensores.

https://docs.google.com/document/d/1e2KNjdX_QjlSxJuRq5K_o0DH5UqwPZlLu8qqjzs9wos/edit?usp=sharing


text:
Duplicate parameters check

Description
Cannot have multiple parameters with the same name. This should raise an error before running the rest of the command/webui

Closed in commit

repo: FBruzzesi/sklearn-smithy


text:
Explore the use case of Stanford DB

Task description: explore the use case of Stanford University Coronavirus Antiviral & Resistance Database, and see if it can be used to detect frameshift mutations and stop codon on other organisms.
Findings:

The Stanford SARS-CoV-2 DB was actually stemmed from their HIV DB and we can use it to achieve the same goal on HIV sequences.

The Stanford DB cannot just be downloaded and used for other organisms. I opened their source code in my terminal and found there were thousands of different .csv files. The content of those .csv files (e.g. some contains COVID patients data, some contains gene information, etc.) confirm that this platform was built for specifically just SARS-CoV-2. It would be 3-4 months worth of work for me to do the backend development to modify and build one for other organisms and Raja thinks it is not worth it.

Action items:

[x] Jingyue to email Stanford DB team, asking if they have any documentation on how to deploy it (from command line is ok) for other viruses to detect frameshifts and stop codons
[x] Once hear back, update the team.

Here is the email reply from the Stanford team:
_Hello,
The core Sierra code can be ported to other viruses. We have created this Sudan Ebolavirus program which can be used as a template (https://github.com/hivdb/sierra-ebv). To use Sierra for another virus, the main changes that need to be done are under the src/main (https://github.com/hivdb/sierra-ebv/tree/main/src/main) folder.
However, we haven't provide any documentation on porting the program for other viruses. Although we does provide brief document for Sierra-HIV on how to start development environment and how to deploy the program: https://github.com/hivdb/sierra
In addition, all of our Sierra programs are open source and distributed under GPL 3.0 licence. Any kind of contributions including code improvement, unit test, documentation through GitHub pull requests are welcomed and will be appreciated.
I hope this answers your question!
Best,
Philip_

@JingyueWu Raja suggested passing this info off to @pmcneely to see if he could work with the source code you found within a couple days - if not then no biggie, but we think Pat is best suited to tell us how much work it might require for our objectives.

[ ] Can you please include any additional information in this ticket (objectives/deliverables) for Pat
[ ] Place the StanfordDB source code in this folder (https://github.com/FDA-ARGOS/data.argosdb/tree/main/lib)
[ ] Reassign the ticket to Pat

@pmcneely I integrated the Stanford source code in this folder, as Stephanie said in her comment above. Please locate to the folder named "covid-drdb" which is on the top.
Thanks for purposing the potential 2 routes we could go about, I think both would be valuable and viable deployments. However, based on the group discussion during the collaborators' meeting, Sergei is going to reach out to Bob and Philip, both are his connections who are part of the database development team, to find out how feasible it is for them to deploy this for other viruses on their end. He will share updates with us once he hears back from them.
In the meantime, Stephen Shank from Pond's lab can run SNPEff on Galaxy to achieve the same objective for us. Please feel free to continue looking into it, if you have time of course, and let us know your thoughts. Thanks so much again for your time and input.

closing and archiving this ticket until we need the information again. not action items at this time.

authors: JingyueWu steph-sing


text:
Fastq files of R1 have different lengths

When I run Cellranger Cout with fastq files, the software shows

. Can you share the parameters you use CellRanger, thank you。

Dear yang-qingxin,
we have been using an older version of CellRanger which didn't have this issue. You should be able to use the --r1-lenght argument setting it to 26. That should work.
Alternatively, you can directly work with the read matrix that we uploaded for each of the nine samples here in the "Raw Data" folder.
Let me know if you have further issues.

Dear FHentzschel,
It was very helpful.
Thank you very much!

Thanks!
------------------ 原始邮件 ------------------
发件人:                                                                                "FHentzschel/MalariaHostRBCAtlas"                                                                                @.>;
发送时间: 2022年8月3日(星期三) 下午5:44
@.>;
@.@.>;
主题: Re: [FHentzschel/MalariaHostRBCAtlas] Fastq files of R1 have different lengths (Issue #2)
Dear yang-qingxin,
we have been using an older version of CellRanger which didn't have this issue. You should be able to use the --r1-lenght argument setting it to 26. That should work.
Alternatively, you can directly work with the read matrix that we uploaded for each of the nine samples here in the "Raw Data" folder.
Let me know if you have further issues.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

authors: FHentzschel yang-qingxin

repo: FHentzschel/MalariaHostRBCAtlas


text:
[build optimization] Don't build armeabi-v7a by default

There are no FTC-legal armeabi-v7a (aka arm32) devices anymore, and EasyOpenCV supports arm64-v8a just fine nowadays.  Disabling the build of armeabi-v7a cuts the APK from ~60MB to ~50MB.

Also FtcCommon-9.0.1 includes a bunch of sound files that are not used.  Only these files are actually needed:

ss_mf_fail.wav
ss_light_speed.wav
ss_mine.wav
ss_bb8_down.wav
ss_r2d2_up.wav

Everything else is not used, and just eating up space unnecessarily.  Removing these files should shave off another ~3.2MB from the source, and at least 1MB from the APK.

repo: FIRST-Tech-Challenge/FtcRobotController


text:
EventHelper

Basically EventThread v2.
This API uses a java Timer and TimerTasks to execute events.

wrong repo

insane that you did this


text:
webase-node-manager，ContractService的updateContract方法，部署状态比较有误

ContractService类的227行，部署状态比较使用了合约类型字段。
if (tbContract.getContractType() == ContractStatus.DEPLOYED.getValue()

webase的问题，建议提交到这里

已修复

authors: cyjseagull hongfish mingzhenliu

repo: FISCO-BCOS/FISCO-BCOS


text:
Add actions badge to README

Add actions badge to README to have a radiator that shows how the GH action to deploy to demo is going

LGTM!

@jtudelag because I didn't create the branch starting with "feature-"

repo: FIWARE-Ops/marinera


text:
Add NVTX based profile instrumentation on linux

This adds clarity to the timeline, showing where in the overall application kernels occur at any given moment.
Colours are selected from a palette.
Also adds a call to cudaFree(0) on device initialisation to create the cuda context - an expensive process.
@todo Add support to windows?
I.e comparing with and without profile=1 for 64 iterations on the keratinocyte model:

Needs windows support

By default, the NVIDIA Nsight installer will set up the environment variable NVTOOLSEXT_PATH to point to the aforementioned location that matches the system's bits.

This variable can be used for system agnostic linking / compilation.

@mondus I've added Makefile support on windows via the relevant flag.
Adding visual studio support would most likely mean making an extra configuration, as we don't want to link against nvtoolsext_lib if we do not have to? Perhaps just providing documentation on how to enable it in visual studio builds would be sufficient?

authors: mondus ptheywood

repo: FLAMEGPU/FLAMEGPU


text:
Invalid argument error

I train with this code for Korean and I got this error:
(most recent call last):
  File "crnn/train.py", line 58, in <module>
    model.fit(train_ds, epochs=config['epochs'], callbacks=callbacks,
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/keras/engine/training.py", line 1183, in fit
    tmp_logs = self.train_function(iterator)
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/def_function.py", line 889, in __call__
    result = self._call(*args, **kwds)
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/def_function.py", line 917, in _call
    return self._stateless_fn(*args, **kwds)  # pylint: disable=not-callable
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 3023, in __call__
    return graph_function._call_flat(
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 1960, in _call_flat
    return self._build_call_outputs(self._inference_function.call(
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 591, in call
    outputs = execute.execute(
  File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/execute.py", line 59, in quick_execute
    tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
tensorflow.python.framework.errors_impl.InvalidArgumentError: 3 root error(s) found.
  (0) Invalid argument:  data/im\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00pg; Invalid argument
	 [[{{node ReadFile}}]]
	 [[MultiDeviceIteratorGetNextFromShard]]
	 [[RemoteCall]]
	 [[IteratorGetNextAsOptional]]
	 [[ReadVariableOp/_290]]
  (1) Invalid argument:  data/im\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00pg; Invalid argument
	 [[{{node ReadFile}}]]
	 [[MultiDeviceIteratorGetNextFromShard]]
	 [[RemoteCall]]
	 [[IteratorGetNextAsOptional]]
  (2) Invalid argument:  data/im\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00pg; Invalid argument
	 [[{{node ReadFile}}]]
	 [[MultiDeviceIteratorGetNextFromShard]]
	 [[RemoteCall]]
	 [[IteratorGetNextAsOptional]]
	 [[replica_1/assert_equal_1/Assert/Assert/data_3/_218]]
0 successful operations.
0 derived errors ignored. [Op:__inference_train_function_23254]

Function call stack:
train_function -> train_function -> train_function

I think if this codes can recognize Chinese with no problem it can do other utf-8 texts too, but it can't
What is cause about this error?
The difference of my data and example is file name(is Korean, ex: 가나다_453.jpg ), so is this cause about it?

Yes, the code can handle any utf-8 characters, from the error message, it seems to be the image path? Maybe you can run the dataset script first to check the iteration content of the dataset.

在 2022年6月27日，10:57，whansk50 @.***> 写道：

I train with this code for Korean and I got this error:
(most recent call last):
File "crnn/train.py", line 58, in
model.fit(train_ds, epochs=config['epochs'], callbacks=callbacks,
File "/home//miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/keras/engine/training.py", line 1183, in fit
tmp_logs = self.train_function(iterator)
File "/home//miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/def_function.py", line 889, in call
result = self._call(args, kwds)
File "/home//miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/def_function.py", line 917, in _call
return self._stateless_fn(args, kwds)  # pylint: disable=not-callable
File "/home//miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 3023, in call
return graph_function._call_flat(
File "/home//miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 1960, in _call_flat
return self._build_call_outputs(self._inference_function.call(
File "/home//miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 591, in call
outputs = execute.execute(
File "/home/***/miniconda3/envs/gpu38/lib/python3.8/site-packages/tensorflow/python/eager/execute.py", line 59, in quick_execute
tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
tensorflow.python.framework.errors_impl.InvalidArgumentError: 3 root error(s) found.
(0) Invalid argument:  data/im\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00pg; Invalid argument
[[{{node ReadFile}}]]
[[MultiDeviceIteratorGetNextFromShard]]
[[RemoteCall]]
[[IteratorGetNextAsOptional]]
[[ReadVariableOp/_290]]
(1) Invalid argument:  data/im\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00pg; Invalid argument
[[{{node ReadFile}}]]
[[MultiDeviceIteratorGetNextFromShard]]
[[RemoteCall]]
[[IteratorGetNextAsOptional]]
(2) Invalid argument:  data/im\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00pg; Invalid argument
[[{{node ReadFile}}]]
[[MultiDeviceIteratorGetNextFromShard]]
[[RemoteCall]]
[[IteratorGetNextAsOptional]]
[[replica_1/assert_equal_1/Assert/Assert/data_3/_218]]
0 successful operations.
0 derived errors ignored. [Op:__inference_train_function_23254]
Function call stack:
train_function -> train_function -> train_function
I think if this codes can recognize Chinese with no problem it can do other utf-8 texts too, but it can't
What is cause about this error?
The difference of my data and example is file name(is Korean, ex: 가나다_453.jpg ), so is this cause about it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Okay, I checked txt files and some lines were written wrong, so I removed them
Then I saw training going with no problem
It was just my mistake 😂
Thanks for reply


text:
Implementing PS2 HW stack

That issue is brocken into smaller one. Not finished at that point 5.3.24


text:
Apriltag filtering

Add config to select which apriltags are valid

One more idea, once this is working for the CPU apriltag code, port it over to the code in gpu_apriltag/src/gpu_apriltag_nodelet.cpp


text:
Caching proof obligations

I think we're starting to badly need caching of proof obligations. Otherwise too much human time is wasted on re-checking the same things over and over and over again, during an interactive proof.
We had formula caching in F5; maybe we can get some inspiration from there (discharge.fs in particular):
https://www.infsec.cs.uni-saarland.de/projects/F5/browser#trunk/Typechecker
I'm sure there are many other tools that do this too though.

One can see hints as a smarter variant of proof obligation caching. Closing.

repo: FStarLang/FStar


text:
Docs with sample code

Hi, just came across your package. I also mentioned it in https://github.com/google/open-location-code/issues/569
Maybe you can use the following as a start for some docs:
Open Location Code (OLC) Dart Library Documentation
The open_location_code package is a Dart library for working with Open Location Codes (OLCs), also known as "plus codes". It provides several functions for encoding, decoding, validating, and manipulating OLCs.

PlusCode class: This is the main class for working with OLCs. It includes the following methods:

PlusCode(): Constructor for creating a new PlusCode instance. It takes a string representing an OLC as an argument.
PlusCode.unverified(): Constructor for creating a new PlusCode instance without verifying the validity of the OLC. It's intended for bulk processing where the codes are known to be valid.
isValid(): Checks if the OLC is valid.
isShort(): Determines if the OLC is a valid short code.
isFull(): Determines if the OLC is a valid full code.
decode(): Decodes an OLC into the location coordinates.
recoverNearest(): Recovers the nearest matching code to a specified location.
shorten(): Removes characters from the start of an OLC.
encode(): Encodes a location into an OLC.

PlusCodeValidator extension: This extension provides additional validation methods for the PlusCode class.

Constants: The file includes various constants used in the OLC encoding and decoding process, such as pairResolutions, gridColumns, gridRows, decodeTable, and more.

Helper functions: The file also includes helper functions used in the OLC encoding and decoding process.

PlusCode Class
The PlusCode class is the main class for working with OLCs. It includes the following methods:
PlusCode()
This is the constructor for creating a new PlusCode instance. It takes a string representing an OLC as an argument.
var plusCode = PlusCode('849VCWC8+Q9');

PlusCode.unverified()
This is a constructor for creating a new PlusCode instance without verifying the validity of the OLC. It's intended for bulk processing where the codes are known to be valid.
var plusCode = PlusCode.unverified('849VCWC8+Q9');

isValid()
This method checks if the OLC is valid.
var isValid = plusCode.isValid;

isShort()
This method determines if the OLC is a valid short code.
var isShort = plusCode.isShort();

isFull()
This method determines if the OLC is a valid full code.
var isFull = plusCode.isFull();

decode()
This method decodes an OLC into the location coordinates.
var codeArea = plusCode.decode();

recoverNearest()
This method recovers the nearest matching code to a specified location.
var recoveredPlusCode = plusCode.recoverNearest(LatLng(51.520847, -0.19552100));

shorten()
This method removes characters from the start of an OLC.
var shortenedPlusCode = plusCode.shorten(LatLng(51.520847, -0.19552100));

encode()
This method encodes a location into an OLC.
var encodedPlusCode = PlusCode.encode(LatLng(51.520847, -0.19552100));

PlusCodeValidator Extension
The PlusCodeValidator extension provides additional validation methods for the PlusCode class.
Constants
The file includes various constants used in the OLC encoding and decoding process, such as pairResolutions, gridColumns, gridRows, decodeTable, and more.
Helper Functions
The file also includes helper functions used in the OLC encoding and decoding process.

Hi @dryprogrammer and thanks for the input :)
Tbh, I was not expecting anyone to show interest in this package really, especially since the google code was lingering in their repository for close to a decade without anyone taking the effort to push it to pub.dev
For now https://pub.dev/documentation/open_location_code/latest/open_location_code/open_location_code-library.html provides a pretty good documentation. Once I feel like there are people start using the library and are in demand of a quick start guide, I will put some effort.
Please just give me a sign in form of a comment here, future users :)

Oh I hadn't seen that. I guess Perplexity crawled that for me when it generated the docs.
Right, I'm new to geohash on dart, but didn't see any mention of OLC for a decade, despite all the benefits and compatibility with Geocoding API out-of-the-box.
Hopefully somebody will understand the potential and extend this in the future. :)

authors: FaFre dryprogrammer


text:
Throwing tridents will sometime crash the game

Describe the Bug
Ever since v0.5.1.f, sometimes throwing a trident will crash the game
Reproduction Steps

Throw trident
Keep throwing until it crashes
Might help to have loyalty on it, I think it crashes more often when returning to the player
...

Expected Result
Expected result: not crashing when using a trident
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/bY4XvxJC
Operating System
Windows 11
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
Mods can be found in the crash log
Additional Context
No response

the relevant code has been rewritten, seems to be working fine

repo: Fabricators-of-Create/Create


text:
Request the release of your pretrain model

Dear developers,
Hello, I would like to ask if you can open the download path of the trained model used in your paper, thank you very much!

Here it is: https://zenodo.org/record/8124014

May I ask whether the text encoder of clip in this pre-trained model has been fine-tuned by the method in the paper?

Yes it has been (not all layers but only the last transformer layer + the projection layers)

As stated in the readme, "pip install -e ." Should solve this issue

authors: FactoDeepLearning YCaigogogo

repo: FactoDeepLearning/MultitaskVLFM


text:
add Continuous Integration to main-v3

[x] Test
[x] Lint
[x] Prettify
[x] Build
[x] ~Publish~

Merged into main-v3

repo: Faire/mjml-react