text:
Automator: update proxy@release-1.15 in istio/istio@release-1.15

Generated by Automator - 2023-03-24T20:16:22+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot

integ-cni_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot

integ-cni_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-cni

integ-security-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot

integ-cni_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-cni

integ-security-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security-istiodremote

integ-security_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test gencheck

integ-basic-arm64_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-basic-arm64

integ-distroless_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-distroless

integ-pilot-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot

integ-cni_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-cni

integ-security-istiodremote_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security-istiodremote

integ-security_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security

integ-pilot-multicluster_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security

integ-pilot-multicluster_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-pilot-multicluster

integ-security-multicluster_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio_release-1.15
c45bc2befe85fc65558d67694ca4fffff84e3ea1
link
true
/test integ-security-multicluster

unit-tests-arm64_istio_release-1.15
f1ff20935119d0e0b91c3f6034ef28f6b20ce268
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: ZiyangXiao dhawton istio-testing


text:
Enable presubmit on Prow

Fix Build Issues
Create presubmit script
Update e2e framework to save logs to _artifacts folder instead of uplading them to gcloud storage since Prow already does this.

Hi @sebastienvas. Thanks for your PR.
I'm waiting for a  member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

@sebastienvas: you can't request testing unless you are a  member.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d2470b301dc1701d722c394a99df248bbc2355f0
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
bd4fff12b827dbb85003035035f87f2995a924e9
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b8163fe1693ce0cda035a10161e89750afb3c385
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

Prow results are available here

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

Prow results are here. Note that artifacts were also uploaded as well.

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

bam!
On Fri, Jul 14, 2017 at 7:48 PM Sebastien Vas notifications@github.com
wrote:

Merged #464 https://github.com/istio/istio/pull/464.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/464#event-1165108472, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACBRURzOSeYvChP9SVPA7wNp4Y4IkC_9ks5sN_48gaJpZM4OTech
.

source: gharchive/pull-request

authors: istio-testing nlandolfi sebastienvas

repo: istio/istio

license_type: permissive

license_source: github-api


text:
Fix no tag webhook is installed after revisioned installation failure

Please provide a description of this PR:
There is an inconsistent behavior in revisioned installations in a clean environment (with no prior installations). Using istioctl install --revision=test in such an environment successfully installs a default webhook. However, if there are failures during the initial installation and you attempt to reinstall again using istioctl install --revision=test, a successful installation will not install a default webhook.
I think that if there is no prior installation, or if no installation has been successfully completed, we should ensure the installation of the default webhook.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4be8dfa5f92925e21cea76429a9fe9002000c3fb
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

not stale

not stale

authors: hanxiaop istio-testing


text:
Test 1

Change-Id: I012c63c3701a681d143e1445fce7c3b6199bb101
Please provide a description of this PR:

Hi @rkatti. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Do not abuse

We are testing EasyCLA validation for PRs submitted through Gerrit vs individual. Pls ignore test PRs.

authors: istio-testing rkatti zirain


text:
Sample: bump jaeger version

Please provide a description of this PR:
bump jaeger version  1.58 --> 1.63.0
https://github.com/jaegertracing/jaeger/releases/tag/v1.63.0

@my-git9: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8e2b295f34bfadc6789cfbbe7e130ad423af092b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@my-git9: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8e2b295f34bfadc6789cfbbe7e130ad423af092b
link
true
/test release-notes

unit-tests-arm64_istio
8e2b295f34bfadc6789cfbbe7e130ad423af092b
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


text:
run dep prune to cleanup unused files

previsou dep version introduced many unused files,eg. LICENSE _test.go
run dep prune to remove these useless files to reduce the repo capacity.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @hzxuzhonghu. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @gyliu513  @ZackButcher

/ok-to-test

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
208f245fb469b4880dd020a03cba8f6f133aa73a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

not sure which exact command (can you document it) you ran but there is a reason some repos had more files - for instance
https://github.com/istio/istio/blame/master/Gopkg.toml#L332-L361
also now it seems the lock file and vendor are out of sync
cc @costinm (fyi) @ostromart  (for license file removal) @nmittler (vendor)

The license files are a legal requirement and must be restored.

$ dep check
# vendor is out of sync:
code.cloudfoundry.org/copilot: hash of vendored tree not equal to digest in Gopkg.lock
github.com/BurntSushi/toml: hash of vendored tree not equal to digest in Gopkg.lock
github.com/apache/thrift: hash of vendored tree not equal to digest in Gopkg.lock
github.com/envoyproxy/go-control-plane: hash of vendored tree not equal to digest in Gopkg.lock
github.com/gogo/googleapis: hash of vendored tree not equal to digest in Gopkg.lock
github.com/gogo/protobuf: hash of vendored tree not equal to digest in Gopkg.lock
github.com/grpc-ecosystem/go-grpc-middleware: hash of vendored tree not equal to digest in Gopkg.lock
github.com/hashicorp/consul: hash of vendored tree not equal to digest in Gopkg.lock
github.com/hashicorp/go-rootcerts: hash of vendored tree not equal to digest in Gopkg.lock
github.com/hashicorp/serf: hash of vendored tree not equal to digest in Gopkg.lock
github.com/hashicorp/vault: hash of vendored tree not equal to digest in Gopkg.lock
github.com/imdario/mergo: hash of vendored tree not equal to digest in Gopkg.lock
github.com/onsi/ginkgo: hash of vendored tree not equal to digest in Gopkg.lock
github.com/open-policy-agent/opa: hash of vendored tree not equal to digest in Gopkg.lock
github.com/prometheus/client_model: hash of vendored tree not equal to digest in Gopkg.lock
github.com/spf13/cobra: hash of vendored tree not equal to digest in Gopkg.lock
github.com/square/certstrap: hash of vendored tree not equal to digest in Gopkg.lock
golang.org/x/tools: hash of vendored tree not equal to digest in Gopkg.lock
istio.io/api: hash of vendored tree not equal to digest in Gopkg.lock
k8s.io/cluster-registry: hash of vendored tree not equal to digest in Gopkg.lock
k8s.io/helm: hash of vendored tree not equal to digest in Gopkg.lock
k8s.io/kubernetes: hash of vendored tree not equal to digest in Gopkg.lock

Do we have some detailed process for this? As well as the dep version requirement for this? I think we should add this to dev guide as well.

@ayj @ldemailly I do not remember how to reproduce this. Seems weird, and now the right way is to re-run dep ensure to restore.
But seems this global prune setting does not take effect
[prune]
  go-tests = true
  unused-packages = true
  non-go = true

@gyliu513 there's no dep process specific to istio, everything is per the official dep documentation.
For adding dependencies we have: https://github.com/istio/istio/wiki/Vendor-FAQ#how-do-i-add--change-a-dependency
We don't expect people to be pruning the vendor dir manually so I don't think having a process for that would be appropriate, it should be done by editing Gopkg.toml. By all means feel free to submit PRs that edit Gopkg.toml if you feel something could be tidied up or improved. After reading the dep docs, the Gopkg.toml should be fairly easy to follow. Ping me or istio-dev if you have questions about any specific items in that file.

@ostromart Yes, this would help.
I also heard from @hzxuzhonghu , it seems using dep version other than 0.5.0 will cause build failed, @hzxuzhonghu can you help confirm? If so, we may need to update the wiki page a bit to highlight the dep version as well?

fyi https://github.com/istio/istio/pull/8036 should indirectly fix this.

authors: ayj gyliu513 hzxuzhonghu istio-testing ldemailly ostromart rshriram


text:
updating to indicate needed source istio.VERSION

when trying to run 1 test
also removed rbac file as it's not necessary anymore/is inlined in every yaml
Release note:

test setup doc update

@andraxylia did you check the diff ? it's a doc, a dev example that didn't work before and works now


text:
Update helm chart config to use stable tag

so that the version is not hardcoded, and they can be replaced by the
actual release version by release automation.

@hklai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
429ed6e82c7222c519735f01b1dd7154a35fa84a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
429ed6e82c7222c519735f01b1dd7154a35fa84a
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
429ed6e82c7222c519735f01b1dd7154a35fa84a
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
429ed6e82c7222c519735f01b1dd7154a35fa84a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
8debbaad5e9cb55eaa272938412248e10a0f0ef8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
429ed6e82c7222c519735f01b1dd7154a35fa84a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
8debbaad5e9cb55eaa272938412248e10a0f0ef8
link
/test istio-unit-tests

prow/istio-presubmit.sh
8debbaad5e9cb55eaa272938412248e10a0f0ef8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
429ed6e82c7222c519735f01b1dd7154a35fa84a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
99aa6c2e2f7ee3bda04f761530f2690d3466f6bd
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: hklai istio-testing


text:
ipptool doesn't check that the printer's response contains a "Content-Type: application/ipp" header

Based on a packet trace, it seems like some printers do not include a "Content-Type: application/ipp" HTTP header in their responses, which is technically non-conformant.
ipptool should check for this and (at least) warn the user when in "test" mode.

[master d130c11] Add HTTP response header validation to ipptool (Issue #39)
Activated using the "-h" option...

source: gharchive/issue

repo: istopwg/ippsample


text:
Bereitstellung LOGIN-Pages

Akzeptanzkriterien

[ ] Wahllokalsystem-LoginGUI wird ausgeliefert
[ ] Admin-LoginGUI wird ausgeliefert

Umsetzungshinweise

unter Beachtung relevanter Filter (CORS, Csrf, ...)
siehe MainController, templates und wro

Please add your planning poker estimate with Zenhub @vjohnslhm

Hey team! Please add your planning poker estimate with Zenhub @dragonfly28 @GerhardPx @MrSebastian @vjohnslhm

repo: it-at-m/Wahllokalsystem

license: MIT


text:
Iscrizione da comune non subentrato (già cancellato in precedenza da ANPR)

Buongiorno, un nostro cliente ha un problema in una pratica di iscrizione da comune non subentrato.
Questo soggetto però, era precedentemente iscritto in un comune subentrato in ANPR, quindi ha già acquisito nel sistema l'id ANPR.
Successivamente è stato cancellato dal comune subentrato per un comune non subentrato.
Ora deve essere nuovamente iscritto in un nuovo comune già subentrato in ANPR: dal nostro gestionale abbiamo recuperato i dati da ANPR ed effettuato tutte le normali operazioni per effettuare l'iscrizione.
Al momento della chiusura della pratica però si è presentata l'anomalia "idSchedaSoggettoANPR non è presente o dati anagrafici incongruenti".
Dopo alcune prove su questo soggetto, abbiamo riprodotto su ambiente di test la stessa situazione ed è andata a buon fine.
I dati delle richieste sono questi:
Richiesta andata a buon fine su ambiente di test:
IDOperazioneComune: 12730
idSchedaSoggettoANPR: 26035260
Richiesta non andata a buon fine in produzione:
IDOperazioneComune: 4107
idSchedaSoggettoANPR: 27288919
Potete fare una verifica su quest'ultima trasmissione e darci indicazioni in merito?
Grazie
Marco Sala
Pa Digitale Spa

Ci sembra che la tua richiesta abbia un carattere di assistenza su casistiche particolari che richiedono scambi di informazioni e di dettaglio.
Questi casi necessitano spesso di contatti telefonici o via email diretti.
Il sistema di Issue Tracking basato Github, dove ci stai leggendo, ha l’obiettivo di condividere problemi tecnici, chiarimenti normativi, esigenze e proposte di interesse generale, quindi ogni comunicazione ha visibilità pubblica.
Per questo motivo ti chiediamo, per questa segnalazione,  di avvalerti del servizio di assistenza ANPR al numero 800863116.

authors: MarcoSalaPad rvinzani

repo: italia/anpr


text:
E129 when trying lightline-problem-12

Setup:
let g:lightline = {
	\ 'colorscheme': 'differentiata',
	\ 'component_function': {
		\ 'mode': 'LightlineMode',
		\ 'filename': 'LightlineFileName',
		\ 'modified': '%#ModifiedColor#%{LightlineModified()}',
		\ 'fileencoding': 'LightlineFileEncoding',
		\ 'fileformat': 'LightlineFileFormat',
		\ 'filetype': 'LightlineFileType',
		\ 'readonly': 'LightlineReadOnly',
		\ 'title': 'LightlineTitle'
	\ },
	\ 'active': {
	\ 'left': [ [ 'title' ],
	\			[ 'mode', 'paste' ],
	\           [ 'readonly', 'filename', 'modified' ] ],
	\ 'right': [ [ 'lineinfo' ],
	\            [ 'percent' ],
	\            [ 'fileformat', 'fileencoding', 'filetype' ] ]
	\ },
	\ 'inactive': {
		\ 'left': [ [ 'title' ],
		\			[ 'filename' ] ],
		\ 'right': [ [ 'lineinfo' ],
		\            [ 'percent' ] ]
	\ }
\ }

function! LightlineModified()
	let map = { 'V': 'n', "\<C-v>": 'n', 's': 'n', 'v': 'n', "\<C-s>": 'n', 'c': 'n', 'R': 'n'}
	let mode = get(map, mode()[0], mode()[0])
	let bgcolor = {'n': [240, '#585858'], 'i': [31, '#0087af']}
	let color = get(bgcolor, mode, bgcolor.n)
	exe printf('hi ModifiedColor ctermfg=196 ctermbg=%d guifg=#ff0000 guibg=%s term=bold cterm=bold',
	\ color[0], color[1])
	return &modified ? '+' : &modifiable ? '' : '-'
endfunction

Output
On :w | source $MYVIMRC:
Error detected while processing function lightline#update[11]..lightline#statusline[4]..<SNR>60_line[19]..<SNR>60_subseparator:
line    2:
E129: Function name required
E129: Function name required
E129: Function name required
E129: Function name required

Also E129 appears on re-entering Vim.

Please move the modified component to component object from component_function.

Oh, hm, thanks. It works. Sorry.

authors: Yodzorah itchyny

license: mit

license_source: bigquery


text:
fix:disable dependabot

#449 was meant to disable dependabot. While doing so it caused an error because the file is now invalid. According to the docs, to disable dependabot temporarily, simply set the open-pull-request-limit to 0.

bors r+


text:
Testnet contract setup keeps failing

We have a big amount of failed CFDs at the moment. Sporadically it seems to work out, but most of the auto-taker CFD opens are failing.

The makes is not responding:
taker_master logs:
  | 2022-05-09 19:30:23 | {"timestamp":"2022-05-09T09:30:23.353848897Z","level":"ERROR","fields":{"message":"Contract setup failed: Maker did not respond within 30 seconds","order_id":"2494735a-fd89-425a-b2fa-e049a5ff43f7"},"target":"model::cfd"}
-- | -- | --

This happens for almost all CFDs at the moment (same error cause).

It appears the maker is seeing the incoming request by the taker:

2022-05-09 19:29:53 | {"timestamp":"2022-05-09T09:29:53.352553529Z","level":"DEBUG","fields":{"message":"Applying new events to CFD","order_id":"2494735a-fd89-425a-b2fa-e049a5ff43f7","aggregate":"daemon::projection::Cfd","cfd_version":"0","num_events":"0"},"target":"daemon::db"}
-- | --
  |

It appears the automation is still the problem:

2022-05-09 19:38:08
{"timestamp":"2022-05-09T09:38:08.884739326Z","level":"ERROR","fields":{"message":"Failed to deserialize cfds event: invalid type: null, expected f64 at line 1 column 11481"},"target":"itchy_automation::itchysats::feed"}

2022-05-09 19:37:58
{"timestamp":"2022-05-09T09:37:58.878235846Z","level":"ERROR","fields":{"message":"Failed to deserialize cfds event: invalid type: null, expected f64 at line 1 column 11481"},"target":"itchy_automation::itchysats::feed"}

2022-05-09 19:37:48
{"timestamp":"2022-05-09T09:37:48.865188503Z","level":"ERROR","fields":{"message":"Failed to deserialize cfds event: invalid type: null, expected f64 at line 1 column 11481"},"target":"itchy_automation::itchysats::feed"}

This was a combination of problem, solved with updating the testnet configuration and solving the deserialization bug.

repo: itchysats/itchysats


text:
Make monitor::Actor adhere to ADR013

No rush in merging this.

@da-kami Is this an actual re-approval where you went through the code again or just a drive-by one? :P
It is quite the code change so I'd appreciate if people have a closer look!

bors r+


text:
fix NotesModalButton

Fixes a bug with the NotesModalButton on the EditInvoice page. When a user saves a note and immediately refreshes the page, the notes modal does not show the saved note.
This partially fixes https://github.com/itenium-be/confac/issues/275

Effe voor de duidelijkheid, dit fixed dus inderdaad dat als je F5 doet de comments wel beschikbaar zijn, maar zover ik begrepen heb als je deze code wegneemt en je drukt F5 dan is de store nog leeg wat er voor zorgt dat er een lege string als state wordt meegegeven aan:
const [text, setText] = useState<string>(value || '');
en useState gaat dan bij elke rerender een lege waarde terug geven.
door het volgende te doen:
if(!text && value){
    setText(value);
  }

gaat op de moment dat de store dan wel opgevuld is je via setText er voor zorgen dat useState wel de correcte text terug geeft na een rerender waardoor het werkt bij refresh.
In essentie zouden we dus het renderen van deze component moeten uitstellen tot op het moment dat de store wel een invoice heeft. lijkt mij een betere fix.

repo: itenium-be/confac


text:
Replicated code in Iter8 tests

In Iter8 repo tests ...
	mux, addr := fhttp.DynamicHTTPServer(false)
	mux.HandleFunc("/echo1/", fhttp.EchoHandler)
	testURL := fmt.Sprintf("http://localhost:%d/echo1/", addr.Port)

	srv, err := repotest.NewTempServerWithCleanup(t, base.CompletePath("../", "testdata/charts/*.tgz*"))
	if err != nil {
		t.Fatal(err)
	}
	defer srv.Stop()
	if err = srv.CreateIndex(); err != nil {
		t.Fatal(err)
	}
	if err = srv.LinkIndices(); err != nil {
		t.Fatal(err)
	}

	repoURL = srv.URL()
	chartName = "load-test-http"
	chartVersionConstraint = "0.1.0"

The above snippet appears in several unit tests. Enable re-use for all but the defers.

Not relevant anymore.


text:
Linux install with snap

link: https://dvc.org/doc/install/linux#install-with-snap
The additional flags --beta and --edge result in messages:

Channel latest/beta for dvc is closed; temporarily forwarding to stable.
Channel latest/edge for dvc is closed; temporarily forwarding to stable.

Should mention of these flags remain if they are closed?

Additionally, installing with snap presents the following message:
$ sudo snap install --classic dvc
dvc 2.8.1 from Casper (casper-dcl) installed

I know who this is but newcomers who try this install method might be caught off guard expecting the org behind the tool, for contrast:
$ sudo snap install redis
redis 6.2.6 from Redis (redislabs) installed

@efiop @dberenbaum is this a core issue? Otherwise what change is required in docs? Thanks. Cc @casperdcl

I've never built snap packages (know what /if any automatic process is doing it for you), but it looks like the build doesn't match other processes at the time either.
looking at the (snap stable provided version): https://github.com/iterative/dvc/tree/2.8.1
I noticed odd behavior and saw the target python version should be 3.8?
dvc doctor from the snap package:
$ dvc doctor
DVC version: 2.8.1 (snap)
---------------------------------
Platform: Python 3.6.9 on Linux-5.11.0-49-generic-x86_64-with-Ubuntu-21.04-hirsute
Supports:
	azure (adlfs = 2021.9.1, knack = 0.8.2, azure-identity = 1.6.1),
	gdrive (pydrive2 = 1.10.0),
	gs (gcsfs = 2021.10.0),
	webhdfs (fsspec = 2021.10.0),
	http (aiohttp = 3.7.4.post0, aiohttp-retry = 2.4.6),
	https (aiohttp = 3.7.4.post0, aiohttp-retry = 2.4.6),
	s3 (s3fs = 2021.10.0, boto3 = 1.17.106),
	ssh (sshfs = 2021.9.0)

We've decided in the past wasn't worth the hassle of creating an iterative snap account.
Safe to drop the --beta & --edge though

Safe to drop the --beta & --edge

OK taking care of that in https://github.com/iterative/dvc.org/pull/3303. Transferring this to DVC core repo for the remaining questions

authors: casperdcl dacbd jorgeorpinel


text:
Removed condenscened language from settings

Fix #1394

CI checks are failing @kurianbenoy please fix formatting as explained in https://dvc.org/doc/user-guide/contributing/docs. Contact me with questions or if you need help.

Ping @kurianbenoy

@andronovhopf please just double check the few changes to blog articles. Thanks

@kurianbenoy before we do more changes - please, address @jorgeorpinel 's review and let's fix CI.

I have addressed comments of @jorgeorpinel reviews, I have only made changes to the first 10 files reviewed. I will make more changes soon.

Closing as stale, feel free to reopen, fix conflicts, address feedback.

Sorry, I was just busy with the DVC 1.0 release and couldn't get back to reviewing this. But it's still a valid PR.

It's going to require lots of conflict solving though. @kurianbenoy do you want to resolve those conflicts or rather branch off master again and re-apply all of these changes?

@jorgeorpinel creating a new branch off master might be a better idea. I agree it's good time to close this PR and reopen as a new PR again

Hi @kurianbenoy,
Are you having issues resetting your fork's master branch and re-applying your changes? It would probably be a better idea not to use master next time, BTW. For situations like this one.
Feel free to reach out to me if you need help with Git.

authors: jorgeorpinel kurianbenoy shcheklein


text:
dvclive-first metrics and plots

Closes #4769.
Tries to address any gaps where we don't explain the relationship between pipelines and dvclive metrics/plots, focusing on dvclive as the primary entrypoint for metrics/plots.

@dberenbaum linter is failing, could you please take a look?

Made one more pass and tried to clarify that you can add metrics and plots as regular outputs but that it's optional. I'm not comfortable making a general recommendation to drop them because they are still useful to store in the run-cache (see https://github.com/iterative/dvclive/issues/456#issuecomment-1644068175).

authors: dberenbaum shcheklein


text:
Procedure too large error

Hello,
When using VBA-RunPE as instructed in the readme:
./pe2vba.py <name.exe>
and inputting the generated .vba into the editor and trying to run I am receiving a "compile error: procedure too large."
Is this expected?
Thanks!

Hello,
Here is the thing with VBA, the length of each line is limited and the length of each procedure is also limited. To work around that, the Python script splits the input EXE into chunks and then creates a procedure that collects all the chunks to reconstruct the EXE in memory.
Without more details from your part about the error, I suspect that your input EXE is too large, which causes the last procedure to grow past the size limit.
This code was never intended to be used to embed large executables. The Python script could surely be improved to address this kind of use case, but I won't do that.
Or perhaps it's something else, but again, I cannot tell without more details.


text:
Token Request Failed - Callback route not found

I am having an issue getting this to run in my Nuxt project using the generic OIDC provider (with AWS Cognito).
The auth flow initializes fine and I get to the Cognito login page fine. When redirected back to the callback page, I get a 500: Token request failed error. Looking at the console logs, I see that its failing to find the route for the callback, even though I have the middleware registered. I have compared everything else I can think of to the playground project in the repository.
[nuxt] error caught during app initialization Error: Page not found: /auth/oidc/callback?

Package versions:
Nuxi: ^3.12.0
Nuxt: ^3.12.4
nuxt-oidc-auth: ^0.12.0
Nuxt.config.ts
// https://nuxt.com/docs/api/configuration/nuxt-config
export default {
	modules: [
    "nuxt-oidc-auth",
  ],
	googleFonts: {
		families: {
			Inter: true,
		},
	},
	tailwindcss: {
		jit: true,
	},
  runtimeConfig: {
    public: {
      apiBaseUrl: process.env.API_BASE_URL,
    },
  },
  imports: {
    dirs: ['./utils'],
  },
  oidc: {
    middleware: {
      globalMiddlewareEnabled: true,
    },
    defaultProvider: 'oidc',
    providers: {
      oidc: {
        clientId: '***',
        clientSecret: '***',
        responseType: 'code',
        pkce: true,
        authorizationUrl: 'https://***.auth.us-east-1.amazoncognito.com/oauth2/authorize',
        tokenUrl: 'https://***.auth.us-east-1.amazoncognito.com/oauth2/token',
        userinfoUrl: 'https://***.auth.us-east-1.amazoncognito.com/oauth2/userInfo',
        redirectUri: 'http://localhost:3000/auth/oidc/callback',
        scope: [ 'openid', 'profile' ],
        responseMode: 'query',
      },
    },
  },
  nitro: {
    preset: 'node-server',
    storage: { // Local file system storage for demo purposes
      oidc: {
        driver: 'fs',
        base: 'oidcstorage'
      }
    }
  },
};

If meanwhile you solve this issue please tell us how. I'm also with the same problem and cant figure it out.
Thanks a lot.

I have the same problem here and would appreciate a solution. The redirect to the IdP and back to the app with the auth code work. But afterwards, it is displayed that the route cannot be found.

I'm still with the same issue but i find out that the code_verifier is not being sent when doing the token request with the access token. Do you also have the same issue? With postman i have the bad request error not 500 but this is also a issue i think. I try to console log the code_verifier but i get undifined.

@mmillican have you configured the callback url correctly in AWS?
I recently tried the generic OIDC provider with AWS Cognito and that worked fine, would you mind sharing your cognito config?

I have the same problem here and would appreciate a solution. The redirect to the IdP and back to the app with the auth code work. But afterwards, it is displayed that the route cannot be found.

![image](https://private-user-images.githubusercontent.com/113760890/355384845-926d2767-56e5-47e4-a7bc-2603e2a1ba56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ4ODk4NDYsIm5iZiI6MTcyNDg4OTU0NiwicGF0aCI6Ii8xMTM3NjA4OTAvMzU1Mzg0ODQ1LTkyNmQyNzY3LTU2ZTUtNDdlNC1hN2JjLTI2MDNlMmExYmE1Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyOFQyMzU5MDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNjllZTkwNmMyMjFlMTdjODk1YjkyY2UxMGMyMDk2MDNiMzg4MjIyYWNjNTY5NzlhZDdhNDQzOGJiMDgyN2RkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.y3ybEiPDXMiJEa8tIYs_XzRAeL28P6CWDdoM5VmgGhw)

This is just a warning by the Nuxt router, but shouldn't have any impact on the actual functionality. In version 0.12.1 there was a visual fix to get rid of that warning.
Would be interesting what the actual request error for the token request on the console is.

If meanwhile you solve this issue please tell us how. I'm also with the same problem and cant figure it out.
Thanks a lot.

Would you mind open a separate issue for the OIDC provider you are trying it with and some details?

If meanwhile you solve this issue please tell us how. I'm also with the same problem and cant figure it out.
Thanks a lot.

Would you mind open a separate issue for the OIDC provider you are trying it with and some details?

Hey itpropro, thanks for answering. I have opened a issue talking about this and i found a solution, still having problems but at least the 500 dissappeard. You can check it:
Title:
Token request failed - [nuxt-oidc-auth]: [POST] "https://github.com/login/oauth/access_token":  fetch failed
Thanks a lot

@itpropro sorry for the delay. Here's a screenshot of the relevant config for the callback:

Hello everyone,
I just got started with nuxt and the nuxt-oidc-auth module and I am stuck on the same issue. I just tried a basic setup (IdP Zitadel) and everything works fine untill the browser comes back with the callback call from the IdP. I don't think this is an IdP issue as nuxt doesn't find a match for the location "/auth/oidc/callback". Even though the documentations writes:

All configured providers automatically register the following server routes.
/auth//callback
/auth//login
/auth//logout

I have a minimum setup with no custom routes at all and "login" and "logout" are working perfectely. Just the the callback function that should be registered automatically gets the warning

[Vue Router warn]: No match found for location with path "/auth/oidc/callback"

and the UI shows "500, callback failed, missing code).
Is there something special that one should now about the auto-registered OIDC fallback?
Thank you very much!

Hi @the-tmp, could you please verify with the most current version?
The vue warning is fine btw, that appears, as it is a server route. Also always make sure that you use the provided composables for login/logout.
For further troubleshooting you nuxt config without sensitive information would be required.

Hi @itpropro
I just updated to the latest version 0.15.1 and still have the same warning. It was strange for me that I get the warning just for the callback but not for the login and logout pages. After the update I have new issue but thisone seems just to be a OIDC configuration mistake of mine. I am new to Nuxt but I will try to double check everything next weekend and hopefully I can give you an update.
Thanks a lot!

Hey @the-tmp
If you share your config and which oidc provider you use, I can try to reproduce and help you get your problem solved.

Hello @itpropro
I updated to v0.17.0. I am using the free Zitadel IAM cloud service as IDP and the following OIDC Config:
  oidc: {     defaultProvider: 'oidc',     providers: {       oidc: {         clientId: '',         clientSecret: '',         authorizationUrl: 'https://xyz.zitadel.cloud/oauth/v2/authorize',         tokenUrl: 'https://lxyz.zitadel.cloud/oauth/v2/token',         redirectUri: 'http://localhost:3000/auth/oidc/callback',         //grantType: 'authorization_code'       }     },     middleware: {       globalMiddlewareEnabled: true,       customLoginPage: false     }   }
I get the this warning now:

[nuxt-oidc-auth]: { error: 'invalid_request', error_description: 'grant_type missing' }

The warning is still there, but I think the callback request is accepted by nuxt-oidc-auth (as you said I should ignore it) but when it tries to get the Token it seems to not send the required "grant_type=authorization_code". I tried to configure the grantType, even though it should be default according to the documenatation, but I got the same error.
I tested the Zitadel setup with the OAUTH Playground (https://www.oauth.com/playground/oidc.html) and it worked as intended. The IDP configuration should be ok.
I think we should switch with this to a new issue, as it seems that this is not about the callback issue anymore.
Thank you very much. I am sure, I just missed a little configuratio detail but I can't figure out with one.
best regards

Hello @itpropro I updated to v0.17.0. I am using the free Zitadel IAM cloud service as IDP and the following OIDC Config:
 oidc: { defaultProvider: 'oidc', providers: { oidc: { clientId: '', clientSecret: '', authorizationUrl: 'https://xyz.zitadel.cloud/oauth/v2/authorize', tokenUrl: 'https://lxyz.zitadel.cloud/oauth/v2/token', redirectUri: 'http://localhost:3000/auth/oidc/callback', //grantType: 'authorization_code' } }, middleware: { globalMiddlewareEnabled: true, customLoginPage: false } }
I get the this warning now:

[nuxt-oidc-auth]: { error: 'invalid_request', error_description: 'grant_type missing' }

The warning is still there, but I think the callback request is accepted by nuxt-oidc-auth (as you said I should ignore it) but when it tries to get the Token it seems to not send the required "grant_type=authorization_code". I tried to configure the grantType, even though it should be default according to the documenatation, but I got the same error.
I tested the Zitadel setup with the OAUTH Playground (https://www.oauth.com/playground/oidc.html) and it worked as intended. The IDP configuration should be ok.
I think we should switch with this to a new issue, as it seems that this is not about the callback issue anymore.
Thank you very much. I am sure, I just missed a little configuratio detail but I can't figure out with one.
best regards

The problem was not the grant_type, but the type of format Zitadel expects.
These are the important configurations to make Zitadel work:
        validateAccessToken: false,
        validateIdToken: true,
        skipAccessTokenParsing: true,
        tokenRequestType: 'form-urlencoded',
        scope: ['openid', 'offline_access'],
        authorizationUrl: 'https://PROJECT.us1.zitadel.cloud/oauth/v2/authorize',
        tokenUrl: 'https://PROJECT.us1.zitadel.cloud/oauth/v2/token',
        userInfoUrl: 'https://PROJECT.us1.zitadel.cloud/oidc/v1/userinfo',
        redirectUri: 'http://localhost:3000/auth/oidc/callback',
        logoutUrl: 'https://PROJECT.us1.zitadel.cloud/oidc/v1/end_session',

I created a dedicated provider for Zitadel that handles everything for you. This will be the config as soon as it releases today:
      zitadel: {
        clientId: '',
        clientSecret: '', // Works with PKCE and Code flow, just leave empty for PKCE
        redirectUri: 'http://localhost:3000/auth/zitadel/callback',
        baseUrl: '',
        audience: '', // Specify for id token validation, normally same as clientId
        logoutRedirectUri: 'https://google.com', // Needs to be registered in Zitadel portal
        authenticationScheme: 'none', // Set this to 'header' if Code is used instead of PKCE
      },

Hi @itpropro
Thank you very much. You saved me a lot of trail & error this weekend. I couldn't install the newest version yet but with your hints above it is working perfectly. I even don't get the missing callback warning any more... I haven't changed anything except added the token attributes in the config.
I will keep testing until I get the hang of it all a little better.
Thanks again!
best regards

Hi @itpropro
Thank you very much. You saved me a lot of trail & error this weekend. I couldn't install the newest version yet but with your hints above it is working perfectly. I even don't get the missing callback warning any more... I haven't changed anything except added the token attributes in the config.
I will keep testing until I get the hang of it all a little better.
Thanks again!
best regards

I just released the new version. It also handles some configurations that were necessary to get the logout redirection to work correctly.
Please test out the new provider and give some feedback on how that one works.

Hello @itpropro
Thank you very much. I updated to the newest version, switched to Zitadel as provider and cleaned out my old config. Working perfectly! Do you wan't me to test anything special for you?
Best regards

authors: DiogoCunhaMoreira MartinVogtFHNW itpropro mmillican the-tmp

repo: itpropro/nuxt-oidc-auth


text:
Pass arguments through the oidc_auth wrapper

The oidc_auth decorator did not accept or pass through any arguments to the wrapped route, resulting in an wrapper() got an unexpected keyword argument error when the wrapped function expected arguments (e.g. from a variable in the route URL).
This PR changes the wrapper() function to both accept any number of arguments and keyword arguments and pass them through to the wrapped function when the user is authenticated, as per the official documentation: http://flask.pocoo.org/docs/0.11/patterns/viewdecorators/

Thanks, this looks great! :)

authors: rebeckag stevenmirabito

repo: its-dirg/Flask-pyoidc


text:
Increment Version

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/44190
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.8.3 -m "<description of version>" 04ec87a6f5b6ab0161c35d18b2fa94cb76afdc8b
git push origin v0.8.3

authors: JuliaRegistrator itsdfish