text:
PHP template

PHP template request
Expected Behaviour
Be able to deploy and run PHP functions
Current Behaviour
Missing a template for PHP applications
Possible Solution
Add PHP template

Hi there and thank you for your interest in OpenFaaS.
The community have provided third party support for PHP. Please see the faas-cli readme file for more details.
Thanks,
Alex

https://github.com/itscaro/openfaas-template-php/

authors: SergeC alexellis

repo: openfaas/templates


text:
ListUsers integration tests for intersection

Description
Add assertions for ListUsers API in models that contain intersection.
References
https://github.com/openfga/openfga/issues/1428

My only request is that we add cases for relation_with_wildcard_involving_intersection? That's a pretty important one that's top-of-mind currently.

Do you mean add assertions? I pushed another one, but i can't think of any others 🤔

source: gharchive/pull-request

repo: openfga/openfga

license_type: permissive

license_source: github-api


text:
gDEBugger doesn't work on lime if DYNAMIC_OGL is defined

Recently I noticed gDEBugger stopped working, and after removing DYNAMIC_OGL, it started working again.
This suggests that gDEBugger can only hook OpenGL functions statically linked to the app, not dynamically loaded ones. Should we disable this by default, when we build lime without ANGLE?

I'm not sure if there's a way we could make it work with dynamic OpenGL?
Our problem that is if we statically link to OpenGL, this can fail on systems without OpenGL installed. Perhaps this more an issue on Linux than Windows, though

Then can we enable this only on Windows?
As of today, all windows systems comes with basic OpenGL support (opengl32.dll), so this shouldn't be a problem for Windows. Newer OpenGL functions are always dynamically loaded with wglGetProcAddress().
Even though this flag is named "DYNAMIC_OGL", functions existed in fixed-pipeline OpenGL is still dynamically linked, at least on Windows. It's implemented in opengl32.dll. Compiler automatically inserts library loading call at startup if this flag is disabled.

source: gharchive/issue

authors: jgranick vroad

repo: openfl/lime

license: mit

license_source: bigquery


text:
[OSX] Failed to install OpenFL via 'haxelib install openfl'

I followed the instructions of the official site, installed Haxe through installer, then run 'haxelib install openfl', I got these:

xarples-MacBook-Air:~ xarple$ haxelib install openfl
Downloading openfl-3,6,1.zip...
Download complete : 0 bytes in 0.6s (0KB/s)
Eof
xarples-MacBook-Air:~ xarple$

Did I missed something steps?
Thanks.

This was an issue with the haxelib server, it sounds like. It should be working now
Thank you! :smile:

authors: jgranick xarple

repo: openfl/openfl


text:
:app:compileDebugJavaWithJavacNote: Some input files use or override a deprecated API.

:app:compileDebugJavaWithJavacNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

just warnings in unit tests code

authors: herau teolemon

repo: openfoodfacts/OpenFoodFacts-androidApp


text:
feat: improved app rating flow

What
Refined the App rating flow issue #3420
Screenshot
Before

After

Run flutter format --set-exit-if-changed .
Formatted packages/smooth_app/lib/pages/user_management/login_page.dart
Formatted 334 files (1 changed) in 1.53 seconds.
Formatting failed: 1
Error: Process completed with exit code 1.

@Omegaviv
 info • Prefer final for variable declarations if they are not reassigned • packages/smooth_app/lib/pages/user_management/login_page.dart:349:13 • prefer_final_locals
   info • Use Flutter TODO format: // TODO(username): message, https://URL-to-issue • packages/smooth_app/lib/pages/user_management/login_page.dart:382:19 • flutter_style_todos
   info • Avoid `print` calls in production code • packages/smooth_app/lib/pages/user_management/login_page.dart:383:19 • avoid_print
   info • Only use double quotes for strings containing single quotes • packages/smooth_app/lib/pages/user_management/login_page.dart:383:25 • prefer_single_quotes

Codecov Report

Merging #3439 (15c9e05) into develop (a0b2e46) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3439      +/-   ##
===========================================
- Coverage    11.29%   11.27%   -0.02%
===========================================
  Files          260      260
  Lines        12561    12583      +22
===========================================
  Hits          1419     1419
- Misses       11142    11164      +22

Impacted Files
Coverage Δ

...ooth_app/lib/pages/user_management/login_page.dart
49.69% <0.00%> (-7.65%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Congrats on your first PR here @Omegaviv 🎉

Congrats on your first PR here @Omegaviv tada

Thank you @M123-dev

authors: M123-dev Omegaviv VaiTon codecov-commenter teolemon

repo: openfoodfacts/smooth-app


text:
Add france to setup

France is missing in setup file

@cyberp   The euro 2016 in france is still a work in progress, that is, it is NOT working for now. e.g. adding it to the setup will "break" the setup.

authors: cyberp geraldb

repo: openfootball/euro-cup


text:
Modify OFF-EP template to include "Alternatives considered" section?

It would be useful for the OFF-EP template to include an "Alternatives considered" section, since this would prevent future suggestions from slowing the process down if they have already been considered and found to be sub-optimal.
What is the process for amending the OFF-EP template? Should I just open a PR into the off-ep-template.md file from a branch, or should this change be itself subject to the same OFF-EP process?

This is a good idea. It looks like there already is an "Alternatives" section in the template that is similar what you describe. Does this cover your needs, or would you propose a different wording?

What is the process for amending the OFF-EP template? Should I just open a PR into the off-ep-template.md file from a branch, or should this change be itself subject to the same OFF-EP process?

I'd think that changes to the EP template should be made through an EP, but nowhere do we write that the template document is actually part of the EP process. So maybe an EP that both:

changes the template, and
lays out a formal process for submitting EPs, that specifies which parts of the template must be populated.

Ah, actually we DO write that the template should be used, but it's not clear if it must be used, or which parts are required. So we could specify the requirements with regard to those topics there.

If there were any alternative solutions to solving the same problem, they should be discussed here, along with a justification for the chosen approach.

Ah! It's indeed already there. My apologies.

IIRC I removed unused sections instead of leaving them blank. I can see why leaving them blank would have been better. Sorry for the resulting confusion!

authors: j-wags jchodera mattwthompson

repo: openforcefield/standards

license: MIT


text:
✅(frontend) separate test that takes screenshot from others

Purpose
This is an attempt to get more stable tests.
Proposal

[x] separate test with screenshots from others
[x] increase jest timeout for a long test

This is what I suggest:

you can keep the new added jest command in the package.json.
you can remove all screenshots that are not SVG but be sure that a test is covering what the screenshot was doing.
Keep the syntax you introduce with [screenshot] in the title

@lunika @roro-lv this PR is ready for review.

authors: kernicPanel lunika

repo: openfun/marsha


text:
Improve printing of ObsData objects

At the moment ObsData object just print all the Dataset information and then a load of metadata, this looks quite messy and needs tidying.

Suggestions from @brendan-m-murphy

Could just add a new line to improve this

Could also quickly review other improvements but should be treated as quick issue to fix.

repo: openghg/openghg


text:
docs

Add readme.md files for react boilerplate and terminal component, include:

purpose and architecture of react boilerplate
how to create new components using react boilerplate
purpose and architecture of terminal component
any additional information that will help the next developer

Fulfileld by https://github.com/openh2labs/elastic-erga/pull/76


text:
Plugin and improvements

Improved documentation and language, introduced plugin architecture and decoupled chain-specific logic from the chain module.
This enables smaller development steps and is the final design (not yet fully implememented as protocols / scrapers are missing).

Decided together  to merge the branch (localchain and ERC-20 test from README is working).
Subsequently, based on new main, Protocol/Index-querying as well as NPM-packages (#11 ) will be implemented.
Bugfixes have been rebased into the original commits.

authors: IbexLabsLuk tbergmueller

repo: openibex/openibex


text:
add cpu dockerfile

Not sure if this is helpful, but the following commands worked from the project root for me using this branch
$ docker build -t equibind_cpu -f cpu.Dockerfile .
$ docker run -it equibind_cpu bash
If this useful I can clean up the file and do a multistage with the GPU Dockerfile to make maintaining easier.
Also, let me know if there are any test commands I can use inside the Docker container.

@NiklasTR merge plz

Hi team - @McMenemy and @kjwallace is this ready to be merged?

Hi team - @McMenemy and @kjwallace is this ready to be merged?

authors: McMenemy NiklasTR kjwallace

repo: openlab-apps/equibind


text:
overlay setVisible

Why should the overlay  setVisible method be made protected?

setVisible() is not part of the @api. To temporarily hide them, it's better to remove them from the map.

repo: openlayers/openlayers


text:
vector layer not showing

I am trying to add a vector layer to a map using the following code but not showing on the map:
var geojsonFormat = new GeoJSON({ dataProjection: "EPSG:3978" });
          var features = geojsonFormat.readFeatures(jsonData);
          let layer = new VectorLayer({
            visible: true,
            source: new VectorSource({
              features: features,
              format: geojsonFormat,
            }),
          });

          mapObject?.addLayer(layer);

JSON that is being transformed into GEOJSON
custom.geo.json

I am able to see the layer added to the map object but it is not visible on the canvas even though its visibility is set to true. Below it is layer number 12

Are you sure your GeoJSON is in EPSG:3978? To me it looks like a standard WGS84 GeoJSON. So you need to remove the dataProjection config option.

I tried without the projection as well but still nothing on the canvas

does anybody using laravel for the openlayers? cause i got an issue when i try to display the map using basic instruction and it not show up. I need your help please, i try to check the error and there is no error in console or in network browser

does anybody using laravel for the openlayers? cause i got an issue when i try to display the map using basic instruction and it not show up. I need your help please, i try to check the error and there is no error in console or in network browser

what's your problem in php and openlayers?

authors: ahocevar jacklinna prosperva raiden909


text:
I found a hit detection bug with WebglPointsLayer

Describe the bug
I have a WebglPointsLayer, which clears its source and inserts 10,000 features every 2 seconds. I observed that the forEachFeatureAtPixel method hit detection works fine at the beginning, but problems occur after running for a while. When the mouse selects a feature, the hit is not the feature I selected.
I noticed that at this point, the ol_uid of each newly added feature reaches 8 digits in length. The forEachFeatureAtCoordinate method of WebGLPoints has code related to ol_uid. I suspect that this phenomenon might be related to ol_uid. Of course this is just my guess, I hope someone can answer my question.
To Reproduce
Steps to reproduce the behavior:

Create a WebglPointsLayer
Every 2 scondes, clear its source and inserts 10,000 features.
See error

Expected behavior
Hit detection works fine.

Feature's ol_uid values are stored and read in a Float32Array. This can indeed lead to some precision issues when reaching integers in the range of 10,000,000. After how long does the problem typically appear?

Feature's values are stored and read in a Float32Array. This can indeed lead to some precision issues when reaching integers in the range of 10,000,000. After how long does the problem typically appear?ol_uid

@jahow Sorry, I just realized that I wrote the wrong number of features. When inserting 100,000 features every 2 seconds, this situation would occur within a few minutes. I found that by this time, the ol_uid had already exceeded 10,000,000.

Ok, then it makes sense. Do you think you could reuse Features instead of recreating new ones? Especially if they're points, you might simply be able to update their coordinates.
We could also store the rendering instructions in Float64 instead (which also contains ol_uid), but the impact of this has to be evaluated.

Thanks for your answer. I will give it a try. By the way, I guess #14277 may also be due to this issue.


text:
Define a folder structure

The repository needs to be navigable and consumable by readers.
The need here is to define a set of principles for the hierarchy of folders to clearly segment the content.
Whilst the majority of the content might be Markdown, we will accommodate other asset formats as appropriate.

Of course, it's possible to define an initial set of folders in a branch/PR for discussion.

Some ideas to start...
Application Modernization:
•	Code analysis for planning
•	Refactor monolithic applications
•	Unlock application value through APIs
•	integrate with other modern languages
•	Leverage managed services (XaaS) such as databases, analytics and storage
Process Modernization:
•	Move to modern source code management systems
•	Implement Agile practices
•	Implement DevSecOps
•	Adopt modern development tools
•	Automate unit testing
•	Implement DevOps
•	Adopt CI/CD
Infrastructure Modernization:
•	Target containers and orchestration for reliable and faster application delivery
•	Re-platform applications to commodity x86 hardware
•	Use containerization and Infrastructure as Code
•	Implement a multi-cloud model
•	Migrate COBOL and mainframe applications to the cloud
•	Use virtualized and containerized platforms

I was really intending this issue to solely consider the shape of the folder structure to accommodate topics, rather than define the content/topics to be accommodated.
But I guess we could have a go at doing both and see how it goes.

agree with @pwmccaffrey and @ijmitch above assumes scope agreement, lets focus on work/process content structure.  so @ijmitch are you looking for content category bill of materials?  ie, guidebook, roadmap, code snippets, architecture, best practices, blah blah?

agree with @rpomp et al.

There are a number of things on @rpomp’s list that hadn’t occurred to me.
How about we start by collecting some examples of what people think should be in the repository?
I’ll start a Wiki just to collect some ideas and then we can draft an INITIAL structure out of that.
Remember that this is our first take on a structure.  Nothing says we can’t decide two months from now or a year from now that another structure will work better.

authors: MistyDecker gmackinnon ijmitch rpomp

repo: openmainframeproject/wg-modernization


text:
Edge to edge support

Navigation bar is black.

Thanks, @ddolny for the research. Let's keep it monitored. Will leave this issue open to track it down the road.

repo: openmobilehub/react-native-omh-auth


text:
test if nest environment can be installed on a base rocker/r-base container

depends on #49

Pretty sure this will fail https://github.com/openpharma/staged.dependencies/issues/60#issuecomment-896632466 so this issue is to make it work...

This depends on PR #69.
Then, you can do the following to install NEST:
docker run \
--name rbaseDocker \
-d --rm \
rocker/r-base:4.1.1 tail -f /dev/null

docker exec -it rbaseDocker bash

apt-get update && apt-get install -y libxml2-dev libcurl4-openssl-dev libssl-dev libgit2-dev

docker exec -it rbaseDocker R

install.packages("remotes")
remotes::install_github("openpharma/staged.dependencies", ref = "46_installFromRemoteRepos")

Sys.setenv(GITHUB_PAT = "<TOKEN>")

staged.dependencies::install_deps(list(list(
  repo = "insightsengineering/utils.nest",
  host = "https://github.com"
)), feature = "main", direction = c("upstream", "downstream"), verbose = 2)


text:
A559085148719353 fixed dutch steps

In case of 100 rounds, final amount would be equeal to 1
Update tests due to new auctionParameters logic

Coverage increased (+0.02%) to 83.006% when pulling 503ab09fc782a5038548d3643ec136bf493aa3f7 on Scandie:a559085148719353_fixed_dutchSteps into 05f67365333148ea9079d8ed57febbe989eb75d9 on openprocurement:sandbox.

authors: Scandie coveralls


text:
Add Allowlist match function to OP providers

We currently (as of PR #86) do not handle the case where the same provider (OP) is specified twice in an allowlist with different audiences. That is same providers sharing the same Issuer but having separate audience claims. Instead it will match on the first provider with the correct issuer and then verify using that provider.
The reason we check for matches rather than just verifying is to avoid blindly downloading a JWKS URI based on the issuer (iss) claim of an ID Token. Instead we check that the issuer is correct and then run verification.
The ideal way to solve this problem is to add a function to the (OP) Provider interface called something like Matches(idt IDToken) (bool) and let each provider determine how decides if an ID Token belongs to it.

I don't think we need this. Instead each provider verifier can check if the token matches that provider verifier and fail early. We no longer need to build this

repo: openpubkey/openpubkey


text:
Check if TX exists in RocksDB

Changes

(List your changes here)

Reminders

[ ] Add a prefix to PR: feat: (for features), chore: (for chores/refactoring), fix: (for bug fixes), or any from: https://www.conventionalcommits.org/en/v1.0.0/#summary
[ ] Assign reviewers
[ ] Link related issues
[ ] Make it draft if it is still WIP
[ ] Write unit tests for your code if possible
[ ] Do manual testing and make sure your changes don't break the rest of the codebase

Closing in favour of #207

repo: openrankprotocol/openrank


text:
Fix typo that terraform plan didn't pick up

😭

👍  to the rescue!

u r my hero

repo: openregister/deployment


text:
Port changes and tests from ngx_http_lua v0.10.15

Sister PRs:

https://github.com/openresty/meta-lua-nginx-module/pull/71
https://github.com/openresty/lua-nginx-module/pull/1577
https://github.com/openresty/lua-nginx-module/pull/1579

Some slight updates to be made for the tests to pass on Travis, will update the PR later.

repo: openresty/stream-lua-nginx-module


text:
feat(104): added acd as a supported ens type

closes #1353

@Stef3st I tested the CDC=ENC. It works very well.

repo: openscd/open-scd


text:
Update docker commands to reflect reduced caps necessary for CVMFS

(SOFTWARE-4477)
Success here: https://github.com/opensciencegrid/osgvo-docker-pilot/pull/35

@DrDaveD I added https://github.com/opensciencegrid/docs/pull/874/commits/d6350cf301e9da48a3fd7aef502a1d776b37e174, which I think should satisfy your request

CI failures unrelated, merging

repo: opensciencegrid/docs


text:
Questions Developers Ask

http://openscience.us/repo/other/questions.html

Data changed from external to internal. Done

authors: bigfatnoob dapryor


text:
[Remote Routing Table] Create Service for remote routing table storage

Is your feature request related to a problem? Please describe
Create a RemoteClusterStateService which would orchestrate the upload to blob storage. This service would be similar to RemoteClusterStateService
Related component
ShardManagement:Routing

[Triage - attendees 1 2 3 4 5 6 7 8]
@himshikha Thanks for creating this issue; however, it isn't being accepted due to not having enough detail on why the change should be made nor the impact when it is resolved. Please feel free to open a new issue after addressing the reason.

authors: himshikha peternied

repo: opensearch-project/OpenSearch


text:
[Remote translog] Make translog buffer interval setting dynamic

Description
This PR attempts to make the remote translog upload buffer interval setting dynamic to allow changes even after index creation.
Related Issues
Resolves #8172

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Will raise manual backport.


text:
[BUG] Alerting API throws 405 error

What is the bug?
Following the documentation to create an alerting destination https://opensearch.org/docs/latest/observing-your-data/alerting/api/#create-destination, I have the following command
curl -XPOST "http://admin:admin@localhost:9200/_plugins/_alerting/destinations" -d "{'name': 'my-destination','type': 'slack','slack': {'url': 'http://www.example.com/'}}"  -H 'Content-Type: application/json'

However I get the following error:
{"error":"Incorrect HTTP method for uri [/_plugins/_alerting/destinations] and method [POST], allowed: [GET]","status":405}

For 1.x it used be /_opendistro/_alerting/destinations and works fine but /_plugins/_alerting/destinations throws 405 error.  Is this a bug from alerting API?
Do you have any additional context?
I’m working on to adding 2.x support for terraform provider https://github.com/opensearch-project/terraform-provider-opensearch/pull/62 and found this issue.
Related Issues:
https://github.com/opensearch-project/terraform-provider-opensearch/issues/30
https://github.com/opensearch-project/documentation-website/issues/1994
https://forum.opensearch.org/t/unable-to-create-alerting-destination-in-v2-1-0/10479

The notifications API works  _plugins/_notifications/configs
https://opensearch.org/docs/latest/observing-your-data/notifications/api/
so the destination is now called channel ?
curl -d '{
  "config_id": "sample-id",
  "name": "sample-name",
  "config": {
    "name": "Sample Slack Channel",
    "description": "This is a Slack channel",
    "config_type": "slack",
    "is_enabled": true,
    "slack": {
      "url": "https://sample-slack-webhook/"
    }
  }
}' -H "Content-Type: application/json" -X POST 'http://admin:admin@localhost:9200/_plugins/_notifications/configs/'

Oh the documentation is not updated. Alerting destinations have been deprecated in 2.0 and we do not allow the creation of new alerting destinations. The user needs to use Notification channels instead.

authors: lezzago prudhvigodithi

repo: opensearch-project/alerting


text:
[BUG] Index mapping updates do not get replicated

What is the bug?
Updating an index mapping on the cluster leader does not get replicated in many circumstances.
The cluster replication plugin periodically checks for index mapping updates but only applies them if an already existing property mapping known to the follower gets modified.
Code reference: https://github.com/opensearch-project/cross-cluster-replication/blob/2e04b0e4efb4b8e2022464f3cad2f1f28ce71b81/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt#L576
This breaks index mapping updates that only add mappings for new properties or modify dynamic mappings. If an existing property mapping gets modified however the replication will apply the entire mappings - including dynamic mappings.
Possible workaround: Modify also an existing property mapping, e.g. add a meta field to the property mapping.
How can one reproduce the bug?
Steps to reproduce the behavior:

Create an index with at least one property mapping on the cluster leader.
Enable the cluster replication and wait until the index gets replicated to the follower.
Add new property to the index mappings on the cluster leader.
Wait and see that nothing gets replicated.
Modify the existing property from step 1 by adding a "meta": {"force": "true"}
Wait and see that the mapping gets replicated.

What is the expected behavior?
Any index mapping update on the cluster leader should get replicated with no workarounds required.
What is your host/environment?

OS: 2.11 and 2.13

Do you have any screenshots?
N/A
Do you have any additional context?
N/A

[Catch All Triage - 1, 2, 3, 4, 5]

@alexmm-amzn Thanks for digging into the code. Want to give writing a test that reproduces this problem a try? Maybe fix the issue?

authors: alexmm-amzn dblock


text:
[BUG] Misused the term and name of data source in the observability plugin.

What is the bug?
The data source term used in this plugins is mis-used.
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to '...'
https://playground.opensearch.org/app/datasources#/

What is the expected behavior?
This should be called Data Adapter or Data Connector rather than Data Source.
There is already OSD build-in datasource feature launched in 2.4. we should either rename this to avoid confusion. or merge this into the build in data-source management, include move the storage to the .opensearch_dashboards index.

What is your host/environment?

OS: All
Version: all supported
Plugins: Obserability

Do you have any screenshots?

Hi @anirudha @brijos @kgcreative
could we triage and build a consensus


text:
MAINT: migrate peer forwarder to event model

Description
This PR

migrates peer-forwarder to use event model.
recovers the muted e2e tests
increase the window_duration in service-map e2e test for the test to pass

With merging of this PR, it mostly wrapped up #546 except that there could be a few places for overall minor cleanup.
Issues Resolved
Resolves #610
Contributes to #546
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (maint/546-migrate-trace-analytics-to-event-model@3e634fd). Click here to learn what that means.
The diff coverage is n/a.

@@                                 Coverage Diff                                 @@
##             maint/546-migrate-trace-analytics-to-event-model     #935   +/-   ##
===================================================================================
  Coverage                                                    ?   91.58%
  Complexity                                                  ?      642
===================================================================================
  Files                                                       ?       75
  Lines                                                       ?     1914
  Branches                                                    ?      163
===================================================================================
  Hits                                                        ?     1753
  Misses                                                      ?      121
  Partials                                                    ?       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e634fd...43a3e95. Read the comment docs.

The service-map e2e test turns out to be flaky. Will still mute it in the PR and need to investigate further.

@cmanning09 Thanks for the review. I also recovered service-map e2e test in the new changes with minimal adjustment.

repo: opensearch-project/data-prepper


text:
[DOC] Incorrect description of default value for indices.breaker.total.use_real_memory

What do you want to do?

[x] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
The documentation states that the default value of indices.breaker.total.use_real_memory is false, but in the source code it is set to true.
https://github.com/opensearch-project/documentation-website/blob/main/_install-and-configure/configuring-opensearch/circuit-breaker.md?plain=1#L18
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/indices/breaker/HierarchyCircuitBreakerService.java#L91

Thanks, @hogesako - do you want to take a stab at creating a PR for the fix?

@hogesako Nicely done! I'll send this through doc review. Thanks!

authors: hdhalter hogesako


text:
Correct the default value for ops_batch_size setting

Description
The default value of ops_batch_size is 50000 as specified here: https://github.com/opensearch-project/cross-cluster-replication/blob/main/src/main/kotlin/org/opensearch/replication/ReplicationPlugin.kt#L165
Modifying the documentation to reflect the same.
Issues Resolved
NA
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This setting has been the same in CCR plugin since the beginning. So please backport to 1.3, 2.0, 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7 and 2.8.


text:
Add boxplot documentation to close aggregations content gaps

Description
Add documentation to close content gaps
Issues Resolved
Closes #4293
Checklist

[ X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bowenlan-amzn , @sandeshkr419 - Can you please review for technical accuracy? Thanks!

Boxplot is not a feature in OpenSearch. Closing PR.

authors: hdhalter vagimeli


text:
[BUG] kNN score discrepancy after update to 2.17

Describe the bug
After updating from version 2.11 to 2.17 on AWS OpenSearch (I know it's a large step, but bear with me), we noticed a significant score variation for newly indexed documents. For documents already in the index, the kNN score remains consistent across OpenSearch versions. However, if you re-index the same document, the score drops dramatically (e.g., from 0.72 to 0.12).
Upon further investigation using local OpenSearch versions, we identified that the issue arises when updating from 2.15 to 2.17.
The root cause appears to be related to the index.knn.space_type setting, which is documented here as deprecated. When we use the new approach of setting space_type directly in the field, the issue is resolved. However, this solution requires re-indexing all our documents, which is a significant drawback.
I couldn't find any mention of the deprecation or removal of support for this setting in the release notes. Is this the expected behavior?
Related component
Indexing
To Reproduce

Using OpenSearch 2.15, create an index with index.knn.space_type setting, don't use the space_type option in the field and index some documents
Perform a search and check if the semantic score makes sense
Update OpenSearch to 2.17 and index the same documents
See different score from 2.15

Extra:

Using OpenSearch 2.17, create a new index using space_type option in the field instead of index.knn.space_type and index the same documents
See same score from 2.15

Expected behavior
It was expected that the minor version update would not change the behavior of index.knn.space_type
Additional Details
Plugins
All plugins enabled by default from AWS OpenSearch
Host/Environment:

AWS OpenSearch
Official OpenSearch containers

@tiagohconte we can move issues, you can close one of them as dup

authors: dblock tiagohconte

repo: opensearch-project/k-NN


text:
Upgrade gradle to 8.4

Description
Upgrade gradle to 8.4 to support JDK-21. Refer to
https://docs.gradle.org/current/userguide/compatibility.html
Issues Resolved
N/A
Check List

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 can we check why windows JDK 11 is breaking?

@navneet1v Right, I thought windows was broken anyway - didnt realize we fixed it. Let me check what happened.

@navneet1v I fixed the windows issue by simplifying the jacoco logic. There were some outdated hacks in there that no longer apply because the OpenSearch TestTask and IntegTestTask extend the gradle Test class now.


text:
Release version 2.0.0 (GA)

This is a component issue for 2.0.0 (GA).
Coming from opensearch-build 2086. Please follow the following checklist.
Please refer to the DATES in that post.
How to use this issue

This Component Release Issue
This issue captures the state of the OpenSearch release, on component/plugin level; its assignee is responsible for driving the release. Please contact them or @mention them on this issue for help.
Any release related work can be linked to this issue or added as comments to create visiblity into the release status.
Release Steps
There are several steps to the release process; these steps are completed as the whole component release and components that are behind present risk to the release. The component owner resolves the tasks in this issue and communicate with the overall release owner to make sure each component are moving along as expected.
Steps have completion dates for coordinating efforts between the components of a release; components can start as soon as they are ready far in advance of a future release. The most current set of dates is on the overall release issue linked at the top of this issue.
The Overall Release Issue
Linked at the top of this issue, the overall release issue captures the state of the entire OpenSearch release including references to this issue, the release owner which is the assignee is responsible for communicating the release status broadly.  Please contact them or @mention them on that issue for help.
What should I do if my plugin isn't making any changes?
If including changes in this release, increment the version on 2.0 branch to 2.0.0 for Min/Core, and 2.0.0.0 for components. Otherwise, keep the version number unchanged for both.

Preparation

[x] Assign this issue to a release owner.
[x] Finalize scope and feature set and update the Public Roadmap.
[x] All the tasks in this issue have been reviewed by the release owner.
[x] Create, update, triage and label all features and issues targeted for this release with v2.0.0.

CI/CD

[x] All code changes for 2.0.0 are complete.
[x] If this repo is core repo, use 2.0.0 version for your component; if this repo is plugin repo, use 2.0.0.0 version for your component. Qualifier should be empty '' see this issue for details: https://github.com/opensearch-project/opensearch-build/issues/2078.
[x] Ensure working and passing CI.
[x] Check that this repo is included in the distribution manifest.

Pre-Release

[x] Update to the 2.0 release branch in the distribution manifest.
[ ] Increment the version on the parent branch to the next development iteration.
[x] Gather, review and publish release notes following the rules and back port it to the release branch.git-release-notes may be used to generate release notes from your commit history.
[x] Confirm that all changes for 2.0.0 have been merged.

Release Testing

[x] Find/fix bugs using latest tarball and docker image provided in parent release issue and update the release notes if necessary.
[x] Code Complete: Test within the distribution, ensuring integration, backwards compatibility, and performance tests pass.
[x] Sanity Testing: Sanity testing and fixing of critical issues found.
[x] File issues for all intermittent test failures.

Release

[x] Complete documentation.
[x] Verify all issued labeled for this release are closed or labelled for the next release.

Post Release

[x] Prepare for an eventual security fix development iteration by incrementing the version on the release branch to the next eventual patch version.
[x] Add this repo to the manifest of the next eventual security patch version.
[x] Suggest improvements to this template.
[x] Conduct a retrospective, and publish its results.

Closing this issue as version 2.0.0 has been released.

authors: peterzhuamazon qreshi

repo: opensearch-project/notifications


text:
[Bug]: Documentation on dockerhub doesn't mention WHERE to place configuration YAML file

Describe the bug
The documentation  on docker hub states the following:
Just like opensearch.yml, you can pass a custom opensearch_dashboards.yml to the container in the Docker Compose file.

But doesn't say where this file should be mounted or what it's contents can be.
To reproduce
visit docker hub site
Expected behavior
No response
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

[Triage] Thanks for your input. We will be working to add more documentation to it.

authors: nobletrout zelinh

repo: opensearch-project/opensearch-build


text:
[release]: Data Prepper 2.2.1

Did you read the on-boarding document
Yes. We are planning to onboard to this for 2.3 release.
What is the name of your component?
Data Prepper 2.2.1
What is the link to your GitHub repo?
https://github.com/opensearch-project/data-prepper
Targeted release date
05/09/2023
Where should we publish this component?
Publishing to Docker Hub, ECS, opensearch.org artifacts, Maven Central.
The current Jenkins job publishes these.
What type of artifact(s) will be generated for this component?
Docker image
tar.gz artifacts
Maven artifacts
Have you completed the required reviews including security reviews, UX reviews?
Yes, this is a patch release.
Have you on-boarded automated security scanning for the GitHub repo associated with this component?
Yes.
Additional context
Data Prepper builds artifacts using GitHub Actions. This will publish to staging repositories. Our team is responsible for this portion. We will need the opensearch-build team to run the Jenkins job which promotes these to production.
A Data Prepper maintainer will supply the DATA_PREPPER_BUILD_NUMBER parameter.
Parameters:
VERSION: 2.2.1
RELEASE_MAJOR_TAG: true
RELEASE_LATEST_TAG: true
DATA_PREPPER_BUILD_NUMBER - To be supplied later.

VERSION: 2.2.1
RELEASE_MAJOR_TAG: true
RELEASE_LATEST_TAG: true
DATA_PREPPER_BUILD_NUMBER - 54

Downloads page PR: https://github.com/opensearch-project/project-website/pull/1578

We have completed the release activities on dockerHub, ECR, Maven, and tarball ..
@asifsmohammed will verify the artifacts
@krisfreedain to verify the website update https://github.com/opensearch-project/project-website/pull/1578

Verified all the artifacts. Thanks @peterzhuamazon @jordarlu

Data Prepper 2.2.1 is now live on the website

authors: asifsmohammed jordarlu krisfreedain


text:
[FEATURE] Fault tolerance

Is your feature request related to a problem?
There doesn't seem to be a way to configure retries in the Java client. This feature is present in the .NET client. The AWS SDK for Java 2.x retries requests as well and this behavior can be configured. I understand the situation is more complicated for OpenSearch as the SDK needs to support both Amazon OpenSearch and a self-hosted deployment.
I'm unsure of the best way to handle faults. I initially attempted to retry at the transport level, but both the Apache HttpClient 5 transport (here) and the AWS SDK 2 transport (here) disable retries. While it's possible to enable retries for the Apache HttpClient 5 transport, enabling retries for the AWS SDK 2 transport requires to muck with the internals of the library. This would also lead to two distinct implementations.
What solution would you like?
It would be great if the team could document the SDK's failure modes and provide guidance around fault handling. Different exceptions seem to be used for similar purposes. I'm unsure what the difference is between org.opensearch.client.transport.httpclient5.ResponseException and org.opensearch.client.opensearch._types.OpenSearchException. OpenSearchException seems to be more widely used, while ResponseException seems to be specific to the Apache HttpClient 5 transport. If I'm using the Apache HttpClient 5 transport, do I need to handle both?
What alternatives have you considered?
I've decorated specific operations with Resilience4j retries, but my configuration is based on experimentation and is likely to be incomplete.
Do you have any additional context?
Not really.

This is a big area we'd like help in, with https://github.com/opensearch-project/opensearch-clients/issues/27 being the umbrella for it.

authors: dblock gweyeratlassian

repo: opensearch-project/opensearch-java


text:
Merge Kafka Puller into Traffic Replayer

Description
This change merges the kafka puller into the replayer, and by doing so needed to accomplish the following items:

Adjust kafka consumer logic to work inside the replayer and update tests
Remove references to the kafka puller and its directory
Adjust docker solution to remove kafka puller and update replayer arguments
Adjust copilot to remove kafka puller and update replayer arguments

Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1149
Testing
Unit tests and manual deployment tests
Check List

[X] New functionality includes testing

[X] All tests pass, including unit test, integration test and doctest

[X] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm fine with most of the changes here except for deleting the KafkaPrinter project. It doesn't have a place in a production release, but it can be exceptionally valuable even today as a debug tool. I'm thinking of the case where the replayer chokes up. I'd love to hop onto the box/container and run this Kafka dumper program to output the Kafka stream to a log so that I can test the replayer later on. Let me know what you think about leaving the project in place (but deleting the container and doing all other refactoring)

If this is still valuable we shouldn't remove. My expectation was that we could leverage this with some debug enabled logic to achieve the same but it does feel a bit clunky as I think about it. My current stance is we should keep but if we are going to use it as a utility it should be integrated a little better


text:
[FEATURE] Optionally disable default certifi certificates

Is your feature request related to a problem?
I dislike certifi because it makes managing self-signed certificates difficult. I would prefer to use the system certificate store instead.
What solution would you like?
I believe the most straightforward solution would be to use ca_certs=None if it is explicitly set. Here's what I mean: change this
            # Convert all sentinel values to their actual default
            # values if not using an SSLContext.
            if verify_certs is VERIFY_CERTS_DEFAULT:
                verify_certs = True
            if ssl_show_warn is SSL_SHOW_WARN_DEFAULT:
                ssl_show_warn = True

            ca_certs = self.default_ca_certs() if ca_certs is None else ca_certs

to this
```python
            # Convert all sentinel values to their actual default
            # values if not using an SSLContext.
            if verify_certs is VERIFY_CERTS_DEFAULT:
                verify_certs = True
            if ssl_show_warn is SSL_SHOW_WARN_DEFAULT:
                ssl_show_warn = True

            ca_certs = self.default_ca_certs() if ca_certs is CA_CERTS_DEFAULT else ca_certs

What alternatives have you considered?
I can't think of any other viable solutions.

Maybe we could add ca_certs as an input parameter, introduce ca_certs = AUTO and default to it?
Either way appreciate a PR!

I think I can make some time this week

Maybe we could add ca_certs as an input parameter, introduce ca_certs = AUTO and default to it?

Yes, your option is probably better, as it is more explicit, but it deviates from the pattern of automatically determining default values used for verify_certs and ssl_show_warn. On the other hand, these are boolean variables, while we are changing str | Path | certifi | system_default. Alternatively, we could define constants like 'system' and 'certifi' to make it even clearer which paths will be checked. Please select the most preferable option. Also, are there any other suggestions for the Pull Request?

Thanks @nokados. My biggest concern is backwards compatibility, we cannot change the way existing parameters and their values work in the current interface without a major version bump, and a lesser concern future adaptability so we can keep changing it. We can always add of course. Give all these options a try and keep that in mind?

authors: dblock nokados

repo: opensearch-project/opensearch-py


text:
[FEATURE] Create RepositoryExtension interface

Description
Describe what this change achieves.
Issues Resolved
Fixes #329
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I apologize, but I am very confused, I would like to make a new one and try again.If that s okay.

Sometimes that happens when you're learning git.  My very first github PR I ended up deleting and trying again. :)

authors: dbwiddis kokibas

repo: opensearch-project/opensearch-sdk-java


text:
Rename trace-analytics to observability

Signed-off-by: Joshua Li joshuali925@gmail.com
Description
Trace-analytics repo is renamed to Observability, rename it here as well
Issues Resolved
https://github.com/opensearch-project/observability/issues/336
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

duplicate of 78d629d

repo: opensearch-project/project-meta


text:
Blog Post on IP2Geo processor

Describe the blog post your would like to write
How to add country of incoming requests based on IP address using IP2Geo processor
What is the title of the blog post?
New real time IP to Geo processor for OpenSearch
Who are the authors?
Who will be listed as the authors of this blog post
Heemin Kim, Junqiu Lei, Satish Nandi, Vamshi Vijay Nakkirtha
What is the proposed posting date?
9/22

Added comments. I will approve once the comments are addressed.

@krisfreedain - Blog is GTG. Let's publish.

Looks like this one has been satisfied. https://opensearch.org/blog/use-opensearch-benchmark-with-randomized-query-terms/

authors: heemin32 nandi-github nateynateynate pajuric

repo: opensearch-project/project-website


text:
Add install_demo_configuration Batch script for Windows

Description
As part of the effort to support windows distribution in 2.4.0 (https://github.com/opensearch-project/opensearch-build/issues/33) the security plugin needs a script to install the demo configuration on windows.
This PR introduces install_demo_configuration.bat with the same functionality as the bash script and installs the demo certificates and adds default config lines to opensearch.yml

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement
Issues Resolved
https://github.com/opensearch-project/security/issues/2148
Testing
Tested by going through the steps outlined on https://github.com/opensearch-project/opensearch-build/issues/33.
Replace step 6 with cd plugins/opensearch-security/tools & ./install_demo_configuration.bat
Screenshot below shows using https and logging in with admin account credentials:

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @cwperks adding this to backport 2.x.

Codecov Report

Merging #2161 (465a117) into main (e5ab646) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2161      +/-   ##
============================================
+ Coverage     61.02%   61.14%   +0.11%
- Complexity     3233     3238       +5
============================================
  Files           257      258       +1
  Lines         18110    18109       -1
  Branches       3229     3224       -5
============================================
+ Hits          11052    11073      +21
+ Misses         5476     5457      -19
+ Partials       1582     1579       -3

Impacted Files
Coverage Δ

...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java
84.78% <0.00%> (-0.33%)
:arrow_down:

...ch/security/privileges/PitPrivilegesEvaluator.java
96.42% <0.00%> (ø)

.../opensearch/security/OpenSearchSecurityPlugin.java
79.95% <0.00%> (+0.08%)
:arrow_up:

...earch/security/dlic/rest/api/MigrateApiAction.java
4.34% <0.00%> (+0.18%)
:arrow_up:

...earch/security/privileges/PrivilegesEvaluator.java
72.38% <0.00%> (+0.35%)
:arrow_up:

...arch/security/configuration/ClusterInfoHolder.java
66.66% <0.00%> (+0.81%)
:arrow_up:

...ty/configuration/ConfigurationLoaderSecurity7.java
70.43% <0.00%> (+4.04%)
:arrow_up:

...nsearch/security/dlic/rest/api/AuditApiAction.java
68.08% <0.00%> (+4.25%)
:arrow_up:

...ecurity/configuration/StaticResourceException.java
25.00% <0.00%> (+25.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Lets update the plugin_install.yml to deploy OpenSearch windows and test this new script.

Good idea - I will see what it takes to add this to the github workflow.

Lets update the plugin_install.yml to deploy OpenSearch windows and test this new script.

Good idea - I will see what it takes to add this to the github workflow.

Plugin install currently runs on Ubuntu. In that case we will have to add a new workflow for windows.

@opensearch-project/security This PR is now ready for further review. Thank you @scrawfor99 for figuring out how to automate the validation of this change by adding a new job in plugin_install to install this on a windows running and verify the node is brought up successfully.
Note: For the merge into main we are disabling this job because the distribution for 3.0.0 is not stable and the node does not get brought up successfully. This job will be enabled in 2.x when this change is backported.

@peterzhuamazon Tagging in case you know someone who can help answer a problem we are facing. As part of this PR to add the batch script for install_demo_configuration.bat this PR adds a new job in the plugin_install.yml Github Action to verify the installation on windows - as we also do with linux. This runs on the windows-latest github runner.
We are currently facing a problem where the opensearch node does not startup (the command .\bin\opensearch.bat because the windows-latest runner is invoking the command as admin and opensearch does not allow the node to run as admin.
In the linux install we add a user and run with the newly created user. It looks like the corresponding windows commands would be:
net user "username" "<password>" /add
runas /user:username ".\bin\program.bat"

but runas prompts for user input and both passwordless and piping in a password are unsupported.
The github action we created works on 2.x, but not on 3.0. It only works on 2.x because this PR (https://github.com/opensearch-project/OpenSearch/pull/4656) has not yet been backported to 2.x.

@dbwiddis Tagging to see if you have any ideas. See the comment above.
The gist of the problem is that the commands inside of the windows-latest Github Action runner run as admin and its not possible to bring up an OpenSearch node using admin in windows.

@cwperks looks like you can use runas with a trust level:
runas /trustlevel:0x20000 "YourCommandHere"

I don't have a windows machine to test, but runas /showtrustlevels should tell you what the numbers mean.

Another idea is using Powershell:
powershell "Start-Process -Verb Runas '<command here>' -Wait"

There's this compiled program you could wrap around your program:  https://github.com/wez/EleDo

@dbwiddis Thank you for the quick reply! Trying these ideas out now.

@cwperks and @scrawfor99 poking back in as I see some activity trying the trustlevel. Some thoughts:

I think it requires a full path, won't work with the relative link
another option I saw is to invoke via explorer.exe. It always starts with least privileges. But I'm not sure the syntax for that.
I saw the following batch file that claims to work:

Set ApplicationPath="C:\Program Files\SomeApp\testapp.exe"
cmd /min /C "set __COMPAT_LAYER=RUNASINVOKER && start "" %ApplicationPath%"

I am going to jot down a running list of the things I tried so that if we run into this problem again in the future we have an idea what is worthwhile:
~trustlevel 2000 with relative path~
~trustlevel 2000 with absolute path~

Command-line switch to disable the running as root check for tests ... 😉

Haha that is certainly an option and may be what I end up doing. I do greatly appreciate all your suggestions and help with this. I think GitHub Actions is still a little finicky and I am not the Windows expert others may be.

At one point in time there may have been something similar to:
if (Boolean.parseBoolean(System.getProperty("os.insecure.allow.root"))) {
      logger.warn("running as ROOT user. this is a bad idea!");
}

in Bootstrap.java, but there is no such option.
I'm not sure if it helps, but github's documentation says UAC is disabled on the runners. See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#administrative-privileges
Ideally, the workflow creates a user opensearch and uses this user account to bring up a node.

@opensearch-project/security The new plugin-install job on windows is working now after the revert from core and new snapshot distribution. This is ready to be reviewed again - there is a link to a snapshot distribution that will need to be updated when an official distro is published.

Removing the old Plugin Install task from required checks and replace it with linux-install and windows-install to unblock the merge.

I am going to jot down a running list of the things I tried so that if we run into this problem again in the future we have an idea what is worthwhile:
~trustlevel 2000 with relative path~ ~trustlevel 2000 with absolute path~ ~Start-process runas~ ~Normdo -- lacks enough documentation for me to debug running errors~ ~explorer.exe does not start~

Tried a few more things, documented here

See https://github.com/opensearch-project/OpenSearch/issues/4942#issuecomment-1301733503

Thank you @dbwiddis. I saw your comment this morning and was trying to apply it on this branch https://github.com/cwperks/security/tree/windows-paexec but have still been unsuccessful in bringing up the node. I am able to use both psexec and paexec on a windows computer, but still struggling within the github runner.

I found that having the .cmd extension on the "batch file" seemed to do something magical that I can't explain..

Specifically: cmd /c xyz only works with built in commands.  But it worked calling xyz.cmd directly.  And did not work with some other extensions.

https://stackoverflow.com/questions/148968/windows-batch-files-bat-vs-cmd
Seems like not that much differences?
I am also wondering as I indeed see more .cmd back in the day than it is now.
Thanks.

Seems like not that much differences?

I suspect it was the error value difference that I saw...

authors: DarshitChanpura cliu123 codecov-commenter cwperks dbwiddis peterzhuamazon scrawfor99

repo: opensearch-project/security


text:
injector: Idiomatic logging of error messages with log.Error().Err(err)

This PR rewrites log statements that attempt to log an err message using log.Error().Msgf(err) to using log.Error().Err(err).Msgf()

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Codecov Report

Merging #2348 (ec90995) into main (05677b0) will increase coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
+ Coverage   57.28%   57.29%   +0.01%
==========================================
  Files         149      149
  Lines        6653     6653
==========================================
+ Hits         3811     3812       +1
+ Misses       2837     2836       -1
  Partials        5        5

Impacted Files
Coverage Δ

pkg/catalog/routes.go
79.03% <20.00%> (ø)

pkg/injector/webhook.go
76.64% <25.00%> (ø)

pkg/injector/profiling.go
100.00% <100.00%> (ø)

pkg/envoy/route/config.go
96.03% <0.00%> (+0.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05677b0...ec90995. Read the comment docs.

Codecov Report

Merging #2348 (ec90995) into main (05677b0) will increase coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
+ Coverage   57.28%   57.29%   +0.01%
==========================================
  Files         149      149
  Lines        6653     6653
==========================================
+ Hits         3811     3812       +1
+ Misses       2837     2836       -1
  Partials        5        5

Impacted Files
Coverage Δ

pkg/catalog/routes.go
79.03% <20.00%> (ø)

pkg/injector/webhook.go
76.64% <25.00%> (ø)

pkg/injector/profiling.go
100.00% <100.00%> (ø)

pkg/envoy/route/config.go
96.03% <0.00%> (+0.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05677b0...ec90995. Read the comment docs.

authors: codecov-io draychev

repo: openservicemesh/osm


text:
[release-v1.15] Add observedGeneration in JobSink OpenAPI schema

Backport of https://github.com/knative/eventing/pull/8297

/cherry-pick release-v1.16

/lgtm

/retest

authors: mgencur pierDipi

repo: openshift-knative/eventing


text:
Add templates to be used with kube-compare

This is a temporary directory for a copy of the reference-crs to be used with kube-compare
/cc @MarSik @imiller0

/approve

There are a couple of improvements that have been suggested that we will take up as separate PRs which can be reviewed individually.

authors: MarSik imiller0 nocturnalastro

repo: openshift-kni/telco-reference


text:
Update version command to get version of particular component

This patch adds flag component to get the
version of a particular component and also
version command show available component versions

closing this PR as there is better implementation in this PR https://github.com/openshift-pipelines/opc/pull/161

repo: openshift-pipelines/opc


text:
Remove runs.tekton.dev from kcp-syncer

Signed-off-by: Romain Arnaud rarnaud@redhat.com

@adambkaplan I've opened this PR based on your feedback on the AppStudio M8 demo.

Note - this should not impact users meaningfully. We are not enabling custom tasks in the TektonConfig, which means Run objects are not reconciled.
See https://github.com/openshift-pipelines/pipeline-service/blob/main/gitops/argocd/tektoncd/tekton-config.yaml.

repo: openshift-pipelines/pipeline-service


text:
Simplify Job templates

There are couple of things in the Jobs which can be simplified like:

Move and replace repos in the personal github namespace to openshift-scale organisation.
Clone a repo with just the keys instead of cloning the entire perf-dept repo.
Cleanup unused vars.
Add support to use workload tooling ( https://github.com/openshift-scale/scale-ci-pipeline/issues/4 )

https://github.com/openshift-scale/scale-ci-pipeline/pull/7 merged

@sjug This issue covers the modifications we need to make on top of #7. Will keep updating the issue as we resolve them. Thanks.

authors: chaitanyaenr sjug

repo: openshift-scale/scale-ci-pipeline


text:
Bug 1721161: Fix typo art.yaml

Describe what this PR does and why we need it:
Typo in art.yaml. The file name was not updated to a minor version and therefore need to change art.yaml to reflect the actual name of the file.

/lgtm

Coverage remained the same at 40.97% when pulling 8685841dd3a406b74c26bbf4d5c3c222918ac2a5 on shawn-hurley:fix-typo-art.yaml into fc214665b006c6c3325b27df08702feae859f4e8 on openshift:release-4.1.

required to ship a minor release.  approved.

authors: coveralls derekwaynecarr fabianvf shawn-hurley

repo: openshift/ansible-service-broker


text:
move logging nodeselectors to inventory logging.yml

move logging nodeselectors to inventory logging.yml
this should fix current logging CI issues

/lgtm
thanks @richm I was going to try a few different permutations to fix this, I think this is the cleanest approach

authors: ewolinetz richm

repo: openshift/aos-cd-jobs


text:
CCO-412: Promote azureWorkloadIdentity to defaultFeatures.

Promote the azureWorkloadIdentity feature from the TechPreviewNoUpgrade featureSet to defaultFeatures.
Corresponding cluster-config-operator pr: https://github.com/openshift/cluster-config-operator/pull/345
Feature periodic: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/logs/periodic-ci-openshift-cloud-credential-operator-release-4.14-periodics-e2e-azure-manual-oidc

/hold

e2e test showing feature stability can be found here: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/logs/periodic-ci-openshift-cloud-credential-operator-release-4.14-periodics-e2e-azure-manual-oidc

/cc @sdodson We would like to promote this feature before branching. I have linked the relevant periodic in the description showing the stability. There were three failures in the past 15 daily tests. Two of them were due to azure replication delays, which we have mitigated with https://github.com/openshift/cloud-credential-operator/pull/591. This should bring us closer to a 90% success rate going forward.

/hold cancel

Do you have a cluster-config-operator bump that includes this change to prove the feature is working when promoted to stable?

Do you have a cluster-config-operator bump that includes this change to prove the feature is working when promoted to stable?

@JoelSpeed I have a corresponding PR with the changes. I ran tests today and they passed everything except what appears to be new e2e-aws-serial*, which I have restarted. Unfortunately, this repo doesn't have the test for our feature (azure-manual-oidc). As a result, it will be difficult to prove the feature itself works. However, they do show that it doesn't break things normally.

I've reviewed the test data and found that the pass rate is at or above Azure baseline.
Since this is an install time variant it requires a unique job. I agree with the ongoing discussion that we should move this from a periodic to an informing release job. That way the frequency of execution scales with the overall rate of product change. We can do that in a follow up.
/approve
/cc @JoelSpeed
Joel, you know the mechanisms to promote to default feature set better than I do. Can you complete the review?

/assign @JoelSpeed

/lgtm

authors: JoelSpeed jstuever sdodson

repo: openshift/api


text:
Add actions CI.

Initial commit for CICD.
Adds build and merge including gofmt and lint.
Thomas F Herbert thomasfherbert@gmail.com

This is the initial commit for satisfying requirement for adding actions to app-netutil.
This commit only sets up build and merge actions. I am testing build-test-mage and build-dpdkapp will be in next commit once this is merged.

/lgtm

authors: dougbtv tfherbert

repo: openshift/app-netutil


text:
Login through PagerDuty incident link or ID

What type of PR is this?
feature
What this PR does / Why we need it?
--
Which Jira/Github issue(s) does this PR fix?
Resolves OSD-19682
Special notes for your reviewer
I'm currently out of ideas how to test the scenario described in the test case "should fail to extract cluster ID when the 'details' field under Common Event Format Details is missing or invalid" due to the sensitivity of the token information involved. Considering this limitation, I'm leaning towards removing this test case from the suite. Unless someone has an idea which would be secure.
Pre-checks (if applicable)

[x] Ran unit tests locally
[ ] Validated the changes in a cluster
[x] Included documentation changes with PR

Fyi, code review has been completed in original PR https://github.com/openshift/backplane-cli/pull/337

Codecov Report
Attention: Patch coverage is 35.71429% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 47.98%. Comparing base (6bc8b44) to head (5e28c42).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   48.27%   47.98%   -0.30%
==========================================
  Files          55       56       +1
  Lines        4182     4272      +90
==========================================
+ Hits         2019     2050      +31
- Misses       1844     1900      +56
- Partials      319      322       +3

Files
Coverage Δ

cmd/ocm-backplane/config/config.go
100.00% <100.00%> (ø)

pkg/cli/config/config.go
75.23% <100.00%> (+3.23%)
:arrow_up:

cmd/ocm-backplane/config/get.go
27.27% <0.00%> (-2.73%)
:arrow_down:

cmd/ocm-backplane/config/set.go
14.28% <0.00%> (-1.51%)
:arrow_down:

cmd/ocm-backplane/login/login.go
73.97% <62.50%> (-2.06%)
:arrow_down:

pkg/pagerduty/pagerduty.go
16.66% <16.66%> (ø)

repo: openshift/backplane-cli


text:
NO-JIRA: Update OWNERS

This PR updates the OWNERS file to the latest version.

/verify-owners

repo: openshift/cluster-api-provider-vsphere


text:
STOR-1725: Add build files for SMB CSI Driver

https://issues.redhat.com/browse/STOR-1725
/cc @openshift/storage
UPSTREAM: : Remove .github files
UPSTREAM: : add OWNERS, Dockerfile, .ci-operator.yaml
UPSTREAM: : Makefile should build from vendor directory
upstream comparison:
https://github.com/kubernetes-csi/csi-driver-smb/compare/master...mpatlasov:[STOR-1725](https://issues.redhat.com//browse/STOR-1725)-openshift-build-files
NB: go mod vendor is not needed because upstream already vendors all deps (hence, go mod vendor does nothing)

@dobsonj Thanks for review, appreciated! I fixed PR according to your comments:

no more changes in release-tools/build.make
rhel-8-release-golang-1.21-openshift-4.16 in .ci-operator.yaml
make smb ARCH=$(go env GOARCH) in Dockerfile.openshift

Can you please review it again.

/lgtm

/approve

authors: dobsonj knobunc mpatlasov

repo: openshift/csi-driver-smb


text:
SREP-1863: dedicated-admin systemgroup added to [cluster]rolebindings

This enables the customer to create any SA in the dedicated-admin namespace and then get dedicated-admin privileges with that SA.
Feature is documented here: https://docs.openshift.com/dedicated/admin_guide/service_accounts.html#dedicated-admin-granting-service-accounts-access

/hold
Couple of things to work out still..

/hold cancel

RoleBindings for existing clusters are not updated as a part of this.  Thought about creating new rolebindings but nobody w/ a live cluster has asked for this feature so they don't care.  I'll propose we simply cleanup manually by forcing recreation of the rolebindings:  oc get rolebinding -A | grep dedicated-admin | grep -v "^openshift" | awk '{print "oc delete rolebinding " $2 " -n " $1}' | sh

Offhand this looks good, but in order to provide better feedback, I'm trying to run it locally and see if it does what we expect.

@jewzaam One suggestion based on testing in minikube:
I had to make this change in order for the ClusterRoleBinding to be created:
[dakini@nibbana dedicated-admin-operator ((66c8dd3...) *$%)]git diff
diff --git a/manifests/02-dedicated-admins-cluster.ClusterRoleBinding.yaml b/manifests/02-dedicated-admins-cluster.ClusterRoleBinding.yaml
index a9aeb5f..75d09df 100644
--- a/manifests/02-dedicated-admins-cluster.ClusterRoleBinding.yaml
+++ b/manifests/02-dedicated-admins-cluster.ClusterRoleBinding.yaml
@@ -1,4 +1,4 @@
-apiVersion: authorization.openshift.io/v1
+apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   name: dedicated-admins-cluster

During testing, dedicated-admin-operator created the following rolebindings automatically when a new namespace was created, so the operator is working:
[dakini@nibbana ~]$ kubectl get rolebindings -n test20190806
NAME                         AGE
dedicated-admins-project-0   14s
dedicated-admins-project-1   14s

And the dedicated-admin namespace exists. So that looks good too.
[dakini@nibbana ~]$ kubectl get serviceaccount -n dedicated-admin
NAME      SECRETS   AGE
default   1         9m20s

I wasn't able to test if SAs within the dedicated-admin namespace are automatically granted dedicated-admin permissions. I might need a full openshift cluster for that test.

repo: openshift/dedicated-admin-operator


text:
HIVE-2400: fix obsolete python references

New builder images do not alias python to python3

Both this and openshift/release#53396 need to go in (other changes might be needed to. Working on unblocking the branch

repo: openshift/hive


text:
fix slice delete issue

On OpenShift SNO install slices were not deleted in some instances. The root cause of this issue is unknown as it is not reproducible on the KinD cluster; one theory is that multiple NVML init calls could cause non-determinism in slice discovery, and an issue is opened for such a use case in #225. This PR has improved logging when a slice is not found and retries when a slice is not found, but the config map for workload still exists in the system.
make test ,make lint, make test-e2e  and daemonset shell script all pass locally.

/lgtm

repo: openshift/instaslice-operator


text:
Option to specify ScriptApprovals when setting up Jenkins

There should be an option to specify script approvals when setting up Jenkins

You can extended the image @kahootali and add an init groovy script to turn this on.
At this point we are no longer adding more explicit environment variables to toggle Jenkins behavior.
Thanks for the interest in the product.
@pradeepto @sthaha @waveywaves fyi

@gabemontero so how do other users do it? Do they manually approve scripts?

Hi @kahootali and @gabemontero
What I usually do, is simply override the scriptApproval.xml file using a config map using the following command:
oc create configmap jenkins-approval-scripts --from-file=scriptApproval.xml
oc set volume --add dc/jenkins -t configmap --mount-path=/var/lib/jenkins/scriptApproval.xml \
              --sub-path=scriptApproval.xml --configmap-name=jenkins-approval-scripts \
              --name=script-approval

You can have a look at this repository for an example of scriptApproval.xml.
https://github.com/akram/openshift-agentless-pipeline

Hi, are there any other workarounds for this ? Currently, this is acting as a blocker for me as well. Updating the volume doesn't seem like a viable solution.

authors: ahmedwaleedmalik akram gabemontero kahootali

repo: openshift/jenkins


text:
update contributing guide for e2e changes, payload removal and new process

@openshift/openshift-team-build-api
forgot to update the contributing guide with the recent e2e and payload removal instructions
also updated a couple of the imagestream refs as we get close to 4.11 shutdown to help illustrate the process
/assign @coreydaley
/assign @akram

/lgtm

authors: coreydaley gabemontero


text:
konflux: fix enterprise contract issues

This resolves the preflight checkes issues:
{
    "passed": [
        {
            "name": "HasUniqueTag",
            "elapsed_time": 0,
            "description": "Checking if container has a tag other than 'latest', so that the image can be uniquely identified."
        },
        {
            "name": "LayerCountAcceptable",
            "elapsed_time": 0,
            "description": "Checking if container has less than 40 layers.  Too many layers within the container images can degrade container performance."
        },
        {
            "name": "HasRequiredLabel",
            "elapsed_time": 0,
            "description": "Checking if the required labels (name, vendor, version, release, summary, description) are present in the container metadata."
        }
    ],
    "failed": [
        {
            "name": "HasLicense",
            "elapsed_time": 0,
            "description": "Checking if terms and conditions applicable to the software including open source licensing information are present. The license must be at /licenses",
            "help": "Check HasLicense encountered an error. Please review the preflight.log file for more information.",
            "suggestion": "Create a directory named /licenses and include all relevant licensing and/or terms and conditions as text file(s) in that directory.",
            "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
            "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
        },
        {
            "name": "RunAsNonRoot",
            "elapsed_time": 0,
            "description": "Checking if container runs as the root user because a container that does not specify a non-root user will fail the automatic certification, and will be subject to a manual review before the container can be approved for publication",
            "help": "Check RunAsNonRoot encountered an error. Please review the preflight.log file for more information.",
            "suggestion": "Indicate a specific USER in the dockerfile or containerfile",
            "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
            "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
        },
        {
            "name": "BasedOnUbi",
            "elapsed_time": 251,
            "description": "Checking if the container's base image is based upon the Red Hat Universal Base Image (UBI)",
            "help": "Check BasedOnUbi encountered an error. Please review the preflight.log file for more information.",
            "suggestion": "Change the FROM directive in your Dockerfile or Containerfile to FROM registry.access.redhat.com/ubi8/ubi",
            "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
            "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
        }
    ],
    "errors": [
        {
            "name": "HasNoProhibitedPackages",
            "elapsed_time": 0,
            "description": "Checks to ensure that the image in use does not include prohibited packages, such as Red Hat Enterprise Linux (RHEL) kernel packages.",
            "help": "Check HasNoProhibitedPackages encountered an error. Please review the preflight.log file for more information."
        },
        {
            "name": "HasModifiedFiles",
            "elapsed_time": 18250,
            "description": "Checks that no files installed via RPM in the base Red Hat layer have been modified",
            "help": "Check HasModifiedFiles encountered an error. Please review the preflight.log file for more information."
        }
    ]
}

/approve
/lgtm
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-rag-content"

authors: raptorsun syedriko

repo: openshift/lightspeed-rag-content


text:
OLS-1001: Added known issue into documentation

Description
Added known issue into documentation
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[x] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Related Tickets & Documents

Related Issue #OLS-1001

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.89%. Comparing base (6af39f6) to head (42ddb1e).
Report is 26 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1687   +/-   ##
=======================================
  Coverage   94.88%   94.89%
=======================================
  Files          60       60
  Lines        2681     2685    +4
=======================================
+ Hits         2544     2548    +4
  Misses        137      137

Flag
Coverage Δ

94.89% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

/approve

/lgtm

/override "Red Hat Konflux / lightspeed-service-on-pull-request"

authors: codecov-commenter syedriko tisnik

repo: openshift/lightspeed-service


text:
Disable query executors when query is empty

Fixes: https://issues.redhat.com/browse/LOG-2917

/lgtm

authors: jgbernalp kyoto

repo: openshift/logging-view-plugin


text:
Add Federico to the approvers

This to add myself to the approvers.

/lgtm
/approve

/approved

/lgtm

/approve

/override ci/prow/metallb-e2e-metal-ipi-ovn

/override ci/prow/metallb-e2e-metal-ipi

repo: openshift/metallb


text:
API-1835: write output even when there are errors

the exit code will still be non-zero, but we'll get the output too, which is usually better than nothing.

/lgtm

repo: openshift/multi-operator-manager


text:
converted devfiles directly creates a url for you

/kind bug

What versions of software are you using?
Operating System:
Output of odo version:
How did you run odo exactly?
Currently as there is no equivalent of "ports" in devfile world when an s2i component is converted to a devfile component the ports described by the s2i image are converted to urls. This is a breaking change and can create issues when the s2i component name is quite large.
Any logs, error output, etc?

odo create nodejs --s2i
Validation
 ✓  Validating component [524ms]
Conversion
 ✓  Successfully generated devfile.yaml and env.yaml for provided S2I component

Please use `odo push` command to create the component with source deployed
(base) girish@MacBook-Pro 3453456345 % odo url list
Found the following URLs for component nodejs-x3453456345-bcab
NAME                             STATE          URL     PORT     SECURE     KIND
nodejs-x3453456345-bcab-8080     Not Pushed             8080     false      route

A solution for this problem is implementing support for exposure: none kind urls in devfile which are present on the devfile as a reference and only get created when someone change their exposure to public.
Currently if a exposure: none url is present in the devfile it doesn't list you the url and also doesn't let you create one.
% odo url list
 ✗  no URLs found for component nodejs-x3453456345-bcab. Refer `odo url create -h` to add one
% odo url create
 ✗  URL creation failed:
        - url nodejs-x3453456345-bcab-8080 already exist in devfile endpoint entry under container s2i-builder

Currently if a exposure: none url is present in the devfile it doesn't list you the url and also doesn't let you create one either

this needs to be fixed as well. It could be related to https://github.com/openshift/odo/issues/4493 and solution described in https://github.com/openshift/odo/issues/4493#issuecomment-818667275 should fix this.

This is a breaking change and can create issues when the s2i component name is quite large.

we need to make sure that the component name lenght doesn't affect this.

The scope of this issue is to make sure the url length doesn't go over 63 chars. Now the length of the url is dependent on the cluster's url so either I keep check the cluster url's length and reduce the url length based on that or just make an educated guess that url length shouldn't be more then 15 chars (example) and the "random chars" show up in the beginning.
Earlier scope was to add exposure:none when we are converting ports to urls in s2i but thats actually fine. And even after the convertion of the port to default url the url would fail to create as its length is incorrect so we dont wanna consider this approach.

The scope of this issue is to make sure the url length doesn't go over 63 chars. Now the length of the url is dependent on the cluster's url so either I check the cluster url's length and reduce the url length based on that or just make an educated guess that url length shouldn't be more then 15 chars (example) [part that we control url name] and the "random chars" show up in the beginning.

based on the devfile spec, endpoint name has to be  "string (up to 63 chars) and must match ^a-z0-9?$ "
when odo generates new endpoint it needs to make sure that the name is valid

but thats not the only thing, should we reduce its size if overall url becomes too large? like max at 20 chars?

The scope of this issue is to make sure the url length doesn't go over 63 chars. Now the length of the url is dependent on the cluster's url so either I check the cluster url's length and reduce the url length based on that or just make an educated guess that url length shouldn't be more then 15 chars (example) [part that we control url name] and the "random chars" show up in the beginning.

based on the devfile spec, endpoint name has to be "string (up to 63 chars) and must match ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ "
when odo generates new endpoint it needs to make sure that the name is valid

I could be wrong here but endpoint name would include the cluster url? or its just the name?

I still dont have an action item on this,

should I just the url name be as is? then we can just close this issue.
should I trim it if it goes beyond a certain characters [ max - 30 chars ] ? - also there is an issue with triming it from right side as the sufix is the random string - which means if I trim it too much we might have conflicting url name. ( as the random string might get trimed )

from the original descrption:

This is a breaking change and can create issues when the s2i component name is quite large.

Creating urls for ports is ok.
It is not ok to create url that has an invalid name.
This is a situation that you need to prevent:
▶ cd Work/odo-examples/1234567890123456789012434567890

▶ odo create

▶  cat devfile.yaml
...
...
    endpoints:
    - name: nodejs-x12345678901-irop-8080
      targetPort: 8080
....
....

▶ odo push

Validation
 ✓  Validating the devfile [31300ns]

Creating Kubernetes resources for component nodejs-x12345678901-irop
 ✓  Waiting for component to start [34s]
 ✓  Waiting for component to start [15ms]

Applying URL changes
 ✗  Failed To Update Config To Component Deployed.
Error: unable to create route: error creating route: Route.route.openshift.io "nodejs-x12345678901-irop-8080-nodejs-x12345678901-irop" is invalid: spec.host: Invalid value: "nodejs-x12345678901-irop-8080-nodejs-x12345678901-irop-tkral-test.apps-crc.testing": host must conform to DNS 1123 naming conventions: [spec.host: Invalid value: "nodejs-x12345678901-irop-8080-nodejs-x12345678901-irop-tkral-test": must be no more than 63 characters]

should I trim it if it goes beyond a certain characters [ max - 30 chars ] ? - also there is an issue with triming it from right side as the sufix is the random string - which means if I trim it too much we might have conflicting url name. ( as the random string might get trimed )

Would this approach work^ so that a url doesn’t go over 20 or 30 characters?

Would this approach work^ so that a url doesn’t go over 20 or 30 characters? @kadel

url name (endpoint name) can be up to 63 characters, why would you limit it to just 20?
Problem is that it generates Ingres/Route with a host that is too long.

I have implemented an approach similar to what devfile does in this https://github.com/openshift/odo/pull/4670
Please take a look

authors: girishramnani kadel

repo: openshift/odo


text:
Use CRI-O 1.19

Use cri-o 1.19 in 4.7 to align with k8s 1.19

Wrong branch :/

repo: openshift/okd-machine-os


text:
OKD 4.7 - Kernel Panic Error When Creating Bootstrap Node.

hi,
I have a problem with installing a lab okd 4.7.
I'm following the guide https://itnext.io/guide-installing-an-okd-4-5-cluster-508a2631cbee by @cragr (Craig Robinson), but when I get to the "Starting the bootstrap node" I get a "kernel panic" error after entering the parameters indicated in the guide.
I am trying to install OKD 4.7 with Fedora CoreOS 34.20210529.3.0, but I have also tried using Fedora CoreOS 35.20220116.3.0and got the same error.
Do you have any suggestions? Did it happen to you?
Thanks in advance for your help.

"Cannot open root device "(null)" and "please append a correct root" with no disks available, not an OKD issue

do you think it could be an error on the ESXi side?

This problem has been solved. I recreated the VM by lowering the hardware compatibility to version 6.5 and using Fedora CoreOS 34.20210529.3.0

authors: indacofilippo vrutkovs

repo: openshift/okd


text:
[OKD4.7] [mac] Creating cluster on AWS failing at connecting to API step

Describe the bug
Using release 4.7.0-0.okd-2021-02-25-144700, I tried to create a cluster on AWS three times and it is always failing at connecting to API step:
? SSH Public Key  [Use arrows to move, enter to select, type to filter, ? for mo? SSH Public Key  [Use arrows to move, enter to select, type to filter, ? for mo? SSH Public Key /path/to/key
? Platform  [Use arrows to move, enter to select, type to filter, ? for more hel? Platform aws
INFO Credentials loaded from the "default" profile in file "/path/to/credentials"
? Region REGION-CODE
? Base Domain  [Use arrows to move, enter to select, type to filter, ? for more ? Base Domain  [Use arrows to move, enter to select, type to filter, ? for more ? Base Domain DOMAIN
? Cluster Name CLUSTER
? Pull Secret [? for help] **********************************
INFO Creating infrastructure resources...
INFO Waiting up to 20m0s for the Kubernetes API at https://api.CLUSTER.DOMAIN:6443...
ERROR Attempted to gather ClusterOperator status after installation failure: listing ClusterOperator objects: Get "https://api.CLUSTER.DOMAIN:6443/apis/config.openshift.io/v1/clusteroperators": dial tcp IP:6443: connect: connection refused
INFO Pulling debug logs from the bootstrap machine
ERROR Attempted to gather debug logs after installation failure: failed to create SSH client: failed to use pre-existing agent, make sure the appropriate keys exist in the agent for authentication: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
FATAL Bootstrap failed to complete: failed waiting for Kubernetes API: Get "https://api.CLUSTER.DOMAIN:6443/version?timeout=32s": dial tcp IP:6443: connect: connection refused

Version
I used the release: https://github.com/openshift/okd/releases/tag/4.7.0-0.okd-2021-02-25-144700
How reproducible
I hit this issue running openshift-installer create cluster three times. After using release https://github.com/openshift/okd/releases/tag/4.6.0-0.okd-2021-02-14-205305 I didn't get the issue.
Log bundle
Can't provide adm must-gather output as no cluster is being created.

Please attach log bundle

@vrutkovs, so, I deleted 4.7 release and I'm using 4.6 release now. How can I make sure I'm providing the correct logs?

In order to fix the issue we need to make sure its happening in 4.7. 4.6-specific issues won't get a lot of attention as OKD is a rolling distro

Closing as not using v4.7 anymore.

authors: mahmoudajawad vrutkovs


text:
Retry tasks in the subscription manager role

What does this PR do?
Some subscription manager role tasks (such as subscription or attaching pool) are now retried by ansible, so that even during slow internet connection, the chance of failure is decreased.
How should this be manually tested?

To make sure that subscription manager tasks fails and is retried, enter wrong credentials in your inventory used for provisioning.
Run provisioning using rhel images.
Ansible will retry to subscribe using wrong credentials and fail at the end.

Is there a relevant Issue open for this?

Who would you like to review this?
cc: @tomassedovic @bogdando PTAL

nit: I wonder if the block: wrapper could work as well?

@bogdando block doesn't support loops, at least yet.

authors: Tlacenka bogdando pschiffe

repo: openshift/openshift-ansible-contrib


text:
OCM-5310 | feat: changed default platform type to aws-classic & aws-hosted-cp

JIRA
Changing default platform type  to aws-classic & aws-hosted-cp from  aws & hostedcluster

/lgtm

/lgtm

authors: davidleerh den-rgb robpblake

repo: openshift/rosa


text:
OCM-6716 | feat: classic mp aws tags on create/describe

OCM-6716

/lgtm

authors: davidleerh gdbranco


text:
Materialized views for KPI cards on ProjectPage

ProjectPage is slow to load because we re-compute every KPI card on load right now.
We should just have a Materialized view called "ProjectPage", which pre-computes every KPI card stat so that we can just pull it and display.
This necessarily means that we must disconnect KPI cards from the date picker, so we may need to refactor some queries as necessary

Since we are moving to dbt pipelines, let's wait until that's up and ready to do this on the new infra.

repo: opensource-observer/oso


text:
🛑 Dev is down

In 7daaf25, Dev (https://dev.opensourcepos.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Dev is back up in 1aa4cf6.

repo: opensourcepos/upptime


text:
[Question] - Is there a way to add hyperlink?

Just trying to understand if there is a way to add a hyperlinked column when creating a row?

Not right now, but you can send a PR to add the feature.
I've just created two xlsx with 3 identical cells, than in the second xslx I've added a URI link to the second cell and an email link to the third one, this is the diff between the two xslx:
Reference file: hyperlink.xlsx
/[Content_Types].xml
@@ -9,6 +9,7 @@
        <Override PartName="/xl/workbook.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.sheet.main+xml"/>
        <Override PartName="/xl/theme/theme1.xml" ContentType="application/vnd.openxmlformats-officedocument.theme+xml"/>
        <Override PartName="/xl/styles.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.styles+xml"/>
+       <Override PartName="/xl/worksheets/_rels/sheet1.xml.rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/>
        <Override PartName="/xl/worksheets/sheet1.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.worksheet+xml"/>
        <Override PartName="/xl/sharedStrings.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.sharedStrings+xml"/>
        <Override PartName="/_rels/.rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/>

/xl/worksheets/sheet1.xml
                        </c>
                </row>
                <row r="2" customFormat="false" ht="12.65" hidden="false" customHeight="false" outlineLevel="0" collapsed="false">
-                       <c r="A2" s="0" t="s">
+                       <c r="A2" s="1" t="s">
                                <v>1</v>
                        </c>
                </row>
                <row r="3" customFormat="false" ht="12.65" hidden="false" customHeight="false" outlineLevel="0" collapsed="false">
-                       <c r="A3" s="0" t="s">
+                       <c r="A3" s="1" t="s">
                                <v>2</v>
                        </c>
                </row>
        </sheetData>
+       <hyperlinks>
+               <hyperlink ref="A2" r:id="rId1" display="b2"/>
+               <hyperlink ref="A3" r:id="rId2" display="c3"/>
+       </hyperlinks>
        <printOptions headings="false" gridLines="false" gridLinesSet="true" horizontalCentered="false" verticalCentered="false"/>
        <pageMargins left="0.7875" right="0.7875" top="1.05277777777778" bottom="1.05277777777778" header="0.7875" footer="0.7875"/>
        <pageSetup paperSize="9" scale="100" fitToWidth="1" fitToHeight="1" pageOrder="downThenOver" orientation="portrait" blackAndWhite="false" draft="false" cellComments="none" firstPageNumber="1" useFirstPageNumber="true" horizontalDpi="300" verticalDpi="300" copies="1"/>

/xl/worksheets/_rels/sheet1.xml.rels
+<?xml version="1.0" encoding="UTF-8"?>
+<Relationships
+        xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
+        <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink" Target="https://www.example.com/" TargetMode="External"/>
+        <Relationship Id="rId2" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink" Target="mailto:example@example.com?subject=Foobar%20subject" TargetMode="External"/>
+</Relationships>

I came across this issue when trying to add a link to a webpage to an Excel file. I found the following workaround, specifically for xlsx files:
new FormulaCell('=HYPERLINK("https://www.google.com")', (new Style())->setFontUnderline()->setFontColor(Color::rgb(70,120,134)));

It does not apply the hyperlink style, so I manually set the underline and link color on the cell. This does mean that clicking on the link does not change the color to the visited state.

authors: Slamdunk artemsky mhvis

repo: openspout/openspout


text:
CHW/ANC - Add UI for MeasureReport filters in the Reports module in the ANC app

Name of feature to enhance
As a Community health supervisor, I would like to see how a given facility is doing based on the recommended measures tracking various health Indicators in a given jurisdiction.
Description of feature
Add the ability to load measure reports that can be used to generate reports for either Individual ANC patients or a subset of a defined population with given characteristics e.g Age, Education levels etc.
Describe the enhancement

Add a UI for doing the Report filters
Add a UI for Reporting Template to be used once a measure is run and computed to generate a MeasureRerport

Screenshots
Landing page - Select report for all

Landing page - Select report for Individual with search

Add ability to search by Family name, Given name , Patient ID or Identifier

Complete selection

Reporting for an Individual

Reporting for a population

Duplicate ticket

repo: opensrp/fhircore