text:
quick start SetupAWS.py option to use existing Thing/Policy/Cert

This is like day two for me so I might be missing something.

Set up a new device with SetupAWS.py setup
git clean and lose all your local state.
Try to setup again, and get errors because the Thing already exists.  Read through the other available options and scratch your head.

Is there a way to fetch details for an existing Thing, and use those?

As part of git clean, if you have not deleted the generated certificate and private key (i.e. if you have not deleted the untracked files), you can populate the configure.json again and use the following command to configure your project:
SetupAWS.py update_creds

If you have deleted the generated certificate and private key, you need to delete the resources and recreate them using the following commands:
SetupAWS.py cleanup
SetupAWS.py setup

Thanks.

I tried! cleanup seems to depend on generated artifacts:
jrr@jrrmbp ~/r/r/a/d/c/t/aws_config_quick_start ((413f30f6…))> python SetupAWS.py cleanup
Traceback (most recent call last):
  File "SetupAWS.py", line 193, in <module>
    cleanup()
  File "SetupAWS.py", line 147, in cleanup
    delete_prereq()
  File "SetupAWS.py", line 118, in delete_prereq
    cert_id_file = open(cert_id_filename, 'r')
IOError: [Errno 2] No such file or directory: u'john-test-thing_cert_id_file'

The current set of scripts rely on some locally generated files and we will see how we can improve them. For now, would you please delete the created certificate and policy using AWS IoT Console:
https://us-west-2.console.aws.amazon.com/iot/home?region=us-west-2#/certificatehub
https://us-west-2.console.aws.amazon.com/iot/home?region=us-west-2#/policyhub
Note that your links may vary depending on the region you are creating your resources in (change us-west-2 with the region your exists in).
Then run the setup command again:
SetupAWS.py setup

Apologies for the inconvenience.

Yeah, that's where I wound up 😒.
As you look to improve the process: it'd be great if generated sources weren't versioned / versioned sources weren't rewritten by automation.
A developer on a team, finishing up a feature branch, shouldn't have to tease out out their code changes from their I-edited-this-file-so-that-I-can-flash-my-device changes.

Thank you for your feedback. These are really good suggestions and we will take them into consideration while improving these scripts.
Thanks.

authors: aggarg jrr

repo: aws/amazon-freertos

license: MIT


text:
Possible bug-fix for aws_demo_logging.c

Description
As I am mostly working on FreeRTOS+TCP these days, I rarely look at the PR's in the amazon-freertos repo.
But as today I was repairing a possible bug in aws_demo_logging.c, I saw Ming Yue's recent PR #2995 for this module.
Ming Yue, the problem was not the uninitialised local variable xLength2, but the missing else clause of if( xArgs != NULL ):
     if( xArgs != NULL )
     {
         xLength2 = vsnprintf( cPrintString + xLength,
                               dlMAX_PRINT_STRING_LENGTH - xLength,
                               pcFormat,
                               xArgs );
     }
+    else
+    {
+        xLength2 = snprintf( cPrintString + xLength,
+                             dlMAX_PRINT_STRING_LENGTH - xLength,
+                             "%s",
+                             pcFormat );
+    }

In earlier versions, the else clause was present.
Here is a normal use case in which 'xArgs' is set to NULL:
void vLoggingPrint( const char * pcFormat )
{
    prvLoggingPrintf( LOG_NONE, NULL, 0, pdFALSE, pcFormat, NULL );
}

Now my possible bug-fix: when checking the free space with uxStreamBufferGetSpace(), it must happen within the critical section, thus like this:
    SetThreadPriority( GetCurrentThread(), THREAD_PRIORITY_TIME_CRITICAL );
    {

        /* How much space is in the buffer? */
        xLength2 = uxStreamBufferGetSpace( xLogStreamBuffer );

        /* There must be enough space to write both the string and the length of
         * the string. */
        if( xLength2 >= ( xLength + sizeof( xLength ) ) )
        {
            uxStreamBufferAdd( xLogStreamBuffer,
                               0,
                               ( const uint8_t * ) &( xLength ),
                               sizeof( xLength ) );
            uxStreamBufferAdd( xLogStreamBuffer,
                               0,
                               ( const uint8_t * ) cOutputString,
                               xLength );
        }
        else
        {
            /* Log line will be dropped, bad luck. */
        }
    }
    SetThreadPriority( GetCurrentThread(), iOriginalPriority );

Otherwise a race condition is possible in which a higher-priority task comes in between and fills the stream buffer. This may cause the logging to stop working properly.
Hein
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

/cbmc run checks

/bot run checks

/bot run checks

/bot run checks

source: gharchive/pull-request

authors: AniruddhaKanhere htibosch lundinc2

license_type: permissive

license_source: github-api


text:
404 Error when using OktaCredentialsProvider

Driver version
3.8
Redshift version
PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.29551
Client Operating System
Mac, ran locally
Python version
3.8
Table schema
n/a
Problem description

Trying to replicate a JDBC connection in Python, to create a connection object.
Running following code to connect to Redshift doesn't work, results in 404 error (see bottom section)

However, the supplying the same information in a JDBC client (e.g. PyCharm/Datagrip) results in a successful connection. After reviewing the code vs the JDBC connection several times, I am certain there is not a typo in any of the parameters in the python code.
Python Driver trace logs

Reproduction code
import redshift_connector

gdp_conn = redshift_connector.connect(
    iam=True,
    database="<<db name>>",
    cluster_identifier="<<cluster name>>",
    credentials_provider='OktaCredentialsProvider',
    user="<<redacted>>@<<domain>>",
    password="<<redacted>>",
    idp_host="<<idp_host>>",
    app_id="myappidstring",
    role_arn="arn:aws:iam::<<accountid>>:role/<<rolename>>"
)

redshift_connector.error.InterfaceError: 404 Client Error: Not Found for url: https://<<idp_host>>/home/amazon_aws_redshift/<<app_id>>?onetimetoken=<<redacted>>

Hi @kylemcleland-fanduel ,
Thank you for reaching out regarding this issue. My recommendation would be the following

ensure you're using the latest release of redshift_connector
enable debug logging using the python logging library and review the logs relevant to the following keywords: Okta, SAML. Please be aware the contents of the logs will contain information specific to your Okta configuration.

As you mentioned this issue is not seen with the Amazon JDBC driver, and the same information is provided to establish the connection, I would guess there may be some issue with the Okta session token or URL used for authenticating with Okta.
Looking to the JDBC source code which builds the URL containing the Okta session token, it appears inline with the redshift_connector implementation, except for the URL encoding of the Okta app_name.
While this is a bug in redshift_connector, I don't believe it is the cause of this issue unless the Okta app_name is something which would require url encoding -- which amazon_aws_redshift would not.
A quick way to check this is to plug your app_name into a site like this which will allow you to url encode text.
If this is the issue at hand, a workaround for the time being would be to url encode the app_name before passing it to redshift_connector.connect(...) method.
Otherwise, my guess would be this has to do with the Okta session token -- for which reviewing the logs will provide some insight.
Additionally, for redshift_connector one additional parameter to redshift_connector.connect(...)  is required, region. This is used for establishing a boto3 session to retrieving temporary IAM credentials to access the given cluster.

@Brooke-white thanks for the response. Apologies for the delay in getting back on this.
It looks like the issue was with my app_id. The string looked like this 'bunchofcharacters/morecharacters' from the Okta portal. Weirdly I can log in using a JDBC client passing just 'bunchofcharacters' but adding the full string seems to get me further along in the connection phase. I'm going to close this issue.

source: gharchive/issue

authors: Brooke-white kylemcleland-fanduel

repo: aws/amazon-redshift-python-driver


text:
[RN] Unauthenticated users on Pinpoint

I am trying to integrate aws-amplify (0.2.7) with React Native for Pinpoint analytics. So far, I'm running into an issue where if user is unauthenticated and the app is forced closed and reopened, a new Cognito Federated Identity Id is retrieved. On the Pinpoint dashboard, it shows up as multiple users when it should be one unique user and I can see the same result on Cognito Federal Identities.
I'm not sure if this is a bug, but if it's the expected behavior for aws-amplify, is there a way to link the identity ID to the device for an unauthenticated user? Or will this require setting up user pools with authentication?
Is there an alternate way to achieve what I'm describing for Pinpoint analytics?
I'm new to using aws-amplify, so let me know what other info would be helpful. Thank you all for your work on aws-amplify!

I am seeing the same thing on the web site. I mostly just want to use amplify for easy access from the web to an API. But on every page reload, a new unauthenticated user is retrieved. I figured this would be stored in localstorage or cookie or something, but that doesn't seem to be happening for unauthenticated users (there does seem to be code to cache the federated login, but it's not being used for the unauthenticated users).
I think I'm in the same boat in not really understanding what is supposed to be happening here.

We have a similar need to cache unauthenticated identity ids in our app, would love to be able to use amplify if it could handle this.

@wanytprograms I can't even figure out how to get anonymous credentials to call my API. I am calling Amplify.configure but it's not giving me anything. Do you have an example?

This is partly related to #308 and a bunch of other issues here :(

Caching the unauthenticated identities, especially in regards to analytics is in our backlog.
@brianfoody Anonymous credentials are always retrieved immediately if the Identity Pool has unauthenticated access configured. If you are using Mobile Hub / awsmobile-cli + user-signin most of this is configured for you, but if you configure it yourself, you need to be sure you setup your IAM Unauthenticated role within your Cognito Identity Pool to have the appropriate permissions for pinpoint analytics, which is essentially:
"Effect": "Allow",
"Action": "mobiletargeting:*",
"Resource": "*"

Similarly with an unauthenticated API Gateway
If you just want to call an http endpoint i.e. not use the sigv4 signing to call an AWS API, I would recommend you just use the fetch() api that's available in both web and react native by the platform.
Question:
What would be the use case to call a random REST API with the API category outside using fetch() ?
I can add this into our backlog, just trying to understand the use case thanks!

Hi @mlabieniec, just wonder if this Caching the unauthenticated identities function is available via another aws library?

This should have been fixed in latest version.

@mlabieniec unfortunately I am still getting this issue of new identity id's with version 0.3.3 on React Native 0.54.0. Is there a way to save the identity id and pass it in again or something?

@brianfoody you can define your endpoint id or user id yourself. Please check this link. Also could you check the identityId you get by using Auth.currentCredentials() to see if you do get different ids every time.

Hey @powerful23 . Ah okay but that's only for pinpoint analytics reporting that you can specify the userId. It's the underlying identity that I'm worried about changing as I'm using multiple AWS services and need the same identity id across them.
I am checking Auth.currentCredentials() -> credentials.params.IdentityId and it's different every time I reload the app at the moment.

@brianfoody confirmed this is a bug for React native app. Fixing it.

authors: Jun711 brianfoody buggy jonninja mlabieniec powerful23 tcscott wanytprograms

repo: aws/aws-amplify


text:
build: add ability to roll forward to run versions higher than netcoreapp3.1

Issue #, if available:
Closes #224
Description of changes:
Add NET5 as a target framework
Fix nullability issues caused as a result of adding NET5 as a TF
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instead of multi target we should add a runtimeconfig.template.json file that allows the tooling to roll forward to major versions. That will avoid us having to add new target frameworks every year when there is a new version of .NET released. That is what we have been doing with the Lambda tools.

I added Major to the CLI csproj which fixed the issue. I saw that it was the same as adding a runtimeconfig file.

repo: aws/aws-dotnet-deploy


text:
Fix venv

Issue #, if available:
Description of changes:
Fixing previous changes that brought in venv folder by mistake
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Mickeypeng committed venv will be in git history forever
meaning everytime anyone forks or clones that repo that will download files from that venv
why don't you just remove that commit ?

Hello @kirillrdy Thanks for you suggestion. We are considering that.
Note this PR is not intend to be merged; It is used to trigger the CI tests to make sure our code passed all tests.

authors: Mickeypeng kirillrdy

repo: aws/aws-elastic-beanstalk-cli


text:
"Server Certificate Verification failed" with Custom Domain

Describe the bug
Hi,
I wanted to report this issue we have been experiencing while trying to switch the IoT Core to custom domain.
Understood that V2 is the solution and should have resolved most issues, we do plan to gradually migrate to V2.
However the thing is we still do have a large number of legacy hardware (Ubuntu 18.04) deployed in the field that we need to support, which makes it a major risk & high cost for us to bring those to V2.
Therefore, we would really appreciate if anyone could provide some insights on the issues with the IoT Core custom domain work with V1, so we can save our legacy hardware.
Issue
We are experiencing Server Certificate Verification failed. during the SSL handshake when connecting to our custom domain, which is also reproducible with the PubSub example.
However, the SDK works perfectly when simply connects to the ATS endpoint.
The only thing we swapped is the endpoint URL in the config file of the SDK, from ATS endpoint to our custom domain. Everything else is properly configured including the ACM SSL certs, VPC endpoint to the iot:data plane, etc.
What we have tried

Tried both IoT CPP SDK V2 and IoT Python SDK to connect to the same custom domain: PubSub example works without problem for both SDKs, and MQTT test client can pub&sub normally
Connect to ATS endpoint using CPP SDK V1: works
Reinstall both OpenSSL 1.1.1 and 1.1.0g and recompile CPP SDK V1: issue persists
Test with openssl s_client -connect <ipv4_addr>:443  -CAfile certs/rootCA.crt as well as openssl s_client -connect <custom_domain>:443  -CAfile certs/rootCA.crt: Both showed verification OK.

However we did notice without specifying the SNI, the s_client always uses the amazonaws SSL cert over our custom domain cert. The results are the following:
subject=CN = *.iot.us-west-2.amazonaws.com

issuer=C = US, O = Amazon, CN = Amazon RSA 2048 M01

---
No client certificate CA names sent
Peer signing digest: SHA256
Peer signature type: RSA
Server Temp Key: ECDH, P-256, 256 bits
---
SSL handshake has read 5502 bytes and written 442 bytes
Verification: OK
---
New, TLSv1.2, Cipher is ECDHE-RSA-AES128-GCM-SHA256
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : ECDHE-RSA-AES128-GCM-SHA256
    Session-ID: 5C520F92903515F3208ED38EF9710B67D08C79298A107727B0859CEF2620F9C0
    Session-ID-ctx:
    Master-Key: 83E247145B24F9654DDE25C4F5088AEBAF771C8FF8083D0FFBB7D7883ED9331480BE2729531008AEC6800E66DAD6DD0B
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time: 1706304653
    Timeout   : 7200 (sec)
    Verify return code: 0 (ok)
    Extended master secret: yes

Tried both the oldest Domain security policy (IoTSecurityPolicy_TLS12_1_0_2015_01) on AWS console  as well as the latest for the custom domain: issue persists
Following the IoT server auth doc, added other cross-signed CA (G2-RootCA1.pem & SFSRootCAG2.pem) to the trusted store of the Linux environment of the hardware: issue persists

Detailed logs are (The Error resolving hostname: -5 and SSL Error Code: 2 are fine because they also exist when we connect to the ATS endpoint which works. However the SSL Error Code: 1 seems to be the cause, which maps to SSL_ERROR_SSL in our environment):
./pub-sub-sample
[DEBUG] Thu Jan 25 18:57:38 2024
:450 [Thread Task] [548328968208] Creating Thread Outbound Action Processing!!
[DEBUG] Thu Jan 25 18:57:38 2024
:451 [Thread Task] [548328968208] Creating Thread TLS Read Action Runner!!
[DEBUG] Thu Jan 25 18:57:38 2024
:452 [Thread Task] [548328968208] Creating Thread MQTT Keep alive Action!!
[TRACE] Thu Jan 25 18:57:38 2024
:452 [Network Read] [548313076176] [PerformAction:L128] :  Network Read Thread, TLS Status : 0
[DEBUG] Thu Jan 25 18:57:38 2024
:452 [OpenSSL Wrapper] [548328968208] [LoadCerts:L369] : Root CA : /home/pi/aws-iot-device-sdk-cpp/build/bin/certs/rootCA.pem
[DEBUG] Thu Jan 25 18:57:38 2024
:453 [OpenSSL Wrapper] [548328968208] [LoadCerts:L377] : Device crt : /home/pi/aws-iot-device-sdk-cpp/build/bin/certs/cert.pem
[DEBUG] Thu Jan 25 18:57:38 2024
:453 [OpenSSL Wrapper] [548328968208] [LoadCerts:L382] : Device privkey : /home/pi/aws-iot-device-sdk-cpp/build/bin/certs/privkey.pem
[ERROR] Thu Jan 25 18:57:38 2024
:482 [OpenSSL Wrapper] [548328968208] [ConnectTCPSocket:L244] : Error resolving hostname: -5
[ERROR] Thu Jan 25 18:57:38 2024
:483 [OpenSSL Wrapper] [548328968208] [PerformSSLConnect:L408] : TCP Connection error
[INFO] Thu Jan 25 18:57:38 2024
:518 [OpenSSL Wrapper] [548328968208] [ConnectTCPSocket:L271] : resolved <our_custom_domain> to xxx.xxx.xxx.xxx
[INFO] Thu Jan 25 18:57:38 2024
:546 [OpenSSL Wrapper] [548328968208] [AttemptConnect:L336] : SSL Error Code: 2
[INFO] Thu Jan 25 18:57:38 2024
:601 [OpenSSL Wrapper] [548328968208] [AttemptConnect:L336] : SSL Error Code: 2
[INFO] Thu Jan 25 18:57:38 2024
:606 [OpenSSL Wrapper] [548328968208] [AttemptConnect:L336] : SSL Error Code: 1
[INFO] Thu Jan 25 18:57:38 2024
:607 [OpenSSL Wrapper] [548328968208] [PerformSSLConnect:L424] :  AttemptConnect Code: -405
[ERROR] Thu Jan 25 18:57:38 2024
:607 [OpenSSL Wrapper] [548328968208] [PerformSSLConnect:L426] :  Server Certificate Verification failed.

Summary
Sorry if I didn't make this concise enough but at this point seemingly we have run out of what to try and we are hammering a wall right now... All points to be an SDK V1 specific issue that may be lack of support of custom domain (which would be surprising if it is)?
Could you suggest anything else to check or try?
Expected Behavior
After switching the endpoint in the config file from ATS to custom domain, it should connect to IoT Core data plane with no issue
Current Behavior
SDK gives Server Certificate Verification failed. which seems to be related to SSL
Reproduction Steps

Configure a custom domain on IoT Core settings with SSL cert from ACM
Connect VPC endpoint to iot:data plane
Put an Network Load Balancer across each AZ in the VPC
Use a global accelerator in front of the NLB to get a static IP
Link the custom domain (same as configured in the IoT Core settings) to the global accelerator using A record in the DNS.
(optional) Put the same domain in the PubSub example in the V2 SDK, it connects and PubSub as expected.
(optional) Put the ATS endpoint in the config file and run the V1 PubSub, it connects and PubSub as expected.
Put the custom domain in the config file endpoint property and run the PubSub example, and it gets Server Certificate Verification failed.

Possible Solution
No response
Additional Information/Context
No response
SDK version used
Compiled from the latest master branch
Environment details (OS name and version, etc.)
Ubuntu 18.04, OpenSSL 1.1.0g

Can you please provide any insights on this one?
I'm sure many existing/current customers would need the IoT custom domain now or in the future. Making the cpp SDK work with the AWS feature would be critical for any scaling business not just us.

@jmklix I noticed last week you self-assigned this issue and would appreciate it if you and the team can provide some insights when you got a chance to take a look. Even just what else to try would be great! Thanks!

Are you able to connect and publish data if you use the custom name with default/dynamic ips directly? e.g
mosquitto_pub -h your.iot.custom.domain.com -p 8883     -t "foo/bar"     -m "Hello"     --cafile AmazonRootCA1.pem     --cert device.pem.crt  --key private.pem.key -d

Did you figure out the cause @yixiangding

repo: aws/aws-iot-device-sdk-cpp


text:
Not a valid project name

Following along with the instructions and when trying to start the image post build with ./mwaa-local-env start, docker throws an error of ""aws-mwaa-local-runner-2.0.2" is not a valid project name".
Environment:
Windows 10 w/ WSL 2
Docker Desktop 4.12.0 (Engine 20.10.17, Compose 2.10.2)

Addressed for default branch in https://github.com/aws/aws-mwaa-local-runner/pull/153

authors: john-jac jtgdy

repo: aws/aws-mwaa-local-runner


text:
FileNotFoundException at compile time for System.Net.Http.Primitives

Installing AWS.S3 nuget package leads to file not found exception
Expected Behavior
Can compile
Current Behavior
cana not compile
I am using xamarin 7.1 and try to use this in my xamarin android app
Severity	Code	Description	Project	File	Line	Suppression State
Error		Exception while loading assemblies: System.IO.FileNotFoundException: Could not load assembly 'System.Net.Http.Primitives, Version=1.5.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Perhaps it doesn't exist in the Mono for Android profile?
File name: 'System.Net.Http.Primitives.dll'
   at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve(AssemblyNameReference reference, ReaderParameters parameters)
   at Xamarin.Android.Tasks.ResolveAssemblies.AddAssemblyReferences(DirectoryAssemblyResolver resolver, ICollection`1 assemblies, AssemblyDefinition assembly, Boolean topLevel)
   at Xamarin.Android.Tasks.ResolveAssemblies.Execute(DirectoryAssemblyResolver resolver)	xxx.Android	C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets	1399

Your Environment

AWSSDK.Core version used: 3.3.13
Service assembly and version used: S3 3.3.5.13
Operating System and version: Win10 64
Visual Studio version: 2017 15.1
Targeted .NET platform:

.NET Core Info

.NET Core version used for development:

.NET Core version installed in the environment where application runs:

Output of dotnet --info:
OS Name:     Windows
OS Version:  10.0.15063
OS Platform: Windows
RID:         win10-x64

Contents of project.json/project.csproj:
Relevant:

<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="..\..\packages\Xamarin.Build.Download.0.4.4\build\Xamarin.Build.Download.props" Condition="Exists('..\..\packages\Xamarin.Build.Download.0.4.4\build\Xamarin.Build.Download.props')" />
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
    <ProjectTypeGuids>{EFBA0AD7-5A72-4C68-AF49-83D382785DCF};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
    <ProjectGuid>{8746861F-4188-47EC-BAA1-719B7AB251A5}</ProjectGuid>
    <OutputType>Library</OutputType>
    <RootNamespace>xxx.Droid</RootNamespace>
    <MonoAndroidAssetsPrefix>Assets</MonoAndroidAssetsPrefix>
    <MonoAndroidResourcePrefix>Resources</MonoAndroidResourcePrefix>
    <AndroidManifest>Properties\AndroidManifest.xml</AndroidManifest>
    <AndroidResgenClass>Resource</AndroidResgenClass>
    <AndroidResgenFile>Resources\Resource.designer.cs</AndroidResgenFile>
    <AndroidApplication>True</AndroidApplication>
    <AndroidUseLatestPlatformSdk>False</AndroidUseLatestPlatformSdk>
    <TargetFrameworkVersion>v7.1</TargetFrameworkVersion>
    <AssemblyName>xxx</AssemblyName>
    <NuGetPackageImportStamp>
    </NuGetPackageImportStamp>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
    <DebugSymbols>True</DebugSymbols>
    <DebugType>full</DebugType>
    <Optimize>false</Optimize>
    <OutputPath>bin\Debug</OutputPath>
    <DefineConstants>DEBUG;</DefineConstants>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
    <AndroidLinkMode>None</AndroidLinkMode>
    <ConsolePause>false</ConsolePause>
    <GenerateSerializationAssemblies>Off</GenerateSerializationAssemblies>
    <AndroidUseSharedRuntime>True</AndroidUseSharedRuntime>
    <EmbedAssembliesIntoApk>False</EmbedAssembliesIntoApk>
    <BundleAssemblies>False</BundleAssemblies>
    <AndroidCreatePackagePerAbi>False</AndroidCreatePackagePerAbi>
    <Debugger>.Net (Xamarin)</Debugger>
    <AotAssemblies>False</AotAssemblies>
    <EnableLLVM>False</EnableLLVM>
    <AndroidEnableMultiDex>False</AndroidEnableMultiDex>
    <EnableProguard>False</EnableProguard>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
    <DebugType>full</DebugType>
    <Optimize>true</Optimize>
    <OutputPath>bin\Release</OutputPath>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
    <AndroidUseSharedRuntime>False</AndroidUseSharedRuntime>
    <ConsolePause>false</ConsolePause>
    <AndroidLinkMode>SdkOnly</AndroidLinkMode>
    <EmbedAssembliesIntoApk>True</EmbedAssembliesIntoApk>
    <BundleAssemblies>False</BundleAssemblies>
    <AndroidCreatePackagePerAbi>False</AndroidCreatePackagePerAbi>
    <Debugger>.Net (Xamarin)</Debugger>
    <AotAssemblies>False</AotAssemblies>
    <EnableLLVM>False</EnableLLVM>
    <AndroidEnableMultiDex>False</AndroidEnableMultiDex>
    <EnableProguard>False</EnableProguard>
    <DebugSymbols>False</DebugSymbols>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604, processorArchitecture=MSIL">
      <HintPath>..\..\packages\AWSSDK.Core.3.3.13\lib\MonoAndroid10\AWSSDK.Core.dll</HintPath>
    </Reference>
    <Reference Include="AWSSDK.S3, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604, processorArchitecture=MSIL">
      <HintPath>..\..\packages\AWSSDK.S3.3.3.5.13\lib\MonoAndroid10\AWSSDK.S3.dll</HintPath>
    </Reference>
    <Reference Include="DotNetCross.Memory.Unsafe, Version=0.2.2.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\DotNetCross.Memory.Unsafe.0.2.2\lib\dotnet\DotNetCross.Memory.Unsafe.dll</HintPath>
    </Reference>
    <Reference Include="FFImageLoading, Version=1.0.0.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Xamarin.FFImageLoading.2.2.9\lib\MonoAndroid10\FFImageLoading.dll</HintPath>
    </Reference>
    <Reference Include="FFImageLoading.Platform, Version=1.0.0.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Xamarin.FFImageLoading.2.2.9\lib\MonoAndroid10\FFImageLoading.Platform.dll</HintPath>
    </Reference>
    <Reference Include="FFImageLoading.Transformations, Version=0.0.0.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Xamarin.FFImageLoading.Transformations.2.2.9\lib\MonoAndroid10\FFImageLoading.Transformations.dll</HintPath>
    </Reference>
    <Reference Include="Microsoft.CSharp" />
    <Reference Include="Mono.Android" />
    <Reference Include="Mono.Android.Export" />
    <Reference Include="Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Newtonsoft.Json.9.0.1\lib\portable-net45+wp80+win8+wpa81\Newtonsoft.Json.dll</HintPath>
    </Reference>
    <Reference Include="PCLCrypto, Version=1.0.0.0, Culture=neutral, PublicKeyToken=d4421c8a4786956c, processorArchitecture=MSIL">
      <HintPath>..\..\packages\PCLCrypto.1.0.2.15130\lib\monoandroid\PCLCrypto.dll</HintPath>
    </Reference>
    <Reference Include="PCLStorage, Version=1.0.2.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\PCLStorage.1.0.2\lib\monoandroid\PCLStorage.dll</HintPath>
    </Reference>
    <Reference Include="PCLStorage.Abstractions, Version=1.0.2.0, Culture=neutral, PublicKeyToken=286fe515a2c35b64, processorArchitecture=MSIL">
      <HintPath>..\..\packages\PCLStorage.1.0.2\lib\monoandroid\PCLStorage.Abstractions.dll</HintPath>
    </Reference>
    <Reference Include="PhoneNumbers, Version=8.3.1.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\libphonenumber-csharp.8.3.1.1\lib\PhoneNumbers.dll</HintPath>
    </Reference>
    <Reference Include="Realm, Version=1.2.0.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Realm.Database.1.2.0\lib\netstandard1.4\Realm.dll</HintPath>
    </Reference>
    <Reference Include="Realm.DataBinding, Version=1.0.0.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Realm.DataBinding.1.0.0\lib\MonoAndroid44\Realm.DataBinding.dll</HintPath>
    </Reference>
    <Reference Include="Realm.Sync, Version=1.2.0.0, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Realm.1.2.0\lib\netstandard1.4\Realm.Sync.dll</HintPath>
    </Reference>
    <Reference Include="Remotion.Linq, Version=2.1.0.0, Culture=neutral, PublicKeyToken=fee00910d6e5f53b, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Remotion.Linq.2.1.1\lib\portable-net45+win+wpa81+wp80\Remotion.Linq.dll</HintPath>
    </Reference>
    <Reference Include="System" />
    <Reference Include="System.IO.Compression" />
    <Reference Include="System.Net.Http" />
    <Reference Include="System.Xml" />
    <Reference Include="System.Core" />
    <Reference Include="Validation, Version=2.2.0.0, Culture=neutral, PublicKeyToken=2fc06f0d701809a7, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Validation.2.2.8\lib\dotnet\Validation.dll</HintPath>
    </Reference>

This looks like an issue with Xamarin Studio, possibly related to this issue. Can you try following those steps?
It doesn't look like the project is referencing Microsoft.Net.Http, you may need to add this package.
As this does not appear to be an issue with the .NET SDK, I'm closing this issue. If you find that there is indeed an SDK bug, feel free to comment and we will reopen.

actually I am using Visual studio 2017 with xamarin, not Xamarin Studio,
also the System.Net.Http package is properly installed, however the version is 4.0.0, is there a way to include two versions of the same package in a solution?

I don't believe it's possible to include multiple versions of the same package.

dfg

Hello,
I have the same problem - on install AWSSDK.S3 to Visual studio 2017  Xamarin  project ( android specific ), receive the same exception during build
Do you have any solution/workaround?
Thanks

Can you share screen shot wat u get error
On Oct 3, 2017 12:59 PM, "anneiman" notifications@github.com wrote:

Hello,
I have the same problem - on install AWSSDK.S3 to Visual studio 2017
Xamarin project ( android specific ), receive the same exception during
build
Do you have any solution/workaround?
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-net/issues/626#issuecomment-333762614,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeCjbyo_Y3uDdfG30zo8q8JvO7laL__9ks5soeJHgaJpZM4NF5ce
.

Just  a momemnt , it seems, I found some workaround . I installed the old version 3.3.0 of AWSSDK.s3 instead of the latest one and it works. I am checking which is the latest suitable version.

The latest suitable version of of AWSSDK.s3 is 3.3.1.1. If I install  this version of AWSSDK.s3, my project is built successfully.
If I use the newer AWSSDK.s3 version ( from 3.3.1.2 till the latest one ) , I receive following exception during the project build . There is no difference in the project unless the version of AWSSDK.s3
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1391,2): error : Exception while loading assemblies: System.IO.FileNotFoundException: Could not load assembly 'System.Net.Http.Primitives, Version=1.5.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Perhaps it doesn't exist in the Mono for Android profile?
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1391,2): error : File name: 'System.Net.Http.Primitives.dll'
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1391,2): error :    at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve(AssemblyNameReference reference, ReaderParameters parameters)
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1391,2): error :    at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve(AssemblyNameReference reference)
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1391,2): error :    at Xamarin.Android.Tasks.ResolveAssemblies.AddAssemblyReferences(DirectoryAssemblyResolver resolver, ICollection`1 assemblies, AssemblyDefinition assembly, Boolean topLevel)
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1391,2): error :    at Xamarin.Android.Tasks.ResolveAssemblies.Execute(DirectoryAssemblyResolver resolver)
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

Hello,
First Remove namespace System.Net.Http after add namespace like(short cut
key ctrl.)
On Oct 3, 2017 12:59 PM, "anneiman" notifications@github.com wrote:

Hello,
I have the same problem - on install AWSSDK.S3 to Visual studio 2017
Xamarin project ( android specific ), receive the same exception during
build
Do you have any solution/workaround?
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-net/issues/626#issuecomment-333762614,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeCjbyo_Y3uDdfG30zo8q8JvO7laL__9ks5soeJHgaJpZM4NF5ce
.

authors: PavelSafronov anneiman meruvasudham superphil0

repo: aws/aws-sdk-net


text:
CVE-2024-24790

Critical CVE in Go lang stdlib 1.22.2
https://nvd.nist.gov/vuln/detail/CVE-2024-24790
Seems to be found in all of the latest releases of aws x-ray daemon, e.g. public.ecr.aws/xray/aws-xray-daemon:3.x

Seems to be fixed in - https://github.com/aws/aws-xray-daemon/pull/222
Closing the issue

repo: aws/aws-xray-daemon


text:
tx.Prepare undefined

The error occured when I'm trying to use xray for SQL Transactions:
stmt, err := tx.Prepare(ctx, `INSERT INTO names ( name ) VALUES ( ? )`)
if err != nil {
	return err
}

Err: tx.Prepare undefined (type *xray.Tx has no field or method Prepare)
Environment:

Go version go1.12.1 darwin/amd64
SDK version 1.0.0-rc.13

It seems that the issue is because dep dependency manager not installing specific version correctly; Overriding with master branch fixed it!

repo: aws/aws-xray-sdk-go


text:
Remove raymond-zhang00 from OWNERS

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

repo: aws/eks-anywhere-build-tooling


text:
Adding go:embed for oidc roles back

Description of changes:
Fixes failing OIDC e2e tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve

/cherrypick release-0.12

authors: abhay-krishna pokearu

repo: aws/eks-anywhere


text:
Add Docker ControlPlaneSpec to generate capi objects

Issue #, if available:
Description of changes:
Added functionality to build Docker Control Plane(CP) Spec by generating the CP yaml and parsing that to obtain the corresponding objects
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


text:
Bumped development release number for 1.24

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

repo: aws/eks-distro


text:
fix(pre-launch science review): correcting categories for toxicity da…

Correcting category columns for toxicity datasets:

BOLD: changed category column to domain. Reason: too many categories for the default number of samples (100). Domains are super-categories of the previous category category. There are 5 domains and 43 categories. With 100 samples as default, we cannot meaningfully cover 43 categories.
RealToxicityPrompts: added the category challenging that was missing. [removed this]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Correcting category columns for toxicity datasets:

BOLD: changed category column to domain. Reason: too many categories for the default number of samples (100). Domains are super-categories of the previous category category. There are 5 domains and 43 categories. With 100 samples as default, we cannot meaningfully cover 43 categories.
RealToxicityPrompts: added the category challenging that was missing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

BOLD change looks good, where is the RealToxicityPrompts change? Is it still part of this CR?

@polaschwoebel  no longer, updated the description

authors: franluca polaschwoebel

repo: aws/fmeval


text:
Python: adds XADD, XTRIM commands

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@acarbonetto please sync docs with your PRs

authors: Yury-Fridlyand shohamazon

repo: aws/glide-for-redis


text:
Fix java IT for linter

Issue #, if available:
N/A
Description of changes:
A comment in info_with_routing_and_options was confusing spotless and it was ignoring this file entirely.
Some technical details:
Skipping '/mnt/c/GitHub/babushka/java/integTest/src/test/java/glide/cluster/CommandTests.java' because it does not converge.  Run {@code spotlessDiagnose} to understand why

> Task :spotlessJavaDiagnose
    integTest/src/test/java/glide/cluster/CommandTests.java diverges after 10 steps

https://github.com/diffplug/spotless/blob/main/PADDEDCELL.md
There is a spotless rule conflict, it goes to patch the file infinitely, but luckily it has a protection and breaks on 10th iteration.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Good idea, added.
See tests in CI: one two.
Kudos to @MitchellGale for the help


text:
chore(go): code generation for extensions

Interfaces extended by other interfaces will be generated as embedded interfaces; for datatype interfaces, the properties will be flattened by the struct proxy. Also add code generation for setter methods on classes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 7283f3cab0b2e0c2de485dee9fef8c67d6d5ac2e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

authors: SoManyHs aws-cdk-automation

repo: aws/jsii


text:
fix(pacmak): greatly reduce go code-gen memory footprint

The go code generator was previously holding multiple copies of the
RootModule objects for dependencies (one for the generated package's
own RootModule, and one for each submodule that uses a type from that
dependency), including their entire type hierarchy, methods and
properties.
On large packages, especially with many submodules, this results in an
extremely large resident set size. Pathological cases have required
heaps as big as 6 GiB.
De-duplicating the RootModule instances, and not retaining GoTypeRef
instances (which are stateless, and cheap to construct), allows reducing
those pathological modules to only occupy around 300 to 400 MiB worth of
heap, which is a very significant improvement.
The reduction of duplication also has significant performance benefits
on affected code-bases. The go bindings generate significantly faster on
top of needing significantly less memory.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you so much 🚀

authors: RomainMuller ansgarm


text:
Metrics for failure reason when no instance type fits

Description
What problem are you trying to solve?
We had a recent incident that someone in the team adjusted the resources for a Daemonset and resulting the bin-packed pods being evicted due to Daemonset overhead, and were stuck in pending forever. Karpenter did show an error when it failed to provision a new node because of no instance type fits, but it would be nice if there are metrics around the reason, so we can easily setup alerts to monitor the failures.
How important is this feature to you?
This allows us to setup alerts to monitor node provisioning failures because of no instance type matches the requirement.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

and were stuck in pending forever

I'm a little confused by this. So, if I understand the order of events:

DaemonSet resources were increased
DaemonSet has a higher priorityClass than the other pods, so that caused a preemption on the workload pods
The DaemonSet resources + the workload pods were now too big for any instance type that your NodePool supports?

I'm trying to understand why number 3 failed? Why did Karpenter not react and showed the error that it did? Can you share your NodePools and EC2NodeClasses that you are using? Along with the Karpenter version?

and were stuck in pending forever

I'm a little confused by this. So, if I understand the order of events:

DaemonSet resources were increased
DaemonSet has a higher priorityClass than the other pods, so that caused a preemption on the workload pods
The DaemonSet resources + the workload pods were now too big for any instance type that your NodePool supports?

I'm trying to understand why number 3 failed? Why did Karpenter not react and showed the error that it did? Can you share your NodePools and EC2NodeClasses that you are using? Along with the Karpenter version?

This is exactly the order, and to be clear, Karpenter did show the error in the logs. We specified a single node type of m5.4xlarge for the node pool, and we tweaked the resources request for the deployment so that only one pod is scheduled to a single node.
What we would love to have is a metrics that can report the reason why Karpenter cannot determine the node type that can fulfil the requirements, and in this case it is "no instance type that can fulfill the resources requirement".
We are running Karpenter v0.31.0, with a Provisioner with only m5.4xlarge nodes type, if this is helpful.

authors: jonathan-innis nandiheath

repo: aws/karpenter-provider-aws


text:
Options for specifying AWS EC2 fleet allocation strategy

Tell us about your request
Adding options for specifying EC2 fleet allocation strategy by users.
Currently it's automatically decided by Karpenter:

capacity-optimized-prioritized - spot
lowest-price - on-demand

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Specifying other strategies by users should be useful especially in case of cost-sensitive workloads.
Currently Karpenter has no option for this so what the users only can do is to build their own controller from the source.
Are you currently working around this issue?
There is no work around now.
Additional context
I posted a PR for this issue: #1238 .
Would you like to use the PR for the basis of discussions.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

I'm removing the launch-templates label. This specific issue is related to how we configure the EC2 Fleet - allocation strategies aren't a part of the EC2 LaunchTemplate itself

What other strategies would you want to use in Karpenter? Do you want different ones for both Spot and On-Demand?

What other strategies would you want to use in Karpenter?

We'd like to use the options of FleetAPI:
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ec2/create-fleet.html
We could add the options to AWSNodeTemplate API like:
apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  name: default
spec:
  subnetSelector:
    karpenter.sh/discovery: ex-cluster
  securityGroupSelector:
    karpenter.sh/discovery: ex-cluster
  instanceProfile: MyInstanceProfile
  launchTemplate: MyLaunchTemplate
  onDemandOptions:
    allocationStrategy: prioritized
  spotOptions:
    allocationStrategy: lowest-price

Hello @akestner. Just a comment from me that if there is no space to implement all strategies at the moment (as @literalice described above), would be super great to see at least lowestPrice strategy for Spot instances 🙏 .

Latest news
https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-ec2-price-capacity-optimized-allocation-strategy-provisioning-ec2-spot-instances/

Latest news https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-ec2-price-capacity-optimized-allocation-strategy-provisioning-ec2-spot-instances/

That post mentions Karpenter v0.19.0. but I cannot find that release anywhere.

@meskander-nydig afaik it is not out (yet)

🏃♂

+1

Need to change to capacity-optimized and can't see documentation on how to do so.

Why was this closed versus some minor adjustments? https://github.com/aws/karpenter/pull/1238

+1

We're specifically looking for capacity-optimized as well.

+1 for capacity-optimized

According to the latest documentation, the current strategy for Spot instances is PriceCapacityOptimized, not CapacityOptimizedPrioritized.
I would use a lowest-price strategy, if available, for Spot instances that are in a cluster I have dedicated to handling short-lived jobs that come in bursts. In other words, the expected lifetime of an instance is under an hour, so I'm not too worried about interruptions, and would prefer the lowest price.
Conversely, I might try to use capacity-optimized for a different pool that runs jobs that take 8-12 hours. Right now I have to run those on On Demand instances.

Is there any update on this? We'd much prefer to have the option to use CapacityOptimizedPrioritized

I'm wondering is anyone will be working on that, it would be great to be able to control that strategy and even better if you could do it at the nodepool level.

authors: AndrzejWisniewski FernandoMiguel Nuru akestner andy-townsend dcarrion87 ellistarn liorfranko literalice meskander-nydig scohen-nd seagyn sergiynesterenko90 suket22 yair-sedaka

repo: aws/karpenter


text:
Why did Karpenter remove the code about node creation and pods prebinding?

Is an existing page relevant?
No response
What karpenter features are relevant?
k8s node object creation  after lauch machines
bind pods to node after k8s node object created
How should the docs be improved?
Since they were Karpenter's key features and main differences from cluster-autoscaler  which was mentioned in docs ,  are there some reasons for the major changes? Is there other way to maintain these features besides using the old version.
It would be very helpful for users to understand if the contexts and reasons about the major changes added.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Pre-binding pods to nodes turned out to not work well in-practice. A lot of Kubernetes components expect that the pod is bound by the scheduler once the kubelet has registered and initialized. We decided to let kube-scheduler bind the pods to the node to avoid this and saw that performance was actually better in this case and also removed a lot of edge cases. We're taking this further to where Karpenter will also stop creating the node resource in the near future.
Here are some links to more context:

https://github.com/aws/karpenter/pull/1856 (PR to remove pre-binding pods to nodes)
https://github.com/aws/karpenter/issues/1537
https://github.com/aws/karpenter/issues/1459
https://github.com/aws/karpenter/issues/1252


text:
Detect and correct "incorrect" use of new FnJoin

A common developer error is to pass an array as the second argument of
new FnJoin, but that argument is variadic. This causes invalid
CloudFormation templates to be generated. This change corrects the
API to match the Fn::Join syntax where the second argument is an
array.
Related to #512

I'm tracking down places where the "old" syntax was used and fixing those (they are what causes the CodeBuild to fail).

repo: awslabs/aws-cdk


text:
feat: adding frontend and backend feature flags

Feature or Bugfix

Feature

Detail

Adding frontend support for all feature flags defined in config.json with a new util method isFeatureEnabled
Adding a new flag preview_data in the datasets module to control whether previewing data is allowed
Adding a new flag glue_crawler in the datasets module to control whether running glue crawler is allowed
Updating environment features to be hidden or visible based on whether the module is active. Adding a new util isAnyFeatureModuleEnabled to check whether to render the entire feature box.

Relates
N/A
Security
Not relevant
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I tested in an AWS Deployment with the feature flags both on and off and is working as expected
One other thing I noted is that we use default useState('preview') in TableView.js to default to the Preview Tab. If that tab is disabled then when as a dataset owner navigating to the path /console/datasets/table/${table.tableUri} it will first have nothing but the tab options showing which I user will then have to select (see screenshot)

Alternatively, we can make overview the default Table tab opened (i.e. useState('overview')) - but trying to think through if this would cause any issues for a Requestor since when a requestor navigates to the catalog and clicks on a table to inspect from the catalog they also get navigated to /console/datasets/table/${table.tableUri}

useState('preview')

Thank you @zsaltys for this PR - I will merge this through to v2m1m0 tomorrow barring any additional review comments found by @dlpzx

authors: noah-paige zsaltys

repo: awslabs/aws-dataall


text:
Docs: Cors Preflight configuration for ALBResolver

What were you searching in the docs?
This is either a bug or a documentation issue. I am looking at this section of the documentation. The way I read the documentation is that if cors_config is provided, powertools will automatically handle preflight 'OPTIONS' requests. In other words, you do not need to write and code to handle options requests as long as you provide a cors_config in the ALBResolver constructor. This does not appear to be the case. When fronting a lambda with an ALB, the preflight request fails, even if cors_config is provided, unless the options request is explicitly handled in the lambda code.
Is this related to an existing documentation section?
https://awslabs.github.io/aws-lambda-powertools-python/latest/core/event_handler/api_gateway/#pre-flight
How can we improve?
Clarification of the documentation for preflight requests for ALBs specifically. Also a code example of how to handle preflight requests for a lambda fronted by and ALB would be nice. Thanks!

Got a suggestion in mind?
No response
Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

hey @francispeabody, thanks for helping us improve our docs! I've just created a test and we're returning the CORS headers as expected - could you provide a sample or something we could try to reproduce?
We can deploy an ALB + Function to try later once we have more details.
Thank you!

Reproduced! @francispeabody, it's our bug. Changing the labels to bug - repro here: https://github.com/heitorlessa/pt-1248

@francispeabody here's a workaround for now while I find which header is causing ALB to panic: https://github.com/heitorlessa/pt-1248/commit/67cc63e2d86c6b11400338a885332f1cfe649af9

Found the issue - ALB apparently faults if the body is null. I'm gonna raise a ticket to the ALB team but in the meantime, we'll make a bug fix release. I just wanna make sure API Gateway doesn't have side effects with a empty bull (not null) before making this change.

Confirmed, it's just ALB. CORS Specification also doesn't dictate whether the response body should be present, so it's more of a serialization issue in ALB - we'll change on our side for now and inform the ALB team internally.
Thank you so much @francispeabody .

ALB
15:26:19 ➜ pt-1248 git:(master!) http --follow --verbose OPTIONS $ENDPOINT
OPTIONS /hello HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Length: 0
Host: pt-12-myloa-nmcfguurzny6-1668993808.eu-west-1.elb.amazonaws.com
User-Agent: HTTPie/2.4.0

# Response

HTTP/1.1 204 No Content
Access-Control-Allow-Headers: Authorization,Content-Type,X-Amz-Date,X-Amz-Security-Token,X-Api-Key
Access-Control-Allow-Methods: GET,OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Max-Age: 1
Connection: keep-alive
Date: Thu, 16 Jun 2022 13:26:22 GMT
Server: awselb/2.0

API Gateway
15:26:23 ➜ pt-1248 git:(master!) ENDPOINT="https://420cn1i5v5.execute-api.eu-west-1.amazonaws.com/Prod/hello"

15:26:39 ➜ pt-1248 git:(master!) http --follow --verbose OPTIONS $ENDPOINT
OPTIONS /Prod/hello HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Length: 0
Host: 420cn1i5v5.execute-api.eu-west-1.amazonaws.com
User-Agent: HTTPie/2.4.0

HTTP/1.1 200 OK
Access-Control-Allow-Headers: Content-Type, X-Forwarded-For
Access-Control-Allow-Methods: GET
Access-Control-Allow-Origin: *
Access-Control-Max-Age: 1
Connection: keep-alive
Content-Length: 3
Content-Type: application/json
Date: Thu, 16 Jun 2022 13:26:42 GMT
Via: 1.1 83bc0649a33d85c1cf516bf48779a390.cloudfront.net (CloudFront)
X-Amz-Cf-Id: UExltMRxrJ75RmUg227tCf94qgpMEIGpESVKOewjmsOjt0EaS7cXOQ==
X-Amz-Cf-Pop: AMS1-C1
X-Cache: Miss from cloudfront
x-amz-apigw-id: T0Re4HyqjoEFcDg=
x-amzn-RequestId: 5defa35b-1fe9-4a82-b808-e09a71c248c5

{}

hey @francispeabody the fix is now out within 1.26.2 version in PyPi/SAR. I've started the release for Lambda Layer version 21 - might take a few hours to hit all commercial regions we support.

authors: francispeabody heitorlessa

repo: awslabs/aws-lambda-powertools-python


text:
Create Successful But Rolled Back

I followed the instructions to create a new stack but it seems that there were still some issues to be ironed out. S3 buckets were not created.

Can you delete that stack and try again now? There was an issue with the code earlier where it relied on the aws cli instead of wget but a fix got pushed in c99caf5d2e5a4679d88e126bcdcbf544d2acf0d7

It works now. Thanks!

authors: anguillanneuf ranman


text:
Update README.md; add warning for Yarn users

Issue #, if available:
Related to #349, but not a complete solution.
Description of changes:
You cannot use yarn global to install aws-sam-local, which could be a little unintuitive for some Yarn users. This adds a warning so they don't get stuck.
Also fixes the styling of "npm", which should always be lowercase.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Not relevant anymore as of https://github.com/awslabs/aws-sam-cli/releases/tag/v0.3.0

authors: rbrtmrtn sanathkr

repo: awslabs/aws-sam-cli


text:
Fixed build errors and failed unit tests with MSVC 2015

Tried to build the sdk on Win7 x64 with MSVC 2015 (x86 + x64) but hit several compilation errors, warnings and one broken unit test!
Please note that i did not try to build it with my changes on Linux/MacOS with gcc/clang!

You are right, bretambrose!
Unfortunately my change in ComputeIdentityFilePath() went sideways ... it breaks the test when built with MSVC 2013!
Apparently tmpnam_s() returns an absolute path (like "C:\Users\You\whatever\Temp\temp.file") when built with MSVC 2015 but only a filename with a "" in front  (like "\temp.file") when built with MSVC 2013 :(
At least it does in my environment ...
I use this command lines:
x86:
cmake c:\Users\Berti\Documents\aws-sdk-cpp -G "Visual Studio 14 2015"
cmake c:\Users\Berti\Documents\aws-sdk-cpp -G "Visual Studio 12 2013"
x64:
cmake c:\Users\Berti\Documents\aws-sdk-cpp -G "Visual Studio 14 2015 Win64"
cmake c:\Users\Berti\Documents\aws-sdk-cpp -G "Visual Studio 12 2013 Win64"
I just committed a runtime fix for this in my fork.
The way i read the MSDN description of tmpnam_s() one has to be able to handle both although the documentation does not note any changes between MSVC 2013 and 2015 that i could spot ...

Well, then, size_t is the correct type, yes.
The two renamed local variables in jsoncpp.cpp and URI.cpp where warnings, but treat warnings as errors is enabled on the MSVC project files created by cmake!

this change has been merged. Thank you for your help!

@bretambrose:
good find on CRT changes in MSVC 2014 CTP1!
BTW: MSVC 2014 got renamed to 2015 before release, so only mentioning 2014 in the comment my be confusing.
One more thing:
My cmake (3.3.1) help states that "Visual Studio 12 2013 [Win64]" is the generator name for MSVC 2013 but your README.md suggests "Visual Studio 12 [Win64]"!
Maybe not really an issue but the difference caught my eye!?

authors: JonathanHenson bmildner

repo: awslabs/aws-sdk-cpp

license_source: bigquery


text:
s3TransferManager is uploading files with Content-Encoding metadata empty

Describe the bug
s3TransferManager is uploading files with Content-Encoding metadata empty, we are uploading some files to s3 with the crt Async client, and the metadata of the objects in s3 contains the Content-Encoding key with an empty value

We are uploading text files and we do not need this Content-Enconding
We tried setting it to null from the code, but it was still created with an empty value.
Expected behavior
Objects in s3 without the key Content-Encoding in metadata
Current behavior
Objects in s3 with the key Content-Encoding in metadata

Steps to Reproduce
Dependencies used in the project:
    implementation(platform("software.amazon.awssdk:bom:2.20.42"))
    implementation("software.amazon.awssdk:s3:2.20.42")
    implementation("software.amazon.awssdk:s3-transfer-manager:2.20.42")
    implementation("software.amazon.awssdk.crt:aws-crt:0.29.10"

Code where the s3Client and the s3TransferManager are being instantiated
    @Bean
    fun S3AsyncClient(s3Properties: S3Properties): S3AsyncClient =
        S3AsyncClient.crtBuilder()
            .region(Region.of(s3Properties.region))
            .targetThroughputInGbps(s3Properties.targetThroughputInGbps)
            .minimumPartSizeInBytes(s3Properties.minimumPartSizeInMegaBytes * MB)
            .build()

    @Bean
    fun S3TransferManager(s3AsyncClient: S3AsyncClient): S3TransferManager =
        S3TransferManager.builder()
            .s3Client(s3AsyncClient)
            .build()

Code that we are using to upload a directory to s3
override fun uploadDirectoryAsync(destinationFolder: String, directory: Path): CompletableFuture<URI> {
        val directoryUpload = s3TransferManager.uploadDirectory(
            UploadDirectoryRequest.builder()
                .source(directory)
                .bucket(s3Properties.recordingsBucketName)
                .s3Prefix(destinationFolder)
                .build()

        )
        val directoryUriParameters = mapOf("bucket" to s3Properties.recordingsBucketName, "path" to destinationFolder)
        return directoryUpload.completionFuture().thenApply { uriTemplate.expand(directoryUriParameters) }
    }

Possible Solution
No response
Context
No response
AWS Kotlin SDK version used
implementation(platform("software.amazon.awssdk:bom:2.20.42"))     implementation("software.amazon.awssdk:s3:2.20.42")     implementation("software.amazon.awssdk:s3-transfer-manager:2.20.42")     implementation("software.amazon.awssdk.crt:aws-crt:0.29.10")
Platform (JVM/JS/Native)
JVM
Operating System and version
Amazon linux 2 and running locally in MAC OS Sonoma 14.2.1

Thanks for the issue but you appear to be using the aws-sdk-java-v2 and not the AWS SDK for Kotlin.
Unfortunately I can't transfer this automatically to that repo for you because it is in a different GitHub organization. Please open an issue there.

authors: aajtodd swilsonmelo

repo: awslabs/aws-sdk-kotlin


text:
Missing post-installation commands

Hello,
this documentation is missing an important part of Symfony deployments, which are the post installation commands for warming up the cache, removing app_dev.php (if required) and checking that the server is properly configured (php bin/console doctrine:ensure-production-settings --env=prod).
When and how should these post-installation steps be performed?

Hi vlahanas,
Sorry about the delayed response. I'm not very familiar with Symfony. Can you provide more information about the commands that need to be run and how to check configuration?
You can use configuration files to run commands during deployments [1]. To remove a file, delete it from your source code, commit, and then redeploy. To run a command on an instance once without deploying, connect to it over ssh with the eb ssh command or by following the instructions in the guide [2].
[1] Customizing Software on Linux Servers
[2] Listing and Connecting to Server Instances

Also delayed response, sorry about that,
Symfony provides a number of commands for the execution of post-installation actions, allowing to properly "initialize" your setup. The most commonly used are:

Database update
php bin/console doctrine:schema:update

Checking that the environment is properly configured for production
php bin/console doctrine:ensure-production-settings --env=prod

Clearing and warming up the cache
php bin/console cache:clear --env=prod

These commands can be performed in the .config file, but the catch is that one of them might fail, if for instance you need to connect to an RDS database (command no1) and during the initial EB deployment, you have not properly set the connection info. Then, the whole deployment fails and you end up with a degraded environment status, trying to figure out what the problem.
I am currently performing these commands inside a "post-install-cmd" block at the composer file, and some extra commands using ssh as you said. But the average (or bellow-average, as i am 😄 ) user would be grateful if this complete deployment process was described in the documentation!

authors: mwunderl vlahanas

repo: awslabs/elastic-beanstalk-docs


text:
Tweaking readme

Supports Homebrew. :beer:
See: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/git-secrets.rb

Thanks!

authors: manabusakai mtdowling

repo: awslabs/git-secrets


text:
Fix quantiles used forecasts produced by TemporalFusionTransformer

Issue #, if available: Fixes #1944
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

Can we add a test?

authors: jaheba lostella

repo: awslabs/gluon-ts


text:
Remove freq argument in SeasonalNaivePredictor

Description of changes: So far, freq was a mandatory argument in constructing SeasonalNaivePredictor. However, its role is not really clear this way: what is it used for? Can the predictor only treat data sampled at frequency freq? No, the frequency information is only used to infer the seasonality in case not directly provided.
This PR fixes this by removing freq altogether: now season_length is required.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

Removed freq altogether, making season_length mandatory.

I think naive2 could be simplified in a similar way, see https://github.com/awslabs/gluonts/blob/3ccb6d377a5bf9b27de74a47cdab295f4d61f7a7/src/gluonts/ext/naive_2/_predictor.py#L61-L80

@lostella Do you want to adjust naive2 in a separate PR?

repo: awslabs/gluonts


text:
revise AWS cloud provider page, including constraints

The page should separate the constraints into intuitive categories.
The page should include a table that summarizes the constraints, including describing the defaults and specification options.

from @ellistarn re: table
Kubernetes Well Known Labels

Constraint
Global Default
Provisioner Default
Pod NodeSelector

Instance Type
All EC2 Instance Types
spec.instanceTypes
node.kubernetes.io/instance-type

Zone
All EC2 Zones w/ Subnets
spec.zones
topology.kubernetes.io/zone

Architecture
amd64
spec.architecture
topology.kubernetes.io/zone

Operating System
Cloud Provider Specific
spec.operatingSystem
topology.kubernetes.io/zone

AWS Specific

Constraint
Global Default
Provisioner Default
Pod NodeSelector

Security Group
All EC2 Instance Types
spec.instanceTypes
node.kubernetes.io/instance-type

Subnet
All EC2 Zones w/ Subnets
spec.zones
topology.kubernetes.io/zone

LaunchTemplate
Cloud Provider Specific
spec.zones
topology.kubernetes.io/zone

Cloud Provider Specific
spec.zones
topology.kubernetes.io/zone

BTW, I'm removing OS as part of https://github.com/awslabs/karpenter/pull/780

authors: eptiger geoffcline

repo: awslabs/karpenter


text:
Add LibreSSL to TravisCI build

Currently, we only build s2n with Openssl's libcrypto in TravisCI: https://github.com/awslabs/s2n/blob/master/.travis/install_openssl.sh#L33 . If we're going to advertise support for other major libcrypto's, we should include them in our builds.

The steps needed to build with LibreSSL are already documented in https://github.com/awslabs/s2n/blob/master/docs/USAGE-GUIDE.md . We just need to add those steps in the Docs to a .travis/install_libressl.sh that builds and installs LibreSSL in the same place as .travis/install_openssl_*.sh and add it to the .travis.yml file.

#410 should make this change easier. We can build/cache libressl and set LIBCRYPTO_ROOT as needed.


text:
[BUG] Bootstrap toolchain allows no trusted principals

The CLI command seedfarmer bootstrap toolchain allows the user to not pass in a trusted principal ARN, causing the toolchain template to fail.  There should be a trusted-principal ARN that is valid as a required field when making this call.

This validation should occur in the seed-farmer/seedfarmer/commands/_bootstrap_commands.py::bootstrap_toolchain_account to be sure that the ARN is a valid format.  There are times where this command is called w/o a principal passed in b/c the toolchain role is created and unchnaged, but the deployment role needs to be deployed (and the user is using the --as-target flag)

Just hit this issue, I don't think you would ever call it w/o needing a principal?

I would lean towards requiring the user to specifying the principal on every call to bootstrap, but I'll take a look and implement validation.

Added a proposed change @dgraeber above, lmk your thoughts.

authors: dgraeber kenerwin88 malachi-constant

repo: awslabs/seed-farmer


text:
Is round corner removed from this version

I deployed previous version in which round corner filter were working but with current one I am not able to figure out how to make JSON format for round corner attribute.
please let me know if there is any way to implement that.

Hi @zeroshree, I found the following info from the SharpJS developer on how to tackle this. Links provided below:
https://github.com/lovell/sharp/issues/565
https://github.com/lovell/sharp/issues/435
Hope this helps!

Thanks

authors: hayesry zeroshree

repo: awslabs/serverless-image-handler


text:
[Feature Request] AWS Synthetics Canaries failing to monitor SWB - 403 error

Hi,
I tired to use AWS  Synthetics Canaries  to monitor SWB (v5.0) and I'm getting a 403 Application denied error
Is there anything to change on AWS Synthetics Canaries default script OR on SWB to enable it to work?
Thanks!
Paul

Closing due to no response

authors: avillach maghirardelli

repo: awslabs/service-workbench-on-aws


text:
[Docs] Add initial documentations

Description
This PR adds documentations for installation, quick-start, and tutorials on single and multiple device optimizations. The webpage is already online on https://awslabs.github.io/slapo/.
Checklist

[x] PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Thanks @chhzh123

repo: awslabs/slapo


text:
Add decorator to allow to make all operations fallible

Motivation and Context
Force all operations in the model to be fallible.
When this decorator is applied, operations that do not have a Smithy error attatched, will return Result<OperationOutput, InternalServerError>.
To enable this decorator, create a file called META-INF/service/software.amazon.smithy.rust.codegen.smithy.customize.RustCodegenDecorator containing codegen-server/src/main/resources/META-INF/services/software.amazon.smithy.rust.codegen.smithy.customize.RustCodegenDecorator.
Closes: #1150
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@crisidev is this path META-INF/service/software.amazon.smithy.rust.codegen.smithy.customize.RustCodegenDecorator meant to be from the smithy-rs project root? or from the root of the build task, and then it will read from under codegen-server-test/...?

assuming you're using the plugin from a separate gradle project, this META-INF would be within resources—you can see the aws/sdk directory as an example: https://github.com/awslabs/smithy-rs/blob/main/aws/sdk-codegen/src/main/resources/META-INF/services/software.amazon.smithy.rust.codegen.smithy.customize.RustCodegenDecorator

Hey @crisidev - I still can't make this work for me.
These are the steps I use to apply the decorator to codegen-server-test:
C1="software.amazon.smithy.rust.codegen.smithy.customize.RustCodegenDecorator"
C2="software.amazon.smithy.rust.codegen.server.smithy.customizations.FallibleOperationsDecorator"
D="codegen-server-test/src/main/resources/META-INF/services"
mkdir -p "$D"
echo $C2 > "$D/$C1"
./gradlew :codegen-server-test:test
grep -r InternalServerError codegen-server-test/build/

Does this work for you?
I expected at least operation Healthcheck from simple.smithy to have the internal error because it has no errors of its own.
I already tried a bunch of my monkey-in-cockpit tricks on the build.gradle.kts but no luck.
Maybe you see what I'm missing?
Thanks

@crisidev OK I found that when I put the META-INF service under codegen-server/ then it works and the decorator is loaded and the internal errors are generated !!! 🥳
(I just change in the script above to D="codegen-server/src/main/resources/META-INF/services")
But I can't make it work when I add it to the upper project codegen-server-test....
Must be a gradle hurdle.

To make it work everywhere, you can probably add it under the META-INF of codegen-server.. Not sure if that will make it work..

It seems to work, but is that how you mean that a server project will enable optional features - by changing the server-codegen project itself? Sounds hard to maintain. Isn't there a way to enable decorators from the caller project?

authors: crisidev guymguym rcoh

repo: awslabs/smithy-rs


text:
Example of building the service side using smithy?

Can't find any demo or example or anything useful here or on the internet.
Am I missing something?
Please provide a ref if one is known.
Thanks

There's work being done in TypeScript and Rust, but neither are well documented or beta quality yet from what I understand: https://github.com/awslabs/smithy-typescript/tree/main/smithy-typescript-ssdk-libs and https://github.com/awslabs/smithy-rs/tree/main/codegen-server

authors: Johnlon mtdowling

repo: awslabs/smithy


text:
Fix numpy warning in test_coverage_attention

This removes a warning when running pytest:
test/unit/test_attention.py::test_coverage_attention[tanh-4]
 [...]/test/unit/test_attention.py:124: RuntimeWarning: divide by zero encountered in true_divide
    expected_probs = np.ones_like(source_length_vector) /source_length_vector.reshape((batch_size, 1))

-- Docs: http://doc.pytest.org/en/latest/warnings.html

Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[x] Passed code style checking (./pre-commit.sh or manual run of pylint & mypy)
[x] You have considered writing a test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mjpost What exactly should I test here? The fact that lengths are now always > 0? I think thats fine since we never have 0-length data in Sockeye anyway.

repo: awslabs/sockeye


text:
Develop

Auditbeat

@njpatel closing this, as we have moved past this.

repo: axiomhq/docs


text:
Followup: one specific standalone updater is still broken

In reviewing shell installers produced after #1444, which was the fix for #1443, I'm still seeing the updater missing for one platform. Reviewing the actual data we're working off of, archive.updater is None for this one platform; it's assigned properly for every other platform. Here's an example from a generated shell installer produced from git HEAD.
    case "$_artifact_name" in
        "axolotlsay-aarch64-apple-darwin.tar.xz")
            _arch="aarch64-apple-darwin"
            _zip_ext=".tar.xz"
            _bins="axolotlsay"
            _bins_js_array='"axolotlsay"'
            _libs=""
            _libs_js_array=""
            _staticlibs=""
            _staticlibs_js_array=""
            _updater_name=""
            _updater_bin=""
            ;;
        "axolotlsay-x86_64-apple-darwin.tar.xz")
            _arch="x86_64-apple-darwin"
            _zip_ext=".tar.xz"
            _bins="axolotlsay"
            _bins_js_array='"axolotlsay"'
            _libs=""
            _libs_js_array=""
            _staticlibs=""
            _staticlibs_js_array=""
            _updater_name="axolotlsay-x86_64-apple-darwin-update"
            _updater_bin="axolotlsay-x86_64-apple-darwin-update"
            ;;
        "axolotlsay-x86_64-pc-windows-msvc.zip")
            _arch="x86_64-pc-windows-msvc"
            _zip_ext=".zip"
            _bins="axolotlsay.exe"
            _bins_js_array='"axolotlsay.exe"'
            _libs=""
            _libs_js_array=""
            _staticlibs=""
            _staticlibs_js_array=""
            _updater_name="axolotlsay-x86_64-pc-windows-msvc-update"
            _updater_bin="axolotlsay-x86_64-pc-windows-msvc-update"
            ;;
        "axolotlsay-x86_64-unknown-linux-gnu.tar.xz")
            _arch="x86_64-unknown-linux-gnu"
            _zip_ext=".tar.xz"
            _bins="axolotlsay"
            _bins_js_array='"axolotlsay"'
            _libs=""
            _libs_js_array=""
            _staticlibs=""
            _staticlibs_js_array=""
            _updater_name="axolotlsay-x86_64-unknown-linux-gnu-update"
            _updater_bin="axolotlsay-x86_64-unknown-linux-gnu-update"
            ;;

Turns out it wasn't that it was None - it's that Some(0) is falsy, so if archive.updater was returning false despite being assigned to a valid index.

repo: axodotdev/cargo-dist


text:
Fix typos and add typo checker

Description

Fix typos found by the typos tool.
Add a few exceptions in a typos.toml.
Add a CI job that runs the typos action

Motivation
I don't know if I need to motivate typo-checking but in case I do, my major motivations would be:

More readable and searchable docs
More searchable code base

Thank you! This looks great.
Sorry for the snapshot merge conflict - mind if I rebase this for you?

Thank you! This looks great.
Sorry for the snapshot merge conflict - mind if I rebase this for you?

Go ahread :+1:

authors: CramBL mistydemeo


text:
set the shellcheck as editable from the UI

As we create shell-checks with this tool right now. We set them to not be editable in the user interface but only to be editable by a script like this using the API. This change will disable the read-only allowing the shell check to be editable by any allowed user using the user interface.

Approved

authors: hshimizu marioaxonops

repo: axonops/axonops-config-automation


text:
🛑 Elmas Yeşiloğlu is down

In 944fa0c, Elmas Yeşiloğlu (https://www.elmasyesiloglu.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Elmas Yeşiloğlu is back up in 4470471 after 25 minutes.

repo: aydgn/upptime


text:
阿里云k8s 报错

> kubectl debug image-XXX --agentless=false
> error execute remote, error sending request: Post http://XXXX/api/v1/debug?command=%5B%22bash%22%5D&container=docker%3A%2F%2Fead772b991c55ead39787cb589847c75a9555e0ce190b12032cc0cc289addf93&image=nicolaka%2Fnetshoot%3Alatest: unexpected EOF

这个是防火墙的问题吗？
> kubectl apply -f https://raw.githubusercontent.com/aylei/kubectl-debug/master/scripts/agent_daemonset.yml

创建pod失败，看日志
standard_init_linux.go:207: exec user process caused "no such file or directory"

看起来是这个 pod 的镜像问题

看起来是这个 pod 的镜像问题

是我要debug pod 的镜像问题吗？看说明没有什么特别配置

看起来是这个 pod 的镜像问题

是我要debug pod 的镜像问题吗？看说明没有什么特别配置

是的，日志上显示文件不存在。

看起来是这个 pod 的镜像问题

是我要debug pod 的镜像问题吗？看说明没有什么特别配置

换一个镜像版本，aylei/debug-agent:latest 试试？

authors: NominationP markzhang0928 whalecold

repo: aylei/kubectl-debug


text:
generate a favicon.ico for our apps

style(apps): generate a favicon.ico for our apps

Fixes #216
Description of changes:

generated a new favicon.ico based off of the Astro Reactive logo
updated apps to use the new icon
Chrome:

Firefox:

Tag a reviewer: @ayoayco

Tasks:

[x] I have ran the build command to make sure apps are working: npm run build
[x] I have ran the tests to make sure nothing is broken: npm run test
[x] I have ran the linter to make sure code is clean: npm run lint
[x] I have reviewed my own code to remove changes that are not needed

Just wanted to know if someone uses dark theme in browser then tab color will also be dark so in that case does this logo looks good because logo has blue color, so it might not have good contrast with black color of tab. So can you please show how it looks when dark mode is on?

Dark mode Chrome:

Dark mode Firefox:

What do you guys think?

Dark mode Chrome:  Dark mode Firefox:  What do you guys think?

In my opinion in dark mode it doesn't looks good. What do you think @ayoayco ?
Right now in my mind there are 2 approaches to make this looks better:

Currently these is not background to our logo, that's why it is taking background-color of the background. So what we can do is add white circular background to the logo so, it will stay during white background and will also stay on dark background. On white background since background of the logo is also white so it will blend and will look like this . So we can use this approach.
Or we can create 2 different logo one for light and one for dark and change it according to theme like this

We can take improvements in another story so we iterate quickly. Can you put this in a new issue @Preet-Sojitra? Then I'm good for merging this one.

We can take improvements in another story so we iterate quickly. Can you put this in a new issue @Preet-Sojitra? Then I'm good for merging this one.
But if there is an easy one in suggested improvements, then let's have them here. What do you think @NeilAn99?

Yeah I will create new issue. You can merge this 👍

Dark mode Chrome:  Dark mode Firefox:  What do you guys think?

In my opinion in dark mode it doesn't looks good. What do you think @ayoayco ?
Right now in my mind there are 2 approaches to make this looks better:
1. Currently these is not background to our logo, that's why it is taking background-color of the background. So what we can do is add white circular background to the logo so, it will stay during white background and will also stay on dark background. On white background since background of the logo is also white so it will blend and will look like [this](https://user-images.githubusercontent.com/54966170/204962249-e98bbfa4-da1a-4c24-abbe-0b0317ac0e58.png) . So we can use this approach.

2. Or we can create 2 different logo one for light and one for dark and change it according to theme like [this](https://user-images.githubusercontent.com/54966170/204962249-e98bbfa4-da1a-4c24-abbe-0b0317ac0e58.png)

@NeilAn99 so which approach you want to take? I guess first one is easier to implement and you want to work in this PR only or should we create another issue?

I have made the changes for the first one @Preet-Sojitra @ayoayco.
Light mode:

Dark mode:

authors: NeilAn99 Preet-Sojitra ayoayco

repo: ayoayco/astro-reactive-library


text:
Copy/paste error in README.md

From 0.6.25 to 0.6.31 the compilation.md link in README.md points to release-contents.md instead of compilation.md

Ping. It's still so, as of today.

Can you edit and open PR?
On Thu, Oct 10, 2019 at 8:18 PM Wrong-Code notifications@github.com wrote:

Ping. It's still so, as of today.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/160?email_source=notifications&email_token=AASOSQIGZK34XPGLG3FRZ2LQN5WWZA5CNFSM4EZWPYC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5JDQI#issuecomment-540709313,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASOSQPZZ5JUZIBOPQZVJW3QN5WWZANCNFSM4EZWPYCQ
.

Sure, done now!

authors: Wrong-Code ayufan rosbif


text:
Fix Submit Boundary

Overview
There are two issues with the Submit Boundary feature:

API request to submit is broken. This is due to invalid timezone strings.
The "After Submit" modal isn't showing up. This is because it was moved to the draft tools which don't render when a submission is in "Submitted" state.

To Solve:

Use django's timezone.now(). See https://docs.djangoproject.com/en/3.2/topics/i18n/timezones/#naive-and-aware-datetime-objects. The seemed like a good idea to do everywhere so it's been replaced everywhere.
Move the "After Submit" modal to the parent, DrawTools component and render it only when in "Submitted" state. Still tie into the submit onSuccess so it doesn't show up on subsequent visits to the page.

Closes #193
Testing Instructions

./scripts/resetdb
Log in as contributor
Go to a "Draft" or a submission that "Needs Revisions"
Make changes and submit

[ ] Ensure "After Submit" dialog shows up

Revisit submission page

[ ] Ensure "After Submit" dialog is not visible
[ ] Ensure submission was saved successfully

Checklist

[ ] fixup! commits have been squashed
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
[ ] README.md updated if necessary to reflect the changes
[ ] CI passes after rebase

Taking a look

repo: azavea/iow-boundary-tool


text:
Style and include fixes

Since I've spent way too much time in the past filtering out the less useful iwyu includes...
Also added a fix so it compiles after the merge.

Thanks for this!

authors: azreika mmcgr

repo: azreika/souffle


text:
Source code for the MMA Removal tool function app

Hello,
I see the function apps of the MMA Removal tool rely on external packages stored at "https://aka.ms/AzTS/MMARemovalUtility/*".
Looking to the content, it's compiled code.
Is it possible to have access to the source code to evaluate what each function is doing?
(Main reason is to comply to my company Security policy).
Regards,

Closing this issue. Please feel free to reopen if you have any further questions or comments.

Hello,
I sent an email but got a "couldn't be delivered" reply with error:
"The group ssengteam only accepts messages from people in its organization or on its allowed senders list, and your email address isn't on the list."
Any advise?
Regards,

@TarunKrShukla @pranchalsomani Hello,
I did send an email to "aztssup@microsoft.com" but got a "Undeliverable" message back:
"The group ssengteam only accepts messages from people in its organization or on its allowed senders list, and your email address isn't on the list."
Could you help?
Regards,

authors: giraudeo pranchalsomani

repo: azsk/AzTS-docs


text:
Bug report- Query Parameters in apim operations not working as intended

Is there an existing issue for this?

[X] I have searched the existing issues

Community Note

Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Version of the module you are using
5.6.5
Rover Version
none
Terraform Version
1.3.0
AzureRM Provider Version
=> 2.99
Affected Resource(s)/Data Source(s)
api_management_api_operation
Terraform Configuration Files
global_settings = {
  default_region = "region1"
  regions = {
    region1 = "australiaeast"
  }
}

resource_groups = {
  rg1 = {
    name   = "example-agw"
    region = "region1"
  }
}

api_management = {
  apim1 = {
    name   = "example-apim"
    region = "region1"
    resource_group = {
      key = "rg1"
    }
    publisher_name  = "My Company"
    publisher_email = "company@terraform.io"

    sku_name = "Developer_1"
  }
}

api_management_api = {
  apimapi1 = {
    name = "example-api"
    resource_group = {
      key = "rg1"
    }
    api_management = {
      key = "apim1"
    }
    revision     = "1"
    display_name = "Example API"
    path         = "example"
    protocols    = ["https"]

    import = {
      content_format = "swagger-link-json"
      content_value  = "http://conferenceapi.azurewebsites.net/?format=json"
    }
  }
}

api_management_api_operation = {
  apimapio1 = {
    operation_id = "sample"
    api = {
      key = "apimapi1"
    }
    api_management = {
      key = "apim1"
    }
    resource_group = {
      key = "rg1"
    }

    display_name = "Get WishLists"
    method       = "GET"
    url_template = "/wishlists"
    description  = "Get WishList"
    request = {
      query_parameter = {
        name     = "test"
        required = false
        type     = "string"
      }
            query_parameter = {
        name     = "test2"
        required = false
        type     = "string"
      }
    }
  }
}

Expected Behaviour
Query parameters named "test" and test2 should created for apimapio1 api_management_api_operation  resource.
Actual Behaviour
The query parameters are not created and a terraform plan shows an empty request {} filed
Steps to Reproduce
terraform apply
Important Factoids
No response
References
No response

This implementation don't look right https://github.com/aztfmod/terraform-azurerm-caf/blob/c82cfc65eecd0b8603c4e64effcfbda69c238bd5/modules/apim/api_management_api_operation/module.tf#L26

Closing as merged in #1629

authors: arnaudlh jioblack

repo: aztfmod/terraform-azurerm-caf


text:
fix: Set Task as successful when exception should be ignored (Fixes #…

Fixes #634
Pull request description

PR meta checklist

[x] Pull request is targeted at main branch for code
or targeted at stable branch for documentation that is live on bunit.dev.
[x] Pull request is linked to all related issues, if any.
[x] I have read the CONTRIBUTING.md document.

Code PR specific checklist

[x] My code follows the code style of this project and AspNetCore coding guidelines.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] I have updated the appropriate sub section in the CHANGELOG.md.
[x] I have added, updated or removed tests to according to my changes.

[x] All tests passed.

Sorry @egil for the inconvenience .
Should have that behaviour earlier

Sorry @egil for the inconvenience .
Should have that behaviour earlier

No need to be sorry at all. We both missed it, and in the end it's my responsibility.
Your solution looks sound on the surface, but let's make sure we have attacked this from all angles. Are there any tests that are missing? Any of the paths through the code that are not covered with the latest changes?
I'll have some time later tonight or tomorrow to look through the code in detail and will add my analysis as well.

I just checked with a coverage tool from that point of view it looks good. But coverage alone is not a great metric on its own.
Anyway I thought to make another PR which either manually creates a report or automatically on every build.
The manual approach would like that:
dotnet test ../bunit.sln --collect:"XPlat Code Coverage" --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat="opencover"
dotnet tool install --global dotnet-reportgenerator-globaltool
reportgenerator.exe -reports:"./**/coverage**opencover.xml" -targetdir:"./CoverageReport" -reporttypes:"html"

A quick way to have a rough idea which areas should get a bit more attention.

I just checked with a coverage tool from that point of view it looks good. But coverage alone is not a great metric on its own.
Anyway I thought to make another PR which either manually creates a report or automatically on every build.
The manual approach would like that:
dotnet test ../bunit.sln --collect:"XPlat Code Coverage" --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat="opencover"
dotnet tool install --global dotnet-reportgenerator-globaltool
reportgenerator.exe -reports:"./**/coverage**opencover.xml" -targetdir:"./CoverageReport" -reporttypes:"html"

A quick way to have a rough idea which areas should get a bit more attention.

I actually used codecov for a bit, but didn't find it added much value in the CI pipeline, but I might reintroduce it.

I actually used codecov for a bit, but didn't find it added much value in the CI pipeline, but I might reintroduce it.

I think having special thresholds for the CI pipeline wouldn't give much, right, but it can give you a nice indication (especially for PRs). Unfortunately I have issues in my repositories with failing builds due to codecov.
Anyway I guess this is a different topic :D

Thanks, this actually made the code more simple. Well done.

authors: egil linkdotnet

repo: bUnit-dev/bUnit


text:
Inference against a corpus is segfaulting

I am migrating away from model.make_doc to tp.util.Corpus and am finding that using Corpus segfaults. My tiny repro is here:
#!/usr/bin/env python3

import time

import numpy as np
import tomotopy as tp

# Workaround for `str.split` received unknown kwarg user_data
class WSTok:
    def __call__(self, raw, **kwargs):
        return raw.split()

def get_highest_lda_list(model, N, docs):
    corpus = [model.make_doc(doc.split()) for doc in docs]
    topic_dist, ll = model.infer(corpus)
    k = np.argmax(topic_dist, axis=1)
    return [" ".join(e[0] for e in model.get_topic_words(k_, top_n=N)) for k_ in k]

def get_highest_lda_corpus(model, N, docs):
    corpus = tp.utils.Corpus(tokenizer=WSTok(), stopwords=[])
    corpus.process(doc for doc in docs)
    topic_dist, ll = model.infer(corpus)
    k = np.argmax([doc.get_topic_dist() for doc in topic_dist], axis=1)
    return [" ".join(e[0] for e in model.get_topic_words(k_, top_n=N)) for k_ in k]

if __name__ == "__main__":
    docs = [line.strip() for line in open('10_line_pretokenized_corpus.tsv')]
    lda = tp.LDAModel.load('tm_model.bin')
    N = 10
    t0 = time.time()
    list_res = get_highest_lda_list(lda, N, docs)
    print(f"Took {time.time() - t0} seconds (list)")
    corpus_res = get_highest_lda_corpus(lda, N, docs)
    print(f"Took {time.time() - t0} seconds (corpus)")
    t0 = time.time()
    assert all(e == f for e, f in zip(corpus_res, list_res))

When I run this, I see:
Took 19.61503529548645 seconds (list)
Segmentation fault (core dumped)

Running this with catchsegv shows these relevant lines:
/usr/lib/x86_64-linux-gnu/libc.so.6(+0x46210)[0x7f171bd43210]
/home/erip/.venv/lib/python3.8/site-packages/_tomotopy_avx2.cpython-38-x86_64-linux-gnu.so(_ZNSt6vectorIjSaIjEE12emplace_backIJRjEEEvDpOT_+0x7c)[0x7f16d662705c]
/home/erip/.venv/lib/python3.8/site-packages/_tomotopy_avx2.cpython-38-x86_64-linux-gnu.so(_Z10makeCorpusP16TopicModelObjectP7_objectS2_+0x681)[0x7f16d6db8f51]
/home/erip/.venv/lib/python3.8/site-packages/_tomotopy_avx2.cpython-38-x86_64-linux-gnu.so(_Z9LDA_inferP16TopicModelObjectP7_objectS2_+0x25a)[0x7f16d6d71b8a]

which seems to point here... maybe d.get() is null?

It seems like my WSTok is the issue and that it doesn't meet the expected interface (__call__ should return (tok, start, stop)). If I use tp.util.SimpleTokenizer(pattern="\w+"), it seems to be OK... this is somewhat unexpected, though so maybe documentation can be slightly improved.

Hi, @erip
Could you share some pieces of the file 10_line_pretokenized_corpus.tsv for reproducing?
A similar error is not reproduced in the sample text I have, so it is not easy to determine the cause.
If you share the file where the problem is reproduced, it will be of great help to find the cause.

@bab2min are you using the WSTok here? It should cause the error


text:
Allow imports in declare module

Q
A

Bug fix?
no

Breaking change?
no

New feature?
yes

Deprecations?
no

Spec compliancy?
yes

Tests added/pass?
yes

Fixed tickets

License
MIT

This allows import type or import typeof inside declare module.
This was done in flow in this commit: https://github.com/facebook/flow/commit/843389f89c69516506213e298096a14867a45061
//cc @jeffmo

Current coverage is 97.27% (diff: 100%)

Merging #315 into master will increase coverage by <.01%

@@             master       #315   diff @@
==========================================
  Files            21         21
  Lines          4001       4007     +6
  Methods         481        484     +3
  Messages          0          0
  Branches       1183       1182     -1
==========================================
+ Hits           3892       3898     +6
  Misses           49         49
  Partials         60         60

Powered by Codecov. Last update a1bfa02...a734422

authors: codecov-io danez jeffmo

repo: babel/babylon

license: mit