text:
[en] Fix Markdown formats

Main Changes

Change `hello,` world to `hello`, world
Use correct codenew statement

Related PR

#32907
#32908
Pending: id, fr, es, pt-br, de

@Sea-n Please limit pull requests to a single localization, since pull requests that change content in multiple localizations are difficult to review.
I suggest that you start with just the English changes that you wanted to make, and then open a separate PR for each localization that you want to update. We want separate PRs partly to allow sharing out the work, but mostly because I think we don't have any reviewers who speak all 13 languages that we've localized the docs into.

/hold
OK to /unhold once this PR only touches one localization.

Thanks very much for point out my mistake in the original PR! I have break it down to 8 separated branch for different language.
Here is PR for en, zh, it.
For id, fr, es, en, pt-br, de, I will open PR after your think it's okay.
CC @sftim

/unhold
/remove-language de es fr id it zh

/auto-cc

This is clean.
/kind cleanup
/lgtm
/approve

authors: Sea-n jihoon-seo sftim tengqm


text:
Add glossary entry for probe

I made a glossary entry for probe issue #39608
I may have made some mistakes since I am new to this but all feedback is welcomed

/sig node

Hey, can I get these changes reviewed if possible. Thank you in advance.

/assign @SergeyKanzhelev @mrunalp

@KhushPatibandha I don't see this in the glossary preview for some reason. Do you happen to know why?

/cc

@KhushPatibandha I don't see this in the glossary preview for some reason. Do you happen to know why?

Hey @bart0sh can you please elaborate on what you are saying? I thought I am only suppose to make a file named "probe.md" and add all the content in there. Am I suppose to do something differently that I am missing out on?

Hey @bart0sh can you please elaborate on what you are saying? I thought I am only suppose to make a file named "probe.md" and add all the content in there. Am I suppose to do something differently that I am missing out on?

I was hoping to see this content in the preview for this PR, but I don't see it there for some reason. This could be just because preview is not generated properly and doesn't include glossary content or because what you did is not enough. I'd suggest you to investigate this further.

Sure I'll look into it.

/label tide/merge-method-squash
/lgtm

Preview page:
https://deploy-preview-40131--kubernetes-io-main-staging.netlify.app/docs/reference/glossary/?all=true#term-probe

/approve

source: gharchive/pull-request

authors: KhushPatibandha bart0sh kbhawkey sftim

repo: kubernetes/website

license_type: permissive

license_source: github-api


text:
update container-runtime.md

Update container runtime description

/lgtm
/approve

authors: dejanu tengqm


text:
[zh] Localize /feature-gates/a*.md

Related to issue #44410
Add zh text to all filename prefixed with "a" in
content/zh-cn/docs/reference/command-line-tools-reference/feature-gates/

accelerators.md
admission-webhook-match-conditions.md
advanced-auditing.md
affinity-in-annotations.md
aggregated-discovery-endpoint.md
allow-ext-traffic-local-endpoints.md
allow-insecure-backend-proxy.md
any-volume-data-source.md
api-list-chunking.md
api-priority-and-fairness.md
api-response-compression.md
api-self-subject-review.md
api-server-identity.md
api-server-tracing.md
apparmor.md
attach-volume-limit.md

/lgtm

authors: howieyuen windsonsea


text:
[zh] Sync kubernetes-basics/scale/scale-intro.html

Sync with en version and update some text:
content/zh-cn/docs/tutorials/kubernetes-basics/scale/scale-intro.html

See preview

/approve

authors: tengqm windsonsea


text:
[ja] fix: Update the word "pull request" from Katakana to English

Change List

Update the word "pull request" from Katakana to English

ref. https://kubernetes.io/ja/docs/contribute/localization/#terminology

Kubernetesのリソース名や技術用語などは、原則としてそのままの表記を使用します。

/assign bells17
for approval

/approve

/lgtm

authors: Okabe-Junya bells17 inductor


text:
[zh-cn]sync pod-sidecar-containers.md

content/zh-cn/docs/tutorials/configuration/pod-sidecar-containers.md

/lgtm

/approve

authors: my-git9 tengqm windsonsea


text:
Same problem reported multiple times

see screenshot below - it shows the same problem multiple times - resulting in an exaggerated problem count and confusing UI

this is the admin ClusterRole in my local Docker Desktop Kubernetes instance

source: gharchive/issue

repo: kubeshop/monokle

license: MIT


text:
Chore: upgrade gateway api

Description of your changes

upgrade gateway api #5826

I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Moved to #5829

repo: kubevela/kubevela


text:
Refactor pending changes with live mgiration

📝 Description
Fixing 2 bugs with that:

vms created through IT do not show pending changes
adding hotplug network triggers also the pending changes on the 'default' network. If vms do not have networks, vmi will have one default network. But no pending change should be triggered in this case.

🎥 Demo
Before
No pending changes
After

/retest

/lgtm

authors: metalice upalatucci

repo: kubevirt-ui/kubevirt-plugin


text:
Add initial Context Provider for VM Wizard

📝 Description
Adding a global context provider extension with the following values:
type WizardTemplateContextType = {
  /** the template used for the wizard */
  template?: V1Template;
  /**
   * used to update the context template.
   * @param template V1Template
   */
  updateTemplate?: (template: V1Template) => void;
  /** loading state of the template */
  loaded?: boolean;
  /** error state of the template */
  error?: any;
};

@metalice @vojtechszocs @yaacov plz review

please review @vojtechszocs @metalice @yaacov

/lgtm

/hold

/unhold

I decided to implement session storage only for the current template. The storage is reset after VM creation.
This helps the wizard survive a full page reload.
Also helps us develop the wizard faster as we don't need to fill the customize form each time we update the code.
@metalice @yaacov @vojtechszocs @avivtur
I'm still not sure about processing the template after each change. Processing the template does not give any validation to the VM object. It may be best to just update the template state without processing it (backend call) and build forms with great validation.

It may be best to just update the template state without processing it (backend call) and build forms with great validation.

Our requirements are:
a - no client logic
b - only one source of truth and it is the back-end
requirement a means that we should not implement validation at all (not complicated, anyways)
requirement b means that any validation we do on the UI side is not valid, we will need to validate using the back end each time we want to show the user indication about validity of input (unless it's trivial like missing required field,  integers, positive numbers and names validations)

/lgtm

authors: glekner metalice yaacov


text:
ParaKubeVirtualization API

Is your feature request related to a problem? Please describe:
I have a use-case where an API that allows a KubeVirt VM to discover details about itself could be quite useful. In my case, the KubeVirt VMs can talk directly to the KubeVirt API for things like device hotplug. For that to happen, the guest needs to know its VMI name and the k8s namespace that it's in.
I noticed KubeVirt adds this information as the cloud-init instance-id (where it's in the form vmi-name.namespace -- sudo cloud-init query v1). However, that requires my guest OS to include and support cloud-init. So for guests that can't or won't support cloud-init, I'm not sure there's any programmatic way for the guest to discover this information about itself (without adding some additional automation somewhere in the cluster or the guest or both).
Describe the solution you'd like:
It would be cool if there was a "ParaKubeVirtualization" API, for example my KubeVirt VM could hit like a whoami endpoint, which could return the VMI yaml or a more reduced set of information including the VMI name and namespaces.

@connorkuehl I'm not sure if a generic API is a good idea. What I mean is that we might not want to expose this kind of information to the VM.
Would be acceptable for you to generate a configmap together with the VM specification and use this? This could be something built on top of KubeVirt.
Another way could be that the qemu-guest-agent generate a file with the needed information. However, this approach has the same drawback as cloud-init that you need to install an additional tool inside the VM.

@connorkuehl @alicefr We do support a downwardAPI volume, you can have a look at an example test https://github.com/kubevirt/kubevirt/blob/main/tests/virtiofs/config.go#L232-L265

Thanks! That looks fascinating but I don't think I can depend on every guest OS having a kernel with virtioFS support.

@connorkuehl It works with disk as well.

authors: alicefr connorkuehl xpivarc

repo: kubevirt/kubevirt


text:
Windows VM failed to start that has larger size

KubeVirt version: v0.24.0
Kubernetes version: v1.15.5
OS: Ubuntu 16.04.6 LTS (Xenial Xerus)
Kernel: Linux dab7ece2-01a7-4ac0-ae18-515b4294b3f0 4.15.0-65-generic #74~16.04.1-Ubuntu SMP Wed Sep 18 09:51:44 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

I use software emulation using the configmap, since the hardware doesn't support virtualization as described in: https://kubevirt.io/user-guide/docs/latest/administration/intro.html#virtualization-support
Installed kubevirt with the yaml: https://github.com/kubevirt/kubevirt/releases/download/v0.24.0/kubevirt.yaml
VMI Specification for windows:
https://github.com/kubevirt/kubevirt/blob/master/examples/vmi-windows.yaml
But I am not using PVC instead used containerDisk as below:
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachineInstance
metadata:
  name: winserver2012-vmi
  labels:
    kubevirt.io/vm: qc-kubevirt-vm
spec:
  domain:
    clock:
      timer:
        hpet:
          present: false
        hyperv: {}
        pit:
          tickPolicy: delay
        rtc:
          tickPolicy: catchup
      utc: {}
    cpu:
      cores: 3
    devices:
      disks:
      - name: containerdisk
        disk:
          bus: virtio
      - name: emptydisk
        disk:
          bus: virtio
      - name: virtiocontainerdisk
        cdrom:
          bus: sata
      interfaces:
      - masquerade: {}
        model: e1000
        name: default
    features:
      acpi: {}
      apic: {}
      hyperv:
        relaxed: {}
        spinlocks:
          spinlocks: 8191
        vapic: {}
    firmware:
      uuid: 5d307ca9-b3ef-428c-8861-06e72d69f223
    machine:
      type: q35
    resources:
      requests:
        memory: 3Gi
  networks:
  - name: default
    pod: {}
  terminationGracePeriodSeconds: 0
  nodeSelector:
    kubernetes.io/hostname: 10.0.3.7
  volumes:
    - name: containerdisk
      containerDisk:
        image: myregistry/vms/winserver2012:latest
        imagePullPolicy: IfNotPresent
        imagePullSecret: secret
    - name: virtiocontainerdisk
      containerDisk:
        image: kubevirt/virtio-container-disk
    - name: emptydisk
      emptyDisk:
        capacity: 50Gi

I build the image out of qcow2 as described : https://kubevirt.io/user-guide/docs/latest/creating-virtual-machines/disks-and-volumes.html#containerdisk
What happened:
Since the VM image i build is large 6gb approx, whenever I try to deploy, it shows me an error approx after 10mins (I think it is normal to wait for 10mins or more since it has to pull this 6gb image). But everytime it fails and the error can be seen in the logs below:
Virt-launcher logs:

Virt-handler logs:

And the pod never gets started.
This is first issue i am having for larger images.
So, for the workaround I manually pulled the image on the node and since I have imagePullPolicy: IfNotPresent , it can take the image from the node.
Again the VMI doesn't gets deployed and it failed.
When I see kubectl get vmi, it was showing the status scheduled for a while and finally it failed.
Below is the new log form Virt-launcher.

Please let me know what steps should I follow or did wrong during the process.
Also to let you know, linux VMs work fine for me.

So besides having issue to pull the larger image, I could able to deploy the VMI and is in running state. But is really slow. I also have the virtio drivers in the VMI yaml as described https://kubevirt.io/user-guide/docs/latest/creating-virtual-machines/virtio-win.html#how-to-obtain-virtio-drivers.
Moreover I am also having an issue with VNC disconnection.

Do I need to install anything else or is the drivers that I installed is not correctly done??

Also deploying VMI is not consistent, it worked once and tried again next time shows error

What I see is that there seems to be an issue even before the Domain is defined by libvirt inside the pod. What you see is the timeout which happens after several minutes, if our node-daemon failed to sync with the pod. The sync timeout in the events log also shows this. Our daemon tries to talk with the pod, but the grpc call times out.

Do I need to install anything else or is the drivers that I installed is not correctly done??

You don't need to install anything for VNC. Does it work if the VMI manages to come up? Can you  verify that you don't run in sofware emulation mode? Check the kube-config configmap in the kubevirt namespace. Also if you nesting or double nesting on the host already, it can be extremely slow.

Ah now I see
I use software emulation using the configmap, since the hardware doesn't support virtualization as described in: https://kubevirt.io/user-guide/docs/latest/administration/intro.html#virtualization-support

You can use software emulation for playing with kubevirt, you can also start small VMs (especially small linux guest can still boot in less than a minute). To have a better experience whil playing with kubevirt with windows you need at least kvm with only one level of nesting. The best is bare-metal with kvm.

@rmohr Thank you for the reply.
Now I have enabled nested virtualization in KVM instead of software emulation.
After deploying Windows10 VMI, it shows following error. It was in scheduled status for sometime and failed after sometime.
Virt-handler Logs:
{"component":"virt-handler","hostname":"58f89800-4b71-4588-a5d3-1f53df05913e","level":"info","pos":"virt-handler.go:187","timestamp":"2019-12-25T22:14:01.033138Z"}
{"component":"virt-handler","level":"info","msg":"Starting collector: node name=58f89800-4b71-4588-a5d3-1f53df05913e","pos":"prometheus.go:395","timestamp":"2019-12-25T22:14:02.471021Z"}
{"component":"virt-handler","level":"info","msg":"STARTING informer vmiInformer","pos":"virtinformers.go:203","timestamp":"2019-12-25T22:14:02.471204Z"}
{"component":"virt-handler","level":"info","msg":"STARTING informer configMapInformer","pos":"virtinformers.go:203","timestamp":"2019-12-25T22:14:02.471258Z"}
{"component":"virt-handler","level":"info","msg":"STARTING informer CRDInformer","pos":"virtinformers.go:203","timestamp":"2019-12-25T22:14:02.471291Z"}
{"component":"virt-handler","level":"info","msg":"metrics: max concurrent requests=3","pos":"virt-handler.go:350","timestamp":"2019-12-25T22:14:02.572174Z"}
{"component":"virt-handler","level":"info","msg":"Starting virt-handler controller.","pos":"vm.go:547","timestamp":"2019-12-25T22:14:02.572609Z"}
{"component":"virt-handler","level":"info","msg":"Starting device plugin controller","pos":"device_controller.go:92","timestamp":"2019-12-25T22:14:02.673621Z"}
{"component":"virt-handler","level":"info","msg":"tun device plugin started","pos":"generic_device.go:157","timestamp":"2019-12-25T22:14:02.687618Z"}
{"component":"virt-handler","level":"info","msg":"kvm device plugin started","pos":"generic_device.go:157","timestamp":"2019-12-25T22:14:02.688099Z"}
{"component":"virt-handler","level":"info","msg":"vhost-net device plugin started","pos":"generic_device.go:157","timestamp":"2019-12-25T22:14:02.687700Z"}
{"component":"virt-handler","level":"info","msg":"Processing event qc-kubevirt/windows10-vmi","pos":"vm.go:808","timestamp":"2019-12-25T22:51:25.306287Z"}
{"component":"virt-handler","kind":"","level":"info","msg":"VMI is in phase: Scheduled\n","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:810","timestamp":"2019-12-25T22:51:25.306406Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"Domain does not exist","pos":"vm.go:817","timestamp":"2019-12-25T22:51:25.306440Z"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:943","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:51:45.418011Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"re-enqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vm.go:595","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:51:45.436915Z"}
{"component":"virt-handler","level":"info","msg":"Processing event qc-kubevirt/windows10-vmi","pos":"vm.go:808","timestamp":"2019-12-25T22:51:45.438068Z"}
{"component":"virt-handler","kind":"","level":"info","msg":"VMI is in phase: Scheduled\n","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:810","timestamp":"2019-12-25T22:51:45.438171Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"Domain does not exist","pos":"vm.go:817","timestamp":"2019-12-25T22:51:45.438407Z"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:943","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:52:05.488207Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"re-enqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vm.go:595","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:52:05.488489Z"}
{"component":"virt-handler","level":"info","msg":"Processing event qc-kubevirt/windows10-vmi","pos":"vm.go:808","timestamp":"2019-12-25T22:52:05.488575Z"}
{"component":"virt-handler","kind":"","level":"info","msg":"VMI is in phase: Scheduled\n","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:810","timestamp":"2019-12-25T22:52:05.488609Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"Domain does not exist","pos":"vm.go:817","timestamp":"2019-12-25T22:52:05.488637Z"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:943","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:52:25.553866Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"re-enqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vm.go:595","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:52:25.580845Z"}
{"component":"virt-handler","level":"info","msg":"Processing event qc-kubevirt/windows10-vmi","pos":"vm.go:808","timestamp":"2019-12-25T22:52:25.580985Z"}
{"component":"virt-handler","kind":"","level":"info","msg":"VMI is in phase: Scheduled\n","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:810","timestamp":"2019-12-25T22:52:25.581057Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"Domain does not exist","pos":"vm.go:817","timestamp":"2019-12-25T22:52:25.581095Z"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:943","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:52:45.937167Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","kind":"","level":"error","msg":"Updating the VirtualMachineInstance status failed.","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:950","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","timestamp":"2019-12-25T22:52:45.948345Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"re-enqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vm.go:595","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","timestamp":"2019-12-25T22:52:45.948442Z"}
{"component":"virt-handler","level":"info","msg":"Processing event qc-kubevirt/windows10-vmi","pos":"vm.go:808","timestamp":"2019-12-25T22:52:45.948508Z"}
{"component":"virt-handler","kind":"","level":"info","msg":"VMI is in phase: Scheduled\n","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:810","timestamp":"2019-12-25T22:52:45.948557Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}
{"component":"virt-handler","level":"info","msg":"Domain does not exist","pos":"vm.go:817","timestamp":"2019-12-25T22:52:45.948600Z"}
{"component":"virt-handler","kind":"","level":"error","msg":"Synchronizing the VirtualMachineInstance failed.","name":"windows10-vmi","namespace":"qc-kubevirt","pos":"vm.go:943","reason":"unknown error encountered sending command SyncVMI: rpc error: code = DeadlineExceeded desc = context deadline exceeded","timestamp":"2019-12-25T22:53:08.590672Z","uid":"511ddaba-fe01-47a6-af97-858c044eac4e"}

Virt-controller-logs:
air{"component":"virt-controller","level":"info","msg":"STARTING informer CRDInformer","pos":"virtinformers.go:203","timestamp":"2019-12-25T22:14:01.578885Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer configMapInformer","pos":"virtinformers.go:203","timestamp":"2019-12-25T22:14:01.579009Z"}
{"component":"virt-controller","level":"info","msg":"CDI not detected, DataVolume integration disabled","pos":"application.go:217","timestamp":"2019-12-25T22:14:01.679514Z"}
{"action":"listening","component":"virt-controller","interface":"0.0.0.0","level":"info","port":8443,"pos":"application.go:264","service":"http","timestamp":"2019-12-25T22:14:02.319522Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer vmimInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843193Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer kubeVirtPodInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843372Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer kubeVirtNodeInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843431Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer vmirsInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843458Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer persistentVolumeClaimInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843672Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer vmInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843725Z"}
{"component":"virt-controller","level":"info","msg":"SKIPPING informer configMapInformer","pos":"virtinformers.go:200","service":"http","timestamp":"2019-12-25T22:14:18.843754Z"}
{"component":"virt-controller","level":"info","msg":"SKIPPING informer CRDInformer","pos":"virtinformers.go:200","service":"http","timestamp":"2019-12-25T22:14:18.843776Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer vmiInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843797Z"}
{"component":"virt-controller","level":"info","msg":"STARTING informer fakeDataVolumeInformer","pos":"virtinformers.go:203","service":"http","timestamp":"2019-12-25T22:14:18.843835Z"}
{"component":"virt-controller","level":"info","msg":"STARTING controllers with following threads : node 3, vmi 3, replicaset 3, vm 3, migration 3, evacuation 3, disruptionBudget 3\n","pos":"application.go:300","timestamp":"2019-12-25T22:14:18.843883Z"}
{"component":"virt-controller","level":"info","msg":"Starting evacuation controller.","pos":"evacuation.go:251","service":"http","timestamp":"2019-12-25T22:14:18.843932Z"}
{"component":"virt-controller","level":"info","msg":"Starting disruption budget controller.","pos":"disruptionbudget.go:252","service":"http","timestamp":"2019-12-25T22:14:18.843941Z"}
{"component":"virt-controller","level":"info","msg":"Starting node controller.","pos":"node.go:109","service":"http","timestamp":"2019-12-25T22:14:18.844052Z"}
{"component":"virt-controller","level":"info","msg":"Starting vmi controller.","pos":"vmi.go:173","service":"http","timestamp":"2019-12-25T22:14:18.844107Z"}
{"component":"virt-controller","level":"info","msg":"Starting VirtualMachineInstanceReplicaSet controller.","pos":"replicaset.go:106","service":"http","timestamp":"2019-12-25T22:14:18.844150Z"}
{"component":"virt-controller","level":"info","msg":"Starting VirtualMachine controller.","pos":"vm.go:117","service":"http","timestamp":"2019-12-25T22:14:18.844194Z"}
{"component":"virt-controller","level":"info","msg":"Starting migration controller.","pos":"migration.go:108","service":"http","timestamp":"2019-12-25T22:14:18.844264Z"}
{"component":"virt-controller","level":"info","msg":"reenqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vmi.go:201","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","service":"http","timestamp":"2019-12-25T22:24:30.542054Z"}
{"component":"virt-controller","level":"info","msg":"reenqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vmi.go:201","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","service":"http","timestamp":"2019-12-25T22:24:30.584408Z"}
{"component":"virt-controller","level":"info","msg":"reenqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vmi.go:201","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","service":"http","timestamp":"2019-12-25T22:25:42.699640Z"}
{"component":"virt-controller","level":"info","msg":"reenqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vmi.go:201","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","service":"http","timestamp":"2019-12-25T22:51:20.344492Z"}
{"component":"virt-controller","level":"info","msg":"reenqueuing VirtualMachineInstance qc-kubevirt/windows10-vmi","pos":"vmi.go:201","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"windows10-vmi\": the object has been modified; please apply your changes to the latest version and try again","service":"http","timestamp":"2019-12-25T22:51:20.432400Z"}

@surazzarus sorry that I missed to follow up.
Just for completeness: The only way to get reasonable results on AWS for kubevirt is using bare-metal offerings from AWS. GCP also offers instances with nested virtualization enabled. There you would still suffer from some nesting-overhead, but you should get more reasonable results.

@rmohr Thank you for the follow up.
Yes, we figured it out that it only worked on AWS bare-metal and also worked on Azure. But haven't tried on GCP.

/close
Great to hear. Closing the issue. Feel free to reopen if needed.

authors: rmohr surazzarus


text:
Re(de)fine the VM API

The VM API has started as a 1:1 mapping of the libvirt domxml.
Over time it became clear that this is not the right approach as the domxml is host centric, and expose host level details.
The VM API otoh should be cluster centric, and consume/expose cluster resources. If host resources are consumed/exposed, then in a cluster compatible way.
I.e.

instead of referencing a file on a file-system, a PVC should be referenced.
Instead of defining a PCIID or sysfs path to use a device for pass-through, a ResourceClass and host resources should be used.
…

Even if some abstractions need to be introduced, the API granularity should be comparable to the domxml.
There are now some docs which describe parts of the involved APIs:

https://github.com/kubevirt/kubevirt/blob/master/docs/vm-configuration.md
https://github.com/kubevirt/kubevirt/blob/master/docs/config-and-instances.md

The goal of this issue is to have a dedicated effort to go over the VM API and expose all relevant domxml parts, but make sure that they are exposed in a compatible way.
it does not need to be complete, but to be reliable - thus if something is exported, then in the correct way.

/cc @michalskrivanek @mpolednik

/cc @petrkotas, and the former attempts #244 and #331 for inspiration/reference

authors: fabiand michalskrivanek


text:
KubeVirt VM's DisK I/O performance is low compared to VM running in the host

I am measuring the disk I/O performance with KubeVirt VM in K3s cluster using fio. The KubeVirt VM shows only 60% of the performance when compared to the VM in the host. The data is as follows:
KubeVirt VM Disk I/O performance:

VM Disk I/O performance in host:

I was under the impression that KubeVirt VM provides at least 90% of normal VM's disk I/O performance.  May I know what is impacting the disk performance within the Kube VM
How to reproduce it (as minimally and precisely as possible):
I used the following commands to measure the disk I/O performance:
fio --minimal --name=seqwrite --time_based --runtime=300 --bs=16k --direct=1 --iodepth=64 --filesize=1M --numjobs=1 --threads1 --group_reporting --ioengine=libaio --rw=write --directory=./.
fio --minimal --name=seqread --time_based --runtime=300 --bs=16k --direct=1 --iodepth=64 --filesize=1M --numjobs=1 --threads= --group_reporting --ioengine=libaio --rw=read --directory=./.
fio --minimal --name=randread --time_based --runtime=300 --bs=16k --direct=1 --iodepth=64 --filesize=1M --numjobs=1 --threads1 --group_reporting --ioengine=libaio --rw=randread --file_service_type=random --directory=./.
fio --minimal --name=rndrw --time_based --runtime=300 --bs=16k --direct=1 --iodepth=64 --filesize=1M --numjobs=1 --threads=1 --group_reporting --ioengine=libaio --rw=randrw:16 --rwmixwrite=40 --file_service_type=random --directory=./.
fio --minimal --name=randwrite --time_based --runtime=300 --bs=16k --direct=1 --iodepth=64 --filesize=10M --numjobs=1 --threads=1 --group_reporting --ioengine=libaio --rw=randwrite:8 --file_service_type=random --directory=./.
Anything else we need to know?:
Followed the link to install KubeVirt in K3s: https://kubevirt.io/2019/KubeVirt_k8s_crio_from_scratch_installing_KubeVirt.html
This link to import the VMI: https://kubevirt.io/labs/kubernetes/lab2.html
Environment:

KubeVirt version (use virtctl version): '
[root@node0 ~]# ./virtctl version
Client Version: version.Info{GitVersion:"v0.32.0", GitCommit:"44d3011eb09b1488d181439dd0bf54f58ebb148b", GitTreeState:"clean", BuildDate:"2020-08-11T19:31:18Z", GoVersion:"go1.12.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"{gitVersion}", GitCommit:"{gitCommit}", GitTreeState:"{gitTreeState}", BuildDate:"{buildDate}", GoVersion:"go1.12.8", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes version (use kubectl version):
[root@node0 ~]# kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2+k3s1", GitCommit:"cdab19b09a84389ffbf57bebd33871c60b1 d6b28", GitTreeState:"clean", BuildDate:"2020-01-27T18:09:26Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2+k3s1", GitCommit:"cdab19b09a84389ffbf57bebd33871c60b1 d6b28", GitTreeState:"clean", BuildDate:"2020-01-27T18:09:26Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}

VM or VMI specifications:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: "fedora"
labels:
app: containerized-data-importer
annotations:
cdi.kubevirt.io/storage.import.endpoint: "https://download.fedoraproject.org/pub/fedora/linux/releases/30/Cloud/x86_64/images/Fedora-Cloud-Base-30-1.2.x86_64.raw.xz"
spec:
accessModes:
ReadWriteOnce
resources:
requests:
storage: 4Gi
storageClassName: hostpath

Cloud provider or hardware configuration: Bare Metal with 12 cores

OS (e.g. from /etc/os-release):
[root@node0 tmp]# cat /etc/os-release
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

Kernel (e.g. uname -a):
[root@node0 tmp]# uname -a
Linux node0 3.10.0-1062.12.1.el7.x86_64 #1 SMP Tue Feb 4 23:02:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Install tools:

Others:

Could you also please provide the domxml of the VM you are running directly on the host?

Also, could you please run the same, but add cpu: 2 to requests:
  resources:
        requests:
          cpu: 2
          memory: 1024M

Apologies for the delayed response. Was running other tests in my setup and couldn't collect these stats. Will do it today. What is the difference between allocating resources -> requests -> cpu: 2 for the pod and allocating cores =2 for the VM.

I ran the performance tests with

resources:
requests:
cpu: 2
memory: 1024M

but the performance is still low as shown below:

The domxml of VM is as follows:
vm1.docx

Could you also please post the domxml of the VM you are running on the host, so I could compare, please?

Attached herewith domxml of the host VM.
hostvm.docx

Correct me if I am wrong, but I was under the impression that in k3s the node is a VM itself. So if you run a KubeVirt VM on a k3s node, then you are running a VM inside a VM, which will impact performance.

@awels The K3s is a physical machine and is not a VM. The system config is as follows:

[root@node1 ~]# lshw -short
H/W path           Device        Class          Description
===========================================================
system          Edge (Default string)
/0                               bus            Default string
/0/0                             memory         64KiB BIOS
/0/3a                            memory         32GiB System Memory
/0/3a/0                          memory         16GiB SODIMM DDR4 Synchronous 2400 MHz (0.
/0/3a/1                          memory         [empty]
/0/3a/2                          memory         16GiB SODIMM DDR4 Synchronous 2400 MHz (0.
/0/3a/3                          memory         [empty]
/0/45                            memory         384KiB L1 cache
/0/46                            memory         1536KiB L2 cache
/0/47                            memory         12MiB L3 cache
/0/48                            processor      Intel(R) Core(TM) i7-8700T CPU @ 2.40GHz
/0/100                           bridge         8th Gen Core Processor Host Bridge/DRAM Re
/0/100/1                         bridge         Xeon E3-1200 v5/E3-1500 v5/6th Gen Core Pr
/0/100/2                         display        UHD Graphics 630 (Desktop)
/0/100/8                         generic        Xeon E3-1200 v5/v6 / E3-1500 v5 / 6th/7th
/0/100/12                        generic        Cannon Lake PCH Thermal Controller
/0/100/14                        bus            Cannon Lake PCH USB 3.1 xHCI Host Controll
/0/100/14/0        usb1          bus            xHCI Host Controller
/0/100/14/1        usb2          bus            xHCI Host Controller
/0/100/14.2                      memory         RAM memory
/0/100/16                        communication  Cannon Lake PCH HECI Controller
/0/100/16.3                      communication  Cannon Lake PCH Active Management Technolo
/0/100/17          scsi1         storage        Cannon Lake PCH SATA AHCI Controller
/0/100/17/0.0.0    /dev/sda      disk           1920GB XA1920LE10063
/0/100/17/0.0.0/1                volume         499MiB Windows FAT volume
/0/100/17/0.0.0/2  /dev/sda2     volume         2047MiB data partition
/0/100/17/0.0.0/3  /dev/sda3     volume         2047KiB BIOS Boot partition
/0/100/17/0.0.0/4  /dev/sda4     volume         1786GiB LVM Physical Volume
/0/100/1b                        bridge         Cannon Lake PCH PCI Express Root Port #17
/0/100/1b/0        enp2s0f0      network        Ethernet Controller 10G X550T
/0/100/1b/0.1      enp2s0f1      network        Ethernet Controller 10G X550T
/0/100/1c                        bridge         Cannon Lake PCH PCI Express Root Port #1
/0/100/1c.3                      bridge         Cannon Lake PCH PCI Express Root Port #4
/0/100/1c.3/0      enp4s0        network        I210 Gigabit Network Connection
/0/100/1c.4                      bridge         Cannon Lake PCH PCI Express Root Port #5
/0/100/1c.4/0      enp5s0        network        I210 Gigabit Network Connection
/0/100/1c.5                      bridge         Cannon Lake PCH PCI Express Root Port #6
/0/100/1c.5/0      enp6s0        network        I210 Gigabit Network Connection
/0/100/1c.6                      bridge         Cannon Lake PCH PCI Express Root Port #7
/0/100/1c.6/0      enp7s0        network        I210 Gigabit Network Connection
/0/100/1c.7                      bridge         Cannon Lake PCH PCI Express Root Port #8
/0/100/1c.7/0      enp8s0        network        I210 Gigabit Network Connection
/0/100/1f                        bridge         Q370 Chipset LPC/eSPI Controller
/0/100/1f.3                      multimedia     Cannon Lake PCH cAVS
/0/100/1f.4                      bus            Cannon Lake PCH SMBus Controller
/0/100/1f.5                      bus            Cannon Lake PCH SPI Controller
/0/100/1f.6        eno1          network        Ethernet Connection (7) I219-LM
/1                               power          To Be Filled By O.E.M.
/2                 cni0          network        Ethernet interface
/3                 vethf9cb5f79  network        Ethernet interface
/4                 vethf3c77754  network        Ethernet interface
/5                 vethd26c3a45  network        Ethernet interface
/6                 veth512db095  network        Ethernet interface
/7                 network1      network        Ethernet interface
/8                 veth56406af8  network        Ethernet interface
/9                 vethfe97f1b5  network        Ethernet interface
/a                 veth1dde9dc9  network        Ethernet interface
/b                 veth2b90e164  network        Ethernet interface
/c                 virbr0-nic    network        Ethernet interface
/d                 virbr0        network        Ethernet interface
/e                 veth8a4299b6  network        Ethernet interface

KubeVirt disk images are initially sparse files.  Is that also the case for your VM?

I used the disk image used in the Host VM on the KubeVirt VM. Even with the same disk image, the performance of KubeVirt VM is low compared with the Host VM

Could this be related to disk cache setting? Ie. if kubevirt defaults to write-through but the vanilla on the host is write-back?

someone can update if some special configuration required to improve the performance ??

The issue is because the VM disk image in the raw format lost its sparseness during the file transfer. Hence, the VM's disk image size has grown leading to poor performance. The performance issue got fixed by using the command "virt-sparsify" on the disk image.

Hi  @avairavan, this is something that you run before you uploading the image ?

authors: avairavan awels mhenriks salanki talcoh2x vladikr


text:
libvmi.NewVirtualMachine: wrap a vmi in a persistent vm

What this PR does / why we need it:
VirtualMachines are the first and formost object that our customers are
interacting with. Our tests create them often. This PR introduces a
libvmi helper function to make it easier and clear to do so.
test/utils's NewRandomVirtualMachine, which had an opaque boolean argument, is replaced by the new libvmi.NewVirtualMachine().
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[x] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[x] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

/approve

authors: AlonaKaplan dankenigsberg


text:
Stop focusing on test_id 4747

This focus was merged accidentally as part of this commit:
220bd65bfcf3102bc8b1daf6a0485f5384853bc1
Release note:

NONE

/test pull-kubevirt-goveralls
/test pull-kubevirt-unit-test

/test pull-kubevirt-goveralls


text:
Testing only: Check that the git action fails if a new file added without running the index generator.

/hold
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

sanity failed after adding a new file without running the index generator :+1:

sanity passed after re-generating the docs/runbooks/README.md file. :+1:

After checking that the github action rejects new runbooks without running the ./automation/generate_pages_index.py script, and approves it after running the script, we can close this PR.

repo: kubevirt/monitoring


text:
New policy: share host PID namespace

Description
By default, containers running in the same Pod have dedicated PID namespaces. That means they cannot see each other processes.
It's however possible to disable this isolation feature inside of a Pod. This is done by setting this value of the pod spec to true:
spec:
  shareProcessNamespace: true

More details here.
The purpose of this policy is to deny the creation of Pods that have this attribute enabled.
Configuration
No configuration value
Note
It's probably faster to implement this policy using Rego

This policy has been released at Artifact hub:  https://artifacthub.io/packages/kubewarden/share-pid-namespace/share-pid-namespace-policy

authors: flavio jvanz

repo: kubewarden/kubewarden-controller


text:
refactor(schematics): add "eslint:recommended" to eslintrc file

should close upon completion #179.

@Naaajii I appreciate the contribution, but there is some more that needs to be done (see the action results) 😉 this code is kinda messy, if you aren't used to it. let me know if you need any help.

@bbortt thanks for reminding me, I didn't finish this off where. I will defi appreciate if you can provide me some heads up against what should we do ahead, I did run it with --fix which only fixed two or three issues, what should go with no-undef & bout no-unused-vars instead of it omitting errors should it be warnings?

I did run it with --fix which only fixed two or three issues

I know, it's a shame.. must do almost everything by handwork. that's why I've never started it.

instead of it omitting errors should it be warnings

that sounds like a good idea - then we would at least be aware of it. and could resolve them one by one.

I have updated the PR!

authors: Naaajii bbortt

repo: kuhnroyal/mat-datetimepicker


text:
Calibration .txt files

Which of the calibration parameters in calib/xxxxx.txt are required for inference?
P0-P3 ???
R0_rect Required
Tr_velo_to_cam Required
Tr_imu_to_velo ???

It looks like P2 parameters are required. I am still confused by why there are parameters implying a stereo setup (e.g., KEY_STEREO_CALIB_P2 in kitti_dataset.py). We run training and inference with input from a single camera and single lidar only. Is this understanding correct?

Yes your are right. KITTI uses two stereo cameras (one monochrome and one RGB stereo camera) so that they have four cameras in total. AVOD only uses the left RGB camera and KEY_STEREO_CALIB_P2 is the projection matrix of that left RGB camera. For inference you need the projection matrix P2, the rectification matrix R0_rect and the transformation matrix Tr_velo_to_cam.

Upon closer inspection, the only calibration parameter in the feed_dict (model input) is:
stereo_calib_p2 = calib_utils.read_calibration(self.calib_dir,
                                                           int(sample_name)).p2

See here: https://github.com/kujason/avod/blob/master/avod/datasets/kitti/kitti_dataset.py#L285-L287
Thus, it doesn't look like R0_rect or Tr_velo_to_cam are used at all. Can you share where you see that R0_rect or Tr_velo_to_cam are used for inference?
Thank you for your time...

Yes your are right. KITTI uses two stereo cameras (one monochrome and one RGB stereo camera) so that they have four cameras in total. AVOD only uses the left RGB camera and KEY_STEREO_CALIB_P2 is the projection matrix of that left RGB camera. For inference you need the projection matrix P2, the rectification matrix R0_rect and the transformation matrix Tr_velo_to_cam.

why not use  the rectification matrix R2_rect instead of  the rectification matrix R0_rect ? beacouse it uses the left RGB camera,   R0_rect instand for the 0 gray camera ' rectification matrix R0_rect

authors: villanuevab walzimmer yinhai86924

repo: kujason/avod


text:
複数ファイル「取り込む」でネームスペースがおかしい

複数ファイル「取り込む」でネームスペースがおかしい
https://nadesi.com/cgi/kaizen3/?m=thread&threadid=46
nadesiko3-wstest、nadesiko3のバージョンを上げたら動かず。ネームスペースもどきが誤って変換されるのが原因っぽい（--compileの出力で確認）。「取り込む」がネストしているのもだめっぽい。
https://twitter.com/weykt/status/1565316790007128064

取り込んだ後、関数定義の中で、関数を呼ぶとおかしくなる？

違った。取り込む文があるだけで、途端におかしくなる問題。
!「./scope_a.nako3」を取り込む

●(Nを)AAAとは
  Nを表示。
ここまで。
3をAAA;

[エラー][文法エラー]scope_test.nako3(9行目): 不完全な文です。数値3、単語『scope_test__AAA』が解決していません。

どうしてだろう。

nako_lexerでwordをfuncに置換する関数の問題。
取り込むがあると、最初に取り込んだ関数のネームスペースが適用されてしまう。

イベント先の実行がエラーになる。
!「https://n3s.nadesi.com/plain/nako3hello.nako3」を取り込む。
挨拶テスト　　//サブ側の関数を呼ぶ
「A」を画面更新時実行　//→[実行時エラー]『画面更新時実行』で関数の取得に失敗しました。

●A
　「A」を表示
ここまで


text:
Notify user that this's on test network

Right now user just open the wallet and got 1,000 Coins, So we should notify that you're currently using test network (no value at all).

[x] Update banner with testnet symbol in README.md.
[ ] Update banner with testnet symbol in the application.

Thanks

authors: suraneti totiz

repo: kulapio/libra-wallet-poc


text:
WIP: [TEST] implement more real-world testing ability

[x] adds test helpers:

[x] expect('name-of-test-case-folder').toBeE2eTestWithExitCode( n )
[x] expect('name-of-test-case-folder').toBeE2eTestWithExitCode( n )
[ ] allow the above to accept optional parameters to test std-out/err
[ ] allow the above to accept an object instead of the test name, to define for example additional packages to be installed

[x] make tests totally isolated (run in a temp folder without having ts-jest as parent)
[x] use a bundled version of ts-jest, as it would be if published, while running e2e tests
[ ] preformence improvments
[ ] move/refactor all exiting integration tests to the new e2e layout

This could even allow us to git clone a minimal repo into the e2e and have it run isolated.

This is a WIP, @kulshekhar, @ahnpnl,  @GeeWee would love your input before continuing (or not) in this direction

Closing this PR, it'll be part of another one

repo: kulshekhar/ts-jest


text:
chore: adds XAction component

Another little PR I had in mind whilst I'm awaiting reviews of others:
Adds an eXtra eXtension to RouterLink in the form of an XAction component which can be used instead of RouterLink (we can eventually take that out of the global scope)
Mainly to paper over the awkward inactive: route.params.inactive ? null : undefined things (I included one example of this here) which really should just be inactive: true | false. But also adds dynamic node choosing based on existence href/to properties and I'm sure there'll be more things we might want to add here in future.

@johncowen same as the other PR - anything we can help with?

Yep defo, feel free to review if you're ok with that. This one is pretty straight forwards codewise I think. The majority of it is converting true/false to null / undefined but instead of doing that in the application code we hide it away in a component.
Separately, there is also code to decide whether to use a <a> or a <button> depending on whether you have passed a href/to or not. If we have a URL/href the element should always be a <a> if we dont' it should always be a <button>. Again we hide this away behind a <XAction /> component so as an application dev I don't need to think about it, or potentially get that wrong.
We do this conversion so we get /url?inactive and /url instead of /url?inactive=true and /url?inactive=false in the browser location bar.
Let me know if there is anything else I can help with
(oh also if its better to rebase these before review lemme know, I usually leave them until during or after review to avoid rebasing everyday as the days go by with these PRs sitting here)

ty! This one needed a rebase, so I'll leave hanging for a little while incase, but then go ahead and merge

authors: johncowen slonka

repo: kumahq/kuma-gui


text:
Styling Fixes - Issues and Navbar

1. Reduce line height and append tags to a new line, 2. Should be smaller text and in separate lines, and 3. Should be in white colour
Adjust spacing (remove extra)

Updated in 8bcf0ceab842a3ec11a1af51154a9ff818d9efdf

repo: kunalkeshan/Shiryoku


text:
[New game]: Circuit Scape

🎮 Game Request
Game logic and basic description
It is a fun and relaxing game.Twist and turn lines to connect into loops,
each lighting up a lamp.Light up all the lines to complete the level.
Similar to this ....

Point down the features
Game points
Calm and minimalist Design
Relaxing Soundtracks
Visual rewards and hint system
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @patelkiran185 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @patelkiran185 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

repo: kunjgit/GameZone


text:
pixel copter added

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #1255

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @S-ishita ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @S-ishita , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

authors: S-ishita kunjgit


text:
Addition of home icon to games

PR Description 📜
Fixes #1620
###Changes:
-As when we click on a game to go back to the homepage ,I have added the home icon .
-By hovering over the home icon we land back to homepage.
-Some games couldn't be loaded in my server so I was not able to make the change.

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸
Without addition of home icon on games

After resolving the issue

@kunjgit Please review my PR.

Thank you soo much for contributing to our repository 💗

Thank you @KanchandeepK ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

How can I check this my system lagging so much 😔@KanchandeepK

@gurjeetsinghvirdee I will try to figure it out .It was working fine in mine.

@gurjeetsinghvirdee I will try to figure it out .It was working fine in mine.

Not working on my system i3 11th gen 😕

Thank you  @KanchandeepK , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

authors: KanchandeepK gurjeetsinghvirdee kunjgit


text:
Ability to specify short hash length

Added option to specify desired length of short hash
Kept default at 7 to avoid breaking changes
Fixes #38, or at least addresses it

thanks; lgtm – will merge and re-release later today

Awesome, thanks 🎉

authors: adamreisnz kurttheviking

repo: kurttheviking/git-rev-sync-js

license: mit

license_source: bigquery


text:
🛑 Community Foundation of Southern Wisconsin is down

In ababdc4, Community Foundation of Southern Wisconsin (https://cfsw.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Community Foundation of Southern Wisconsin is back up in c62de95.

repo: kuznacic/wtf-uptime


text:
Add bower to dev dependencies and do not globally install it anymore

fix #319

Codecov Report

Merging #355 into 2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #355   +/-   ##
=======================================
  Coverage   85.89%   85.89%
=======================================
  Files          38       38
  Lines         723      723
=======================================
  Hits          621      621
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a417f0...cf23730. Read the comment docs.

authors: ballinette codecov-io

repo: kuzzleio/kuzzle-backoffice


text:
Add ZFS storage provider support

Currently when you run
linstor node create node1 xxx.xxx.xxx.xxx

the following warning is shown:
    Unsupported storage providers:
        ZFS: 'cat /sys/module/zfs/version' returned with exit code 1
        ZFS_THIN: 'cat /sys/module/zfs/version' returned with exit code 1

Wouldn't be enough to add /sys/module mount to linstor-satellite.yaml volumes and volumeMounts?

It might be better to mount /sys/module/zfs only.
Also this option should be switchable using chart variables.
Because if there are no ZFS (zfsutils-linux for Ubutnu 18.04) installed - linstor-satellite container won't start.
  Warning  Failed     9s (x3 over 23s)  kubelet, node4     Error: failed to start container "linstor-satellite": Error response from daemon: error while creating mount source path '/sys/module/zfs': mkdir /sys/module/zfs: operation not permitted

It is also necessary to update README.md with ZFS prerequisite and guide how to turn ZFS support on and off.
Because ZFS might be not required in each installation.

Yes, but we're providing zfs-utils package in the common linstor-satellite docker image and /sys/modules path existing in every Linux-system regardless of using zfs on the host itself.
So why not simple use it in common way?
Can you confirm that this change is enough for make zfs working on the Linstor?

I was hoping someone else would test whole ZFS case and add required updates :)
I'd be able to test it next week, so no fast reply should be expected.

authors: it-svit kvaps

repo: kvaps/kube-linstor


text:
'Require user' works incorect.

Im tring to make auth to only one user from all ldap. And it works but with one bug. User should place correct password, but he might enter everything (not empty string) to name input place and he still good. So name variable kind of ignoring. Is it possible to fix? My configs
ldap_server ldap1 {
url ldap://ldap_host:389/dc=example,dc=com?uid?sub?(&(objectClass=posixAccount));
binddn "cn=admin,dc=example,dc=com";
binddn_passwd "password";
group_attribute uid;
group_attribute_is_dn on;
#require valid_user;
#group_attribute uniquemember;
require valid_user "uid=usename,ou=People,dc=example,dc=com";
satisfy all;
}
Aslo  when i replace valid_user with user variable i cant log in and in error logs is empty -_-

require valid_user "uid=usename,ou=People,dc=example,dc=com";

Not sure if this is correct see https://github.com/kvspb/nginx-auth-ldap#require

here i dont see any description about user and valid_user. Can not understand difference. So is it possible to make auth for only one user witch i will configure in nginx conf? But this user still should write his creds in name/password fields.

Aslo when i replace valid_user with user variable i cant log in and in error logs is empty -_-

just noticed this line in your comment.
does valid_user work? instead of 1 user, all users?

Try narrowing your url, i tried on my test box and it worked
    ldap_server ldap_local {
    	url "ldap://localhost/ou=people,dc=datacom,dc=net?uid?sub?(uid=user)";
...
...
	require valid_user;
    }

when i write this way, i can not login at all. and my error log still empty. its kind of ldap plugin can find user but for some reasons dont let him in and for some reasons dont write logs

can you do a successful ldap bind based off of your url using the user/user credentials?
something like:
ldapsearch -xLLL -h ldap_host -p 389 -b dc=example,dc=com "(objectClass=posixAccount)" -D uid=user,bla,bla -w 'userpass`

then try your asdfasdfas test
ldapsearch -xLLL -h ldap_host -p 389 -b dc=example,dc=com "(objectClass=posixAccount)" -D uid=asdasdf,bla,bla -w 'asdfsda'

Also, not sure if you need the group* settings if only auth one user

btw this one work good for me
ldap_server ldap_local {
url "ldap://localhost/ou=people,dc=datacom,dc=net?uid?sub?(uid=user)";
...
...
require valid_user;
}
Thank you.

glad it works
close issue

ye add this one template to ur wiki as example for user users

ldap_server ldap1 {
url ldap://ldap_hostname:389/dc=example,dc=com?uid,mail,cn?sub?(uid=user_name);
binddn "cn=admin,dc=example,dc=com";
binddn_passwd "pass";
require valid_user;
}

authors: Frikitrok davama

repo: kvspb/nginx-auth-ldap


text:
Invalid typings

"itty-router": "3.0.8"

This should be fixed in 3.0.9+, thanks to a fix by @jahands! :)
Please reopen if that's not the case!!

authors: kwhitley polRk

repo: kwhitley/itty-router


text:
ERROR: Cannot install palme==0.0.1 and palme==0.0.2 because these package versions have conflicting dependencies.

When I run "pip install requirements.txt" following the README, an error raises.
(robocat) deeprob@deeprob-MS-7E06:~/RoboCAT$ pip install palme
Collecting palme
Obtaining dependency information for palme from https://files.pythonhosted.org/packages/bf/99/48109229f38547ebe8c93fedb79c33d111c6315eb8f323553f5446856da0/palme-0.0.2-py3-none-any.whl.metadata
Using cached palme-0.0.2-py3-none-any.whl.metadata (799 bytes)
INFO: pip is looking at multiple versions of palme to determine which version is compatible with other requirements. This could take a while.
Obtaining dependency information for palme from https://files.pythonhosted.org/packages/87/08/0a66848a38064ab80704bde445fcb55fabc6c865df0cde60ab9cb0f0aadc/palme-0.0.1-py3-none-any.whl.metadata
Using cached palme-0.0.1-py3-none-any.whl.metadata (799 bytes)
ERROR: Cannot install palme==0.0.1 and palme==0.0.2 because these package versions have conflicting dependencies.
The conflict is caused by:
palme 0.0.2 depends on torchlion-pytorch
palme 0.0.1 depends on torchlion-pytorch
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

So how to solve this problem? @kyegomez

@hexiangdong2020 Hey please excuse me! I did not see this until now, I have updated it since then and it's working now.

repo: kyegomez/RoboCAT


text:
Add configurable ellipsoid

This adds the option for a user to supply an ellipsoid other than WGS84 to encode quantized-mesh tiles. Useful for generating terrain tiles for non-earth objects.

Now using dataclasses! I guess it's a python 3.7+ feature so it's causing the CI to fail on 3.6

I'm not sure if I can push to your branch but I can make a PR into it

I'm not sure if I can push to your branch but I can make a PR into it

I can't make a PR into your branch easily because it's a different repo I think.
I added linting to CI in #33 . Can you merge in master and fix the lint issues?

Now using dataclasses! I guess it's a python 3.7+ feature so it's causing the CI to fail on 3.6

Can you add dataclasses;python_version<'3.7' to the install requires in setup.py?
https://github.com/kylebarron/quantized-mesh-encoder/blob/5396c4f4ee3ccb3cd370057bd656157edb3dddcc/setup.py#L13-L14
That'll install the dataclasses backport for Python 3.6.

Thanks!

authors: kylebarron malaretv

repo: kylebarron/quantized-mesh-encoder


text:
Lexer deadlocks on incorrect template instead of erroring

Scenario:
If a tag is not closed properly
e.g.
{{ something

Expectation:
Error is thrown or processing is finished without result.
What happens:
https://github.com/kylef/Stencil/blob/master/Sources/Lexer.swift#L27 deadlocks
// cc @ilyapuchka

I think this can be fixed by simply adding content = "" here: https://github.com/kylef/Stencil/blob/master/Sources/Lexer.swift#L93

repo: kylef/Stencil


text:
[CMP-710] Update dependencies

Description
Changes proposed in this pull request:

Update Spring boot version
Update PostgreSQL driver version
Update Eclipselink version

Looks good to me ✅

authors: PetarTodorovv dzahariev

repo: kyma-incubator/ord-service


text:
Setup tekton pipeline for nats-manager

Requirements for tekton pipelines
flowchart TD
Start --> Checkout
Checkout --> lint
Checkout --> UT[Unit Test]
Checkout --> BM[Build Module]
lint --> upgrade
UT --> upgrade
BM --> upgrade
lint --> e2e
UT --> e2e
BM --> e2e
lint --> SecScan
UT --> SecScan
BM --> SecScan
e2e --> Release[Metadata update for released artefact]
upgrade --> Release[Metadata update for released artefact]
SecScan --> Release[Metadata update for released artefact]
Release --> End

Common build pipeline steps:

Check out source code
Run unit tests
Lint code
Build module (no need for full fledged module with descriptor, as it will be installed without lifecycle manager)
execute E2E-Test #40
upgrade test
Security scan
Setup Metadata

Additional Information:
https://github.com/kyma-project/test-infra/blob/e1c488d114e663d419099d1297ae82d2102c2593/docs/examples/tekton-demo.yaml#L118

lint, unit test and build can be executed in parallel
upgrade test, e2e test, security scan as well

Tekton is dead for kyma.

repo: kyma-project/nats-manager


text:
Gridsearch should do the 'if file exists' check immediately

It is often the case that users of the gridsearch invoker accidentally put the wrong file location or wrong file name into the config file. Due to the way source gridserach works, is often five minutes before the gridsearch realises that it doesn't have the files that are needed.
This issue would put additional if file exists  checks at the beginning of the gridsearch invoker.

I think this does work better now, so removing until we have a good example.

repo: kymata-atlas/kymata-core


text:
🛑 senoshaidodelasmanos.love is down

In 6c99f8a, senoshaidodelasmanos.love (https://senoshaidodelasmanos.love) was down:

HTTP code: 0
Response time: 0 ms

Resolved: senoshaidodelasmanos.love is back up in d9d9838 after 11 minutes.

repo: kyryl-bogach/upptime


text:
Set build status with travis-ci 'result'

Currently our "build status" is just getting an svg image from our server. We can use the build result from the Travis CI server that we are using: https://docs.travis-ci.com/user/status-images/

Done on 0e8db1c22b00136cf5a0dddb406aaa33518cd999

repo: kytos/kyco


text:
Paradex update: programHash changed

Resolves L2B-4476

hogh

set the severity to 🐗


text:
monitoring for tls certificate expiry

Signed-off-by: a0p0ie5 a0p0ie5@homeoffice.wal-mart.com

This PR is for issue #62


text:
Ctor

closes #2

@rultor merge

@rultor merge

@l3r8yj Oops, I failed. You can see the full log here (spent 12s)
+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 2851749
+ echo '2.0-SNAPSHOT BUILD'
2.0-SNAPSHOT BUILD
+ date
Wed 07 Dec 2022 06:38:01 PM CET
+ uptime
 18:38:01 up 14 days, 16 min,  0 users,  load average: 6.11, 6.04, 6.01
+ cat
.rultor.yml in yegor256/home doesn't allow l3r8yJ/gitnotifier to use its assets (there are 121 friends), see http://doc.rultor.com/reference.html#assets
+ exit -1
'cid' file is absent, most probably the Docker container wasn't started correctly

@rultor merge


text:
Fixed headers (h1, h2, h3, h4, h5, h6) in wysiwyg editor

Browser type detection was flawed. As all modern browsers that I have support formatBlock already the check was deleted.

Thanks @servy. Merged to master

authors: max-dev servy

repo: la-team/light-admin


text:
zerubabel: Welcome to javascript, 3 weeks

Learning Objectives
Priorities: 🥚, 🐣, 🐥, 🐔 (click to learn more)

There is a lot to learn in this repository. If you can't master all the material
at once, that's expected! Anything you don't master now will always be waiting
for you to review when you need it. These 4 emoji's will help you prioritize
your study time and to measure your progress:

🥚: Understanding this material is required, it covers the base skills you'll
need for this module and the next. You do not need to finish all of them but
should feel comfortable that you could do them with enough time.
🐣: You have started all of these exercises and feel you could complete them
all if you just had more time. It may not be easy for you but with effort you
can make it through.
🐥: You have studied the examples and started some exercises if you had time.
You should have a big-picture understanding of these concepts/skills, but may
not be confident completing the exercises.
🐔: These concepts or skills are not necessary but are related to this module.
If you are finished with 🥚, 🐣 and 🐥 you can use the 🐔 exercises to push
yourself without getting distracted from the module's main objectives.

1. What is Programming
What is a program? What is a programming language? How do programs and people
fit together?

[x] 🥚 Data in, Data Out: You understand that computer programs are used
to transform data, and can explain a JS program from this module in terms
of the data that goes in and the data that comes out.
🥚 Three Audiences: You can explain how a single file of code is used to
communicate with 3 different audiences:

[x] Developers: You can explain how code formatting, comments, logs and
variable names make it easier (or harder!) for a developer to understand
a program.
[x] Computers: You can explain how a computer follows your instructions
to store, read and modify data in program memory.
[x] Users: You can explain how the computer creates a dynamic user
experience by following different executions paths depending on user
input.

[x] 🥚 Tracing Variables: You can complete a trace table for a program
that uses only variables, and can check your work using the "trace"
button.
🥚 JavaScript Syntax: Given a program, you can identify these parts of
JavaScript syntax:

[x] Primitives
[x] Operators
[x] Identifiers
[x] Keywords
[x] Checks
[x] Blocks
[x] Function Calls

[ ] 🥚 Pseudo Code: You can explain what pseudo code is, how it's used and
why it's helpful.
[ ] 🥚 Program Goals: You understand that a full JavaScript program can be
explained as a series of smaller goals, and can write names for the goals
in a simple working program.
🐣 Program Analysis: You can study a simple working program and identify:

[ ] The program's behavior (data in, data out)
[ ] The program's goals
[ ] The program's syntax and language features
[ ] Which parts of the source code are for which audience (users, devs,
computers)

[ ] 🐥 Same Behavior, Different Code: You can study simple programs with
the same behavior (data in, data out) but different source code and
explain how the differences matter for each audience.

2. Just Enough JavaScript
Go in depth on JavaScript you need to know for writing interactive text-based
programs in the browser. Along the way you will learn how each language feature
works in small programs.

🥚 Listening and Reading: You can read code out loud, and understand your
classmates when they read code to you. You don't need to understand how a
program works to master these learning objectives!

[ ] Listening You can exactly re-write a program that a classmate has
read
[ ] Reading You can read a program out loud and guide your classmates to
re-write exactly the same code without them seeing the program. Every
indentation, semi-colon, comment and spelling in their program must be
identical to yours.

🥚 Static vs. Dynamic Analysis: You can explain and use these two ways of
studying a program, each can help you understand different aspects of your
code. To help understand this concept, the options panel in Study Lenses is
organized into static and dynamic study options:

[ ] Static: Studying the text in a code file without running it. Some
static study methods are creating a flowchart, analyzing variables,
filling out a trace table, and drawing on code.
[ ] Dynamic: Running code and studying the computer's behavior. Some
dynamic study methods are running code and reading console logs, using
the trace button, and stepping through in the debugger or JS Tutor.

[x] 🥚 Tracing Execution: You can complete a "steps" trace table for all
JS language features in Just Enough JavaScript, and can correct your table
using console output from the "trace" button.
[x] 🥚 Analyzing Variables: You can list all the variables in a program,
and answer these 5 questions for each variable:

Where is the variable declared?
What is the variable's scope?
Is the variable initialized with a value?
How many times is its value used (read) in the program?
How many times is the variable assigned a new value?
What types are assigned to this variable during the program's execution?

[ ] 🥚 Completing Programs: You can successfully fill in blanks for a
program when the missing words are provided, including distractors.
[ ] 🐣 Translating Pseudo Code: Given a program written in Pseudo Code,
you can translate it to working JavaScript.
[ ] 🐣 Comparing Programs: You can compare two programs with similar code
and explain if they have the same behavior or not. If they do not, you can
explain how they behave differently and why.
[ ] 🐥 Constructing Programs: You can reconstruct a program's lines and
indentation, successfully ignoring distractor lines.
[ ] 🐥 Linting: You can find and fix simple linting errors in JavaScript
programs.
[ ] 🐔 Writing Programs: You can write small programs that log specific
values, or pass specific test cases.

3. Understanding Programs
Learn how to understand a larger programs by finding connections between the
details and the big picture. By the end of this chapter you will know how to
read a new program and do a simple code review.

[ ] 🥚 Stepping Through: You can pause a script in a your browser's
debugger, arrange the debugger, collapse extra panels, and step through a
script written with Just Enough JS. At each point in execution you can
make a prediction of the next line before executing, and can check your
prediction using the scopes panel.
[ ] 🥚 Imperative Programming: You can explain what the Imperative
Programming paradigm is, and can explain how you know the programs in
Welcome to JS are Imperative.
[ ] 🥚 Logging: You can tracing specific aspects of a program's execution
and log them to the console.
[x] 🐣 Naming Variables: You can analyze how a variable is used in a
program and give it two names:

Generic: You can give a generic name to a variable based on how it is
used in the program.
Specific: You can give a specific name to a variable based on how it's
used and the program's domain (the program's specific data and use-case).

[ ] 🐣 Describing Programs: You can read a program and describe it with
comments using to the methodology from /describing-programs:

Zoom Out
Zoom In
Find Connections
Describe Goals

[ ] 🐥 Code Review: Given a working program you can review the code for
clarity, correctness and style.

I Need Help With:
nothing, thank you
What went well?

variables
commenting and logging
JS Syntax

What went less well?
it's a little more than I expected and it takes time to understand what you doing even while your watching videos.
Sunday Prep Work
i will finish just enough syntax today then i'm trying to finish what is programing, I was working a lot this week so i wasn't active enough.

and it takes time to understand what you doing even while your watching videos.

could we make the videos more helpful, or provide something else as well?

no no thank you it's just my problem I take some time to understand things that's why, thank you.

I Need Help With
What went well?

devtools debugger
writing and reviewing
[computers and developers
just enough javascript 1-9

What went less well?
Sunday Prep Work

I Need Help With
What went well?

debugging!
last week's exercise but the second one was a little hard.
trying to finish just-enough-javascript until tomorrow.
finished UX/UI review.
coding our website with @alexanderism55 so we can't forget HTML & CSS.

What went less well?
Sunday Prep Work

coding our website with @alexanderism55 so we can't forget HTML & CSS.

💪


text:
The page should have fixed padding

What happened?
At the moment, if we reduce the height of the page, it also shrinks the padding at the bottom.
You can essentially obscure the logs at the bottom with the footer if the height is small enough.

This is probably due to the percentage-based heights we set in App.tsx.
Errors & Logs
No response
App Version
v1.0.0-alpha.37
Web Browser
All

resolved by #67

authors: josephlabeleven sohrab-

repo: labeleven-dev/bettercallsol


text:
【Auto-build】kubernetes

Usage:
   /imagebuild_k8s

Example:
  /imagebuild_k8s

/imagebuild_k8s_part4

/imagebuild_k8s

repo: labring/cluster-image


text:
virtual channel function

function added to add_virtual_channel() should be able to accept at least *args and **kwargs.

Implemented

authors: TKosir gasperkrivic

repo: ladisk/LDAQ


text:
message:Connection to broker closed.

Error :Connection to broker closed.
  onMessageReceive = (msg) => {
    console.log(`onMessage:${msg}`)
  }
  sendMessage = (billNo) => {
    let qryParams = {
      "yztIdCode": "111",
      "inwarehouseNo": billNo//入库单号
    };
    this.clientRef.sendMessage("/action/collectConfirmPda", JSON.stringify(qryParams));
  }

  onConnect() {
    this.sendMessage(this.props.navigation.state.params.billNo);
    this.setState({ clientConnected: true });
  }
  onDisconnect() {
    this.setState({ clientConnected: false });
  }
  render() {
    const billNo = this.props.navigation.state.params.billNo;
    const wsUrl = 'http://192.168.16.144:18004/websocket/wms-stockInfo-endpoint';
    const customHeaders = {
      "Authorization": `Bearer ${getTokenCache()}`
    };
    return (
      <View style={{ flex: 1 }}>
        <ScanCodeDetails
          dataList={this.plainList}
          title={'入库单'}
          currentId={this.props.navigation.state.params.billNo}
          changeVisible={this.props.changeVisible}
          submit={this.props.submit}
          navigation={this.props.navigation}
          getDataList={this.props.getDataList}
        />
        <SockJsClient url={wsUrl}
          topics={[`/topic/collectConfirmPda${billNo}`]}
          headers={customHeaders}
          onConnect={() => { this.onConnect() }}
          onDisconnect={() => { this.onDisconnect() }}
          onMessage={this.onMessageReceive} ref={(client) => { this.clientRef = client }} debug={true} />
      </View>
    );
  }

@giscafer The log suggest that the ERROR frame is sent from server side. Please check server logs

@lahsivjar but my ng web application doesn't  cause this issue by using the ng2-stompjs under the same websocket server。
when i use react-stomp in react native app cause this issue, i have no idea deal with this，server logs is seems normal

I see. Can you share the network logs?

open chrome dev tools -> network tab
reload your page
under network tab locate the ws tab and find your ws connection
share the frames view

Can you confirm the same behaviour in some other browsers other than chrome?

@lahsivjar i want to know how to set the network ws tab can see the logs in react native。i only can see http request in  xhr tab logs

when the view rerender , the component SockJsClient will rerender lead to  reconnect websock?

did someone solve this issue?

authors: giscafer lahsivjar piyushkathayat

repo: lahsivjar/react-stomp


text:
🛑 静态主页（Static） is down

In 4ab2ac3, 静态主页（Static） (https://lakejason0.ml) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 静态主页（Static） is back up in 1426170.


text:
fix(levm): change gas type from U256 to u64

Motivation
The execution client uses u64 for measuring gas, while LEVM uses U256. This PR makes LEVM also use u64 for gas
Description

Closes #https://github.com/lambdaclass/ethrex/issues/1499

We'll see when it finishes running, but in theory all the uses of gas have been changed to u64.
The files that relate to parsing the tests and running the benchmarks remain in U256, simply to maintain how the parsing works. Those values are cast to u64 when the tests run.

PS: Note to reviewers
I used the "VeryLargeNumber" when a function couldn't cast a value from U256 u64. Should I return a different error?
What error should it be?

I left some suggestions. If possible re-review the PR yourself and see if you find anything out of place. I think other than the things I mentioned it looks good

Hello Jere, thank you very much for your feedback. I incorporated your suggestions and re-reviewed the PR. Let me know if you find anything else that need correction.
PS: I also found some other places (https://github.com/lambdaclass/ethrex/pull/1528/commits/ef21d78038065fcd1b38b2a31146cc6b7b7c953d) where I had created a variable where there wasn't any before. I rolled back those changes so that is more aligned with the previous style.
LMKWYT!

nice! sorry if I was pretty annoying with the suggestions. good work

Please Jere, no need to apologize! On the contrary, I not only value your diligence, I also admire it!
I have never taken any offense from your comments. Thank you very much for all your dedication!
:blush:

repo: lambdaclass/ethrex


text:
Command Arguments

Would it be possible to add additional arguments so that the app can be controlled from the commandline? I'd like to use your app in combination with ranger (a commandline file manager).
For example open -a /Applications/imageviewer5.app "path-to-file.heic" opens the image in the app but if the application has not been launched the window is very tiny.
PS: thank you for making this, the HEIC display is really fast!

I had a few ideas that would probably not fit into your app. I'll put it on GitHub if you are interested. In any case thank you for the starting point!

Sorry, didn't see this until now.
I'm actually surprised that opening from the command line works at all because I don't remember implementing that, but I guess I got that for free with one of the other methods I implemented :)
Yeah the tiny window thing is annoying and always has been annoying. Everytime I use the app myself I am annoyed by it.
So I went ahead and tried to fix it! Window size is now remembered from last run, so it's better atleast. I also specified some idealWidth and idealHeight flags to be the image dimensions, but that doesn't seem to do anything. I also set the max window size to be your display resolution.
Give it a try: https://github.com/lambdan/imageviewer5/releases/tag/1.3

Looks good! Not sure if you have ever looked at macOS QuickView (launched by space from Finder) - it can display almost everything but for some reason takes forever to load HEIC images. At first I thought you were using a special library to load the images so quickly - I'm still surprised that it's just the standard SwiftUI controls.

Yes I wanted to just QuickView or Preview or whatever its called so I didn't have to do all this, but I absolutely cannot stand how you navigate through images in it. Like if your Finder window is in list view, you navigate by pressing Up and Down. If you have Icons you have to left/right and then down/up. Basically you navigate the Finder window, you don't navigate anything in the QuickView, and I hate that.

authors: laktak lambdan


text:
Add AWS Simple icons

Add AWS Simple icons set :)

@Surgo thanks for the PR! Has this been tested with a Slack instance with no issues? If so, I will merge.

Closing due to inactivity, glad to reopen and merge if tested

@zachfeldman Sorry my late responce!
Its tested and I have already used it

authors: Surgo zachfeldman

repo: lambtron/emojipacks


text:
🛑 vipgifts.net is down

In 9aa70aa, vipgifts.net (https://vipgifts.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: vipgifts.net is back up in a2f25fc after 8 minutes.

repo: lanen/bs-site


text:
🛑 rexingsports.cn is down

In 644691d, rexingsports.cn (https://www.rexingsports.cn) was down:

HTTP code: 567
Response time: 781 ms

Resolved: rexingsports.cn is back up in 7a7ed79 after 42 minutes.


text:
🛑 rexingsports.cn is down

In caed6f7, rexingsports.cn (https://www.rexingsports.cn) was down:

HTTP code: 567
Response time: 762 ms

Resolved: rexingsports.cn is back up in 4439a6e after 19 minutes.


text:
🛑 rexingsports.cn is down

In b3d550d, rexingsports.cn (https://www.rexingsports.cn) was down:

HTTP code: 567
Response time: 875 ms

Resolved: rexingsports.cn is back up in d868a65.


text:
🛑 rexingsports.cn is down

In c0586bd, rexingsports.cn (https://www.rexingsports.cn) was down:

HTTP code: 567
Response time: 661 ms

Resolved: rexingsports.cn is back up in 0857dc2 after 19 minutes.


text:
🛑 trixmall.com is down

In ac1e99d, trixmall.com (https://www.trixmall.com/) was down:

HTTP code: 567
Response time: 595 ms

Resolved: trixmall.com is back up in 5dc86a1.


text:
🛑 vipgifts.net is down

In 68b117f, vipgifts.net (https://vipgifts.net) was down:

HTTP code: 567
Response time: 668 ms

Resolved: vipgifts.net is back up in e2d6b98 after 19 minutes.


text:
[OpenSearch Vector Search] Add Method for approximate_search_query_match_text_with_boolean_filter

Replace this entire comment with:

Description:
I added a function '_approximate_search_query_match_text_with_boolean_filter' at opensearch_vector_search.py.

Issue:
To improve search performance of OpenSearch vector search, it should be possible to compare the similarity with the vector embedding as well as with the text field. I'm developing Chatbot with Langchain based on Opensearch index as a vectorDB now and it helped to improve the search performance.

Dependencies: any dependencies required for this change -> NO,

Tag maintainer: for a quicker response, tag the relevant maintainer (see below),

Twitter handle: we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out!

Please make sure your PR is passing linting and testing before submitting. Run make format, make lint and make test to check this locally.
See contribution guidelines for more information on how to write/run tests, lint, etc:
https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md
If you're adding a new integration, please include:

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/extras directory.

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17.

@hwchase17
Hi Team,
I'm working on it recently and I need to improve the query to OpenSearch asap, I hope you check the commit soon :)
Thanks,
Minjee Woo (freemjstudio)

cc @naveentatikonda

@baskaryan
I fixed the bug in L625. Could you take a look at it?
Thanks,
Minjee Woo

authors: baskaryan freemjstudio

repo: langchain-ai/langchain


text:
community[feat]: Adds LLMLingua as a document compressor

Description: This PR adds support for using the LLMLingua project  especially the LongLLMLingua (Enhancing Large Language Model Inference via Prompt Compression) as a document compressor / transformer.
The LLMLingua project is an interesting project that can greatly improve RAG system by compressing prompts and contexts while keeping their semantic relevance.
Issue: https://github.com/microsoft/LLMLingua/issues/31
Dependencies: llmlingua
@baskaryan

@hwchase17 The CI check "extended_tests" fails because the package llmlingua is not added to the dependencies list. Should this be added? Attempting to add it via "poetry add llmlingua" gets stucked on resolving dependencies. It seems there are some conflicts with some of the boto3 dependencies

ping @hwchase17 @baskaryan


text:
community: added support for handling parsing errors in SQL agent

Added error handling for LLM output parsing errors
This commit introduces the ability to handle errors when the output from the Language Learning Model (LLM) is not in the expected format for the output parser. Developers can now use the handle_parsing_errors parameter when creating an SQL agent to enable this feature. This parameter is optional and defaults to False to ensure backward compatibility with existing functionality.
Example usage:
agent_executor = AgentExecutor(agent=agent, tools=tools, verbose=True, handle_parsing_errors=True)
Dependencies: None

@efriis Hi Erick, can you please validate this? It's a simple and quite useful change.
SQL Agent cannot handle parsing errors as of now. This simple change allows developers to pass the handle_parsing_errors param to handle such errors.

this parameter can already be specified in agent_executor_kwargs (unless I misunderstanding) and adding here would be backwards incompatible for anyone currently passing in that way, so going to keep as is for now


text:
community[patch]: Improve import callbacks to make it IDE friendly

declares all as a list of strings (instead of dynamically computing it)
import type definitions when TYPE_CHECKING is true

@eyurtsev This solves my issue too in VSCode but a new one appeared. Pylint complains about the imports not being exported despite the __all__ variable.

My guess is that the linter doesn't compute the list from the dict. My fix to that is to put back the original list.
__all__ = [
    "AimCallbackHandler",
    "ArgillaCallbackHandler",
    "ArizeCallbackHandler",
    "PromptLayerCallbackHandler",
    "ArthurCallbackHandler",
    "ClearMLCallbackHandler",
    "CometCallbackHandler",
    "ContextCallbackHandler",
    "HumanApprovalCallbackHandler",
    "InfinoCallbackHandler",
    "MlflowCallbackHandler",
    "LLMonitorCallbackHandler",
    "OpenAICallbackHandler",
    "LLMThoughtLabeler",
    "StreamlitCallbackHandler",
    "WandbCallbackHandler",
    "WhyLabsCallbackHandler",
    "get_openai_callback",
    "wandb_tracing_enabled",
    "FlyteCallbackHandler",
    "SageMakerCallbackHandler",
    "LabelStudioCallbackHandler",
    "TrubricsCallbackHandler",
    "FiddlerCallbackHandler",
]

@pierreveron got it -- it sounds like we should not compute the all list dynamically and instead rely on unit tests to catch any drift

@pierreveron made required changes, we'll merge and please confirm that it all works as expected

@pierreveron made required changes, we'll merge and please confirm that it all works as expected

Super cool thanks @eyurtsev. I think you should do the same for all modules in langchain_community that were changed by the PR. There can be cascading errors, for example when importing from langchain.memory import ChatMessageHistory as ChatMessageHistory export is not caught by the linter in libs/community/langchain_community/chat_message_histories/__init__.py

@eyurtsev I'll refactor other langchain_community modules whenever applicable.

authors: eyurtsev leo-gan pierreveron


text:
community: support advanced text extraction options for pdf documents

Description:

Updated constructors in PyPDFParser and PyPDFLoader to handle extraction_mode and additional kwargs, aligning with the capabilities of PageObject.extract_text() from pypdf.

Added test_pypdf_loader_with_layout along with a corresponding example text file to validate layout extraction from PDFs.

Issue: fixes #19735
Dependencies: This change requires updating the pypdf dependency from version 3.4.0 to at least 4.0.0.
Additional changes include the addition of a new test test_pypdf_loader_with_layout and an example text file to ensure the functionality of layout extraction from PDFs aligns with the new capabilities.

Hello Guys!
@ccurme @baskaryan @efriis @maximeperrindev
Hope you're all well!
Just to know that if there is something I can do to help as I saw an activity on last week

is there a way we can make this backwards compatible with version 3 of pypdf?

@efriis do you think something like this can be ok?
if pypdf.__version__.startswith('4'):
    page_content = page.extract_text(
        extraction_mode=self.extraction_mode, **self.extraction_kwargs
    )
else:
    page_content = page.extract_text()

Could we reverse it to if pypdf.__version.startswith('3.'): do the old thing, otherwise new? Base assumption being future releases are additive
Will mark this a draft, feel free to mark ready to review when you want me to take a look!

Hi @efriis,
I just added the changes. You can check it. I mentionned you on it.
Feel free to tell me if there is something to change or do better.
Thanks!

authors: bricefotzo efriis


text:
docs: YouTube page update

Greatly simplified to get a cleaner look.
Only the YouTube pages with 40K+ views.

@baskaryan Thanks, Bagatur!


text:
community: VectorStore integration for SAP HANA Cloud Vector Engine

Description:
This PR adds a VectorStore integration for SAP HANA Cloud Vector Engine, which is an upcoming feature in the SAP HANA Cloud database (https://blogs.sap.com/2023/11/02/sap-hana-clouds-vector-engine-announcement/).
This typescript version is as close as Python version integration (https://github.com/langchain-ai/langchain/pull/16514)

Issue: N/A

Dependencies: SAP HANA Node.js Client

Twitter handle: @sapopensource

Implementation of the integration:
libs/langchain-community/src/vectorstores/hanavector.ts
Unit tests:
libs/langchain-community/src/vectorstores/tests/hanavector.test.ts
Integration tests:
libs/langchain-community/src/vectorstores/tests/hanavector.int.test.ts
Examples:
examples/src/indexes/vector_stores/hana_vector/
Documentation:
docs/core_docs/docs/integrations/vectorstores/hanavector.mdx
Integration tests and examples were run successfully.
Access credentials for the execution of the integration tests can be provided to the maintainers.

Hi @cinqisap, thanks so much for this!
The SAP client dep is quite large (186MB!) and I'm worried it'll slow down our CI. I see that it's only being used as a type in the connector itself - is there any lighter variant?

Yeah, it adds a full minute to our yarn install.
If there is no lighter version, what we can do is split it out into a partner package that is versioned separately, and skip building it in CI.
The other option I see is to inline the examples/ in the docs, comment out the test cases, and define some other interface for hanaClient.Connection or even type it as any so that the client isn't actually a direct dep.
What do you prefer?

hi, @jacoblee93, thanks for the suggestion!
I pushed a new commit to address this issue. My solution is to add support for another HANA Node.js driver hdb which is only about 1MB and thus remove the large @sap/hana-client as a direct dev package.  Since the hdb did not originally support typescript, I added another declaration file to avoid errors during building time.
Now the client type is defined as any and can represent both drivers.
Looking forward to hearing more if the current solution is not as desired.

Yes that's a great solution! Thank you, I'll look shortly.

Ah, sorry missed the part about the declaration. Will fix.

Thank you!

repo: langchain-ai/langchainjs


text:
js[patch]: make evaluate,traceable importable from top-level

match python sdk
make our most-used classes and functions more easily accessible

@dqbd , any concerns around import paths here?

pretty sure that moving evaluate and traceable into root will cause bundling issues for browser environments

Gotcha ya then maybe we can't land

authors: baskaryan dqbd hinthornw

repo: langchain-ai/langsmith-sdk


text:
BLD: run cython at install time

This will avoid future issues with older versions of cython generate c code that is incompatible with newer versions of CPython.
The c file that was checked in is incompatible with CPython3.12

Thank you!

repo: lanl/pyxDamerauLevenshtein


text:
Use theme color for install plugin button

The backgound color for the install plugin buttons is currently hard-coded to rgb(80, 161, 79) but it should probably use a theme color.

before
after

I just used the editor caret color for now but it would probably make sense to add some sort of primary button theme color.

I'd prefer to leave it hardcoded green for install/installed, yellow for disabled for now
just like remote button in titlebar

yellow for disabled for now

Does it become yellow when the plugin is disabled for you because for me it just stays green.

TIL github displays the actual color here, really cool: rgb(80, 161, 79) #123456
I would prefer creating generic theme colors/color names (like BUTTON_AVAILABLE, etc. [come up with better names than my sleepy brain, please]) instead, so we can allow theme authors to choose non-clashing colors, but not changing the colors at this moment.

Should I create a new issue where we can think about these general theme variables?

I don't think there is need for that, you can just prefix action/status with LAPCE_EXTENSION_BUTTON_*

authors: CreatorSiSo bugadani panekj

repo: lapce/lapce


text:
Update README.md

Changes
When specifying the package version, unexpected problems may occur, so it has been removed and composer has been left to decide.
Breaking changes
N/A

Could you list one?

Good evening,
Sure here I list one
There may be a conflict in the versions of the project dependencies. Example, the package nunomaduro/larastan version 2.1.0 (which is the one you choose) requires the version of illuminate/console in the range of ^9; but some other package in the project that requires a different version of illuminate/console may conflict. To resolve this conflict you would have to update the dependencies, adjust the dependency versions manually, or revise the project dependencies.
All this is solved by just letting composer install the version of nunomaduro/larastan that suits you best.

Hi,
I don't think this is needed. Thank you.

authors: canvural ymigval

repo: larastan/larastan


text:
How to perform simple attribute transformations before an event?

Previously, it was possible to use Adapter hooks:
https://laravel-json-api.readthedocs.io/en/latest/basics/adapters/#adapter-hooks
I know there are a bunch of hooks, but I couldn't find any examples for this in the documentation.
What would be the recommendation now to perform simple 1-2 line modifications on attributes?
I basically need to get the value of a field, do a single action, then modify the value of the field with a new value.
I know I can use Eloquent events for that, but is that the recommended way? Access to JSONAPI's original fields is not as easy this way.

How to modify attributes is described here:
https://laraveljsonapi.io/docs/1.0/schemas/attributes.html#attribute-hydration

authors: fidelix lindyhopchris

repo: laravel-json-api/laravel