UI fixes

app.py

@@ -294,158 +294,159 @@ def generate_motion_single(
         return None, error_msg
 
 
-def generate_motion_batch(
-    text_file_content: str,
-    cfg_scale: float,
-    use_auto_length: bool,
-    gpu_id: int,
-    seed: int
-) -> Tuple[List[Optional[str]], str]:
-    """
-    Generate motions from a batch of text prompts.
-    Returns (list_of_video_paths, status_message)
-    """
-    # Parse text file
-    text_prompts = []
-    for line in text_file_content.strip().split('\n'):
-        line = line.strip()
-        if not line:
-            continue
-        if '#' in line:
-            parts = line.split('#')
-            text = parts[0].strip()
-            length_str = parts[1].strip() if len(parts) > 1 else 'NA'
-        else:
-            text = line
-            length_str = 'NA'
-        
-        if length_str.upper() == 'NA':
-            motion_length = None if use_auto_length else 120
-        else:
-            try:
-                motion_length = int(length_str)
-                motion_length = ((motion_length + 2) // 4) * 4
-            except:
-                motion_length = None if use_auto_length else 120
-        
-        text_prompts.append((text, motion_length))
-    
-    if not text_prompts:
-        return [], "No valid prompts found in file"
-    
-    status_msg = f"Processing {len(text_prompts)} prompts...\n"
-    video_paths = []
-    
-    # Create a persistent directory for batch videos (not temp, so Gradio can access them)
-    # Use a directory that Gradio can serve from
-    batch_output_dir = pjoin('generation', 'batch_temp')
-    os.makedirs(batch_output_dir, exist_ok=True)
-    
-    # Also ensure the parent directory exists
-    os.makedirs('generation', exist_ok=True)
-    
-    for idx, (text, motion_length) in enumerate(text_prompts):
-        try:
-            video_path, gen_msg = generate_motion_single(
-                text, motion_length, cfg_scale, use_auto_length, gpu_id, seed + idx
-            )
-            
-            # If video was created, copy it to persistent location for batch gallery
-            if video_path and os.path.exists(video_path):
-                # Create a unique filename for this batch item
-                # Get file extension from original path
-                file_ext = os.path.splitext(video_path)[1] or '.mp4'
-                batch_video_path = pjoin(batch_output_dir, f'motion_{idx:04d}{file_ext}')
-                
-                # Copy file to persistent location
-                import shutil
-                try:
-                    shutil.copy2(video_path, batch_video_path)
-                    
-                    # Verify the copied file exists
-                    if os.path.exists(batch_video_path):
-                        # Use relative path for Gradio (works better in HuggingFace Spaces)
-                        # Gradio can serve files from relative paths within the app directory
-                        video_paths.append(batch_video_path)
-                        file_size = os.path.getsize(batch_video_path)
-                        status_msg += f"\n[{idx+1}/{len(text_prompts)}] ✓ {text[:50]}... - Video saved ({file_size/1024:.1f} KB)"
-                    else:
-                        status_msg += f"\n[{idx+1}/{len(text_prompts)}] ⚠ {text[:50]}... - Video copy failed (file not found after copy)"
-                        video_paths.append(None)
-                except Exception as copy_error:
-                    status_msg += f"\n[{idx+1}/{len(text_prompts)}] ⚠ {text[:50]}... - Copy error: {str(copy_error)}"
-                    video_paths.append(None)
-            else:
-                status_msg += f"\n[{idx+1}/{len(text_prompts)}] ❌ {text[:50]}... - Generation failed (no video path returned)"
-                video_paths.append(None)
-                
-        except Exception as e:
-            status_msg += f"\n[{idx+1}/{len(text_prompts)}] ❌ Error: {str(e)}"
-            import traceback
-            status_msg += f"\n   Traceback: {traceback.format_exc()[:200]}"
-            video_paths.append(None)
-    
-    # Filter out None values and verify files exist - Gradio Gallery needs valid paths
-    valid_video_paths = []
-    for path in video_paths:
-        if path is not None:
-            # Use relative path (Gradio handles these better in cloud environments)
-            # Verify file exists
-            if os.path.exists(path):
-                # Verify it's a video file
-                if path.lower().endswith(('.mp4', '.gif', '.mov', '.avi')):
-                    # Get file size for debugging
-                    file_size = os.path.getsize(path)
-                    if file_size > 0:  # Ensure file is not empty
-                        valid_video_paths.append(path)  # Keep relative path
-                        status_msg += f"\n  ✓ Verified: {os.path.basename(path)} ({file_size/1024:.1f} KB)"
-                    else:
-                        status_msg += f"\n  ⚠ Empty file: {path}"
-                else:
-                    status_msg += f"\n  ⚠ Skipping non-video file: {path}"
-            else:
-                # Try absolute path as fallback
-                abs_path = os.path.abspath(path)
-                if os.path.exists(abs_path):
-                    valid_video_paths.append(abs_path)
-                    status_msg += f"\n  ✓ Found via absolute path: {abs_path}"
-                else:
-                    status_msg += f"\n  ⚠ File not found (relative: {path}, absolute: {abs_path})"
-    
-    if len(valid_video_paths) == 0:
-        status_msg += "\n\n❌ No videos were successfully generated for the gallery."
-        status_msg += "\n💡 Check the error messages above for each prompt."
-        # Return empty list explicitly
-        return [], status_msg
-    else:
-        status_msg += f"\n\n✅ Successfully generated {len(valid_video_paths)}/{len(text_prompts)} motions."
-        status_msg += f"\n📁 Videos saved in: {batch_output_dir}"
-        status_msg += f"\n📋 Gallery will display {len(valid_video_paths)} video(s)."
-        
-        # Debug: Show first few paths
-        status_msg += f"\n\n🎬 First few video paths:\n"
-        for i, p in enumerate(valid_video_paths[:3]):
-            abs_p = os.path.abspath(p) if not os.path.isabs(p) else p
-            exists = "✓" if os.path.exists(p) else "✗"
-            status_msg += f"  {exists} [{i+1}] {p} (exists: {os.path.exists(p)})\n"
-        if len(valid_video_paths) > 3:
-            status_msg += f"  ... and {len(valid_video_paths) - 3} more\n"
-    
-    # Return list of file paths (Gradio Gallery expects list of strings)
-    # Ensure all paths are valid and accessible
-    final_paths = []
-    for p in valid_video_paths:
-        if os.path.exists(p):
-            # Normalize path (use forward slashes for cross-platform compatibility)
-            normalized_path = p.replace('\\', '/')
-            final_paths.append(normalized_path)
-        else:
-            status_msg += f"\n⚠ Warning: Path not found when returning: {p}"
-    
-    if len(final_paths) != len(valid_video_paths):
-        status_msg += f"\n⚠ Some paths were filtered out. Returning {len(final_paths)}/{len(valid_video_paths)} videos."
-    
-    return final_paths, status_msg
+# Batch generation feature commented out
+# def generate_motion_batch(
+#     text_file_content: str,
+#     cfg_scale: float,
+#     use_auto_length: bool,
+#     gpu_id: int,
+#     seed: int
+# ) -> Tuple[List[Optional[str]], str]:
+#     """
+#     Generate motions from a batch of text prompts.
+#     Returns (list_of_video_paths, status_message)
+#     """
+#     # Parse text file
+#     text_prompts = []
+#     for line in text_file_content.strip().split('\n'):
+#         line = line.strip()
+#         if not line:
+#             continue
+#         if '#' in line:
+#             parts = line.split('#')
+#             text = parts[0].strip()
+#             length_str = parts[1].strip() if len(parts) > 1 else 'NA'
+#         else:
+#             text = line
+#             length_str = 'NA'
+#         
+#         if length_str.upper() == 'NA':
+#             motion_length = None if use_auto_length else 120
+#         else:
+#             try:
+#                 motion_length = int(length_str)
+#                 motion_length = ((motion_length + 2) // 4) * 4
+#             except:
+#                 motion_length = None if use_auto_length else 120
+#         
+#         text_prompts.append((text, motion_length))
+#     
+#     if not text_prompts:
+#         return [], "No valid prompts found in file"
+#     
+#     status_msg = f"Processing {len(text_prompts)} prompts...\n"
+#     video_paths = []
+#     
+#     # Create a persistent directory for batch videos (not temp, so Gradio can access them)
+#     # Use a directory that Gradio can serve from
+#     batch_output_dir = pjoin('generation', 'batch_temp')
+#     os.makedirs(batch_output_dir, exist_ok=True)
+#     
+#     # Also ensure the parent directory exists
+#     os.makedirs('generation', exist_ok=True)
+#     
+#     for idx, (text, motion_length) in enumerate(text_prompts):
+#         try:
+#             video_path, gen_msg = generate_motion_single(
+#                 text, motion_length, cfg_scale, use_auto_length, gpu_id, seed + idx
+#             )
+#             
+#             # If video was created, copy it to persistent location for batch gallery
+#             if video_path and os.path.exists(video_path):
+#                 # Create a unique filename for this batch item
+#                 # Get file extension from original path
+#                 file_ext = os.path.splitext(video_path)[1] or '.mp4'
+#                 batch_video_path = pjoin(batch_output_dir, f'motion_{idx:04d}{file_ext}')
+#                 
+#                 # Copy file to persistent location
+#                 import shutil
+#                 try:
+#                     shutil.copy2(video_path, batch_video_path)
+#                     
+#                     # Verify the copied file exists
+#                     if os.path.exists(batch_video_path):
+#                         # Use relative path for Gradio (works better in HuggingFace Spaces)
+#                         # Gradio can serve files from relative paths within the app directory
+#                         video_paths.append(batch_video_path)
+#                         file_size = os.path.getsize(batch_video_path)
+#                         status_msg += f"\n[{idx+1}/{len(text_prompts)}] ✓ {text[:50]}... - Video saved ({file_size/1024:.1f} KB)"
+#                     else:
+#                         status_msg += f"\n[{idx+1}/{len(text_prompts)}] ⚠ {text[:50]}... - Video copy failed (file not found after copy)"
+#                         video_paths.append(None)
+#                 except Exception as copy_error:
+#                     status_msg += f"\n[{idx+1}/{len(text_prompts)}] ⚠ {text[:50]}... - Copy error: {str(copy_error)}"
+#                     video_paths.append(None)
+#             else:
+#                 status_msg += f"\n[{idx+1}/{len(text_prompts)}] ❌ {text[:50]}... - Generation failed (no video path returned)"
+#                 video_paths.append(None)
+#                 
+#         except Exception as e:
+#             status_msg += f"\n[{idx+1}/{len(text_prompts)}] ❌ Error: {str(e)}"
+#             import traceback
+#             status_msg += f"\n   Traceback: {traceback.format_exc()[:200]}"
+#             video_paths.append(None)
+#     
+#     # Filter out None values and verify files exist - Gradio Gallery needs valid paths
+#     valid_video_paths = []
+#     for path in video_paths:
+#         if path is not None:
+#             # Use relative path (Gradio handles these better in cloud environments)
+#             # Verify file exists
+#             if os.path.exists(path):
+#                 # Verify it's a video file
+#                 if path.lower().endswith(('.mp4', '.gif', '.mov', '.avi')):
+#                     # Get file size for debugging
+#                     file_size = os.path.getsize(path)
+#                     if file_size > 0:  # Ensure file is not empty
+#                         valid_video_paths.append(path)  # Keep relative path
+#                         status_msg += f"\n  ✓ Verified: {os.path.basename(path)} ({file_size/1024:.1f} KB)"
+#                     else:
+#                         status_msg += f"\n  ⚠ Empty file: {path}"
+#                 else:
+#                     status_msg += f"\n  ⚠ Skipping non-video file: {path}"
+#             else:
+#                 # Try absolute path as fallback
+#                 abs_path = os.path.abspath(path)
+#                 if os.path.exists(abs_path):
+#                     valid_video_paths.append(abs_path)
+#                     status_msg += f"\n  ✓ Found via absolute path: {abs_path}"
+#                 else:
+#                     status_msg += f"\n  ⚠ File not found (relative: {path}, absolute: {abs_path})"
+#     
+#     if len(valid_video_paths) == 0:
+#         status_msg += "\n\n❌ No videos were successfully generated for the gallery."
+#         status_msg += "\n💡 Check the error messages above for each prompt."
+#         # Return empty list explicitly
+#         return [], status_msg
+#     else:
+#         status_msg += f"\n\n✅ Successfully generated {len(valid_video_paths)}/{len(text_prompts)} motions."
+#         status_msg += f"\n📁 Videos saved in: {batch_output_dir}"
+#         status_msg += f"\n📋 Gallery will display {len(valid_video_paths)} video(s)."
+#         
+#         # Debug: Show first few paths
+#         status_msg += f"\n\n🎬 First few video paths:\n"
+#         for i, p in enumerate(valid_video_paths[:3]):
+#             abs_p = os.path.abspath(p) if not os.path.isabs(p) else p
+#             exists = "✓" if os.path.exists(p) else "✗"
+#             status_msg += f"  {exists} [{i+1}] {p} (exists: {os.path.exists(p)})\n"
+#         if len(valid_video_paths) > 3:
+#             status_msg += f"  ... and {len(valid_video_paths) - 3} more\n"
+#     
+#     # Return list of file paths (Gradio Gallery expects list of strings)
+#     # Ensure all paths are valid and accessible
+#     final_paths = []
+#     for p in valid_video_paths:
+#         if os.path.exists(p):
+#             # Normalize path (use forward slashes for cross-platform compatibility)
+#             normalized_path = p.replace('\\', '/')
+#             final_paths.append(normalized_path)
+#         else:
+#             status_msg += f"\n⚠ Warning: Path not found when returning: {p}"
+#     
+#     if len(final_paths) != len(valid_video_paths):
+#         status_msg += f"\n⚠ Some paths were filtered out. Returning {len(final_paths)}/{len(valid_video_paths)} videos."
+#     
+#     return final_paths, status_msg
 
 
 # Gradio Interface
@@ -546,65 +547,65 @@ def create_interface():
                     outputs=[video_output, status_output]
                 )
             
-            # Batch Generation Tab
-            with gr.Tab("Batch Generation"):
-                with gr.Row():
-                    with gr.Column(scale=1):
-                        batch_text_input = gr.Textbox(
-                            label="Text Prompts (one per line, format: text#length or text#NA)",
-                            placeholder="A person is running on a treadmill.#120\nSomeone is doing jumping jacks.#NA",
-                            lines=10,
-                            info="Each line: 'text#length' or 'text#NA' for auto-estimate"
-                        )
-                        
-                        batch_cfg_scale = gr.Slider(
-                            label="CFG Scale",
-                            minimum=1.0,
-                            maximum=10.0,
-                            value=3.0,
-                            step=0.5
-                        )
-                        
-                        batch_use_auto_length = gr.Checkbox(
-                            label="Auto-estimate length for NA",
-                            value=True
-                        )
-                        
-                        batch_gpu_id = gr.Number(
-                            label="GPU ID",
-                            value=0,
-                            precision=0
-                        )
-                        
-                        batch_seed = gr.Number(
-                            label="Random Seed",
-                            value=3407,
-                            precision=0
-                        )
-                        
-                        batch_generate_btn = gr.Button("Generate Batch", variant="primary", size="lg")
-                    
-                    with gr.Column(scale=1):
-                        batch_status_output = gr.Textbox(
-                            label="Batch Status",
-                            lines=15,
-                            interactive=False
-                        )
-                        batch_video_gallery = gr.Gallery(
-                            label="Generated Motions",
-                            show_label=True,
-                            elem_id="gallery",
-                            columns=2,
-                            rows=2,
-                            height="auto",
-                            type="filepath"  # Explicitly specify filepath type
-                        )
-                
-                batch_generate_btn.click(
-                    fn=generate_motion_batch,
-                    inputs=[batch_text_input, batch_cfg_scale, batch_use_auto_length, batch_gpu_id, batch_seed],
-                    outputs=[batch_video_gallery, batch_status_output]
-                )
+            # Batch Generation Tab - COMMENTED OUT
+            # with gr.Tab("Batch Generation"):
+            #     with gr.Row():
+            #         with gr.Column(scale=1):
+            #             batch_text_input = gr.Textbox(
+            #                 label="Text Prompts (one per line, format: text#length or text#NA)",
+            #                 placeholder="A person is running on a treadmill.#120\nSomeone is doing jumping jacks.#NA",
+            #                 lines=10,
+            #                 info="Each line: 'text#length' or 'text#NA' for auto-estimate"
+            #             )
+            #             
+            #             batch_cfg_scale = gr.Slider(
+            #                 label="CFG Scale",
+            #                 minimum=1.0,
+            #                 maximum=10.0,
+            #                 value=3.0,
+            #                 step=0.5
+            #             )
+            #             
+            #             batch_use_auto_length = gr.Checkbox(
+            #                 label="Auto-estimate length for NA",
+            #                 value=True
+            #             )
+            #             
+            #             batch_gpu_id = gr.Number(
+            #                 label="GPU ID",
+            #                 value=0,
+            #                 precision=0
+            #             )
+            #             
+            #             batch_seed = gr.Number(
+            #                 label="Random Seed",
+            #                 value=3407,
+            #                 precision=0
+            #             )
+            #             
+            #             batch_generate_btn = gr.Button("Generate Batch", variant="primary", size="lg")
+            #         
+            #         with gr.Column(scale=1):
+            #             batch_status_output = gr.Textbox(
+            #                 label="Batch Status",
+            #                 lines=15,
+            #                 interactive=False
+            #             )
+            #             batch_video_gallery = gr.Gallery(
+            #                 label="Generated Motions",
+            #                 show_label=True,
+            #                 elem_id="gallery",
+            #                 columns=2,
+            #                 rows=2,
+            #                 height="auto",
+            #                 type="filepath"  # Explicitly specify filepath type
+            #             )
+            #     
+            #     batch_generate_btn.click(
+            #         fn=generate_motion_batch,
+            #         inputs=[batch_text_input, batch_cfg_scale, batch_use_auto_length, batch_gpu_id, batch_seed],
+            #         outputs=[batch_video_gallery, batch_status_output]
+            #     )
             
             # Model Management Tab
             with gr.Tab("Model Management"):